[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-22 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736367#comment-17736367
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/23/23 6:53 AM:
---

Yes the id is beginning with 0. That is a "bug" in a sense that I was not aware 
that the id starts with one if the viewstate is server rendered we can change 
that easily, that must be done on all branches. I can do that at the weekend!

PS: Another possible solution would be to include the viewstate nevertheless in 
the form response that way the Viewstate in the update tag would only update 
the embedded ViewState. But that would need a small server side fix someone 
else has to perform. From the js code perspective, it makes no difference

a) No Viewstate element, the element is added at the last processing step

b) Viewstate element present in the form, only the value is updated with the 
one coming in from the tag, then also the id would not change compared to the 
embedded one.

These are the two cases which must be supported as per spec, afair.

I am not entirely sure how Mojarra behaves for this case, I guess we should be 
in sync with their response xml patterns here!

 

 

 

 


was (Author: werpu):
Yes the id is beginning with 0. That is a "bug" in a sense that I was not aware 
that the id starts with one if the viewstate is server rendered we can change 
that easily, that must be done on all branches. I can do that at the weekend!

Does not change the fact that the id can change from one response to the other 
hence you always should rely on the viewstate in the id or viewstate as name 
which is always permanent for viewstate element detection never on a permanent 
id.

(but that also can happen during server side rendering theoretically)

I will change that at the weekend accordingly. The rest I see as no bug and 
works as expected, if you all can agree as well (gave the explanation already)

PS: Another possible solution would be to include the viewstate nevertheless in 
the form response that way the viewstate in the viestate update tag would only 
update the embedded viewstate. But that would need a small server side fix 
someone else has to perform. From the js code it makes no difference

a) No Viewstate element, the element is added at the last processing step

b) Viewstate element present in the form, only the value is updated with the 
one coming in from the tag, then also the id would not change compared to the 
embedded one.

If you want to implement this option then we have 2 viewstate definitions in 
the response but also the advantage of server side id control!

Either option is fine the 0->1 fix must be added anyway, the other option wont 
break the js code!

I am not entirely sure how Mojarra behaves for this case, I guess we should be 
in sync with their response pattern here!

 

 

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-22 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736367#comment-17736367
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/23/23 6:51 AM:
---

Yes the id is beginning with 0. That is a "bug" in a sense that I was not aware 
that the id starts with one if the viewstate is server rendered we can change 
that easily, that must be done on all branches. I can do that at the weekend!

Does not change the fact that the id can change from one response to the other 
hence you always should rely on the viewstate in the id or viewstate as name 
which is always permanent for viewstate element detection never on a permanent 
id.

(but that also can happen during server side rendering theoretically)

I will change that at the weekend accordingly. The rest I see as no bug and 
works as expected, if you all can agree as well (gave the explanation already)

PS: Another possible solution would be to include the viewstate nevertheless in 
the form response that way the viewstate in the viestate update tag would only 
update the embedded viewstate. But that would need a small server side fix 
someone else has to perform. From the js code it makes no difference

a) No Viewstate element, the element is added at the last processing step

b) Viewstate element present in the form, only the value is updated with the 
one coming in from the tag, then also the id would not change compared to the 
embedded one.

If you want to implement this option then we have 2 viewstate definitions in 
the response but also the advantage of server side id control!

Either option is fine the 0->1 fix must be added anyway, the other option wont 
break the js code!

I am not entirely sure how Mojarra behaves for this case, I guess we should be 
in sync with their response pattern here!

 

 

 

 


was (Author: werpu):
Yes the id is beginning with 0. That is a "bug" in a sense that I was not aware 
that the id starts with one if the viewstate is server rendered we can change 
that easily, that must be done on all branches. I can do that at the weekend!

Does not change the fact that the id can change from one response to the other 
hence you always should rely on the viewstate in the id or viewstate as name 
which is always permanent for viewstate element detection never on a permanent 
id.

(but that also can happen during server side rendering theoretically)

I will change that at the weekend accordingly. The rest I see as no bug and 
works as expected, if you all can agree as well (gave the explanation already)

PS: Another possible solution would be to include the viewstate nevertheless in 
the form response that way the viewstate in the viestate update tag would only 
update the embedded viewstate. But that would need a small server side fix 
someone else has to perform. From the js code it makes no difference

a) No Viewstate element, the element is added at the last processing step

b) Viewstate element present in the form, only the value is updated with the 
one coming in from the tag, then also the id would not change compared to the 
embedded one.

If you want to implement this option then we have 2 viewstate definitions in 
the response but also the advantage of server side id control!

Either option is fine the 0->1 fix must be added anyway, the other option wont 
break the js code!

 

 

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-22 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736367#comment-17736367
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/23/23 6:49 AM:
---

Yes the id is beginning with 0. That is a "bug" in a sense that I was not aware 
that the id starts with one if the viewstate is server rendered we can change 
that easily, that must be done on all branches. I can do that at the weekend!

Does not change the fact that the id can change from one response to the other 
hence you always should rely on the viewstate in the id or viewstate as name 
which is always permanent for viewstate element detection never on a permanent 
id.

(but that also can happen during server side rendering theoretically)

I will change that at the weekend accordingly. The rest I see as no bug and 
works as expected, if you all can agree as well (gave the explanation already)

PS: Another possible solution would be to include the viewstate nevertheless in 
the form response that way the viewstate in the viestate update tag would only 
update the embedded viewstate. But that would need a small server side fix 
someone else has to perform. From the js code it makes no difference

a) No Viewstate element, the element is added at the last processing step

b) Viewstate element present in the form, only the value is updated with the 
one coming in from the tag, then also the id would not change compared to the 
embedded one.

If you want to implement this option then we have 2 viewstate definitions in 
the response but also the advantage of server side id control!

Either option is fine the 0->1 fix must be added anyway, the other option wont 
break the js code!

 

 

 

 


was (Author: werpu):
Yes the id is beginning with 0. That is a "bug" in a sense that I was not aware 
that the id starts with one if the viewstate is server rendered we can change 
that easily, that must be done on all branches. I can do that at the weekend!

Does not change the fact that the id can change from one response to the other 
hence you always should rely on the viewstate in the id or viewstate as name 
which is always permanent for viewstate element detection never on a permanent 
id.

(but that also can happen during server side rendering theoretically)

I will change that at the weekend accordingly. The rest I see as no bug and 
works as expected, if you all can agree as well (gave the explanation already)

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-21 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735918#comment-17735918
 ] 

Volodymyr Siedlecki edited comment on MYFACES-4605 at 6/21/23 10:29 PM:


Looks like the new viewstate id is caused by

    _fetchUniqueId: function(prefix, identifier) {
        var cnt = 0;
        var retVal = prefix + identifier + jsf.separatorchar + cnt;
        while(this._Dom.byId(retVal) != null)

{             cnt++;             retVal = prefix + identifier + 
jsf.separatorchar + cnt;         }

        return retVal;
    },

The count starts at 0, and the evaluation sees that 0 is available, so it uses 
it.

The Java code starts the id with 1 :
{color:#dcdcaa}see HtmlResponseStateManager{color}

        if (count == null)
       

{             count = Integer.valueOf(0);         }

        count += 1;


I think we should keep this consistent and have both start with 0 or 1?  
Otherwise, I agree with Werner. We just need a unique id, per the spec, and we 
do.


was (Author: volosied):
Looks like the new viewstate id is caused by 

    _fetchUniqueId: function(prefix, identifier) {
        var cnt = 0;
        var retVal = prefix + identifier + jsf.separatorchar + cnt;
        while(this._Dom.byId(retVal) != null) {
            cnt++;
            retVal = prefix + identifier + jsf.separatorchar + cnt;
        }
        return retVal;
    },

The count starts at 0, and the evaluation sees that 0 is available, so it uses 
it. 


The Java code starts the id with 1 :
{color:#dcdcaa}HtmlResponseStateManager{color}

        if (count == null)
        {
            count = Integer.valueOf(0);
        }
        count += 1;

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-21 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735435#comment-17735435
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/21/23 2:01 PM:
---

Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder















 {code}
The test runs 100 times an alternative click either click1 or click2

and then processes the ajax response:

!image-2023-06-20-21-22-50-593.png|width=661,height=159!

 

In the end I am getting a properly updated viewstate which is identical on both 
forms.

The behavor looks correct to me! I also walked through the code, the viewstate 
of the executing form is updated as well as the viewstate of the forms in the 
render area.

This is correct behavior, as per spec!

Testcase was run against 

MyFaces 3.0.3-SNAPSHOT

Can you give me a concrete example where your code fails?

As far as I can see the behavior is correct according to the spec (even takes 
the viewroot id into consideration in the code), but I might have missed 
something here.


was (Author: werpu):
Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder















 {code}
The test runs 100 times an alternative click either click1 or click2

and then processes the ajax response:

!image-2023-06-20-21-22-50-593.png|width=661,height=159!

 

In the end I am getting a properly updated viewstate which is identical on both 
forms.

The behavor looks correct to me! I also walked through the code, the viewstate 
of the executing form is updated as well as the viewstate of the forms in the 
render area.

This is correct behavior, as per spec!

Testcase was run against 

MyFaces 3.0.3-SNAPSHOT

Can you give me a concrete example where your code fails?

As far as I can see the behavior is correct according to the spec (even takes 
the viewroot id into consideration in the code), but I might have missed 
something here.

 

 

 

 

 

 

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-20 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735435#comment-17735435
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/20/23 8:00 PM:
---

Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder















 {code}
The test runs 100 times an alternative click either click1 or click2

and then processes the ajax response:

!image-2023-06-20-21-22-50-593.png|width=661,height=159!

 

In the end I am getting a properly updated viewstate which is identical on both 
forms.

The behavor looks correct to me! I also walked through the code, the viewstate 
of the executing form is updated as well as the viewstate of the forms in the 
render area.

This is correct behavior, as per spec!

Testcase was run against 

MyFaces 3.0.3-SNAPSHOT

Can you give me a concrete example where your code fails?

As far as I can see the behavior is correct according to the spec (even takes 
the viewroot id into consideration in the code), but I might have missed 
something here.

 

 

 

 

 

 

 

 


was (Author: werpu):
Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder















 {code}
The test runs 100 times an alternative click either click1 or click2

and then processes the ajax response:

!image-2023-06-20-21-22-50-593.png|width=661,height=159!

 

In the end I am getting a properly updated viewstate which is identical on both 
forms.

Testcase was run against 

MyFaces 3.0.3-SNAPSHOT

Can you give me a concrete example where your code fails?

As far as I can see the behavior is correct according to the spec (even takes 
the viewroot id into consideration in the code), but I might have missed 
something here.

 

 

 

The behavor looks correct to me! I also walked through the code, the viewstate 
of the executing form is updated as well as the viewstate of the forms in the 
render area.

This is correct behavior, as per spec!

 

 

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-20 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735435#comment-17735435
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/20/23 7:59 PM:
---

Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder















 {code}
The test runs 100 times an alternative click either click1 or click2

and then processes the ajax response:

!image-2023-06-20-21-22-50-593.png|width=661,height=159!

 

In the end I am getting a properly updated viewstate which is identical on both 
forms.

Testcase was run against 

MyFaces 3.0.3-SNAPSHOT

Can you give me a concrete example where your code fails?

As far as I can see the behavior is correct according to the spec (even takes 
the viewroot id into consideration in the code), but I might have missed 
something here.

 

 

 

The behavor looks correct to me! I also walked through the code, the viewstate 
of the executing form is updated as well as the viewstate of the forms in the 
render area.

This is correct behavior, as per spec!

 

 

 

 


was (Author: werpu):
Mhh I tried it in my integration testsuite by altering my multiform test:
{code:java}
// code placeholder















 {code}
The test runs 100 times an alternative click either click1 or click2

and then processes the ajax response:

!image-2023-06-20-21-22-50-593.png|width=661,height=159!

 

In the end I am getting a properly updated viewstate which is identical on both 
forms.

The behavor looks correct to me! I also walked through the code, the viewstate 
of the executing form is updated as well as the viewstate of the forms in the 
render area.

This is correct behavior, as per spec!

 

 

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-15 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733216#comment-17733216
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/15/23 8:07 PM:
---

I am starting now to work on it, expect a fix early/mid next week.

The fix should be as per spec, not the hack we had in 2.2!

(which was older than the solution in the spec)


was (Author: werpu):
I am starting now to work on it, expect a fix early/mid next week.

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-14 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732725#comment-17732725
 ] 

Werner Punz edited comment on MYFACES-4605 at 6/14/23 7:46 PM:
---

Sorry for the delay, I will start with this issue tomorrow, this bug should 
only affect the 2.3 and 3.0 versions of the code, 4.0 definitely does not have 
it, I spent a ton of time on 4.0 to get this right and spec conform in the new 
typescript codebase!

Cross form submit I think either was introduced in 2.2 or 2.3 cannot remember 
anymore (aka have to look that up)!

Before that we had a config parameter which enforced that the forms were all 
updated at once!

 


was (Author: werpu):
Sorry for the delay, I will start with this issue tomorrow, this bug should 
only affect the 2.3 and 3.0 versions of the code, 4.0 definitely does not have 
it, I spent a ton of time on 4.0 to get this right and spec conform!

Cross form submit I think either was introduced in 2.2 or 2.3 cannot remember 
anymore (aka have to look that up)!

Before that we had a config parameter which enforced that the forms were all 
updated at once!

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-05-30 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727596#comment-17727596
 ] 

Werner Punz edited comment on MYFACES-4605 at 5/30/23 8:05 PM:
---

I will have a look on it on Thursday, I assume it only is broken for MyFaces 
3.x but not for the new codebase in 4.0, given the mentioned TCK passes there.

JSF 2.3 and 3.0 share the same core Ajax codebase, 4.0 is the breaking point 
where we applied the new codebase. So yes a fix for 3.0 can and will be merged 
back into 2.x!

 

 


was (Author: werpu):
I will have a look on it on Thursday, I assume it only is broken for MyFaces 
3.x but not for the new codebase in 4.0, given the mentioned TCK passes there.

JSF 2.3 and 3.0 share the same Ajax codebase, 4.0 is the breaking point where 
we applied the new codebase. So yes a fix for 3.0 can and will be merged back 
into 2.x!

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-05-30 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727596#comment-17727596
 ] 

Werner Punz edited comment on MYFACES-4605 at 5/30/23 8:04 PM:
---

I will have a look on it on Thursday, I assume it only is broken for MyFaces 
3.x but not for the new codebase in 4.0, given the mentioned TCK passes there.

JSF 2.3 and 3.0 share the same Ajax codebase, 4.0 is the breaking point where 
we applied the new codebase. So yes a fix for 3.0 can and will be merged back 
into 2.x!

 

 


was (Author: werpu):
I will have a look on it on Thursday, I assume it only is broken for MyFaces 
3.x but not for the new codebase in 4.0, given the mentioned TCK passes there.

 

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-05-30 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727596#comment-17727596
 ] 

Werner Punz edited comment on MYFACES-4605 at 5/30/23 8:03 PM:
---

I will have a look on it on Thursday, I assume it only is broken for MyFaces 
3.x but not for the new codebase in 4.0, given the mentioned TCK passes there.

 

 


was (Author: werpu):
I will have a look on it on Thursday, I assume it only is broken for MyFaces 
3.x but not for the new codebase in 4.0!

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-05-30 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727576#comment-17727576
 ] 

Volodymyr Siedlecki edited comment on MYFACES-4605 at 5/30/23 3:19 PM:
---

I agree with Melloware. Looks like there's a TCK app here: 
[https://github.com/jakartaee/faces/blob/1d71aae51f7d5ae684a3f43db0521b7e7e6aa4f6/tck/faces23/ajax/src/main/webapp/spec790.xhtml]

You have may worked on it via MYFACES-4511?   
[https://github.com/apache/myfaces/pull/403/files]


was (Author: volosied):
I agree with Melloware. Looks like there's a TCK app here: 
[https://github.com/jakartaee/faces/blob/1d71aae51f7d5ae684a3f43db0521b7e7e6aa4f6/tck/faces23/ajax/src/main/webapp/spec790.xhtml]

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Joe Crichton
>Priority: Major
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)