[jira] [Commented] (MYFACES-4030) MyFaces CDI support is disabled if non-CDI application is loaded first
[
https://issues.apache.org/jira/browse/MYFACES-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145338#comment-15145338
]
Bill Lucy commented on MYFACES-4030:
I've gone ahead and committed the patch - thanks for providing this, Hank. I
didn't change the log message; we can continue to discuss that here, if
necessary.
> MyFaces CDI support is disabled if non-CDI application is loaded first
> --
>
> Key: MYFACES-4030
> URL: https://issues.apache.org/jira/browse/MYFACES-4030
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.10-SNAPSHOT
> Environment: WebSphere Liberty 8.5.5.8, Weld 2.3, MyFaces 2.2.8
>Reporter: Hank Ibell
>Assignee: Bill Lucy
>Priority: Minor
> Fix For: 2.2.10-SNAPSHOT
>
> Attachments: myfaces-4030.patch
>
>
> If MyFaces 2.2 is loaded at the server level, MyFaces CDI support is set once
> per server. This causes CDI-enabled JSF applications to not work properly if
> a non-CDI application is loaded first.
> {panel:title=Steps to reproduce the error on WebSphere
> Liberty|bgColor=#e8e8e8}
> 1. Enable the jsf-2.2 and cdi-1.2 features on the WebSphere Liberty server.
> 2. Deploy two JSF applications: one that uses CDI (e.g. a flow built using
> FlowBuilder) and one that does not use CDI.
> 3. Make a request to the non-CDI application first. The message 'MyFaces CDI
> support disabled' should be written to the logs.
> 4. Make a request to the CDI-enabled application. If testing an application
> with a flow built using FlowBuilder, the flow will not be discovered.
> {panel}
> I've investigated the issue and found that MyFaces has two conditions to
> determine CDI availability:
> 1. CDI must be found on the classpath
> 2. The application map must have a bean manager instance
> (Found inside
> org.apache.myfaces.util.ExternalSpecifications#isCDIAvailable()).
> When MyFaces is shared between different applications, basing CDI
> availability on an application's configuration (condition two) is an issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MYFACES-4030) MyFaces CDI support is disabled if non-CDI application is loaded first
[
https://issues.apache.org/jira/browse/MYFACES-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145425#comment-15145425
]
Leonardo Uribe commented on MYFACES-4030:
-
On the release procedure all issues are moved to 2.2.10, but I have changed it
anyway.
> MyFaces CDI support is disabled if non-CDI application is loaded first
> --
>
> Key: MYFACES-4030
> URL: https://issues.apache.org/jira/browse/MYFACES-4030
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.10-SNAPSHOT
> Environment: WebSphere Liberty 8.5.5.8, Weld 2.3, MyFaces 2.2.8
>Reporter: Hank Ibell
>Assignee: Bill Lucy
>Priority: Minor
> Fix For: 2.2.10
>
> Attachments: myfaces-4030.patch
>
>
> If MyFaces 2.2 is loaded at the server level, MyFaces CDI support is set once
> per server. This causes CDI-enabled JSF applications to not work properly if
> a non-CDI application is loaded first.
> {panel:title=Steps to reproduce the error on WebSphere
> Liberty|bgColor=#e8e8e8}
> 1. Enable the jsf-2.2 and cdi-1.2 features on the WebSphere Liberty server.
> 2. Deploy two JSF applications: one that uses CDI (e.g. a flow built using
> FlowBuilder) and one that does not use CDI.
> 3. Make a request to the non-CDI application first. The message 'MyFaces CDI
> support disabled' should be written to the logs.
> 4. Make a request to the CDI-enabled application. If testing an application
> with a flow built using FlowBuilder, the flow will not be discovered.
> {panel}
> I've investigated the issue and found that MyFaces has two conditions to
> determine CDI availability:
> 1. CDI must be found on the classpath
> 2. The application map must have a bean manager instance
> (Found inside
> org.apache.myfaces.util.ExternalSpecifications#isCDIAvailable()).
> When MyFaces is shared between different applications, basing CDI
> availability on an application's configuration (condition two) is an issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MYFACES-4030) MyFaces CDI support is disabled if non-CDI application is loaded first
[
https://issues.apache.org/jira/browse/MYFACES-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145414#comment-15145414
]
Thomas Andraschko commented on MYFACES-4030:
shoudln't "fix versions" target 2.2.10 instead of 2.2.10-SNAPSOT?
> MyFaces CDI support is disabled if non-CDI application is loaded first
> --
>
> Key: MYFACES-4030
> URL: https://issues.apache.org/jira/browse/MYFACES-4030
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.10-SNAPSHOT
> Environment: WebSphere Liberty 8.5.5.8, Weld 2.3, MyFaces 2.2.8
>Reporter: Hank Ibell
>Assignee: Bill Lucy
>Priority: Minor
> Fix For: 2.2.10-SNAPSHOT
>
> Attachments: myfaces-4030.patch
>
>
> If MyFaces 2.2 is loaded at the server level, MyFaces CDI support is set once
> per server. This causes CDI-enabled JSF applications to not work properly if
> a non-CDI application is loaded first.
> {panel:title=Steps to reproduce the error on WebSphere
> Liberty|bgColor=#e8e8e8}
> 1. Enable the jsf-2.2 and cdi-1.2 features on the WebSphere Liberty server.
> 2. Deploy two JSF applications: one that uses CDI (e.g. a flow built using
> FlowBuilder) and one that does not use CDI.
> 3. Make a request to the non-CDI application first. The message 'MyFaces CDI
> support disabled' should be written to the logs.
> 4. Make a request to the CDI-enabled application. If testing an application
> with a flow built using FlowBuilder, the flow will not be discovered.
> {panel}
> I've investigated the issue and found that MyFaces has two conditions to
> determine CDI availability:
> 1. CDI must be found on the classpath
> 2. The application map must have a bean manager instance
> (Found inside
> org.apache.myfaces.util.ExternalSpecifications#isCDIAvailable()).
> When MyFaces is shared between different applications, basing CDI
> availability on an application's configuration (condition two) is an issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MYFACES-4030) MyFaces CDI support is disabled if non-CDI application is loaded first
[
https://issues.apache.org/jira/browse/MYFACES-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139739#comment-15139739
]
Bill Lucy commented on MYFACES-4030:
The patch here looks good, and given the WebSphere scenario this change makes
sense. If there aren't any objections I think this is a safe change to make.
As far as the logging goes, I agree that's a bit misleading. (Again, just
taking the WebSphere scenario into account.) I'd be fine with making that
change too.
> MyFaces CDI support is disabled if non-CDI application is loaded first
> --
>
> Key: MYFACES-4030
> URL: https://issues.apache.org/jira/browse/MYFACES-4030
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.10-SNAPSHOT
> Environment: WebSphere Liberty 8.5.5.8, Weld 2.3, MyFaces 2.2.8
>Reporter: Hank Ibell
>Priority: Minor
> Attachments: myfaces-4030.patch
>
>
> If MyFaces 2.2 is loaded at the server level, MyFaces CDI support is set once
> per server. This causes CDI-enabled JSF applications to not work properly if
> a non-CDI application is loaded first.
> {panel:title=Steps to reproduce the error on WebSphere
> Liberty|bgColor=#e8e8e8}
> 1. Enable the jsf-2.2 and cdi-1.2 features on the WebSphere Liberty server.
> 2. Deploy two JSF applications: one that uses CDI (e.g. a flow built using
> FlowBuilder) and one that does not use CDI.
> 3. Make a request to the non-CDI application first. The message 'MyFaces CDI
> support disabled' should be written to the logs.
> 4. Make a request to the CDI-enabled application. If testing an application
> with a flow built using FlowBuilder, the flow will not be discovered.
> {panel}
> I've investigated the issue and found that MyFaces has two conditions to
> determine CDI availability:
> 1. CDI must be found on the classpath
> 2. The application map must have a bean manager instance
> (Found inside
> org.apache.myfaces.util.ExternalSpecifications#isCDIAvailable()).
> When MyFaces is shared between different applications, basing CDI
> availability on an application's configuration (condition two) is an issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
