[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740879#comment-17740879 ] Werner Punz commented on MYFACES-4610: -- The old code is not affected by it, I did the determination of the origin slightly different there in my fix, am not sure which approach is better, but for now the changes I will do in the old branches are just fixing the id issue so that it starts with a 1 instead of 0 in the identifier number postfix for hidden fields. (the second issue which was discussed recently) > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739604#comment-17739604 ] Volodymyr Siedlecki commented on MYFACES-4610: -- Thank you for fixing it in main. Let me know if I can help with the other branches. > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737968#comment-17737968 ] Werner Punz commented on MYFACES-4610: -- Pull request merged for main (Myfaces 4.0), other branches will follow the upcoming days > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737813#comment-17737813 ] Werner Punz commented on MYFACES-4610: -- have issued a pull request which soon will be merged, will issue fixes for the 2.x branches in the upcoming days! > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737688#comment-17737688 ] Werner Punz commented on MYFACES-4610: -- The issue here is indeed the fix we added recently that a key value pair of the issuing element is added. The problem here is that the issuing element has the same id (the virtual element tobago-select-many-checkbox but has no value, to make matters worse the embedded real inputs have the same name as the input elements id: Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737019#comment-17737019 ] Werner Punz commented on MYFACES-4610: -- I also will add the fix discussed in MYFACES-4605 for starting the id with a counter of 1 in the fix for this issue, to avoid too many commits! > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install 4. cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)