[jira] [Commented] (MYFACES-985) UIData with multihierarchical children inside produces NPE

2011-07-22 Thread Leonardo Uribe (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069636#comment-13069636
 ] 

Leonardo Uribe commented on MYFACES-985:


Doing some performance improvements I notice this old issue. Basically, the 
code proposed is invalid, but just for reference I'll explain what's going on 
in this case.

The general problem is about when it is valid to add components in JSF inside a 
dataTable. In theory, UIData.setRowIndex do the following:

1. If the component is in row -1 (no row), take a snapshot of the components 
that implements 

EditableValueHolder, to restore them later when rows are traversed.
2. If the component is in a row, save the current state of EditableValueHolder 
components.
3. Move to the selected row.
4. If no state saved found, restore EditableValueHolder components from saved 
initial state.
5. If state saved found, restore EditableValueHolder components from stored 
saved state.

The algorithm ignores all transient components, because they don't have state 
(for example, t:inputCalendar uses a transient input component when popup mode 
is enabled). The problem happens when a user try to create  inside a renderer a 
component that is EditableValueHolder and is not transient. In the moment the 
snapshot is created, the component does not exists, so the initial state 
cannot be created and the algorithm will fail. 

I ignore the reasons why Mojarra code works, but I believe that is not 
intentional. In JSF 2.1, full row component state was added to UIData, and the 
same principle applies, but in that case the restriction applies to all 
components. Note transient component are ignored too. 

The problem is adding a non transient EditableValueHolder component inside a 
dataTable row leads to a illegal state, because the initial state is unknown.

In JSF 2.0 and upper the most standard way to add a component as structure of 
other component is use a custom component facelet tag handler. In t:dataTable, 
this hack is used for detailStampRow and ajaxRowRender features. Also, 
PostAddToViewEvent can be used to modify the component tree, because it occur 
before markInitialState, so UIData rowStatePreserved will work well, and PSS 
algorithm will deal with it gracefully.

I'll close this issue as invalid, because everything that can be done for solve 
this issue was already done, and the reasons why does not work are completely 
understood.

 UIData with multihierarchical children inside produces NPE
 --

 Key: MYFACES-985
 URL: https://issues.apache.org/jira/browse/MYFACES-985
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
 Environment: Tomcat 5.0
 JDK 1.4
Reporter: Andrew Kharchenko 
Assignee: Mathias Broekelmann
 Fix For: 2.0.0

 Attachments: UIData NPE Sample.rar


 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-06 Thread Mathias Broekelmann (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361951 
] 

Mathias Broekelmann commented on MYFACES-985:
-

I will leave this issue open since it is working on Sun´s RI.

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-06 Thread Mathias Broekelmann (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361950 
] 

Mathias Broekelmann commented on MYFACES-985:
-

You could also use the rendered attribute to switch on or off rendering a 
component. 

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-06 Thread Andrew Kharchenko (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361953 
] 

Andrew Kharchenko  commented on MYFACES-985:


OK. Thanx for advice.

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Mathias Broekelmann (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361830 
] 

Mathias Broekelmann commented on MYFACES-985:
-

what version of myfaces do you use?

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Mathias Broekelmann (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361832 
] 

Mathias Broekelmann commented on MYFACES-985:
-

You are modifying the component tree by removing a component while rendering 
the children, which is the problem. 
Why do you need to remove a component child in the renderer?

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Andrew Kharchenko (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361836 
] 

Andrew Kharchenko  commented on MYFACES-985:


I'm just trying to avoid multiple adding of the same children. OK, this is the 
way to check children presence in component tree and do not add it again. I'll 
try to implement my component in such way but still I'm not sure it will help.

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Andrew Kharchenko (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361838 
] 

Andrew Kharchenko  commented on MYFACES-985:


As I said, I've replaced this part of code in renderer:


for (Iterator iterator = children.iterator(); iterator.hasNext();) {
  UIComponent child = (UIComponent) iterator.next();
  if (child instanceof UIInputTestComponent) {
children.remove(child);
break;
  }
}
  UIInputTestComponent itc = (UIInputTestComponent) 
context.getApplication().createComponent(UIInputTestComponent.COMPONENT_TYPE);
  itc.setId(component.getId() + _id);
  itc.setNeedChildren(false);
  children.add(itc);


with this one: 



boolean isPresent = false;
for (Iterator iterator = children.iterator(); iterator.hasNext();) {
  UIComponent child = (UIComponent) iterator.next();
  if (child instanceof UIInputTestComponent) {
isPresent = true;
break;
  }
}
if (!isPresent) {
  UIInputTestComponent itc = (UIInputTestComponent) 
context.getApplication().createComponent(UIInputTestComponent.COMPONENT_TYPE);
  itc.setId(component.getId() + _id);
  itc.setNeedChildren(false);
  children.add(itc);
}


but it still has the same effect :(


 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Mathias Broekelmann (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361840 
] 

Mathias Broekelmann commented on MYFACES-985:
-

You are still modifing the component tree while rendering.
Why don´t you add your component in the the base component when it is created?

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Andrew Kharchenko (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361845 
] 

Andrew Kharchenko  commented on MYFACES-985:


Do you mean in the component's constructor? Is it good style?

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Mathias Broekelmann (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361866 
] 

Mathias Broekelmann commented on MYFACES-985:
-

Can you explain what you want to achieve with your component?

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Andrew Kharchenko (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361941 
] 

Andrew Kharchenko  commented on MYFACES-985:


Oh, just forgot. I want to notice again, that behaviour in the attached sample 
project works fine under Sun RI.

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-985) UIData with multihierarchical children inside produces NPE

2006-01-05 Thread Andrew Kharchenko (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-985?page=comments#action_12361940 
] 

Andrew Kharchenko  commented on MYFACES-985:


Attached component is just a sample. The real component is a DateChooser which 
consists with text field, button and popup calendar. DateChooser is extended 
from UIInput and has popup panel (UIPanel extentor) as child. For one's turn, 
popup panel has Calendar (UIInput extentor) as child. That's all.

In addition, I've tried to move children addition to component's constructor 
from component's renderer and it helped. So, I think this request can be 
resolved. Thanx.

 UIData with multihierarchical children inside produces NPE
 --

  Key: MYFACES-985
  URL: http://issues.apache.org/jira/browse/MYFACES-985
  Project: MyFaces
 Type: Bug
   Components: Implementation
  Environment: Tomcat 5.0
 JDK 1.4
 Reporter: Andrew Kharchenko 
 Assignee: Mathias Broekelmann
  Attachments: UIData NPE Sample.rar

 I've found incorrect UIData behaviour under MyFaces which produces 
 NullPointerException on runtime and which works fine under Sun implementation.
 Here it is:
 I have a custom component which is extentor from UIInput. This component has 
 UIPanel extentor component as child which is added to children list of 
 UIInput component on rendering. 
 For one's turn, UIPanel extentor has one more UIInput extentor component as 
 child which is added to children list of UIPanel component on rendering.
 This component works fine standalone, but when it is added to UIData, I have 
 NPE on runtime. Here is the part of listing:
 java.lang.NullPointerException
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:223)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at 
 javax.faces.component.UIData.restoreDescendantComponentStates(UIData.java:235)
  at javax.faces.component.UIData.setRowIndex(UIData.java:178)
 I will also attach sample component's classes, definitions and test page if 
 it will be granted after issue creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira