Re: StartupServletContextListener in tomhawk-sandbox-examples web.xml but not in examples-simple web.xml
On 2/25/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: But I added the listener to your archetype, because of I added the Jetty6 plugin for mvn. So calling jetty:run will start the container and deploy the sample app, without getting that error message ;-) How hard would it be for you to add jetty:run to the tomahawk and sandbox examples? Also, according to Greg of Jetty, the TLD listeners should be picked up by default in Jetty 6, so the web.xml file listener entry isn't needed for Jetty 6.
Re: StartupServletContextListener in tomhawk-sandbox-examples web.xml but not in examples-simple web.xml
Lets remove from sandbox to be consistent. +1 But I added the listener to your archetype, because of I added the Jetty6 plugin for mvn. So calling jetty:run will start the container and deploy the sample app, without getting that error message ;-) -Matthias On 2/24/06, Mike Kienenberger [EMAIL PROTECTED] wrote: We have inconsistently defined a listener entry in the tomahawk-sandbox-examples web.xml file but not in the myfaces-example-simple web.xml file. listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener I found out because sandbox examples work as-is with jetty 5.1.8, but the simple examples do not. I'm guessing we want to remove the listener declaration from sandbox. I wouldn't be opposed to adding it to simple, though :) I'm guessing it's problematic to have the listener defined in both the tld file and the web.xml file on most containers, but I don't know for sure. -Mike -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: StartupServletContextListener in tomhawk-sandbox-examples web.xml but not in examples-simple web.xml
Lets remove from sandbox to be consistent. On 2/24/06, Mike Kienenberger [EMAIL PROTECTED] wrote: We have inconsistently defined a listener entry in the tomahawk-sandbox-examples web.xml file but not in the myfaces-example-simple web.xml file. listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener I found out because sandbox examples work as-is with jetty 5.1.8, but the simple examples do not. I'm guessing we want to remove the listener declaration from sandbox. I wouldn't be opposed to adding it to simple, though :) I'm guessing it's problematic to have the listener defined in both the tld file and the web.xml file on most containers, but I don't know for sure. -Mike
Re: StartupServletContextListener
That's good news! Bruno 2005/7/27, Martin Marinschek [EMAIL PROTECTED]: A discussion Matze and I had at the ApacheCon was with the Atanion people about the StartupServletContextListener. There was one Webcontainer who screwed up if you added the StartupServletContextListener to the TLD file directly - apparently, this issue has been resolved in the last version of this container (it was Weblogic, I think). So we might finally be able to get rid of adding the Listener to the web.xml file and might be able to add it to the TLD instead. regards, Martin
RE: StartupServletContextListener
Woo Hoo!!! Uh, I mean +1. Whatever. J Stan Silvert JBoss, Inc. [EMAIL PROTECTED] callto://stansilvert From: Martin Marinschek [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 11:43 AM To: MyFaces Development Subject: StartupServletContextListener A discussion Matze and I had at the ApacheCon was with the Atanion people about the StartupServletContextListener. There was one Webcontainer who screwed up if you added the StartupServletContextListener to the TLD file directly - apparently, this issue has been resolved in the last version of this container (it was Weblogic, I think). So we might finally be able to get rid of adding the Listener to the web.xml file and might be able to add it to the TLD instead. regards, Martin
Re: StartupServletContextListener
That will be really popular with people currently using the RI and wanting to try out MyFaces, since that's the way the RI does it. you are talking about your build scripts, isn't it ? :) But, sure this solution will be fine to people, since they don't see any differences between RI and MyFaces. That is a common point. I often hear MyFaces needs a ContextListener, but RI doesn't -Matthias regards, Martin Craig -- Matthias Wessendorf
Re: StartupServletContextListener
On 7/27/05, Matthias Wessendorf [EMAIL PROTECTED] wrote: That will be really popular with people currently using the RI and wanting to try out MyFaces, since that's the way the RI does it. you are talking about your build scripts, isn't it ? :) But of course! :-) The Ant hacks (for Shale) that I'm using to conditionally add the listener work ... but they have the disadvantage of making the source code of the web.xml file not be valid XML, which NetBeans whines about. Craig But, sure this solution will be fine to people, since they don't see any differences between RI and MyFaces. That is a common point. I often hear MyFaces needs a ContextListener, but RI doesn't -Matthias regards, Martin Craig -- Matthias Wessendorf
Re: StartupServletContextListener
We should add a JIRA issue on this so that when its closed, it will be part of the release notes. Also, the release notes for this release should come right out of JIRA. Its simple to generate them this way. sean On 7/27/05, Craig McClanahan [EMAIL PROTECTED] wrote: On 7/27/05, Matthias Wessendorf [EMAIL PROTECTED] wrote: That will be really popular with people currently using the RI and wanting to try out MyFaces, since that's the way the RI does it. you are talking about your build scripts, isn't it ? :) But of course! :-) The Ant hacks (for Shale) that I'm using to conditionally add the listener work ... but they have the disadvantage of making the source code of the web.xml file not be valid XML, which NetBeans whines about. Craig But, sure this solution will be fine to people, since they don't see any differences between RI and MyFaces. That is a common point. I often hear MyFaces needs a ContextListener, but RI doesn't -Matthias regards, Martin Craig -- Matthias Wessendorf
Re: StartupServletContextListener
did just that... regards, MartinOn 7/27/05, Sean Schofield [EMAIL PROTECTED] wrote: We should add a JIRA issue on this so that when its closed, it will bepart of the release notes.Also, the release notes for this releaseshould come right out of JIRA.Its simple to generate them this way. seanOn 7/27/05, Craig McClanahan [EMAIL PROTECTED] wrote: On 7/27/05, Matthias Wessendorf [EMAIL PROTECTED] wrote: That will be really popular with people currently using the RI and wanting to try out MyFaces, since that's the way the RI does it. you are talking about your build scripts, isn't it ? :) But of course!:-) The Ant hacks (for Shale) that I'm using to conditionally add the listener work ... but they have the disadvantage of making the source code of the web.xml file not be valid XML, which NetBeans whines about. Craig But, sure this solution will be fine to people, since they don't see any differences between RI and MyFaces. That is a common point. I often hear MyFaces needs a ContextListener, but RI doesn't -Matthiasregards, Martin Craig -- Matthias Wessendorf
