Re: [PR] Make the UUID Converter Implicit [myfaces]
volosied merged PR #700: URL: https://github.com/apache/myfaces/pull/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4662) Update FaceletViewDeclarationLanguageStrategy to look at exact mappings to the Faces Servlet
[
https://issues.apache.org/jira/browse/MYFACES-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841343#comment-17841343
]
Volodymyr Siedlecki commented on MYFACES-4662:
--
5.0: https://github.com/apache/myfaces/pull/709
> Update FaceletViewDeclarationLanguageStrategy to look at exact mappings to
> the Faces Servlet
>
>
> Key: MYFACES-4662
> URL: https://issues.apache.org/jira/browse/MYFACES-4662
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 4.0.0, 4.1.0-RC1
>Reporter: Volodymyr Siedlecki
>Priority: Major
>
> While investigating the 4.1 TCK tests, a 404 was returned for some pages in
> the headAndBodyRenderer app. Only the `*.xhtml` extensions worked even though
> the servlet mappings were listed:
> web.xml:
> {code:java}
>
> facesServlet
>
>
> facesServlet
> *.xhtml
> *.xhtmlAsXhtml
> *.xhtmlAsXml
> {code}
> Turns out that our FaceletViewDeclarationLanguageStrategy class looked if
> *.xhtml matched, and if not, then it looked at any mappings set via
> jakarta.faces.FACELETS_VIEW_MAPPINGS. This isn't set in the app. Ultimately,
> FaceletViewDeclarationLanguageStrategy#handlesView returns false and since no
> VDL is found, the page fails to load.
> [https://github.com/apache/myfaces/blob/7f6fefb4b05ccf5272e6907397954f7d4db8f4d2/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguageStrategy.java#L62-L76
>
> |https://github.com/jakartaee/faces/tree/4.1/tck/faces41/headAndBodyRenderer/src/main/webapp]
> I think we should update the code to look at the servlet mappings, too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4664) Update Faces To Address 4.1 TCK Failures
[ https://issues.apache.org/jira/browse/MYFACES-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841344#comment-17841344 ] Volodymyr Siedlecki commented on MYFACES-4664: -- Spec 1760 in 4.1: [https://github.com/apache/myfaces/pull/708] rowStatePreserved in 4.1: [https://github.com/apache/myfaces/pull/701] UUID Converter Implicit in 4.1: https://github.com/apache/myfaces/pull/700 > Update Faces To Address 4.1 TCK Failures > > > Key: MYFACES-4664 > URL: https://issues.apache.org/jira/browse/MYFACES-4664 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 4.1.0-RC1, 5.0.0 >Reporter: Volodymyr Siedlecki >Priority: Major > > Creating a single Jira to cover the 3 issues below: > - Make the UUID Converter Implicit > - > [https://github.com/jakartaee/faces/blob/4.1/tck/faces41/uuidConverter/src/test/java/org/eclipse/ee4j/tck/faces/faces41/uuidConverter/Spec1819IT.java#L38] > - Fix up rowStatePreserved in UIRepeat > - > [https://github.com/jakartaee/faces/blob/4.1/tck/faces41/uiRepeat/src/test/java/org/eclipse/ee4j/tck/faces/faces41/uiRepeat/Spec1263IT.java#L33] > - Implement Spec 1760 > - [https://github.com/jakartaee/faces/issues/1760] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Apply MYFACES-4662 & MYFACES-4664 to 5.0 [myfaces]
volosied merged PR #709: URL: https://github.com/apache/myfaces/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MYFACES-4664) Update Faces To Address 4.1 TCK Failures
Volodymyr Siedlecki created MYFACES-4664: Summary: Update Faces To Address 4.1 TCK Failures Key: MYFACES-4664 URL: https://issues.apache.org/jira/browse/MYFACES-4664 Project: MyFaces Core Issue Type: Bug Affects Versions: 4.1.0-RC1, 5.0.0 Reporter: Volodymyr Siedlecki Creating a single Jira to cover the 3 issues below: - Make the UUID Converter Implicit - [https://github.com/jakartaee/faces/blob/4.1/tck/faces41/uuidConverter/src/test/java/org/eclipse/ee4j/tck/faces/faces41/uuidConverter/Spec1819IT.java#L38] - Fix up rowStatePreserved in UIRepeat - [https://github.com/jakartaee/faces/blob/4.1/tck/faces41/uiRepeat/src/test/java/org/eclipse/ee4j/tck/faces/faces41/uiRepeat/Spec1263IT.java#L33] - Implement Spec 1760 - [https://github.com/jakartaee/faces/issues/1760] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Fix up rowStatePreserved in UIRepeat [myfaces]
volosied merged PR #701: URL: https://github.com/apache/myfaces/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]
volosied merged PR #708: URL: https://github.com/apache/myfaces/pull/708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Main updates [myfaces]
volosied opened a new pull request, #709: URL: https://github.com/apache/myfaces/pull/709 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MYFACES-4664) Update Faces To Address 4.1 TCK Failures
[ https://issues.apache.org/jira/browse/MYFACES-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Siedlecki resolved MYFACES-4664. -- Resolution: Fixed > Update Faces To Address 4.1 TCK Failures > > > Key: MYFACES-4664 > URL: https://issues.apache.org/jira/browse/MYFACES-4664 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 4.1.0-RC1, 5.0.0 >Reporter: Volodymyr Siedlecki >Priority: Major > > Creating a single Jira to cover the 3 issues below: > - Make the UUID Converter Implicit > - > [https://github.com/jakartaee/faces/blob/4.1/tck/faces41/uuidConverter/src/test/java/org/eclipse/ee4j/tck/faces/faces41/uuidConverter/Spec1819IT.java#L38] > - Fix up rowStatePreserved in UIRepeat > - > [https://github.com/jakartaee/faces/blob/4.1/tck/faces41/uiRepeat/src/test/java/org/eclipse/ee4j/tck/faces/faces41/uiRepeat/Spec1263IT.java#L33] > - Implement Spec 1760 > - [https://github.com/jakartaee/faces/issues/1760] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Make the UUID Converter Implicit [myfaces]
tandraschko commented on PR #700: URL: https://github.com/apache/myfaces/pull/700#issuecomment-2080021874 Please dont forget the master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix up rowStatePreserved in UIRepeat [myfaces]
tandraschko commented on PR #701: URL: https://github.com/apache/myfaces/pull/701#issuecomment-2080022233 Please dont forget the master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make the UUID Converter Implicit [myfaces]
volosied commented on PR #700: URL: https://github.com/apache/myfaces/pull/700#issuecomment-2080023702 Updates to main were all done here in one PR: https://github.com/apache/myfaces/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release of MyFaces Core 4.10-RC2
+1 Melloware @melloware on GitHub > On Apr 26, 2024, at 4:54 PM, Volodymyr Siedlecki wrote: > > > Hi, > > I was running the needed tasks to get the 4.1.0-RC2 release of Apache > MyFaces core out. > > Please note that this vote concerns all of the following parts: >1. Maven artifact group “org.apache.myfaces.core” v4.1.0-RC2 [1] > > The artifacts were deployed on nexus repo [1] for binary and source > packages. > > The release notes could be found at [4]. > > The japicmp tool shows no binary incompatibilities with 4.1.0-RC1. > Please take a look at the attached results.html. > > This release has not yet been run against the TCK. > > Please take a look at the “4.1.0-RC2" artifacts and vote! (see [3]) > > Please note: This vote is “majority approval” with a minimum of three +1 > votes (see [2]). > > > [ ] +1 for community members who have reviewed the bits > [ ] +0 > [ ] -1 for fatal flaws that should cause these bits not to be released, and > why. > > > Thanks, > > Volodymyr > > [1] > https://repository.apache.org/content/repositories/orgapachemyfaces-1247/org/apache/myfaces/core/ > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes > [3] > https://repository.apache.org/content/repositories/orgapachemyfaces-1247/org/apache/myfaces/core/myfaces-core-assembly/ > [4] > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12354226 >
