[GitHub] [mynewt-documentation] utzig commented on pull request #98: Add more rust target explanations

2020-06-09 Thread GitBox


utzig commented on pull request #98:
URL: 
https://github.com/apache/mynewt-documentation/pull/98#issuecomment-640906930


   > Why did you change the TARGET variable? Did you test that value? It 
doesn't seem to build for me, but I could do something wrong.
   
   I had tested it on another MCU which is also Cortex-M4, but now I did on 
nrf52840 as well and it works. I updated this PR so that the shell script 
auto-detects which Cortex type is being used and sets the proper TARGET.
   
   > If you do want to change it, you should change the `rustup` command as 
well.
   
   Done (in a way!).
   
   Why don't you submit a PR to https://github.com/apache/mynewt-core adding a 
new app, say `rust-blinky`? That would make it easier to colaborate then 
working on documentation! :-P
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [mynewt-documentation] utzig commented on pull request #98: Add more rust target explanations

2020-06-04 Thread GitBox


utzig commented on pull request #98:
URL: 
https://github.com/apache/mynewt-documentation/pull/98#issuecomment-638981202


   /cc @caspermeijn 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org