Re: [VOTE] Release Apache NetBeans Language Server 12.5.301 VSCode Extension

2021-10-16 Thread Matthias Bläsing
+1 (binding)

- Verified SHA512 and Signature
- Contents of source zip matches the reporitoy state
- Eyeballed LICENSE and NOTICE files
- Build from source
- the binary was not tested!

There seems to be a build problem with recent versions of npm.
PrepareBundles.java tries to find licenses for all "modules" in the
node_modules and does this by iterating over all childs of that
directory. It seems npm in version 7.5.2 creates a file ".package-
lock.json", which fails to resolve to a license file. I had to patch
the PrepareBundles.java by handling the special case:

# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- a/PrepareBundles
+++ b/PrepareBundles.java
@@ -101,6 +101,10 @@
 try (DirectoryStream ds = 
Files.newDirectoryStream(packagesDir.resolve("node_modules"));
 Writer binariesList = new 
OutputStreamWriter(Files.newOutputStream(bundlesDir.resolve("binaries-list")), 
"UTF-8")) {
 for (Path module : ds) {
+if(! Files.isDirectory(module)) {
+continue;
+}
+
 if (".bin".equals(module.getFileName().toString())) continue;
 if ("@types".equals(module.getFileName().toString())) continue;
 if ("@ungap".equals(module.getFileName().toString())) {



Am Donnerstag, dem 14.10.2021 um 07:31 + schrieb Martin Balin:
> Dear community, 
> let's update the Apache NetBeans Language Server extension on VSCode 
> Marketplace 
> https://marketplace.visualstudio.com/items?itemName=ASF.apache-netbeans-java 
> to significantly improved version 12.5.301.
> 
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/
> 
> The primary voting artifact is the source
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301-src.zip
> with SHA-512 sum: 
> 11b460cfaa8d98f9612320c0040e7f928d0b6af904427ad92867ef64c5df3ec7d12192b3980e10f04e15033d0f5ddd57ec0cdda3bdec8c706be541b8f722ff13
>   
> and PGP signature: 
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301-src.zip.asc
> 
> The artifacts have been generated by 
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/650/ from git 
> revision b19730846d986575f26b3b70236d2142dde18157
> 
> Use following commands to build your own 12.5.301 VSIX  binary:
> 
> tmp$ unzip apache-netbeans-java-12.5.301-src.zip
> 
> tmp$ ant build 
> -Dmetabuild.jsonurl=https://raw.githubusercontent.com/JaroslavTulach/netbeans-jenkins-lib/jtulach/vsnetbeans_preview_1253/meta/netbeansrelease.json
> 
> tmp$ cd java/java.lsp.server
> 
> java.lsp.server$ ant build-vscode-ext -Dvsix.version=12.5.301 
> -D3rdparty.modules=.*nbjavac.*
> 
> The special netbeansrelease.json is needed now (and was used in build job 
> #650) due to pending PR to netbeans-jenkins-lib 
> https://github.com/apache/netbeans-jenkins-lib/pull/35
> 
> In addition to the source ZIP file, we are also voting about convenience 
> binary: 
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301.vsix
> with SHA512  checksum:
> ed94506362a3f6add8e3cd6f4f50f94178d761701001045158ee9d2a7935136fe706ff8a3e3c6c04be2b2feb422e72219959435ddec93c512cfb79ca3b30108b
>  
> and
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301.vsix.asc
>  PGP signature.
>  
> The binary has been produced by the same job run #650, from the same commit. 
> 
> This vote is going to be open at least 72 hours, vote with +1, 0, and -1 as 
> usual. Please mark your vote with (binding) if you're an Apache NetBeans PMC 
> member.
> 
> Thank you,
> Martin Balín
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
> 
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> 
> 
> 



-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Using test distribution & Apache's Jenkins pipelines

2021-10-16 Thread Eric Bresie
Would having some sort of "test matrix" to show where different parts of
build testing is currently (i.e. some current done in GA, is travis, in
jenkins) be worth wild?

Eric Bresie
ebre...@gmail.com


On Tue, Oct 12, 2021 at 11:41 PM Jaroslav Tulach 
wrote:

> Dne čtvrtek 7. října 2021 18:36:29 CEST, Michael Bien napsal(a):
> > On 07.10.21 08:30, Jaroslav Tulach wrote:
> > >> So, what specifically needs to be done?
> > >
> > > #1 from my perspective: We need support for build pipelines. In
> particular
> > >
> > > ```
> > > var ide = buildIDEZip();
> > > var testDist = buildTestDistributionZip();
> > >
> > > var moduleSet = [ "platform", "ide", "hints1", "hints2" ];
> > > var jdkSet = [ "jdk8", "jdk11", "jdk17", "jdk-latest" ];
> > >
> > > new ForkJoinPool("many parallel executors") (module, jdk) {
> > >
> > > setup jdk
> > >
> > > unzip ide
> > > unzip testDist
> > >
> > > teste module
> > >
> > > }
> > > ```
> > >
> > > Can that be implemented (easily) in Travis? Not likely. Can that be
> > > implemented easily in GitHub actions (that'd be great, but I doubt).
> >
> > i think one way of doing this with gh actions is to zip the build and
> > upload it as artifact. Subsequent jobs in the pipeline would use that
> > artifact and continue from there.
> >
> >
> https://docs.github.com/en/actions/learn-github-actions/essential-features-o
> > f-github-actions#sharing-data-between-jobs
> >
> > having artifacts would also mitigate the issue of being able to access
> > test results, if they don't end up in the console for whatever reason.
>
> It would be great to reconfigure the GitHub actions to do the build of IDE
> ZIP
> and test distribution ZIP only once.
> -jt
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>


Re: LSP Language Server Protocol

2021-10-16 Thread Eric Bresie
I've started to add comments on the page taken from many mailing list
threads in hopes these can be edited together and make it into the page
proper at some point.

There are suggested items needed for a new language, references to specs,
references to existing text mate grammers, LSP implementations, etc.

See what you think.

Eric Bresie
ebre...@gmail.com


On Sat, Oct 16, 2021 at 9:49 AM Eric Bresie  wrote:

> While looking on the wiki, I noticed the following.
>
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Adding+New+Language+Support
>
> Perhaps discussions of writing a tutorial can be added to this to help the
> community.
>
> Eric Bresie
> ebre...@gmail.com
>
>
> On Fri, Oct 8, 2021 at 7:45 AM Eric Bresie  wrote:
>
>> Follow up question…
>>
>> Assume the LSP is for language editing mainly but how do linking with a
>> given compiler and/or run type action get handled?
>>
>> Assume there may be need to handle setting up instances of a given
>> languages compiler/runtime so where is this setup?
>>
>> Depending on the language assume there may be need for additional
>> plug-in/module management support (i.e. node module, Python pips, etc.).
>> Or would this be in someway some kind of dependency handling functionality
>> for the language?
>>
>> If in the past there was an older implementations for a given language,
>> is it better to start over, to convert over to an LSP based merging code
>> when possible or just maintain the existing updating to current standards?
>> Assume this depends on the implemented language but figure I’d add as an
>> extra step to start porting languages.
>>
>> On Fri, Oct 8, 2021 at 7:34 AM Eric Bresie  wrote:
>>
>>> I’ve seen the tutorial and appreciated the context, but was curious if
>>> more generalized perspective can be expanded on as this is a specific
>>> implementation.  Some of the following may be implied by the article
>>> indirectly but wanted to confirm it here as well.
>>>
>>> It talks about setting up a node.js bash LSP server.  So in general,
>>> does each language need some sort of equivalent LSP Server ?  Or does the
>>> provided LSP in Netbeans work well enough to support other languages?
>>>
>>> Assume if a server is not available then one may need to be
>>> implemented.  Assume to do this would require compliance with LSP interface
>>> of some type and if so where can this be found?  Is there interface defined
>>> in Netbeans which can be extended or implemented from?
>>>
>>> If an server is available how should that be brought in?  Add a
>>> dependency which gets pulled in with maybe some wrapper layer having it?
>>>
>>> In what context does the “server” get started up/loaded within
>>> Netbeans?  Are there specific triggers to start it (i.e. when working on a
>>> specific file type of the given language, if the language support is
>>> “active”, at startup, or some other trigger)?
>>>
>>> I seem to recall in the preference section there is the ability to
>>> define an LSP support.  How does this interact with the new language
>>> implemented here?  In other words, does something have to be defined and
>>> added so that it includes in that area?  Does the user have to manually
>>> define that (I would hope not but maybe initially) and link up the LSP?
>>>
>>> How is the grammar (tm) linked up?  Is that supported by the server or
>>> does the server link to the external grammar?  So if there is an “external
>>> implemented server”, does this mean limited or no coverage of the grammar
>>> would have to be considered?
>>>
>>> What client interfaces need to be implemented and where are they
>>> defined?  Does the client also need knowledge of the grammar in some way?
>>>
>>> Assume the “mime-type” may need to be based on standardized ‘mime-types”
>>> for a given language.  Is there a sources to use to get these
>>> “mime-types”?  Can always google but if there is someplace already
>>> established with these to base on that may also help some.
>>>
>>>
>>> On Thu, Oct 7, 2021 at 1:18 AM Jaroslav Tulach <
>>> jaroslav.tul...@gmail.com> wrote:
>>>
 >- LSP  seems to be gaining ground, but
 there
 >are no tutorials, apart from Jan Lahoda's rudimental one
 >.


 Why do you call the tutorial "rudimental"? The tutorial is short, but
 it
 contains grammar, syntax coloring, and LSP server. E.g. everything.
 Shouldn't
 you rather call the tutorial "end-to-end" guide for integrating
 languages into
 NetBeans via LSP?

 -jt

 PS: The only question is why people don't follow the tutorial and
 create a new
 PR with a new language integration per week?




 -
 To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
 For additional commands, e-mail: dev-h...@netbeans.apache.org

 For 

Re: LSP Language Server Protocol

2021-10-16 Thread Eric Bresie
While looking on the wiki, I noticed the following.

https://cwiki.apache.org/confluence/display/NETBEANS/Adding+New+Language+Support

Perhaps discussions of writing a tutorial can be added to this to help the
community.

Eric Bresie
ebre...@gmail.com


On Fri, Oct 8, 2021 at 7:45 AM Eric Bresie  wrote:

> Follow up question…
>
> Assume the LSP is for language editing mainly but how do linking with a
> given compiler and/or run type action get handled?
>
> Assume there may be need to handle setting up instances of a given
> languages compiler/runtime so where is this setup?
>
> Depending on the language assume there may be need for additional
> plug-in/module management support (i.e. node module, Python pips, etc.).
> Or would this be in someway some kind of dependency handling functionality
> for the language?
>
> If in the past there was an older implementations for a given language, is
> it better to start over, to convert over to an LSP based merging code when
> possible or just maintain the existing updating to current standards?
> Assume this depends on the implemented language but figure I’d add as an
> extra step to start porting languages.
>
> On Fri, Oct 8, 2021 at 7:34 AM Eric Bresie  wrote:
>
>> I’ve seen the tutorial and appreciated the context, but was curious if
>> more generalized perspective can be expanded on as this is a specific
>> implementation.  Some of the following may be implied by the article
>> indirectly but wanted to confirm it here as well.
>>
>> It talks about setting up a node.js bash LSP server.  So in general, does
>> each language need some sort of equivalent LSP Server ?  Or does the
>> provided LSP in Netbeans work well enough to support other languages?
>>
>> Assume if a server is not available then one may need to be implemented.
>> Assume to do this would require compliance with LSP interface of some type
>> and if so where can this be found?  Is there interface defined in Netbeans
>> which can be extended or implemented from?
>>
>> If an server is available how should that be brought in?  Add a
>> dependency which gets pulled in with maybe some wrapper layer having it?
>>
>> In what context does the “server” get started up/loaded within Netbeans?
>> Are there specific triggers to start it (i.e. when working on a specific
>> file type of the given language, if the language support is “active”, at
>> startup, or some other trigger)?
>>
>> I seem to recall in the preference section there is the ability to define
>> an LSP support.  How does this interact with the new language implemented
>> here?  In other words, does something have to be defined and added so that
>> it includes in that area?  Does the user have to manually define that (I
>> would hope not but maybe initially) and link up the LSP?
>>
>> How is the grammar (tm) linked up?  Is that supported by the server or
>> does the server link to the external grammar?  So if there is an “external
>> implemented server”, does this mean limited or no coverage of the grammar
>> would have to be considered?
>>
>> What client interfaces need to be implemented and where are they
>> defined?  Does the client also need knowledge of the grammar in some way?
>>
>> Assume the “mime-type” may need to be based on standardized ‘mime-types”
>> for a given language.  Is there a sources to use to get these
>> “mime-types”?  Can always google but if there is someplace already
>> established with these to base on that may also help some.
>>
>>
>> On Thu, Oct 7, 2021 at 1:18 AM Jaroslav Tulach 
>> wrote:
>>
>>> >- LSP  seems to be gaining ground, but
>>> there
>>> >are no tutorials, apart from Jan Lahoda's rudimental one
>>> >.
>>>
>>>
>>> Why do you call the tutorial "rudimental"? The tutorial is short, but it
>>> contains grammar, syntax coloring, and LSP server. E.g. everything.
>>> Shouldn't
>>> you rather call the tutorial "end-to-end" guide for integrating
>>> languages into
>>> NetBeans via LSP?
>>>
>>> -jt
>>>
>>> PS: The only question is why people don't follow the tutorial and create
>>> a new
>>> PR with a new language integration per week?
>>>
>>>
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
>>> For additional commands, e-mail: dev-h...@netbeans.apache.org
>>>
>>> For further information about the NetBeans mailing lists, visit:
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>
>>>
>>>
>>> --
>> Eric Bresie
>> ebre...@gmail.com
>>
> --
> Eric Bresie
> ebre...@gmail.com
>


Re: [VOTE] Release Apache NetBeans Language Server 12.5.301 VSCode Extension

2021-10-16 Thread Svata Dedic

+1 (binding)

* ZIP and VSIX sha-checked, signatures verified
* built from sources (OK), installed into vscode (OK)
* used as an editor for several hours
* basic run / debug / stop at breakpoint works

Ubuntu 19.04 / KDE / JDK8+11

-S.

Dne 14. 10. 21 v 9:31 Martin Balin napsal(a):

Dear community,
let's update the Apache NetBeans Language Server extension on VSCode 
Marketplace 
https://marketplace.visualstudio.com/items?itemName=ASF.apache-netbeans-java to 
significantly improved version 12.5.301.

https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/

The primary voting artifact is the source
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301-src.zip
with SHA-512 sum:
11b460cfaa8d98f9612320c0040e7f928d0b6af904427ad92867ef64c5df3ec7d12192b3980e10f04e15033d0f5ddd57ec0cdda3bdec8c706be541b8f722ff13
and PGP signature:
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301-src.zip.asc

The artifacts have been generated by
https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/650/ from git 
revision b19730846d986575f26b3b70236d2142dde18157

Use following commands to build your own 12.5.301 VSIX  binary:

tmp$ unzip apache-netbeans-java-12.5.301-src.zip

tmp$ ant build 
-Dmetabuild.jsonurl=https://raw.githubusercontent.com/JaroslavTulach/netbeans-jenkins-lib/jtulach/vsnetbeans_preview_1253/meta/netbeansrelease.json

tmp$ cd java/java.lsp.server

java.lsp.server$ ant build-vscode-ext -Dvsix.version=12.5.301 
-D3rdparty.modules=.*nbjavac.*

The special netbeansrelease.json is needed now (and was used in build job #650) 
due to pending PR to netbeans-jenkins-lib 
https://github.com/apache/netbeans-jenkins-lib/pull/35

In addition to the source ZIP file, we are also voting about convenience binary:
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301.vsix
with SHA512  checksum:
ed94506362a3f6add8e3cd6f4f50f94178d761701001045158ee9d2a7935136fe706ff8a3e3c6c04be2b2feb422e72219959435ddec93c512cfb79ca3b30108b
and
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301.vsix.asc
 PGP signature.
  
The binary has been produced by the same job run #650, from the same commit.


This vote is going to be open at least 72 hours, vote with +1, 0, and -1 as 
usual. Please mark your vote with (binding) if you're an Apache NetBeans PMC 
member.

Thank you,
Martin Balín
-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists






-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists