[GitHub] nifi pull request: NIFI-1520 by default skip javadoc/source jar ge...
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/234#issuecomment-185541846 applies clean to support/nifi-0.5.x and master. running through a test release:prepare and release:perform to verify correct behavior with those plugins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1520 by default skip javadoc/source jar ge...
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/234#issuecomment-185538294 reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1520 by default skip javadoc/source jar ge...
GitHub user joewitt opened a pull request: https://github.com/apache/nifi/pull/234 NIFI-1520 by default skip javadoc/source jar generation in nars/wars You can merge this pull request into a Git repository by running: $ git pull https://github.com/joewitt/incubator-nifi NIFI-1520 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/234.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #234 commit b51aff6d4cf2b1ef9e4c9b592b398e09ff8a24cb Author: joewittDate: 2016-02-18T04:25:11Z NIFI-1520 by default skip javadoc and source jar generation in nars and wars --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [DISCUSS] NiFi 0.5.1 release
+1 On Wed, Feb 17, 2016 at 10:12 PM, Tony Kurcwrote: > All, > Just so we're clear, my expectations is that the fixes we need above will > go into master (0.6.0-SNAPSHOT). I (or the contributor) will attempt to > also apply those fixes to a branch I made off of nifi-0.5.0, called > "support/nifi-0.5.x", and when done we can test and when satisfied, start > the 0.5.1 release process. > > > On Wed, Feb 17, 2016 at 8:28 PM, Tony Kurc wrote: > >> I lieu of a decision on a git branching strategy, does anyone object to me >> naming a branch "support/0.5.x" so I can start pulling together 0.5.1? >> >> On Wed, Feb 17, 2016 at 8:17 PM, Joe Witt wrote: >> >>> Team, >>> >>> First, congrats on getting 0.5.0 out the door. Very nice release with >>> excellent new features, enhancements, and bug fixes with involvement >>> of many new contributors. >>> >>> The effort toward 0.6.0 is well underway and if we are shooting for >>> our original target would still arrive around mid march-ish. Seems >>> reasonable given progress so far. >>> >>> That said, I'd like to propose we go ahead and put out an 0.5.1 as >>> soon as the patches are addressed. The finding that Lars helped >>> expose and that Mark Payne is now working [1] in my view warrants a >>> release by itself as it is data loss related. Also, we can address >>> the work Matt Gilman is doing to ensure properly authorized users can >>> access resources they're being blocked by [2] and the license/notice >>> findings Sean discovered during the last release [3]. There are a >>> couple odd/ends in the list as well [4]. Purely a bug fix release as >>> spec'd out in release notes [5]. >>> >>> I checked with Tony and he is happy to continue performing RM tasks on >>> the 0.5.x line. >>> >>> [1] https://issues.apache.org/jira/browse/NIFI-1527 >>> [2] https://issues.apache.org/jira/browse/NIFI-1497 >>> [3] https://issues.apache.org/jira/browse/NIFI-1520 >>> [4] https://s.apache.org/nifi-0.5.1-candidate >>> [5] https://cwiki.apache.org/confluence/display/NIFI/Release+Notes >>> >>> Thanks >>> Joe >>> >> >>
[GitHub] nifi pull request: NIFI-1063
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[DISCUSS] NiFi 0.5.1 release
Team, First, congrats on getting 0.5.0 out the door. Very nice release with excellent new features, enhancements, and bug fixes with involvement of many new contributors. The effort toward 0.6.0 is well underway and if we are shooting for our original target would still arrive around mid march-ish. Seems reasonable given progress so far. That said, I'd like to propose we go ahead and put out an 0.5.1 as soon as the patches are addressed. The finding that Lars helped expose and that Mark Payne is now working [1] in my view warrants a release by itself as it is data loss related. Also, we can address the work Matt Gilman is doing to ensure properly authorized users can access resources they're being blocked by [2] and the license/notice findings Sean discovered during the last release [3]. There are a couple odd/ends in the list as well [4]. Purely a bug fix release as spec'd out in release notes [5]. I checked with Tony and he is happy to continue performing RM tasks on the 0.5.x line. [1] https://issues.apache.org/jira/browse/NIFI-1527 [2] https://issues.apache.org/jira/browse/NIFI-1497 [3] https://issues.apache.org/jira/browse/NIFI-1520 [4] https://s.apache.org/nifi-0.5.1-candidate [5] https://cwiki.apache.org/confluence/display/NIFI/Release+Notes Thanks Joe
[ANNOUNCE] Apache NiFi 0.5.0 release
Hello, The Apache NiFi team would like to announce the release of Apache NiFi 0.5.0. Apache NiFi is an easy to use, powerful, and reliable system to process and distribute data. Apache NiFi was made for dataflow. It supports highly configurable directed graphs of data routing, transformation, and system mediation logic. More details on Apache NiFi can be found here: http://nifi.apache.org/ The release artifacts can be downloaded from here: http://nifi.apache.org/download.html Maven artifacts have been made available here: https://repository.apache.org/content/repositories/releases/org/apache/nifi/ 106 issues were closed/resolved for this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020=12334158 Release note highlights can be found here: https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version0.5.0 Migration guidance here: https://cwiki.apache.org/confluence/display/NIFI/Migration+Guidance Thank you The Apache NiFi team
Re: FlowFiles missing (MissingFlowFileException)
Mark, Joe, thanks a lot for investigating, reproducing and explaining what's going on, I couldn't have done that. I built the 0.5.0 RC3 version from the git commit mentioned and haven't changed a single configuration property. I hadn't even heard of archiving so far. Just looked at the properties to be safe and archiving is enabled and threshold is set to 50%. My local disk is definitely more than 50% utilised. Had the archive worked would it have been a manual process to recover the data? It looks like you've got it covered but if there's anything else I can do to help let me know. Lars On Wed, Feb 17, 2016 at 8:16 PM, Mark Paynewrote: > Lars, > > Joe is correct - i felt a need for coffee before trying to identify the > exact case > that will cause this issue to occur :) > > I created a ticket for this issue here: > https://issues.apache.org/jira/browse/NIFI-1527 < > https://issues.apache.org/jira/browse/NIFI-1527> > > I share your opinion that the funnel is not related. Rather, I believe the > issue has to do > with swapping of data. NiFi has a mechanism for swapping out FlowFiles to > disk, rather > than leaving them all in memory (here we are talking about the FlowFile > objects, which > contains things of attributes. The content is already written to disk and > not kept in memory). > > With the default settings, this happens if at least 30,000 FlowFiles exist > in the same queue. > In this case, upon restart, if all of the FlowFiles that reference a > specific "content file" on disk > are swapped out, the Content Repository will end up removing or archiving > that data. If the > archive is disabled or full, the repository will end up removing it. I > believe this is what you saw. > I believe the content was removed on restart because all FlowFiles that > referenced it were > swapped out. > > Please confirm what Joe asked below: that you either disabled archiving or > that your disk is > at least 50% full (or that you changed that configuration parameter in > conf/nifi.properties). > > We will certainly be addressing this issue very promptly. A huge thank you > for noticing the weirdness > and bringing it to our attention and for providing such great details! > > -Mark > > > > On Feb 17, 2016, at 1:48 PM, Joe Witt wrote: > > > > Lars, > > > > First of all thank you very much for reporting this and providing the > > detail you did. > > > > Mark Payne just replicated the problem it sounds like then rather than > > emailing he decided to go get coffee :-). > > > > We will be working this up for very prompt resolution and it warrants > > a release in my view. > > > > Can you confirm that you are either not using archiving or you are > > using it and you have more than 50% of space on the partition nifi is > > running used up? > > > > I'll let Mark share the details. > > > > Thanks > > Joe > > > > On Wed, Feb 17, 2016 at 4:06 AM, Lars Francke > wrote: > >> It seems as if the Funnel thing wasn't actually the problem. > >> > >> Here's my new timeline: > >> > >> 18:14... - Stop Processors > >> 18:15:40 - Shutdown NiFi (graceful and successful) > >> 18:28:03 - Starting NiFi which seemingly deletes content > >> 18:31++ - Add Funnel etc. and start Processors again (so only now do I > see > >> the problem occurring even though it probably would have happened > without > >> it as well) > >> > >> I've uploaded the relevant part of the log here < > >> http://pastebin.com/6XWP5SVF> > >> > >> All processors involved are custom processors but they don't do anything > >> special and have been running for days and survived multiple restarts > >> already. I can't share code now but if it becomes important I can strip > >> them to a bare minimum and share. > >> > >> So when the failure happened it was even easier: CustomSourceProcessor > was > >> connected to CustomDestinationProcessor via a normal connection. > >> > >> Thanks yet again for helping out everyone! > >> > >> On Wed, Feb 17, 2016 at 5:04 AM, Aldrin Piri > wrote: > >> > >>> Lars, > >>> > >>> Are you able to share your flow or a template of it so we can try to > >>> recreate? > >>> > >>> If not, could you give some information as to what it is doing and what > >>> processors/components are involved. Are there any custom components? > >>> > >>> Thanks! > >>> > >>> On Tue, Feb 16, 2016 at 10:18 PM, Joe Witt wrote: > >>> > 'that deletes the original file' > > True but even then that refers to the original source data and not > what it is in the content repository itself. The content repository > error that was emitted about missing flow file exception/content not > found is for the purpose of signaling data was removed by some process > outside of NiFi. > > Mark Payne: Any ideas? > > On Tue, Feb 16, 2016 at 10:15 PM, Thad Guidry > wrote: > > There's a
[GitHub] nifi pull request: NIFI-1252
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Set default yield duration
Every Processor's configuration should have 4 tabs (settings, scheduling, properties, and comments). You can adjust the yield duration from the settings tab and the run schedule from the scheduling tab. Matt On Wed, Feb 17, 2016 at 1:19 AM, Adam Lamarwrote: > Hey everyone, > > I've been working on a processor that yields often, and the default yield > duration of 1 second is too short. Is there any way to change this default > for a specific processor only? > > Alternatively, can the run schedule default duration be changed in a > similar way? > > Cheers, > Adam >
Re: Set default yield duration
I think it is a good idea to allow a processor to establish what are reasonable defaults for itself then let users tune it as they can today. Definitely a good JIRA to fire up. On Wed, Feb 17, 2016 at 9:30 AM, Bryan Bendewrote: > Adam, > > I think the idea was for the user to always control these values through > the user interface, and therefore there isn't a way that I know of for a > specific processor to control the default values for yield duration and run > schedule. > > I have always wanted to be able to do this though, specifically for the run > schedule. The main scenario is a "Get" processor that is going to poll an > external system and extract data. In this case, a run schedule of 0 seconds > is almost never the desired value, and if a user runs the processor > forgetting to change the duration, they start killing the external system. > > Curious to hear what others think. > > -Bryan > > > On Wed, Feb 17, 2016 at 1:19 AM, Adam Lamar wrote: > >> Hey everyone, >> >> I've been working on a processor that yields often, and the default yield >> duration of 1 second is too short. Is there any way to change this default >> for a specific processor only? >> >> Alternatively, can the run schedule default duration be changed in a >> similar way? >> >> Cheers, >> Adam >>
Re: Set default yield duration
Adam, I think the idea was for the user to always control these values through the user interface, and therefore there isn't a way that I know of for a specific processor to control the default values for yield duration and run schedule. I have always wanted to be able to do this though, specifically for the run schedule. The main scenario is a "Get" processor that is going to poll an external system and extract data. In this case, a run schedule of 0 seconds is almost never the desired value, and if a user runs the processor forgetting to change the duration, they start killing the external system. Curious to hear what others think. -Bryan On Wed, Feb 17, 2016 at 1:19 AM, Adam Lamarwrote: > Hey everyone, > > I've been working on a processor that yields often, and the default yield > duration of 1 second is too short. Is there any way to change this default > for a specific processor only? > > Alternatively, can the run schedule default duration be changed in a > similar way? > > Cheers, > Adam >
Re: nifi question
Hello, Could you share a screenshot. Also, which web browser (and version) are you using ? Finally, which version of NiFi? Thanks JOe On Wed, Feb 17, 2016 at 10:24 AM, yonatan kebedewrote: > hi, > i am new to nifi and have got problems on the UI, that its not displaying > the icons on top of the processors and also in the connections/relations, > it was working in windows 8 but when i update it to win 10 , sth like this > happen? > > what do you think is the problem? or any helpis appreciated > > Regards, > > Yonatan Kebede.
nifi question
hi, i am new to nifi and have got problems on the UI, that its not displaying the icons on top of the processors and also in the connections/relations, it was working in windows 8 but when i update it to win 10 , sth like this happen? what do you think is the problem? or any helpis appreciated Regards, Yonatan Kebede.
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185323176 +1 to Bryan's point. We should definitely try to leverage the SSL Context. Oleg is this something you can work with Pierre on with the unit testing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185322119 Have we considered using the SSLContextService here rather than specifying all of the keystore/truststore properties in the processor? Usually the processor will have logic that says "if no SSLContextService was selected then we are doing regular communication, if one is selected then secure communication". This way you can avoid another property to specify if SSL/TLS should be used. An example of using this service is in InvokeHTTP... Defining the property: https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java#L196 Using the service: https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java#L479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1252
Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/229#issuecomment-185321319 @pvillard31 Thank you for contributing this fix against the last release. This was handled via NIFI-1415 in commit 93e2c5219599f24b54517dd43195c3d121030c5e as part of the 0.5.0 release. I was not able to reproduce and believe it should be have as desired. Please let us know if this is not the case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/232#discussion_r53195449 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -84,6 +89,72 @@ .allowableValues("0.9.1") .defaultValue("0.9.1") .build(); +public static final PropertyDescriptor USE_SSL_PROTOCOL = new PropertyDescriptor.Builder() +.name("Use SSL protocol") +.description("Indicates whether or not SSL protocol should be used") +.allowableValues("true", "false") +.defaultValue("false") +.required(true) +.build(); +public static final PropertyDescriptor VALIDATE_CERTIFICATES = new PropertyDescriptor.Builder() --- End diff -- @alopresto In fact I added this possibility because this is a use case described in [the RabbitMQ documentation](https://www.rabbitmq.com/ssl.html), and I assumed this is a possible scenario. Regarding the default value, I definitely agree with you, my bad. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/232#discussion_r53186223 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -84,6 +89,72 @@ .allowableValues("0.9.1") .defaultValue("0.9.1") .build(); +public static final PropertyDescriptor USE_SSL_PROTOCOL = new PropertyDescriptor.Builder() +.name("Use SSL protocol") +.description("Indicates whether or not SSL protocol should be used") +.allowableValues("true", "false") +.defaultValue("false") +.required(true) +.build(); +public static final PropertyDescriptor VALIDATE_CERTIFICATES = new PropertyDescriptor.Builder() --- End diff -- I am not sure why we would allow certificates _not_ be validated on a secure connection. I recommend removing this option, and I strongly oppose to the default value being `false` if it is allowed to remain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185272014 Ok, let's collaborate. If you can simply describe what you needed to do on both client and server to have SSL, I can definitely mock it on the _TestConnection_ and _TestChannel_. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185270244 Well I must admit I locally tested the change with a RabbitMQ server, but that's all. I had a look at the existing unit tests for AMQP processors but I am not sure how to mock a SSL context. If you have some hints I'll do my best to add unit tests ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185265232 Pierre, first of all, huge thanks for the contribution! Quite an important feature especially for enterprise users. Quick question though. One of the initiatives we are going through at the moment is to improve test coverage of our components. I know it's not trivial to the infrastructure tests for things like SSL, but I still wanted to ask if you thought about it and if any type of tests you ran locally could be migrated into unit tests even if mocks has to be used. I can also help with that as well as I am a bit paranoid when it comes to unit testing ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/232 NIFI-1521 Allows use of SSL in AMQP Processor Allows use of SSL in AMQP Processor You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-1521 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #232 commit 4ae03bb7ed6b2739351bcda58528d16b497821ff Author: Pierre VillardDate: 2016-02-16T10:02:10Z Merge remote-tracking branch 'refs/remotes/apache/master' commit e3c6b5741b22d22a4c9a3476c843be5390171353 Author: Pierre Villard Date: 2016-02-17T10:39:01Z Merge remote-tracking branch 'refs/remotes/apache/master' commit 241c11a914dcea2a01f7e74732e40e511685122c Author: Pierre Villard Date: 2016-02-17T15:30:09Z NIFI-1521 Allows use of SSL in AMQP Processor Allows use of SSL in AMQP Processor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1519 upgraded to the latest version of Spa...
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/231 NIFI-1519 upgraded to the latest version of Spark 1.6.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1519 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/231.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #231 commit 9ee4404640ee5f8413a455c666983ae7f47199a3 Author: Oleg ZhurakouskyDate: 2016-02-17T15:29:24Z NIFI-1519 upgraded to the latest version of Spark 1.6.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: Fix NiFi-1501 : Test Monitor Activity has spuri...
Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/225#issuecomment-185230292 @PuspenduBanerjee i will add you now as a contributor to the apache nifi wiki so you can do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r53169078 --- Diff: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java --- @@ -71,6 +71,7 @@ public static final String ADMINISTRATIVE_YIELD_DURATION = "nifi.administrative.yield.duration"; public static final String PERSISTENT_STATE_DIRECTORY = "nifi.persistent.state.directory"; public static final String BORED_YIELD_DURATION = "nifi.bored.yield.duration"; +public static final String PROCESSOR_START_TIMEOUT = "nifi.processor.start.timeout"; --- End diff -- One last comment. In any event I think we should still support a simple expression of time in numbers treating them as milliseconds. For example if time configuration value comes as '1', then it should be treated as 1 millisecond. At least this way we can argue both points and see what users use most. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r53165063 --- Diff: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java --- @@ -71,6 +71,7 @@ public static final String ADMINISTRATIVE_YIELD_DURATION = "nifi.administrative.yield.duration"; public static final String PERSISTENT_STATE_DIRECTORY = "nifi.persistent.state.directory"; public static final String BORED_YIELD_DURATION = "nifi.bored.yield.duration"; +public static final String PROCESSOR_START_TIMEOUT = "nifi.processor.start.timeout"; --- End diff -- regarding user friendliness the issue we saw before providing a utility for more natural expression of duration is that people were very inconsistent in specifying the unit of time that a given value applied to and using at times periods which didn't make sense for the scenario. This model allows the user to express in a much more natural way both the period of time and unit of time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r53164352 --- Diff: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java --- @@ -71,6 +71,7 @@ public static final String ADMINISTRATIVE_YIELD_DURATION = "nifi.administrative.yield.duration"; public static final String PERSISTENT_STATE_DIRECTORY = "nifi.persistent.state.directory"; public static final String BORED_YIELD_DURATION = "nifi.bored.yield.duration"; +public static final String PROCESSOR_START_TIMEOUT = "nifi.processor.start.timeout"; --- End diff -- I don't think we need to add default since it's handled during retrieval (basically if property is null or doesn't exist). I'll change to string based representation of time although I am still struggling with the whole concept and if indeed it is more user friendly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request: Enhancement for NIFI-1045 : Add "backup suffix"...
Github user trixpan commented on the pull request: https://github.com/apache/nifi/pull/230#issuecomment-185094912 Wouldn't it be a better choice to change the name of the new file instead of the existent one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---