[GitHub] nifi-minifi pull request #24: MINIFI-49 Made TestRestChangeNotifier upload f...

[JPercivall]

Github user JPercivall commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/24#discussion_r69504541
  
--- Diff: 
minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/notifiers/util/TestRestChangeNotifierCommon.java
 ---
@@ -84,6 +78,14 @@ public void testFileUpload() throws Exception {
 
 assertEquals("The result of notifying 
listeners:\nMockChangeListener successfully handled the configuration 
change\n", response.body().string());
 
-assertEquals(new String(Files.readAllBytes(file.toPath())), 
mockChangeListener.getConfFile());
+// Ignoring the system dependent line ending.
+String confFile = mockChangeListener.getConfFile();
+if (confFile.endsWith("\n") || confFile.endsWith("\r")) {
--- End diff --

You are totally right, will change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #24: MINIFI-49 Made TestRestChangeNotifier upload f...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi/pull/24#discussion_r69502168
  
--- Diff: 
minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/configuration/notifiers/util/TestRestChangeNotifierCommon.java
 ---
@@ -84,6 +78,14 @@ public void testFileUpload() throws Exception {
 
 assertEquals("The result of notifying 
listeners:\nMockChangeListener successfully handled the configuration 
change\n", response.body().string());
 
-assertEquals(new String(Files.readAllBytes(file.toPath())), 
mockChangeListener.getConfFile());
+// Ignoring the system dependent line ending.
+String confFile = mockChangeListener.getConfFile();
+if (confFile.endsWith("\n") || confFile.endsWith("\r")) {
--- End diff --

Do you think it would be better to just use a StringUtils#trim on the 
returned conf file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Clarification on Automation of Jobs

[Matthew Clarke]

The scheduling strategy dictates when the processor should trigger. For any
of the scheduling strategies to work, the processor must be running. The
purpose of the scheduling strategy is not to change the state of the
processor from stopped to started and back. It controls the behavior of a
running processor.

Timer driven --> this strategy will run the processor immediately when it's
state is changed from stop to start. It will then trigger to run at the
configured interval (30 secs in your example).

Event driven --> Not all processor support this scheduling strategy.
Rather then a processor running on an interval, the NiFi controller
triggers the processor to run based on whether or not the feeding
connection to that processor have any FlowFiles queued in them.

>From driven --> this strategy given the user a to define a very specific
run schedule. For example run at 2 am every Wednesday only.

Matt
On Jul 4, 2016 8:52 AM, "Basu, Aakash"  wrote:

> Hi team NiFi,
>
>
>
> Need a little clarification on automating the run for NiFi jobs.
>
>
>
> Currently there are three ways of automating jobs in NiFi, i.e., Time
> Driven, Event Driven and CRON Driven.
>
>
>
> *i)  **Time Driven* - I’ve set Time driven in the following
> way,
>
>
>
>
>
> But it still doesn’t work, for testing the working of this scheduling
> strategy, we checked with 30 secs. But it still didn’t start at all.
>
>
>
> *ii)**Event Driven – *Since it is still in the
> experimentation phase, as described by the NiFi community, so, we’re
> avoiding to use this strategy for the business.
>
>
>
> *iii)   **CRON Driven – *Can we get a little explanation of the
> CRON driven strategy, I’ve gone through the little description available on
> internet, but we need to know the working from end to end.
>
>
>
>
>
> A question: Should the processors be kept running for the jobs to work?
> Won’t they automatically switch on and work as per the scheduling?
>
>
>
> Some insight on this would help!
>
>
>
> Thanks & Regards,
>
> ___
>
> [image: Email_CBE.gif]*Aakash Basu*
>
> *Software Engineer | Insights & Data – Big Data COE*
>
> aakash.b...@capgemini.com 
>
> *Cap**gemini** India** | Bangalore*
>
> *Mob.: *+91 98743 60170 | *Tel: *+91 80 6656 7000* Ext:* 8043526
>
> www.capgemini.com
>
> [image: Description: cid:image002.gif@01CCD07C.65A424C0]
>
> *People matter, results count.*
>
> *7**Switch off as you go* |*q**Recycle always* | P*Print only if
> absolutely necessary*
>
>
>
> This message contains information that may be privileged or confidential
> and is the property of the Capgemini Group. It is intended only for the
> person to whom it is addressed. If you are not the intended recipient, you
> are not authorized to read, print, retain, copy, disseminate, distribute,
> or use this message or any part thereof. If you receive this message in
> error, please notify the sender immediately and delete all copies of this
> message.
>

[GitHub] nifi-minifi pull request #25: MINIFI-22 Removing lingering parts of UI

[JPercivall]

GitHub user JPercivall opened a pull request:

https://github.com/apache/nifi-minifi/pull/25

MINIFI-22 Removing lingering parts of UI

Most of this work was done with MINIFI-38 but there were still some 
lingering transitive dependencies being brought in that needed to be removed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-22

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit d98d0970bf1929dcd3da13a51c7dd4b27d08680d
Author: Joseph Percivall 
Date:   2016-07-05T01:33:44Z

MINIFI-22 Removing lingering parts of UI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---