Re: [VOTE] Release Apache NiFi Registry 0.1.0
+1, binding * Verified the downloads worked * Verified the signature (and that Bryan used SHA-512 for the underlying digest algorithm) * Verified checksums * Verified the Maven build worked and the RAT check passed * Verified the presence of valid LICENSE, NOTICE, and README files * Verified the git commit ID was correct * Verified the RC was branched off the correct git commit ID * Verified the RC binary contained valid LICENSE, NOTICE, and README files * Verified the registry application worked as expected (standalone) * Verified the NiFi PR 2219 built with the registry already installed * Verified the integration between the two applications worked as expected * Verified changes to a process group propagated to the registry and to cloned/imported process groups on the canvas * Verified error message and that changes are not lost if committed when registry is unavailable Notes: * A couple minor formatting/whitespace issues in the root pom.xml * “No results match this query” is an off-putting message for the default. Before a user has created a bucket (no indicator from the default listing that one must go to settings to do so), there are obviously no results, but the user does not expect that they have executed a “query” (unless they are a DBA, probably). Can we change this to be “Go to Settings to add your first bucket” if count(buckets) == 0? * After adding a bucket, I would expect “NiFi Registry/All” to show that bucket, not “No results match this query”. A user has to click the dropdown on “All” to see the new bucket listed. * Once entering the new bucket, the message displayed is still “No results match this query”. At this point, a new user has no idea what type of object would be a result at this level. Again, if the logic "count(flow) == 0”, I think a different message should be displayed like “Add versioned flows to this bucket from NiFi”. * I believe this is echoing Pierre, but I think the status icons in the PG and the toolbar need alt texts (both for 508 compliance and for people unfamiliar with the meaning of the icons). * If following the instructions provided in the release helper email, the local changes made to the first process group must be “Committed locally” in order for the imported PG to contain them. Otherwise, the imported PG will only contain the empty PG, while any changes made in the original are only in the originally and in a “locally modified” state. * When a PG is imported and an existing PG has the same name, the new PG should have the name “[Existing name] copy” or similar to indicate which is the original/source. * If a versioned PG is imported and is not at the most current version, local changes cannot be committed. Rather, “Change Version” and “Stop version control” are the only two options available. If a version upgrade is attempted, an error occurs and the local changes must be reverted. At this time, “Show local changes” and “Revert local changes” are made available in the version menu (not the error dialog). If these changes are non-conflicting, why does this occur? If this cannot be reconciled in the same flow snippet versioning chain, I suggest branching here and allowing it to be saved separately (i.e. provenance chain forking or git branching). Or at least warn the user on the first change made if the PG is not at the most recent version because a significant amount of work can be put in and then either lost or the ability to upgrade/save is lost with no user knowledge. * If the local changes are reverted, the menu options and state remain the same (conflicted) until a manual refresh occurs. * If changes are made to the cloned PG and committed, the changes are reflected in the registry UI and the original PG can be changed to that version, but it does not show the “a new version is available” indicator icon or notify the user that new changes are available (even after manual refresh). Despite all these notes, I think this is an excellent first release and will make NiFi much more useful for many users and open the possibilities for continued development that has been prevented up to this point. Thanks to everyone who worked on this. Andy LoPresto alopre...@apache.org alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Dec 29, 2017, at 2:56 PM, Yolanda Daviswrote: > > +1, binding > > Have been looking forward to this contribution; it is a great addition to > the community! > > Following the release helper I verified signatures, hashes as well as > the README, > NOTICE, and LICENSE. Successfully built the project per instructions and > built the NiFi project using the referenced PR. From there I tested in > unsecured mode the basic test suggested in the helper guide. Also tried > minor things such as deleting a flow from registry that was associated to a > PG to ensure NiFi updated as expected. > > One thing that would be helpful
[RESULT][VOTE] Release Apache NiFi Registry 0.1.0
Apache NiFi Community, I am pleased to announce that the 0.1.0 release of Apache NiFi Registry passes with: 12 +1 (binding) votes 4 +1 (non-binding) votes 0 0 votes 0 -1 votes Thanks to all who helped make this release possible. Here is the PMC vote thread: https://lists.apache.org/thread.html/c94d32297f1421929405a3c68b45fef24daaee17b266facd76153cc3@%3Cdev.nifi.apache.org%3E
Re: [VOTE] Release Apache NiFi Registry 0.1.0
+1 (binding) On Mon, Jan 1, 2018 at 2:20 PM, Jeffwrote: > +1 (binding) > > - Ran through the helper guide > - Ran through the initial testing steps in the helper guide > - Ran through several use case scenarios, everything worked as expected, > with a minor exception described below. > > NiFi Registry looks great! I think this provides a huge quality of life > improvement for NiFi and its users, and this is only the initial release! > Amazing! > > One thing I did notice, when working with two process groups referencing > the same versioned flow. If one of these process groups is modified (for > example, a processor was added) and the changes are committed, the second > process group will report that it's up to do date, though it doesn't have > any of the changes that were committed. It appears there's a period of > time between the commit of the changes and NiFi's retrieval/integration of > the updates from the registry. Refreshing the NiFi UI during this time > period will still show both process groups as up to date, though the > process group with the second instance of that versioned flow will still > not have the changes. Some moments later, the second process group's icon > will report that there's a new version. Updating that second process group > to the new version works as expected. > > This is minor and doesn't effect NiFi Registry, but I thought I'd mention > it here. I'll post this on the NiFi PR [1] as well. > > [1] https://github.com/apache/nifi/pull/2219. > > On Mon, Jan 1, 2018 at 11:30 AM Andrew Lim > wrote: > >> +1 (non-binding) >> >> -Ran full clean install on OS X (10.11.6) >> -Tested secure and unsecure Registry instances: creating/editing users, >> buckets, policies, special privileges; performed similar testing on group >> level >> -Reviewed documentation >> -Performed basic testing in NiFi: adding registry clients, putting a >> process group under version control, saving different versions, changing >> versions, importing a version, stopping version control >> >> Awesome initial release for this project! >> >> Drew >> >> >> > On Dec 28, 2017, at 1:09 PM, Bryan Bende wrote: >> > >> > Hello, >> > >> > I am pleased to be calling this vote for the source release of Apache >> > NiFi Registry 0.1.0. >> > >> > The source zip, including signatures, digests, etc. can be found at: >> > https://repository.apache.org/content/repositories/orgapachenifi-1115/ >> > >> > The Git tag is nifi-registry-0.1.0-RC1 >> > The Git commit ID is 81b99e7b04491eabb72ddf30754053ca12d0fcca >> > >> https://git-wip-us.apache.org/repos/asf?p=nifi-registry.git;a=commit;h=81b99e7b04491eabb72ddf30754053ca12d0fcca >> > >> > Checksums of nifi-registry-0.1.0-source-release.zip: >> > MD5: 56244c3c296cdc9c3fcc6d22590b80d1 >> > SHA1: 6354e91f868f40d6656ec2467bde307260ad63ca >> > SHA256: 2c680e441e6c4bfa2381bf004e9b19a6a79401a6a83e04597d0a714a95efd301 >> > >> > Release artifacts are signed with the following key: >> > https://people.apache.org/keys/committer/bbende.asc >> > >> > KEYS file available here: >> > https://dist.apache.org/repos/dist/release/nifi/KEYS >> > >> > 65 issues were closed/resolved for this release: >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320920=12340217 >> > >> > Release note highlights can be found here: >> > >> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-NiFiRegistry0.1.0 >> > >> > The vote will be open for 96 hours. >> > >> > Please download the release candidate and evaluate the necessary items >> > including checking hashes, signatures, build from source, and test. >> > >> > The please vote: >> > >> > [ ] +1 Release this package as nifi-registry-0.1.0 >> > [ ] +0 no opinion >> > [ ] -1 Do not release this package because... >> >>
Re: [VOTE] Release Apache NiFi Registry 0.1.0
+1 (non-binding) -Ran full clean install on OS X (10.11.6) -Tested secure and unsecure Registry instances: creating/editing users, buckets, policies, special privileges; performed similar testing on group level -Reviewed documentation -Performed basic testing in NiFi: adding registry clients, putting a process group under version control, saving different versions, changing versions, importing a version, stopping version control Awesome initial release for this project! Drew > On Dec 28, 2017, at 1:09 PM, Bryan Bendewrote: > > Hello, > > I am pleased to be calling this vote for the source release of Apache > NiFi Registry 0.1.0. > > The source zip, including signatures, digests, etc. can be found at: > https://repository.apache.org/content/repositories/orgapachenifi-1115/ > > The Git tag is nifi-registry-0.1.0-RC1 > The Git commit ID is 81b99e7b04491eabb72ddf30754053ca12d0fcca > https://git-wip-us.apache.org/repos/asf?p=nifi-registry.git;a=commit;h=81b99e7b04491eabb72ddf30754053ca12d0fcca > > Checksums of nifi-registry-0.1.0-source-release.zip: > MD5: 56244c3c296cdc9c3fcc6d22590b80d1 > SHA1: 6354e91f868f40d6656ec2467bde307260ad63ca > SHA256: 2c680e441e6c4bfa2381bf004e9b19a6a79401a6a83e04597d0a714a95efd301 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/bbende.asc > > KEYS file available here: > https://dist.apache.org/repos/dist/release/nifi/KEYS > > 65 issues were closed/resolved for this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320920=12340217 > > Release note highlights can be found here: > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-NiFiRegistry0.1.0 > > The vote will be open for 96 hours. > > Please download the release candidate and evaluate the necessary items > including checking hashes, signatures, build from source, and test. > > The please vote: > > [ ] +1 Release this package as nifi-registry-0.1.0 > [ ] +0 no opinion > [ ] -1 Do not release this package because...