Re: [DISCUSS} Closing in on a NiFi 1.4.0 release?

[Wes Lawrence]

I'd also like NIFI-4242 and NIFI-4181 added (or if it's OK, I can label
their fix versions for 1.4.0. I wasn't sure sure I could do that, or if
that should be left to PMC/Commiters)

NIFI-4242  has a patch
with feedback, and I'll be pushing a new patch addressing the feedback
later today.
NIFI-4181  has a patch
with feedback, and I'd like to address the feedback for 1.4.0 if possible.

--Wes

On Mon, Sep 11, 2017 at 10:33 AM, Christopher Currie  wrote:

> In addition to this list, I'd like to request that
> https://issues.apache.org/jira/browse/NIFI-3950 also be added. I created a
> PR for it, and I'm happy to work with a committer to clean it up for
> project standards if needed.
>
> Christopher
> On Mon, Sep 11, 2017 at 6:44 AM James Wing  wrote:
>
> > +1  It does seem to be about time to get a release out, and we should
> > certainly take advantage of your offer to performing RM duties.  Thank
> you
> > for that.
> >
> > On Sun, Sep 10, 2017 at 5:45 PM, Jeff  wrote:
> >
> > > All,
> > >
> > > On the dev and users lists there have been some questions about when
> the
> > > next release of NiFi would be.  I would like perform RM duties, and get
> > > things started on identifying what the community would like to include
> in
> > > the release of NiFi 1.4.0 that has not already been reviewed and
> > committed
> > > to master.
> > >
> > > There are 11 unresolved JIRAs tagged with a fix version of 1.4.0.
> > >
> > > https://issues.apache.org/jira/issues/?jql=project%20%
> > > 3D%20NIFI%20AND%20resolution%20%3D%20Unresolved%20AND%
> > > 20fixVersion%20%3D%201.4.0%20ORDER%20BY%20priority%
> 20DESC%2C%20key%20DESC
> > >
> > > Are there any reasons to hold off on a 1.4.0 release?  Are there
> > particular
> > > JIRAs that the community considers necessary to have as part of the
> > > release? Let's discuss!
> > >
> > > Thanks,
> > > Jeff
> > >
> >
>

Re: NiFi-4215 stackoverflow exception + patch

[Wes Lawrence]

Joe's right, there's a GitHub PR[1] and patch attached in JIRA[2], but I
did say "patch attached" in my email, and forgot to add it; sorry about
that Andy.

Attached this time, if that's convenient. =)

[1] https://github.com/apache/nifi/pull/2034
[2] https://issues.apache.org/jira/browse/NIFI-4215

--Wes

On Tue, Jul 25, 2017 at 3:22 PM, Joe Witt <joe.w...@gmail.com> wrote:

> He has a nice JIRA and PR up.  Think this is just to help find a reviewer.
>
> Thanks
> Joe
>
> On Tue, Jul 25, 2017 at 3:08 PM, Andy LoPresto <alopre...@apache.org>
> wrote:
> > Hi Wes,
> >
> > Thanks for discovering this and bringing it to our attention. The mailing
> > list strips attachments, so your patch is not available here. The best
> > course of action is to submit a pull request on GitHub, or attach the
> patch
> > file to the Jira directly. Let us know if you need any assistance with
> these
> > processes. Thanks again.
> >
> > Andy LoPresto
> > alopre...@apache.org
> > alopresto.apa...@gmail.com
> > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69
> >
> > On Jul 25, 2017, at 11:34 AM, Wes Lawrence <wesleyll...@gmail.com>
> wrote:
> >
> > Hey all,
> >
> > While building some standard templates we'd like to ship to customers, I
> > found an issue where the AvroSchemaRegistry throws a stack overflow
> > exception on Avro schemas that define a record that composes itself, e.g;
> >
> > {
> >  "namespace": "org.apache.nifi.testing",
> >  "name": "CompositRecord",
> >  "type": "record",
> >  "fields": [
> >{
> >  "name": "id",
> >  "type": "int"
> >},
> >{
> >  "name": "value",
> >  "type": "string"
> >},
> >{
> >  "name": "parent",
> >  "type": [
> >"null",
> >"CompositRecord"
> >  ]
> >}
> >  ]
> > }
> >
> >
> > The patch attached should take care of that use case, looking forward to
> > any feedback, and let me know if anything needs to be improved.
> >
> > --Wes
> >
> >
>

NiFi-4215 stackoverflow exception + patch

[Wes Lawrence]

Hey all,

While building some standard templates we'd like to ship to customers, I
found an issue where the AvroSchemaRegistry throws a stack overflow
exception on Avro schemas that define a record that composes itself, e.g;

{
  "namespace": "org.apache.nifi.testing",
  "name": "CompositRecord",
  "type": "record",
  "fields": [
{
  "name": "id",
  "type": "int"
},
{
  "name": "value",
  "type": "string"
},
{
  "name": "parent",
  "type": [
"null",
"CompositRecord"
  ]
}
  ]
}


The patch attached should take care of that use case, looking forward to
any feedback, and let me know if anything needs to be improved.

--Wes

Re: Start Contributing

[Wes Lawrence]

Hey Grant.

I'm also new to this, but I recommend writing the solution and providing a
GitHub PR and/or patch.

I've only fixed some minor bugs I've found, and only today added a very
minor feature, but I've found that approaching with a solution is the best
approach.

After all, if you were in charge of something, what do you prefer; I person
approaching you and saying "This needs fixing", or "This needs fixing, and
he's a potential fix".

Worst case, if the fix isn't what the commiters/PMC has is mind, providing
some solution gets the ball rolling on the problem.

--Wes

On Wed, Jul 12, 2017 at 11:10 PM, Grant Langlois  wrote:

> Hello all,
>
> First and foremost, my apologies if this message breaks protocol, this is
> my first time hitting a dev mailing list.
>
> I'm interested in contributing to this project and have a specific feature
> in mind to tackle first. I read through the developer's guide which
> recommended first submitting a Jira (which I did here
> .)
>
> My question is what happens next? Should I wait for someone to comment on
> it as to whether or not it's a feasible addition? I'm more than willing to
> write the code, assuming it's an acceptable addition.
>
> Thanks for your patience in helping out a newbie.
>
> Grant
>

Re: NiFi-4181 + patch

[Wes Lawrence]

Ah, an unintended feature! That is useful, and I'll have to keep it in mind.

Glad you're liking it, let me know if anything needs to be fixed up.

--Wes

On Wed, Jul 12, 2017 at 9:39 PM, Matt Burgess <mattyb...@gmail.com> wrote:

> Wes,
>
> I'm reviewing this now, looking good! A cool feature of it, when used
> with "Treat First Line As Header" set to true, is that you can rename
> the columns/fields, so even if you have a header line you don't have
> to use it :)
>
> Regards,
> Matt
>
>
> On Wed, Jul 12, 2017 at 5:37 PM, Wes Lawrence <wesleyll...@gmail.com>
> wrote:
> > Hey,
> >
> > I've been enjoying the new *Record processes, but I found
> > CSVReading/Writing a bit much, with having to describe an Avro schema.
> >
> > While we do use Avro, it's a bit much to define a whole schema for the
> > cases where we have 10-15+ columns of CSV data that we are typically
> trying
> > to reduce down to a smaller, say 5 column Avro payload. Just being able
> to
> > list the columns (when they aren't the first line) is helpful, I believe.
> >
> > So, I added a patch for CSVReading/Writing to work given a simple column
> > list, if that helps anyone out!
> >
> > --Wes
>

NiFi-4181 + patch

[Wes Lawrence]

Hey,

I've been enjoying the new *Record processes, but I found
CSVReading/Writing a bit much, with having to describe an Avro schema.

While we do use Avro, it's a bit much to define a whole schema for the
cases where we have 10-15+ columns of CSV data that we are typically trying
to reduce down to a smaller, say 5 column Avro payload. Just being able to
list the columns (when they aren't the first line) is helpful, I believe.

So, I added a patch for CSVReading/Writing to work given a simple column
list, if that helps anyone out!

--Wes

Re: NIFI-4064 High CPU with Funnels when no outgoing connections

[Wes Lawrence]

I can now, thank you.

I hope I didn't create two accounts accidentally.

--Wes

On Tue, Jun 13, 2017 at 1:22 PM, Aldrin Piri <aldrinp...@gmail.com> wrote:

> Hey Wes,
>
> Looks like there were two Wesley L Lawrence accounts.  I added the second
> one as well.  Could you please check that out to see if you now have the
> ability?
>
> Thanks!
>
>
> On Tue, Jun 13, 2017 at 10:10 AM, Wes Lawrence <wesleyll...@gmail.com>
> wrote:
>
> > Sorry, I can't seem to assign the ticket to myself.
> >
> > --Wes
> >
> > On Tue, Jun 13, 2017 at 12:03 PM, Bryan Bende <bbe...@gmail.com> wrote:
> >
> > > Hi Wes,
> > >
> > > I added you to the contributors group in JIRA.
> > >
> > > Let me know if you still can't assign the ticket to yourself.
> > >
> > > -Bryan
> > >
> > >
> > > On Tue, Jun 13, 2017 at 11:45 AM, Wes Lawrence <wesleyll...@gmail.com>
> > > wrote:
> > > > Hello,
> > > >
> > > > I created NIFI-4064 <https://issues.apache.org/jira/browse/NIFI-4064
> >
> > > since
> > > > I ran into a minor issue with high CPU usage when a Funnel has a
> queued
> > > > FlowFile, but no outgoing connections. I submitted a fix via a GitHub
> > PR
> > > > here <https://github.com/apache/nifi/pull/1914/files>, if someone
> has
> > a
> > > > chance to look.
> > > >
> > > > Also, is it possible for me to get Jira access to assign tickets to
> > > myself?
> > > >
> > > > --Wes
> > >
> >
>

Re: NIFI-4064 High CPU with Funnels when no outgoing connections

[Wes Lawrence]

Sorry, I can't seem to assign the ticket to myself.

--Wes

On Tue, Jun 13, 2017 at 12:03 PM, Bryan Bende <bbe...@gmail.com> wrote:

> Hi Wes,
>
> I added you to the contributors group in JIRA.
>
> Let me know if you still can't assign the ticket to yourself.
>
> -Bryan
>
>
> On Tue, Jun 13, 2017 at 11:45 AM, Wes Lawrence <wesleyll...@gmail.com>
> wrote:
> > Hello,
> >
> > I created NIFI-4064 <https://issues.apache.org/jira/browse/NIFI-4064>
> since
> > I ran into a minor issue with high CPU usage when a Funnel has a queued
> > FlowFile, but no outgoing connections. I submitted a fix via a GitHub PR
> > here <https://github.com/apache/nifi/pull/1914/files>, if someone has a
> > chance to look.
> >
> > Also, is it possible for me to get Jira access to assign tickets to
> myself?
> >
> > --Wes
>

NIFI-4064 High CPU with Funnels when no outgoing connections

[Wes Lawrence]

Hello,

I created NIFI-4064  since
I ran into a minor issue with high CPU usage when a Funnel has a queued
FlowFile, but no outgoing connections. I submitted a fix via a GitHub PR
here , if someone has a
chance to look.

Also, is it possible for me to get Jira access to assign tickets to myself?

--Wes