[GitHub] nifi issue #495: NIFI-1968 ExtractHL7Attributes is squashing empty component...

2016-06-06 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/495
  
+1 LGTM, built and ran the tests, also ran with a NiFi flow, verified the 
attributes with empty segment components are displayed correctly.

Mind squashing your commits? Also I was having trouble applying the patch, 
I may need to manually intervene but I will keep you as author of the commit(s).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #495: NIFI-1968 ExtractHL7Attributes is squashing empty component...

2016-06-06 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/495
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---