[GitHub] nifi issue #517: NIFI-1994: Fixed issues with controller services and templa...

2016-06-20 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/517
  
Looks good @markap14 

Had one minor issue ensuring controller services are copied as part of a 
process group dto. I tweak your commit to include the additionally 
functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #517: NIFI-1994: Fixed issues with controller services and templa...

2016-06-17 Thread markap14
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/517
  
@mcgilman I have updated the PR to address this. Please try it out again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #517: NIFI-1994: Fixed issues with controller services and templa...

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/517
  
@markap14 When exporting a template with controller services at multiple 
levels, it appears the services all end up at the top level group. These should 
probably retain the same scoping as the source system. With all the services at 
the top level, it is difficult to verify this fix (if I understand it 
correctly).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---