Re: Minor package update to test class

2020-10-28 Thread Mark Bean
PR submitted. They don't get any simpler than this.

https://github.com/apache/nifi/pull/4631

Thanks,
Mark

On Wed, Oct 28, 2020 at 2:56 PM Mark Bean  wrote:

> Will do. Thanks Andy.
>
>
> On Wed, Oct 28, 2020 at 2:54 PM Andy LoPresto 
> wrote:
>
>> Mark,
>>
>> Thanks for pointing this out. Please do file a Jira for this as it will
>> require a code change. Any commit to the repository needs to go through the
>> Jira/PR/review process, but with small changes like this they can usually
>> get knocked out quickly via coordination between committers.
>>
>> Andy LoPresto
>> alopre...@apache.org
>> alopresto.apa...@gmail.com
>> He/Him
>> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69
>>
>> > On Oct 28, 2020, at 11:36 AM, Mark Bean  wrote:
>> >
>> > A coworker noticed that the package name for
>> TestZooKeeperStateServer.java
>> > is incorrect. Currently, it is
>> > "org.apache.nifi.controller.state.server.zookeeper". However, it should
>> be
>> > "org.apache.nifi.controller.state.server"
>> >
>> > Does this require a full JIRA ticket, PR, etc.? Or is this considered a
>> > documentation update a kind committer could take care of for us?
>> >
>> > Thanks,
>> > Mark
>>
>>


Re: Minor package update to test class

2020-10-28 Thread Mark Bean
Will do. Thanks Andy.


On Wed, Oct 28, 2020 at 2:54 PM Andy LoPresto  wrote:

> Mark,
>
> Thanks for pointing this out. Please do file a Jira for this as it will
> require a code change. Any commit to the repository needs to go through the
> Jira/PR/review process, but with small changes like this they can usually
> get knocked out quickly via coordination between committers.
>
> Andy LoPresto
> alopre...@apache.org
> alopresto.apa...@gmail.com
> He/Him
> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69
>
> > On Oct 28, 2020, at 11:36 AM, Mark Bean  wrote:
> >
> > A coworker noticed that the package name for
> TestZooKeeperStateServer.java
> > is incorrect. Currently, it is
> > "org.apache.nifi.controller.state.server.zookeeper". However, it should
> be
> > "org.apache.nifi.controller.state.server"
> >
> > Does this require a full JIRA ticket, PR, etc.? Or is this considered a
> > documentation update a kind committer could take care of for us?
> >
> > Thanks,
> > Mark
>
>


Re: Minor package update to test class

2020-10-28 Thread Andy LoPresto
Mark,

Thanks for pointing this out. Please do file a Jira for this as it will require 
a code change. Any commit to the repository needs to go through the 
Jira/PR/review process, but with small changes like this they can usually get 
knocked out quickly via coordination between committers. 

Andy LoPresto
alopre...@apache.org
alopresto.apa...@gmail.com
He/Him
PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69

> On Oct 28, 2020, at 11:36 AM, Mark Bean  wrote:
> 
> A coworker noticed that the package name for TestZooKeeperStateServer.java
> is incorrect. Currently, it is
> "org.apache.nifi.controller.state.server.zookeeper". However, it should be
> "org.apache.nifi.controller.state.server"
> 
> Does this require a full JIRA ticket, PR, etc.? Or is this considered a
> documentation update a kind committer could take care of for us?
> 
> Thanks,
> Mark



Minor package update to test class

2020-10-28 Thread Mark Bean
A coworker noticed that the package name for TestZooKeeperStateServer.java
is incorrect. Currently, it is
"org.apache.nifi.controller.state.server.zookeeper". However, it should be
"org.apache.nifi.controller.state.server"

Does this require a full JIRA ticket, PR, etc.? Or is this considered a
documentation update a kind committer could take care of for us?

Thanks,
Mark