Re: NIFI-5452: Allow For Ignoring Block Locality When Writing to HDFS
David No - i get it. I'm just giving some color to help explain what makes it easier to get things in. We effectively have two motions 1) Contributions made 2) Contributions reviewed/tested/merged We have a lot more people focused on #1 and a lot fewer on #2. As a result the pipeline of open PRs tends to grow. We need folks, contributors, helping on both 1 and 2. Your PR is merged now though. Thanks On Mon, Oct 28, 2019 at 3:38 PM David Mollitor wrote: > Hey Joe, > > I hope you didn't understand my email to be some sort of complaint or > critique of the process. I can now see how it could be misconstrued as > such. What I meant was that I was motivated to get in done, just needed > some direction. > > Thanks again, > David > > On Mon, Oct 28, 2019, 4:58 PM Joe Witt wrote: > > > I am deep in the RC3 prep process and have been grabbing as I can. This > > looks ok to grab and I plan to do so now. But, please understand we need > > help from detailed/thoughtful reviews to help this pipeline function. We > > get tons of great contribs but the review part is equally important. > > Please consider participating, if you've not, in other reviews as well. > > > > Thanks > > > > On Mon, Oct 28, 2019 at 1:38 PM David Mollitor > wrote: > > > > > I've been working on this effort for more than a year. I'm hoping > > someone > > > can assist me in getting it over the finish line. > > > > > > PR needs a review. > > > > > > https://github.com/apache/nifi/pull/3652 > > > > > > Thanks! > > > > > >
Re: NIFI-5452: Allow For Ignoring Block Locality When Writing to HDFS
Hey Joe, I hope you didn't understand my email to be some sort of complaint or critique of the process. I can now see how it could be misconstrued as such. What I meant was that I was motivated to get in done, just needed some direction. Thanks again, David On Mon, Oct 28, 2019, 4:58 PM Joe Witt wrote: > I am deep in the RC3 prep process and have been grabbing as I can. This > looks ok to grab and I plan to do so now. But, please understand we need > help from detailed/thoughtful reviews to help this pipeline function. We > get tons of great contribs but the review part is equally important. > Please consider participating, if you've not, in other reviews as well. > > Thanks > > On Mon, Oct 28, 2019 at 1:38 PM David Mollitor wrote: > > > I've been working on this effort for more than a year. I'm hoping > someone > > can assist me in getting it over the finish line. > > > > PR needs a review. > > > > https://github.com/apache/nifi/pull/3652 > > > > Thanks! > > >
Re: NIFI-5452: Allow For Ignoring Block Locality When Writing to HDFS
David - I will take a look at this for you. However I will say here (and on the review) that I believe the "ignorelocality" should be defaulted to "True" by default simply to maintain functionality closer to the original implementation. Thanks, Jeremy Dyer On Mon, Oct 28, 2019 at 4:55 PM David Mollitor wrote: > I do apologies if I am sending a duplicate of the following message. I'm > not sure if the first one went through... > > I've been working on this effort for more than a year. I'm hoping someone > can assist me in getting it over the finish line. > > PR needs a review. > > https://github.com/apache/nifi/pull/3652 > > Thanks! >
Re: NIFI-5452: Allow For Ignoring Block Locality When Writing to HDFS
I am deep in the RC3 prep process and have been grabbing as I can. This looks ok to grab and I plan to do so now. But, please understand we need help from detailed/thoughtful reviews to help this pipeline function. We get tons of great contribs but the review part is equally important. Please consider participating, if you've not, in other reviews as well. Thanks On Mon, Oct 28, 2019 at 1:38 PM David Mollitor wrote: > I've been working on this effort for more than a year. I'm hoping someone > can assist me in getting it over the finish line. > > PR needs a review. > > https://github.com/apache/nifi/pull/3652 > > Thanks! >
NIFI-5452: Allow For Ignoring Block Locality When Writing to HDFS
I do apologies if I am sending a duplicate of the following message. I'm not sure if the first one went through... I've been working on this effort for more than a year. I'm hoping someone can assist me in getting it over the finish line. PR needs a review. https://github.com/apache/nifi/pull/3652 Thanks!