[jira] [Updated] (NUTCH-2725) Plugin lib-http to support per-host configurable cookies

2019-07-25 Thread Markus Jelsma (JIRA) 


 [ 
https://issues.apache.org/jira/browse/NUTCH-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Markus Jelsma updated NUTCH-2725:
-
Attachment: NUTCH-2725.patch

> Plugin lib-http to support per-host configurable cookies
> 
>
> Key: NUTCH-2725
> URL: https://issues.apache.org/jira/browse/NUTCH-2725
> Project: Nutch
>  Issue Type: Improvement
>  Components: protocol
>Affects Versions: 1.15
>Reporter: Markus Jelsma
>Assignee: Markus Jelsma
>Priority: Major
> Fix For: 1.16
>
> Attachments: NUTCH-2725.patch, NUTCH-2725.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (NUTCH-2725) Plugin lib-http to support per-host configurable cookies

2019-07-25 Thread Markus Jelsma (JIRA) 


[ 
https://issues.apache.org/jira/browse/NUTCH-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892873#comment-16892873
 ] 

Markus Jelsma commented on NUTCH-2725:
--

Addressed all three points. Thanks Sebastian!

> Plugin lib-http to support per-host configurable cookies
> 
>
> Key: NUTCH-2725
> URL: https://issues.apache.org/jira/browse/NUTCH-2725
> Project: Nutch
>  Issue Type: Improvement
>  Components: protocol
>Affects Versions: 1.15
>Reporter: Markus Jelsma
>Assignee: Markus Jelsma
>Priority: Major
> Fix For: 1.16
>
> Attachments: NUTCH-2725.patch, NUTCH-2725.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (NUTCH-2725) Plugin lib-http to support per-host configurable cookies

2019-07-25 Thread Sebastian Nagel (JIRA) 


[ 
https://issues.apache.org/jira/browse/NUTCH-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892858#comment-16892858
 ] 

Sebastian Nagel commented on NUTCH-2725:


Hi [~markus17] looks good and works. A few minor points:
* converting the URL object to a String, then parsing it again doesn't seem 
efficient (could just pass the URL object itself):
{code}
cookie = http.getCookie(url.toString());
...
public String getCookie(String url) {
   if (hostCookies != null) {
 return hostCookies.get(URLUtil.getHost(url));
   }
...
{code}
* comment lines in the cookies.txt file cause an exception and the rest of the 
file is ignored (should generally report and skip invalid lines and continue):
{noformat}
2019-07-25 16:58:24,052 WARN  http.Http - Failed to read 
http.agent.host.cookie.file cookies.txt: 
java.lang.ArrayIndexOutOfBoundsException: 1
at 
org.apache.nutch.protocol.http.api.HttpBase.setConf(HttpBase.java:278)
{noformat}
* could add "http.agent.host.cookie.file" to nutch-default.xml

> Plugin lib-http to support per-host configurable cookies
> 
>
> Key: NUTCH-2725
> URL: https://issues.apache.org/jira/browse/NUTCH-2725
> Project: Nutch
>  Issue Type: Improvement
>  Components: protocol
>Affects Versions: 1.15
>Reporter: Markus Jelsma
>Assignee: Markus Jelsma
>Priority: Major
> Fix For: 1.16
>
> Attachments: NUTCH-2725.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (NUTCH-2725) Plugin lib-http to support per-host configurable cookies

2019-07-25 Thread Markus Jelsma (JIRA) 


 [ 
https://issues.apache.org/jira/browse/NUTCH-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Markus Jelsma updated NUTCH-2725:
-
Attachment: NUTCH-2725.patch

> Plugin lib-http to support per-host configurable cookies
> 
>
> Key: NUTCH-2725
> URL: https://issues.apache.org/jira/browse/NUTCH-2725
> Project: Nutch
>  Issue Type: Improvement
>  Components: protocol
>Affects Versions: 1.15
>Reporter: Markus Jelsma
>Assignee: Markus Jelsma
>Priority: Major
> Fix For: 1.16
>
> Attachments: NUTCH-2725.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (NUTCH-2725) Plugin lib-http to support per-host configurable cookies

2019-07-25 Thread Markus Jelsma (JIRA) 


 [ 
https://issues.apache.org/jira/browse/NUTCH-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Markus Jelsma updated NUTCH-2725:
-
Patch Info: Patch Available

> Plugin lib-http to support per-host configurable cookies
> 
>
> Key: NUTCH-2725
> URL: https://issues.apache.org/jira/browse/NUTCH-2725
> Project: Nutch
>  Issue Type: Improvement
>  Components: protocol
>Affects Versions: 1.15
>Reporter: Markus Jelsma
>Assignee: Markus Jelsma
>Priority: Major
> Fix For: 1.16
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (NUTCH-2725) Plugin lib-http to support per-host configurable cookies

2019-07-25 Thread Markus Jelsma (JIRA) 
Markus Jelsma created NUTCH-2725:


 Summary: Plugin lib-http to support per-host configurable cookies
 Key: NUTCH-2725
 URL: https://issues.apache.org/jira/browse/NUTCH-2725
 Project: Nutch
  Issue Type: Improvement
  Components: protocol
Affects Versions: 1.15
Reporter: Markus Jelsma
Assignee: Markus Jelsma
 Fix For: 1.16






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)