[jira] [Assigned] (NUTCH-2856) Implement a protocol-smb plugin based on hierynomus/smbj

2023-02-28 Thread Lewis John McGibbney (Jira)


 [ 
https://issues.apache.org/jira/browse/NUTCH-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney reassigned NUTCH-2856:
---

Assignee: (was: Lewis John McGibbney)

> Implement a protocol-smb plugin based on hierynomus/smbj
> 
>
> Key: NUTCH-2856
> URL: https://issues.apache.org/jira/browse/NUTCH-2856
> Project: Nutch
>  Issue Type: New Feature
>  Components: external, plugin, protocol
>Reporter: Hiran Chaudhuri
>Priority: Major
> Fix For: 1.20
>
>
> The plugin protocol-smb advertized on 
> [https://cwiki.apache.org/confluence/display/NUTCH/PluginCentral] actually 
> refers to the JCIFS library. According to this library's homepage 
> [https://www.jcifs.org/]:
> _If you're looking for the latest and greatest open source Java SMB library, 
> this is not it. JCIFS has been in maintenance-mode-only for several years and 
> although what it does support works fine (SMB1, NTLMv2, midlc, MSRPC and 
> various utility classes), jCIFS does not support the newer SMB2/3 variants of 
> the SMB protocol which is slowly becoming required (Windows 10 requires 
> SMB2/3). JCIFS only supports SMB1 but Microsoft has deprecated SMB1 in their 
> products. *So if SMB1 is disabled on your network, JCIFS' file related 
> operations will NOT work.*_
> Looking at 
> [https://en.wikipedia.org/wiki/Server_Message_Block#SMB_/_CIFS_/_SMB1:|https://en.wikipedia.org/wiki/Server_Message_Block#SMB_/_CIFS_/_SMB1]
> _Microsoft added SMB1 to the Windows Server 2012 R2 deprecation list in June 
> 2013. Windows Server 2016 and some versions of Windows 10 Fall Creators 
> Update do not have SMB1 installed by default._
> As a conclusion, the chances that SMB1 protocol is installed and/or 
> configured are getting vastly smaller. Therefore some migration towards 
> SMB2/3 is required. Luckily the JCIFS homepage lists alternatives:
>  * [jcifs-codelibs|https://github.com/codelibs/jcifs]
>  * [jcifs-ng|https://github.com/AgNO3/jcifs-ng]
>  * [smbj|https://github.com/hierynomus/smbj]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Tim Allison (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694744#comment-17694744
 ] 

Tim Allison commented on NUTCH-2988:


If you open the 7.13.2 jar file, there's just the two -- "Server Side Public 
License" and "Elastic License 2.0".  The word Apache is never used.

> Elasticsearch 7.13.2 compatible with ASL 2.0?
> -
>
> Key: NUTCH-2988
> URL: https://issues.apache.org/jira/browse/NUTCH-2988
> Project: Nutch
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Minor
> Attachments: LICENSE.txt
>
>
> In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
> high level java client is at 7.13.2, which is after the great schism.  Or, 
> the last purely ASL 2.0 license was in 7.10.2.
> So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing 
> plan suitable to be released within an ASF project?
> Or, is the client as opposed to the main search project still actually ASL 
> 2.0?
> Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Tim Allison (Jira)


 [ 
https://issues.apache.org/jira/browse/NUTCH-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Allison updated NUTCH-2988:
---
Attachment: LICENSE.txt

> Elasticsearch 7.13.2 compatible with ASL 2.0?
> -
>
> Key: NUTCH-2988
> URL: https://issues.apache.org/jira/browse/NUTCH-2988
> Project: Nutch
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Minor
> Attachments: LICENSE.txt
>
>
> In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
> high level java client is at 7.13.2, which is after the great schism.  Or, 
> the last purely ASL 2.0 license was in 7.10.2.
> So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing 
> plan suitable to be released within an ASF project?
> Or, is the client as opposed to the main search project still actually ASL 
> 2.0?
> Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Lewis John McGibbney (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694741#comment-17694741
 ] 

Lewis John McGibbney commented on NUTCH-2988:
-

Actually, digging deeper it looks like the v7.13.2 we consume is licensed under 
[Elastic License 
2.0|https://raw.githubusercontent.com/elastic/elasticsearch/v7.13.2/licenses/ELASTIC-LICENSE-2.0.txt].
 This is confirmed by
# 
https://central.sonatype.com/artifact/org.elasticsearch.client/elasticsearch-rest-high-level-client/7.13.2,
 and
# 
https://mvnrepository.com/artifact/org.elasticsearch.client/elasticsearch-rest-high-level-client/7.13.2

> Elasticsearch 7.13.2 compatible with ASL 2.0?
> -
>
> Key: NUTCH-2988
> URL: https://issues.apache.org/jira/browse/NUTCH-2988
> Project: Nutch
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Minor
>
> In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
> high level java client is at 7.13.2, which is after the great schism.  Or, 
> the last purely ASL 2.0 license was in 7.10.2.
> So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing 
> plan suitable to be released within an ASF project?
> Or, is the client as opposed to the main search project still actually ASL 
> 2.0?
> Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Tim Allison (Jira)


 [ 
https://issues.apache.org/jira/browse/NUTCH-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Allison updated NUTCH-2988:
---
Description: 
In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
high level java client is at 7.13.2, which is after the great schism.  Or, the 
last purely ASL 2.0 license was in 7.10.2.

So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing plan 
suitable to be released within an ASF project?

Or, is the client as opposed to the main search project still actually ASL 2.0?

Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt

  was:
In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
high level java client is at 7.13.2, which is after the great schism.  Or, the 
last purely ASL 2.0 license was in 7.10.2.

So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing plan 
suitable to be released within an ASF project?

Or, is the client still actually ASL 2.0?

Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt


> Elasticsearch 7.13.2 compatible with ASL 2.0?
> -
>
> Key: NUTCH-2988
> URL: https://issues.apache.org/jira/browse/NUTCH-2988
> Project: Nutch
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Minor
>
> In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
> high level java client is at 7.13.2, which is after the great schism.  Or, 
> the last purely ASL 2.0 license was in 7.10.2.
> So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing 
> plan suitable to be released within an ASF project?
> Or, is the client as opposed to the main search project still actually ASL 
> 2.0?
> Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Tim Allison (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694739#comment-17694739
 ] 

Tim Allison commented on NUTCH-2988:


Y, k. 
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/_license.html.

Maven central which raised my initial concern is probably not the best 
resource: 
https://mvnrepository.com/artifact/org.elasticsearch.client/elasticsearch-rest-high-level-client/7.13.2
 and 

https://raw.githubusercontent.com/elastic/elasticsearch/v7.13.2/licenses/ELASTIC-LICENSE-2.0.txt

> Elasticsearch 7.13.2 compatible with ASL 2.0?
> -
>
> Key: NUTCH-2988
> URL: https://issues.apache.org/jira/browse/NUTCH-2988
> Project: Nutch
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Minor
>
> In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
> high level java client is at 7.13.2, which is after the great schism.  Or, 
> the last purely ASL 2.0 license was in 7.10.2.
> So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing 
> plan suitable to be released within an ASF project?
> Or, is the client still actually ASL 2.0?
> Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Lewis John McGibbney (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694736#comment-17694736
 ] 

Lewis John McGibbney commented on NUTCH-2988:
-

It looks the the [elasticsearch-java 
client|https://github.com/elastic/elasticsearch-java/blob/v8.6.2/LICENSE.txt]'s 
are licensed under ALv2.0.

> Elasticsearch 7.13.2 compatible with ASL 2.0?
> -
>
> Key: NUTCH-2988
> URL: https://issues.apache.org/jira/browse/NUTCH-2988
> Project: Nutch
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Minor
>
> In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
> high level java client is at 7.13.2, which is after the great schism.  Or, 
> the last purely ASL 2.0 license was in 7.10.2.
> So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing 
> plan suitable to be released within an ASF project?
> Or, is the client still actually ASL 2.0?
> Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Tim Allison (Jira)


 [ 
https://issues.apache.org/jira/browse/NUTCH-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Allison updated NUTCH-2988:
---
Description: 
In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
high level java client is at 7.13.2, which is after the great schism.  Or, the 
last purely ASL 2.0 license was in 7.10.2.

So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing plan 
suitable to be released within an ASF project?

Or, is the client still actually ASL 2.0?

Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt

  was:
In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
high level java client is at 7.13.2, which is after the great schism.  Or, the 
last purely ASL 2.0 license was in 7.10.2.

So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing plan 
suitable to be released within an ASF project?

Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt


> Elasticsearch 7.13.2 compatible with ASL 2.0?
> -
>
> Key: NUTCH-2988
> URL: https://issues.apache.org/jira/browse/NUTCH-2988
> Project: Nutch
>  Issue Type: Task
>Reporter: Tim Allison
>Priority: Minor
>
> In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
> high level java client is at 7.13.2, which is after the great schism.  Or, 
> the last purely ASL 2.0 license was in 7.10.2.
> So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing 
> plan suitable to be released within an ASF project?
> Or, is the client still actually ASL 2.0?
> Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NUTCH-2988) Elasticsearch 7.13.2 compatible with ASL 2.0?

2023-02-28 Thread Tim Allison (Jira)
Tim Allison created NUTCH-2988:
--

 Summary: Elasticsearch 7.13.2 compatible with ASL 2.0?
 Key: NUTCH-2988
 URL: https://issues.apache.org/jira/browse/NUTCH-2988
 Project: Nutch
  Issue Type: Task
Reporter: Tim Allison


In the latest release of at least the 1.x branch of Nutch, the elasticsearch 
high level java client is at 7.13.2, which is after the great schism.  Or, the 
last purely ASL 2.0 license was in 7.10.2.

So, do we need to downgrade to 7.10.2 or is Elasticsearch's new licensing plan 
suitable to be released within an ASF project?

Ref: https://github.com/elastic/elasticsearch/blob/v7.13.2/LICENSE.txt



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NUTCH-2972) Javadoc build fails using JDK 17

2023-02-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694651#comment-17694651
 ] 

ASF GitHub Bot commented on NUTCH-2972:
---

sebastian-nagel commented on PR #760:
URL: https://github.com/apache/nutch/pull/760#issuecomment-1448538857

   > We should upgrade the entire codebase to JDK 17.
   
   Yes. I've opened NUTCH-2987 to track the upgrade to JDK 17.




> Javadoc build fails using JDK 17
> 
>
> Key: NUTCH-2972
> URL: https://issues.apache.org/jira/browse/NUTCH-2972
> Project: Nutch
>  Issue Type: Sub-task
>  Components: build, documentation
>Affects Versions: 1.20
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Major
>  Labels: help-wanted
> Fix For: 1.20
>
>
> Creating the Javadocs fails using JDK 17:
> {noformat}
> $> JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 ant javadoc
> ...
>   [javadoc] 
> /home/wastl/data0/proj/crawler/nutch/git/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java:79:
>  error: heading used out of sequence: , compared to implicit preceding 
> heading: 
>   [javadoc]  * Important Notes Which parts are merged?
> ...
>   [javadoc] 3 errors
>   [javadoc] 100 warnings
> {noformat}
> All 3 errors must be fixed, would be good also to address the warnings.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nutch] sebastian-nagel commented on pull request #760: NUTCH-2972 Javadoc build fails using JDK 17

2023-02-28 Thread via GitHub


sebastian-nagel commented on PR #760:
URL: https://github.com/apache/nutch/pull/760#issuecomment-1448538857

   > We should upgrade the entire codebase to JDK 17.
   
   Yes. I've opened NUTCH-2987 to track the upgrade to JDK 17.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NUTCH-2987) Upgrade to Java 17

2023-02-28 Thread Sebastian Nagel (Jira)
Sebastian Nagel created NUTCH-2987:
--

 Summary: Upgrade to Java 17
 Key: NUTCH-2987
 URL: https://issues.apache.org/jira/browse/NUTCH-2987
 Project: Nutch
  Issue Type: Improvement
  Components: build
Affects Versions: 1.20
Reporter: Sebastian Nagel
 Fix For: 1.20


Upgrade build to use Java 17 LTS. Depends on NUTCH-2970 and eventually 
HADOOP-17177.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NUTCH-2596) Upgrade from org.mortbay.jetty to org.eclipse.jetty

2023-02-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694644#comment-17694644
 ] 

ASF GitHub Bot commented on NUTCH-2596:
---

sebastian-nagel commented on PR #758:
URL: https://github.com/apache/nutch/pull/758#issuecomment-1448515489

   Yes, it's based on #757 - otherwise the build would fail without the 
"org.mortbay.jetty" packages.
   
   Shall I split this into two issues or PRs
   1. Replace "org.mortbay.jetty" in Fetcher unit tests
   2. (dependent on #757 / NUTCH-2984) remove the "org.mortbay.jetty" dependency




> Upgrade from org.mortbay.jetty to org.eclipse.jetty
> ---
>
> Key: NUTCH-2596
> URL: https://issues.apache.org/jira/browse/NUTCH-2596
> Project: Nutch
>  Issue Type: Sub-task
>  Components: nutch server, test
>Affects Versions: 1.14
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Major
> Fix For: 1.20
>
>
> The old org.mortbay.jetty libs (not maintained since 2008) are still used for 
> the Nutch server and multiple unit tests. Nutch should be upgraded to the 
> maintained org.eclipse.jetty libs/packages.
> The old dependency causes the unit tests of the HTTP protocol plugins to fail 
> when built with Java 9 or 10 with the following error while compiling JSP 
> classes (see NUTCH-2512):
> {noformat}
> 2018-06-06 11:03:02,335 ERROR mortbay.log (Slf4jLog.java:warn(87)) - 
> /basic-http.jsp
> java.lang.ClassCastException: 
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to 
> java.base/java.net.URLClassLoader
> at 
> org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:94)
> at org.apache.jasper.servlet.JspServlet.init(JspServlet.java:100)
> at 
> org.mortbay.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:440)
> at 
> org.mortbay.jetty.servlet.ServletHolder.getServlet(ServletHolder.java:339)
> at 
> org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
> at 
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
> at 
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
> at 
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
> at 
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
> at org.mortbay.jetty.Server.handle(Server.java:326)
> at 
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
> at 
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
> at 
> org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
> at 
> org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
> 2018-06-06 11:03:02,356 WARN  mortbay.log (Slf4jLog.java:warn(76)) - 
> /basic-http.jsp: javax.servlet.UnavailableException: 
> java.lang.ClassCastException: 
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to 
> java.base/java.net.URLClassLoader
> 2018-06-06 11:03:02,386 INFO  mortbay.log (Slf4jLog.java:info(67)) - Stopped 
> SelectChannelConnector@127.0.0.1:47504
> ...
> HTTP Status Code for http://127.0.0.1:47504/basic-http.jsp expected:<200> but 
> was:<500>
> junit.framework.AssertionFailedError: HTTP Status Code for 
> http://127.0.0.1:47504/basic-http.jsp expected:<200> but was:<500>
> at 
> org.apache.nutch.protocol.http.TestProtocolHttp.fetchPage(TestProtocolHttp.java:130)
> at 
> org.apache.nutch.protocol.http.TestProtocolHttp.testStatusCode(TestProtocolHttp.java:80)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nutch] sebastian-nagel commented on pull request #758: NUTCH-2596 Upgrade from org.mortbay.jetty to org.eclipse.jetty

2023-02-28 Thread via GitHub


sebastian-nagel commented on PR #758:
URL: https://github.com/apache/nutch/pull/758#issuecomment-1448515489

   Yes, it's based on #757 - otherwise the build would fail without the 
"org.mortbay.jetty" packages.
   
   Shall I split this into two issues or PRs
   1. Replace "org.mortbay.jetty" in Fetcher unit tests
   2. (dependent on #757 / NUTCH-2984) remove the "org.mortbay.jetty" dependency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NUTCH-2596) Upgrade from org.mortbay.jetty to org.eclipse.jetty

2023-02-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694607#comment-17694607
 ] 

ASF GitHub Bot commented on NUTCH-2596:
---

lewismc commented on PR #758:
URL: https://github.com/apache/nutch/pull/758#issuecomment-1448352540

   This also includes https://github.com/apache/nutch/pull/757 ? 
@sebastian-nagel 




> Upgrade from org.mortbay.jetty to org.eclipse.jetty
> ---
>
> Key: NUTCH-2596
> URL: https://issues.apache.org/jira/browse/NUTCH-2596
> Project: Nutch
>  Issue Type: Sub-task
>  Components: nutch server, test
>Affects Versions: 1.14
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Major
> Fix For: 1.20
>
>
> The old org.mortbay.jetty libs (not maintained since 2008) are still used for 
> the Nutch server and multiple unit tests. Nutch should be upgraded to the 
> maintained org.eclipse.jetty libs/packages.
> The old dependency causes the unit tests of the HTTP protocol plugins to fail 
> when built with Java 9 or 10 with the following error while compiling JSP 
> classes (see NUTCH-2512):
> {noformat}
> 2018-06-06 11:03:02,335 ERROR mortbay.log (Slf4jLog.java:warn(87)) - 
> /basic-http.jsp
> java.lang.ClassCastException: 
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to 
> java.base/java.net.URLClassLoader
> at 
> org.apache.jasper.compiler.JspRuntimeContext.(JspRuntimeContext.java:94)
> at org.apache.jasper.servlet.JspServlet.init(JspServlet.java:100)
> at 
> org.mortbay.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:440)
> at 
> org.mortbay.jetty.servlet.ServletHolder.getServlet(ServletHolder.java:339)
> at 
> org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
> at 
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
> at 
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
> at 
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
> at 
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
> at org.mortbay.jetty.Server.handle(Server.java:326)
> at 
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
> at 
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
> at 
> org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
> at 
> org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
> 2018-06-06 11:03:02,356 WARN  mortbay.log (Slf4jLog.java:warn(76)) - 
> /basic-http.jsp: javax.servlet.UnavailableException: 
> java.lang.ClassCastException: 
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to 
> java.base/java.net.URLClassLoader
> 2018-06-06 11:03:02,386 INFO  mortbay.log (Slf4jLog.java:info(67)) - Stopped 
> SelectChannelConnector@127.0.0.1:47504
> ...
> HTTP Status Code for http://127.0.0.1:47504/basic-http.jsp expected:<200> but 
> was:<500>
> junit.framework.AssertionFailedError: HTTP Status Code for 
> http://127.0.0.1:47504/basic-http.jsp expected:<200> but was:<500>
> at 
> org.apache.nutch.protocol.http.TestProtocolHttp.fetchPage(TestProtocolHttp.java:130)
> at 
> org.apache.nutch.protocol.http.TestProtocolHttp.testStatusCode(TestProtocolHttp.java:80)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nutch] lewismc commented on pull request #758: NUTCH-2596 Upgrade from org.mortbay.jetty to org.eclipse.jetty

2023-02-28 Thread via GitHub


lewismc commented on PR #758:
URL: https://github.com/apache/nutch/pull/758#issuecomment-1448352540

   This also includes https://github.com/apache/nutch/pull/757 ? 
@sebastian-nagel 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NUTCH-2972) Javadoc build fails using JDK 17

2023-02-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694591#comment-17694591
 ] 

ASF GitHub Bot commented on NUTCH-2972:
---

lewismc commented on PR #760:
URL: https://github.com/apache/nutch/pull/760#issuecomment-1448285390

   We should upgrade the entire codebase to JDK 17. 




> Javadoc build fails using JDK 17
> 
>
> Key: NUTCH-2972
> URL: https://issues.apache.org/jira/browse/NUTCH-2972
> Project: Nutch
>  Issue Type: Sub-task
>  Components: build, documentation
>Affects Versions: 1.20
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Major
>  Labels: help-wanted
> Fix For: 1.20
>
>
> Creating the Javadocs fails using JDK 17:
> {noformat}
> $> JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 ant javadoc
> ...
>   [javadoc] 
> /home/wastl/data0/proj/crawler/nutch/git/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java:79:
>  error: heading used out of sequence: , compared to implicit preceding 
> heading: 
>   [javadoc]  * Important Notes Which parts are merged?
> ...
>   [javadoc] 3 errors
>   [javadoc] 100 warnings
> {noformat}
> All 3 errors must be fixed, would be good also to address the warnings.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nutch] lewismc commented on pull request #760: NUTCH-2972 Javadoc build fails using JDK 17

2023-02-28 Thread via GitHub


lewismc commented on PR #760:
URL: https://github.com/apache/nutch/pull/760#issuecomment-1448285390

   We should upgrade the entire codebase to JDK 17. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NUTCH-2972) Javadoc build fails using JDK 17

2023-02-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/NUTCH-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694590#comment-17694590
 ] 

ASF GitHub Bot commented on NUTCH-2972:
---

lewismc commented on PR #760:
URL: https://github.com/apache/nutch/pull/760#issuecomment-1448281571

   +1




> Javadoc build fails using JDK 17
> 
>
> Key: NUTCH-2972
> URL: https://issues.apache.org/jira/browse/NUTCH-2972
> Project: Nutch
>  Issue Type: Sub-task
>  Components: build, documentation
>Affects Versions: 1.20
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Major
>  Labels: help-wanted
> Fix For: 1.20
>
>
> Creating the Javadocs fails using JDK 17:
> {noformat}
> $> JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 ant javadoc
> ...
>   [javadoc] 
> /home/wastl/data0/proj/crawler/nutch/git/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java:79:
>  error: heading used out of sequence: , compared to implicit preceding 
> heading: 
>   [javadoc]  * Important Notes Which parts are merged?
> ...
>   [javadoc] 3 errors
>   [javadoc] 100 warnings
> {noformat}
> All 3 errors must be fixed, would be good also to address the warnings.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nutch] lewismc commented on pull request #760: NUTCH-2972 Javadoc build fails using JDK 17

2023-02-28 Thread via GitHub


lewismc commented on PR #760:
URL: https://github.com/apache/nutch/pull/760#issuecomment-1448281571

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org