[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556726#comment-13556726
]
Hudson commented on NUTCH-1274:
---
Integrated in Nutch-2.x-Windows #5 (See
[https://builds.apache.org/job/Nutch-2.x-Windows/5/])
NUTCH-1274 Fix [cast] javac warnings (Revision 1432471)
Result = FAILURE
lewismc : http://svn.apache.org/viewvc/nutch/branches/2.x/?view=revrev=1432471
Files :
* /nutch/branches/2.x/CHANGES.txt
* /nutch/branches/2.x/src/java/org/apache/nutch/api/DbReader.java
* /nutch/branches/2.x/src/java/org/apache/nutch/crawl/WebTableReader.java
* /nutch/branches/2.x/src/java/org/apache/nutch/fetcher/FetcherReducer.java
*
/nutch/branches/2.x/src/java/org/apache/nutch/indexer/solr/SolrMappingReader.java
* /nutch/branches/2.x/src/java/org/apache/nutch/indexer/solr/SolrWriter.java
* /nutch/branches/2.x/src/java/org/apache/nutch/tools/arc/ArcRecordReader.java
* /nutch/branches/2.x/src/test/org/apache/nutch/parse/TestParserFactory.java
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Assignee: Tejas Patil
Priority: Minor
Fix For: 1.7, 2.2
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-2.x.v2.patch,
NUTCH-1274-trunk.patch, NUTCH-1274-trunk.v2.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556731#comment-13556731
]
Hudson commented on NUTCH-1274:
---
Integrated in Nutch-trunk-Windows #4 (See
[https://builds.apache.org/job/Nutch-trunk-Windows/4/])
NUTCH-1274 Fix [cast] javac warnings (Revision 1432469)
Result = FAILURE
lewismc : http://svn.apache.org/viewvc/nutch/trunk/?view=revrev=1432469
Files :
* /nutch/trunk/CHANGES.txt
* /nutch/trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java
* /nutch/trunk/src/java/org/apache/nutch/crawl/CrawlDbReader.java
* /nutch/trunk/src/java/org/apache/nutch/crawl/CrawlDbReducer.java
* /nutch/trunk/src/java/org/apache/nutch/crawl/Generator.java
* /nutch/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java
* /nutch/trunk/src/java/org/apache/nutch/indexer/solr/SolrMappingReader.java
* /nutch/trunk/src/java/org/apache/nutch/parse/ParseOutputFormat.java
* /nutch/trunk/src/java/org/apache/nutch/parse/ParseSegment.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkDumper.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkRank.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/Loops.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/WebGraph.java
* /nutch/trunk/src/java/org/apache/nutch/segment/ContentAsTextInputFormat.java
* /nutch/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java
* /nutch/trunk/src/java/org/apache/nutch/segment/SegmentReader.java
* /nutch/trunk/src/java/org/apache/nutch/tools/FreeGenerator.java
* /nutch/trunk/src/java/org/apache/nutch/tools/arc/ArcRecordReader.java
* /nutch/trunk/src/test/org/apache/nutch/parse/TestParserFactory.java
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Assignee: Tejas Patil
Priority: Minor
Fix For: 1.7, 2.2
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-2.x.v2.patch,
NUTCH-1274-trunk.patch, NUTCH-1274-trunk.v2.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551964#comment-13551964
]
Hudson commented on NUTCH-1274:
---
Integrated in Nutch-trunk #2081 (See
[https://builds.apache.org/job/Nutch-trunk/2081/])
NUTCH-1274 Fix [cast] javac warnings (Revision 1432469)
Result = SUCCESS
lewismc : http://svn.apache.org/viewvc/nutch/trunk/?view=revrev=1432469
Files :
* /nutch/trunk/CHANGES.txt
* /nutch/trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java
* /nutch/trunk/src/java/org/apache/nutch/crawl/CrawlDbReader.java
* /nutch/trunk/src/java/org/apache/nutch/crawl/CrawlDbReducer.java
* /nutch/trunk/src/java/org/apache/nutch/crawl/Generator.java
* /nutch/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java
* /nutch/trunk/src/java/org/apache/nutch/indexer/solr/SolrMappingReader.java
* /nutch/trunk/src/java/org/apache/nutch/parse/ParseOutputFormat.java
* /nutch/trunk/src/java/org/apache/nutch/parse/ParseSegment.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkDumper.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkRank.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/Loops.java
* /nutch/trunk/src/java/org/apache/nutch/scoring/webgraph/WebGraph.java
* /nutch/trunk/src/java/org/apache/nutch/segment/ContentAsTextInputFormat.java
* /nutch/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java
* /nutch/trunk/src/java/org/apache/nutch/segment/SegmentReader.java
* /nutch/trunk/src/java/org/apache/nutch/tools/FreeGenerator.java
* /nutch/trunk/src/java/org/apache/nutch/tools/arc/ArcRecordReader.java
* /nutch/trunk/src/test/org/apache/nutch/parse/TestParserFactory.java
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Assignee: Tejas Patil
Priority: Minor
Fix For: 1.7, 2.2
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-2.x.v2.patch,
NUTCH-1274-trunk.patch, NUTCH-1274-trunk.v2.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551791#comment-13551791
]
Lewis John McGibbney commented on NUTCH-1274:
-
Hi Tejas. The trunk patch does not fully address all [cast] flags. SOme still
exist in the following classes
Webgraph @line 348
ContextAsTextInputFormat @ 52, 53
SegmentMerger @ 216
SegmentReader @240
FreeGenerator @127
ArcRecordReader @125, 132, 267, 269
TestParserFactory @52, 54, 56
If you wish to address these then please do, I'll also have a trawl through the
2.x patch just now.
Thank you for your contributions.
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Priority: Minor
Fix For: 1.7
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-trunk.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551792#comment-13551792
]
Lewis John McGibbney commented on NUTCH-1274:
-
Hi Tejas, the only ones missing in the 2.x patch are present around lines 52,
54 56 in TestParserFactory.
Please say if you would like me to take these on... alternatively I can assign
the issue to you?
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Priority: Minor
Fix For: 1.7
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-trunk.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551809#comment-13551809
]
Tejas Patil commented on NUTCH-1274:
Hi Lewis, I will do those changes. You can assign this jira to me.
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Priority: Minor
Fix For: 1.7
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-trunk.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551815#comment-13551815
]
Tejas Patil commented on NUTCH-1274:
Hi Lewis,
I took a fresh checkout of trunk and applied the patch to it. I could not see
any of the [cast] flags that you pointed out ([build
log|http://pastebin.com/gxTJDXMj]). My guess is that our java versions are
different. Is this the right Java version:
{noformat}java version 1.7.0_10
Java(TM) SE Runtime Environment (build 1.7.0_10-b18)
Java HotSpot(TM) 64-Bit Server VM (build 23.6-b04, mixed mode)
{noformat}
This is the
[latest|http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html]
Oracles' Java version currently available. From
[Jenkins|https://builds.apache.org/job/Nutch-trunk/], I gather that JDK 1.7 is
used for nutch builds but not sure which bundle is used (OpenJdk or Oracle).
Please let me know the same so that I would continue ahead.
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Assignee: Tejas Patil
Priority: Minor
Fix For: 1.7
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-trunk.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
[
https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551818#comment-13551818
]
Lewis John McGibbney commented on NUTCH-1274:
-
Hi Tejas, I'm working from 1.6 ish locally (I am just leaving for home just
now). You are correct, the nightly console output from Jenkins with Java 7 does
in fact miss most of the [cast]'s highlighted by Java 1.6. TestParserFactory
still applies to the nightly build though.
In all honesty thanks for pointing out that different Java JDK's give different
results with regards to these messages, I didn't realise that this was the case.
Unless you wish to add to this, I am happy to commit with the TestParserFactory
[cast]'s added in. Same therefore applies to 2.x. Thank you.
Fix [cast] javac warnings
-
Key: NUTCH-1274
URL: https://issues.apache.org/jira/browse/NUTCH-1274
Project: Nutch
Issue Type: Sub-task
Components: build
Affects Versions: nutchgora, 1.5
Reporter: Lewis John McGibbney
Assignee: Tejas Patil
Priority: Minor
Fix For: 1.7
Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-trunk.patch
A typical example of this is
{code}
trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast]
redundant cast to int
[javac] res ^= (int)(signature[i] 24 + signature[i+1] 16 +
{code}
these should all be fixed by replacing with the correct implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
