[jira] [Commented] (NUTCH-2500) Add pull-reqest template to github
[
https://issues.apache.org/jira/browse/NUTCH-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488933#comment-16488933
]
Hudson commented on NUTCH-2500:
---
SUCCESS: Integrated in Jenkins build Nutch-trunk #3526 (See
[https://builds.apache.org/job/Nutch-trunk/3526/])
NUTCH-2500 Add pull-reqest template for github (snagel:
[https://github.com/apache/nutch/commit/2cf5e1cc8cc9eef70c1af39330f4d377ae5ab156])
* (add) .github/pull_request_template.md
> Add pull-reqest template to github
> --
>
> Key: NUTCH-2500
> URL: https://issues.apache.org/jira/browse/NUTCH-2500
> Project: Nutch
> Issue Type: Improvement
> Components: documentation
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Minor
>
> Github allows to add [pull request
> templates](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
> For contributors already familiar with github from other projects that's
> probably the best place to show a check list which helps us to get pull
> requests merged more quickly. Here's a draft:
> {noformat}
> Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)!
> Your help is appreciated!
> Before opening the pull request, please verify that
> * there is an open issue on the [Nutch issue
> tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the
> problem or the improvement. We cannot accept pull requests without an issue
> because the change wouldn't be listed in the release notes.
> * the issue ID (`NUTCH-`)
> - is referenced in the title of the pull request
> - and placed in front of your commit messages
> * commits are squashed into a single one (or few commits for larger changes)
> * Java source code follows [Nutch Eclipse Code Formatting
> rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
> * Nutch builds and unit tests pass by running `ant clean runtime test`
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUTCH-2500) Add pull-reqest template to github
[
https://issues.apache.org/jira/browse/NUTCH-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488915#comment-16488915
]
Hudson commented on NUTCH-2500:
---
SUCCESS: Integrated in Jenkins build Nutch-nutchgora #1609 (See
[https://builds.apache.org/job/Nutch-nutchgora/1609/])
NUTCH-2500 Add pull-reqest template for github (snagel:
[https://github.com/apache/nutch/commit/ea62c401b4eb62beee10c3540d448c0b858dcbb6])
* (add) .github/pull_request_template.md
> Add pull-reqest template to github
> --
>
> Key: NUTCH-2500
> URL: https://issues.apache.org/jira/browse/NUTCH-2500
> Project: Nutch
> Issue Type: Improvement
> Components: documentation
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Minor
>
> Github allows to add [pull request
> templates](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
> For contributors already familiar with github from other projects that's
> probably the best place to show a check list which helps us to get pull
> requests merged more quickly. Here's a draft:
> {noformat}
> Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)!
> Your help is appreciated!
> Before opening the pull request, please verify that
> * there is an open issue on the [Nutch issue
> tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the
> problem or the improvement. We cannot accept pull requests without an issue
> because the change wouldn't be listed in the release notes.
> * the issue ID (`NUTCH-`)
> - is referenced in the title of the pull request
> - and placed in front of your commit messages
> * commits are squashed into a single one (or few commits for larger changes)
> * Java source code follows [Nutch Eclipse Code Formatting
> rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
> * Nutch builds and unit tests pass by running `ant clean runtime test`
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUTCH-2500) Add pull-reqest template to github
[
https://issues.apache.org/jira/browse/NUTCH-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488890#comment-16488890
]
ASF GitHub Bot commented on NUTCH-2500:
---
sebastian-nagel closed pull request #333: NUTCH-2500 Add pull-reqest template
for github
URL: https://github.com/apache/nutch/pull/333
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 0..e549eb0e3
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,13 @@
+Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)! Your
help is appreciated!
+
+Before opening the pull request, please verify that
+* there is an open issue on the [Nutch issue
tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
+* the issue ID (`NUTCH-`)
+ - is referenced in the title of the pull request
+ - and placed in front of your commit messages
+* commits are squashed into a single one (or few commits for larger changes)
+* Java source code follows [Nutch Eclipse Code Formatting
rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
+* Nutch is successfully built and unit tests pass by running `ant clean
runtime test`
+* there should be no conflicts when merging the pull request branch into the
*recent* master branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled master branch.
+
+We will be able to faster integrate your pull request if these conditions are
met. If you have any questions how to fix your problem or about using Nutch in
general, please sign up for the [Nutch mailing
list](http://nutch.apache.org/mailing_lists.html). Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add pull-reqest template to github
> --
>
> Key: NUTCH-2500
> URL: https://issues.apache.org/jira/browse/NUTCH-2500
> Project: Nutch
> Issue Type: Improvement
>Reporter: Sebastian Nagel
>Priority: Minor
>
> Github allows to add [pull request
> templates](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
> For contributors already familiar with github from other projects that's
> probably the best place to show a check list which helps us to get pull
> requests merged more quickly. Here's a draft:
> {noformat}
> Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)!
> Your help is appreciated!
> Before opening the pull request, please verify that
> * there is an open issue on the [Nutch issue
> tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the
> problem or the improvement. We cannot accept pull requests without an issue
> because the change wouldn't be listed in the release notes.
> * the issue ID (`NUTCH-`)
> - is referenced in the title of the pull request
> - and placed in front of your commit messages
> * commits are squashed into a single one (or few commits for larger changes)
> * Java source code follows [Nutch Eclipse Code Formatting
> rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
> * Nutch builds and unit tests pass by running `ant clean runtime test`
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUTCH-2500) Add pull-reqest template to github
[
https://issues.apache.org/jira/browse/NUTCH-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487637#comment-16487637
]
ASF GitHub Bot commented on NUTCH-2500:
---
lewismc commented on issue #333: NUTCH-2500 Add pull-reqest template for github
URL: https://github.com/apache/nutch/pull/333#issuecomment-391422290
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add pull-reqest template to github
> --
>
> Key: NUTCH-2500
> URL: https://issues.apache.org/jira/browse/NUTCH-2500
> Project: Nutch
> Issue Type: Improvement
>Reporter: Sebastian Nagel
>Priority: Minor
>
> Github allows to add [pull request
> templates](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
> For contributors already familiar with github from other projects that's
> probably the best place to show a check list which helps us to get pull
> requests merged more quickly. Here's a draft:
> {noformat}
> Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)!
> Your help is appreciated!
> Before opening the pull request, please verify that
> * there is an open issue on the [Nutch issue
> tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the
> problem or the improvement. We cannot accept pull requests without an issue
> because the change wouldn't be listed in the release notes.
> * the issue ID (`NUTCH-`)
> - is referenced in the title of the pull request
> - and placed in front of your commit messages
> * commits are squashed into a single one (or few commits for larger changes)
> * Java source code follows [Nutch Eclipse Code Formatting
> rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
> * Nutch builds and unit tests pass by running `ant clean runtime test`
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUTCH-2500) Add pull-reqest template to github
[
https://issues.apache.org/jira/browse/NUTCH-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487070#comment-16487070
]
ASF GitHub Bot commented on NUTCH-2500:
---
sebastian-nagel opened a new pull request #333: NUTCH-2500 Add pull-reqest
template for github
URL: https://github.com/apache/nutch/pull/333
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add pull-reqest template to github
> --
>
> Key: NUTCH-2500
> URL: https://issues.apache.org/jira/browse/NUTCH-2500
> Project: Nutch
> Issue Type: Improvement
>Reporter: Sebastian Nagel
>Priority: Minor
>
> Github allows to add [pull request
> templates](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
> For contributors already familiar with github from other projects that's
> probably the best place to show a check list which helps us to get pull
> requests merged more quickly. Here's a draft:
> {noformat}
> Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)!
> Your help is appreciated!
> Before opening the pull request, please verify that
> * there is an open issue on the [Nutch issue
> tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the
> problem or the improvement. We cannot accept pull requests without an issue
> because the change wouldn't be listed in the release notes.
> * the issue ID (`NUTCH-`)
> - is referenced in the title of the pull request
> - and placed in front of your commit messages
> * commits are squashed into a single one (or few commits for larger changes)
> * Java source code follows [Nutch Eclipse Code Formatting
> rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
> * Nutch builds and unit tests pass by running `ant clean runtime test`
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
