[jira] [Commented] (NUTCH-2662) index-jexl-filter plugin throws a RuntimeException if its enabled but not configured
[
https://issues.apache.org/jira/browse/NUTCH-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655180#comment-16655180
]
Jorge Luis Betancourt Gonzalez commented on NUTCH-2662:
---
[~yossi] Yes, I know :). At the time, I didn't notice that the actual
recommendation (the message shown to the user) is to pick an expression
(true/false) which can be done automatically and log the default value. The
second validation that checks if the expression is syntactically correct it's
still valid.
> index-jexl-filter plugin throws a RuntimeException if its enabled but not
> configured
>
>
> Key: NUTCH-2662
> URL: https://issues.apache.org/jira/browse/NUTCH-2662
> Project: Nutch
> Issue Type: Improvement
> Components: plugin
>Affects Versions: 1.16
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Jorge Luis Betancourt Gonzalez
>Priority: Minor
>
> If the index-jexl-filter plugin is enabled but no configuration is provided
> in the {{index.jexl.filter}} property the plugin throws a RuntimeException.
> In the same exception message, we advise to either set true or false to index
> all/none.
> This is a case where we can just select a sane default and log a warning, but
> not stop the entire process. I think this is more consistent with how we
> approach configuration in general: Only fail if there is an actual error in
> the configuration (i.e parse error on the expression).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUTCH-2662) index-jexl-filter plugin throws a RuntimeException if its enabled but not configured
[
https://issues.apache.org/jira/browse/NUTCH-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655082#comment-16655082
]
Yossi Tamari commented on NUTCH-2662:
-
[~jorgelbg], this goes against your own review comment on this plugin:
[https://github.com/apache/nutch/pull/219#discussion_r136044914]
> index-jexl-filter plugin throws a RuntimeException if its enabled but not
> configured
>
>
> Key: NUTCH-2662
> URL: https://issues.apache.org/jira/browse/NUTCH-2662
> Project: Nutch
> Issue Type: Improvement
> Components: plugin
>Affects Versions: 1.16
>Reporter: Jorge Luis Betancourt Gonzalez
>Assignee: Jorge Luis Betancourt Gonzalez
>Priority: Minor
>
> If the index-jexl-filter plugin is enabled but no configuration is provided
> in the {{index.jexl.filter}} property the plugin throws a RuntimeException.
> In the same exception message, we advise to either set true or false to index
> all/none.
> This is a case where we can just select a sane default and log a warning, but
> not stop the entire process. I think this is more consistent with how we
> approach configuration in general: Only fail if there is an actual error in
> the configuration (i.e parse error on the expression).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
