RE: [PATCH] stm32/stm32f7/stm32h7: Fix bugs in SERIAL_CONSOLE definition

[BERNET Markus]

Sorry about that, now with .txt extension


-Original Message-
From: Xiang Xiao  
Sent: Dienstag, 10. März 2020 11:29
To: dev@nuttx.apache.org
Subject: Re: [PATCH] stm32/stm32f7/stm32h7: Fix bugs in SERIAL_CONSOLE 
definition

This email is not from Hexagon’s Office 365 instance. Please be careful while 
clicking links, opening attachments, or replying to this email.


Or send PR to:
https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-nuttx%2Fpullsdata=02%7C01%7C%7C8c627582846c461ed67708d7c4dddc37%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C637194329483318246sdata=%2BNN8ppE13l7ue%2B8LAOyEiJ3w9SnwAaxFThuN0jUBCsQ%3Dreserved=0
This is more interactive than email loop.

On Tue, Mar 10, 2020 at 6:11 PM Abdelatif Guettouche 
 wrote:
>
> Hi,
>
> Thanks for the patch, however the attachment didn't come through.
> Could you please send it again with a .txt extension?
>
> Thanks.
>
> On Tue, Mar 10, 2020 at 9:59 AM BERNET Markus  
> wrote:
> >
> > Hi all,
> >
> >
> >
> > I’ve found some typos in the SERIAL_CONSOLE definition, see attached patch.
> >
> >
> >
> > Best regards,
> >
> > Markus
> >
> >
> >
> > Markus Bernet
> > Senior Software Engineer
> > T: +41 41 729 87 49
> > E: markus.ber...@hexagon.com
> >
> > Hexagon Mining
> > Baarerstrasse 133
> > 6300 Zug, Switzerland
> > hexagonmining.com | LinkedIn | Facebook | Twitter
> >
> >
> >
> >
From 354cb45fe21bc5cc70833ef313ea657884d16cc6 Mon Sep 17 00:00:00 2001
From: Markus Bernet 
Date: Fri, 6 Mar 2020 16:46:18 +0100
Subject: [PATCH] stm32/stm32f7/stm32h7: Fix bugs in SERIAL_CONSOLE definition

---
 arch/arm/src/stm32/stm32_uart.h   | 3 +--
 arch/arm/src/stm32f7/stm32_uart.h | 3 +--
 arch/arm/src/stm32h7/stm32_uart.h | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/src/stm32/stm32_uart.h b/arch/arm/src/stm32/stm32_uart.h
index 99e950c9a1..a4117c51a8 100644
--- a/arch/arm/src/stm32/stm32_uart.h
+++ b/arch/arm/src/stm32/stm32_uart.h
@@ -249,7 +249,6 @@
 #  undef CONFIG_UART4_SERIAL_CONSOLE
 #  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_USART6_SERIAL_CONSOLE
-#  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_UART8_SERIAL_CONSOLE
 #  define CONSOLE_UART 7
 #  define HAVE_CONSOLE 1
@@ -258,7 +257,7 @@
 #  undef CONFIG_USART2_SERIAL_CONSOLE
 #  undef CONFIG_USART3_SERIAL_CONSOLE
 #  undef CONFIG_UART4_SERIAL_CONSOLE
-#  undef CONFIG_UART6_SERIAL_CONSOLE
+#  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_USART6_SERIAL_CONSOLE
 #  undef CONFIG_UART7_SERIAL_CONSOLE
 #  define CONSOLE_UART 8
diff --git a/arch/arm/src/stm32f7/stm32_uart.h 
b/arch/arm/src/stm32f7/stm32_uart.h
index 9c326811d8..1ce0a7f212 100644
--- a/arch/arm/src/stm32f7/stm32_uart.h
+++ b/arch/arm/src/stm32f7/stm32_uart.h
@@ -156,7 +156,6 @@
 #  undef CONFIG_UART4_SERIAL_CONSOLE
 #  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_USART6_SERIAL_CONSOLE
-#  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_UART8_SERIAL_CONSOLE
 #  define CONSOLE_UART 7
 #  define HAVE_CONSOLE 1
@@ -165,7 +164,7 @@
 #  undef CONFIG_USART2_SERIAL_CONSOLE
 #  undef CONFIG_USART3_SERIAL_CONSOLE
 #  undef CONFIG_UART4_SERIAL_CONSOLE
-#  undef CONFIG_UART6_SERIAL_CONSOLE
+#  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_USART6_SERIAL_CONSOLE
 #  undef CONFIG_UART7_SERIAL_CONSOLE
 #  define CONSOLE_UART 8
diff --git a/arch/arm/src/stm32h7/stm32_uart.h 
b/arch/arm/src/stm32h7/stm32_uart.h
index bdd6bc9d81..c6cab46d5d 100644
--- a/arch/arm/src/stm32h7/stm32_uart.h
+++ b/arch/arm/src/stm32h7/stm32_uart.h
@@ -156,7 +156,6 @@
 #  undef CONFIG_UART4_SERIAL_CONSOLE
 #  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_USART6_SERIAL_CONSOLE
-#  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_UART8_SERIAL_CONSOLE
 #  define CONSOLE_UART 7
 #  define HAVE_CONSOLE 1
@@ -165,7 +164,7 @@
 #  undef CONFIG_USART2_SERIAL_CONSOLE
 #  undef CONFIG_USART3_SERIAL_CONSOLE
 #  undef CONFIG_UART4_SERIAL_CONSOLE
-#  undef CONFIG_UART6_SERIAL_CONSOLE
+#  undef CONFIG_UART5_SERIAL_CONSOLE
 #  undef CONFIG_USART6_SERIAL_CONSOLE
 #  undef CONFIG_UART7_SERIAL_CONSOLE
 #  define CONSOLE_UART 8
-- 
2.20.1.windows.1

[PATCH] stm32/stm32f7/stm32h7: Fix bugs in SERIAL_CONSOLE definition

[BERNET Markus]

Hi all,

I've found some typos in the SERIAL_CONSOLE definition, see attached patch.

Best regards,
Markus

Markus Bernet
Senior Software Engineer
T: +41 41 729 87 49
E: markus.ber...@hexagon.com
Hexagon Mining
Baarerstrasse 133
6300 Zug, Switzerland
hexagonmining.com | 
LinkedIn | 
Facebook
 | 
Twitter