Re: [DISCUSS] NuttX 9.1 RC1
On Fri, Jul 3, 2020 at 7:44 PM Brennan Ashton wrote: > > Haitao, > Thanks for catching that. I suspect this might have been around for a > while in the zip releases. > The release script checks out a tag to make sure we are getting what > we expect so I dont think we cut the wrong code > > What looks to be going on is we have files in .gitignore that are > being stripped when zipme.sh calls tar > ./nuttx/tools/zipme.sh:TAR+=" --exclude-vcs-ignores --exclude-vcs" > We are also stripping out all the z80 asm files which is really bad. > > I did a diff between the tag and the release tarball and I found this > diff -rq nuttx/ ../incubator-nuttx | grep -v gitignore > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_handlers.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_init.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_handlers.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_init.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_loader.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_program.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_getsp.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_io.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqcommon.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqsave.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_progentry.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_reset.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_restorecontext.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_saveusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_startup.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_head.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_restoreusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_rom.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_romvectors.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_saveusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectcommon.asm > Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectors.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_head.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_restoreusercontext.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_rom.asm > Only in ../incubator-nuttx/arch/z80/src/z80: z80_saveusercontext.asm > Only in ../incubator-nuttx: .asf.yaml > Only in ../incubator-nuttx/boards/arm/samd5e5/metro-m4/scripts: nvm.srec > Only in ../incubator-nuttx/boards/arm/samd5e5/same54-xplained-pro/scripts: > nvm.srec > Only in ../incubator-nuttx/boards/sim/sim/sim/src/etc: init.d > Only in ../incubator-nuttx: .git > Only in ../incubator-nuttx: .github > Only in nuttx/: .version > > Anyone have a suggestion on how to handle this? I am tempted to > remove that option. > That would require making sure the repo is clean. I do this anyway by > doing a fresh shallow clone of the repo and checking that the tag is > exactly matching the commit > > --Brennan Opened an issue in github. https://github.com/apache/incubator-nuttx/issues/1363 --Brennan
Re: [DISCUSS] NuttX 9.1 RC1
Haitao, Thanks for catching that. I suspect this might have been around for a while in the zip releases. The release script checks out a tag to make sure we are getting what we expect so I dont think we cut the wrong code What looks to be going on is we have files in .gitignore that are being stripped when zipme.sh calls tar ./nuttx/tools/zipme.sh:TAR+=" --exclude-vcs-ignores --exclude-vcs" We are also stripping out all the z80 asm files which is really bad. I did a diff between the tag and the release tarball and I found this diff -rq nuttx/ ../incubator-nuttx | grep -v gitignore Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_handlers.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_init.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_handlers.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_init.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_loader.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_program.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_getsp.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_io.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqcommon.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqsave.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_progentry.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_reset.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_restorecontext.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_saveusercontext.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_startup.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_head.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_restoreusercontext.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_rom.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_romvectors.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_saveusercontext.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectcommon.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectors.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_head.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_restoreusercontext.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_rom.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_saveusercontext.asm Only in ../incubator-nuttx: .asf.yaml Only in ../incubator-nuttx/boards/arm/samd5e5/metro-m4/scripts: nvm.srec Only in ../incubator-nuttx/boards/arm/samd5e5/same54-xplained-pro/scripts: nvm.srec Only in ../incubator-nuttx/boards/sim/sim/sim/src/etc: init.d Only in ../incubator-nuttx: .git Only in ../incubator-nuttx: .github Only in nuttx/: .version Anyone have a suggestion on how to handle this? I am tempted to remove that option. That would require making sure the repo is clean. I do this anyway by doing a fresh shallow clone of the repo and checking that the tag is exactly matching the commit --Brennan On Fri, Jul 3, 2020 at 7:04 PM Haitao Liu wrote: > > I have just downloaded > https://dist.apache.org/repos/dist/dev/incubator/nuttx/9.1.0-RC1/ and built > sim:nsh which reports rcS missing as below. > But I checked the release/9.1 branch with rcS change inside. So I wonder if > the 9.1.0-RC1 is not align to the latest 9.1 branch code. > > make[1]: Entering directory '/home/haitao/test/nuttx/arch/sim/src' > make[2]: Entering directory '/home/haitao/test/nuttx/boards/sim/sim/sim/src' > make[2]: *** No rule to make target 'etc/init.d/rcS', needed by > 'etctmp/etc/init.d/rcS'. Stop. > make[2]: Leaving directory '/home/haitao/test/nuttx/boards/sim/sim/sim/src' > Makefile:326: recipe for target '.depend' failed > make[1]: *** [.depend] Error 2 > make[1]: Leaving directory '/home/haitao/test/nuttx/arch/sim/src' > tools/Makefile.unix:441: recipe for target 'pass2dep' failed > > Brennan Ashton 于2020年6月27日周六 上午1:48写道： > > > Hey everyone, > > There were several bugs found on the RC0 so we will not be moving forward > > with that release candidate and will be creating RC1. I had suggested a > > few days ago creating the release today, but as we merged some changes > > yesterday that seems to be rushed. > > > > I'm proposing that we move forward cutting the RC1 on Sunday 28th. I would > > encourage everyone to test with the fixes that have been backported already > > to the releases/9.1 branch. I know there is an outstanding bug report that > > was sent to the list but this is not even in master yet. > > > > > > https://lists.apache.org/x/thread.html/rbb1f85b5f2dba9ee221548fcc5f99d49ef55522c487b99c1549c3a52@%3Cdev.nuttx.apache.org%3E > > > > > > Thanks, > > Brennan > >
Re: [DISCUSS] NuttX 9.1 RC1
I have just downloaded https://dist.apache.org/repos/dist/dev/incubator/nuttx/9.1.0-RC1/ and built sim:nsh which reports rcS missing as below. But I checked the release/9.1 branch with rcS change inside. So I wonder if the 9.1.0-RC1 is not align to the latest 9.1 branch code. make[1]: Entering directory '/home/haitao/test/nuttx/arch/sim/src' make[2]: Entering directory '/home/haitao/test/nuttx/boards/sim/sim/sim/src' make[2]: *** No rule to make target 'etc/init.d/rcS', needed by 'etctmp/etc/init.d/rcS'. Stop. make[2]: Leaving directory '/home/haitao/test/nuttx/boards/sim/sim/sim/src' Makefile:326: recipe for target '.depend' failed make[1]: *** [.depend] Error 2 make[1]: Leaving directory '/home/haitao/test/nuttx/arch/sim/src' tools/Makefile.unix:441: recipe for target 'pass2dep' failed Brennan Ashton 于2020年6月27日周六 上午1:48写道： > Hey everyone, > There were several bugs found on the RC0 so we will not be moving forward > with that release candidate and will be creating RC1. I had suggested a > few days ago creating the release today, but as we merged some changes > yesterday that seems to be rushed. > > I'm proposing that we move forward cutting the RC1 on Sunday 28th. I would > encourage everyone to test with the fixes that have been backported already > to the releases/9.1 branch. I know there is an outstanding bug report that > was sent to the list but this is not even in master yet. > > > https://lists.apache.org/x/thread.html/rbb1f85b5f2dba9ee221548fcc5f99d49ef55522c487b99c1549c3a52@%3Cdev.nuttx.apache.org%3E > > > Thanks, > Brennan >
Sv: [DISCUSS] NuttX 9.1 RC1
Thanks for cutting the release I will test it today Regards Alin Från: Nathan Hartman Skickat: den 30 juni 2020 01:35 Till: dev@nuttx.apache.org Ämne: Re: [DISCUSS] NuttX 9.1 RC1 On Mon, Jun 29, 2020 at 6:04 PM Brennan Ashton wrote: > I held off on cutting the release yesterday since not everything had > been backported yet and I had not heard of any other testing. > > There is one remaining PR for a backport which I just opened > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dnuttx_pull_1330=DwIBaQ=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc=9PLdMPCoy-UxqQeL_7fkXjdHjEO-awBtN4-Wr8MqKGE=5Htug5pjd6wHmAH5R-e_GsqNL27IkG5jG66AXwwveU8=bgdAPO9eqT9gEKh95BU9_9CF4cDk-2Ndkc_YKQD3TNM= > > I can get some feedback about going ahead creating the RC1 tonight I > will, but otherwise I will not be able to do it until Thursday or > Friday (stepping away from the computer for a few days) It looks like Greg backported PR-1330 to 9.1. I think that was the only outstanding thing for RC1. Hopefully you're still able to create RC1 tonight... Thanks for everything, Nathan
Re: [DISCUSS] NuttX 9.1 RC1
On Mon, Jun 29, 2020 at 6:04 PM Brennan Ashton wrote: > I held off on cutting the release yesterday since not everything had > been backported yet and I had not heard of any other testing. > > There is one remaining PR for a backport which I just opened > https://github.com/apache/incubator-nuttx/pull/1330 > > I can get some feedback about going ahead creating the RC1 tonight I > will, but otherwise I will not be able to do it until Thursday or > Friday (stepping away from the computer for a few days) It looks like Greg backported PR-1330 to 9.1. I think that was the only outstanding thing for RC1. Hopefully you're still able to create RC1 tonight... Thanks for everything, Nathan
Re: [DISCUSS] NuttX 9.1 RC1
I held off on cutting the release yesterday since not everything had been backported yet and I had not heard of any other testing. There is one remaining PR for a backport which I just opened https://github.com/apache/incubator-nuttx/pull/1330 I can get some feedback about going ahead creating the RC1 tonight I will, but otherwise I will not be able to do it until Thursday or Friday (stepping away from the computer for a few days) Thanks, Brennan
Re: [DISCUSS] NuttX 9.1 RC1
More time sounds good, I'll retest on Saturday. -adam On Fri, Jun 26, 2020 at 3:47 PM Nathan Hartman wrote: > On Fri, Jun 26, 2020 at 1:48 PM Brennan Ashton > wrote: > > > Hey everyone, > > There were several bugs found on the RC0 so we will not be moving forward > > with that release candidate and will be creating RC1. I had suggested a > > few days ago creating the release today, but as we merged some changes > > yesterday that seems to be rushed. > > > > I'm proposing that we move forward cutting the RC1 on Sunday 28th. I > would > > encourage everyone to test with the fixes that have been backported > already > > to the releases/9.1 branch. I know there is an outstanding bug report > that > > was sent to the list but this is not even in master yet. > > > > > > > https://lists.apache.org/x/thread.html/rbb1f85b5f2dba9ee221548fcc5f99d49ef55522c487b99c1549c3a52@%3Cdev.nuttx.apache.org%3E > > > > > Yes, more time for testing sounds good to me. > > Thanks, > Nathan > -- Adam Feuer
Re: [DISCUSS] NuttX 9.1 RC1
On Fri, Jun 26, 2020 at 1:48 PM Brennan Ashton wrote: > Hey everyone, > There were several bugs found on the RC0 so we will not be moving forward > with that release candidate and will be creating RC1. I had suggested a > few days ago creating the release today, but as we merged some changes > yesterday that seems to be rushed. > > I'm proposing that we move forward cutting the RC1 on Sunday 28th. I would > encourage everyone to test with the fixes that have been backported already > to the releases/9.1 branch. I know there is an outstanding bug report that > was sent to the list but this is not even in master yet. > > > https://lists.apache.org/x/thread.html/rbb1f85b5f2dba9ee221548fcc5f99d49ef55522c487b99c1549c3a52@%3Cdev.nuttx.apache.org%3E > Yes, more time for testing sounds good to me. Thanks, Nathan
Re: [DISCUSS] NuttX 9.1 RC1
Thanks Brennan, I'll retest everything tomorrow //Alin On Fri, Jun 26, 2020, 20:48 Brennan Ashton wrote: > Hey everyone, > There were several bugs found on the RC0 so we will not be moving forward > with that release candidate and will be creating RC1. I had suggested a > few days ago creating the release today, but as we merged some changes > yesterday that seems to be rushed. > > I'm proposing that we move forward cutting the RC1 on Sunday 28th. I would > encourage everyone to test with the fixes that have been backported already > to the releases/9.1 branch. I know there is an outstanding bug report that > was sent to the list but this is not even in master yet. > > > https://lists.apache.org/x/thread.html/rbb1f85b5f2dba9ee221548fcc5f99d49ef55522c487b99c1549c3a52@%3Cdev.nuttx.apache.org%3E > > > Thanks, > Brennan >
[DISCUSS] NuttX 9.1 RC1
Hey everyone, There were several bugs found on the RC0 so we will not be moving forward with that release candidate and will be creating RC1. I had suggested a few days ago creating the release today, but as we merged some changes yesterday that seems to be rushed. I'm proposing that we move forward cutting the RC1 on Sunday 28th. I would encourage everyone to test with the fixes that have been backported already to the releases/9.1 branch. I know there is an outstanding bug report that was sent to the list but this is not even in master yet. https://lists.apache.org/x/thread.html/rbb1f85b5f2dba9ee221548fcc5f99d49ef55522c487b99c1549c3a52@%3Cdev.nuttx.apache.org%3E Thanks, Brennan
