Re: Github Issue on Build Failure
On Wed, Mar 11, 2020 at 12:57 AM Anthony Merlino wrote: > > I have been inactive for some time now, but I would like to get back up to > speed and start making some contributions. One thing I was hoping to do was > help get rid of some of the nightly build errors so that we can get a > stable base and hopefully make a release soon. I spent the time getting the > docker container set up and understanding how the current CI system works. > Thanks to those who have been putting in the effort on this. > > I got the basics working and then looked to the nightly build log from last > night so that I could try and replicate, then fix a bug. To my surprise, > the build that failed last night built successfully. Of course a quick look > at the recent commits shows that Xiang already fixed the issue. > The most build error inside the source code get fixed in recent month, but two parallel build system issues happen randomly, that is why you can pass the nightly build sometime especially if you run make with small number of job. BTW, github precheck action seldom hit the parallel build issue just because github's VM has two CPU core only and we invoke make with -j2. > This brings up a point that I saw mentioned in one of the email threads - > we should use the Jenkins build failure to create an issue for us. This > will allow us to see what progress is being made on each issue, and know if > it has been resolved or not. Of course there is still a race condition > where two people decide to pick up the same task at once, but this could be > solved by the contributor assigning the issue to themselves, or commenting > on it stating they are going to look into it. > > It looks like there is a Jenkins plugin that allows the Github issue to be > created relatively easily. I'd be happy to try and get this working if > everyone agrees. > > https://plugins.jenkins.io/github-issues/ > It's a great addon to the nightly build system. > Justin, could you please give me admin access to Jenkins? All committers should already got the admin permission by default, you can try login with your apache account here: https://builds.apache.org https://builds.apache.org/job/NuttX-Nightly-Build/ > > Best, > Anthony
Re: Github Issue on Build Failure
On Wed, Mar 11, 2020 at 1:24 AM Gregory Nutt wrote: > > > >> It looks like there is a Jenkins plugin that allows the Github issue to be > > created relatively easily. I'd be happy to try and get this working if > > everyone agrees. > Just as a matter of practicality, it would be good to restrict to build > failures and not style check problems, at least for the time being. > Maybe later we could add style issues.When we get license checking > in place, the same would apply. We would also have to restrict this to > files that exist, not to files being added. Only github precheck action do the style check, the nightly build just run full build test.
Re: Github Issue on Build Failure
It looks like there is a Jenkins plugin that allows the Github issue to be created relatively easily. I'd be happy to try and get this working if everyone agrees. Just as a matter of practicality, it would be good to restrict to build failures and not style check problems, at least for the time being. Maybe later we could add style issues. When we get license checking in place, the same would apply. We would also have to restrict this to files that exist, not to files being added.
RE: Github Issue on Build Failure
> It looks like there is a Jenkins plugin that allows the Github issue to be created relatively easily. I'd be happy to try and get this working if everyone agrees. +1 -Original Message- From: Anthony Merlino [mailto:anth...@vergeaero.com] Sent: Tuesday, March 10, 2020 9:57 AM To: dev@nuttx.apache.org Subject: Github Issue on Build Failure I have been inactive for some time now, but I would like to get back up to speed and start making some contributions. One thing I was hoping to do was help get rid of some of the nightly build errors so that we can get a stable base and hopefully make a release soon. I spent the time getting the docker container set up and understanding how the current CI system works. Thanks to those who have been putting in the effort on this. I got the basics working and then looked to the nightly build log from last night so that I could try and replicate, then fix a bug. To my surprise, the build that failed last night built successfully. Of course a quick look at the recent commits shows that Xiang already fixed the issue. This brings up a point that I saw mentioned in one of the email threads - we should use the Jenkins build failure to create an issue for us. This will allow us to see what progress is being made on each issue, and know if it has been resolved or not. Of course there is still a race condition where two people decide to pick up the same task at once, but this could be solved by the contributor assigning the issue to themselves, or commenting on it stating they are going to look into it. It looks like there is a Jenkins plugin that allows the Github issue to be created relatively easily. I'd be happy to try and get this working if everyone agrees. https://plugins.jenkins.io/github-issues/ Justin, could you please give me admin access to Jenkins? Best, Anthony
Re: Github Issue on Build Failure
I have been inactive for some time now, but I would like to get back up to speed and start making some contributions. I am really glad to see back!
Github Issue on Build Failure
I have been inactive for some time now, but I would like to get back up to speed and start making some contributions. One thing I was hoping to do was help get rid of some of the nightly build errors so that we can get a stable base and hopefully make a release soon. I spent the time getting the docker container set up and understanding how the current CI system works. Thanks to those who have been putting in the effort on this. I got the basics working and then looked to the nightly build log from last night so that I could try and replicate, then fix a bug. To my surprise, the build that failed last night built successfully. Of course a quick look at the recent commits shows that Xiang already fixed the issue. This brings up a point that I saw mentioned in one of the email threads - we should use the Jenkins build failure to create an issue for us. This will allow us to see what progress is being made on each issue, and know if it has been resolved or not. Of course there is still a race condition where two people decide to pick up the same task at once, but this could be solved by the contributor assigning the issue to themselves, or commenting on it stating they are going to look into it. It looks like there is a Jenkins plugin that allows the Github issue to be created relatively easily. I'd be happy to try and get this working if everyone agrees. https://plugins.jenkins.io/github-issues/ Justin, could you please give me admin access to Jenkins? Best, Anthony
