[jira] [Closed] (OFBIZ-4435) Fixed typo in ProductionRun class.
[ https://issues.apache.org/jira/browse/OFBIZ-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4435. -- Resolution: Fixed Fix Version/s: (was: Release Branch 11.04) (was: Release Branch 10.04) (was: Release Branch 09.04) Assignee: Jacques Le Roux Thanks Deepak, Despite your effort I have decided to not backport in releases, too much work for me for a so little thing Your patch is in trunk at r1175124 Fixed typo in ProductionRun class. -- Key: OFBIZ-4435 URL: https://issues.apache.org/jira/browse/OFBIZ-4435 Project: OFBiz Issue Type: Bug Components: manufacturing Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4435-Trunk.patch, OFBIZ-4435.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4410) breadcrumbs.ftl code is not efficient
[ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4410. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Kiran, Your patch is in trunk at r1175127 Just a little remark: when you provide a patch from Eclipse (using Subclipse), please follow [these recommendations|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)] : Eclipse internal command (don't use finish but rather select project to avoid the 2 1st lines in the patch), ie {code} ### Eclipse Workspace Patch 1.0 #P ofbiz-trunk {code} Else when applying from eclipse we get a project conflict. Not a big deal, but faster for us ;) BTW at r1175130, I have also fixed a bug introduced at r737506, for a better formatting of breadcrumbs breadcrumbs.ftl code is not efficient - Key: OFBIZ-4410 URL: https://issues.apache.org/jira/browse/OFBIZ-4410 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Release Branch 10.04 Reporter: Kiran Gawde Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch, OFBIZ-4410-breadcrumbsEfficientCode.patch breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4434) ajaxAutocompleteOptions.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4434. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Christian, Your patch is in trunk at r1175122 ajaxAutocompleteOptions.ftl --- Key: OFBIZ-4434 URL: https://issues.apache.org/jira/browse/OFBIZ-4434 Project: OFBiz Issue Type: Improvement Reporter: Christian Fischer Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: ajaxAutocompleteOptions.ftl.patch Before the patch, the content was made HTML-safe, what wasn't necessary for the autocomplete. Also, it displayed things like Fumlr, because it made the umlauts HTML-safe, too. The patch uses the stringwrapper from the stringUtil.java to avoid the general HTML auto-encoding. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4441) UtilXml firstChildElement should use getNodeName instead of getLocalName
[ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113941#comment-13113941 ] Jacques Le Roux commented on OFBIZ-4441: Please guys dont repeat useless information already present in previous tickets. I'd even appreciate if you could clean those above, thanks UtilXml firstChildElement should use getNodeName instead of getLocalName Key: OFBIZ-4441 URL: https://issues.apache.org/jira/browse/OFBIZ-4441 Project: OFBiz Issue Type: Bug Components: framework Reporter: Kiran Gawde Priority: Minor Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4440) OnePageCheckout breaks when you are logged in with userid that belongs to PartyGroup
[ https://issues.apache.org/jira/browse/OFBIZ-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4440. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Release Branch 10.04 Release Branch 09.04 Assignee: Jacques Le Roux Thanks Kiran, Fixed in trunk r1175135 R11.04 r1175138 R10.04 r1175137 R09.04 r1175141 OnePageCheckout breaks when you are logged in with userid that belongs to PartyGroup Key: OFBIZ-4440 URL: https://issues.apache.org/jira/browse/OFBIZ-4440 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release 10.04 Reporter: Kiran Gawde Assignee: Jacques Le Roux Fix For: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk OnePageCheckout breaks when you are logged in with userid that belongs to PartyGroup. But the quickcheckout doesn't break. This is due to the fact that EditShippingAddress has following line which returns null. person = delegator.findByPrimaryKey(Person, [partyId : party.partyId]); -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1175135 - /ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
Hello Jacques, Inline:- +context.partyId = party.partyId +if (Person.equals(party.partyTypeId)) { +person = delegator.findByPrimaryKey(Person, [partyId : party.partyId]); I think partyTypeId check should be (PERSON.equals(party.partyTypeId)) instead of (Person.equals(party.partyTypeId)) -- Thanks and Regards Amit Sharma HotWax Media http://www.hotwaxmedia.com
Re: svn commit: r1175135 - /ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
Opps right AMIT... Thanks Jacques From: Amit Sharma amit.sha...@hotwaxmedia.com Hello Jacques, Inline:- +context.partyId = party.partyId +if (Person.equals(party.partyTypeId)) { +person = delegator.findByPrimaryKey(Person, [partyId : party.partyId]); I think partyTypeId check should be (PERSON.equals(party.partyTypeId)) instead of (Person.equals(party.partyTypeId)) -- Thanks and Regards Amit Sharma HotWax Media http://www.hotwaxmedia.com
[jira] [Commented] (OFBIZ-4435) Fixed typo in ProductionRun class.
[ https://issues.apache.org/jira/browse/OFBIZ-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113945#comment-13113945 ] Deepak Dixit commented on OFBIZ-4435: - No issue Jacques, Thanks. Fixed typo in ProductionRun class. -- Key: OFBIZ-4435 URL: https://issues.apache.org/jira/browse/OFBIZ-4435 Project: OFBiz Issue Type: Bug Components: manufacturing Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4435-Trunk.patch, OFBIZ-4435.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4403) The Orders tab in Catalog Products is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4403. -- Resolution: Fixed Backported in R10.04 from r1170469 at r1175161 The Orders tab in Catalog Products is not working. Key: OFBIZ-4403 URL: https://issues.apache.org/jira/browse/OFBIZ-4403 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk Reporter: Atul Vani Assignee: Sascha Rodekamp Fix For: Release Branch 11.04, SVN trunk, Release 10.04 Attachments: OFBIZ-4403.patch, OFBIZ-4403.patch, OFBIZ-4403.patch The Orders tab in Catalog Products is not working. The reason being that the CommonProductDecorator has got a condition 'notif-empty field=product//not' in it, which fails for the ViewProductOrder screen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4429) No HTML comments in CSV rendering
[ https://issues.apache.org/jira/browse/OFBIZ-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113955#comment-13113955 ] Jacques Le Roux commented on OFBIZ-4429: For now, a workaround is to set widgetVerbose false in the screen context (this is now possible again since r1172954: http://svn.apache.org/viewvc?rev=1172954view=rev) No HTML comments in CSV rendering - Key: OFBIZ-4429 URL: https://issues.apache.org/jira/browse/OFBIZ-4429 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Fix For: SVN trunk HTML comments are outputted for CSV (because there's no csv element and you have to use html) element. No HTML comments should be outputted for csv. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1175130 - /ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/breadcrumbs.ftl
If nobody disagree, I will backport this in releases. It introduces an improvement from https://issues.apache.org/jira/browse/OFBIZ-4410 but alsofixes a bad breadcrumbs rendering (from 2009-01-25) Jacques Author: jleroux Date: Sat Sep 24 08:43:22 2011 New Revision: 1175130 URL: http://svn.apache.org/viewvc?rev=1175130view=rev Log: For a better formatting of breadcrumbs in all cases, fixes a bug introduced (for Visual themes) at r737506 Modified: ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/breadcrumbs.ftl Modified: ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/breadcrumbs.ftl URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/breadcrumbs.ftl?rev=1175130r1=1175129r2=1175130view=diff == --- ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/breadcrumbs.ftl (original) +++ ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/breadcrumbs.ftl Sat Sep 24 08:43:22 2011 @@ -17,14 +17,20 @@ specific language governing permissions under the License. -- div class=breadcrumbs +#assign isDefaultTheme = !layoutSettings.VT_FTR_TMPLT_LOC?contains(multiflex) +#if isDefaultTheme + a href=@ofbizUrlmain/@ofbizUrl class=linktext${uiLabelMap.CommonMain}/a gt; +#else ul li - a href=@ofbizUrlmain/@ofbizUrl class=linktext${uiLabelMap.CommonMain}/a gt; + a href=@ofbizUrlmain/@ofbizUrl class=linktext${uiLabelMap.CommonMain}/a /li +/#if #-- Show the category branch -- #assign crumbs = Static[org.ofbiz.product.category.CategoryWorker].getTrail(request)/ #list crumbs as crumb #if catContentWrappers?exists catContentWrappers[crumb]?exists +#if !isDefaultTheme li a href=@ofbizCatalogUrl currentCategoryId=crumb previousCategoryId=previousCategoryId!/ class=#if crumb_has_nextlinktext#elsebuttontextdisabled/#if #if catContentWrappers[crumb].get(CATEGORY_NAME)?exists @@ -36,12 +42,28 @@ under the License. /#if /a /li - #assign previousCategoryId = crumb / +#else + a href=@ofbizCatalogUrl currentCategoryId=crumb previousCategoryId=previousCategoryId!/ class=#if crumb_has_nextlinktext#elsebuttontextdisabled/#if + #if catContentWrappers[crumb].get(CATEGORY_NAME)?exists + ${catContentWrappers[crumb].get(CATEGORY_NAME)} + #elseif catContentWrappers[crumb].get(DESCRIPTION)?exists + ${catContentWrappers[crumb].get(DESCRIPTION)} + #else + ${crumb} + /#if + /a + #if crumb_has_next gt;/#if +/#if +#assign previousCategoryId = crumb / /#if /#list #-- Show the product, if there is one -- #if productContentWrapper?exists -li${productContentWrapper.get(PRODUCT_NAME)?if_exists}/li + #if isDefaultTheme + nbsp;gt; ${productContentWrapper.get(PRODUCT_NAME)?if_exists} + #else + li${productContentWrapper.get(PRODUCT_NAME)?if_exists}/li +/ul + /#if /#if - /ul /div
[jira] [Created] (OFBIZ-4445) On register page, billing address same as shipping doesn't copy the phone number
On register page, billing address same as shipping doesn't copy the phone number Key: OFBIZ-4445 URL: https://issues.apache.org/jira/browse/OFBIZ-4445 Project: OFBiz Issue Type: Bug Reporter: Kiran Gawde Steps: 1. Click register 2. enter the shipping address 3. Click 'billing address same as shipping address' Issue: Billing phone number is not populated. Also it is not disabled. Question: In ofbiz, we have two separate contact for phone and postal address. But do we believe that on the UI they should be treated separately? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4445) On register page, billing address same as shipping doesn't copy the phone number
[ https://issues.apache.org/jira/browse/OFBIZ-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kiran Gawde updated OFBIZ-4445: --- Priority: Minor (was: Major) On register page, billing address same as shipping doesn't copy the phone number Key: OFBIZ-4445 URL: https://issues.apache.org/jira/browse/OFBIZ-4445 Project: OFBiz Issue Type: Bug Reporter: Kiran Gawde Priority: Minor Steps: 1. Click register 2. enter the shipping address 3. Click 'billing address same as shipping address' Issue: Billing phone number is not populated. Also it is not disabled. Question: In ofbiz, we have two separate contact for phone and postal address. But do we believe that on the UI they should be treated separately? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4446) OnePageCheckout creates new billing/shipping phone number even if user selects the default values
OnePageCheckout creates new billing/shipping phone number even if user selects the default values - Key: OFBIZ-4446 URL: https://issues.apache.org/jira/browse/OFBIZ-4446 Project: OFBiz Issue Type: Bug Reporter: Kiran Gawde Priority: Minor Steps: 1. Make sure the logged in user has billing/shipping phone number in the profile. 2. Add item to cart, and select 'onepagecheckout' 3. submit the order 4. Login to admin ui 5. Check the party profile. Issue: 1. You will notice two new contacts for shipping/billing phone number. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4446) OnePageCheckout creates new billing/shipping phone number even if user selects the default values
[ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114016#comment-13114016 ] Kiran Gawde commented on OFBIZ-4446: This happens due to the error in CheckoutService.xml. It is missing following lines: set field=createUpdatePartyTelecomNumberCtx.contactMechId from-field=parameters.shipToPhoneContactMechId / set field=createUpdatePartyTelecomNumberCtx.contactMechId from-field=parameters.billToPhoneContactMechId / OnePageCheckout creates new billing/shipping phone number even if user selects the default values - Key: OFBIZ-4446 URL: https://issues.apache.org/jira/browse/OFBIZ-4446 Project: OFBiz Issue Type: Bug Reporter: Kiran Gawde Priority: Minor Steps: 1. Make sure the logged in user has billing/shipping phone number in the profile. 2. Add item to cart, and select 'onepagecheckout' 3. submit the order 4. Login to admin ui 5. Check the party profile. Issue: 1. You will notice two new contacts for shipping/billing phone number. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4446) OnePageCheckout creates new billing/shipping phone number even if user selects the default values
[ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114019#comment-13114019 ] Kiran Gawde commented on OFBIZ-4446: Also not sure, but I feel checkoutProcess.js has two incorrect lines: jQuery('#shipToPhoneContactMechId').val(json.phoneContactMechId); jQuery('#billToPhoneContactMechId').val(json.phoneContactMechId); As the json fields return from the services (CheckoutServices.xml) are shipToPhoneContactMechId and billToPhoneContactMechId respectively. OnePageCheckout creates new billing/shipping phone number even if user selects the default values - Key: OFBIZ-4446 URL: https://issues.apache.org/jira/browse/OFBIZ-4446 Project: OFBiz Issue Type: Bug Reporter: Kiran Gawde Priority: Minor Steps: 1. Make sure the logged in user has billing/shipping phone number in the profile. 2. Add item to cart, and select 'onepagecheckout' 3. submit the order 4. Login to admin ui 5. Check the party profile. Issue: 1. You will notice two new contacts for shipping/billing phone number. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4446) OnePageCheckout creates new billing/shipping phone number even if user selects the default values
[ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114021#comment-13114021 ] Kiran Gawde commented on OFBIZ-4446: One more related error: The field names in the form are phoneContactMechId. These should be renamed to shipToPhoneContactMechId and billToPhoneContactMechId. OnePageCheckout creates new billing/shipping phone number even if user selects the default values - Key: OFBIZ-4446 URL: https://issues.apache.org/jira/browse/OFBIZ-4446 Project: OFBiz Issue Type: Bug Reporter: Kiran Gawde Priority: Minor Steps: 1. Make sure the logged in user has billing/shipping phone number in the profile. 2. Add item to cart, and select 'onepagecheckout' 3. submit the order 4. Login to admin ui 5. Check the party profile. Issue: 1. You will notice two new contacts for shipping/billing phone number. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Use sequenceNum on EntityType ?
EntityTypeGroupAssoc is an interesting idea Nicolas. Other opinions? Jacques From: Nicolas Malin malin.nico...@librenberry.net Hi Rishi, thanks for your reply Rishi Solanki a écrit : Hi Nicolas, Currently only StatusItem and may 1 or 2 entities have this ability i.e sequenceNum as a field to reorder the types in the drop-down. There is no way to reorder the types in the drop-down, we just arrange it by its id or description. When I configure a customer site, it's difficult to change id or description to reorder the types, but it's true for labellised type that it's not the description on the entity that is used. The sequenceNum it's the first easier step to reorder, but it's not the better way. On one site, you should have different order Type following the functional context. Another solution, is to add EntityTypeGroupAssoc (with attributes entityTypeGroupId, entityTypeId, description, comments, sequenceNum), that for a group, will give the Type list used to order, and other information that could be interesting for functional group parameter. Exemple for RoleType, it's a large entity, we can add RoleTypeGroup entity, to manage roleType following the functional context RoleTypeGroupAssoc OrderMgmt |- OrderMgmt, BILL_TO_CUSTOMER, , ,10 |- OrderMgmt, SHIP_TO_CUSTOMER, , , 20 |- OrderMgmt, END_USER_CUSTOMER, , ,30 |- OrderMgmt, BILL_FROM_VENDOR, , ,40 \- OrderMgmt, SHIP_FROM_VENDOR, , ,50 RoleTypeGroupAssoc SFA |- SFA, END_USER_CUSTOMER, , ,10 \- SFA, LEARNER, , ,20 This entity EntityTypeGroupAssoc, can be used on dropdown to filter and order type, but also for functional service. It's a complement of parentTypeId since parentTypeId create a main type hierarchy. Group create a multiple type hierarchy. Nicolas I personally think its interesting and nice idea to have this ability in all the EntityType, but not sure that to have the reordering ability for types we should add the sequenceNum or sequenceId. Lets come some more thoughts on this. Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Tue, Jul 12, 2011 at 2:41 PM, Nicolas Malin malin.nico...@librenberry.net mailto:malin.nico...@librenberry.net wrote: Hi, On a project I have reordered the drop-down type (CustRequestType, CommEvenType, etc ...) depending on the client's functional priorities. I caught sight it is difficult to do without an inherited form. For easy customer setup, adding a sequenceNum field on all EntityType will be interesting (with an generci entity-order on sequenceNum)? Or Do you have a particular practice run for just such cases Nicolas
Re: demos reboot
Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi, I noticed this morning that, when infra stops the VMs, OFBiz is not reloading when they restart. I guess we have to install rc.ofbiz.for.debian (I created it sometimes ago should be still ok) in etc. But I have no time to take care about it right now. If someone get a chance to look at it before me (not sure when) remember that we have specific settings for memory and especially for using SDK 6.0_23, see startofbiz.sh as a reference. For both trunk and stable and also R10.04 (Christian worked on that last one). I think I will never do that, who cares :o) Jacques BTW we still have to decide if we run only R10.04 or keep R9.04. I'd prefer to have them all. Of course only 3 will be possible (to be tested) and next year R11.04 will push R9.04 out... Jacques
Re: demos reboot
I get the distinct impression you have. I think everyone depends on you too much. Thanks for what you have done. Jacques Le Roux sent the following on 9/24/2011 3:02 PM: Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi, I noticed this morning that, when infra stops the VMs, OFBiz is not reloading when they restart. I guess we have to install rc.ofbiz.for.debian (I created it sometimes ago should be still ok) in etc. But I have no time to take care about it right now. If someone get a chance to look at it before me (not sure when) remember that we have specific settings for memory and especially for using SDK 6.0_23, see startofbiz.sh as a reference. For both trunk and stable and also R10.04 (Christian worked on that last one). I think I will never do that, who cares :o) Jacques BTW we still have to decide if we run only R10.04 or keep R9.04. I'd prefer to have them all. Of course only 3 will be possible (to be tested) and next year R11.04 will push R9.04 out... Jacques