Re: buildbot failure in ASF Buildbot on ofbiz-trunk
From: Jacques Le Roux jacques.le.r...@les7arts.com It's ok now, so I reverted changes below, it updates again to HEAD But we have still # temporary change until we fix the theme issue svn merge -c -1202849 http://svn.apache.org/repos/asf/ofbiz/trunk I think it's ok now, I will check that tomorrow... This is solved now, I removed the temporary change Jacques Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Done (should be ok soon), I changed check-svn-update.sh trunk-manual.sh and restarted trunk Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com From a report in user ML, seems that it's a bit more complicated. I will certainly force svn up -r 1231646 in trunk demo tomorrow morning... Until Sascha has fixed it... Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com I think it was because of framework/base/lib/slf4j-log4j12-1.6.4.jar I guess blamelist was done because of me also updating a commit comment Sascha at r1231656 should have fixed that. BuildBot apparently is not triggered on removed libs. We will see if I'm right at the next changes taken in account by BuildBot... Jacques From: build...@apache.org Sent: Sunday, January 15, 2012 12:37 PM The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/2520 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source Stamp: [branch ofbiz/trunk] 1231649 Blamelist: jleroux,sascharodekamp BUILD FAILED: failed compile_1 sincerely, -The Buildbot
[jira] [Updated] (OFBIZ-4580) Categories - calculated trails
[
https://issues.apache.org/jira/browse/OFBIZ-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Piper updated OFBIZ-4580:
--
Attachment: getCategoryTrail-patch.patch
Added a little service descriptor to go along with the function and fixed the
patch
Categories - calculated trails
--
Key: OFBIZ-4580
URL: https://issues.apache.org/jira/browse/OFBIZ-4580
Project: OFBiz
Issue Type: Improvement
Reporter: Paul Piper
Assignee: Jacques Le Roux
Priority: Minor
Attachments: CategoryWorker-with-trail-export.patch,
getCategoryTrail-patch.patch
Hey folks,
been a while since I contributed. I noticed that currently ofbiz misses a
simple function to generate a category trail. Generating a trail, however, is
often useful when generating breadcrums, facetted search results, and proper
category trees in general. Hence I created the following as a timesaver:
{code:title=getCategoryTrail|borderStyle=solid}
public static List getCategoryTrail(String productCategoryId,DispatchContext
dctx){
GenericDelegator delegator = (GenericDelegator)
dctx.getDelegator();
ListString trailElements = FastList.newInstance();
trailElements.add(productCategoryId);
String parentProductCategoryId = productCategoryId;
while (UtilValidate.isNotEmpty(parentProductCategoryId)) {
// find product category rollup
try {
ListEntityCondition rolllupConds = FastList.newInstance();
rolllupConds.add(EntityCondition.makeCondition(productCategoryId,
parentProductCategoryId));
rolllupConds.add(EntityUtil.getFilterByDateExpr());
ListGenericValue productCategoryRollups =
delegator.findList(ProductCategoryRollup,
EntityCondition.makeCondition(rolllupConds), null,
UtilMisc.toList(-fromDate), null, true);
if (UtilValidate.isNotEmpty(productCategoryRollups)) {
// add only categories that belong to the top category to
trail
for (GenericValue productCategoryRollup :
productCategoryRollups) {
String trailCategoryId =
productCategoryRollup.getString(parentProductCategoryId);
parentProductCategoryId = trailCategoryId;
if (trailElements.contains(trailCategoryId)) {
break;
}else{
trailElements.add(trailCategoryId);
}
}
} else {
parentProductCategoryId = null;
}
} catch (GenericEntityException e) {
Debug.logError(e, Cannot generate trail from product
category, module);
}
}
Collections.reverse(trailElements);
return trailElements;
}
{code}
I suggest to add this to the CategoryWorker.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4580) Categories - calculated trails
[
https://issues.apache.org/jira/browse/OFBIZ-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Piper updated OFBIZ-4580:
--
Attachment: (was: getCategoryTrail-patch.patch)
Categories - calculated trails
--
Key: OFBIZ-4580
URL: https://issues.apache.org/jira/browse/OFBIZ-4580
Project: OFBiz
Issue Type: Improvement
Reporter: Paul Piper
Assignee: Jacques Le Roux
Priority: Minor
Attachments: CategoryWorker-with-trail-export.patch
Hey folks,
been a while since I contributed. I noticed that currently ofbiz misses a
simple function to generate a category trail. Generating a trail, however, is
often useful when generating breadcrums, facetted search results, and proper
category trees in general. Hence I created the following as a timesaver:
{code:title=getCategoryTrail|borderStyle=solid}
public static List getCategoryTrail(String productCategoryId,DispatchContext
dctx){
GenericDelegator delegator = (GenericDelegator)
dctx.getDelegator();
ListString trailElements = FastList.newInstance();
trailElements.add(productCategoryId);
String parentProductCategoryId = productCategoryId;
while (UtilValidate.isNotEmpty(parentProductCategoryId)) {
// find product category rollup
try {
ListEntityCondition rolllupConds = FastList.newInstance();
rolllupConds.add(EntityCondition.makeCondition(productCategoryId,
parentProductCategoryId));
rolllupConds.add(EntityUtil.getFilterByDateExpr());
ListGenericValue productCategoryRollups =
delegator.findList(ProductCategoryRollup,
EntityCondition.makeCondition(rolllupConds), null,
UtilMisc.toList(-fromDate), null, true);
if (UtilValidate.isNotEmpty(productCategoryRollups)) {
// add only categories that belong to the top category to
trail
for (GenericValue productCategoryRollup :
productCategoryRollups) {
String trailCategoryId =
productCategoryRollup.getString(parentProductCategoryId);
parentProductCategoryId = trailCategoryId;
if (trailElements.contains(trailCategoryId)) {
break;
}else{
trailElements.add(trailCategoryId);
}
}
} else {
parentProductCategoryId = null;
}
} catch (GenericEntityException e) {
Debug.logError(e, Cannot generate trail from product
category, module);
}
}
Collections.reverse(trailElements);
return trailElements;
}
{code}
I suggest to add this to the CategoryWorker.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4580) Categories - calculated trails
[
https://issues.apache.org/jira/browse/OFBIZ-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Piper updated OFBIZ-4580:
--
Attachment: CategoryWorker.patch
This should be an example inclusion of how to wrap it in a service... maybe we
should consider doing both - adding the function first, before wrapping it in a
service.
Either way, this works fine but needs to be tested.
Categories - calculated trails
--
Key: OFBIZ-4580
URL: https://issues.apache.org/jira/browse/OFBIZ-4580
Project: OFBiz
Issue Type: Improvement
Reporter: Paul Piper
Assignee: Jacques Le Roux
Priority: Minor
Attachments: CategoryWorker-with-trail-export.patch,
CategoryWorker.patch
Hey folks,
been a while since I contributed. I noticed that currently ofbiz misses a
simple function to generate a category trail. Generating a trail, however, is
often useful when generating breadcrums, facetted search results, and proper
category trees in general. Hence I created the following as a timesaver:
{code:title=getCategoryTrail|borderStyle=solid}
public static List getCategoryTrail(String productCategoryId,DispatchContext
dctx){
GenericDelegator delegator = (GenericDelegator)
dctx.getDelegator();
ListString trailElements = FastList.newInstance();
trailElements.add(productCategoryId);
String parentProductCategoryId = productCategoryId;
while (UtilValidate.isNotEmpty(parentProductCategoryId)) {
// find product category rollup
try {
ListEntityCondition rolllupConds = FastList.newInstance();
rolllupConds.add(EntityCondition.makeCondition(productCategoryId,
parentProductCategoryId));
rolllupConds.add(EntityUtil.getFilterByDateExpr());
ListGenericValue productCategoryRollups =
delegator.findList(ProductCategoryRollup,
EntityCondition.makeCondition(rolllupConds), null,
UtilMisc.toList(-fromDate), null, true);
if (UtilValidate.isNotEmpty(productCategoryRollups)) {
// add only categories that belong to the top category to
trail
for (GenericValue productCategoryRollup :
productCategoryRollups) {
String trailCategoryId =
productCategoryRollup.getString(parentProductCategoryId);
parentProductCategoryId = trailCategoryId;
if (trailElements.contains(trailCategoryId)) {
break;
}else{
trailElements.add(trailCategoryId);
}
}
} else {
parentProductCategoryId = null;
}
} catch (GenericEntityException e) {
Debug.logError(e, Cannot generate trail from product
category, module);
}
}
Collections.reverse(trailElements);
return trailElements;
}
{code}
I suggest to add this to the CategoryWorker.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Discussion: Column Screen Widgets
Yes this seems like a good complement to container to me What are the places you want to use this OOTB? Jacques From: Adrian Crum adrian.c...@sandglass-software.com I would like to implement two new screen widgets: column-container and column. The goal is to simplify multi-column layout. The column-container widget can have only column child elements and the column widget can have any screen widget child widgets. A width attribute can specify the width of the columns. In HTML, the column container is a combination of table and tr elements, and the columns are td elements. This will be different from the current floated div elements - mainly because getting the floating div layout to work correctly with pluggable widgets across visual themes has been unsuccessful. What do you think? -Adrian
Re: The Apache Software Foundation Projects
I created this patch. Is committing and updating /www/ofbiz.apache.org/ enough? Index: doap_OFBiz.rdf === --- doap_OFBiz.rdf (revision 1214648) +++ doap_OFBiz.rdf (working copy) @@ -52,7 +52,27 @@ /maintainer release Version -nameLast stable/name +nameApache OFBiz 11.04/name +created2011-05-02/created +revision11.04/revision +/Version +/release +Version +name(Last stable) Apache OFBiz 10.04/name +created2010-05-01/created +revision10.04/revision +/Version +/release +release +Version +name(Lastest 09.04) Apache OFBiz 09.04.01 /name +created2011-01-25/created +revision09.04.01/revision +/Version +/release +release +Version +nameApache OFBiz R09.04/name created2009-04-01/created revision09.04/revision /Version Using svn log --stop-on-copy creation.date to get the date at the bottom of creation.date file (tip from Bertrand http://grep.codeconsult.ch/2008/11/26/what-svn-revision-was-this-branch-created-in/) Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi Jacopo, Just stumbled upon http://projects.apache.org/projects/ofbiz.html Should we not update regarding releases? Should be only stable releases there? But then why showing 4.0. Just let me know and I will update... Thanks Jacques
Re: The Apache Software Foundation Projects
I just noticed we have a tag for all releases branches but not R11.04, normal? Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com I created this patch. Is committing and updating /www/ofbiz.apache.org/ enough? Index: doap_OFBiz.rdf === --- doap_OFBiz.rdf (revision 1214648) +++ doap_OFBiz.rdf (working copy) @@ -52,7 +52,27 @@ /maintainer release Version -nameLast stable/name +nameApache OFBiz 11.04/name +created2011-05-02/created +revision11.04/revision +/Version +/release +Version +name(Last stable) Apache OFBiz 10.04/name +created2010-05-01/created +revision10.04/revision +/Version +/release +release +Version +name(Lastest 09.04) Apache OFBiz 09.04.01 /name +created2011-01-25/created +revision09.04.01/revision +/Version +/release +release +Version +nameApache OFBiz R09.04/name created2009-04-01/created revision09.04/revision /Version Using svn log --stop-on-copy creation.date to get the date at the bottom of creation.date file (tip from Bertrand http://grep.codeconsult.ch/2008/11/26/what-svn-revision-was-this-branch-created-in/) Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi Jacopo, Just stumbled upon http://projects.apache.org/projects/ofbiz.html Should we not update regarding releases? Should be only stable releases there? But then why showing 4.0. Just let me know and I will update... Thanks Jacques
Re: The Apache Software Foundation Projects
Le 21/01/2012 15:49, Jacques Le Roux a écrit : I just noticed we have a tag for all releases branches but not R11.04, normal? Jacques 11.04 has still not been voted. It may explain this. CHeers, -- Erwan de FERRIERES www.nereide.biz
Re: [jira] [Updated] (OFBIZ-4580) Categories - calculated trails
Hello Paul, I agree that having such function to generate the trail would be useful. But this is an expensive operation (not sure if it would hit the cache) as it recursively lookups the parent category by doing query. A comment should be added to make it clear to user. When possible, you should set category_id and pcategory. These are used to update the trail (see setTrail). setTrail can be called from anywhere as below: curCategoryId = parameters.category_id ?: parameters.CATEGORY_ID ?: ; CategoryWorker.setTrail(request, curCategoryId); Cheers, Kiran
Re: The Apache Software Foundation Projects
Indeed, I forgot it does not appear yet on the download page Jacques From: Erwan de FERRIERES erwan.de-ferrie...@nereide.fr Le 21/01/2012 15:49, Jacques Le Roux a écrit : I just noticed we have a tag for all releases branches but not R11.04, normal? Jacques 11.04 has still not been voted. It may explain this. CHeers, -- Erwan de FERRIERES www.nereide.biz
Re: The Apache Software Foundation Projects
Since R11.04 is not yet official, the patch would be rather Index: doap_OFBiz.rdf === --- doap_OFBiz.rdf (revision 1214648) +++ doap_OFBiz.rdf (working copy) @@ -50,9 +50,30 @@ foaf:mbox rdf:resource=mailto:jaco...@apache.org/ /foaf:Person /maintainer +!--release +Version +nameApache OFBiz 11.04/name +created2011-05-02/created +revision11.04/revision +/Version +/release-- release Version -nameLast stable/name +name(Last stable) Apache OFBiz 10.04/name +created2010-05-01/created +revision10.04/revision +/Version +/release +release +Version +name(Lastest 09.04) Apache OFBiz 09.04.01 /name +created2011-01-25/created +revision09.04.01/revision +/Version +/release +release +Version +nameApache OFBiz R09.04/name created2009-04-01/created revision09.04/revision /Version Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com I created this patch. Is committing and updating /www/ofbiz.apache.org/ enough? Index: doap_OFBiz.rdf === --- doap_OFBiz.rdf (revision 1214648) +++ doap_OFBiz.rdf (working copy) @@ -52,7 +52,27 @@ /maintainer release Version -nameLast stable/name +nameApache OFBiz 11.04/name +created2011-05-02/created +revision11.04/revision +/Version +/release +Version +name(Last stable) Apache OFBiz 10.04/name +created2010-05-01/created +revision10.04/revision +/Version +/release +release +Version +name(Lastest 09.04) Apache OFBiz 09.04.01 /name +created2011-01-25/created +revision09.04.01/revision +/Version +/release +release +Version +nameApache OFBiz R09.04/name created2009-04-01/created revision09.04/revision /Version Using svn log --stop-on-copy creation.date to get the date at the bottom of creation.date file (tip from Bertrand http://grep.codeconsult.ch/2008/11/26/what-svn-revision-was-this-branch-created-in/) Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi Jacopo, Just stumbled upon http://projects.apache.org/projects/ofbiz.html Should we not update regarding releases? Should be only stable releases there? But then why showing 4.0. Just let me know and I will update... Thanks Jacques
Re: [jira] [Updated] (OFBIZ-4580) Categories - calculated trails
Kiran, I think Paul is not monitoring the dev ML. Your comment should be better in the Jira issue (from where it will be relayed to Paul, creator of the issue). This anyway is by and large true, to keep history, and ease comments flow Thanks Jacques From: ki...@objectedge.com Hello Paul, I agree that having such function to generate the trail would be useful. But this is an expensive operation (not sure if it would hit the cache) as it recursively lookups the parent category by doing query. A comment should be added to make it clear to user. When possible, you should set category_id and pcategory. These are used to update the trail (see setTrail). setTrail can be called from anywhere as below: curCategoryId = parameters.category_id ?: parameters.CATEGORY_ID ?: ; CategoryWorker.setTrail(request, curCategoryId); Cheers, Kiran
