[jira] [Closed] (OFBIZ-5842) Implement JUnit tests for Entity Query Builder
[ https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya closed OFBIZ-5842. -- Resolution: Fixed Thanks Arun for the contribution. Your changes are committed in trunk at r1635894. Thanks Scott, Jacopo Adrian for reviewing the patch content. -- Ashish Implement JUnit tests for Entity Query Builder -- Key: OFBIZ-5842 URL: https://issues.apache.org/jira/browse/OFBIZ-5842 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Arun Patidar Assignee: Ashish Vijaywargiya Priority: Minor Attachments: OFBIZ-5842.patch, OFBIZ-5842.patch As we have Entity Query Builder implemented in trunk (OFBIZ-4053) and now we should add Junit tests for its methods. As per initial analyses, we can write Junit tests for following methods of Entity Query Builder: 1. queryList() 2. queryFirst() 3. queryCount() 4. queryOne() 5. distinct() 6. filterByDate() 7. orderBy() 8. select() 9. cursorForwardOnly() 10. cursorScrollSensitive() 11. cursorScrollInSensitive() 12. fetchSize() 13. maxRows() 14. cache() 15. queryIterator() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-5844) Convert java files to EntityQuery
Arun Patidar created OFBIZ-5844: --- Summary: Convert java files to EntityQuery Key: OFBIZ-5844 URL: https://issues.apache.org/jira/browse/OFBIZ-5844 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Arun Patidar Priority: Minor Recently [~lektran] has been converted java files to use Entity Query methods in place of Entity Engine methods. Components that has been converted are as below: - content - humanres - manufacturing - ordermgr (partially converted) - Replaced findOne() method in all components And commit revisions are: r1635380, r1635381, r1635382 and r1635383 Remaining components to be convert are: - product - party - commonext - securityext - workeffort - ordermgr (remaining part) - specialpurpose -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5842) Implement JUnit tests for Entity Query Builder
[ https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193020#comment-14193020 ] Arun Patidar commented on OFBIZ-5842: - Thanks for the commit Ashish. Implement JUnit tests for Entity Query Builder -- Key: OFBIZ-5842 URL: https://issues.apache.org/jira/browse/OFBIZ-5842 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Arun Patidar Assignee: Ashish Vijaywargiya Priority: Minor Attachments: OFBIZ-5842.patch, OFBIZ-5842.patch As we have Entity Query Builder implemented in trunk (OFBIZ-4053) and now we should add Junit tests for its methods. As per initial analyses, we can write Junit tests for following methods of Entity Query Builder: 1. queryList() 2. queryFirst() 3. queryCount() 4. queryOne() 5. distinct() 6. filterByDate() 7. orderBy() 8. select() 9. cursorForwardOnly() 10. cursorScrollSensitive() 11. cursorScrollInSensitive() 12. fetchSize() 13. maxRows() 14. cache() 15. queryIterator() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-4572) Migration from json-lib to jackson
[ https://issues.apache.org/jira/browse/OFBIZ-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-4572. Resolution: Fixed Fix Version/s: Upcoming Branch Rev. 1635901 Migration from json-lib to jackson -- Key: OFBIZ-4572 URL: https://issues.apache.org/jira/browse/OFBIZ-4572 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Erwan de FERRIERES Assignee: Jacopo Cappellato Priority: Minor Fix For: Upcoming Branch According to various benchmarks, json-lib, based on the json.org implementation, is one of the slowest implementation for json parsing. Moreover, this project hasn't been updated since 2010-12-14 (latest release), and activity on the user mailing-list is empty. I found jackson, which seems to be a lot faster, and activity is bigger, with a lot of releases (next to monthly). Here are some links: benchmark: https://github.com/eishay/jvm-serializers/wiki/ Update on State of Json-parsing Performance: http://www.cowtowncoder.com/blog/archives/2009/02/entry_204.html Upgrade from org.json to Jackson, piece by piece, using jackson-module-org-json: http://www.cowtowncoder.com/blog/archives/2011/03/entry_447.html project's documentation: http://wiki.fasterxml.com/JacksonDocumentation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-3365) Clean JSON Service Event Handler
[
https://issues.apache.org/jira/browse/OFBIZ-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato closed OFBIZ-3365.
Resolution: Fixed
Fix Version/s: Upcoming Branch
Rev. 1635901
Clean JSON Service Event Handler
Key: OFBIZ-3365
URL: https://issues.apache.org/jira/browse/OFBIZ-3365
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Frank Lam
Assignee: Jacopo Cappellato
Priority: Minor
Fix For: Upcoming Branch
Attachments: cleanjson.patch
I ran into a small issue while using
org.ofbiz.webapp.event.JSONServiceEventHandler (typically referred to as
jsonservice in controller files). If I defined my service as such:
service name=foo engine=java location=my.Class invoke=someFunction
attribute name=mylist mode=OUT type=List optional=true/
/service
I would get the following in the content of my response:
{targetRequestUri:/foo,thisRequestUri:foo,mylist:[{some:stuff}],multiPartMap:{},_CONTROL_PATH_:/myapp/control,_CONTEXT_ROOT_:/Users/me/Documents/workspace/ofbiz/hot-deploy/mycomponent/webapp/myapp/,_SERVER_ROOT_URL_:http://localhost:8080}
where I would prefer to receive simply:
{mylist:[{some:stuff}]}
I've added another event handler to try to resolve this problem. The patch
is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-5790) Json string parameters as a service input are not recognized by OFBiz ServiceEventHandler.
[
https://issues.apache.org/jira/browse/OFBIZ-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato closed OFBIZ-5790.
Resolution: Fixed
Fix Version/s: Upcoming Branch
Rev. 1635901
Json string parameters as a service input are not recognized by OFBiz
ServiceEventHandler.
--
Key: OFBIZ-5790
URL: https://issues.apache.org/jira/browse/OFBIZ-5790
Project: OFBiz
Issue Type: Improvement
Affects Versions: Trunk
Reporter: Amardeep Singh Jhajj
Assignee: Jacopo Cappellato
Priority: Minor
Fix For: Upcoming Branch
Attachments: CommonEvents.java.patch, JSON.java.patch,
OFBIZ-5790.patch, jackson-annotations-2.4.0.jar, jackson-core-2.4.2.jar,
jackson-databind-2.4.2.jar
I was trying to pass the Json string as a input to a service, but is not
recognized by ServiceEventHandler.
Example Json String- {faciltyId: WebStoreWarehouse}
I worked on this issue and attached a patch here. Here I have used Jackson
Json library for parsing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-5751) Replace JSON Parser with proper library
[ https://issues.apache.org/jira/browse/OFBIZ-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-5751. Resolution: Fixed Fix Version/s: Upcoming Branch Rev. 1635901 Replace JSON Parser with proper library --- Key: OFBIZ-5751 URL: https://issues.apache.org/jira/browse/OFBIZ-5751 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Justen Walker Assignee: Jacopo Cappellato Priority: Minor Labels: json Fix For: Upcoming Branch Recently I was bitten by the JavaCC JSON parser. Apparently the folks developing JavaCC thought that encountering an unexpected token in the input stream should be treated like a StackOverflowError or OutOfMemoryError and derive from the Error class rather than Exceptions - guaranteeing that no sane try/catch block would be able to catch it (Since you aren't typically expected to catch [Errors|http://docs.oracle.com/javase/6/docs/api/java/lang/Error.html]) A bit peeved by this design bug, I did some more investigation as to when this class was added and why. I discovered that this was added 4 years ago (February 10 2010) with the commit message admitting that - even though it seemed unneeded - it would later be extended to be more useful. It has been 4 year since that commit and the code has not been touched. In that time (and perhaps even at that time) other production-ready libraries have been created for parsing JSON; some which are extensible and full featured as well those which are very simple and robust. (A list exists at [json.org|http://json.org/]) I don't see a need to keep maintaining a home-rolled JSON parsing library inside the project that has to be built by everyone when other libraries exist that do the job better and are less likely to have these pitfalls (due to being actively developed). *References* - [Rev 908712 - 10 Feb 2010|https://fisheye6.atlassian.com/changelog/ofbiz?cs=908712] - [File History of JSON.jj|https://fisheye6.atlassian.com/browse/ofbiz/trunk/framework/base/src/org/ofbiz/base/json/JSON.jj] - [json.org (list of java libraries)|http://json.org/] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193045#comment-14193045 ] Pierre Smits commented on OFBIZ-5434: - Jacques, This is something you might see happening when patches are not reviewed and committed in a timely fashiion. Regards, Pierre Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Attachments: OFBIZ-5434-PRODUCT_Labels.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-5434: Attachment: OFBIZ-5434-PRODUCT-UiLabels.patch This patch addresses the issue. Redo after original file got outdated. Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Attachments: OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5781) Convert Javolution collections into Java collections
[ https://issues.apache.org/jira/browse/OFBIZ-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193057#comment-14193057 ] Adrian Crum commented on OFBIZ-5781: I removed Javolution from most of the framework. I need a Groovy guru to remove Javolution from the Groovy scripts. Convert Javolution collections into Java collections Key: OFBIZ-5781 URL: https://issues.apache.org/jira/browse/OFBIZ-5781 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Deepak Dixit Assignee: Ashish Vijaywargiya -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5434: --- Attachment: OFBIZ-5434-PRODUCT_Labels.patch.1.rej OFBIZ-5434-PRODUCT_Labels.patch.2.rej OFBIZ-5434-PRODUCT_Labels.patch.3.rej Pierre, As you like, I committed what could be, 3 parts were rejected. If you are interested, I have attached them Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5434. -- Resolution: Implemented Fix Version/s: Upcoming Branch Commmitted: At revision: 1635916 Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193071#comment-14193071 ] Jacques Le Roux commented on OFBIZ-5434: Pierre, Ha too bad we crossed on wire, see what I have done before I saw your new patch which also have some rejects. I attach them here to let you choice if I should commit the new one, or? Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5434: --- Attachment: OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5780) Fix compilation warnings
[ https://issues.apache.org/jira/browse/OFBIZ-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-5780: - Priority: Minor (was: Critical) Fix compilation warnings Key: OFBIZ-5780 URL: https://issues.apache.org/jira/browse/OFBIZ-5780 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Deepak Dixit Assignee: Ashish Vijaywargiya Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193073#comment-14193073 ] Jacques Le Roux commented on OFBIZ-5434: Looking at it, I think it's better to commit your new patch and handle issues starting from OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, agreed? Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193075#comment-14193075 ] Jacques Le Roux commented on OFBIZ-5434: Even easier I could revert r1635916 and you would provide a new complete patch agains current trunk HEAD, Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193078#comment-14193078 ] Pierre Smits commented on OFBIZ-5434: - Yes, let's do that. Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193084#comment-14193084 ] Jacques Le Roux commented on OFBIZ-5434: Done, just attach your new complete patch Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193084#comment-14193084 ] Jacques Le Roux edited comment on OFBIZ-5434 at 11/1/14 11:09 AM: -- Done at r1635921, just attach your new complete patch was (Author: jacques.le.roux): Done, just attach your new complete patch Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193118#comment-14193118 ] Deepak Dixit commented on OFBIZ-5776: - Here is the proposed structure for resources webapp: - /resources/js/ |_date |_imagemanagement |_ - /resources/js : Move all the js file like (fieldlookup.js, selectall.sj), jquery folder - /resources/css : Move all css file related to ofbiz - /resources/images: Move all the images (excluding products images) related to framework related - /resources/icon : Move images/icon folder to resources/icon Move static resources from framework/images to framework/resources webapp - Key: OFBIZ-5776 URL: https://issues.apache.org/jira/browse/OFBIZ-5776 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Deepak Dixit Priority: Minor Move all the static resources form images webapp to resources webapp, as they all are more related to resources rather then images. Also we need to rearrange these resources based on their purpose, like - Move all js related files and plugins under resources/js - Move all the css related files and plugins under resources/css - Move all the images related to js and css under resources/images or resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193118#comment-14193118 ] Deepak Dixit edited comment on OFBIZ-5776 at 11/1/14 12:12 PM: --- Here is the proposed structure for resources webapp: /resources/js: Move all the js file like (fieldlookup.js, selectall.sj) - date - imagemanagement - jquery - plugins /resources/css : Move all css file related to ofbiz - catalog - humanres /resources/images: Move all the images (except products images) related to framework - portlets - rate - rtl - tabs /resources/icon : Move icons folder to resources/icons was (Author: deepak.dixit): Here is the proposed structure for resources webapp: - /resources/js/ |_date |_imagemanagement |_ - /resources/js : Move all the js file like (fieldlookup.js, selectall.sj), jquery folder - /resources/css : Move all css file related to ofbiz - /resources/images: Move all the images (excluding products images) related to framework related - /resources/icon : Move images/icon folder to resources/icon Move static resources from framework/images to framework/resources webapp - Key: OFBIZ-5776 URL: https://issues.apache.org/jira/browse/OFBIZ-5776 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Deepak Dixit Priority: Minor Move all the static resources form images webapp to resources webapp, as they all are more related to resources rather then images. Also we need to rearrange these resources based on their purpose, like - Move all js related files and plugins under resources/js - Move all the css related files and plugins under resources/css - Move all the images related to js and css under resources/images or resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-5434: Attachment: OFBIZ-5434-PRODUCT-Labels_NL.patch New file addressing the issue. Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-Labels_NL.patch, OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5434) Improvement of Dutch localization in Product
[ https://issues.apache.org/jira/browse/OFBIZ-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193134#comment-14193134 ] Jacques Le Roux commented on OFBIZ-5434: Completed: At revision: 1635945 Improvement of Dutch localization in Product Key: OFBIZ-5434 URL: https://issues.apache.org/jira/browse/OFBIZ-5434 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-5434-PRODUCT-Labels_NL.patch, OFBIZ-5434-PRODUCT-UiLabels-1.patch.rej, OFBIZ-5434-PRODUCT-UiLabels.patch, OFBIZ-5434-PRODUCT_Labels.patch, OFBIZ-5434-PRODUCT_Labels.patch.1.rej, OFBIZ-5434-PRODUCT_Labels.patch.2.rej, OFBIZ-5434-PRODUCT_Labels.patch.3.rej -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5764) Add/Revise Traditional Chinese (zh-TW) translation
[ https://issues.apache.org/jira/browse/OFBIZ-5764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5764. -- Resolution: Implemented At r1635946, I have commented out the Chinese duplicated labels, and fixed a NL labels Add/Revise Traditional Chinese (zh-TW) translation -- Key: OFBIZ-5764 URL: https://issues.apache.org/jira/browse/OFBIZ-5764 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS, ALL COMPONENTS Affects Versions: Upcoming Branch Reporter: Nick Ho Assignee: Jacques Le Roux Priority: Minor Fix For: Trunk Attachments: framework-translation-NOT-zh-TW.patch, framework-translation-zh-TW2.patch, locales_with_underscore_correction.zip, translation-zh-TW.zip Revisions are : 1. the locales with language code_country code (underscore in between) are revised to language code-country code (hyphen in between) to comply the XML schema specified in the beginning of every translation files - resource xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; 2. added/revised zh-TW translations in the framework, applications and specialpurpose folders to have consistent, commonly-used meaningful terms in Traditional Chinese. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
r1635901(?) issue
Hi, Starting at (it seems) r1635901 we have an error with testConverters Buildbot has a lunatic behaviour at the moment, so we can't rely on its messages. Weird because tests ran properly here around this revision (not sure it was this one) this morning. Please check, thanks Jacques PS: this should help java] java.lang.IllegalStateException: This object has been flagged as immutable (unchangeable), probably because it came from an Entity Engine cache. Cannot modify an immutable entity object. Use the clone method to create a mutable copy of this object. [java] at org.ofbiz.entity.GenericEntity.assertIsMutable(GenericEntity.java:158) [ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericEntity.removedFromDatasource(GenericEntity.java:303) [ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericDelegator.removeValue(GenericDelegator.java:1100) [ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericDelegator.removeValue(GenericDelegator.java:1064) [ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericDelegator.rollback(GenericDelegator.java:2878) [ofbiz-entity.jar:?] [java] at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:149) [ofbiz-testtools.jar:?] [java] at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237) [ofbiz-base.jar:?] [java] at org.ofbiz.base.start.Start.startStartLoaders(Start.java:342) [ofbiz.jar:?] [java] at org.ofbiz.base.start.Start.start(Start.java:368) [ofbiz.jar:?] [java] at org.ofbiz.base.start.Start.main(Start.java:135) [ofbiz.jar:?] [java] 2014-11-01 13:00:29,203 |main |GenericDelegator |E| Failure in removeValue operation for entity [TestingType]: java.lang.IllegalStateException: This object has been flagged as immutable (unchangeable), probably because it came from an Entity Engine cache. Cannot modify an immutable entity object. Use the clone method to create a mutable copy of this object.. Rolling back transaction. [java] java.lang.IllegalStateException: This object has been flagged as immutable (unchangeable), probably because it came from an Entity Engine cache. Cannot modify an immutable entity object. Use the clone method to create a mutable copy of this object. [java] at org.ofbiz.entity.GenericEntity.assertIsMutable(GenericEntity.java:158) ~[ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericEntity.removedFromDatasource(GenericEntity.java:303) ~[ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericDelegator.removeValue(GenericDelegator.java:1100) [ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericDelegator.removeValue(GenericDelegator.java:1064) [ofbiz-entity.jar:?] [java] at org.ofbiz.entity.GenericDelegator.rollback(GenericDelegator.java:2878) [ofbiz-entity.jar:?] [java] at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:149) [ofbiz-testtools.jar:?] [java] at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237) [ofbiz-base.jar:?] [java] at org.ofbiz.base.start.Start.startStartLoaders(Start.java:342) [ofbiz.jar:?] [java] at org.ofbiz.base.start.Start.start(Start.java:368) [ofbiz.jar:?] [java] at org.ofbiz.base.start.Start.main(Start.java:135) [ofbiz.jar:?] [java] 2014-11-01 13:00:29,204 |main |TransactionUtil |I| Transaction rolled back [java] 2014-11-01 13:00:29,205 |main |GenericDelegator |W| org.ofbiz.entity.GenericEntityException: java.lang.IllegalStateException: This object has been flagged as immutable (unchangeable), probably because it came from an Entity Engine cache. Cannot modify an immutable entity object. Use the clone method to create a mutable copy of this object. (This object has been flagged as immutable (unchangeable), probably because it came from an Entity Engine cache. Cannot modify an immutable entity object. Use the clone method to create a mutable copy of this object.) [java] 2014-11-01 13:00:29,274 |main |GenericDelegator |E| Failure in create operation for entity [TestingType]: org.ofbiz.entity.GenericEntityException: Error while inserting: [GenericEntity:TestingType][createdStamp,2014-11-01 13:00:29.205(java.sql.Timestamp)][createdTxStamp,2014-11-01 13:00:29.205(java.sql.Timestamp)][description,New Testing Type #Cache-0(java.lang.String)][lastUpdatedStamp,2014-11-01 13:00:29.205(java.sql.Timestamp)][lastUpdatedTxStamp,2014-11-01 13:00:29.205(java.sql.Timestamp)][testingTypeId,TEST-CACHE-1(java.lang.String)] (SQL Exception while executing the following:INSERT INTO OFBIZ.TESTING_TYPE (TESTING_TYPE_ID, DESCRIPTION, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (The statement was aborted because it would have caused a
[jira] [Closed] (OFBIZ-3775) IterateSectionWidget.java Is Not Thread-Safe
[ https://issues.apache.org/jira/browse/OFBIZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3775. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1635984. IterateSectionWidget.java Is Not Thread-Safe Key: OFBIZ-3775 URL: https://issues.apache.org/jira/browse/OFBIZ-3775 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 09.04, Release Branch 10.04, Trunk Reporter: Adrian Crum Fix For: Upcoming Branch Multiple threads alter the model object's state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-3776) ModelScreenWidget.Content Is Not Thread Safe
[ https://issues.apache.org/jira/browse/OFBIZ-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-3776. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1635957. ModelScreenWidget.Content Is Not Thread Safe Key: OFBIZ-3776 URL: https://issues.apache.org/jira/browse/OFBIZ-3776 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 09.04, Release Branch 10.04, Trunk Reporter: Adrian Crum Fix For: Upcoming Branch Rev 499264 introduced code that has multiple threads changing the state of the Content model. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193280#comment-14193280 ] Adrian Crum commented on OFBIZ-3774: Work on this begun with rev 1635990. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
