[jira] [Commented] (OFBIZ-6417) renderDateFindField doesn't reselect operation
[ https://issues.apache.org/jira/browse/OFBIZ-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563859#comment-14563859 ] Nicolas Malin commented on OFBIZ-6417: -- It's works fine. currently I didn't commit it on all branch because on 13.07 the date value haven't present after a refresh. I will check that. renderDateFindField doesn't reselect operation -- Key: OFBIZ-6417 URL: https://issues.apache.org/jira/browse/OFBIZ-6417 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Nicolas Malin Attachments: OFBIZ-6417.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563584#comment-14563584 ] Christian Carlow commented on OFBIZ-6310: - Thanks for the review Jacques, I'll pay better attention to those details for future patches. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[
https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Carlow updated OFBIZ-6310:
Comment: was deleted
(was: Good to know Michael.
I thought Jacques may have been referring to the missing space before the
opening curly bracket consistent with the others:
{code}
if(UtilValidate.isNotEmpty(UtilGenerics.toList(fieldValue))){
{code}
)
createConditionList doesn't handle widget dropdown multi-submitted values
when called by performFind
Key: OFBIZ-6310
URL: https://issues.apache.org/jira/browse/OFBIZ-6310
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Assignee: Michael Brohl
Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming
Branch
Attachments: OFBIZ-6310.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[
https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563655#comment-14563655
]
Christian Carlow commented on OFBIZ-6310:
-
Good to know Michael.
I thought Jacques may have been referring to the missing space before the
opening curly bracket consistent with the others:
{code}
if(UtilValidate.isNotEmpty(UtilGenerics.toList(fieldValue))){
{code}
createConditionList doesn't handle widget dropdown multi-submitted values
when called by performFind
Key: OFBIZ-6310
URL: https://issues.apache.org/jira/browse/OFBIZ-6310
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Assignee: Michael Brohl
Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming
Branch
Attachments: OFBIZ-6310.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[
https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563653#comment-14563653
]
Christian Carlow commented on OFBIZ-6310:
-
Good to know Michael.
I thought Jacques may have been referring to the missing space before the
opening curly bracket consistent with the others:
{code}
if(UtilValidate.isNotEmpty(UtilGenerics.toList(fieldValue))){
{code}
createConditionList doesn't handle widget dropdown multi-submitted values
when called by performFind
Key: OFBIZ-6310
URL: https://issues.apache.org/jira/browse/OFBIZ-6310
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Assignee: Michael Brohl
Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming
Branch
Attachments: OFBIZ-6310.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-6415) renderTextFindField doesn't reselect operation dropdown or ignoreCase checkbox
[ https://issues.apache.org/jira/browse/OFBIZ-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-6415. renderTextFindField doesn't reselect operation dropdown or ignoreCase checkbox -- Key: OFBIZ-6415 URL: https://issues.apache.org/jira/browse/OFBIZ-6415 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Nicolas Malin Fix For: 14.12.01, 12.04.06, 13.07.03, Upcoming Branch Attachments: OFBIZ-6415.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Closed] (OFBIZ-5679) Functionality to add WebSitePathAlias records is missing
Normally not, the branch is freezed as we call that, there are exceptions but must be by consensus. I guess here it's easier to simply revert ;) Jacques Le 28/05/2015 20:29, Michael Brohl a écrit : Should have asked this before but missed it in the heat of the battle: This was an improvement not a bugfix and I have backported in the unreleased branch 14.12. Is this ok for unreleased branches to bring in improvements or is this restricted to bugfixes and security fixes? Thanks for your advise, Michael Am 28.05.15 um 20:20 schrieb Michael Brohl (JIRA): [ https://issues.apache.org/jira/browse/OFBIZ-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-5679. Resolution: Implemented Fix Version/s: Release Branch 14.12 Upcoming Branch Thanks Pierre and Willem, your changes are in trunk at r1682295 release branch 14.12 at r1682298 I had to manually apply some changes and correct some issues with whitespaces to get this in. Please be careful with the encoding settings of your IDE.
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563589#comment-14563589 ] Michael Brohl commented on OFBIZ-6310: -- Christian, your patch file was ok, it was my fault. No big deal anyway. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563760#comment-14563760 ] Jacques Le Roux commented on OFBIZ-6310: Actually was that and only that, anyway trivial ;) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6229) Can't create a geo without providing a geoID
[ https://issues.apache.org/jira/browse/OFBIZ-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb reassigned OFBIZ-6229: -- Assignee: Taher Alkhateeb Can't create a geo without providing a geoID Key: OFBIZ-6229 URL: https://issues.apache.org/jira/browse/OFBIZ-6229 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, 14.12.01, 12.04.06, 13.07.02 Reporter: Pierre Smits Assignee: Taher Alkhateeb Priority: Minor Labels: geodata Currently the process of creating a geo fails when a geoId is not provided. The process should self-provide the geoId if it isn't provided by the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563271#comment-14563271 ] Michael Brohl commented on OFBIZ-6310: -- Jacques, I had problems using the formatting in Eclipse in one of the latest developments, maybe it was just this issue, can't remember. Using the official OFBiz Eclipse formatting template there were way too much changes so I reverted and did it by hand. I fear formatting is not strictly followed in all our sources... Anyway, thanks for the correction. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563343#comment-14563343 ] Christian Carlow edited comment on OFBIZ-6427 at 5/28/15 5:51 PM: -- With regard to identification of fields that should be calculated/summed of last message, I'll likely keep it simple for now and implement as an enhancement to form widgets. An additional functionality should probably be provided to allow for users to choose different summarizations such as sum, avg, min, max, etc. was (Author: ofbizzer): With regard to identification of fields that should be calculated/summed of last message, I'll likely keep it simple for now and implement as an enhancement to form widgets. An additional functionality should probably be provided to allow for users to choose different summarizations such as sum, avg, min, max, ext. Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563343#comment-14563343 ] Christian Carlow commented on OFBIZ-6427: - With regard to identification of fields that should be calculated/summed of last message, I'll likely keep it simple for now and implement as an enhancement to form widgets. An additional functionality should probably be provided to allow for users to choose different summarizations such as sum, avg, min, max, ext. Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6229) Can't create a geo without providing a geoID
[ https://issues.apache.org/jira/browse/OFBIZ-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563479#comment-14563479 ] Taher Alkhateeb edited comment on OFBIZ-6229 at 5/28/15 7:10 PM: - This issue triggered multiple other issues that I noticed in the geo management forms as follows: - The search screen results take you to the link geos. I believe it should go directly to create / edit instead - You cannot edit a geo because the parameter is not passed across the tabs link and edit / create. The menus should be redefined to pass the parameter around - The primary key is enforced in the service definition when it should be optional to create new geos - finally, the geoId should not be a lookup field. An entity cannot lookup itself I will apply a commit to fix all the above was (Author: taher): This issue triggered multiple other issues that I noticed in the geo management forms as follows: - The search screen results take you to the link geos. I believe it should go directly to create / edit instead - You cannot edit a geo because the parameter is not passed across the tabs link and edit / create. The menus should be redefined to pass the parameter around - The primary key is enforced in the service definition when it should be optional to create new geos I will apply a commit to fix all the above Can't create a geo without providing a geoID Key: OFBIZ-6229 URL: https://issues.apache.org/jira/browse/OFBIZ-6229 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, 14.12.01, 12.04.06, 13.07.02 Reporter: Pierre Smits Assignee: Taher Alkhateeb Priority: Minor Labels: geodata Currently the process of creating a geo fails when a geoId is not provided. The process should self-provide the geoId if it isn't provided by the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563278#comment-14563278 ] Christian Carlow commented on OFBIZ-6427: - Group row styles is another part of this that will need to be resolved. Default group row styles should probably be implemented based on the group level (maybe grayscale with highest group darkest and gradually get lighter) but this method would only realistically 3 groups deep given that the shades of gray have to be sufficiently far apart to distinguish from one another. Fortunately 3 groups is typically the max that will need but there should probably be style override options that can be chosen in case the default coloring is insufficient. This could be provided as a dropdown next to the groupBy check box that will appear next to fields like ignoreCase. Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563313#comment-14563313 ] Christian Carlow commented on OFBIZ-6427: - Identification of fields to group/summarize is another complication. If based on just fieldType then price fields are likely summed which is undesirable. Perhaps form widgets should be extended to identify which fields should be summarized. Extending the entity engine to allow group/summary fields to be identified at that level could be another possibility with applicability outside of form widgets. It would also allow auto-fields-entity to work with grouping functionality without further specifications. Any feedback is appreciated. Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563262#comment-14563262 ] Jacques Le Roux commented on OFBIZ-6310: Hi Michael, Christian, Please take care of the formatting, I know it's not so easy to spot during reviews ;) Done for trunk at r1682282, no needs to backport, thanks for your work! createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Release Branch 13.07, Release Branch 14.12, Upcoming Branch Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Closed] (OFBIZ-5679) Functionality to add WebSitePathAlias records is missing
Should have asked this before but missed it in the heat of the battle: This was an improvement not a bugfix and I have backported in the unreleased branch 14.12. Is this ok for unreleased branches to bring in improvements or is this restricted to bugfixes and security fixes? Thanks for your advise, Michael Am 28.05.15 um 20:20 schrieb Michael Brohl (JIRA): [ https://issues.apache.org/jira/browse/OFBIZ-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-5679. Resolution: Implemented Fix Version/s: Release Branch 14.12 Upcoming Branch Thanks Pierre and Willem, your changes are in trunk at r1682295 release branch 14.12 at r1682298 I had to manually apply some changes and correct some issues with whitespaces to get this in. Please be careful with the encoding settings of your IDE. smime.p7s Description: S/MIME Cryptographic Signature
[jira] [Closed] (OFBIZ-5679) Functionality to add WebSitePathAlias records is missing
[ https://issues.apache.org/jira/browse/OFBIZ-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-5679. Resolution: Implemented Fix Version/s: Release Branch 14.12 Upcoming Branch Thanks Pierre and Willem, your changes are in trunk at r1682295 release branch 14.12 at r1682298 I had to manually apply some changes and correct some issues with whitespaces to get this in. Please be careful with the encoding settings of your IDE. Functionality to add WebSitePathAlias records is missing Key: OFBIZ-5679 URL: https://issues.apache.org/jira/browse/OFBIZ-5679 Project: OFBiz Issue Type: Improvement Components: content Affects Versions: 11.04.04, 12.04.03, Upcoming Branch Reporter: Pierre Smits Assignee: Michael Brohl Fix For: Upcoming Branch, Release Branch 14.12 Attachments: addWebSitePathAlias.diff On websites in Content Mgr an overview to show path aliases (WebSitePathAlias entity) is available. However, the functionality to add path aliases is not available in the menu for the website. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563369#comment-14563369 ] Christian Carlow commented on OFBIZ-6427: - Adding more fields to allow for summary type such as sum, avg, max will be implemented along with a first and last method which will allow fields that would otherwise appear blank in the group to be based on either the first or last detail record field value. This field will likely be be provided as a multi select. Functionality should probably exist to ignore incompatibly summary types such as if you try to avg the orderId. Another extension that would be valuable would be to have the ability to insert your own messages for each grouping but this requires more thought. Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5679) Functionality to add WebSitePathAlias records is missing
[ https://issues.apache.org/jira/browse/OFBIZ-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563577#comment-14563577 ] Pierre Smits commented on OFBIZ-5679: - Thanks Michael Functionality to add WebSitePathAlias records is missing Key: OFBIZ-5679 URL: https://issues.apache.org/jira/browse/OFBIZ-5679 Project: OFBiz Issue Type: Improvement Components: content Affects Versions: 11.04.04, 12.04.03, Upcoming Branch Reporter: Pierre Smits Assignee: Michael Brohl Fix For: Release Branch 14.12, Upcoming Branch Attachments: addWebSitePathAlias.diff On websites in Content Mgr an overview to show path aliases (WebSitePathAlias entity) is available. However, the functionality to add path aliases is not available in the menu for the website. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6229) Can't create a geo without providing a geoID
[ https://issues.apache.org/jira/browse/OFBIZ-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563479#comment-14563479 ] Taher Alkhateeb commented on OFBIZ-6229: This issue triggered multiple other issues that I noticed in the geo management forms as follows: - The search screen results take you to the link geos. I believe it should go directly to create / edit instead - You cannot edit a geo because the parameter is not passed across the tabs link and edit / create. The menus should be redefined to pass the parameter around - The primary key is enforced in the service definition when it should be optional to create new geos I will apply a commit to fix all the above Can't create a geo without providing a geoID Key: OFBIZ-6229 URL: https://issues.apache.org/jira/browse/OFBIZ-6229 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, 14.12.01, 12.04.06, 13.07.02 Reporter: Pierre Smits Assignee: Taher Alkhateeb Priority: Minor Labels: geodata Currently the process of creating a geo fails when a geoId is not provided. The process should self-provide the geoId if it isn't provided by the user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563278#comment-14563278 ] Christian Carlow edited comment on OFBIZ-6427 at 5/28/15 5:43 PM: -- Group row styles is another part of this that will need to be resolved. Default group row styles should probably be implemented based on the group level (maybe grayscale with highest group darkest and gradually get lighter) but this method would only realistically support 3 groups deep because the shades of gray have to be sufficiently far apart to distinguish from one another. Fortunately 3 groups is typically the max that will need but there should probably be style override options that can be chosen in case the default coloring is insufficient. This could be provided as a dropdown next to the groupBy check box that will appear next to fields like ignoreCase. was (Author: ofbizzer): Group row styles is another part of this that will need to be resolved. Default group row styles should probably be implemented based on the group level (maybe grayscale with highest group darkest and gradually get lighter) but this method would only realistically 3 groups deep given that the shades of gray have to be sufficiently far apart to distinguish from one another. Fortunately 3 groups is typically the max that will need but there should probably be style override options that can be chosen in case the default coloring is insufficient. This could be provided as a dropdown next to the groupBy check box that will appear next to fields like ignoreCase. Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1682132 - in /ofbiz/trunk: applications/product/webapp/catalog/product/ applications/product/widget/catalog/ framework/widget/dtd/ framework/widget/src/org/ofbiz/widget/model/ framewo
Hi Michael,
Well done, here a small explanation on what have really been done would help
reviewers, not only committers, but also external users following changelogs.
For instance :
Adds a maxlength attribute to the textarea element in form, handle errors using
maxlength as default value
Apply the max length (255 chars) value in several FTL files, when the DB is
limiting the length
You can always add a better comment (than mine ;)) in the commit log afterwards
Thanks
Jacque
Le 28/05/2015 00:18, mbr...@apache.org a écrit :
Author: mbrohl
Date: Wed May 27 22:18:29 2015
New Revision: 1682132
URL: http://svn.apache.org/r1682132
Log:
Manually applied and modified the changes of the patch from jira issue
OFBIZ-6312: Catalog Manager's EditProduct screen HTML should place a limit on
the size of text that can be entered in the Product Description box.
Thanks Forrest Rae for reporting the issue and providing the patch.
Modified:
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
ofbiz/trunk/framework/widget/dtd/widget-form.xsd
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/model/ModelFormField.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/html/HtmlFormRenderer.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
ofbiz/trunk/framework/widget/templates/csvFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/foFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/textFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/xmlFormMacroLibrary.ftl
Modified:
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl?rev=1682132r1=1682131r2=1682132view=diff
==
---
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
(original)
+++
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
Wed May 27 22:18:29 2015
@@ -52,7 +52,7 @@ under the License.
td width=20% align=right
valign=topb${uiLabelMap.ProductProductDescription}/b/td
tdnbsp;/td
td width=80% colspan=4 valign=top
-textarea name=description cols=60
rows=2${(product.description)!}/textarea
+textarea name=description cols=60 rows=2
maxlength=255${(product.description)!}/textarea
/td
/tr
tr
Modified: ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml?rev=1682132r1=1682131r2=1682132view=diff
==
--- ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml (original)
+++ ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml Wed May 27
22:18:29 2015
@@ -353,7 +353,7 @@ under the License.
field name=productId title=${uiLabelMap.ProductDuplicateRemoveSelectedWithNewId}
map-name=dupProducttext size=20 maxlength=20//field
field name=newInternalName title=${uiLabelMap.ProductInternalName}text size=30
maxlength=255//field
field name=newProductName title=${uiLabelMap.ProductProductName}text size=30
maxlength=60//field
-field name=newDescription title=${uiLabelMap.ProductProductDescription}
widget-style=textAreaBoxtextarea cols=60 rows=2//field
+field name=newDescription title=${uiLabelMap.ProductProductDescription}
widget-style=textAreaBoxtextarea cols=60 rows=2 maxlength=255//field
field name=newLongDescription title=${uiLabelMap.ProductLongDescription} widget-style=textAreaBox
dojo-ResizableTextAreatextarea cols=60 rows=7//field
field name=duplicateTitle title=${uiLabelMap.CommonDuplicate}
title-style=h1 map-name=dummy
display description=/
Modified: ofbiz/trunk/framework/widget/dtd/widget-form.xsd
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-form.xsd?rev=1682132r1=1682131r2=1682132view=diff
==
--- ofbiz/trunk/framework/widget/dtd/widget-form.xsd (original)
+++ ofbiz/trunk/framework/widget/dtd/widget-form.xsd Wed May 27 22:18:29 2015
@@ -1615,6 +1615,7 @@ under the License.
xs:complexType
xs:attribute type=xs:positiveInteger name=cols default=60
/
xs:attribute type=xs:positiveInteger name=rows default=3 /
+xs:attribute type=xs:positiveInteger name=maxlength/
xs:attribute type=xs:string name=default-value /
[jira] [Commented] (OFBIZ-6208) rename AccountingConfig.properties to accounting.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562406#comment-14562406 ] Jacques Le Roux commented on OFBIZ-6208: Hi Pierre, did you get a chance? rename AccountingConfig.properties to accounting.properties --- Key: OFBIZ-6208 URL: https://issues.apache.org/jira/browse/OFBIZ-6208 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, multi-tenant Attachments: OFBIZ-6208-ACCInvoicePerShipmentTests.patch, OFBIZ-6208-ACCInvoiceServices.java.patch, OFBIZ-6208-ACCInvoiceServices.xml.patch, OFBIZ-6208-ACCPaymentServices.xml.patch, OFBIZ-6208-AccountingConfigChange.patch, OFBIZ-6208-ORDROrderServices.patch, OFBIZ-6208-PRODRentalServices.xml.patch Currently many properties files in various components are named after the component, i.e. the bi component has bi.properties. In order to have consistency from component to component the AccountingConfig.properties file must be renamed to accounting.properties and all references in other components should reflect the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6190) Have configuration options for sfa
[ https://issues.apache.org/jira/browse/OFBIZ-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562411#comment-14562411 ] Jacques Le Roux commented on OFBIZ-6190: Nothing planned to use systemResourceId=sfa? Have configuration options for sfa -- Key: OFBIZ-6190 URL: https://issues.apache.org/jira/browse/OFBIZ-6190 Project: OFBiz Issue Type: Sub-task Components: marketing Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, multi-tenant, sfa Attachments: OFBIZ-6190-SfaOFBizComponent.patch, OFBIZ-6190-SfaSystemPropertyData.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6190) Have configuration options for sfa
[ https://issues.apache.org/jira/browse/OFBIZ-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6190. -- Resolution: Implemented Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux (was: Pierre Smits) Thanks Pierre, Your patches are in trunk at revision: 1682159 Have configuration options for sfa -- Key: OFBIZ-6190 URL: https://issues.apache.org/jira/browse/OFBIZ-6190 Project: OFBiz Issue Type: Sub-task Components: marketing Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Labels: configuration, multi-tenant, sfa Fix For: Upcoming Branch Attachments: OFBIZ-6190-SfaOFBizComponent.patch, OFBIZ-6190-SfaSystemPropertyData.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562395#comment-14562395 ] Jacques Le Roux commented on OFBIZ-6426: Yes please, duplicate of? FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562395#comment-14562395 ] Jacques Le Roux edited comment on OFBIZ-6426 at 5/28/15 7:01 AM: - Yes please, duplicate of? OFBIZ-6312? was (Author: jacques.le.roux): Yes please, duplicate of? FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6415) renderTextFindField doesn't reselect operation dropdown or ignoreCase checkbox
[ https://issues.apache.org/jira/browse/OFBIZ-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562402#comment-14562402 ] Nicolas Malin commented on OFBIZ-6415: -- I think this code doesn't work with the Is Empty option because no value need. I will check that. renderTextFindField doesn't reselect operation dropdown or ignoreCase checkbox -- Key: OFBIZ-6415 URL: https://issues.apache.org/jira/browse/OFBIZ-6415 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Nicolas Malin Attachments: OFBIZ-6415.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6162) Improve configuration options for Search/Find screens in project mgr.
[ https://issues.apache.org/jira/browse/OFBIZ-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562410#comment-14562410 ] Jacques Le Roux commented on OFBIZ-6162: Could you explain more with 1 or 2 sentences what it does exactly, thanks! Improve configuration options for Search/Find screens in project mgr. - Key: OFBIZ-6162 URL: https://issues.apache.org/jira/browse/OFBIZ-6162 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/projectmgr Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, find, search Attachments: OFBIZ-6162-ProjectMgrSystemProperty.patch In a multi-tenant setup configuration of the number of rows returned as well as the show the result on accessing a search find screens in project mgr needs to be configurable per tenant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6162) Improve configuration options for Search/Find screens in project mgr.
[ https://issues.apache.org/jira/browse/OFBIZ-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562410#comment-14562410 ] Jacques Le Roux edited comment on OFBIZ-6162 at 5/28/15 7:20 AM: - Could you explain more with 1 or 2 sentences what it does exactly, thanks! Ha maybe you did already at OFBIZ-6164? was (Author: jacques.le.roux): Could you explain more with 1 or 2 sentences what it does exactly, thanks! Improve configuration options for Search/Find screens in project mgr. - Key: OFBIZ-6162 URL: https://issues.apache.org/jira/browse/OFBIZ-6162 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/projectmgr Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, find, search Attachments: OFBIZ-6162-ProjectMgrSystemProperty.patch In a multi-tenant setup configuration of the number of rows returned as well as the show the result on accessing a search find screens in project mgr needs to be configurable per tenant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6190) Have configuration options for sfa
[ https://issues.apache.org/jira/browse/OFBIZ-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562419#comment-14562419 ] Pierre Smits commented on OFBIZ-6190: - It is being used in vcard.java Have configuration options for sfa -- Key: OFBIZ-6190 URL: https://issues.apache.org/jira/browse/OFBIZ-6190 Project: OFBiz Issue Type: Sub-task Components: marketing Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, multi-tenant, sfa Attachments: OFBIZ-6190-SfaOFBizComponent.patch, OFBIZ-6190-SfaSystemPropertyData.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6190) Have configuration options for sfa
[ https://issues.apache.org/jira/browse/OFBIZ-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562446#comment-14562446 ] Jacques Le Roux commented on OFBIZ-6190: OK clear, thanks! Have configuration options for sfa -- Key: OFBIZ-6190 URL: https://issues.apache.org/jira/browse/OFBIZ-6190 Project: OFBiz Issue Type: Sub-task Components: marketing Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, multi-tenant, sfa Attachments: OFBIZ-6190-SfaOFBizComponent.patch, OFBIZ-6190-SfaSystemPropertyData.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6162) Improve configuration options for Search/Find screens in project mgr.
[ https://issues.apache.org/jira/browse/OFBIZ-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6162. -- Resolution: Implemented Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux (was: Pierre Smits) Thanks Pierre, Your patch is in trunk at revision: 1682160 Improve configuration options for Search/Find screens in project mgr. - Key: OFBIZ-6162 URL: https://issues.apache.org/jira/browse/OFBIZ-6162 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/projectmgr Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Labels: configuration, find, search Fix For: Upcoming Branch Attachments: OFBIZ-6162-ProjectMgrSystemProperty.patch In a multi-tenant setup configuration of the number of rows returned as well as the show the result on accessing a search find screens in project mgr needs to be configurable per tenant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1682132 - in /ofbiz/trunk: applications/product/webapp/catalog/product/ applications/product/widget/catalog/ framework/widget/dtd/ framework/widget/src/org/ofbiz/widget/model/ framewo
Hi Jaques,
I have changed the commit message, the original one was indeed too brief
for what has been done.
Thanks for review and your advise,
Michael
Am 28.05.15 um 09:12 schrieb Jacques Le Roux:
Hi Michael,
Well done, here a small explanation on what have really been done
would help reviewers, not only committers, but also external users
following changelogs.
For instance :
Adds a maxlength attribute to the textarea element in form, handle
errors using maxlength as default value
Apply the max length (255 chars) value in several FTL files, when the
DB is limiting the length
You can always add a better comment (than mine ;)) in the commit log
afterwards
Thanks
Jacque
Le 28/05/2015 00:18, mbr...@apache.org a écrit :
Author: mbrohl
Date: Wed May 27 22:18:29 2015
New Revision: 1682132
URL: http://svn.apache.org/r1682132
Log:
Manually applied and modified the changes of the patch from jira
issue OFBIZ-6312: Catalog Manager's EditProduct screen HTML should
place a limit on the size of text that can be entered in the Product
Description box.
Thanks Forrest Rae for reporting the issue and providing the patch.
Modified:
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
ofbiz/trunk/framework/widget/dtd/widget-form.xsd
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/model/ModelFormField.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/html/HtmlFormRenderer.java
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
ofbiz/trunk/framework/widget/templates/csvFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/foFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/textFormMacroLibrary.ftl
ofbiz/trunk/framework/widget/templates/xmlFormMacroLibrary.ftl
Modified:
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl?rev=1682132r1=1682131r2=1682132view=diff
==
---
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
(original)
+++
ofbiz/trunk/applications/product/webapp/catalog/product/EditProductContent.ftl
Wed May 27 22:18:29 2015
@@ -52,7 +52,7 @@ under the License.
td width=20% align=right
valign=topb${uiLabelMap.ProductProductDescription}/b/td
tdnbsp;/td
td width=80% colspan=4 valign=top
-textarea name=description cols=60
rows=2${(product.description)!}/textarea
+textarea name=description cols=60 rows=2
maxlength=255${(product.description)!}/textarea
/td
/tr
tr
Modified:
ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml?rev=1682132r1=1682131r2=1682132view=diff
==
--- ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
(original)
+++ ofbiz/trunk/applications/product/widget/catalog/ProductForms.xml
Wed May 27 22:18:29 2015
@@ -353,7 +353,7 @@ under the License.
field name=productId
title=${uiLabelMap.ProductDuplicateRemoveSelectedWithNewId}
map-name=dupProducttext size=20 maxlength=20//field
field name=newInternalName
title=${uiLabelMap.ProductInternalName}text size=30
maxlength=255//field
field name=newProductName
title=${uiLabelMap.ProductProductName}text size=30
maxlength=60//field
-field name=newDescription
title=${uiLabelMap.ProductProductDescription}
widget-style=textAreaBoxtextarea cols=60 rows=2//field
+field name=newDescription
title=${uiLabelMap.ProductProductDescription}
widget-style=textAreaBoxtextarea cols=60 rows=2
maxlength=255//field
field name=newLongDescription
title=${uiLabelMap.ProductLongDescription}
widget-style=textAreaBox dojo-ResizableTextAreatextarea cols=60
rows=7//field
field name=duplicateTitle
title=${uiLabelMap.CommonDuplicate} title-style=h1 map-name=dummy
display description=/
Modified: ofbiz/trunk/framework/widget/dtd/widget-form.xsd
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-form.xsd?rev=1682132r1=1682131r2=1682132view=diff
==
--- ofbiz/trunk/framework/widget/dtd/widget-form.xsd (original)
+++ ofbiz/trunk/framework/widget/dtd/widget-form.xsd Wed May 27
22:18:29 2015
@@ -1615,6 +1615,7 @@ under the License.
xs:complexType
xs:attribute type=xs:positiveInteger name=cols
default=60 /
xs:attribute
[jira] [Commented] (OFBIZ-6398) Print Pick Sheet PDF using orderId.pdf as attachement name.
[ https://issues.apache.org/jira/browse/OFBIZ-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562557#comment-14562557 ] Michael Brohl commented on OFBIZ-6398: -- I've had a look at it. I could check if the facilityId is available and set the pdf fileName accordingly. What do people think about this? 1. should we preserve the old behaviour and name the picksheet pdf orderPickSheet.pdf 2. or should we rename it to orderIdPickSheet.pdf 3 or else? Print Pick Sheet PDF using orderId.pdf as attachement name. --- Key: OFBIZ-6398 URL: https://issues.apache.org/jira/browse/OFBIZ-6398 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 14.12, Trunk Reporter: Deepak Dixit Assignee: Michael Brohl Priority: Minor Print Pick Sheet PDF using orderId.pdf as attachement name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6420) Improve ModelFormField Code
[ https://issues.apache.org/jira/browse/OFBIZ-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6420. Done in r1682214 Improve ModelFormField Code --- Key: OFBIZ-6420 URL: https://issues.apache.org/jira/browse/OFBIZ-6420 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Michael Brohl Assignee: Michael Brohl Priority: Minor Fix For: Upcoming Branch The ModelFormField Code should be improved. It contains unnecessary code, catched exceptions are too broad etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6308) Form widget drop-down should reselect multiple submitted options
[ https://issues.apache.org/jira/browse/OFBIZ-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6308: Assignee: Michael Brohl Form widget drop-down should reselect multiple submitted options - Key: OFBIZ-6308 URL: https://issues.apache.org/jira/browse/OFBIZ-6308 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Attachments: OFBIZ-6308.patch Form widget multi-dropdowns only reselect single options submitted but should also reselect multiple options submitted. This was previously discussed back in 2011 on ML: http://mail-archives.apache.org/mod_mbox/ofbiz-user/201102.mbox/%3CFF794895DC4942FB9F3090336C3DC63A@inspiron530%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
buildbot failure in ASF Buildbot on ofbiz-trunk
The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/907 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 1682214 Blamelist: mbrohl BUILD FAILED: failed Sincerely, -The Buildbot
[jira] [Assigned] (OFBIZ-6414) drop-down widget field with allow-multiple=true does not display current value
[ https://issues.apache.org/jira/browse/OFBIZ-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6414: Assignee: Michael Brohl drop-down widget field with allow-multiple=true does not display current value Key: OFBIZ-6414 URL: https://issues.apache.org/jira/browse/OFBIZ-6414 Project: OFBiz Issue Type: Bug Affects Versions: Trunk Reporter: Gareth Carter Assignee: Michael Brohl Priority: Minor Attachments: ModelFormField.patch ModelFormField.getEntry returns the string representation of the value corresponding to the field in either the context map or parameters map but when the value is returned as a list [X, Y, Z], the opening and closing brackets are encoded #x5b;X, Y, Z#x5d; This prevents the FormRenderer (atleast MacroFormRenderer) from detecting a list object from the string and converting it back to a list eg - currentValueList = StringUtil.toList(currentValue); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-6420) Improve ModelFormField Code
[ https://issues.apache.org/jira/browse/OFBIZ-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl resolved OFBIZ-6420. -- Resolution: Fixed Improve ModelFormField Code --- Key: OFBIZ-6420 URL: https://issues.apache.org/jira/browse/OFBIZ-6420 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Michael Brohl Assignee: Michael Brohl Priority: Minor Fix For: Upcoming Branch The ModelFormField Code should be improved. It contains unnecessary code, catched exceptions are too broad etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6426: --- Comment: was deleted (was: Thanks!) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Slow JIRA
I suffered this also yesterday evening, then this morning http://status.apache.org/ said it was clear; I see the same than yesterday evening there now, so they are still on it... Jacques Le 28/05/2015 14:52, Christian Carlow a écrit : Just letting anyone else who might be experiencing the same problem know that JIRA seems to be running slower than normal since yesterday. This caused me to create OFBIZ-6426 as a duplicate of OFBIZ-6425. For patch OFBIZ-6422 I received an error message that the upload didn't succeed but saw that it actually did after refreshing the page. Its probably best to check that operations do in fact fail before trying to initiate them again to prevent further duplicates while JIRA isn't performing as usual.
[jira] [Commented] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562764#comment-14562764 ] Christian Carlow commented on OFBIZ-6426: - This issue is an exact duplicate of OFBIZ-6425, created accidentally do to my browser malfunction. FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6425) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6425: Attachment: OFBIZ-6425.patch This patch allows the performFindList service to be called by a form widget action without this FTL error occuring (ListProduct was just used for testing): Error in form [ListProducts] calling service with name [performFindList]: org.ofbiz.service.GenericServiceException: Outgoing result (in runSync : performFindList) does not match expected requirements (The following required parameter is missing: [performFindList.listSize])) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6425 URL: https://issues.apache.org/jira/browse/OFBIZ-6425 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6425.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6308) Form widget drop-down should reselect multiple submitted options
[ https://issues.apache.org/jira/browse/OFBIZ-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6308. I close this issue because there is a duplicate (OFBIZ-6414) which provides a more general solution, as stated by [~ofbizzer] at https://issues.apache.org/jira/browse/OFBIZ-6414?focusedCommentId=14558509page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14558509 Thanks Christian Form widget drop-down should reselect multiple submitted options - Key: OFBIZ-6308 URL: https://issues.apache.org/jira/browse/OFBIZ-6308 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Attachments: OFBIZ-6308.patch Form widget multi-dropdowns only reselect single options submitted but should also reselect multiple options submitted. This was previously discussed back in 2011 on ML: http://mail-archives.apache.org/mod_mbox/ofbiz-user/201102.mbox/%3CFF794895DC4942FB9F3090336C3DC63A@inspiron530%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562821#comment-14562821 ] Jacques Le Roux commented on OFBIZ-6426: Thanks! FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562831#comment-14562831 ] Jacques Le Roux commented on OFBIZ-6426: Thanks! FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6423) FindService.performFindList can't be swapped for performFind of grids/forms
[ https://issues.apache.org/jira/browse/OFBIZ-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562885#comment-14562885 ] Christian Carlow commented on OFBIZ-6423: - Just making a note her in case forgotten later. Once the results of performFindList are displayed, it is necessary to assign override-list-size attribute so that FormRenderer.renderItemRows sets the lowIndex correctly, otherwise pages 0 are rendered as empty. FindService.performFindList can't be swapped for performFind of grids/forms --- Key: OFBIZ-6423 URL: https://issues.apache.org/jira/browse/OFBIZ-6423 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow This is a container issue to have grids/forms render the same way regardless of which service is chosen. OFBIZ-6419 will resolve the issue that causes the listSize to be set to the default viewSize. FormRender.renderItemRows has a TODO note mentioning that the code needs to be redisigned because it doesn't skip previously iterated rows won't be rendered. Such redisign will likely be involved with the patches to resolve this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Slow JIRA
Just letting anyone else who might be experiencing the same problem know that JIRA seems to be running slower than normal since yesterday. This caused me to create OFBIZ-6426 as a duplicate of OFBIZ-6425. For patch OFBIZ-6422 I received an error message that the upload didn't succeed but saw that it actually did after refreshing the page. Its probably best to check that operations do in fact fail before trying to initiate them again to prevent further duplicates while JIRA isn't performing as usual.
[jira] [Commented] (OFBIZ-6415) renderTextFindField doesn't reselect operation dropdown or ignoreCase checkbox
[ https://issues.apache.org/jira/browse/OFBIZ-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562934#comment-14562934 ] Christian Carlow commented on OFBIZ-6415: - Hey Nicolas, Is Empty has been verified as working on my end. I manually updated product.internalName = null and did a search for internalName Is Empty at catalog/control/FindProduct and got only that record. renderTextFindField doesn't reselect operation dropdown or ignoreCase checkbox -- Key: OFBIZ-6415 URL: https://issues.apache.org/jira/browse/OFBIZ-6415 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Nicolas Malin Attachments: OFBIZ-6415.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
buildbot success in ASF Buildbot on ofbiz-trunk
The Buildbot has detected a restored build on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/908 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 1682234 Blamelist: mbrohl Build succeeded! Sincerely, -The Buildbot
[jira] [Comment Edited] (OFBIZ-6423) FindService.performFindList can't be swapped for performFind of grids/forms
[ https://issues.apache.org/jira/browse/OFBIZ-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562885#comment-14562885 ] Christian Carlow edited comment on OFBIZ-6423 at 5/28/15 1:31 PM: -- Just making a note here in case forgotten later. Once the results of performFindList are displayed, it is necessary to assign override-list-size attribute so that FormRenderer.renderItemRows sets the lowIndex correctly, otherwise pages 0 are rendered as empty. was (Author: ofbizzer): Just making a note her in case forgotten later. Once the results of performFindList are displayed, it is necessary to assign override-list-size attribute so that FormRenderer.renderItemRows sets the lowIndex correctly, otherwise pages 0 are rendered as empty. FindService.performFindList can't be swapped for performFind of grids/forms --- Key: OFBIZ-6423 URL: https://issues.apache.org/jira/browse/OFBIZ-6423 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow This is a container issue to have grids/forms render the same way regardless of which service is chosen. OFBIZ-6419 will resolve the issue that causes the listSize to be set to the default viewSize. FormRender.renderItemRows has a TODO note mentioning that the code needs to be redisigned because it doesn't skip previously iterated rows won't be rendered. Such redisign will likely be involved with the patches to resolve this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-6425) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6425: --- Comment: was deleted (was: Sounds like a wise change to me :)) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6425 URL: https://issues.apache.org/jira/browse/OFBIZ-6425 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6425.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6414) drop-down widget field with allow-multiple=true does not display current value
[ https://issues.apache.org/jira/browse/OFBIZ-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562904#comment-14562904 ] Jacques Le Roux commented on OFBIZ-6414: The variant Gareth spoke about is visible at http://demo-trunk-ofbiz.apache.org/example/control/FormWidgetExamples#DropDownMultipleFieldExampleForm it's used in few places in the the project. drop-down widget field with allow-multiple=true does not display current value Key: OFBIZ-6414 URL: https://issues.apache.org/jira/browse/OFBIZ-6414 Project: OFBiz Issue Type: Bug Affects Versions: Trunk Reporter: Gareth Carter Assignee: Michael Brohl Priority: Minor Fix For: Upcoming Branch Attachments: ModelFormField.patch ModelFormField.getEntry returns the string representation of the value corresponding to the field in either the context map or parameters map but when the value is returned as a list [X, Y, Z], the opening and closing brackets are encoded #x5b;X, Y, Z#x5d; This prevents the FormRenderer (atleast MacroFormRenderer) from detecting a list object from the string and converting it back to a list eg - currentValueList = StringUtil.toList(currentValue); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6425) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562919#comment-14562919 ] Jacques Le Roux commented on OFBIZ-6425: OK, thanks! FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6425 URL: https://issues.apache.org/jira/browse/OFBIZ-6425 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6425.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6428) Improve FindService.performFind to handle multi-field sorting
Christian Carlow created OFBIZ-6428: --- Summary: Improve FindService.performFind to handle multi-field sorting Key: OFBIZ-6428 URL: https://issues.apache.org/jira/browse/OFBIZ-6428 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as find fields have ignoreCase fields, adding a drop down for sortSeq and sortDir would offer more power to users to sort by more than one field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6419) Improve form widget find functionality as a generic reporting tool to offer more power to the end user
[ https://issues.apache.org/jira/browse/OFBIZ-6419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563205#comment-14563205 ] Christian Carlow commented on OFBIZ-6419: - OFBIZ-6428 will add the sort enhancements to this issue. The plan is to implement some way to identify that a form is intended to be used for finding records and then allow the extra reporting options to appear next to fields like ignoreCase does. This would allow for the same form and query to be used rather than creating a separate form for every little difference which I often feel is too redundant and becomes more difficult to manage. My next train of thought is to find a way to define defaults for the new find options so they can be automatically selected. This could lead the way for end users to create and save their own custom reports as well but that part would likely need to be driven by the database. Improve form widget find functionality as a generic reporting tool to offer more power to the end user -- Key: OFBIZ-6419 URL: https://issues.apache.org/jira/browse/OFBIZ-6419 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Christian Carlow Attachments: OFBIZ-6419.patch This is a container issue for future issues that work toward enhancing the form widget find functionality as a more generic reporting tool. Controls similar to ignore case should be added to find fields to allow end users to for example: hide result fields, sort by multiple fields, group/summarize by fields and choose grouping color Most of this functionality is meant to allow a single form and entity query to handle multiple reports that use the same data but hide, sort, and group/summarize fields differently. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563216#comment-14563216 ] Christian Carlow commented on OFBIZ-6427: - Group/summarization will likely rely on sorting/seq functionality of OFBIZ-6428. I'm not exactly sure how this should be implemented yet. The simple way is to loop the sort fields in order and see if they are also grouped and then create a group record if one does not yet exist. However, this would rely on the user making sure they don't select something that gives misleading grouping information. For example if they choose to sort and group by customer, then sort by order date, then sort and group by product they will get multiple product groupings if another product was ordered between the order date of the next identical product. I'll likely implement the simple way first and add an enhancement to it later as a separate JIRA. Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6425) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562826#comment-14562826 ] Jacques Le Roux commented on OFBIZ-6425: Sounds like a wise change to me :) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6425 URL: https://issues.apache.org/jira/browse/OFBIZ-6425 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6425.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6422) Paginator.getListLimits listSize gets set to viewSize for FindServices.performFindList
[ https://issues.apache.org/jira/browse/OFBIZ-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6422: Attachment: OFBIZ-6422.patch This patch adds code to Paginator to account for the entryList being instanceOf List and extracts extracts from the context.results object the original listSize. Paginator.getListLimits listSize gets set to viewSize for FindServices.performFindList -- Key: OFBIZ-6422 URL: https://issues.apache.org/jira/browse/OFBIZ-6422 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6422.patch I simply changed a grid/form service service-name attribute from performFind to performFindList and the listSize gets set to 20 causing the paginator not to render since it thinks all results are being shown. It seems performFindList isn't as compatible with form widgets as performFind which may be worthy a separate JIRA. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562835#comment-14562835 ] Christian Carlow commented on OFBIZ-6426: - Actually I think the duplicates are being caused by JIRA running slowly since yesterday. FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6425) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562833#comment-14562833 ] Jacques Le Roux commented on OFBIZ-6425: Sounds like a wise change to me :) But could you please give more details, like an URL to reproduce the error? FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6425 URL: https://issues.apache.org/jira/browse/OFBIZ-6425 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6425.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6426) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562845#comment-14562845 ] Jacques Le Roux commented on OFBIZ-6426: Yes thanks crappy Jira :/ FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6426 URL: https://issues.apache.org/jira/browse/OFBIZ-6426 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6425) FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0
[ https://issues.apache.org/jira/browse/OFBIZ-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562849#comment-14562849 ] Christian Carlow commented on OFBIZ-6425: - Hey Jacques, I was testing at catalog/control/FindProduct. I just changed ProductForms.xml#ListProducts service-name from performFind to performFindList. Then upon initially visiting the page the error is displayed. FindService.performFindList listSize = null causes errors when list is empty because the rendering system expects 0 --- Key: OFBIZ-6425 URL: https://issues.apache.org/jira/browse/OFBIZ-6425 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6425.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6414) drop-down widget field with allow-multiple=true does not display current value
[ https://issues.apache.org/jira/browse/OFBIZ-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6414. Resolution: Fixed Fix Version/s: Upcoming Branch Thanks Gareth, your change is in r1682234 drop-down widget field with allow-multiple=true does not display current value Key: OFBIZ-6414 URL: https://issues.apache.org/jira/browse/OFBIZ-6414 Project: OFBiz Issue Type: Bug Affects Versions: Trunk Reporter: Gareth Carter Assignee: Michael Brohl Priority: Minor Fix For: Upcoming Branch Attachments: ModelFormField.patch ModelFormField.getEntry returns the string representation of the value corresponding to the field in either the context map or parameters map but when the value is returned as a list [X, Y, Z], the opening and closing brackets are encoded #x5b;X, Y, Z#x5d; This prevents the FormRenderer (atleast MacroFormRenderer) from detecting a list object from the string and converting it back to a list eg - currentValueList = StringUtil.toList(currentValue); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Slow JIRA
Yeah, it's not fun to work with it today... Michael Am 28.05.15 um 14:52 schrieb Christian Carlow: Just letting anyone else who might be experiencing the same problem know that JIRA seems to be running slower than normal since yesterday. This caused me to create OFBIZ-6426 as a duplicate of OFBIZ-6425. For patch OFBIZ-6422 I received an error message that the upload didn't succeed but saw that it actually did after refreshing the page. Its probably best to check that operations do in fact fail before trying to initiate them again to prevent further duplicates while JIRA isn't performing as usual. smime.p7s Description: S/MIME Cryptographic Signature
[jira] [Created] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
Christian Carlow created OFBIZ-6427: --- Summary: Implement FindService record grouping/summarization functionality Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5679) Functionality to add WebSitePathAlias records is missing
[ https://issues.apache.org/jira/browse/OFBIZ-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-5679: Assignee: Michael Brohl Functionality to add WebSitePathAlias records is missing Key: OFBIZ-5679 URL: https://issues.apache.org/jira/browse/OFBIZ-5679 Project: OFBiz Issue Type: Improvement Components: content Affects Versions: 11.04.04, 12.04.03, Trunk Reporter: Pierre Smits Assignee: Michael Brohl Attachments: addWebSitePathAlias.diff On websites in Content Mgr an overview to show path aliases (WebSitePathAlias entity) is available. However, the functionality to add path aliases is not available in the menu for the website. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563161#comment-14563161 ] Christian Carlow commented on OFBIZ-6310: - Thanks for the review Michael, Feel free to commit any of my patches for me. I've been holding off since it isn't convenient while I'm still using git and working on other functionality. Also feel free to backport if you like but for now I'm only focusing on the trunk. createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6310: Assignee: Michael Brohl createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6427) Implement FindService record grouping/summarization functionality
[ https://issues.apache.org/jira/browse/OFBIZ-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6427: Issue Type: Improvement (was: Bug) Implement FindService record grouping/summarization functionality - Key: OFBIZ-6427 URL: https://issues.apache.org/jira/browse/OFBIZ-6427 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow Just as sortSeq and sortDir will be added to find fields like ignoreCase is available, groupBy check box would also enhance user query capabilities. FindService would have to be extended to process the list and create group/summary records. For example, if a grid/form lists customer orders and the user wants to determine the total quantity and price of products ordered between a date range, then check marking the groupBy for productId would insert a grouping record before the details containing totals. This issue is primarily meant to handle reports for which pagination isn't used because all records are displayed. For these reports queries, group totals can simply be calculated by looping each detail record. But if pagination is used, the method of calculating totals for grouping records becomes more complicated because if detail records exist outside of the current page but are part of a group being summarized then they will be excluded from the group total unless implemented some other way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6419) Improve form widget find functionality as a generic reporting tool to offer more power to the end user
[ https://issues.apache.org/jira/browse/OFBIZ-6419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563168#comment-14563168 ] Christian Carlow commented on OFBIZ-6419: - OFBIZ-6427 will implement group/summarization functionality into FindService for forms and provide query option to activate the functionality similar to how ignoreCase is used. Improve form widget find functionality as a generic reporting tool to offer more power to the end user -- Key: OFBIZ-6419 URL: https://issues.apache.org/jira/browse/OFBIZ-6419 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Christian Carlow Attachments: OFBIZ-6419.patch This is a container issue for future issues that work toward enhancing the form widget find functionality as a more generic reporting tool. Controls similar to ignore case should be added to find fields to allow end users to for example: hide result fields, sort by multiple fields, group/summarize by fields and choose grouping color Most of this functionality is meant to allow a single form and entity query to handle multiple reports that use the same data but hide, sort, and group/summarize fields differently. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563135#comment-14563135 ] Michael Brohl commented on OFBIZ-6310: -- Christian, your patch looks good to me, do you want to commit it yourself? Should we backport to the 13.07 and 14.12 branches? createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6310) createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind
[ https://issues.apache.org/jira/browse/OFBIZ-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6310. Resolution: Fixed Fix Version/s: Release Branch 13.07 Release Branch 14.12 Upcoming Branch Thanks Christian, your fix is in trunk at r1682272 release branch 14.12 at r1682274 release branch 13.07 at r1682275 createConditionList doesn't handle widget dropdown multi-submitted values when called by performFind Key: OFBIZ-6310 URL: https://issues.apache.org/jira/browse/OFBIZ-6310 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Christian Carlow Assignee: Michael Brohl Fix For: Upcoming Branch, Release Branch 14.12, Release Branch 13.07 Attachments: OFBIZ-6310.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5679) Functionality to add WebSitePathAlias records is missing
[ https://issues.apache.org/jira/browse/OFBIZ-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-5679: - Affects Version/s: (was: Trunk) Upcoming Branch Functionality to add WebSitePathAlias records is missing Key: OFBIZ-5679 URL: https://issues.apache.org/jira/browse/OFBIZ-5679 Project: OFBiz Issue Type: Improvement Components: content Affects Versions: 11.04.04, 12.04.03, Upcoming Branch Reporter: Pierre Smits Assignee: Michael Brohl Attachments: addWebSitePathAlias.diff On websites in Content Mgr an overview to show path aliases (WebSitePathAlias entity) is available. However, the functionality to add path aliases is not available in the menu for the website. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
