[jira] [Created] (OFBIZ-7079) Extend Product entity and add serialized field
Deepak Dixit created OFBIZ-7079: --- Summary: Extend Product entity and add serialized field Key: OFBIZ-7079 URL: https://issues.apache.org/jira/browse/OFBIZ-7079 Project: OFBiz Issue Type: Improvement Reporter: Deepak Dixit Assignee: Deepak Dixit Extend Product entity and add serialized field to recognize product behavior. Will use product.serialized at the time of receiving to identified inventory item behavior. This will be setup time configuration, At the time of Product creation will set this flag. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7078) Extend OrderAdjustment entity and add isManual field
[
https://issues.apache.org/jira/browse/OFBIZ-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-7078:
Description:
Extend OrderAdjustment entity and add isManual field to recognize manually
added order adjustment.
As per current implementation code using orderAdjustment.comments field to
recognize manually added comment using string "Added manually by"
{code}
if ( adjustment.get("comments") != null
&&
((String)adjustment.get("comments")).startsWith("Added manually by")) {
cart.addAdjustment(adjustment);
}
{code}
was:
Extend OrderAdjustment entity and add isManual field to recognize if manually
added order adjustment.
As per current implementation code using orderAdjustment.comments to recognize
manually added comment using string "Added manually by"
{code}
if ( adjustment.get("comments") != null
&&
((String)adjustment.get("comments")).startsWith("Added manually by")) {
cart.addAdjustment(adjustment);
}
{code}
> Extend OrderAdjustment entity and add isManual field
>
>
> Key: OFBIZ-7078
> URL: https://issues.apache.org/jira/browse/OFBIZ-7078
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> Extend OrderAdjustment entity and add isManual field to recognize manually
> added order adjustment.
> As per current implementation code using orderAdjustment.comments field to
> recognize manually added comment using string "Added manually by"
> {code}
> if ( adjustment.get("comments") != null
> &&
> ((String)adjustment.get("comments")).startsWith("Added manually by")) {
> cart.addAdjustment(adjustment);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7078) Extend OrderAdjustment entity and add isManual field
Deepak Dixit created OFBIZ-7078:
---
Summary: Extend OrderAdjustment entity and add isManual field
Key: OFBIZ-7078
URL: https://issues.apache.org/jira/browse/OFBIZ-7078
Project: OFBiz
Issue Type: Improvement
Reporter: Deepak Dixit
Assignee: Deepak Dixit
Extend OrderAdjustment entity and add isManual field to recognize if manually
added order adjustment.
As per current implementation code using orderAdjustment.comments to recognize
manually added comment using string "Added manually by"
{code}
if ( adjustment.get("comments") != null
&&
((String)adjustment.get("comments")).startsWith("Added manually by")) {
cart.addAdjustment(adjustment);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7077) Unknown request error when generating Acctg Trans Entries PDF from invoice overview page
[ https://issues.apache.org/jira/browse/OFBIZ-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-7077: -- Assignee: Ashish Vijaywargiya > Unknown request error when generating Acctg Trans Entries PDF from invoice > overview page > > > Key: OFBIZ-7077 > URL: https://issues.apache.org/jira/browse/OFBIZ-7077 > Project: OFBiz > Issue Type: Bug > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 13.07 >Reporter: Ravi Lodhi >Assignee: Ashish Vijaywargiya > > Problem: > Unknown request [InvoiceAcctgTransEntriesPdf] > Step to regenerate: > 1) Go to http://demo-stable-ofbiz.apache.org/ar/control/FindArInvoices > 2) Go to invoice overview page of any sales invoice. > 3) Click on "Acctg Trans Entries PDF" button. > Root Cause: > InvoiceAcctgTransEntriesPdf request was available in the birt component of > specialpurpose and that component was removed from the specialpurpose in > 13.07 release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7003) Error when accessing project manager
[
https://issues.apache.org/jira/browse/OFBIZ-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandan Khandelwal updated OFBIZ-7003:
--
Attachment: OFBIZ-7003-1512.patch
OFBIZ-7003-1412.patch
> Error when accessing project manager
>
>
> Key: OFBIZ-7003
> URL: https://issues.apache.org/jira/browse/OFBIZ-7003
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Chandan Khandelwal
>Priority: Minor
> Attachments: OFBIZ-7003-1412.patch, OFBIZ-7003-1512.patch,
> OFBIZ-7003.patch
>
>
> I am running SVN version 1738958.
> Problem
> ===
> I navigate to https://localhost:8443/projectmgr, and found the following
> error on the console:
> {code}
> 2016-04-14 22:31:56,648 |http-nio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [projectmgr/getProject] finished in [24] milliseconds
> 2016-04-14 22:31:56,724 |http-nio-8443-exec-3 |FlexibleStringExpander
> |W| Error evaluating scriptlet
> [${groovy:isBillable&&actualNonBilledTotalHours!=void?actualNonBilledTotalHours:""}];
> error was: groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:52)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGroovyObjectGetProperty(AbstractCallSite.java:307)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> script14606441839311459442740.run(script14606441839311459442740.groovy:1)
> ~[?:?]
> at org.ofbiz.base.util.ScriptUtil.evaluate(ScriptUtil.java:263)
> ~[ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander$ScriptElem.get(FlexibleStringExpander.java:657)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:437)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:407)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.getDescription(ModelFormField.java:1496)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroFormRenderer.renderDisplayField(MacroFormRenderer.java:194)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.renderFieldString(ModelFormField.java:1615)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:724)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRow(FormRenderer.java:582)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRows(FormRenderer.java:899)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderListFormString(FormRenderer.java:941)
> [ofbiz-widget.jar:?]
> at org.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:266)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1053)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:678)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:599)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:906)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:127)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:943)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget
[jira] [Created] (OFBIZ-7077) Unknown request error when generating Acctg Trans Entries PDF from invoice overview page
Ravi Lodhi created OFBIZ-7077: - Summary: Unknown request error when generating Acctg Trans Entries PDF from invoice overview page Key: OFBIZ-7077 URL: https://issues.apache.org/jira/browse/OFBIZ-7077 Project: OFBiz Issue Type: Bug Components: accounting, specialpurpose/birt Affects Versions: Release Branch 13.07 Reporter: Ravi Lodhi Problem: Unknown request [InvoiceAcctgTransEntriesPdf] Step to regenerate: 1) Go to http://demo-stable-ofbiz.apache.org/ar/control/FindArInvoices 2) Go to invoice overview page of any sales invoice. 3) Click on "Acctg Trans Entries PDF" button. Root Cause: InvoiceAcctgTransEntriesPdf request was available in the birt component of specialpurpose and that component was removed from the specialpurpose in 13.07 release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: OFBiz Committers Survey
Sharan, Actually it's a matter of past and future. Your questions were all oriented toward future, and that's a good thing. But I believe we must not forget the past; we need to mix it with future to hope for a best one. Some also call the past "technical debt". We all signed up to this debt, and we need to take care about it. Pierre for instance regularly post a list of available patches in the user ML (see my comment about that)... Jacques Le 19/05/2016 à 20:26, Sharan Foga a écrit : Hi Jacques Thanks for the feedback. Maybe I should have included an 'other' category to capture these extra possibilities. Anyway please remember this new option and we can include it in the post survey discussions. Thanks Sharan On 19 May 2016 19:36, "Jacques Le Roux" wrote: Thanks Sharan, There is only one question I was not convinced to answer to:"What do you think would help improve the project? Please rank these in the order of importance." IMO, it missed one option: "Review and possibly apply the pending patches". A lot get lost because people tend to focus on their own issues... Jacques Le 18/05/2016 à 17:10, Sharan-F a écrit : Hi Everyone It's been a long while since I last did any kind of community survey and this time I'd like to survey our committers – so I'm hoping our committers are willing to participate. :-) I'm currently working on finalising it all and hope that it can be sent out by the end of this week. I'll keep it open for a fixed time (maybe up to a week) and then will summarise and publish the results. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: OFBiz Committers Survey
Hi Jacques Thanks for the feedback. Maybe I should have included an 'other' category to capture these extra possibilities. Anyway please remember this new option and we can include it in the post survey discussions. Thanks Sharan On 19 May 2016 19:36, "Jacques Le Roux" wrote: > Thanks Sharan, > > There is only one question I was not convinced to answer to:"What do you > think would help improve the project? Please rank these in the order of > importance." > > IMO, it missed one option: "Review and possibly apply the pending > patches". A lot get lost because people tend to focus on their own issues... > > Jacques > > > Le 18/05/2016 à 17:10, Sharan-F a écrit : > >> Hi Everyone >> >> It's been a long while since I last did any kind of community survey and >> this time I'd like to survey our committers – so I'm hoping our committers >> are willing to participate. :-) >> >> I'm currently working on finalising it all and hope that it can be sent >> out >> by the end of this week. I'll keep it open for a fixed time (maybe up to a >> week) and then will summarise and publish the results. >> >> Thanks >> Sharan >> >> >> >> >> -- >> View this message in context: >> http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727.html >> Sent from the OFBiz - Dev mailing list archive at Nabble.com. >> >> >> >
Re: OFBiz Committers Survey
Thanks Sharan, There is only one question I was not convinced to answer to:"What do you think would help improve the project? Please rank these in the order of importance." IMO, it missed one option: "Review and possibly apply the pending patches". A lot get lost because people tend to focus on their own issues... Jacques Le 18/05/2016 à 17:10, Sharan-F a écrit : Hi Everyone It's been a long while since I last did any kind of community survey and this time I'd like to survey our committers – so I'm hoping our committers are willing to participate. :-) I'm currently working on finalising it all and hope that it can be sent out by the end of this week. I'll keep it open for a fixed time (maybe up to a week) and then will summarise and publish the results. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: OFBiz Committers Survey
Hi Taher Sorry that wasnt clear - yes 1 is the highest. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680812.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: OFBiz Committers Survey
Sharan the ranking for importance I assume 1 is highest importance. If not I need to retake the survey On May 19, 2016 7:46 PM, "Sharan-F" wrote: > Thanks guys for responding so quickly. > > It is only 10 questions so I think it's straightforward and very quick to > do. > > Thanks > Sharan > > > > -- > View this message in context: > http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680809.html > Sent from the OFBiz - Dev mailing list archive at Nabble.com. >
Re: OFBiz Committers Survey
Thanks guys for responding so quickly. It is only 10 questions so I think it's straightforward and very quick to do. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680809.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: OFBiz Committers Survey
Done here too On May 19, 2016 7:23 PM, "Nicolas Malin" wrote: > done, > > thks Sharan for this initiative > > Nicolas > > Le 19/05/2016 15:24, Sharan-F a écrit : > >> Hi Everyone >> >> I've sent out the survey today so all our committers (including emeritus >> and >> inactive) should get an email with a link to it. >> I'll plan to keep the survey open for 7 days (less if I get all the >> responses back beforehand!) to give people enough time to complete it. >> >> Thanks in advance for your feedback. >> >> Thanks >> Sharan >> >> >> >> >> -- >> View this message in context: >> http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680804.html >> Sent from the OFBiz - Dev mailing list archive at Nabble.com. >> > >
Re: OFBiz Committers Survey
done, thks Sharan for this initiative Nicolas Le 19/05/2016 15:24, Sharan-F a écrit : Hi Everyone I've sent out the survey today so all our committers (including emeritus and inactive) should get an email with a link to it. I'll plan to keep the survey open for 7 days (less if I get all the responses back beforehand!) to give people enough time to complete it. Thanks in advance for your feedback. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680804.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: OFBiz Committers Survey
done! On 19/05/2016 15:24, Sharan-F wrote: Hi Everyone I've sent out the survey today so all our committers (including emeritus and inactive) should get an email with a link to it. I'll plan to keep the survey open for 7 days (less if I get all the responses back beforehand!) to give people enough time to complete it. Thanks in advance for your feedback. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680804.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: OFBiz Committers Survey
Hi Everyone I've sent out the survey today so all our committers (including emeritus and inactive) should get an email with a link to it. I'll plan to keep the survey open for 7 days (less if I get all the responses back beforehand!) to give people enough time to complete it. Thanks in advance for your feedback. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680804.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Closed] (OFBIZ-7075) Sending mail button from viewProfile doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-7075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7075. -- Resolution: Fixed Fix Version/s: Upcoming Branch Thanks Florian, Your patch is in trunk r1744571. No needs to backport, all previous releases branches work well > Sending mail button from viewProfile doesn't work > - > > Key: OFBIZ-7075 > URL: https://issues.apache.org/jira/browse/OFBIZ-7075 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux > Labels: contact, mail, party > Fix For: Upcoming Branch > > Attachments: OFBIZ-7075.patch > > > Hi, > The button 'send mail' from the profile overview page is not working. > How to reproduce : > 1) Go to the party component > 2) Search for an party with a registered mail address > 3) Go to the profile page : i.e. : > https://localhost:8443/partymgr/control/viewprofile?partyId=admin > 4) Click on the "send mail" button > 5) Nothing happens > Problem : > When checking the target of the button "send mail", we can see that a "@" > symbol appears. The target corresponds to the form name just above (the one > containing the email address). Thus, the form name contains the symbol too. > This symbol seems to be forbidden in javascript naming (a warning is risen by > the browser console) and this prevents the execution of the javascript. > When manually deleting this symbol in both the name of the form and the > target of the button, the javascript works fine. > Root of the problem : > In the "Contact.ftl" template, which creates this form, we can see that the > name of the form and the target are created from the 'contactMech.infoString' > (the email address in this case). A parsing of the string is done to remove > the "@" symbol and the "." . The dot is deleted but not the at symbol. The > problem comes from the encoding of the symbol. The parsing looks for a html > coding "@" but in the source code of the page, the symbol is in UCS > "@" . > I'll provide the patch adding a replace with this encoding. > Thanks, > Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7050) CMS does not store "Long text"
[ https://issues.apache.org/jira/browse/OFBIZ-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291079#comment-15291079 ] Jacques Le Roux commented on OFBIZ-7050: Comparing with R15.12 it seems this bug did not exist there, I did not went further... > CMS does not store "Long text" > -- > > Key: OFBIZ-7050 > URL: https://issues.apache.org/jira/browse/OFBIZ-7050 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > Attachments: cms.patch > > > When create content via CMS > (Content --> Websites --> [Select Website for example WebStore] --> CMS ) > the text content does not get stored. No error message available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7057) UiLabel for the GeneratedDescription is missing in promotion details screen
[ https://issues.apache.org/jira/browse/OFBIZ-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291075#comment-15291075 ] Jacques Le Roux commented on OFBIZ-7057: Yes I also think we should go this way indeed. Hopefully there should be only few bugs concerned and backporting by hand (because of OFBIZ-6810) should not be huge tasks > UiLabel for the GeneratedDescription is missing in promotion details screen > --- > > Key: OFBIZ-7057 > URL: https://issues.apache.org/jira/browse/OFBIZ-7057 > Project: OFBiz > Issue Type: Bug > Components: order, specialpurpose/ecommerce >Affects Versions: Release Branch 14.12, Trunk >Reporter: Swapnil M Mane >Assignee: Pranay Pandey >Priority: Trivial > Fix For: 14.12.01 > > Attachments: OFBIZ-7057.patch, show_promo_detail.png > > > Steps to regenerate > 1.) Create an Order from Order Entry > 2.) Apply any promo > 3.) Now as promo is applied, it is shown in the applied promo list below > 4.) The UiLabel for the promo is EcommerceGeneratedDescription > Reason: > The ftl (applications/order/template/entry/cart/promotiondetails.ftl) used > for showing the promotion detail is common for ecommerce and order entry. > Solution: > Moved the UiLable EcommerceGeneratedDescription to the OrderUiLabels > Since OrderUiLabels are included in the E-Commerce main-decorator > Please refer attached screenshot show_promo_detail.png for more details. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
buildbot success in on ofbiz-branch15
The Buildbot has detected a restored build on builder ofbiz-branch15 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch15/builds/65 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz15-commit' triggered this build Build Source Stamp: [branch ofbiz/branches/release15.12] 1744560 Blamelist: pranayp Build succeeded! Sincerely, -The Buildbot
[jira] [Commented] (OFBIZ-7057) UiLabel for the GeneratedDescription is missing in promotion details screen
[ https://issues.apache.org/jira/browse/OFBIZ-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291014#comment-15291014 ] Pranay Pandey commented on OFBIZ-7057: -- Done in R15.12 at r1744560. Thanks [~swapnilmmane] for reporting the issue and providing patch. > UiLabel for the GeneratedDescription is missing in promotion details screen > --- > > Key: OFBIZ-7057 > URL: https://issues.apache.org/jira/browse/OFBIZ-7057 > Project: OFBiz > Issue Type: Bug > Components: order, specialpurpose/ecommerce >Affects Versions: Release Branch 14.12, Trunk >Reporter: Swapnil M Mane >Assignee: Pranay Pandey >Priority: Trivial > Fix For: 14.12.01 > > Attachments: OFBIZ-7057.patch, show_promo_detail.png > > > Steps to regenerate > 1.) Create an Order from Order Entry > 2.) Apply any promo > 3.) Now as promo is applied, it is shown in the applied promo list below > 4.) The UiLabel for the promo is EcommerceGeneratedDescription > Reason: > The ftl (applications/order/template/entry/cart/promotiondetails.ftl) used > for showing the promotion detail is common for ecommerce and order entry. > Solution: > Moved the UiLable EcommerceGeneratedDescription to the OrderUiLabels > Since OrderUiLabels are included in the E-Commerce main-decorator > Please refer attached screenshot show_promo_detail.png for more details. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6109) Have quote report show product name(s)
[ https://issues.apache.org/jira/browse/OFBIZ-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291019#comment-15291019 ] Ashish Vijaywargiya commented on OFBIZ-6109: Thanks Pierre for creating the issue and thanks Ravi for verifying the same. > Have quote report show product name(s) > -- > > Key: OFBIZ-6109 > URL: https://issues.apache.org/jira/browse/OFBIZ-6109 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Ashish Vijaywargiya > > Currently the quote report (pdf) only shows the product id. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6109) Have quote report show product name(s)
[ https://issues.apache.org/jira/browse/OFBIZ-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya closed OFBIZ-6109. -- Resolution: Cannot Reproduce Tried with the steps mentioned by Ravi. It is working as expected and showing Product Name as well in the PDF. For now closing this issue. > Have quote report show product name(s) > -- > > Key: OFBIZ-6109 > URL: https://issues.apache.org/jira/browse/OFBIZ-6109 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Ashish Vijaywargiya > > Currently the quote report (pdf) only shows the product id. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7057) UiLabel for the GeneratedDescription is missing in promotion details screen
[ https://issues.apache.org/jira/browse/OFBIZ-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291009#comment-15291009 ] Pranay Pandey commented on OFBIZ-7057: -- Hi Jacques, [OFBIZ-6810] is rather a big effort and is an improvement and [OFBIZ-7050] is a bug. If we go with a general rule that any bug fixes should find their way to the release. We should backport this one and [OFBIZ-7050] to Release 14.12 and 15.12 if the bug exists there. I am taking care of this issue, will merge it to 15.12 as well. Thanks! > UiLabel for the GeneratedDescription is missing in promotion details screen > --- > > Key: OFBIZ-7057 > URL: https://issues.apache.org/jira/browse/OFBIZ-7057 > Project: OFBiz > Issue Type: Bug > Components: order, specialpurpose/ecommerce >Affects Versions: Release Branch 14.12, Trunk >Reporter: Swapnil M Mane >Assignee: Pranay Pandey >Priority: Trivial > Fix For: 14.12.01 > > Attachments: OFBIZ-7057.patch, show_promo_detail.png > > > Steps to regenerate > 1.) Create an Order from Order Entry > 2.) Apply any promo > 3.) Now as promo is applied, it is shown in the applied promo list below > 4.) The UiLabel for the promo is EcommerceGeneratedDescription > Reason: > The ftl (applications/order/template/entry/cart/promotiondetails.ftl) used > for showing the promotion detail is common for ecommerce and order entry. > Solution: > Moved the UiLable EcommerceGeneratedDescription to the OrderUiLabels > Since OrderUiLabels are included in the E-Commerce main-decorator > Please refer attached screenshot show_promo_detail.png for more details. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1744537 - /ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
Hi,
Nah not really worth it, and I worked hard to keep commons-cli completely
decoupled from ofbiz, I don't want to pass any specific parameters from
main for sure.
If someone adds new options in the future and the output looks wrong, then
everything can be fixed in one isolated place: StartupCommandUtil
Taher Alkhateeb
On May 19, 2016 3:48 PM, "Pierre Smits" wrote:
Hi Taher,
Shouldn't the '+6' element in the
{code}
HelpFormatter.DEFAULT_WIDTH
{code}
code change be something that users want to configure?
Best regards,
Pierre Smits
ORRTIZ.COM
OFBiz based solutions & services
OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/
On Thu, May 19, 2016 at 10:54 AM, wrote:
> Author: taher
> Date: Thu May 19 08:54:03 2016
> New Revision: 1744537
>
> URL: http://svn.apache.org/viewvc?rev=1744537&view=rev
> Log:
> improve the --test command documentation and widen commons-cli screen
> OFBIZ-6783
>
> as suggested by Jacques, the commons-cli screen is widened to be
> 80 characters instead of the default 74 characters. Also the test
> command for java -jar ofbiz.jar is improved in terms of documentation
> so that it does not break off into a newline which was confusing
>
> Modified:
>
>
ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
>
> Modified:
>
ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
> URL:
>
http://svn.apache.org/viewvc/ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java?rev=1744537&r1=1744536&r2=1744537&view=diff
>
>
==
> ---
>
ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
> (original)
> +++
>
ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
> Thu May 19 08:54:03 2016
> @@ -123,7 +123,9 @@ public final class StartupCommandUtil {
> + System.lineSeparator()
> + "--test component=base --test case=somecase"
> + System.lineSeparator()
> -+ "--test component=base --test suitename=somesuite")
> ++ "or"
> ++ System.lineSeparator()
> ++ "--test component=base --test suitename=xyz")
> .numberOfArgs(2)
> .valueSeparator('=')
> .optionalArg(true)
> @@ -166,7 +168,7 @@ public final class StartupCommandUtil {
> HelpFormatter formatter = new HelpFormatter();
> formatter.printHelp(
> new PrintWriter(printStream, true),
> -HelpFormatter.DEFAULT_WIDTH,
> +HelpFormatter.DEFAULT_WIDTH + 6,
> "java -jar ofbiz.jar",
> System.lineSeparator() + "Executes OFBiz command e.g.
> start, shutdown, check status, etc",
> getOfbizStartupOptions(),
>
>
>
[jira] [Updated] (OFBIZ-7076) Error on getting inventory history report in HTML
[ https://issues.apache.org/jira/browse/OFBIZ-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7076: --- Affects Version/s: Release Branch 14.12 > Error on getting inventory history report in HTML > - > > Key: OFBIZ-7076 > URL: https://issues.apache.org/jira/browse/OFBIZ-7076 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-7076-screenshot.png > > > Error on getting inventory history report in HTML. Please find attached > screenshot of error: > Steps to reproduce the issue: > 1. Go to > https://localhost:8443/facility/control/ViewFacilityInventoryHistoryReport?action=Y&facilityId=WebStoreWarehouse > 2. Export the report with content type HTML. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1744537 - /ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
Hi Taher,
Shouldn't the '+6' element in the
{code}
HelpFormatter.DEFAULT_WIDTH
{code}
code change be something that users want to configure?
Best regards,
Pierre Smits
ORRTIZ.COM
OFBiz based solutions & services
OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/
On Thu, May 19, 2016 at 10:54 AM, wrote:
> Author: taher
> Date: Thu May 19 08:54:03 2016
> New Revision: 1744537
>
> URL: http://svn.apache.org/viewvc?rev=1744537&view=rev
> Log:
> improve the --test command documentation and widen commons-cli screen
> OFBIZ-6783
>
> as suggested by Jacques, the commons-cli screen is widened to be
> 80 characters instead of the default 74 characters. Also the test
> command for java -jar ofbiz.jar is improved in terms of documentation
> so that it does not break off into a newline which was confusing
>
> Modified:
>
> ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
>
> Modified:
> ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java?rev=1744537&r1=1744536&r2=1744537&view=diff
>
> ==
> ---
> ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
> (original)
> +++
> ofbiz/trunk/framework/start/src/org/ofbiz/base/start/StartupCommandUtil.java
> Thu May 19 08:54:03 2016
> @@ -123,7 +123,9 @@ public final class StartupCommandUtil {
> + System.lineSeparator()
> + "--test component=base --test case=somecase"
> + System.lineSeparator()
> -+ "--test component=base --test suitename=somesuite")
> ++ "or"
> ++ System.lineSeparator()
> ++ "--test component=base --test suitename=xyz")
> .numberOfArgs(2)
> .valueSeparator('=')
> .optionalArg(true)
> @@ -166,7 +168,7 @@ public final class StartupCommandUtil {
> HelpFormatter formatter = new HelpFormatter();
> formatter.printHelp(
> new PrintWriter(printStream, true),
> -HelpFormatter.DEFAULT_WIDTH,
> +HelpFormatter.DEFAULT_WIDTH + 6,
> "java -jar ofbiz.jar",
> System.lineSeparator() + "Executes OFBiz command e.g.
> start, shutdown, check status, etc",
> getOfbizStartupOptions(),
>
>
>
[jira] [Assigned] (OFBIZ-7076) Error on getting inventory history report in HTML
[ https://issues.apache.org/jira/browse/OFBIZ-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-7076: -- Assignee: Amardeep Singh Jhajj Sorry Amardeep, was to fast when assigning myself, did not see you did it already, reassigned you :) > Error on getting inventory history report in HTML > - > > Key: OFBIZ-7076 > URL: https://issues.apache.org/jira/browse/OFBIZ-7076 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-7076-screenshot.png > > > Error on getting inventory history report in HTML. Please find attached > screenshot of error: > Steps to reproduce the issue: > 1. Go to > https://localhost:8443/facility/control/ViewFacilityInventoryHistoryReport?action=Y&facilityId=WebStoreWarehouse > 2. Export the report with content type HTML. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7076) Error on getting inventory history report in HTML
[ https://issues.apache.org/jira/browse/OFBIZ-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-7076: -- Assignee: (was: Jacques Le Roux) > Error on getting inventory history report in HTML > - > > Key: OFBIZ-7076 > URL: https://issues.apache.org/jira/browse/OFBIZ-7076 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj > Attachments: OFBIZ-7076-screenshot.png > > > Error on getting inventory history report in HTML. Please find attached > screenshot of error: > Steps to reproduce the issue: > 1. Go to > https://localhost:8443/facility/control/ViewFacilityInventoryHistoryReport?action=Y&facilityId=WebStoreWarehouse > 2. Export the report with content type HTML. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7076) Error on getting inventory history report in HTML
[ https://issues.apache.org/jira/browse/OFBIZ-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-7076: -- Assignee: Jacques Le Roux (was: Amardeep Singh Jhajj) > Error on getting inventory history report in HTML > - > > Key: OFBIZ-7076 > URL: https://issues.apache.org/jira/browse/OFBIZ-7076 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Jacques Le Roux > Attachments: OFBIZ-7076-screenshot.png > > > Error on getting inventory history report in HTML. Please find attached > screenshot of error: > Steps to reproduce the issue: > 1. Go to > https://localhost:8443/facility/control/ViewFacilityInventoryHistoryReport?action=Y&facilityId=WebStoreWarehouse > 2. Export the report with content type HTML. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6783) Refactor the start component
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290791#comment-15290791
]
Jacques Le Roux edited comment on OFBIZ-6783 at 5/19/16 10:57 AM:
--
Cool, could we not have also
{code}
--testlist file=runtime/test-list-build.xml
and
--testlist mode=ant or --testlist mode=text
{code}
I believe it's else still confusing, despite
{code}
Also a command must be invoked separately for each argument e.g.
java -jar ofbiz.jar --test component=somecomp --test case=somecase
{code}
TL;DR always wins against RTFM! ;)
was (Author: jacques.le.roux):
Cool, could we not have also
{code}
--testlist file=runtime/test-list-build.xml
and
--testlist mode=ant or --testlist mode=text
{code}
I believe it's else still confusing, despite
{code}
Also a command must be invoked separately for each argument e.g.
java -jar ofbiz.jar --test component=somecomp --test case=somecase
{code}
TL;DR always wins again RTFM! ;)
> Refactor the start component
>
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7071) CategoryContent & ProductContent cachekey problem on multi tenant environment
[ https://issues.apache.org/jira/browse/OFBIZ-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290894#comment-15290894 ] Jacques Le Roux commented on OFBIZ-7071: Yes, but this one was about "Flaw in content wrapper cache handling with encoderType" which has been fixed. I expected you to create a new (another) Jira, anyway it's done now, thanks for spotting it initially :) > CategoryContent & ProductContent cachekey problem on multi tenant environment > - > > Key: OFBIZ-7071 > URL: https://issues.apache.org/jira/browse/OFBIZ-7071 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: Multitenant >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux > Fix For: 14.12.01, 15.12.01 > > Attachments: ofbiz.patch > > > Two tenants: > DEMO1 > DEMO2 > Category Demo 1: > c-0001 > Title: Demo1 > Category Demo 2: > c-0001 > Title: Demo2 > Depending on which tenant did create the cachekey, both tenants will display > the same title. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290893#comment-15290893 ] Jacques Le Roux commented on OFBIZ-6783: Thks! > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7071) CategoryContent & ProductContent cachekey problem on multi tenant environment
[ https://issues.apache.org/jira/browse/OFBIZ-7071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290862#comment-15290862 ] Wai commented on OFBIZ-7071: The jira I reported earlier is the one you're referring to. > CategoryContent & ProductContent cachekey problem on multi tenant environment > - > > Key: OFBIZ-7071 > URL: https://issues.apache.org/jira/browse/OFBIZ-7071 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: Multitenant >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux > Fix For: 14.12.01, 15.12.01 > > Attachments: ofbiz.patch > > > Two tenants: > DEMO1 > DEMO2 > Category Demo 1: > c-0001 > Title: Demo1 > Category Demo 2: > c-0001 > Title: Demo2 > Depending on which tenant did create the cachekey, both tenants will display > the same title. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290813#comment-15290813 ] Taher Alkhateeb commented on OFBIZ-6783: done in r1744547. > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290794#comment-15290794 ] Jacques Le Roux commented on OFBIZ-6783: This would need an extra Jira, but also some arguments... Why not improve it? > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290791#comment-15290791
]
Jacques Le Roux commented on OFBIZ-6783:
Cool, could we not have also
{code}
--testlist file=runtime/test-list-build.xml
and
--testlist mode=ant or --testlist mode=text
{code}
I believe it's else still confusing, despite
{code}
Also a command must be invoked separately for each argument e.g.
java -jar ofbiz.jar --test component=somecomp --test case=somecase
{code}
TL;DR always wins again RTFM! ;)
> Refactor the start component
>
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7076) Error on getting inventory history report in HTML
[ https://issues.apache.org/jira/browse/OFBIZ-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amardeep Singh Jhajj updated OFBIZ-7076: Attachment: OFBIZ-7076-screenshot.png > Error on getting inventory history report in HTML > - > > Key: OFBIZ-7076 > URL: https://issues.apache.org/jira/browse/OFBIZ-7076 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-7076-screenshot.png > > > Error on getting inventory history report in HTML. Please find attached > screenshot of error: > Steps to reproduce the issue: > 1. Go to > https://localhost:8443/facility/control/ViewFacilityInventoryHistoryReport?action=Y&facilityId=WebStoreWarehouse > 2. Export the report with content type HTML. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7076) Error on getting inventory history report in HTML
Amardeep Singh Jhajj created OFBIZ-7076: --- Summary: Error on getting inventory history report in HTML Key: OFBIZ-7076 URL: https://issues.apache.org/jira/browse/OFBIZ-7076 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release Branch 15.12, Trunk Reporter: Amardeep Singh Jhajj Assignee: Amardeep Singh Jhajj Error on getting inventory history report in HTML. Please find attached screenshot of error: Steps to reproduce the issue: 1. Go to https://localhost:8443/facility/control/ViewFacilityInventoryHistoryReport?action=Y&facilityId=WebStoreWarehouse 2. Export the report with content type HTML. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290729#comment-15290729 ] Taher Alkhateeb commented on OFBIZ-6783: Ok, committed in r1744537. The screen width for commons-cli is now 80 characters instead of the default 74 (a little wider and nicer) I also fixed the --test documentation so that it is no longer confusing. > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290687#comment-15290687 ] Jacques Le Roux commented on OFBIZ-6783: A wider screen would help readability, but there could still be cases, notably when maintained. So indeed a sign to say it continues on next line would be definitely better! BTW I don't think we need to parse too much, I mean eg no needs to test for a --test alone, etc. > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7003) Error when accessing project manager
[
https://issues.apache.org/jira/browse/OFBIZ-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandan updated OFBIZ-7003:
---
Attachment: OFBIZ-7003.patch
> Error when accessing project manager
>
>
> Key: OFBIZ-7003
> URL: https://issues.apache.org/jira/browse/OFBIZ-7003
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Chandan
>Priority: Minor
> Attachments: OFBIZ-7003.patch
>
>
> I am running SVN version 1738958.
> Problem
> ===
> I navigate to https://localhost:8443/projectmgr, and found the following
> error on the console:
> {code}
> 2016-04-14 22:31:56,648 |http-nio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [projectmgr/getProject] finished in [24] milliseconds
> 2016-04-14 22:31:56,724 |http-nio-8443-exec-3 |FlexibleStringExpander
> |W| Error evaluating scriptlet
> [${groovy:isBillable&&actualNonBilledTotalHours!=void?actualNonBilledTotalHours:""}];
> error was: groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:52)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGroovyObjectGetProperty(AbstractCallSite.java:307)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> script14606441839311459442740.run(script14606441839311459442740.groovy:1)
> ~[?:?]
> at org.ofbiz.base.util.ScriptUtil.evaluate(ScriptUtil.java:263)
> ~[ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander$ScriptElem.get(FlexibleStringExpander.java:657)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:437)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:407)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.getDescription(ModelFormField.java:1496)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroFormRenderer.renderDisplayField(MacroFormRenderer.java:194)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.renderFieldString(ModelFormField.java:1615)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:724)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRow(FormRenderer.java:582)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRows(FormRenderer.java:899)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderListFormString(FormRenderer.java:941)
> [ofbiz-widget.jar:?]
> at org.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:266)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1053)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:678)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:599)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:906)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:127)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:943)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:459)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelS
[jira] [Commented] (OFBIZ-7003) Error when accessing project manager
[
https://issues.apache.org/jira/browse/OFBIZ-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290686#comment-15290686
]
Chandan commented on OFBIZ-7003:
Hi Montalbano Florian,
Your findings looks good, I have also explored the issue and found that
property "actualNonBilledTotalHours" does not exist in the current context and
seems like its typo as it is already available in context as
"actualNonBilledHours".
I have attached a patch with minor improvements in service to declare the
variable with default-value="0" to avoid No such property exception.
Kindly share your thoughts on this.
--
Chandan Khandelwal
> Error when accessing project manager
>
>
> Key: OFBIZ-7003
> URL: https://issues.apache.org/jira/browse/OFBIZ-7003
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Chandan
>Priority: Minor
>
> I am running SVN version 1738958.
> Problem
> ===
> I navigate to https://localhost:8443/projectmgr, and found the following
> error on the console:
> {code}
> 2016-04-14 22:31:56,648 |http-nio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [projectmgr/getProject] finished in [24] milliseconds
> 2016-04-14 22:31:56,724 |http-nio-8443-exec-3 |FlexibleStringExpander
> |W| Error evaluating scriptlet
> [${groovy:isBillable&&actualNonBilledTotalHours!=void?actualNonBilledTotalHours:""}];
> error was: groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:52)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGroovyObjectGetProperty(AbstractCallSite.java:307)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> script14606441839311459442740.run(script14606441839311459442740.groovy:1)
> ~[?:?]
> at org.ofbiz.base.util.ScriptUtil.evaluate(ScriptUtil.java:263)
> ~[ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander$ScriptElem.get(FlexibleStringExpander.java:657)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:437)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:407)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.getDescription(ModelFormField.java:1496)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroFormRenderer.renderDisplayField(MacroFormRenderer.java:194)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.renderFieldString(ModelFormField.java:1615)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:724)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRow(FormRenderer.java:582)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRows(FormRenderer.java:899)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderListFormString(FormRenderer.java:941)
> [ofbiz-widget.jar:?]
> at org.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:266)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1053)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:678)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:599)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:906)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:127)
> [ofbiz-widget.jar:?]
>
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290672#comment-15290672 ] Jacques Le Roux commented on OFBIZ-6783: Thanks! > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290671#comment-15290671 ] Taher Alkhateeb commented on OFBIZ-6783: Yeah I see why you got confused by that. So there are two problems here: 1- The second example breaks into two lines due to screen width 2- It does not show like they are two separate examples, it looks like one single command Which one confuse you? or is it both? If so, I can make the screen a little wider for commons-cli and also add the word "OR between the two lines. What do you think? > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6783) Refactor the start component
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290663#comment-15290663
]
Jacques Le Roux edited comment on OFBIZ-6783 at 5/19/16 8:11 AM:
-
About
bq. java -jar ofbiz.jar --test component=minilang --test
Actually I was abused by this line in help
{code}
-t,--test Runs the selected test or all if none
selected e.g.:
--test component=base --test case=somecase
--test component=base --test
suitename=somesuite
{code}
Could we not increase the width of the help?
was (Author: jacques.le.roux):
Actually I was abused by this line in help
bq. -t,--test Runs the selected test or all if none
selected e.g.:
--test component=base --test case=somecase
--test component=base --test
suitename=somesuite
> Refactor the start component
>
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290667#comment-15290667 ] Jacques Le Roux commented on OFBIZ-6783: Indeed, this happens also with bq. java -jar ofbiz.jar --test ie in your version. So it's not fixed by your changes (I see no reasons why it would, just saying ;)) > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290663#comment-15290663 ] Jacques Le Roux commented on OFBIZ-6783: Actually I was abused by this line in help bq. -t,--test Runs the selected test or all if none selected e.g.: --test component=base --test case=somecase --test component=base --test suitename=somesuite > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290661#comment-15290661 ] Taher Alkhateeb commented on OFBIZ-6783: Also another commit in r1744528 to clarify the usage in the footer. > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7042) "Forgot your password" link in login page is not working for Web POS
[ https://issues.apache.org/jira/browse/OFBIZ-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7042: --- Fix Version/s: 15.12.01 14.12.01 > "Forgot your password" link in login page is not working for Web POS > > > Key: OFBIZ-7042 > URL: https://issues.apache.org/jira/browse/OFBIZ-7042 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/webpos >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7042-14.12.patch, OFBIZ-7042-15.12.patch, > OFBIZ-7042-screenshot-1.png, OFBIZ-7042.patch > > > On clicking "Forgot your password" link from Web POS login page, system > navigating to blank page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290652#comment-15290652 ] Taher Alkhateeb commented on OFBIZ-6783: Hmmm, definitely worth investigating. It is my intention to attack all 16 containers once I'm done with refactoring the start component. I will definitely dig into this soon. > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7003) Error when accessing project manager
[
https://issues.apache.org/jira/browse/OFBIZ-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandan updated OFBIZ-7003:
---
Assignee: Chandan
> Error when accessing project manager
>
>
> Key: OFBIZ-7003
> URL: https://issues.apache.org/jira/browse/OFBIZ-7003
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Chandan
>Priority: Minor
>
> I am running SVN version 1738958.
> Problem
> ===
> I navigate to https://localhost:8443/projectmgr, and found the following
> error on the console:
> {code}
> 2016-04-14 22:31:56,648 |http-nio-8443-exec-3 |ServiceDispatcher
> |T| Sync service [projectmgr/getProject] finished in [24] milliseconds
> 2016-04-14 22:31:56,724 |http-nio-8443-exec-3 |FlexibleStringExpander
> |W| Error evaluating scriptlet
> [${groovy:isBillable&&actualNonBilledTotalHours!=void?actualNonBilledTotalHours:""}];
> error was: groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> groovy.lang.MissingPropertyException: No such property:
> actualNonBilledTotalHours for class: script14606441839311459442740
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:52)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGroovyObjectGetProperty(AbstractCallSite.java:307)
> ~[groovy-all-2.4.5.jar:2.4.5]
> at
> script14606441839311459442740.run(script14606441839311459442740.groovy:1)
> ~[?:?]
> at org.ofbiz.base.util.ScriptUtil.evaluate(ScriptUtil.java:263)
> ~[ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander$ScriptElem.get(FlexibleStringExpander.java:657)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:437)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.base.util.string.FlexibleStringExpander.expandString(FlexibleStringExpander.java:407)
> [ofbiz-base.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.getDescription(ModelFormField.java:1496)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroFormRenderer.renderDisplayField(MacroFormRenderer.java:194)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField$DisplayField.renderFieldString(ModelFormField.java:1615)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:724)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRow(FormRenderer.java:582)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderItemRows(FormRenderer.java:899)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.FormRenderer.renderListFormString(FormRenderer.java:941)
> [ofbiz-widget.jar:?]
> at org.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:266)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1053)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:678)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:599)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:906)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:127)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:943)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:459)
> [ofbiz-widget.jar:?]
> at
> org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290647#comment-15290647
]
Jacques Le Roux commented on OFBIZ-6783:
And a Ctrl+C gave me that
{code}
2016-05-19 09:46:43,169 |main |TestRunContainer
|I| [JUNIT] Pass: true | # Tests: 5 | # Failed: 0 # Errors: 0
org.ofbiz.base.start.StartupException: Cannot start()
org.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:239)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:446)
at org.ofbiz.base.start.Start.start(Start.java:191)
at org.ofbiz.base.start.Start.main(Start.java:88)
Caused by: org.ofbiz.base.container.ContainerException: Test run was
unsuccessful
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:193)
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
... 3 more
Exception in thread "main" org.ofbiz.base.start.StartupException:
java.lang.Exception: Error during start. (Error during start.)
at org.ofbiz.base.start.Start.main(Start.java:91)
Caused by: java.lang.Exception: Error during start.
at org.ofbiz.base.start.Start.start(Start.java:195)
at org.ofbiz.base.start.Start.main(Start.java:88)
2016-05-19 09:48:28,669 |Thread-0 |ContainerLoader
|I| Shutting down containers
2016-05-19 09:48:28,669 |Thread-0 |ContainerLoader
|I| Stopping container testtools-container
2016-05-19 09:48:28,669 |Thread-0 |ContainerLoader
|I| Stopped container testtools-container
2016-05-19 09:48:28,669 |Thread-0 |ContainerLoader
|I| Stopping container catalina-container-test
2016-05-19 09:48:28,893 FATAL Unable to register shutdown hook because JVM is
shutting down.
2016-05-19 09:48:28,895 |0.0.0.0-startStop-2 |ServiceContainer
|I| Removing from cache dispatcher: ebay
2016-05-19 09:48:28,895 |0.0.0.0-startStop-2 |ServiceDispatcher
|I| De-Registering dispatcher: ebay
{code}
Note the
bq. FATAL Unable to register shutdown hook because JVM is shutting down.
!
Yours is far better!
> Refactor the start component
>
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290645#comment-15290645
]
Jacques Le Roux commented on OFBIZ-6783:
Ah indeed, anyway same with
bq. java -jar ofbiz.jar --test component=minilang
BTW when running
bq. java -jar ofbiz.jar test
with your commit reverted (so old way)
I get this at some point
{code}
2016-05-19 09:46:43,169 |main |TestRunContainer
|I| [JUNIT] Pass: true | # Tests: 5 | # Failed: 0 # Errors: 0
org.ofbiz.base.start.StartupException: Cannot start()
org.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:239)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:446)
at org.ofbiz.base.start.Start.start(Start.java:191)
at org.ofbiz.base.start.Start.main(Start.java:88)
Caused by: org.ofbiz.base.container.ContainerException: Test run was
unsuccessful
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:193)
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
... 3 more
Exception in thread "main" org.ofbiz.base.start.StartupException:
java.lang.Exception: Error during start. (Error during start.)
at org.ofbiz.base.start.Start.main(Start.java:91)
Caused by: java.lang.Exception: Error during start.
at org.ofbiz.base.start.Start.start(Start.java:195)
at org.ofbiz.base.start.Start.main(Start.java:88)
{code}
And then it's blocked. Anyway we don't care now... so just to say...
> Refactor the start component
>
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290646#comment-15290646 ] Taher Alkhateeb commented on OFBIZ-6783: Hi Jacques, Thank you for reverting, I have implemented your work in r1744525. It's a simple prettyprinter in StartupCommandUtil that highlights your error message at the top. > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first
[ https://issues.apache.org/jira/browse/OFBIZ-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290644#comment-15290644 ] Rohit Koushal commented on OFBIZ-5935: -- Hi [~arun.patidar] Thanks for posting the solution. I have attached the patch. Please review and let me know if you have any concern. > Sales tax adjustments manually added to purchase orders cause creation of > another adjustment undoing the first > -- > > Key: OFBIZ-5935 > URL: https://issues.apache.org/jira/browse/OFBIZ-5935 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Arun Patidar >Priority: Minor > Attachments: Image 094.png, OFBIZ-5935.patch > > > For example, if a sales tax adjustment of 0.20 is manually added to a > purchase order, another adjustment will be created for -0.20. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first
[ https://issues.apache.org/jira/browse/OFBIZ-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-5935: - Comment: was deleted (was: Hi [~arun.patidar] Thanks for the posting the solution. I have attached the patch. Please review and let me know if you have any concern.) > Sales tax adjustments manually added to purchase orders cause creation of > another adjustment undoing the first > -- > > Key: OFBIZ-5935 > URL: https://issues.apache.org/jira/browse/OFBIZ-5935 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Arun Patidar >Priority: Minor > Attachments: Image 094.png, OFBIZ-5935.patch > > > For example, if a sales tax adjustment of 0.20 is manually added to a > purchase order, another adjustment will be created for -0.20. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first
[ https://issues.apache.org/jira/browse/OFBIZ-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-5935: - Attachment: OFBIZ-5935.patch Hi [~arun.patidar] Thanks for the posting the solution. I have attached the patch. Please review and let me know if you have any concern. > Sales tax adjustments manually added to purchase orders cause creation of > another adjustment undoing the first > -- > > Key: OFBIZ-5935 > URL: https://issues.apache.org/jira/browse/OFBIZ-5935 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Arun Patidar >Priority: Minor > Attachments: Image 094.png, OFBIZ-5935.patch > > > For example, if a sales tax adjustment of 0.20 is manually added to a > purchase order, another adjustment will be created for -0.20. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290634#comment-15290634 ] Taher Alkhateeb commented on OFBIZ-6783: Hi Jacques, I guess need to further finetune the validation rules. The correct syntax is simple java -jar ofbiz.jar --test component=minilang You have an extra --test which is unneeded. I think I need to add too many validation rules > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290628#comment-15290628
]
Jacques Le Roux commented on OFBIZ-6783:
OK, I will simply revert and let you handling things, it's indeed only
formatting anyway.
BTW, I think I can't compare with what we had before because AFAIK we could
only run all tests. But when I ran
bq. java -jar ofbiz.jar --test component=minilang --test
I got this in stopping phase
{code}
2016-05-19 09:22:51,685 |main |ContainerLoader
|I| Started container testtools-container
2016-05-19 09:22:51,685 |main |ContainerLoader
|I| Shutting down containers
2016-05-19 09:22:51,685 |main |ContainerLoader
|I| Stopping container testtools-container
2016-05-19 09:22:51,685 |main |ContainerLoader
|I| Stopped container testtools-container
2016-05-19 09:22:51,686 |main |ContainerLoader
|I| Stopping container catalina-container-test
2016-05-19 09:22:51,844 |0.0.0.0-startStop-2 |ServiceContainer
|I| Removing from cache dispatcher: ebay
2016-05-19 09:22:51,844 |0.0.0.0-startStop-2 |ServiceDispatcher
|I| De-Registering dispatcher: ebay
2016-05-19 09:22:51,848 |0.0.0.0-startStop-2 |WebappClassLoaderBase
|W| The web application [ebay] appears to have started a thread named
[OFBiz-JobPoller] but has failed to stop it. This is very lik
ely to create a memory leak. Stack trace of thread:
java.lang.Thread.sleep(Native Method)
org.ofbiz.service.job.JobPoller$JobManagerPoller.run(JobPoller.java:214)
java.lang.Thread.run(Unknown Source)
2016-05-19 09:22:51,849 |0.0.0.0-startStop-2 |WebappClassLoaderBase
|W| The web application [ebay] appears to have started a thread named
[RetryTimer] but has failed to stop it. This is very likely t
o create a memory leak. Stack trace of thread:
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Unknown Source)
java.util.TimerThread.mainLoop(Unknown Source)
java.util.TimerThread.run(Unknown Source)
2016-05-19 09:22:51,849 |0.0.0.0-startStop-2 |WebappClassLoaderBase
|W| The web application [ebay] appears to have started a thread named
[ForkJoinPool-1-worker-3] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.ForkJoinPool.awaitWork(Unknown Source)
java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source)
2016-05-19 09:22:51,849 |0.0.0.0-startStop-2 |WebappClassLoaderBase
|W| The web application [ebay] appears to have started a thread named
[ForkJoinPool-1-worker-5] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.ForkJoinPool.awaitWork(Unknown Source)
java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source)
2016-05-19 09:22:51,849 |0.0.0.0-startStop-2 |WebappClassLoaderBase
|W| The web application [ebay] appears to have started a thread named
[ForkJoinPool-1-worker-6] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.ForkJoinPool.awaitWork(Unknown Source)
java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source)
2016-05-19 09:22:51,850 |0.0.0.0-startStop-2 |WebappClassLoaderBase
|W| The web application [ebay] appears to have started a thread named
[ForkJoinPool-1-worker-7] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.ForkJoinPool.awaitWork(Unknown Source)
java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source)
2016-05-19 09:22:51,856 |0.0.0.0-startStop-2 |ServiceContainer
|I| Removing from cache dispatcher: marketing
2016-05-19 09:22:51,856 |0.0.0.0-startStop-2 |ServiceDispatcher
|I| De-Registering dispatcher: marketing
2016-05-19 09:22:51,869 |0.0.0.0-startStop-2 |ServiceContainer
|I| Removing from cache dispatcher: oagismgr
2016-05-19 09:22:51,869 |0.0.0.0-startStop-2 |ServiceDispatcher
|I| De-Registering dispatcher: oagismgr
2016-05-19 09:22:51,875 |0.0.0.0-startStop-2 |ServiceContainer
|I| Removing from cache dispatcher: order
2016-05-19 09:22:51,875 |0.0.0.0-startStop-2 |ServiceDispatcher
|I| De-Registering dispatcher: order
2016-05-19 09:22:51,881 |0.0.0.0-startStop-2 |ServiceContainer
|I| Removing
[jira] [Updated] (OFBIZ-6776) Amount to capture for order is in-correct after manual refund electronic transaction
[ https://issues.apache.org/jira/browse/OFBIZ-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-6776: - Assignee: (was: Pranay Pandey) > Amount to capture for order is in-correct after manual refund electronic > transaction > > > Key: OFBIZ-6776 > URL: https://issues.apache.org/jira/browse/OFBIZ-6776 > Project: OFBiz > Issue Type: Bug > Components: accounting, order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Nameet > Fix For: Upcoming Branch > > Attachments: OFBIZ-6776.patch, OFBIZ-6776.patch > > > Steps to regenerate- > 1) Place a sales order of Rainbow Gizmo. Order Total was of $29.91. Order > will be in approved status and in *Payment Information* section you will see > $29.91 as authorized and available to capture. > 2) Capture $15.00 by using the capture button available in *Payment > Information* block. System should successfully capture $15.00 and also new > authorized payment of $14.91 should be seen in Payment Information section. > 3) Refund $5.00 by using manual electronic transfer UI in accounting. System > successfully does the refund. > 4) Click quick ship entire order from order screen. As per payment > requirement, now system should proceed to complete the capture process for > amount $19.91($29.91 - $15(Captured) + $5(Refunded)) but it captures only > $9.91 and not showing any remaining amount to capture on order. Also the > order invoice due shows $0.00. > Possible reason of the issue is that refunded payment amount is being > considered by the system as received payment and hence amount to capture on > order is calculated wrong. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7042) "Forgot your password" link in login page is not working for Web POS
[ https://issues.apache.org/jira/browse/OFBIZ-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey closed OFBIZ-7042. Closing the ticket as now the issue is fixed in Trunk, Release 14.12 and 15.12. Thanks [~amardeepsj] for reporting the issue and providing patches. > "Forgot your password" link in login page is not working for Web POS > > > Key: OFBIZ-7042 > URL: https://issues.apache.org/jira/browse/OFBIZ-7042 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/webpos >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Attachments: OFBIZ-7042-14.12.patch, OFBIZ-7042-15.12.patch, > OFBIZ-7042-screenshot-1.png, OFBIZ-7042.patch > > > On clicking "Forgot your password" link from Web POS login page, system > navigating to blank page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OFBIZ-7042) "Forgot your password" link in login page is not working for Web POS
[ https://issues.apache.org/jira/browse/OFBIZ-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey resolved OFBIZ-7042. -- Resolution: Fixed > "Forgot your password" link in login page is not working for Web POS > > > Key: OFBIZ-7042 > URL: https://issues.apache.org/jira/browse/OFBIZ-7042 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/webpos >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Attachments: OFBIZ-7042-14.12.patch, OFBIZ-7042-15.12.patch, > OFBIZ-7042-screenshot-1.png, OFBIZ-7042.patch > > > On clicking "Forgot your password" link from Web POS login page, system > navigating to blank page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7042) "Forgot your password" link in login page is not working for Web POS
[ https://issues.apache.org/jira/browse/OFBIZ-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-7042: - Priority: Major (was: Critical) > "Forgot your password" link in login page is not working for Web POS > > > Key: OFBIZ-7042 > URL: https://issues.apache.org/jira/browse/OFBIZ-7042 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/webpos >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Attachments: OFBIZ-7042-14.12.patch, OFBIZ-7042-15.12.patch, > OFBIZ-7042-screenshot-1.png, OFBIZ-7042.patch > > > On clicking "Forgot your password" link from Web POS login page, system > navigating to blank page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
buildbot exception in on ofbiz-branch15
The Buildbot has detected a build exception on builder ofbiz-branch15 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch15/builds/64 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz15-commit' triggered this build Build Source Stamp: [branch ofbiz/branches/release15.12] 1744523 Blamelist: pranayp BUILD FAILED: exception upload_1 Sincerely, -The Buildbot
[jira] [Commented] (OFBIZ-7042) "Forgot your password" link in login page is not working for Web POS
[ https://issues.apache.org/jira/browse/OFBIZ-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290619#comment-15290619 ] Pranay Pandey commented on OFBIZ-7042: -- Thanks [~amardeepsj] for providing patches for releases as well. Committed in Release 14.12 at r1744522 and Release 15.12 at r1744523. > "Forgot your password" link in login page is not working for Web POS > > > Key: OFBIZ-7042 > URL: https://issues.apache.org/jira/browse/OFBIZ-7042 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/webpos >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey >Priority: Critical > Attachments: OFBIZ-7042-14.12.patch, OFBIZ-7042-15.12.patch, > OFBIZ-7042-screenshot-1.png, OFBIZ-7042.patch > > > On clicking "Forgot your password" link from Web POS login page, system > navigating to blank page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: OFBiz Committers Survey
Good initiative Sharan ! Thanks ! Julien. On 18/05/2016 17:10, Sharan-F wrote: Hi Everyone It's been a long while since I last did any kind of community survey and this time I'd like to survey our committers – so I'm hoping our committers are willing to participate. :-) I'm currently working on finalising it all and hope that it can be sent out by the end of this week. I'll keep it open for a fixed time (maybe up to a week) and then will summarise and publish the results. Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Commented] (OFBIZ-6783) Refactor the start component
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290599#comment-15290599 ] Taher Alkhateeb commented on OFBIZ-6783: Hi Jacques, This code does not look good, you shouldn't put formatting stuff in main. The same is true with StartupException. I suggest to create a prettyPrint function somewhere to take care of this if you want to box it with =. Otherwise, again we are mixing different levels of abstraction and making it extremely dependent on the device output. This means that if we ever decide to change the formatting of the help screen, then I have to go and change it everywhere you made the modifications to make it look pretty. Also, I implemented commons-cli so that each command must be called multiple times if it takes multiple arguments. Look at the below examples Example: java -jar ofbiz.jar --load-data readers=seed --load-data delegator=default another example: java -jar ofbiz.jar --test component=base --test suiteName=whatever So my suggestion is to instead specify in the header or footer of the help menu that you must pass the commands multiple times and remove the ", ie 2 --testlist" which is confusing anyway. My intention of this refactoring is to make Start.java and espeially main very short and clean. Your modifications for one thing makes the line width 175 characters wide in addition to having something very unimportant like formatting right there in main where the programmer should not be worried with such details. Sorry for rambling for too long, but it is these small things over long time that made the code as fragile as it is right now. So please consider a pretty printer for your formatting and hide it away from main. > Refactor the start component > > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
