date:20160718

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Taher Alkhateeb

Hi Scott,

Thank you for the feedback. To be focused exactly on integration vs unit, I
already mentioned above that at least for me the main objective is to
confidently and quickly run the tests in short bursts of red-green
refactor. This allows me to refactor code without waiting in front of the
screen in between test cycles thus giving me immediate feedback on any
errors I made. Perhaps my intro was too long so this is the squeezed out
version of it.

I already had one round of testing in the start component which was much
faster that way and had an immediate impact. Oh and by the way, you cannot
test the start component with integration tests for example unless you do
it from an external component which cannot access package protected items.

This style of coding is applicable I think to any software project
inclusive of OFBiz. Maybe in certain components more than others or certain
areas more than others. But I can't see how it could be bad or unwanted.

Taher Alkhateeb

On Jul 19, 2016 8:18 AM, "Scott Gray"  wrote:

> Thanks Ron and Taher for your responses, I appreciate them but I don't hear
> much in the conversation that speaks to the value of unit tests over
> integration tests.  Most of the thoughts shared speaks more to the value of
> tests rather than differences in the type of tests.
>
> Speed: At an application level we have ~685 tests that run in 35 seconds
> (excluding build and data load).  Another point is that there isn't much
> reason why tests can't be run in parallel rather than sequentially.
> TDD: Integration tests in OFBiz are as simple if not simpler to write than
> unit tests and just as useful for TDD.
> I'm not sure if I missed any other points raised regarding integration vs.
> unit tests?
>
> I'm not looking to start a big long debate on the topic, I just wanted to
> speak out that someone out there (me) doesn't think unit tests are the best
> solution for testing OFBiz applications.
>
> Regards
> Scott
>
> On 19 July 2016 at 16:52, Taher Alkhateeb 
> wrote:
>
> > Hi Scott,
> >
> > Thank you for your input. Your ideas are thought provoking and enriching
> to
> > the conversation.
> >
> > The way I look at it, the general rule is usually many unit tests, less
> > integration tests, lesser functional tests. So we are not excluding any
> > types of test, all of them are important in certain areas for certain
> > purposes with certain quantity. Usually integration tests are less
> because
> > as you said they just grab more. I like the picture below as a general
> > guideline
> >
> > http://i.stack.imgur.com/fjQvQ.png
> >
> > As you already mentioned unit tests are useful for the framework. I
> > discovered errors in code that I wrote which I was very very careful
> with.
> > I immediately learned the lesson that humans are not designed to code,
> and
> > TDD gives you confidence as you build your code with those short 30-60
> > second red-green refactors. I feel much much safer and more confident
> > writing code that way, the test also documents how to use the api,
> > refactoring and feature change becomes less terrifying. Also messy code
> is
> > usually not test friendly thus refactoring and unit tests go hand-in-hand
> > for improving the code base.
> >
> > Also, I am sorry to say that the framework code is rather messy and
> brittle
> > in many places. I think you probably encountered this yourself. The same
> is
> > said for the applications. Now If we start refactoring without unit tests
> > then we are back to scary business. So much can go wrong so fast and
> break
> > things you never expected to break. The framework with all applications
> > require heavy refactoring of things like massive ugly methods, sandwiched
> > logic, heavy shared mutable state, hidden dependencies, poor
> > interfaces, and much more. Every time I touch something I get shocked at
> > how bad it looks, spaghetti logic to no end. If you refactor with
> > integration tests instead of unit tests then you will come down to a
> > screeching halt as you wait between these test cycles. My computer
> actually
> > takes 10 minutes or more for a full clean load data and testing.
> >
> > Now talking about mocking you raise some interesting points, what can you
> > mock vs utilizing integration tests? This is an excellent question that
> > does not have a simple answer, and you mostly learn as you code,
> difficult
> > to envision without coding. However simple things like Java services can
> be
> > mocked with a standard mocking class that you use everywhere.
> Transactions
> > are difficult to mock and better left to integration tests I think. SECAs
> > might be mocked by simply passing output to input as chaining methods.
> Mind
> > you I am not 100% sure of all of this, coding is the ultimate guide to
> what
> > can or cannot be done.
> >
> > So I am not suggesting unit tests as a best-practice (even though it is).
> > Instead I suggest it as

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Scott Gray

Thanks Ron and Taher for your responses, I appreciate them but I don't hear
much in the conversation that speaks to the value of unit tests over
integration tests.  Most of the thoughts shared speaks more to the value of
tests rather than differences in the type of tests.

Speed: At an application level we have ~685 tests that run in 35 seconds
(excluding build and data load).  Another point is that there isn't much
reason why tests can't be run in parallel rather than sequentially.
TDD: Integration tests in OFBiz are as simple if not simpler to write than
unit tests and just as useful for TDD.
I'm not sure if I missed any other points raised regarding integration vs.
unit tests?

I'm not looking to start a big long debate on the topic, I just wanted to
speak out that someone out there (me) doesn't think unit tests are the best
solution for testing OFBiz applications.

Regards
Scott

On 19 July 2016 at 16:52, Taher Alkhateeb 
wrote:

> Hi Scott,
>
> Thank you for your input. Your ideas are thought provoking and enriching to
> the conversation.
>
> The way I look at it, the general rule is usually many unit tests, less
> integration tests, lesser functional tests. So we are not excluding any
> types of test, all of them are important in certain areas for certain
> purposes with certain quantity. Usually integration tests are less because
> as you said they just grab more. I like the picture below as a general
> guideline
>
> http://i.stack.imgur.com/fjQvQ.png
>
> As you already mentioned unit tests are useful for the framework. I
> discovered errors in code that I wrote which I was very very careful with.
> I immediately learned the lesson that humans are not designed to code, and
> TDD gives you confidence as you build your code with those short 30-60
> second red-green refactors. I feel much much safer and more confident
> writing code that way, the test also documents how to use the api,
> refactoring and feature change becomes less terrifying. Also messy code is
> usually not test friendly thus refactoring and unit tests go hand-in-hand
> for improving the code base.
>
> Also, I am sorry to say that the framework code is rather messy and brittle
> in many places. I think you probably encountered this yourself. The same is
> said for the applications. Now If we start refactoring without unit tests
> then we are back to scary business. So much can go wrong so fast and break
> things you never expected to break. The framework with all applications
> require heavy refactoring of things like massive ugly methods, sandwiched
> logic, heavy shared mutable state, hidden dependencies, poor
> interfaces, and much more. Every time I touch something I get shocked at
> how bad it looks, spaghetti logic to no end. If you refactor with
> integration tests instead of unit tests then you will come down to a
> screeching halt as you wait between these test cycles. My computer actually
> takes 10 minutes or more for a full clean load data and testing.
>
> Now talking about mocking you raise some interesting points, what can you
> mock vs utilizing integration tests? This is an excellent question that
> does not have a simple answer, and you mostly learn as you code, difficult
> to envision without coding. However simple things like Java services can be
> mocked with a standard mocking class that you use everywhere. Transactions
> are difficult to mock and better left to integration tests I think. SECAs
> might be mocked by simply passing output to input as chaining methods. Mind
> you I am not 100% sure of all of this, coding is the ultimate guide to what
> can or cannot be done.
>
> So I am not suggesting unit tests as a best-practice (even though it is).
> Instead I suggest it as something that I and others did and got a huge
> psychological relief and confidence and comfort from. Swimming in code
> without tests is a terrifying business, made more terrifying if the code is
> bad. Short bursts of red/green/red/green makes you feel good as you build
> up your logic. And I don't have an exact vision of how to do it, because
> the details always win.
>
> I look forward to hearing your thoughts and thank you for enriching this
> conversation.
>
> Taher Alkhateeb
>
> On Tuesday, 19 July 2016, Scott Gray  wrote:
>
> > I know I'm late to the party here, but I just want to say that I think
> > integration tests have far greater value to OFBiz than unit tests.
> Mostly
> > because we tend to have quite a low number of tests and integration tests
> > give us much better coverage per line of test code and the tests are much
> > closer to the real world scenarios the application might encounter.
> >
> > I don't really see how unit tests could be applied to non-framework
> testing
> > in a useful manner, could you expand on your vision in that regard?  I
> mean
> > would we be testing something smaller than a service as the 'unit'?  What
> > would we mock? Would transaction

[jira] [Commented] (OFBIZ-7365) fonts.pdf Throw error on terminal

2016-07-18 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383578#comment-15383578
 ] 

Deepak Dixit commented on OFBIZ-7365:
-

Its working fine, Error is related to "Broken Pipe"  It is caused by something 
causing the connection to close. (It is not your application that closed the 
connection: that would have resulted in a different exception.)

Its working fine for firefox and chrome.

> fonts.pdf Throw error on terminal
> -
>
> Key: OFBIZ-7365
> URL: https://issues.apache.org/jira/browse/OFBIZ-7365
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/example
>Reporter: Vaibhav Jain
>Assignee: Vaibhav Jain
>
> Steps to regenerate the issue:
> 1. Go to "EXAMPLE"  component.
> 2. Click on sub-menu "FOP fonts in a PDF"
> _
> Direct link
> https://localhost:8443/example/control/fonts.pdf
> _
> {code}
>   [java] 2016-06-13 19:25:34,639 |ttp-nio-8443-exec-10 |ScreenFopViewHandler  
> |E| Unable to write to OutputStream: 
> org.apache.catalina.connector.ClientAbortException: java.io.IOException: 
> Broken pipe; Screen XSL:FO text was:
> [java] 
> [java] 2016-06-13 19:25:35,084 |ttp-nio-8443-exec-10 |ScreenFopViewHandler
>   |E| Multiple errors rendering FOP
> [java] 2016-06-13 19:25:35,085 |ttp-nio-8443-exec-10 |ControlServlet  
>   |E| Error in request handler: 
> [java] java.lang.IllegalStateException: getOutputStream() has already 
> been called for this response
> [java] at 
> org.apache.catalina.connector.Response.getWriter(Response.java:564) 
> ~[tomcat-8.0.33-catalina.jar:8.0.33]
> [java] at 
> org.apache.catalina.connector.ResponseFacade.getWriter(ResponseFacade.java:212)
>  ~[tomcat-8.0.33-catalina.jar:8.0.33]
> [java] at 
> org.ofbiz.widget.renderer.fo.ScreenFopViewHandler.renderError(ScreenFopViewHandler.java:191)
>  ~[ofbiz-widget.jar:?]
> [java] at 
> org.ofbiz.widget.renderer.fo.ScreenFopViewHandler.render(ScreenFopViewHandler.java:174)
>  ~[ofbiz-widget.jar:?]
> [java] at 
> org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1001) 
> ~[ofbiz-webapp.jar:?]
> [java] at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:653) 
> ~[ofbiz-webapp.jar:?]
> [java] at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
> [java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) 
> [servlet-api-3.1.jar:?]
> [java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) 
> [servlet-api-3.1.jar:?]
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Taher Alkhateeb

Hi Scott,

Thank you for your input. Your ideas are thought provoking and enriching to
the conversation.

The way I look at it, the general rule is usually many unit tests, less
integration tests, lesser functional tests. So we are not excluding any
types of test, all of them are important in certain areas for certain
purposes with certain quantity. Usually integration tests are less because
as you said they just grab more. I like the picture below as a general
guideline

http://i.stack.imgur.com/fjQvQ.png

As you already mentioned unit tests are useful for the framework. I
discovered errors in code that I wrote which I was very very careful with.
I immediately learned the lesson that humans are not designed to code, and
TDD gives you confidence as you build your code with those short 30-60
second red-green refactors. I feel much much safer and more confident
writing code that way, the test also documents how to use the api,
refactoring and feature change becomes less terrifying. Also messy code is
usually not test friendly thus refactoring and unit tests go hand-in-hand
for improving the code base.

Also, I am sorry to say that the framework code is rather messy and brittle
in many places. I think you probably encountered this yourself. The same is
said for the applications. Now If we start refactoring without unit tests
then we are back to scary business. So much can go wrong so fast and break
things you never expected to break. The framework with all applications
require heavy refactoring of things like massive ugly methods, sandwiched
logic, heavy shared mutable state, hidden dependencies, poor
interfaces, and much more. Every time I touch something I get shocked at
how bad it looks, spaghetti logic to no end. If you refactor with
integration tests instead of unit tests then you will come down to a
screeching halt as you wait between these test cycles. My computer actually
takes 10 minutes or more for a full clean load data and testing.

Now talking about mocking you raise some interesting points, what can you
mock vs utilizing integration tests? This is an excellent question that
does not have a simple answer, and you mostly learn as you code, difficult
to envision without coding. However simple things like Java services can be
mocked with a standard mocking class that you use everywhere. Transactions
are difficult to mock and better left to integration tests I think. SECAs
might be mocked by simply passing output to input as chaining methods. Mind
you I am not 100% sure of all of this, coding is the ultimate guide to what
can or cannot be done.

So I am not suggesting unit tests as a best-practice (even though it is).
Instead I suggest it as something that I and others did and got a huge
psychological relief and confidence and comfort from. Swimming in code
without tests is a terrifying business, made more terrifying if the code is
bad. Short bursts of red/green/red/green makes you feel good as you build
up your logic. And I don't have an exact vision of how to do it, because
the details always win.

I look forward to hearing your thoughts and thank you for enriching this
conversation.

Taher Alkhateeb

On Tuesday, 19 July 2016, Scott Gray  wrote:

> I know I'm late to the party here, but I just want to say that I think
> integration tests have far greater value to OFBiz than unit tests.  Mostly
> because we tend to have quite a low number of tests and integration tests
> give us much better coverage per line of test code and the tests are much
> closer to the real world scenarios the application might encounter.
>
> I don't really see how unit tests could be applied to non-framework testing
> in a useful manner, could you expand on your vision in that regard?  I mean
> would we be testing something smaller than a service as the 'unit'?  What
> would we mock? Would transaction management still be active? What happens
> when the service calls another service, I guess we mock the response from
> that service (how)?
>
> It just seems a very complicated method to achieve a less thorough but
> albeit faster (maybe) test result.
>
> A build, data load and full test run takes 4m 9s on my laptop.  Excluding
> build, data load and framework tests: the application level tests take 35s,
> not very expensive IMO.  The data load time can be reduced to practically
> nothing by copying a clean slate database into runtime for each run.
>
> I'm mostly just suggesting we be wary of adding complicated testing
> procedures in the hope of achieving some 'best practice' result which in
> reality will provide minimal benefits.
>
> Regards
> Scott
>
> On 18 July 2016 at 18:57, Taher Alkhateeb  >
> wrote:
>
> > Hello Akash,
> >
> > Fantastic, I have a few unit tests almost done to be included in the
> start
> > component. I will create a new subtask under OFBIZ-1463 to commit the
> tests
> > so you can use them as a reference if you like to.
> >
> > I

Re: Temporary change for filling the "Fix Versions/s" field in Jira

2016-07-18 Thread Deepak Dixit

Thanks Jacques for update.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Jul 18, 2016 at 9:46 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Committer, Devs, All,
>
> You might have noticed I Temporary changed our policy about filling the
> "Fix Versions/s" field in Jira
>
> Please read
> https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=7766050=46=45
>
> Thanks
>
> Jacques
>
>

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Ron Wheeler


You are probably right that integration testing has a lot more value.
However, unit tests are still useful in their own right and may 
encourage people to write smaller classes that can be tested easily.


As you point out, integration testing can be done at several levels with 
mock implementations used to limit the scope of the tests.


A full set of integration tests would take a long time to run and even 
longer to construct.


You may also be right that building a lot of new unit tests to test old 
features may not be very valuable but getting developers to move towards 
TDD might reduce the number of regressions.
Unit testing does, at least, give positive proof of what has been tested 
when new code is presented for review.

It also demonstrates the use of a class which may add to the specifications.

It is usually possible to exclude tests that are redundant or not 
relative to the new features being added.
There is not a lot of point in running low-level unit tests repeatedly 
in a development cycle if you are not changing the classes being tested.

This is trivial to manage in Maven with jUnit and Surefire.
Not sure about the Gradle build.

Proper integration tests that cover load testing, synchronization, 
caching and locking under tests of all UI features would be wonderful to 
have but would take a long time to construct given the number of feature 
combinations, stack configurations and use cases.
A full test would take a long time to run and would be something that 
would be useful only a few times in each release cycle.
Very useful if versions are going to be released with any sort of 
implied warranty about quality.


The current activity is a big step forward and Taher's leadership in 
modernizing the framework seems to have inspired a lot of new activity 
and a more modern way of thinking about software development.


Well done.


Ron


On 18/07/2016 10:19 PM, Scott Gray wrote:

I know I'm late to the party here, but I just want to say that I think
integration tests have far greater value to OFBiz than unit tests.  Mostly
because we tend to have quite a low number of tests and integration tests
give us much better coverage per line of test code and the tests are much
closer to the real world scenarios the application might encounter.

I don't really see how unit tests could be applied to non-framework testing
in a useful manner, could you expand on your vision in that regard?  I mean
would we be testing something smaller than a service as the 'unit'?  What
would we mock? Would transaction management still be active? What happens
when the service calls another service, I guess we mock the response from
that service (how)?

It just seems a very complicated method to achieve a less thorough but
albeit faster (maybe) test result.

A build, data load and full test run takes 4m 9s on my laptop.  Excluding
build, data load and framework tests: the application level tests take 35s,
not very expensive IMO.  The data load time can be reduced to practically
nothing by copying a clean slate database into runtime for each run.

I'm mostly just suggesting we be wary of adding complicated testing
procedures in the hope of achieving some 'best practice' result which in
reality will provide minimal benefits.

Regards
Scott

On 18 July 2016 at 18:57, Taher Alkhateeb 
wrote:


Hello Akash,

Fantastic, I have a few unit tests almost done to be included in the start
component. I will create a new subtask under OFBIZ-1463 to commit the tests
so you can use them as a reference if you like to.

I also recommend that you follow the same directory structure between the
test code and production code. So for example:

Production code: framework/start/src/main/java/org/apache/ofbiz/base/start
Test code: framework/start/src/test/java/org/apache/ofbiz/base/start

The benefit of this hierarchy is that you can access non-public (package
protected) methods for testing. This is in fact exactly what I needed to be
able to apply some of the tests.

Cheers,

Taher Alkhateeb

On Mon, Jul 18, 2016 at 9:22 AM, Akash Jain 
wrote:


Thanks Taher for nice initiative!

We are planning to written unit tests to all components under OFBIZ-1463

Thanks and Regards
--
Akash Jain

On Mon, Jul 18, 2016 at 10:36 AM, Taher Alkhateeb <
slidingfilame...@gmail.com> wrote:


Hello Everyone,

In reference to this thread and the Jira OFBIZ-7254, I'm very happy to
announce that OFBiz is now ready for applying unit tests with only 8

new

lines of code in the build script (r1753143) :)

I recommend we do the following moving forward:

1- Introduce unit tests as much as we can to all components
2- Migrate most of the integration tests we currently have to unit

tests

(since they are designed to do very little integration).

This is a great chance for us to practice real TDD in OFBiz

Cheers,

Taher Alkhateeb

On Mon, Jun 13, 2016 at 7:43 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com>

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Scott Gray

I know I'm late to the party here, but I just want to say that I think
integration tests have far greater value to OFBiz than unit tests.  Mostly
because we tend to have quite a low number of tests and integration tests
give us much better coverage per line of test code and the tests are much
closer to the real world scenarios the application might encounter.

I don't really see how unit tests could be applied to non-framework testing
in a useful manner, could you expand on your vision in that regard?  I mean
would we be testing something smaller than a service as the 'unit'?  What
would we mock? Would transaction management still be active? What happens
when the service calls another service, I guess we mock the response from
that service (how)?

It just seems a very complicated method to achieve a less thorough but
albeit faster (maybe) test result.

A build, data load and full test run takes 4m 9s on my laptop.  Excluding
build, data load and framework tests: the application level tests take 35s,
not very expensive IMO.  The data load time can be reduced to practically
nothing by copying a clean slate database into runtime for each run.

I'm mostly just suggesting we be wary of adding complicated testing
procedures in the hope of achieving some 'best practice' result which in
reality will provide minimal benefits.

Regards
Scott

On 18 July 2016 at 18:57, Taher Alkhateeb 
wrote:

> Hello Akash,
>
> Fantastic, I have a few unit tests almost done to be included in the start
> component. I will create a new subtask under OFBIZ-1463 to commit the tests
> so you can use them as a reference if you like to.
>
> I also recommend that you follow the same directory structure between the
> test code and production code. So for example:
>
> Production code: framework/start/src/main/java/org/apache/ofbiz/base/start
> Test code: framework/start/src/test/java/org/apache/ofbiz/base/start
>
> The benefit of this hierarchy is that you can access non-public (package
> protected) methods for testing. This is in fact exactly what I needed to be
> able to apply some of the tests.
>
> Cheers,
>
> Taher Alkhateeb
>
> On Mon, Jul 18, 2016 at 9:22 AM, Akash Jain 
> wrote:
>
> > Thanks Taher for nice initiative!
> >
> > We are planning to written unit tests to all components under OFBIZ-1463
> >
> > Thanks and Regards
> > --
> > Akash Jain
> >
> > On Mon, Jul 18, 2016 at 10:36 AM, Taher Alkhateeb <
> > slidingfilame...@gmail.com> wrote:
> >
> > > Hello Everyone,
> > >
> > > In reference to this thread and the Jira OFBIZ-7254, I'm very happy to
> > > announce that OFBiz is now ready for applying unit tests with only 8
> new
> > > lines of code in the build script (r1753143) :)
> > >
> > > I recommend we do the following moving forward:
> > >
> > > 1- Introduce unit tests as much as we can to all components
> > > 2- Migrate most of the integration tests we currently have to unit
> tests
> > > (since they are designed to do very little integration).
> > >
> > > This is a great chance for us to practice real TDD in OFBiz
> > >
> > > Cheers,
> > >
> > > Taher Alkhateeb
> > >
> > > On Mon, Jun 13, 2016 at 7:43 AM, Pranay Pandey <
> > > pranay.pan...@hotwaxsystems.com> wrote:
> > >
> > > > +1
> > > >
> > > > Best regards,
> > > >
> > > > Pranay Pandey
> > > > HotWax Systems
> > > > http://www.hotwaxsystems.com/
> > > >
> > > > On Fri, Jun 10, 2016 at 7:46 PM, Taher Alkhateeb <
> > > > slidingfilame...@gmail.com
> > > > > wrote:
> > > >
> > > > > Hello Everyone,
> > > > >
> > > > > I was able to get a few tests running and this is very doable. But
> I
> > > > faced
> > > > > a big problem in designing the testing framework because of ANT.
> > > > >
> > > > > The problem
> > > > > 
> > > > > The way the build scripts are designed in OFBiz are very complex. A
> > > > master
> > > > > file calls other files which call other files. And in the middle
> you
> > > have
> > > > > external libraries (ant-contrib) and macros, and variables, and
> class
> > > > path
> > > > > declarations, and and and 
> > > > >
> > > > > I cannot declare the tests programmatically (with JUnit test
> suites)
> > > > > because this means lower level components would depend on higher
> > level
> > > > > components. So I have to do it in ANT, by navigating this maze of
> > build
> > > > > scripts, and it was a headache for me just to read them, let alone
> > > modify
> > > > > them to create a testing framework.
> > > > >
> > > > > Suggested Solution
> > > > > 
> > > > > I suggest to implement the testing framework in Gradle, and simply
> > call
> > > > it
> > > > > from within ant. This is a middle solution that sustains ant for
> now,
> > > but
> > > > > can allow us to switch out later.
> > > > >
> > > > > This means I will just add one more file called build.gradle in the
> > top
> > > > > level directory, and figure out the business logic for calling the
> >

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Hans Bakker

great initiative Taher, finally someone who values automated tests to 
enable TDD but also leading to continuous improvement and finally 
continuous deployment


Regards,
Hans Bakker
CEO AntWebsystems.com

On 18/07/16 12:06, Taher Alkhateeb wrote:

Hello Everyone,

In reference to this thread and the Jira OFBIZ-7254, I'm very happy to
announce that OFBiz is now ready for applying unit tests with only 8 new
lines of code in the build script (r1753143) :)

I recommend we do the following moving forward:

1- Introduce unit tests as much as we can to all components
2- Migrate most of the integration tests we currently have to unit tests
(since they are designed to do very little integration).

This is a great chance for us to practice real TDD in OFBiz

Cheers,

Taher Alkhateeb

On Mon, Jun 13, 2016 at 7:43 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:


+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 10, 2016 at 7:46 PM, Taher Alkhateeb <
slidingfilame...@gmail.com

wrote:



Hello Everyone,

I was able to get a few tests running and this is very doable. But I

faced

a big problem in designing the testing framework because of ANT.

The problem

The way the build scripts are designed in OFBiz are very complex. A

master

file calls other files which call other files. And in the middle you have
external libraries (ant-contrib) and macros, and variables, and class

path

declarations, and and and 

I cannot declare the tests programmatically (with JUnit test suites)
because this means lower level components would depend on higher level
components. So I have to do it in ANT, by navigating this maze of build
scripts, and it was a headache for me just to read them, let alone modify
them to create a testing framework.

Suggested Solution

I suggest to implement the testing framework in Gradle, and simply call

it

from within ant. This is a middle solution that sustains ant for now, but
can allow us to switch out later.

This means I will just add one more file called build.gradle in the top
level directory, and figure out the business logic for calling the test
suites from that file

I look forward to your feedback.

Regards,

Taher Alkhateeb

On Wed, Jun 8, 2016 at 6:00 PM, Taher Alkhateeb <
slidingfilame...@gmail.com>
wrote:


Hi Everyone,

Thank you all for your support, JIRA created in
https://issues.apache.org/jira/browse/OFBIZ-7254

I will start working on it and try to implement ASAP to get my focus

back

on refactoring.

Cheers!

Taher Alkhateeb

On Wed, Jun 8, 2016 at 4:58 PM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:


+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Wed, Jun 8, 2016 at 7:12 PM, Mridul Pathak <
mridul.pat...@hotwaxsystems.com> wrote:


+1

Makes perfect sense.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com


On Jun 8, 2016, at 2:41 PM, Taher Alkhateeb <

slidingfilame...@gmail.com>

wrote:


Hello Everyone,

After refactoring the start component and while starting on the

base

component I realized that the testing framework for OFBiz is not

good.

You

cannot do real test driven development or red-green-refactor with

the

current setup, hence my proposal to change it. I explain below:

Problem with current design

- What we have right now is not unit tests, it's really

integration

tests.

You have to start the framework, the database, the service engine,

the

entity engine and pretty much everything.
- Testing is very slow, because it's an integration test as I

mentioned

above. 10 minutes on a good computer!
- There is zero mocking! We actually have to --load-data for

things

to

work. Again, these are integration tests.
- Too complex: Integration tests by their nature are grabbing too

much.

Mind you, I am not objecting to integration tests (I actually like

them)

but I am objecting to not having real unit-tests. Unit tests

should

all

run

in a few seconds.

Proposed solution
--
- We keep what is considered real integration tests the way they

are

right

now and keep using them
- We move what should be unit tests into simple JUnit classes, and

we

do

not run them using java -jar ofbiz.jar --test, but instead run

them

directly from the build.xml script, so these files are not

identified

in

any XML document, but are simply called immediately from the build

scripts.

- We clearly mark the difference between integration tests and

unit

tests

(inside the source files or in the suite declarations).
- We change the run-tests target in build.xml to run both unit

tests

and

integration tests.

I intend to heavily refactor the framework and I would feel better

about

introducing this change while refactoring. What do you guys think?

Ideas?

Suggestions? Approvals and thumbs up?

Regards,

Taher Alkhateeb
















--

Re: svn commit: r1752972 - in /ofbiz/trunk/applications: accounting/config/AccountingUiLabels.xml order/template/return/QuickReturn.ftl party/template/party/EditGiftCard.ftl party/template/party/profi

2016-07-18 Thread Jacques Le Roux


At least, AccountingCreateNewCreditCard was used in ReturnForms.xml

Jacques


Le 18/07/2016 à 21:45, Michael Brohl a écrit :

HI Vikas,

the comments in Jira https://issues.apache.org/jira/browse/OFBIZ-7707 say that 
these labels are obsolete, have you checked this?

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 18.07.16 um 20:24 schrieb Vikas Mayur:

Just for a cosmetic and trivial (JIRA issue indicates that) change loosing
the translation to 15 odd languages, is it desirable? It might be years
effort to have the label defined in those languages.


Regards
Vikas

On Sat, Jul 16, 2016 at 9:22 AM,  wrote:


Author: pranayp
Date: Sat Jul 16 14:22:18 2016
New Revision: 1752972

URL: http://svn.apache.org/viewvc?rev=1752972=rev
Log:
[OFBIZ-7707] Improved payment method information UI on party profile
screen for creating new payment methods. Thanks Chandan Khandelwal for the
contribution.

Modified:
ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
ofbiz/trunk/applications/order/template/return/QuickReturn.ftl
ofbiz/trunk/applications/party/template/party/EditGiftCard.ftl

ofbiz/trunk/applications/party/template/party/profileblocks/PaymentMethods.ftl

Modified: ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml?rev=1752972=1752971=1752972=diff

==
--- ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
(original)
+++ ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml Sat
Jul 16 14:22:18 2016
@@ -3555,6 +3555,18 @@
  æ–°å»ºæˆ æœ¬ç»„ä»¶è®¡ç®—
  æ–°å»ºæˆ æœ¬å…ƒä»¶è¨ˆç®—
  
+
+Create Credit Card
+à¤•à¥ à¤°à¥‡à¤¡à¤¿à¤Ÿ à¤•à¤¾à¤°à¥ à¤¡
à¤¬à¤¨à¤¾à¤ à¤ 
+
+
+Create EFT Account
+à¤ˆà¤ à¤«à¤¼à¤Ÿà¥€(EFT) à¤–à¤¾à¤¤à¤¾
à¤¬à¤¨à¤¾à¤ à¤ 
+
+
+Create Gift Card
+à¤‰à¤ªà¤¹à¤¾à¤° à¤•à¤¾à¤°à¥ à¤¡
à¤¬à¤¨à¤¾à¤ à¤ 
+
  
  Berechtigungsfehler: Um
'createFixedAssetMaintOrder' auszufÃ¼hren muss man ACCOUNTING_CREATEUPDATE
or ACCOUNTING_ADMIN Berechtigungen haben
  Security Error: to run
createFixedAssetMaintOrder you must have the ACCOUNTING_CREATEUPDATE or
ACCOUNTING_ADMIN permission, or the limited ACCOUNTING_ROLE_CREATE
permission
@@ -3570,25 +3582,6 @@
  å®‰å…¨é”™è¯¯ï¼šè¦ è¿
è¡Œæ–°å»ºå›ºå®šèµ„äº§ç»´ä¿®ä¿ å…»è®¢å
•(createFixedAssetMaintOrder)ï¼Œä½ 
å¿…é¡»æœ‰ACCOUNTING_CREATEUPDATEæˆ–ACCOUNTING_ADMINæ
ƒé™ ï¼Œæˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ ƒé™ 
  å®‰å…¨éŒ¯èª¤:è¦
åŸ·è¡Œæ–°å»ºå›ºå®šè³‡ç”¢ç¶ä¿®ä¿
é¤Šè¨‚å–®(createFixedAssetMaintOrder),ä½ å¿…é 
ˆæœ‰ACCOUNTING_CREATEUPDATEæˆ–ACCOUNTING_ADMINæ¬Šé™
,æˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ¬Šé™ 
  
-
-Ø®Ù„Ù‚ Ø¨Ø·Ø§Ù‚Ø© Ø§Ø¦ØªÙ…Ø§Ù†
Ø¬Ø¯ÙŠØ¯Ø©
-Neue Kreditkarte erstellen
-Create New Credit Card
-Crear nueva tarjeta de crÃ©dito
-Enregistrer une nouvelle carte de
crÃ©dit
-à¤¨à¤¯à¤¾ à¤•à¥ à¤°à¥‡à¤¡à¤¿à¤Ÿ
à¤•à¤¾à¤°à¥ à¤¡ à¤¬à¤¨à¤¾à¤ à¤ 
-Creare Nuova Carta Credito
-æ–°è¦ ã‚¯ãƒ¬ã‚¸ãƒƒãƒˆã‚«ãƒ¼ãƒ‰ã‚’ä½œæˆ

-Nieuwe kredietkaart aanmaken
-Criar Novo CartÃ£o de CrÃ©dito
-Criar Novo CartÃ£o de CrÃ©dito
-Creaza Noua Carte de Credit
-Ð¡Ð¾Ð·Ð´Ð°Ñ‚ÑŒ Ð½Ð¾Ð²ÑƒÑŽ ÐºÑ€ÐµÐ´Ð¸Ñ‚Ð½ÑƒÑŽ
ÐºÐ°Ñ€Ñ‚Ñƒ
-à¸ªà¸£à¹‰à¸²à¸‡à¸šà¸±à¸•à¸£à¹€à¸„à¸£à¸”à¸´à¸•à¹ƒà¸«à¸¡à¹ˆ
-ThÃªm má»›i Tháº» tÃn dá»¥ng
-åˆ›å»ºæ–°ä¿¡ç”¨å ¡
-æ–°å»ºæ–°ä¿¡ç”¨å ¡
-
  
  Ø®Ù„Ù‚ Ø¯Ù Ø¹Ø© Ø§ÙŠØ¯Ø§Ø¹ Ø¬Ø¯ÙŠØ¯Ø©
  Neue Einzahlung
@@ -3637,25 +3630,6 @@
  ä¸ºè´¢åŠ¡è´¦æˆ·æ–°å»ºå˜æ¬¾å
•ï¼š${finAccount.finAccountName} [${finAccountId}]
  ç‚ºè²¡å‹™å¸³æˆ¶æ–°å»ºå˜æ¬¾å–®:${finAccount.finAccountName}
[${finAccountId}]
  
-
-Ø®Ù„Ù‚ ØØ³Ø§Ø¨ EFT Ø¬Ø¯ÙŠØ¯
-Neue Bankverbindung erstellen
-Create New EFT Account
-Crear una nueva cuenta EFT
-Enregistrer un nouveau compte de virement
Ã©lectronique
-à¤¨à¤¯à¤¾  à¤ˆà¤ à¤«à¤¼à¤Ÿà¥€(EFT)
à¤–à¤¾à¤¤à¤¾ à¤¬à¤¨à¤¾à¤ à¤ 
-Creare Nuovo Conto EFT
-æ–°è¦ é›»å å
–å¼•(EFT)ã‚¢ã‚«ã‚¦ãƒ³ãƒˆã‚’ä½œæˆ 
-Nieuwe bankrekening aanmaken
-Criar Nova Conta EFT
-Criar Nova Conta EFT
-Creaza un Cont nou EFT
-Ð¡Ð¾Ð·Ð´Ð°Ñ‚ÑŒ Ð½Ð¾Ð²Ñ‹Ð¹ Ð±Ð°Ð½ÐºÐ¾Ð²Ñ
ÐºÐ¸Ð¹ Ñ Ñ‡ÐµÑ‚
-à¸ªà¸£à¹‰à¸²à¸‡à¸šà¸±à¸
à¸Šà¸µà¸˜à¸™à¸²à¸„à¸²à¸£à¹ƒà¸«à¸¡à¹ˆ
-Táº¡o má»›i tÃ i khoáº£n EFT
-åˆ›å»ºæ–°ç”µå èµ„é‡‘è½¬è´¦
-æ–°å»ºæ–°é›»å è³‡é‡‘è½‰å¸³
-
  
  Ø®Ù„Ù‚ ØØ³Ø§Ø¨ Ù…Ø§Ù„ÙŠ Ø¬Ø¯ÙŠØ¯
  Neues Finanzkonto erstellen
@@ -3679,24 +3653,6 @@
  æ–°å»ºè´¢åŠ¡è´¦ç›®å¯¹è´¦
  æ–°å»ºè²¡å‹™å¸³ç›®å° å¸³
  
-
-Ø®Ù„Ù‚ Ø¨Ø·Ø§Ù‚Ø© Ù‡Ø¯ÙŠØ© Ø¬Ø¯ÙŠØ¯Ø©
-Neuen Gutschein erstellen
-Create New Gift Card
-

Re: svn commit: r1752972 - in /ofbiz/trunk/applications: accounting/config/AccountingUiLabels.xml order/template/return/QuickReturn.ftl party/template/party/EditGiftCard.ftl party/template/party/profi

2016-07-18 Thread Michael Brohl


HI Vikas,

the comments in Jira https://issues.apache.org/jira/browse/OFBIZ-7707 
say that these labels are obsolete, have you checked this?


Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 18.07.16 um 20:24 schrieb Vikas Mayur:

Just for a cosmetic and trivial (JIRA issue indicates that) change loosing
the translation to 15 odd languages, is it desirable? It might be years
effort to have the label defined in those languages.


Regards
Vikas

On Sat, Jul 16, 2016 at 9:22 AM,  wrote:


Author: pranayp
Date: Sat Jul 16 14:22:18 2016
New Revision: 1752972

URL: http://svn.apache.org/viewvc?rev=1752972=rev
Log:
[OFBIZ-7707] Improved payment method information UI on party profile
screen for creating new payment methods. Thanks Chandan Khandelwal for the
contribution.

Modified:
 ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
 ofbiz/trunk/applications/order/template/return/QuickReturn.ftl
 ofbiz/trunk/applications/party/template/party/EditGiftCard.ftl

ofbiz/trunk/applications/party/template/party/profileblocks/PaymentMethods.ftl

Modified: ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml?rev=1752972=1752971=1752972=diff

==
--- ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
(original)
+++ ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml Sat
Jul 16 14:22:18 2016
@@ -3555,6 +3555,18 @@
  æ–°å»ºæˆ æœ¬ç»„ä»¶è®¡ç®—
  æ–°å»ºæˆ æœ¬å…ƒä»¶è¨ˆç®—
  
+
+Create Credit Card
+à¤•à¥ à¤°à¥‡à¤¡à¤¿à¤Ÿ à¤•à¤¾à¤°à¥ à¤¡
à¤¬à¤¨à¤¾à¤ à¤ 
+
+
+Create EFT Account
+à¤ˆà¤ à¤«à¤¼à¤Ÿà¥€(EFT) à¤–à¤¾à¤¤à¤¾
à¤¬à¤¨à¤¾à¤ à¤ 
+
+
+Create Gift Card
+à¤‰à¤ªà¤¹à¤¾à¤° à¤•à¤¾à¤°à¥ à¤¡
à¤¬à¤¨à¤¾à¤ à¤ 
+
  
  Berechtigungsfehler: Um
'createFixedAssetMaintOrder' auszufÃ¼hren muss man ACCOUNTING_CREATEUPDATE
or ACCOUNTING_ADMIN Berechtigungen haben
  Security Error: to run
createFixedAssetMaintOrder you must have the ACCOUNTING_CREATEUPDATE or
ACCOUNTING_ADMIN permission, or the limited ACCOUNTING_ROLE_CREATE
permission
@@ -3570,25 +3582,6 @@
  å®‰å…¨é”™è¯¯ï¼šè¦ è¿
è¡Œæ–°å»ºå›ºå®šèµ„äº§ç»´ä¿®ä¿ å…»è®¢å
•(createFixedAssetMaintOrder)ï¼Œä½ 
å¿…é¡»æœ‰ACCOUNTING_CREATEUPDATEæˆ–ACCOUNTING_ADMINæ
ƒé™ ï¼Œæˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ ƒé™ 
  å®‰å…¨éŒ¯èª¤:è¦
åŸ·è¡Œæ–°å»ºå›ºå®šè³‡ç”¢ç¶ä¿®ä¿
é¤Šè¨‚å–®(createFixedAssetMaintOrder),ä½ å¿…é 
ˆæœ‰ACCOUNTING_CREATEUPDATEæˆ–ACCOUNTING_ADMINæ¬Šé™
,æˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ¬Šé™ 
  
-
-Ø®Ù„Ù‚ Ø¨Ø·Ø§Ù‚Ø© Ø§Ø¦ØªÙ…Ø§Ù†
Ø¬Ø¯ÙŠØ¯Ø©
-Neue Kreditkarte erstellen
-Create New Credit Card
-Crear nueva tarjeta de crÃ©dito
-Enregistrer une nouvelle carte de
crÃ©dit
-à¤¨à¤¯à¤¾ à¤•à¥ à¤°à¥‡à¤¡à¤¿à¤Ÿ
à¤•à¤¾à¤°à¥ à¤¡ à¤¬à¤¨à¤¾à¤ à¤ 
-Creare Nuova Carta Credito
-æ–°è¦ ã‚¯ãƒ¬ã‚¸ãƒƒãƒˆã‚«ãƒ¼ãƒ‰ã‚’ä½œæˆ

-Nieuwe kredietkaart aanmaken
-Criar Novo CartÃ£o de CrÃ©dito
-Criar Novo CartÃ£o de CrÃ©dito
-Creaza Noua Carte de Credit
-Ð¡Ð¾Ð·Ð´Ð°Ñ‚ÑŒ Ð½Ð¾Ð²ÑƒÑŽ ÐºÑ€ÐµÐ´Ð¸Ñ‚Ð½ÑƒÑŽ
ÐºÐ°Ñ€Ñ‚Ñƒ
-à¸ªà¸£à¹‰à¸²à¸‡à¸šà¸±à¸•à¸£à¹€à¸„à¸£à¸”à¸´à¸•à¹ƒà¸«à¸¡à¹ˆ
-ThÃªm má»›i Tháº» tÃn dá»¥ng
-åˆ›å»ºæ–°ä¿¡ç”¨å ¡
-æ–°å»ºæ–°ä¿¡ç”¨å ¡
-
  
  Ø®Ù„Ù‚ Ø¯Ù Ø¹Ø© Ø§ÙŠØ¯Ø§Ø¹ Ø¬Ø¯ÙŠØ¯Ø©
  Neue Einzahlung
@@ -3637,25 +3630,6 @@
  ä¸ºè´¢åŠ¡è´¦æˆ·æ–°å»ºå˜æ¬¾å
•ï¼š${finAccount.finAccountName} [${finAccountId}]
  ç‚ºè²¡å‹™å¸³æˆ¶æ–°å»ºå˜æ¬¾å–®:${finAccount.finAccountName}
[${finAccountId}]
  
-
-Ø®Ù„Ù‚ ØØ³Ø§Ø¨ EFT Ø¬Ø¯ÙŠØ¯
-Neue Bankverbindung erstellen
-Create New EFT Account
-Crear una nueva cuenta EFT
-Enregistrer un nouveau compte de virement
Ã©lectronique
-à¤¨à¤¯à¤¾  à¤ˆà¤ à¤«à¤¼à¤Ÿà¥€(EFT)
à¤–à¤¾à¤¤à¤¾ à¤¬à¤¨à¤¾à¤ à¤ 
-Creare Nuovo Conto EFT
-æ–°è¦ é›»å å
–å¼•(EFT)ã‚¢ã‚«ã‚¦ãƒ³ãƒˆã‚’ä½œæˆ 
-Nieuwe bankrekening aanmaken
-Criar Nova Conta EFT
-Criar Nova Conta EFT
-Creaza un Cont nou EFT
-Ð¡Ð¾Ð·Ð´Ð°Ñ‚ÑŒ Ð½Ð¾Ð²Ñ‹Ð¹ Ð±Ð°Ð½ÐºÐ¾Ð²Ñ
ÐºÐ¸Ð¹ Ñ Ñ‡ÐµÑ‚
-à¸ªà¸£à¹‰à¸²à¸‡à¸šà¸±à¸
à¸Šà¸µà¸˜à¸™à¸²à¸„à¸²à¸£à¹ƒà¸«à¸¡à¹ˆ
-Táº¡o má»›i tÃ i khoáº£n EFT
-åˆ›å»ºæ–°ç”µå èµ„é‡‘è½¬è´¦
-æ–°å»ºæ–°é›»å è³‡é‡‘è½‰å¸³
-
  
  Ø®Ù„Ù‚ ØØ³Ø§Ø¨ Ù…Ø§Ù„ÙŠ Ø¬Ø¯ÙŠØ¯
  Neues Finanzkonto erstellen
@@ -3679,24 +3653,6 @@
  æ–°å»ºè´¢åŠ¡è´¦ç›®å¯¹è´¦
  æ–°å»ºè²¡å‹™å¸³ç›®å° å¸³
  
-
-Ø®Ù„Ù‚ Ø¨Ø·Ø§Ù‚Ø© Ù‡Ø¯ÙŠØ© Ø¬Ø¯ÙŠØ¯Ø©
-Neuen Gutschein erstellen
-Create New Gift Card
-Crear nuevo certificado de regalo
-CrÃ©er une nouvelle carte cadeau
-à¤¨à¤¯à¤¾  à¤‰à¤ªà¤¹à¤¾à¤°

Re: svn commit: r1752972 - in /ofbiz/trunk/applications: accounting/config/AccountingUiLabels.xml order/template/return/QuickReturn.ftl party/template/party/EditGiftCard.ftl party/template/party/profi

2016-07-18 Thread Vikas Mayur

Just for a cosmetic and trivial (JIRA issue indicates that) change loosing
the translation to 15 odd languages, is it desirable? It might be years
effort to have the label defined in those languages.


Regards
Vikas

On Sat, Jul 16, 2016 at 9:22 AM,  wrote:

> Author: pranayp
> Date: Sat Jul 16 14:22:18 2016
> New Revision: 1752972
>
> URL: http://svn.apache.org/viewvc?rev=1752972=rev
> Log:
> [OFBIZ-7707] Improved payment method information UI on party profile
> screen for creating new payment methods. Thanks Chandan Khandelwal for the
> contribution.
>
> Modified:
> ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> ofbiz/trunk/applications/order/template/return/QuickReturn.ftl
> ofbiz/trunk/applications/party/template/party/EditGiftCard.ftl
>
> ofbiz/trunk/applications/party/template/party/profileblocks/PaymentMethods.ftl
>
> Modified: ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml?rev=1752972=1752971=1752972=diff
>
> ==
> --- ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> (original)
> +++ ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml Sat
> Jul 16 14:22:18 2016
> @@ -3555,6 +3555,18 @@
>  æ–°å»ºæˆ æœ¬ç»„ä»¶è®¡ç®—
>  æ–°å»ºæˆ æœ¬å…ƒä»¶è¨ˆç®—
>  
> +
> +Create Credit Card
> +à¤•à¥ à¤°à¥‡à¤¡à¤¿à¤Ÿ à¤•à¤¾à¤°à¥ à¤¡
> à¤¬à¤¨à¤¾à¤ à¤ 
> +
> +
> +Create EFT Account
> +à¤ˆà¤ à¤«à¤¼à¤Ÿà¥€(EFT) à¤–à¤¾à¤¤à¤¾
> à¤¬à¤¨à¤¾à¤ à¤ 
> +
> +
> +Create Gift Card
> +à¤‰à¤ªà¤¹à¤¾à¤° à¤•à¤¾à¤°à¥ à¤¡
> à¤¬à¤¨à¤¾à¤ à¤ 
> +
>  
>  Berechtigungsfehler: Um
> 'createFixedAssetMaintOrder' auszufÃ¼hren muss man ACCOUNTING_CREATEUPDATE
> or ACCOUNTING_ADMIN Berechtigungen haben
>  Security Error: to run
> createFixedAssetMaintOrder you must have the ACCOUNTING_CREATEUPDATE or
> ACCOUNTING_ADMIN permission, or the limited ACCOUNTING_ROLE_CREATE
> permission
> @@ -3570,25 +3582,6 @@
>  å®‰å…¨é”™è¯¯ï¼šè¦ è¿
> è¡Œæ–°å»ºå›ºå®šèµ„äº§ç»´ä¿®ä¿ å…»è®¢å
> •(createFixedAssetMaintOrder)ï¼Œä½ 
> å¿…é¡»æœ‰ACCOUNTING_CREATEUPDATEæˆ–ACCOUNTING_ADMINæ
> ƒé™ ï¼Œæˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ ƒé™ 
>  å®‰å…¨éŒ¯èª¤:è¦
> åŸ·è¡Œæ–°å»ºå›ºå®šè³‡ç”¢ç¶ä¿®ä¿
> é¤Šè¨‚å–®(createFixedAssetMaintOrder),ä½ å¿…é 
> ˆæœ‰ACCOUNTING_CREATEUPDATEæˆ–ACCOUNTING_ADMINæ¬Šé™
> ,æˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ¬Šé™ 
>  
> -
> -Ø®Ù„Ù‚ Ø¨Ø·Ø§Ù‚Ø© Ø§Ø¦ØªÙ…Ø§Ù†
> Ø¬Ø¯ÙŠØ¯Ø©
> -Neue Kreditkarte erstellen
> -Create New Credit Card
> -Crear nueva tarjeta de crÃ©dito
> -Enregistrer une nouvelle carte de
> crÃ©dit
> -à¤¨à¤¯à¤¾ à¤•à¥ à¤°à¥‡à¤¡à¤¿à¤Ÿ
> à¤•à¤¾à¤°à¥ à¤¡ à¤¬à¤¨à¤¾à¤ à¤ 
> -Creare Nuova Carta Credito
> -æ–°è¦ ã‚¯ãƒ¬ã‚¸ãƒƒãƒˆã‚«ãƒ¼ãƒ‰ã‚’ä½œæˆ
> 
> -Nieuwe kredietkaart aanmaken
> -Criar Novo CartÃ£o de CrÃ©dito
> -Criar Novo CartÃ£o de CrÃ©dito
> -Creaza Noua Carte de Credit
> -Ð¡Ð¾Ð·Ð´Ð°Ñ‚ÑŒ Ð½Ð¾Ð²ÑƒÑŽ ÐºÑ€ÐµÐ´Ð¸Ñ‚Ð½ÑƒÑŽ
> ÐºÐ°Ñ€Ñ‚Ñƒ
> - xml:lang="th">à¸ªà¸£à¹‰à¸²à¸‡à¸šà¸±à¸•à¸£à¹€à¸„à¸£à¸”à¸´à¸•à¹ƒà¸«à¸¡à¹ˆ
> -ThÃªm má»›i Tháº» tÃn dá»¥ng
> -åˆ›å»ºæ–°ä¿¡ç”¨å ¡
> -æ–°å»ºæ–°ä¿¡ç”¨å ¡
> -
>  
>  Ø®Ù„Ù‚ Ø¯Ù Ø¹Ø© Ø§ÙŠØ¯Ø§Ø¹ Ø¬Ø¯ÙŠØ¯Ø©
>  Neue Einzahlung
> @@ -3637,25 +3630,6 @@
>  ä¸ºè´¢åŠ¡è´¦æˆ·æ–°å»ºå˜æ¬¾å
> •ï¼š${finAccount.finAccountName} [${finAccountId}]
>   xml:lang="zh-TW">ç‚ºè²¡å‹™å¸³æˆ¶æ–°å»ºå˜æ¬¾å–®:${finAccount.finAccountName}
> [${finAccountId}]
>  
> -
> -Ø®Ù„Ù‚ ØØ³Ø§Ø¨ EFT Ø¬Ø¯ÙŠØ¯
> -Neue Bankverbindung erstellen
> -Create New EFT Account
> -Crear una nueva cuenta EFT
> -Enregistrer un nouveau compte de virement
> Ã©lectronique
> -à¤¨à¤¯à¤¾  à¤ˆà¤ à¤«à¤¼à¤Ÿà¥€(EFT)
> à¤–à¤¾à¤¤à¤¾ à¤¬à¤¨à¤¾à¤ à¤ 
> -Creare Nuovo Conto EFT
> -æ–°è¦ é›»å å
> –å¼•(EFT)ã‚¢ã‚«ã‚¦ãƒ³ãƒˆã‚’ä½œæˆ 
> -Nieuwe bankrekening aanmaken
> -Criar Nova Conta EFT
> -Criar Nova Conta EFT
> -Creaza un Cont nou EFT
> -Ð¡Ð¾Ð·Ð´Ð°Ñ‚ÑŒ Ð½Ð¾Ð²Ñ‹Ð¹ Ð±Ð°Ð½ÐºÐ¾Ð²Ñ
> ÐºÐ¸Ð¹ Ñ Ñ‡ÐµÑ‚
> -à¸ªà¸£à¹‰à¸²à¸‡à¸šà¸±à¸
> à¸Šà¸µà¸˜à¸™à¸²à¸„à¸²à¸£à¹ƒà¸«à¸¡à¹ˆ
> -Táº¡o má»›i tÃ i khoáº£n EFT
> -åˆ›å»ºæ–°ç”µå èµ„é‡‘è½¬è´¦
> -æ–°å»ºæ–°é›»å è³‡é‡‘è½‰å¸³
> -
>  
>  Ø®Ù„Ù‚ ØØ³Ø§Ø¨ Ù…Ø§Ù„ÙŠ Ø¬Ø¯ÙŠØ¯
>  Neues Finanzkonto erstellen
> @@ -3679,24 +3653,6 @@
>  æ–°å»ºè´¢åŠ¡è´¦ç›®å¯¹è´¦
>  æ–°å»ºè²¡å‹™å¸³ç›®å° å¸³
>  
> -
> -Ø®Ù„Ù‚ Ø¨Ø·Ø§Ù‚Ø© Ù‡Ø¯ÙŠØ© Ø¬Ø¯ÙŠØ¯Ø©
> -Neuen Gutschein erstellen
> -Create New Gift Card
> -Crear nuevo certificado de regalo
> -CrÃ©er une nouvelle carte cadeau
> -

[jira] [Commented] (OFBIZ-7897) Introduce unit tests to the start component

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382735#comment-15382735
 ] 

Taher Alkhateeb commented on OFBIZ-7897:


Also a small comment, a very nice test report is generated for the unit tests 
in /build/reports/tests/index.html similar to the test report for integration 
tests in runtime/logs.

> Introduce unit tests to the start component
> ---
>
> Key: OFBIZ-7897
> URL: https://issues.apache.org/jira/browse/OFBIZ-7897
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: start
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>  Labels: start, unit-test
> Fix For: Upcoming Branch
>
>
> Introduce unit tests to the Start component utilizing the unit tests 
> framework introduced by Gradle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7254) provide a new unit testing framework for OFBiz

2016-07-18 Thread Taher Alkhateeb (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taher Alkhateeb closed OFBIZ-7254.
--
Resolution: Fixed

Already 8 unit tests are introduced to the framework and working properly in 
OFBIZ-7897. Thus we can consider this JIRA done

> provide a new unit testing framework for OFBiz
> --
>
> Key: OFBIZ-7254
> URL: https://issues.apache.org/jira/browse/OFBIZ-7254
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>
> The objective of this JIRA is to create a unit testing framework for OFBiz in 
> addition to the existing testing framework which is used for integration 
> tests.
> This objective will be achieved using the following steps:
> - Create a master suite to hold all other suites and unit tests
> - Modify build.xml to incorporate unit tests and integration tests in 
> separate tasks
> - design at least a few test scripts to showcase usage
> This JIRA has reference to the discussion on the below mail thread 
> http://ofbiz.markmail.org/message/3cebkshhgyzds4e5
> https://lists.apache.org/thread.html/0a5e3a02505061ac2d55f75dfb88714b5ab543c39bbadb9aa3e2d2b3@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7899) createDataResource will sometimes fail when uploading Excel documents due to missing libraries

2016-07-18 Thread Forrest Rae (JIRA)

Forrest Rae created OFBIZ-7899:
--

 Summary: createDataResource will sometimes fail when uploading 
Excel documents due to missing libraries
 Key: OFBIZ-7899
 URL: https://issues.apache.org/jira/browse/OFBIZ-7899
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: Release Branch 15.12, Trunk
Reporter: Forrest Rae


createDataResource calls 
org.ofbiz.content.data.DataResourceWorker.getMimeTypeWithByteBuffer().  
getMimeTypeWithByteBuffer calls into the Tika library to detect the mime type 
of the file.  Tika will try to detect the file format, leveraging a number of 
detectors, one of which is Apache POI.  Apache POI's detector will try to call 
routines in jar files that are not included in with the content application, 
leading to the following exception:

java.lang.IllegalAccessError: tried to access method 
org.apache.poi.util.POILogger.log(ILjava/lang/Object;)V from class 
org.apache.poi.openxml4j.opc.PackageRelationshipCollection

The missing jar files can be found here:
https://archive.apache.org/dist/poi/release/bin/poi-bin-3.13-20150929.zip

The missing jars are:
poi-ooxml
poi-ooxml-schemas

Might be good to update to the latest version of POI as well:
http://poi.apache.org/download.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382667#comment-15382667
 ] 

Taher Alkhateeb edited comment on OFBIZ-1463 at 7/18/16 5:33 PM:
-

Hello everyone, I've introduced unit tests to the start component in OFBIZ-7897 
which helped me actually detect some minor errors in the code. If you wish you 
can use these tests as a reference of how to introduce unit tests utilizing 
gradle. These tests automatically run every time you call build, test, or run 
any of the server commands (upon any code change). If no change in the code is 
detected then the tests are cached and not run again (just like ant or any 
other build system)


was (Author: taher):
Hello everyone, I've introduced unit tests to the start component in OFBIZ-7898 
which helped me actually detect some minor errors in the code. If you wish you 
can use these tests as a reference of how to introduce unit tests utilizing 
gradle. These tests automatically run every time you call build, test, or run 
any of the server commands (upon any code change). If no change in the code is 
detected then the tests are cached and not run again (just like ant or any 
other build system)

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382667#comment-15382667
 ] 

Taher Alkhateeb commented on OFBIZ-1463:


Hello everyone, I've introduced unit tests to the start component which helped 
me actually detect some minor errors in the code. If you wish you can use these 
tests as a reference of how to introduce unit tests utilizing gradle. These 
tests automatically run every time you call build, test, or run any of the 
server commands (upon any code change). If no change in the code is detected 
then the tests are cached and not run again (just like ant or any other build 
system)

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382667#comment-15382667
 ] 

Taher Alkhateeb edited comment on OFBIZ-1463 at 7/18/16 5:33 PM:
-

Hello everyone, I've introduced unit tests to the start component in OFBIZ-7898 
which helped me actually detect some minor errors in the code. If you wish you 
can use these tests as a reference of how to introduce unit tests utilizing 
gradle. These tests automatically run every time you call build, test, or run 
any of the server commands (upon any code change). If no change in the code is 
detected then the tests are cached and not run again (just like ant or any 
other build system)


was (Author: taher):
Hello everyone, I've introduced unit tests to the start component which helped 
me actually detect some minor errors in the code. If you wish you can use these 
tests as a reference of how to introduce unit tests utilizing gradle. These 
tests automatically run every time you call build, test, or run any of the 
server commands (upon any code change). If no change in the code is detected 
then the tests are cached and not run again (just like ant or any other build 
system)

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7897) Introduce unit tests to the start component

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382663#comment-15382663
 ] 

Taher Alkhateeb commented on OFBIZ-7897:


Committed the first batch of unit tests (8 tests) in r1753274 into a new file 
called OfbizStartupUnitTests.java and fixed minor issues in the code that were 
detected thanks to these tests.

> Introduce unit tests to the start component
> ---
>
> Key: OFBIZ-7897
> URL: https://issues.apache.org/jira/browse/OFBIZ-7897
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: start
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>  Labels: start, unit-test
> Fix For: Upcoming Branch
>
>
> Introduce unit tests to the Start component utilizing the unit tests 
> framework introduced by Gradle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7365) fonts.pdf Throw error on terminal

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382648#comment-15382648
 ] 

Jacques Le Roux commented on OFBIZ-7365:


Hi Vaibhav, can you still reproduce locally? Because before opening a Jira 
issue I created this dev ML thread http://markmail.org/message/kgsnhep5zlbljec5

> fonts.pdf Throw error on terminal
> -
>
> Key: OFBIZ-7365
> URL: https://issues.apache.org/jira/browse/OFBIZ-7365
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/example
>Reporter: Vaibhav Jain
>Assignee: Vaibhav Jain
>
> Steps to regenerate the issue:
> 1. Go to "EXAMPLE"  component.
> 2. Click on sub-menu "FOP fonts in a PDF"
> _
> Direct link
> https://localhost:8443/example/control/fonts.pdf
> _
> {code}
>   [java] 2016-06-13 19:25:34,639 |ttp-nio-8443-exec-10 |ScreenFopViewHandler  
> |E| Unable to write to OutputStream: 
> org.apache.catalina.connector.ClientAbortException: java.io.IOException: 
> Broken pipe; Screen XSL:FO text was:
> [java] 
> [java] 2016-06-13 19:25:35,084 |ttp-nio-8443-exec-10 |ScreenFopViewHandler
>   |E| Multiple errors rendering FOP
> [java] 2016-06-13 19:25:35,085 |ttp-nio-8443-exec-10 |ControlServlet  
>   |E| Error in request handler: 
> [java] java.lang.IllegalStateException: getOutputStream() has already 
> been called for this response
> [java] at 
> org.apache.catalina.connector.Response.getWriter(Response.java:564) 
> ~[tomcat-8.0.33-catalina.jar:8.0.33]
> [java] at 
> org.apache.catalina.connector.ResponseFacade.getWriter(ResponseFacade.java:212)
>  ~[tomcat-8.0.33-catalina.jar:8.0.33]
> [java] at 
> org.ofbiz.widget.renderer.fo.ScreenFopViewHandler.renderError(ScreenFopViewHandler.java:191)
>  ~[ofbiz-widget.jar:?]
> [java] at 
> org.ofbiz.widget.renderer.fo.ScreenFopViewHandler.render(ScreenFopViewHandler.java:174)
>  ~[ofbiz-widget.jar:?]
> [java] at 
> org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1001) 
> ~[ofbiz-webapp.jar:?]
> [java] at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:653) 
> ~[ofbiz-webapp.jar:?]
> [java] at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
> [java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) 
> [servlet-api-3.1.jar:?]
> [java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) 
> [servlet-api-3.1.jar:?]
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7898) Create a (short term) Gradle "cleanAnt" task to remove old build dirs

2016-07-18 Thread Jacques Le Roux (JIRA)

Jacques Le Roux created OFBIZ-7898:
--

 Summary: Create a (short term) Gradle "cleanAnt" task to remove 
old build dirs
 Key: OFBIZ-7898
 URL: https://issues.apache.org/jira/browse/OFBIZ-7898
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Minor


The idea is to adapt the "old" Ant "clean*" targets in order to allow to remove 
old build dirs. It's not a problem if you have done an Ant clean just before 
removing Ant whith a "svn up" but I guess most of us did not.

We will then also remove the related svn:ignore (build dirs)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7897) Introduce unit tests to the start component

2016-07-18 Thread Taher Alkhateeb (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taher Alkhateeb updated OFBIZ-7897:
---
Summary: Introduce unit tests to the start component  (was: Introduce unit 
tests to the startup component)

> Introduce unit tests to the start component
> ---
>
> Key: OFBIZ-7897
> URL: https://issues.apache.org/jira/browse/OFBIZ-7897
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: start
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>  Labels: start, unit-test
> Fix For: Upcoming Branch
>
>
> Introduce unit tests to the Start component utilizing the unit tests 
> framework introduced by Gradle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7897) Introduce unit tests to the startup component

2016-07-18 Thread Taher Alkhateeb (JIRA)

Taher Alkhateeb created OFBIZ-7897:
--

 Summary: Introduce unit tests to the startup component
 Key: OFBIZ-7897
 URL: https://issues.apache.org/jira/browse/OFBIZ-7897
 Project: OFBiz
  Issue Type: Sub-task
  Components: start
Reporter: Taher Alkhateeb
Assignee: Taher Alkhateeb
Priority: Minor
 Fix For: Upcoming Branch


Introduce unit tests to the Start component utilizing the unit tests framework 
introduced by Gradle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7815) OFBiz secured background process does not work on Windows

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7815:
---
Issue Type: Sub-task  (was: Bug)
Parent: OFBIZ-7534

> OFBiz secured background process does not work on Windows
> -
>
> Key: OFBIZ-7815
> URL: https://issues.apache.org/jira/browse/OFBIZ-7815
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Jacques Le Roux
>Priority: Minor
>
> bq. gradlew ofbiz 
> works but not
> bq. gradlew --stacktrace "ofbizBackgroundSecure --start"
> I get this (French sorry)
> {code}
> C:\projectASF-Mars\ofbiz>gradlew --stacktrace "ofbizBackgroundSecure --start"
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> :ofbizBackgroundSecure --start FAILED
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectASF-Mars\ofbiz\build.gradle' line: 785
> * What went wrong:
> Execution failed for task ':ofbizBackgroundSecure --start'.
> > Cannot run program "gradlew" (in directory "C:\projectASF-Mars\ofbiz"): 
> > CreateProcess error=2, Le fichier sp├®cifi├® est introuvable
> * Try:
> Run with --info or --debug option to get more log output.
> * Exception is:
> org.gradle.api.tasks.TaskExecutionException: Execution failed for task 
> ':ofbizBackgroundSecure --start'.
> at 
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
> at 
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
> at 
> org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
> at 
> org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:68)
> at 
> org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
> at 
> org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:52)
> at 
> org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
> at 
> org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:53)
> at 
> org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
> at 
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:203)
> at 
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:185)
> at 
> org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:66)
> at 
> org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:50)
> at 
> org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:25)
> at 
> org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:110)
> at 
> org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)
> at 
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
> at 
> org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)
> at 
> org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)
> at 
> org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)
> at 
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
> at 
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)
> at 
> org.gradle.initialization.DefaultGradleLauncher$4.run(DefaultGradleLauncher.java:154)
> at org.gradle.internal.Factories$1.create(Factories.java:22)
> at 
> org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
> at 
> org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:52)
> at 
> org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:151)
> at 
> org.gradle.initialization.DefaultGradleLauncher.access$200(DefaultGradleLauncher.java:32)
> at 
> org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:99)
> at 
> org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:93)
> at 
>

Temporary change for filling the "Fix Versions/s" field in Jira

2016-07-18 Thread Jacques Le Roux


Hi Committer, Devs, All,

You might have noticed I Temporary changed our policy about filling the "Fix 
Versions/s" field in Jira

Please read 
https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=7766050=46=45

Thanks

Jacques

[jira] [Comment Edited] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382301#comment-15382301
 ] 

Pierre Smits edited comment on OFBIZ-1463 at 7/18/16 1:56 PM:
--

We all know trunk can be a volatile branch and things can get broken from time 
to time, but that doesn't mean that is should be used as a testbed for some 
piece of 3rd party software the community has no experience with.

That being said, why don't you do a Proof of Concept first in your own dev 
environment and share results with the community? So that it can look for 
follow-up actions.


was (Author: pfm.smits):
We all know trunk can be a volatile branch and things can get broken from time 
to time, but that doesn't mean that is should be used as a testbed for some 
piece of 3rd party software the community has no experience with.

That being said, why don't you do a Proof of Concept first and share results 
with the community, so that it can look for follow-up actions.

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382301#comment-15382301
 ] 

Pierre Smits commented on OFBIZ-1463:
-

We all know trunk can be a volatile branch and things can get broken from time 
to time, but that doesn't mean that is should be used as a testbed for some 
piece of 3rd party software the community has no experience with.

That being said, why don't you do a Proof of Concept first and share results 
with the community, so that it can look for follow-up actions.

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7895) ebay : Remove unused imports from groovy files.

2016-07-18 Thread Ankit Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-7895:
---
Attachment: OFBIZ-7895-trunk.patch

Attached the patch to remove unused imports for code optimization purpose.

> ebay : Remove unused imports from groovy files.
> ---
>
> Key: OFBIZ-7895
> URL: https://issues.apache.org/jira/browse/OFBIZ-7895
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ebay
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Assignee: Ankit Joshi
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7895-trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7895) ebay : Remove unused imports from groovy files.

2016-07-18 Thread Ankit Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-7895:
---
Assignee: (was: Ankit Joshi)

> ebay : Remove unused imports from groovy files.
> ---
>
> Key: OFBIZ-7895
> URL: https://issues.apache.org/jira/browse/OFBIZ-7895
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/ebay
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7895-trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7896) Order: Remove inline js for toggleAll, checkToggle and selectAll calling from ftls.

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)

Amardeep Singh Jhajj created OFBIZ-7896:
---

 Summary: Order: Remove inline js for toggleAll, checkToggle and 
selectAll calling from ftls.
 Key: OFBIZ-7896
 URL: https://issues.apache.org/jira/browse/OFBIZ-7896
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Trunk
Reporter: Amardeep Singh Jhajj
Assignee: Amardeep Singh Jhajj


Remove inline js for toggleAll, checkToggle and selectAll calling from ftls in 
Order component. Add class="selectAll" on parent checkbox element for select 
all functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7895) ebay : Remove unused imports from groovy files.

2016-07-18 Thread Ankit Joshi (JIRA)

Ankit Joshi created OFBIZ-7895:
--

 Summary: ebay : Remove unused imports from groovy files.
 Key: OFBIZ-7895
 URL: https://issues.apache.org/jira/browse/OFBIZ-7895
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ebay
Affects Versions: Trunk
Reporter: Ankit Joshi
Assignee: Ankit Joshi
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7720) Write one generic functionality for select all checkbox by removing currently written multiple fuctionality

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amardeep Singh Jhajj updated OFBIZ-7720:

Attachment: OFBIZ-7720.patch

> Write one generic functionality for select all checkbox by removing currently 
> written multiple fuctionality
> ---
>
> Key: OFBIZ-7720
> URL: https://issues.apache.org/jira/browse/OFBIZ-7720
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7720.patch
>
>
> We have many occurrence of selectAll, toggleAll abd checkToggle function 
> calling in ftls. Example: 
> {code}
> // For selecting all the child checkboxes
>  onclick="javascript:toggleAll(this, '${selectAllFormName}');"/>
> // For selecting the child checkboxes and parent (if all child boxes is 
> selected)
>  onclick="javascript:checkToggle(this, '${selectAllFormName}');"/>
> // For selecting all the child checkboxes if parent checbox is selected on 
> page load.
>  type="text/javascript">selectAll('selectAllForm');
> {code}
> Above all functionality should be replaced using one generic utility of 
> selectAll. Example:
> {code}
> // One class "selectAll" on parent checkbox will handle all above cases.
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382269#comment-15382269
 ] 

Taher Alkhateeb commented on OFBIZ-1463:


Hm, It is certainly doable with gradle. I think the technology is still 
beta and we are expected to make a release branch soon. Perhaps we can upgrade 
junit after the branch? As far as I know the syntax is very much the same and 
only new features are added such as the ability to use lambda expressions in 
assertions. So I think an upgrade is not difficult.

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7605) Extend use of Apache IVY re external library management for r13x

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7605.
--
Resolution: Not A Problem
  Assignee: Jacques Le Roux  (was: Pierre Smits)

No longer a problem since Ivy will not be used but Gradle

> Extend use of Apache IVY re external library management for r13x
> 
>
> Key: OFBIZ-7605
> URL: https://issues.apache.org/jira/browse/OFBIZ-7605
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Affects Versions: Release Branch 13.07
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: OFBIZ-7605-r13-ivy-v2.patch, OFBIZ-7605-status-v2.txt, 
> OFBIZ-7605-svn-status.txt, ofbiz-7605-r13-ivy.patch
>
>
> This subtask addresses the issues regarding the r13.07 branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-5541) Address '.classpath' issue

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382235#comment-15382235
 ] 

Jacques Le Roux edited comment on OFBIZ-5541 at 7/18/16 1:02 PM:
-

No longer a problem since Ivy will not be used but Gradle


was (Author: jacques.le.roux):
No longer a problem since Ivy will not be used bu Gradle

> Address '.classpath' issue
> --
>
> Key: OFBIZ-5541
> URL: https://issues.apache.org/jira/browse/OFBIZ-5541
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-5464) Extend Ivy usage for easier external lib management

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5464.
--
Resolution: Not A Problem
  Assignee: Jacques Le Roux  (was: Pierre Smits)

No longer a problem since Ivy will not be used but Gradle

> Extend Ivy usage for easier external lib management
> ---
>
> Key: OFBIZ-5464
> URL: https://issues.apache.org/jira/browse/OFBIZ-5464
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS, framework
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: jarfiles.txt
>
>
> *IMPORTANT*:
> *As per http://ofbiz.markmail.org/message/mqkqejm6vck2dmot this issue has 
> been reopened to address ASF Guidelines regarding Dependencies*
> Currently Apache Ivy is used to facilitate downloads of specific external jar 
> files for Activemq, mySQL, postgreSQL configuration and Sonar and Cobertura 
> functions. 
> However, Apache Ivy can also be for easier management of the standard jars 
> OFBiz is dependent on, in
> - various framework areas
> - various base and special purpose applications/components.
> Applying more ivy functionality will decrease the load on commiters regarding 
> maintenance of  (and upgrading) external jars used  and required licence 
> information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7614) Extend use of Apache IVY re external library management for r14x

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7614.
--
Resolution: Not A Problem
  Assignee: Jacques Le Roux

No longer a problem since Ivy will not be used but Gradle

> Extend use of Apache IVY re external library management for r14x
> 
>
> Key: OFBIZ-7614
> URL: https://issues.apache.org/jira/browse/OFBIZ-7614
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Affects Versions: Release Branch 14.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Blocker
>
> This subtask addresses the issues regarding the r14.12 branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7872) Clean up commented out code in Free Marker Template for Content

2016-07-18 Thread Aman Agrawal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Agrawal updated OFBIZ-7872:

Priority: Minor  (was: Major)

> Clean up commented out code in Free Marker Template for Content
> ---
>
> Key: OFBIZ-7872
> URL: https://issues.apache.org/jira/browse/OFBIZ-7872
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Aman Agrawal
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7872_trunk.patch
>
>
> Clean up commented out code in Free Marker Template for Content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7894) Clean up commented out code in Free Marker Template for Manufacturing

2016-07-18 Thread Aman Agrawal (JIRA)

Aman Agrawal created OFBIZ-7894:
---

 Summary: Clean up commented out code in Free Marker Template for 
Manufacturing
 Key: OFBIZ-7894
 URL: https://issues.apache.org/jira/browse/OFBIZ-7894
 Project: OFBiz
  Issue Type: Sub-task
  Components: manufacturing
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Aman Agrawal
Priority: Minor


Clean up commented out code in Free Marker Template for Manufacturing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7615) Extend use of Apache IVY re external library management for r15x

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7615.
--
Resolution: Not A Problem
  Assignee: Jacques Le Roux

No longer a problem since Ivy will not be used but Gradle

> Extend use of Apache IVY re external library management for r15x
> 
>
> Key: OFBIZ-7615
> URL: https://issues.apache.org/jira/browse/OFBIZ-7615
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Affects Versions: Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Blocker
>
> This subtask addresses the issues regarding the r15.12 branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-5465) Address 'LICENCE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382237#comment-15382237
 ] 

Jacques Le Roux edited comment on OFBIZ-5465 at 7/18/16 1:01 PM:
-

No longer a problem since Ivy will not be used but Gradle


was (Author: jacques.le.roux):
No longer a problem since Ivy will not be used bu Gradle

> Address 'LICENCE' doc
> -
>
> Key: OFBIZ-5465
> URL: https://issues.apache.org/jira/browse/OFBIZ-5465
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>
> The licence doc must be reviewed and adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-5466) Address 'NOTICE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382236#comment-15382236
 ] 

Jacques Le Roux edited comment on OFBIZ-5466 at 7/18/16 1:01 PM:
-

No longer a problem since Ivy will not be used but Gradle


was (Author: jacques.le.roux):
No longer a problem since Ivy will not be used bu Gradle

> Address 'NOTICE' doc
> 
>
> Key: OFBIZ-5466
> URL: https://issues.apache.org/jira/browse/OFBIZ-5466
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>
> The 'Notice' doc must be reviewed and adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-5541) Address '.classpath' issue

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382235#comment-15382235
 ] 

Jacques Le Roux edited comment on OFBIZ-5541 at 7/18/16 1:01 PM:
-

No longer a problem since Ivy will not be used bu Gradle


was (Author: jacques.le.roux):
No monger a problem since Ivy will not be used bu Gradle

> Address '.classpath' issue
> --
>
> Key: OFBIZ-5541
> URL: https://issues.apache.org/jira/browse/OFBIZ-5541
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-5466) Address 'NOTICE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5466.
--
Resolution: Not A Problem

No longer a problem since Ivy will not be used bu Gradle

> Address 'NOTICE' doc
> 
>
> Key: OFBIZ-5466
> URL: https://issues.apache.org/jira/browse/OFBIZ-5466
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>
> The 'Notice' doc must be reviewed and adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-5465) Address 'LICENCE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5465.
--
Resolution: Not A Problem

No longer a problem since Ivy will not be used bu Gradle

> Address 'LICENCE' doc
> -
>
> Key: OFBIZ-5465
> URL: https://issues.apache.org/jira/browse/OFBIZ-5465
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>
> The licence doc must be reviewed and adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-5541) Address '.classpath' issue

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5541.
--
Resolution: Not A Problem

No monger a problem since Ivy will not be used bu Gradle

> Address '.classpath' issue
> --
>
> Key: OFBIZ-5541
> URL: https://issues.apache.org/jira/browse/OFBIZ-5541
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS, framework
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7872) Clean up commented out code in Free Marker Template for Content

2016-07-18 Thread Aman Agrawal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Agrawal updated OFBIZ-7872:

Attachment: OFBIZ-7872_trunk.patch

Patch provided.

> Clean up commented out code in Free Marker Template for Content
> ---
>
> Key: OFBIZ-7872
> URL: https://issues.apache.org/jira/browse/OFBIZ-7872
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Aman Agrawal
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7872_trunk.patch
>
>
> Clean up commented out code in Free Marker Template for Content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7752:
---
Fix Version/s: (was: Upcoming Branch)

I finally remove "Upcoming Branch" from the "Fix version/s" field to be 
consistent with what we had before, even if I'm not sure all that makes sense 
until we release R16...

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: Release Branch 14.12, Release Branch 15.12, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: JackRabbit branch

2016-07-18 Thread Michael Brohl


+1, Jacques

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 18.07.16 um 11:17 schrieb Jacques Le Roux:

Hi,

I believe the JackRabbit branch is now completely unmergeable. I 
suggest that we archive it in Jira. It adds only confusion there. Same 
for the the Boostrap theme?


I see no problems keeping all branches even old in the repo, it does 
annoy there.


Thanks

Jacques






smime.p7s
Description: S/MIME Cryptographic Signature

[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.' to org.apache.ofbiz.'

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382163#comment-15382163
 ] 

Jacques Le Roux edited comment on OFBIZ-6274 at 7/18/16 12:05 PM:
--

As a summary: we also changed the log4j2.xml at r1753029+1753168


was (Author: jacques.le.roux):
We also changed the log4j2.xml at r1753029+1753168

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.' to org.apache.ofbiz.'

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382163#comment-15382163
 ] 

Jacques Le Roux commented on OFBIZ-6274:


We also changed the log4j2.xml at r1753029+1753168

> Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
> 
>
> Key: OFBIZ-6274
> URL: https://issues.apache.org/jira/browse/OFBIZ-6274
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
> Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch
>
>
> Currently (a lot of) our java and other artifacts sport the name/reference 
> 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more 
> consistency across the projects under the Apache umbrella.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382151#comment-15382151
 ] 

Jacques Le Roux commented on OFBIZ-7752:


Done

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382149#comment-15382149
 ] 

Jacques Le Roux commented on OFBIZ-7752:


Done

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: JackRabbit branch

2016-07-18 Thread Jacques Le Roux


Done

Jacques


Le 18/07/2016 à 12:09, Pierre Smits a écrit :

Hi Jacques,

If that is the case, I don't see any reason to object.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Jul 18, 2016 at 12:02 PM, Taher Alkhateeb <
slidingfilame...@gmail.com> wrote:


+1

On Mon, Jul 18, 2016 at 1:01 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Nope, simply that we will no longer see the JackRabbit branch when

filling

the Fix Version/s field, which is disturbing, same for Bootstrap

Jacques



Le 18/07/2016 à 11:31, Pierre Smits a écrit :


Your assumption and suggestion applies to many more branches than just

the

2 mentioned, but only 2 were registered in JIRA.

What does that 'archive it in Jira' entail? Will associated issues be
removed from JIRA?

Best regards,


Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Jul 18, 2016 at 11:17 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Hi,

I believe the JackRabbit branch is now completely unmergeable. I

suggest

that we archive it in Jira. It adds only confusion there. Same for the
the
Boostrap theme?

I see no problems keeping all branches even old in the repo, it does
annoy
there.

Thanks

Jacques

[jira] [Updated] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7893:
---
Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-7888

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382038#comment-15382038
 ] 

Jacques Le Roux commented on OFBIZ-7892:


Done thanks for the request Pierre

> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382038#comment-15382038
 ] 

Jacques Le Roux edited comment on OFBIZ-7892 at 7/18/16 10:14 AM:
--

Done at r1753196, thanks for the request Pierre


was (Author: jacques.le.roux):
Done thanks for the request Pierre

> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7892.
--
   Resolution: Done
Fix Version/s: Upcoming Branch

> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: JackRabbit branch

2016-07-18 Thread Pierre Smits

Hi Jacques,

If that is the case, I don't see any reason to object.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Jul 18, 2016 at 12:02 PM, Taher Alkhateeb <
slidingfilame...@gmail.com> wrote:

> +1
>
> On Mon, Jul 18, 2016 at 1:01 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Nope, simply that we will no longer see the JackRabbit branch when
> filling
> > the Fix Version/s field, which is disturbing, same for Bootstrap
> >
> > Jacques
> >
> >
> >
> > Le 18/07/2016 à 11:31, Pierre Smits a écrit :
> >
> >> Your assumption and suggestion applies to many more branches than just
> the
> >> 2 mentioned, but only 2 were registered in JIRA.
> >>
> >> What does that 'archive it in Jira' entail? Will associated issues be
> >> removed from JIRA?
> >>
> >> Best regards,
> >>
> >>
> >> Pierre Smits
> >>
> >> ORRTIZ.COM 
> >> OFBiz based solutions & services
> >>
> >> OFBiz Extensions Marketplace
> >> http://oem.ofbizci.net/oci-2/
> >>
> >> On Mon, Jul 18, 2016 at 11:17 AM, Jacques Le Roux <
> >> jacques.le.r...@les7arts.com> wrote:
> >>
> >> Hi,
> >>>
> >>> I believe the JackRabbit branch is now completely unmergeable. I
> suggest
> >>> that we archive it in Jira. It adds only confusion there. Same for the
> >>> the
> >>> Boostrap theme?
> >>>
> >>> I see no problems keeping all branches even old in the repo, it does
> >>> annoy
> >>> there.
> >>>
> >>> Thanks
> >>>
> >>> Jacques
> >>>
> >>>
> >>>
> >
>

[jira] [Assigned] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-7892:
--

Assignee: Jacques Le Roux

> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382030#comment-15382030
 ] 

Pierre Smits commented on OFBIZ-7893:
-

Thank you for sharing your viewpoint on what the OFBiz community should and/or 
should not do. Feel free to discuss that in the dev ml.


> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: JackRabbit branch

2016-07-18 Thread Jacques Le Roux


Nope, simply that we will no longer see the JackRabbit branch when filling the 
Fix Version/s field, which is disturbing, same for Bootstrap

Jacques


Le 18/07/2016 à 11:31, Pierre Smits a écrit :

Your assumption and suggestion applies to many more branches than just the
2 mentioned, but only 2 were registered in JIRA.

What does that 'archive it in Jira' entail? Will associated issues be
removed from JIRA?

Best regards,


Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Jul 18, 2016 at 11:17 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi,

I believe the JackRabbit branch is now completely unmergeable. I suggest
that we archive it in Jira. It adds only confusion there. Same for the the
Boostrap theme?

I see no problems keeping all branches even old in the repo, it does annoy
there.

Thanks

Jacques

Re: JackRabbit branch

2016-07-18 Thread Taher Alkhateeb

+1

On Mon, Jul 18, 2016 at 1:01 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Nope, simply that we will no longer see the JackRabbit branch when filling
> the Fix Version/s field, which is disturbing, same for Bootstrap
>
> Jacques
>
>
>
> Le 18/07/2016 à 11:31, Pierre Smits a écrit :
>
>> Your assumption and suggestion applies to many more branches than just the
>> 2 mentioned, but only 2 were registered in JIRA.
>>
>> What does that 'archive it in Jira' entail? Will associated issues be
>> removed from JIRA?
>>
>> Best regards,
>>
>>
>> Pierre Smits
>>
>> ORRTIZ.COM 
>> OFBiz based solutions & services
>>
>> OFBiz Extensions Marketplace
>> http://oem.ofbizci.net/oci-2/
>>
>> On Mon, Jul 18, 2016 at 11:17 AM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> Hi,
>>>
>>> I believe the JackRabbit branch is now completely unmergeable. I suggest
>>> that we archive it in Jira. It adds only confusion there. Same for the
>>> the
>>> Boostrap theme?
>>>
>>> I see no problems keeping all branches even old in the repo, it does
>>> annoy
>>> there.
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>>
>

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382023#comment-15382023
 ] 

Pierre Smits commented on OFBIZ-7782:
-

I leave that up to you. Or to any other OFBiz contributor that is also working 
on the Apache Groovy project.

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382023#comment-15382023
 ] 

Pierre Smits edited comment on OFBIZ-7782 at 7/18/16 10:01 AM:
---

I leave that up to you. Or to any other OFBiz contributor who is also working 
on the Apache Groovy project.


was (Author: pfm.smits):
I leave that up to you. Or to any other OFBiz contributor that is also working 
on the Apache Groovy project.

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382022#comment-15382022
 ] 

Taher Alkhateeb commented on OFBIZ-7893:


There are no inconsistencies because everything is automated and works. 
Furthermore, we should not write any howto and other OFBiz documents explaining 
how to override the build system and do things by hand. It violates the 
original purpose of the build system which is to provide ease and comfort for 
the users.

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382021#comment-15382021
 ] 

Jacques Le Roux commented on OFBIZ-7782:


You might rather challenge people here 
https://stackoverflow.com/questions/20464913/does-gradle-use-ivy-internally

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382019#comment-15382019
 ] 

Pierre Smits edited comment on OFBIZ-7893 at 7/18/16 9:56 AM:
--

Thanks for your opinion on the nice to have. But deviations on built time 
(based on what each developer *likes* with respect to his development 
environment):

* creates unnecessary inconsistencies from old to new releases
* complicates writing descriptive howto and other OFBiz documents unnecessarily.


was (Author: pfm.smits):
Thanks for your opinion on the nice to have. But deviations on built time 
(based on what each developer *likes* with respect to his development 
environment:

* creates unnecessary inconsistencies from old to new releases
* complicates writing descriptive howto and other OFBiz documents unnecessarily.

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382019#comment-15382019
 ] 

Pierre Smits commented on OFBIZ-7893:
-

Thanks for your opinion on the nice to have. But deviations on built time 
(based on what each developer *likes* with respect to his development 
environment:

* creates unnecessary inconsistencies from old to new releases
* complicates writing descriptive howto and other OFBiz documents unnecessarily.

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382017#comment-15382017
 ] 

Taher Alkhateeb commented on OFBIZ-7893:


Hi Jacques,

Sure, please go ahead and start a thread.

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382013#comment-15382013
 ] 

Jacques Le Roux commented on OFBIZ-7893:


We should discuss this on dev ML

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382009#comment-15382009
 ] 

Pierre Smits commented on OFBIZ-7893:
-

It must be something that resides somewhere outside the project or is hidden in 
some folder/zip structure.

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382008#comment-15382008
 ] 

Taher Alkhateeb commented on OFBIZ-7893:


This patch breaks the build script because it is dependent on the project name. 
The project name is simply the name of the root folder. So the jar takes the 
name of the folder that the project lives in. So if ofbiz is in 
/home/user/MyOfbiz then the jar would be created in /build/libs/MyOfbiz.jar

If you want to make the name of the project permanent like "ofbiz" then you 
need to set it up accordingly in settings.gradle.

I personally prefer if we keep it the way it is because it is nice to have your 
jar reflecting your directory name for clarity, but I don't mind fixing it if 
users prefer that.

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381997#comment-15381997
 ] 

Pierre Smits commented on OFBIZ-7892:
-

It is now. :)

> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6302) Ftl to Widget: improve ViewCertificate to use widgets instead of ftl

2016-07-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6302.
---

> Ftl to Widget: improve ViewCertificate to use widgets instead of ftl
> 
>
> Key: OFBIZ-6302
> URL: https://issues.apache.org/jira/browse/OFBIZ-6302
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: security
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6302-Certificate.patch, 
> OFBIZ-6302-Certificate.patch
>
>
> Currently the screen ViewCertificate uses a freemarker to render the form(s). 
> This can be replaced by widgets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381992#comment-15381992
 ] 

Pierre Smits edited comment on OFBIZ-7782 at 7/18/16 9:40 AM:
--

Clearly the author of the article was misinformed and did not check thorougly...

This is what 
*./gradlew build --debug* produces:
{code}

11:34:44.684 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.default.settings.dir' to 
'jar:file:/Users/pierre/.gradle/wrapper/dists/gradle-2.13-bin/4xsgxlfjcxvrea7akf941nvc7/gradle-2.13/lib/plugins/ivy-2.2.0.jar!/org/apache/ivy/core/settings'
11:34:44.686 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.basedir' to '/Users/pierre/dev/ofbiz/ofbiz-gradle/.'
11:34:44.686 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.default.conf.dir' to 
'jar:file:/Users/pierre/.gradle/wrapper/dists/gradle-2.13-bin/4xsgxlfjcxvrea7akf941nvc7/gradle-2.13/lib/plugins/ivy-2.2.0.jar!/org/apache/ivy/core/settings'
{code}


was (Author: pfm.smits):
Clearly the author of the article was misinformed and did not check thorougly...

This is what 
*./gradlew build --debug* produces:
{code}

11:34:44.684 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.default.settings.dir' to 
'jar:file:/Users/pierre/.gradle/wrapper/dists/gradle-2.13-bin/4xsgxlfjcxvrea7akf941nvc7/gradle-2.13/lib/plugins/*ivy-2.2.0.jar*!/org/apache/ivy/core/settings'
11:34:44.686 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.basedir' to '/Users/pierre/dev/ofbiz/ofbiz-gradle/.'
11:34:44.686 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.default.conf.dir' to 
'jar:file:/Users/pierre/.gradle/wrapper/dists/gradle-2.13-bin/4xsgxlfjcxvrea7akf941nvc7/gradle-2.13/lib/plugins/*ivy-2.2.0.jar*!/org/apache/ivy/core/settings'
{code}

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381992#comment-15381992
 ] 

Pierre Smits commented on OFBIZ-7782:
-

Clearly the author of the article was misinformed and did not check thorougly...

This is what 
*./gradlew build --debug* produces:
{code}

11:34:44.684 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.default.settings.dir' to 
'jar:file:/Users/pierre/.gradle/wrapper/dists/gradle-2.13-bin/4xsgxlfjcxvrea7akf941nvc7/gradle-2.13/lib/plugins/*ivy-2.2.0.jar*!/org/apache/ivy/core/settings'
11:34:44.686 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.basedir' to '/Users/pierre/dev/ofbiz/ofbiz-gradle/.'
11:34:44.686 [DEBUG] 
[org.gradle.api.internal.artifacts.ivyservice.IvyLoggingAdaper] setting 
'ivy.default.conf.dir' to 
'jar:file:/Users/pierre/.gradle/wrapper/dists/gradle-2.13-bin/4xsgxlfjcxvrea7akf941nvc7/gradle-2.13/lib/plugins/*ivy-2.2.0.jar*!/org/apache/ivy/core/settings'
{code}

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381987#comment-15381987
 ] 

Jacques Le Roux commented on OFBIZ-7893:


AFAIK this has been done already not sure when and by who... It you confirm 
(use trunk HEAD) please close, thanks!

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381988#comment-15381988
 ] 

Deepak Dixit commented on OFBIZ-7892:
-

Hi [~pfm.smits],

OFBIZ-6302 not closed yet, its an resolved status. 

And [~jacques.le.roux] added comment 

>>I don't close to let you check all is allright before closing, thanks!



> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7835) Unable to identify the fields on the edit of product attributes, facilities, payment types, Meters, work effort, parties

2016-07-18 Thread Montalbano Florian (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381982#comment-15381982
 ] 

Montalbano Florian commented on OFBIZ-7835:
---

Hi,
this patch works well !
The title of each columns is now aligned with its column and there is more 
space between the columns, improving the readability.

I found some more forms that could use your improvement :
- ListProductGeos
- UpdateProductPrice (the result is a little weird though)
- UpdateProductGoodIdentifications
- UpdateProductCategoryMember (the result is a little awkward too)
- ListProductGlAccounts

Do you think some of these forms could benefit from your improvement ?
Also, I think that this issue can be set as an "Improvement" instead of a "Bug".

Have a nice day.


> Unable to identify the fields on the edit of product attributes, facilities, 
> payment types, Meters, work effort, parties
> 
>
> Key: OFBIZ-7835
> URL: https://issues.apache.org/jira/browse/OFBIZ-7835
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Aditi Patidar
>Assignee: Aditi Patidar
>Priority: Minor
> Attachments: OFBIZ-7835.patch, edit product facilities.png
>
>
> Steps to regenerate issue:
> 1. Navigate to Catalog -> Products.
> 2. Browse the product.
> 3. Press 'Facilities' or 'Payment Types' or 'Meters' or 'Work Effort' or 
> 'Parties' tab to look UI issue.
> Refer the attached screenshot to view the UI issue on the edit of product 
> facilities. Same kind of UI issue exists in above mentioned areas. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: JackRabbit branch

2016-07-18 Thread Pierre Smits

Your assumption and suggestion applies to many more branches than just the
2 mentioned, but only 2 were registered in JIRA.

What does that 'archive it in Jira' entail? Will associated issues be
removed from JIRA?

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Jul 18, 2016 at 11:17 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> I believe the JackRabbit branch is now completely unmergeable. I suggest
> that we archive it in Jira. It adds only confusion there. Same for the the
> Boostrap theme?
>
> I see no problems keeping all branches even old in the repo, it does annoy
> there.
>
> Thanks
>
> Jacques
>
>

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381976#comment-15381976
 ] 

Jacques Le Roux commented on OFBIZ-7782:


I don't know for Ant (and I doubt) but for Ivy it's clear for 2 years already
bq. Initially, Gradle used Apache Ivy for its dependency management. Later own 
it moved to its own native dependency resolution engine.
https://technologyconversations.com/2014/06/18/build-tools/

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381967#comment-15381967
 ] 

Pierre Smits commented on OFBIZ-7892:
-

That issue was dealt with. And it created a new issue, as the implemented patch 
was not reflecting OFBIZ-7218. In stead of revisiting closed tasks it is 
customary to open new ones, as I did.

But if you want to address the issue of enhancing OFBiz best practices with 
respect to JIRA issues, feel free to open a discussion in dev ml. 

> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

JackRabbit branch

2016-07-18 Thread Jacques Le Roux


Hi,

I believe the JackRabbit branch is now completely unmergeable. I suggest that we archive it in Jira. It adds only confusion there. Same for the the 
Boostrap theme?


I see no problems keeping all branches even old in the repo, it does annoy 
there.

Thanks

Jacques

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381956#comment-15381956
 ] 

Taher Alkhateeb commented on OFBIZ-1463:


Hello everyone,

It is important to note in here that the old OFBiz tests are really integration 
tests, not unit tests. Therefore, please note the following comments / 
recommendations:

- If your test does not need a database or some environment context, then 
convert it to a unit test
- Real unit tests are very fast, if it takes time (because of using external 
resources) then keep it as an integration test
- Unit tests are automatically run everytime you call ./gradlew build or run 
any server commands.
- Unit tests can be explicitly called by the command ./gradlew test
- Recommend to keep the JUnit tests as pure junit (nothing OFBiz related)
- Recommend using the annotations instead of starting each test name with 
test...
- Highly recommend using _ExpectedException_ and _assertThat(actual, expected) 
API over other older classical test methods.
- You might need to create mock objects for your tests. This is where mockito 
might be helpful. I will propose something on the ML once I hit a test 
requirement to introduce it.

I will create a Sub-JIRA to commit some tests for the Start component which you 
can use as a reference If you like to.

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7892) Move CertKeystore.groovy to location according to best practice

2016-07-18 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381949#comment-15381949
 ] 

Deepak Dixit commented on OFBIZ-7892:
-

Hi [~pfm.smits],

I think instead of reporting new issue we can reopen OFBIZ-6302, as this groovy 
introduced in mentioned issue.

> Move *CertKeystore.groovy* to location according to best practice
> -
>
> Key: OFBIZ-7892
> URL: https://issues.apache.org/jira/browse/OFBIZ-7892
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Pierre Smits
>
> Currently the *CertKeystore.groovy* is located in 
> *framework/common/webcommon/WEB-INF/actions/certs*. This file should move to 
> the location in accordance to best practices. 
> The dependencies need to be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Pranay Pandey (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381951#comment-15381951
 ] 

Pranay Pandey commented on OFBIZ-7752:
--

Thanks Jacques, a note for the contributors would be great.

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381933#comment-15381933
 ] 

Jacques Le Roux edited comment on OFBIZ-7752 at 7/18/16 9:10 AM:
-

Ah indeed you are right Pranay, I did not think about that. Now that it's 
official I'll remove the 2  14.12.01, 15.12.01, and we should (exceptionally) 
use the release 14 and 15. Doing it for the 1st time here, I'll not do it 
backward, too much work! But if someone wants to do it, welcome :)

Thanks for your comment!

Ah and we should also add a temporary note for contributors in the wiki, I'll 
do that also


was (Author: jacques.le.roux):
Ah indeed you are right Pranay, I did not think about that. Now that it's 
official I'll remove the 2  14.12.01, 15.12.01, and we should (exceptionally) 
use the release 14 and 15. Doing it for the 1st time here, I'll not do it 
backwar, too much work!

Thanks for your comment!

Ah and we should also add a temporary note for contributors in the wiki, I'll 
do that also

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381947#comment-15381947
 ] 

Pierre Smits commented on OFBIZ-7782:
-

FWIW: Gradle is a layer over Ant and Ant IVY and generates Maven download 
definitions underneath for dependency management.

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381933#comment-15381933
 ] 

Jacques Le Roux edited comment on OFBIZ-7752 at 7/18/16 9:09 AM:
-

Ah indeed you are right Pranay, I did not think about that. Now that it's 
official I'll remove the 2  14.12.01, 15.12.01, and we should (exceptionally) 
use the release 14 and 15. Doing it for the 1st time here, I'll not do it 
backwar, too much work!

Thanks for your comment!

Ah and we should also add a temporary note for contributors in the wiki, I'll 
do that also


was (Author: jacques.le.roux):
Ah indeed you are right Pranay, I did not think about that. Now that it's 
official I'll remove the 2  14.12.01, 15.12.01, and we should (exceptionally) 
the release 14 and 15. Doing it for the 1st time.

Thanks for your comment!

Ah and we should also add a temporary note for contributors in the wiki, I'll 
do that also

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381942#comment-15381942
 ] 

Pierre Smits commented on OFBIZ-7782:
-

That is easy to say when you don't know the inner workings of Gradle.

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7752:
---
Fix Version/s: (was: 15.12.01)
   (was: 14.12.01)
   Release Branch 14.12
   Release Branch 15.12
   Upcoming Branch

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381941#comment-15381941
 ] 

Pierre Smits commented on OFBIZ-7782:
-

It seems to me that this issue should be enough to address this. But if you 
have other arguments, please share.

> Duplicates of .properties and Label files appear
> 
>
> Key: OFBIZ-7782
> URL: https://issues.apache.org/jira/browse/OFBIZ-7782
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Attachments: Screen Shot 2016-07-13 at 10.05.43.png
>
>
> With the switch to gradle/gradlew .properties and the label definition files 
> get duplicated into the build folder. See attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7888) Apache OFBiz and OPS

2016-07-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-7888:

Description: 
This is a placeholder issue intended to capture issues that are related to the 
OPS side of the DEVOPS domain.

The encompassing areas (amongs others) are:
Continuous Integration
Continuous Deployment
CAT (Customer Acceptance Testing), including UAT and performance testing
Production

A related ml thread starts here 
http://ofbiz.markmail.org/message/dzq3e55n6z4cwmre

  was:
This is a placeholder issue intended to capture issues that are related to the 
OPS side of the DEVOPS domain.

The encompassing areas (amongs others) are:
Continuous Integration
Continuous Deployment
Production

A related ml thread starts here 
http://ofbiz.markmail.org/message/dzq3e55n6z4cwmre


> Apache OFBiz and OPS
> 
>
> Key: OFBIZ-7888
> URL: https://issues.apache.org/jira/browse/OFBIZ-7888
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>
> This is a placeholder issue intended to capture issues that are related to 
> the OPS side of the DEVOPS domain.
> The encompassing areas (amongs others) are:
> Continuous Integration
> Continuous Deployment
> CAT (Customer Acceptance Testing), including UAT and performance testing
> Production
> A related ml thread starts here 
> http://ofbiz.markmail.org/message/dzq3e55n6z4cwmre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381933#comment-15381933
 ] 

Jacques Le Roux commented on OFBIZ-7752:


Ah indeed you are right Pranay, I did not think about that. Now that it's 
official I'll remove the 2  14.12.01, 15.12.01, and we should (exceptionally) 
the release 14 and 15. Doing it for the 1st time.

Thanks for your comment!

Ah and we should also add a temporary note for contributors in the wiki, I'll 
do that also

> 'parentCommEventId' is not passed in parameter from edit communication event
> 
>
> Key: OFBIZ-7752
> URL: https://issues.apache.org/jira/browse/OFBIZ-7752
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, party
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7752.patch
>
>
> Steps :
> # Create 'New Communication Event' with parentCommEventId
> # Go To 'Edit Communication Event'
> # Click on 'Go To Parent' button
> No communicationEventId (parentCommEventId) passed with link. 
> Ref URL : https://localhost:8443/sfa/control/EditCommunicationEvent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7796) Running OFBiz as a service fails

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381931#comment-15381931
 ] 

Pierre Smits commented on OFBIZ-7796:
-

{quote}
This is something I like, I'm always reluctant to black boxes... I'd commit the 
patch but we need to agree on the ofbiz.jar name (path included). I'd then 
adapt also the other rc. scripts... if nobody disagree... Opinions?
{quote}

Is another issue: OFBIZ-7893. Lets discuss it there.

> Running OFBiz as a service fails
> 
>
> Key: OFBIZ-7796
> URL: https://issues.apache.org/jira/browse/OFBIZ-7796
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
> Environment: Ubuntu 16.04, openjdk-8-jdk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Blocker
> Attachments: OFBIZ-77796-rc.ofbiz.for.debian.patch
>
>
> In a new ubuntu environment I performed a checkout  from trunk and ran the 
> loadDefault build script.
> After this had completed, I moved the ofbiz directory from my user folder to 
> the /opt folder, and configured the Ubuntu environment to be able to run 
> OFBiz as a service.
> This entails:
> * deploy a script in /etc/init.d
> * set the correct permissions of the service script
> * create the service user 
> * changed the owner and ownergroup of the files and folders in /opt/ofbiz
> and then fire the service:
> sudo /etc/init.d/ofbiz start
> This normally starts the proces java -jar ofbiz.jar
> But now nothing happens.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7796) Running OFBiz as a service fails

2016-07-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381870#comment-15381870
 ] 

Pierre Smits edited comment on OFBIZ-7796 at 7/18/16 9:01 AM:
--

I have tested *java -jar build/libs.ofbiz-gradle.jar --start* in my dev 
environment and it works. In another cli I used  *java -jar 
build/libs.ofbiz-gradle.jar --shutdown* and it stops the task running in the 
first cli.

re:: *generic enough situation*
* No, it is - as the name of the script indicates - intended for *debian* based 
systems.
* I have changed the *JAVA_BINARY* variable from hardcoded and old java version 
1.4.2 to generic $JAVA_HOME
* I have changed the *OFBIZ_HOME* variable from location in users home folder 
to more generic */opt/ofbiz*

re: *why use java directly*
In UAT an PROD environments you want the entire OFBIZ setup running as clean, 
mean and lean as possible. That also include shortest startup time possible 
(argument behind that: minimal downtime with respect to SLAs). Building (or 
checking the build) the OFBiz implementation is not adding to that.


was (Author: pfm.smits):
I have tested *java -jar build/libs.ofbiz-gradle.jar --start* in my dev 
environment and it works. In another cli I used  *java -jar 
build/libs.ofbiz-gradle.jar --shutdownt* and it stops the task running in the 
first cli.

re:: *generic enough situation*
* No, it is - as the name of the script indicates - intended for *debian* based 
systems.
* I have changed the *JAVA_BINARY* variable from hardcoded and old java version 
1.4.2 to generic $JAVA_HOME
* I have changed the *OFBIZ_HOME* variable from location in users home folder 
to more generic */opt/ofbiz*

re: *why use java directly*
In UAT an PROD environments you want the entire OFBIZ setup running as clean, 
mean and lean as possible. That also include shortest startup time possible 
(argument behind that: minimal downtime with respect to SLAs). Building (or 
checking the build) the OFBiz implementation is not adding to that.

> Running OFBiz as a service fails
> 
>
> Key: OFBIZ-7796
> URL: https://issues.apache.org/jira/browse/OFBIZ-7796
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
> Environment: Ubuntu 16.04, openjdk-8-jdk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Blocker
> Attachments: OFBIZ-77796-rc.ofbiz.for.debian.patch
>
>
> In a new ubuntu environment I performed a checkout  from trunk and ran the 
> loadDefault build script.
> After this had completed, I moved the ofbiz directory from my user folder to 
> the /opt folder, and configured the Ubuntu environment to be able to run 
> OFBiz as a service.
> This entails:
> * deploy a script in /etc/init.d
> * set the correct permissions of the service script
> * create the service user 
> * changed the owner and ownergroup of the files and folders in /opt/ofbiz
> and then fire the service:
> sudo /etc/init.d/ofbiz start
> This normally starts the proces java -jar ofbiz.jar
> But now nothing happens.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7796) Running OFBiz as a service fails

2016-07-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381929#comment-15381929
 ] 

Jacques Le Roux commented on OFBIZ-7796:


Interesting, I was indeed able to shutdown/start OFBiz locally using
bq.  java -jar build\libs\ofbiz.jar \-\-shutdown/\-\-start
I guess the name changed since the unit tests introduction.

About
{quote}
re:: *generic enough situation*
# No, it is - as the name of the script indicates - intended for *debian* based 
systems.
# I have changed the *JAVA_BINARY* variable from hardcoded and old java version 
1.4.2 to generic $JAVA_HOME
# I have changed the *OFBIZ_HOME* variable from location in users home folder 
to more generic */opt/ofbiz*
{quote}
# of course :D
# +1
# Why not but as said above in the script anyway:
bq.  # Paths - Edit for your locations
{quote}
re: why use java directly
In UAT an PROD environments you want the entire OFBIZ setup running as clean, 
mean and lean as possible. That also include shortest startup time possible 
(argument behind that: minimal downtime with respect to SLAs). Building (or 
checking the build) the OFBiz implementation is not adding to that.
{quote}
This is something I like, I'm always reluctant to black boxes... I'd commit the 
patch but we need to agree on the ofbiz.jar name (path included). I'd then 
adapt also the other rc. scripts... *if nobody disagree*... Opinions?

Ah, also while looking at it I noticed we have still the old jars in old 
build/lib dirs. We need to remove all the svn:ignore related, and everybody 
should remove their old local build dirs. I'll create a Jira for that

> Running OFBiz as a service fails
> 
>
> Key: OFBIZ-7796
> URL: https://issues.apache.org/jira/browse/OFBIZ-7796
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
> Environment: Ubuntu 16.04, openjdk-8-jdk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Blocker
> Attachments: OFBIZ-77796-rc.ofbiz.for.debian.patch
>
>
> In a new ubuntu environment I performed a checkout  from trunk and ran the 
> loadDefault build script.
> After this had completed, I moved the ofbiz directory from my user folder to 
> the /opt folder, and configured the Ubuntu environment to be able to run 
> OFBiz as a service.
> This entails:
> * deploy a script in /etc/init.d
> * set the correct permissions of the service script
> * create the service user 
> * changed the owner and ownergroup of the files and folders in /opt/ofbiz
> and then fire the service:
> sudo /etc/init.d/ofbiz start
> This normally starts the proces java -jar ofbiz.jar
> But now nothing happens.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-7893:

Attachment: OFBIZ-7893-build.gradle.patch

This patch addresses the issue.

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-7893:
---

Assignee: Pierre Smits

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --
>
> Key: OFBIZ-7893
> URL: https://issues.apache.org/jira/browse/OFBIZ-7893
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>
> With the implementation of the Gradle build methodology the name of the OFBiz 
> executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so 
> that the old name is back.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7893) Rename generated ofbiz-gradle.jar to ofbiz.jar

2016-07-18 Thread Pierre Smits (JIRA)

Pierre Smits created OFBIZ-7893:
---

 Summary: Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
 Key: OFBIZ-7893
 URL: https://issues.apache.org/jira/browse/OFBIZ-7893
 Project: OFBiz
  Issue Type: Improvement
Reporter: Pierre Smits


With the implementation of the Gradle build methodology the name of the OFBiz 
executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.

In order to keep consistency with older releases this should be changed so that 
the old name is back.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

1 2 >

1 - 100 of 127 matches

Mail list logo