Re: Quantity UOM in Supplier Product

2017-08-15 Thread Vaibhav Jain
Hello Pierre,

A JIRA  is created for
further tracking the improvements.

Thanks & Regards

Vaibhav Jain
Hotwax Systems,
vaibhav.j...@hotwaxsystems.com

On Tue, Aug 15, 2017 at 11:22 AM, pierre  wrote:

> Hi all,
> We made something very similar.
>
> We use this information of purchasing orders until the reception.
>
> I am going to supply a patch and more details of what we made in the
> course of September (at present I am on holidays)
>
> Is there Jira to propose a patch?
>
> Many thanks
>
> Pierre
>
> On 14/08/2017 10:43, Jacques Le Roux wrote:
>
>> Thanks Scott,
>>
>> Inline too
>>
>>
>> Le 14/08/2017 à 08:20, Scott Gray a écrit :
>>
>>> Hi Vaibhav,
>>>
>>> Comments inline.
>>>
>>> Regards
>>> Scott
>>>
>>> On 11 August 2017 at 02:55, Vaibhav Jain >> >
>>> wrote:
>>>
>>> Thank you so much Scott for sharing these details, indeed they are really
 helpful.
 Kindly see my comments inline.


 On Thu, Aug 10, 2017 at 3:22 PM, Scott Gray <
 scott.g...@hotwaxsystems.com>
 wrote:

 Hi Vaibhav,
>
> It's a good question and mailing list archives (that are available)
> don't
> really answer the question clearly.  At the moment as far as I can
> tell,
> the quantityUomId and unitsIncluded field do nothing, they're display
>
 only.

> I think SupplierProduct.unitsIncluded is the same as
> Product.quantityIncluded, the field types are the same and the names
>
 imply

> similar things. I actually think unitsIncluded is a better name than
> quantityIncluded which is confusing because the number doesn't relate
> to
> any quantity fields we normally use.
>
>IMO, quantityIncluded name can be better choice, because as my
 undestanding
 unitsIncluded is used to define units of product (like each, pack etc.)
 but we may have products in various UOMs like (weight UOM, Liquid/Volume
 UOM e.t.c.)

 The confusing part is that quantityIncluded implies it has some
>>> relation to
>>> the OrderItem.quantity being ordered but that isn't the case.  I see your
>>> point though.  Perhaps a name like uomQuantityIncluded would make more
>>> sense.
>>>
>> +1 for uomQuantityIncluded, too late to change?
>>
>>
>>>
  From the Product entity definition we have this explanation of the
>
 fields:

> "If you have a six-pack of 12oz soda cans you would have
> quantityIncluded=12, quantityUomId=oz, piecesIncluded=6"
>
> piecesIncluded is missing from ProductSupplier but I think the
> definition
> for quantityIncluded/unitsIncluded can stand without it.
>
> As per my understanding the quantityIncluded defines the quantity
 included
 in the respective quantityUomId and we do not need piecesIncluded here.

 The need is really based on the real-world use case. piecesIncluded
>>> could
>>> have a place in a purchasing use case in the same way it does for a
>>> selling
>>> use case.
>>>
>> +1 for putting in piecesIncludedin case of purchase also.
>>
>>
>>>
>>> "If you have a six-pack of 12oz soda cans you would have
>>
> quantityIncluded=6 quantityUomId=pack"

 As per my understanding, I think, "oz" is a weightUomId and this should
 be
 managed at product level not at SupplierProduct. Please let me know your
 thoughts on this.

 The purpose of the Product.quantityUomId is to define how we choose to
>>> describe our product.  Likewise the SupplierProduct.quantityUomId defines
>>> how the supplier describes their product.
>>>
>>> To extend my earlier use-case: If I am a house painter in NZ but I import
>>> my paint from the US, then chances are I would be ordering from a
>>> supplier
>>> who works in fluid ounces, US quarts or gallons.  Despite that, I still
>>> want to be able to sell paint locally by the litre.
>>>
>>>
>>> So I think what we can conclude from this detail is that these fields are
> informative and not functional, and they shouldn't have any bearing
>
 against

> other fields such as lastPrice.
>
> Agreed!


 I think there could be room for making use of the fields, an example:
> Let's say you are a house painter and you need to order 12 litres of
>
 paint

> for a job.  The supplier has two products available, 2 litre tins @ $10
>
 and

> 4 litre tins @ $15:
>  minimumOrderQuantity="1" orderQtyIncrements="1"/>
> 
 lastPrice="3.75"

> minimumOrderQuantity="1" orderQtyIncrements="1"/>
>
> So you tell your amazing OFBiz system that you'd like to order 12
> liters
>
 of

> paint, OFBiz will then look at your SupplierProduct records and
> determine
> which record gives you the best price and fits within the supplier's
> purchasing rules (i.e. you can't 

Re: buildbot success in on ofbiz-trunk-framework-plugins

2017-08-15 Thread Jacques Le Roux

Hi Michael,

Also this is not related with Buildbot, it's OK there

https://ci.apache.org/builders/ofbiz-trunk-framework-plugins

The ofbiz-trunk-framework-plugins test all

https://ci.apache.org/builders/ofbiz-trunk-framework

The ofbiz-trunk-framework test only the framework

HTH

Jacques


Le 15/08/2017 à 21:50, gil portenseigne a écrit :

Hello Michael,

I just did try the given build *./gradlew cleanAll loadAll testIntegration 
eclipse*, with success :

2017-08-15 21:37:54,529 |main |ContainerLoader   |I| Stopping 
container component-container
2017-08-15 21:37:54,529 |main |ContainerLoader   |I| Stopped 
container component-container
Trying to override old definition of datatype junitreport
:testIntegration
:eclipseClasspath
:eclipseJdt
:eclipseProject
:eclipse

BUILD SUCCESSFUL

Total time: 7 mins 52.896 secs

You might have something wrong on your side...

Gil


On 15/08/2017 20:29, Michael Brohl wrote:

Hi devs,

Is anyone else experiencing build failures with the latest trunk version?

The build ./gradlew cleanAll loadAll testIntegration eclipse

fails with the following messages:

org.apache.ofbiz.base.start.StartupException: Cannot start() 
org.apache.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:150)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)
at org.apache.ofbiz.base.start.Start.main(Start.java:84)
Caused by: org.apache.ofbiz.base.container.ContainerException: Test run was 
unsuccessful
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:199)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
... 4 more
:ofbiz --test FAILED
Trying to override old definition of datatype junitreport

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ofbiz --test'.
> Process 'command 
'/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home/bin/java'' 
finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED


The failed tests are

failure:

servicetestsservice-xml-rpc-local-engineFailureHTTP server returned 
unexpected status: Invalid password/token for user: admin

junit.framework.AssertionFailedError: HTTP server returned unexpected status: 
Invalid password/token for user: admin
at org.apache.ofbiz.testtools.ServiceTest.run(ServiceTest.java:677)
at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainnerLoader.java:148)
at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupConttrolPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)
at org.apache.ofbiz.base.staart.Start.main(Start.java:84)

error:

serviceteststestSOAPSimpleServiceErrorService did not return 
expected result

org.apache.ofbiz.service.GenericServiceException: Service did not return 
expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at 
org.apache.ofbiz.service.test.ServiceSOAPTests.testSOAPSimpleService(SerrviceSOAPTests.java:43)
at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoadeer.startLoadedContainers(ContainerLoader.java:148)
at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:222)
at 
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:72)
at org.apache.ofbiz.base.staart.Start.main(Start.java:84)
0.596
serviceteststestSOAPServiceErrorService did not return expected 
result

org.apache.ofbiz.service.GenericServiceException: Service did not return 
expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 

Re: buildbot success in on ofbiz-trunk-framework-plugins

2017-08-15 Thread gil portenseigne

Hello Michael,

I just did try the given build *./gradlew cleanAll loadAll 
testIntegration eclipse*, with success :


2017-08-15 21:37:54,529 |main |ContainerLoader   |I| 
Stopping container component-container
2017-08-15 21:37:54,529 |main |ContainerLoader   |I| Stopped 
container component-container

Trying to override old definition of datatype junitreport
:testIntegration
:eclipseClasspath
:eclipseJdt
:eclipseProject
:eclipse

BUILD SUCCESSFUL

Total time: 7 mins 52.896 secs

You might have something wrong on your side...

Gil


On 15/08/2017 20:29, Michael Brohl wrote:

Hi devs,

Is anyone else experiencing build failures with the latest trunk version?

The build ./gradlew cleanAll loadAll testIntegration eclipse

fails with the following messages:

org.apache.ofbiz.base.start.StartupException: Cannot start() 
org.apache.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:150)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.start.Start.main(Start.java:84)
Caused by: org.apache.ofbiz.base.container.ContainerException: Test 
run was unsuccessful
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:199)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)

... 4 more
:ofbiz --test FAILED
Trying to override old definition of datatype junitreport

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ofbiz --test'.
> Process 'command 
'/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home/bin/java'' 
finished with non-zero exit value 1


* Try:
Run with --stacktrace option to get the stack trace. Run with --info 
or --debug option to get more log output.


BUILD FAILED


The failed tests are

failure:

servicetestsservice-xml-rpc-local-engineFailureHTTP server 
returned unexpected status: Invalid password/token for user: admin


junit.framework.AssertionFailedError: HTTP server returned unexpected 
status: Invalid password/token for user: admin

at org.apache.ofbiz.testtools.ServiceTest.run(ServiceTest.java:677)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainnerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupConttrolPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)

error:

serviceteststestSOAPSimpleServiceErrorService did not 
return expected result


org.apache.ofbiz.service.GenericServiceException: Service did not 
return expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at 
org.apache.ofbiz.service.test.ServiceSOAPTests.testSOAPSimpleService(SerrviceSOAPTests.java:43)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoadeer.startLoadedContainers(ContainerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:222)
at 
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)
0.596
serviceteststestSOAPServiceErrorService did not return 
expected result


org.apache.ofbiz.service.GenericServiceException: Service did not 
return expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at 
org.apache.ofbiz.service.test.ServiceSOAPTests.testSOAPService(ServicceSOAPTests.java:54)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 

Re: buildbot success in on ofbiz-trunk-framework-plugins

2017-08-15 Thread Michael Brohl

Sorry,

the subject/Re: is wrong, the build problems are in OFBiz framework, not 
plugins.


Thanks,

Michael


Am 15.08.17 um 20:29 schrieb Michael Brohl:

Hi devs,

Is anyone else experiencing build failures with the latest trunk version?

The build ./gradlew cleanAll loadAll testIntegration eclipse

fails with the following messages:

org.apache.ofbiz.base.start.StartupException: Cannot start() 
org.apache.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:150)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.start.Start.main(Start.java:84)
Caused by: org.apache.ofbiz.base.container.ContainerException: Test 
run was unsuccessful
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:199)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)

... 4 more
:ofbiz --test FAILED
Trying to override old definition of datatype junitreport

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ofbiz --test'.
> Process 'command 
'/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home/bin/java'' 
finished with non-zero exit value 1


* Try:
Run with --stacktrace option to get the stack trace. Run with --info 
or --debug option to get more log output.


BUILD FAILED


The failed tests are

failure:

servicetestsservice-xml-rpc-local-engineFailureHTTP server 
returned unexpected status: Invalid password/token for user: admin


junit.framework.AssertionFailedError: HTTP server returned unexpected 
status: Invalid password/token for user: admin

at org.apache.ofbiz.testtools.ServiceTest.run(ServiceTest.java:677)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainnerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupConttrolPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)

error:

serviceteststestSOAPSimpleServiceErrorService did not 
return expected result


org.apache.ofbiz.service.GenericServiceException: Service did not 
return expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at 
org.apache.ofbiz.service.test.ServiceSOAPTests.testSOAPSimpleService(SerrviceSOAPTests.java:43)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoadeer.startLoadedContainers(ContainerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:222)
at 
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)
0.596
serviceteststestSOAPServiceErrorService did not return 
expected result


org.apache.ofbiz.service.GenericServiceException: Service did not 
return expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at 
org.apache.ofbiz.service.test.ServiceSOAPTests.testSOAPService(ServicceSOAPTests.java:54)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoadeer.startLoadedContainers(ContainerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:222)
at 
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)
0.046
serviceteststestXmlRpcRequestErrorHTTP server returned 
unexpected 

Re: buildbot success in on ofbiz-trunk-framework-plugins

2017-08-15 Thread Michael Brohl

Hi devs,

Is anyone else experiencing build failures with the latest trunk version?

The build ./gradlew cleanAll loadAll testIntegration eclipse

fails with the following messages:

org.apache.ofbiz.base.start.StartupException: Cannot start() 
org.apache.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:150)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.start.Start.main(Start.java:84)
Caused by: org.apache.ofbiz.base.container.ContainerException: Test run 
was unsuccessful
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:199)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)

... 4 more
:ofbiz --test FAILED
Trying to override old definition of datatype junitreport

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ofbiz --test'.
> Process 'command 
'/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home/bin/java'' 
finished with non-zero exit value 1


* Try:
Run with --stacktrace option to get the stack trace. Run with --info or 
--debug option to get more log output.


BUILD FAILED


The failed tests are

failure:

servicetestsservice-xml-rpc-local-engineFailureHTTP server 
returned unexpected status: Invalid password/token for user: admin


junit.framework.AssertionFailedError: HTTP server returned unexpected 
status: Invalid password/token for user: admin

at org.apache.ofbiz.testtools.ServiceTest.run(ServiceTest.java:677)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainnerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupConttrolPanel.java:222)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)

error:

serviceteststestSOAPSimpleServiceErrorService did not return 
expected result


org.apache.ofbiz.service.GenericServiceException: Service did not return 
expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at 
org.apache.ofbiz.service.test.ServiceSOAPTests.testSOAPSimpleService(SerrviceSOAPTests.java:43)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoadeer.startLoadedContainers(ContainerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:222)
at 
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)
0.596
serviceteststestSOAPServiceErrorService did not return 
expected result


org.apache.ofbiz.service.GenericServiceException: Service did not return 
expected result
at 
org.apache.ofbiz.service.engine.SOAPClientEngine.runSync(SOAPClientEngine.java:77)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at 
org.apache.ofbiz.service.test.ServiceSOAPTests.testSOAPService(ServicceSOAPTests.java:54)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:152)
at 
org.apache.ofbiz.base.container.ContainerLoadeer.startLoadedContainers(ContainerLoader.java:148)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:222)
at 
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:72)

at org.apache.ofbiz.base.staart.Start.main(Start.java:84)
0.046
serviceteststestXmlRpcRequestErrorHTTP server returned 
unexpected status: Invalid password/token for user: admin


org.apache.xmlrpc.client.XmlRpcHttpTransportException: HTTP server 
returned unexpected status: Invalid 

buildbot success in on ofbiz-trunk-framework-plugins

2017-08-15 Thread buildbot
The Buildbot has detected a restored build on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/341

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1805107
Blamelist: jleroux

Build succeeded!

Sincerely,
 -The Buildbot





Let's encrypt certificate renewal

2017-08-15 Thread Jacques Le Roux

Dear Infra team,

The OFBiz project recently suffered a Let's encrypt certificate renewal failure. I asked for help on Infra HipChat room and it got quickly fixed with 
the help of Chris Thistlethwaite (thanks again Chris:))


Then I reported to the OFBiz team here https://s.apache.org/xBT8

Richard Siddall, one of our user, suggested to have a look at 
https://github.com/dthielking/puppet_getssl

I did not check what is used in Puppet at the ASF, but in case it was worth it 
I decided to send this message

Thanks

Jacques



Re: Request for enhance entity:SystemProperty.

2017-08-15 Thread Jacques Le Roux

Hi Wai,

It was more a question. I also think UserLogin fits

Jacques


Le 14/08/2017 à 23:52, Wai a écrit :

Since entity:UserPreference provides a reference to entity:UserLogin, it
seems a good fit for what I need.
You implied that a party-based preference would be more appropriate. What
would be the advantage of a party-based version.
If I were to use a party-based version then I would have to create another
entity (eg. PartyPreference)
Thanks



--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Re-Request-for-enhance-entity-SystemProperty-tp4709235p4709655.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.





Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

2017-08-15 Thread Jacques Le Roux

Thanks Nicolas,

I completed with a quote in OFBIZ-9577 and a mention at the top of the commit comment (as it's in our template, for Michael to refer in the monthly 
blog post)


Jacques


Le 14/08/2017 à 23:29, Nicolas Malin a écrit :

done :)


Le 14/08/2017 à 23:10, Jacques Le Roux a écrit :

I guess just a mention of the commit, and its reason, in OFBIZ-9577 should be 
enough

Thanks

Jacques


Le 14/08/2017 à 20:33, Nicolas Malin a écrit :

Not really, I detect it effectively during some trying related to the 
OFBIZ-9577but actually I didn't detect any problem with that in the framework.

So I corrected it because it's a easy framework error.

If you think it's interesting to open an issue, I can do that

Nicolas


Le 14/08/2017 à 19:49, Jacques Le Roux a écrit :

Ha got it OFBIZ-9577

Jacques

Le 14/08/2017 à 19:38, Jacques Le Roux a écrit :

Good catch Nicolas,

Should there not be a related Jira?

Thanks

Jacques


Le 14/08/2017 à 17:47, nma...@apache.org a écrit :

Author: nmalin
Date: Mon Aug 14 15:47:36 2017
New Revision: 1805011

URL: http://svn.apache.org/viewvc?rev=1805011=rev
Log:
Fixed: Missing fieldInfo when call constructor for ModelFormField Password, 
File and Lookup
When you create a form with an entity or service auto fields, the three previous form field call only "super(fieldSource, modelFormField);" in 
their constructor or this initialise a TextField with the fieldInfo FieldInfo.TEXT.

I force the field info when the super constructor is called


Modified:
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java

Modified: 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1805011=1805010=1805011=diff

==
--- 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
 Mon Aug 14 15:47:36 2017
@@ -2096,7 +2096,7 @@ public class ModelFormField {
  }
public FileField(int fieldSource, ModelFormField modelFormField) {
-super(fieldSource, modelFormField);
+super(fieldSource, FieldInfo.FILE, modelFormField);
  }
@Override
@@ -3028,7 +3028,7 @@ public class ModelFormField {
  }
public LookupField(int fieldSource, ModelFormField modelFormField) {
-super(fieldSource, modelFormField);
+super(fieldSource, FieldInfo.LOOKUP, modelFormField);
  this.descriptionFieldName = "";
  this.fadeBackground = "";
  this.formName = FlexibleStringExpander.getInstance("");
@@ -3250,7 +3250,7 @@ public class ModelFormField {
  }
public PasswordField(int fieldSource, ModelFormField 
modelFormField) {
-super(fieldSource, modelFormField);
+super(fieldSource, FieldInfo.PASSWORD, modelFormField);
  }
private PasswordField(PasswordField original, ModelFormField 
modelFormField) {