Re: Permission service not on the same transaction

[Jacques Le Roux]

Thanks Nicolas,

Sorry, I completely forgot about that.

I'll have a look ASAP, but after 
https://issues.apache.org/jira/browse/OFBIZ-10047 that I want in R17 :)

Jacques

Le 14/08/2017 à 20:40, Nicolas Malin a écrit :

Hi Jacques,

All is present on the issue OFBIZ-7113 


But I think the patch doesn't up to date.
It contains big change, I will review quietly if you think it would be a good 
improvement

Nicolas
Le 12/08/2017 à 10:23, Jacques Le Roux a écrit :

Hi Nicolas,

Just stumbled upon this. Is there a Jira? What is the revision commit number?

Thanks
Jacques (sent from PonyMail)

On 2016-04-14 21:03, Nicolas Malin  wrote:

No remarks on this case ?

If the silent is present I open an issue and commit this patch ;)

Nicolas

Le 07/04/2016 10:00, Nicolas Malin a écrit :

Hello,

Currently I continue the conversion on shipment  crud service and I
detected that many service use the same mini-lang call to check if the
shipment status is ok for editing "checkCanChangeShipmentStatusPacked"

I convert it on service to call it directly by the permission-service
like that :

 ...
 
 ...
 

The problem with this change that when I run the unit tests, I have
some failed to due database lock on shipment.
After some analyse I founded that the permission service wasn't call
on the same service's transaction.
I a realize this change :

Index: framework/service/src/org/ofbiz/service/ModelService.java
===
--- framework/service/src/org/ofbiz/service/ModelService.java
(révision 1737860)
+++ framework/service/src/org/ofbiz/service/ModelService.java (copie
de travail)
@@ -985,7 +985,7 @@
  LocalDispatcher dispatcher = dctx.getDispatcher();
  Map resp;
  try {
-    resp = dispatcher.runSync(permission.name, ctx,
300, true);
+    resp = dispatcher.runSync(permission.name, ctx);
  } catch (GenericServiceException e) {
  Debug.logError(e, module);
  Map result =
ServiceUtil.returnSuccess();

All unit test pass.
Anyone know the reason to call the permission service on a new
transaction ?
I couldn't spot any valid reason.

Thnaks for help ;)

Nicolas

--
#jeSuisCharlie
logoNrd 
Nicolas Malin
Ingénieur d'étude. Dernier sujet : "Les vaches portant un prénom
pouvent trouver la sortie d'un labyrinthe en cas de toxoplasmose
informat...@nereide.fr
8 rue des Déportés 37000 TOURS, 02 47 50 30 54

Apache OFBiz  | ofbiz-fr
 | | réseau LE

Re: Put the social networks icons above "Latest tweets" (OFBIZ-10050)

[Jacques Le Roux]

Le 11/12/2017 à 13:29, Jacques Le Roux a écrit :

Hi,

I wanted to put the social networks icons above "Latest tweets" but it's not as 
easy as I thought without breaking the layout.

Could someone with more knowledge with the site have a look please?

TIA

Jacques



I even wonder if we should not remove the Tweeter feeds from the site. I often 
find myself waiting the site appears or completes because of this part :/
And actually I think we can get rid of them w/o too much annoyance.

Jacques

Re: svn commit: r1818093 - /ofbiz/ofbiz-framework/trunk/README.md

[Jacques Le Roux]

Done at revision: 1818125

BTW, I find funny that users have to get to this section after failing with the 
"Quick start" section ;)

"C'est la vie" would say some

Jacques


Le 14/12/2017 à 13:09, Jacques Le Roux a écrit :

We have already a FAQ, I'll add a "known issues" section there and add a link 
at bottom of the README.md

But should we not warn new users in the the "Quick start" section about this 
dash issue which came at least 3 times now

Jacques


Le 14/12/2017 à 10:40, Taher Alkhateeb a écrit :

Yup +1

One remark, I recommend the "further reading" section should be
somewhere at the bottom of the README.md. We keep adding stuff to the
top of this file which keeps hiding away the most important part of
the README.md to new comers: the "Quick start" section.

On Thu, Dec 14, 2017 at 12:22 PM, Jacopo Cappellato
 wrote:

On Thu, Dec 14, 2017 at 10:02 AM, Michael Brohl 
wrote:


I suggest to create an FAQ or "known issues" section in our wiki and have
a section in the README.md like "further reading" or "additional infos"
etc. which contain the links.

Regards,

Michael


+1

This is a good idea Michael!

Jacopo

Re: svn commit: r1818093 - /ofbiz/ofbiz-framework/trunk/README.md

[Jacques Le Roux]

We have already a FAQ, I'll add a "known issues" section there and add a link 
at bottom of the README.md

But should we not warn new users in the the "Quick start" section about this 
dash issue which came at least 3 times now

Jacques


Le 14/12/2017 à 10:40, Taher Alkhateeb a écrit :

Yup +1

One remark, I recommend the "further reading" section should be
somewhere at the bottom of the README.md. We keep adding stuff to the
top of this file which keeps hiding away the most important part of
the README.md to new comers: the "Quick start" section.

On Thu, Dec 14, 2017 at 12:22 PM, Jacopo Cappellato
 wrote:

On Thu, Dec 14, 2017 at 10:02 AM, Michael Brohl 
wrote:


I suggest to create an FAQ or "known issues" section in our wiki and have
a section in the README.md like "further reading" or "additional infos"
etc. which contain the links.

Regards,

Michael


+1

This is a good idea Michael!

Jacopo

Re: svn commit: r1818093 - /ofbiz/ofbiz-framework/trunk/README.md

[Taher Alkhateeb]

Yup +1

One remark, I recommend the "further reading" section should be
somewhere at the bottom of the README.md. We keep adding stuff to the
top of this file which keeps hiding away the most important part of
the README.md to new comers: the "Quick start" section.

On Thu, Dec 14, 2017 at 12:22 PM, Jacopo Cappellato
 wrote:
> On Thu, Dec 14, 2017 at 10:02 AM, Michael Brohl 
> wrote:
>
>> I suggest to create an FAQ or "known issues" section in our wiki and have
>> a section in the README.md like "further reading" or "additional infos"
>> etc. which contain the links.
>>
>> Regards,
>>
>> Michael
>>
>
> +1
>
> This is a good idea Michael!
>
> Jacopo

Re: svn commit: r1818093 - /ofbiz/ofbiz-framework/trunk/README.md

[Jacopo Cappellato]

On Thu, Dec 14, 2017 at 10:02 AM, Michael Brohl 
wrote:

> I suggest to create an FAQ or "known issues" section in our wiki and have
> a section in the README.md like "further reading" or "additional infos"
> etc. which contain the links.
>
> Regards,
>
> Michael
>

+1

This is a good idea Michael!

Jacopo

Re: svn commit: r1818093 - /ofbiz/ofbiz-framework/trunk/README.md

[Michael Brohl]

I suggest to create an FAQ or "known issues" section in our wiki and 
have a section in the README.md like "further reading" or "additional 
infos" etc. which contain the links.


Regards,

Michael


Am 14.12.17 um 09:12 schrieb Jacques Le Roux:
I wonder, we had already at least 2 persons crossing this issue and 
it's not obvious to spot it's this one and remember the solution.


Maybe we can move it to another place but keep it there? Finding 
https://cwiki.apache.org/confluence/display/OFBENDUSER/How+to+Install+OFBiz+without+the+Demo+Data 
seems not enough for some people


What do others think?

Jacques


Le 14/12/2017 à 08:42, Taher Alkhateeb a écrit :
This is too specific to include in the general README.md file. I 
don't think we need to keep every workaround and every specific 
detail otherwise this file would get too large. This is especially 
true because you added the comment under a very specific instruction 
that was discussed in a thread.


I recommend removing it.


On 12/14/2017 10:38 AM, jler...@apache.org wrote:

Author: jleroux
Date: Thu Dec 14 07:38:45 2017
New Revision: 1818093

URL: http://svn.apache.org/viewvc?rev=1818093=rev
Log:
No functional change, warning about dashes

Modified:
 ofbiz/ofbiz-framework/trunk/README.md

Modified: ofbiz/ofbiz-framework/trunk/README.md
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/README.md?rev=1818093=1818092=1818093=diff
== 


--- ofbiz/ofbiz-framework/trunk/README.md (original)
+++ ofbiz/ofbiz-framework/trunk/README.md Thu Dec 14 07:38:45 2017
@@ -328,6 +328,11 @@ Example:
    `gradlew "ofbiz --load-data 
readers=seed,seed-initial,ext,ext-demo"`

  +
+Beware that copying this command in Microsoft Word will 
automatically transform the double dash in en dashes (Unicode 
0x2013: –)
+Other cases not related to Word were also reported.So when this 
command does not work check that you are using dash!

+text
+
   Load all OFBiz data
    Loads all data sets; meant for initial loading of generic OFBiz 
data.













smime.p7s
Description: S/MIME Cryptographic Signature

Re: svn commit: r1818093 - /ofbiz/ofbiz-framework/trunk/README.md

[Jacques Le Roux]

I wonder, we had already at least 2 persons crossing this issue and it's not 
obvious to spot it's this one and remember the solution.

Maybe we can move it to another place but keep it there? Finding 
https://cwiki.apache.org/confluence/display/OFBENDUSER/How+to+Install+OFBiz+without+the+Demo+Data seems not enough for some people


What do others think?

Jacques


Le 14/12/2017 à 08:42, Taher Alkhateeb a écrit :
This is too specific to include in the general README.md file. I don't think we need to keep every workaround and every specific detail otherwise 
this file would get too large. This is especially true because you added the comment under a very specific instruction that was discussed in a thread.


I recommend removing it.


On 12/14/2017 10:38 AM, jler...@apache.org wrote:

Author: jleroux
Date: Thu Dec 14 07:38:45 2017
New Revision: 1818093

URL: http://svn.apache.org/viewvc?rev=1818093=rev
Log:
No functional change, warning about dashes

Modified:
 ofbiz/ofbiz-framework/trunk/README.md

Modified: ofbiz/ofbiz-framework/trunk/README.md
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/README.md?rev=1818093=1818092=1818093=diff
==
--- ofbiz/ofbiz-framework/trunk/README.md (original)
+++ ofbiz/ofbiz-framework/trunk/README.md Thu Dec 14 07:38:45 2017
@@ -328,6 +328,11 @@ Example:
    `gradlew "ofbiz --load-data readers=seed,seed-initial,ext,ext-demo"`
  +
+Beware that copying this command in Microsoft Word will automatically 
transform the double dash in en dashes (Unicode 0x2013: –)
+Other cases not related to Word were also reported.So when this command does 
not work check that you are using dash!
+text
+
   Load all OFBiz data
    Loads all data sets; meant for initial loading of generic OFBiz data.