Re: Welcome to Mathieu Lirzin as new committer!

[Jacopo Cappellato]

Welcome to the party, Mathieu!

Jacopo



On Tue, Feb 19, 2019 at 6:16 PM Taher Alkhateeb  wrote:

> The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> we are happy to announce that he has accepted this role.
>
> Some of the reasons for inviting Mathieu include:
>
> - He is invested in the OFBiz project and has delivered substantial
> work to the code base.
> - He has demonstrated solid technical skills.
> - He adopts a professional attitude towards coding and software
> development.
> - He engages thoughtfully with others and likes to work with the community.
>
> Please join me in welcoming and congratulating Mathieu!
>
> Cheers,
> Taher Alkhateeb
>

Re: Welcome to Mathieu Lirzin as new committer!

[Suraj Khurana]

Many congratulations Mathieu.

Welcome, Abroad !!

--
Best Regards,
Suraj Khurana
TECHNICAL CONSULTANT
mobile: +91 9669750002
email: suraj.khur...@hotwax.co
www.hotwax.co






On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:

> The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> we are happy to announce that he has accepted this role.
>
> Some of the reasons for inviting Mathieu include:
>
> - He is invested in the OFBiz project and has delivered substantial
> work to the code base.
> - He has demonstrated solid technical skills.
> - He adopts a professional attitude towards coding and software
> development.
> - He engages thoughtfully with others and likes to work with the community.
>
> Please join me in welcoming and congratulating Mathieu!
>
> Cheers,
> Taher Alkhateeb
>

Re: Welcome to Mathieu Lirzin as new committer!

[Gil Portenseigne]

Welcome Mathieu, and Congratulations !

Gil

Le 20:15 - mardi 19 févr., Taher Alkhateeb a écrit :
> The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> we are happy to announce that he has accepted this role.
> 
> Some of the reasons for inviting Mathieu include:
> 
> - He is invested in the OFBiz project and has delivered substantial
> work to the code base.
> - He has demonstrated solid technical skills.
> - He adopts a professional attitude towards coding and software development.
> - He engages thoughtfully with others and likes to work with the community.
> 
> Please join me in welcoming and congratulating Mathieu!
> 
> Cheers,
> Taher Alkhateeb

Re: Welcome to Mathieu Lirzin as new committer!

[Deepak Nigam]

Congratulations Mathieu!!

Thanks & Regards
--
Deepak Nigam

On Wed, Feb 20, 2019 at 10:32 AM Swapnil M Mane 
wrote:

> Many congratulations Mathieu, welcome aboard :-)
>
>
> - Best Regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:
>
> > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> > we are happy to announce that he has accepted this role.
> >
> > Some of the reasons for inviting Mathieu include:
> >
> > - He is invested in the OFBiz project and has delivered substantial
> > work to the code base.
> > - He has demonstrated solid technical skills.
> > - He adopts a professional attitude towards coding and software
> > development.
> > - He engages thoughtfully with others and likes to work with the
> community.
> >
> > Please join me in welcoming and congratulating Mathieu!
> >
> > Cheers,
> > Taher Alkhateeb
> >
>

Re: Welcome to Mathieu Lirzin as new committer!

[Swapnil M Mane]

Many congratulations Mathieu, welcome aboard :-)


- Best Regards,
Swapnil M Mane,
ofbiz.apache.org



On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:

> The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> we are happy to announce that he has accepted this role.
>
> Some of the reasons for inviting Mathieu include:
>
> - He is invested in the OFBiz project and has delivered substantial
> work to the code base.
> - He has demonstrated solid technical skills.
> - He adopts a professional attitude towards coding and software
> development.
> - He engages thoughtfully with others and likes to work with the community.
>
> Please join me in welcoming and congratulating Mathieu!
>
> Cheers,
> Taher Alkhateeb
>

Re: buildbot failure in on ofbizTrunkFramework

[Deepak Dixit]

This might be false positives, testIntegration working fine on local.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Feb 19, 2019 at 11:43 PM  wrote:

> The Buildbot has detected a new failure on builder ofbizTrunkFramework
> while building . Full details are available at:
> https://ci.apache.org/builders/ofbizTrunkFramework/builds/663
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named
> 'onTrunkFrameworkCommit' triggered this build
> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1853905
> Blamelist: deepak
>
> BUILD FAILED: failed shell_2
>
> Sincerely,
>  -The Buildbot
>
>
>
>

Re: Welcome to Mathieu Lirzin as new committer!

[Aditya Sharma]

Felicitations Mathieu :)

Welcome Aboard..!!

Regards,
Aditya Sharma


On Wed, Feb 20, 2019 at 10:13 AM Ashish Vijaywargiya <
ashish.vijaywarg...@hotwaxsystems.com> wrote:

> Welcome and congratulations Mathieu! :-)
>
> --
> Kind Regards
> Ashish Vijaywargiya
> HotWax Systems - est. 1997 
>
>
>
> On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:
>
> > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> > we are happy to announce that he has accepted this role.
> >
> > Some of the reasons for inviting Mathieu include:
> >
> > - He is invested in the OFBiz project and has delivered substantial
> > work to the code base.
> > - He has demonstrated solid technical skills.
> > - He adopts a professional attitude towards coding and software
> > development.
> > - He engages thoughtfully with others and likes to work with the
> community.
> >
> > Please join me in welcoming and congratulating Mathieu!
> >
> > Cheers,
> > Taher Alkhateeb
> >
>

Re: Welcome to Mathieu Lirzin as new committer!

[Ashish Vijaywargiya]

Welcome and congratulations Mathieu! :-)

--
Kind Regards
Ashish Vijaywargiya
HotWax Systems - est. 1997 



On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:

> The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> we are happy to announce that he has accepted this role.
>
> Some of the reasons for inviting Mathieu include:
>
> - He is invested in the OFBiz project and has delivered substantial
> work to the code base.
> - He has demonstrated solid technical skills.
> - He adopts a professional attitude towards coding and software
> development.
> - He engages thoughtfully with others and likes to work with the community.
>
> Please join me in welcoming and congratulating Mathieu!
>
> Cheers,
> Taher Alkhateeb
>

Re: Welcome to Mathieu Lirzin as new committer!

[Michael Brohl]

Congratulations and welcome, Mathieu!

Happy to have you on board!

Regards,

Michael


Am 19.02.19 um 18:15 schrieb Taher Alkhateeb:

The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
we are happy to announce that he has accepted this role.

Some of the reasons for inviting Mathieu include:

- He is invested in the OFBiz project and has delivered substantial
work to the code base.
- He has demonstrated solid technical skills.
- He adopts a professional attitude towards coding and software development.
- He engages thoughtfully with others and likes to work with the community.

Please join me in welcoming and congratulating Mathieu!

Cheers,
Taher Alkhateeb




smime.p7s
Description: S/MIME Cryptographic Signature

Re: Welcome to Mathieu Lirzin as new committer!

[Sharan Foga]

Welcome and congratulations Mathieu!

Thanks
Sharan

On 2019/02/19 17:15:49, Taher Alkhateeb  wrote: 
> The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> we are happy to announce that he has accepted this role.
> 
> Some of the reasons for inviting Mathieu include:
> 
> - He is invested in the OFBiz project and has delivered substantial
> work to the code base.
> - He has demonstrated solid technical skills.
> - He adopts a professional attitude towards coding and software development.
> - He engages thoughtfully with others and likes to work with the community.
> 
> Please join me in welcoming and congratulating Mathieu!
> 
> Cheers,
> Taher Alkhateeb
> 

Re: Pending works from Christian Carlow

[Pierre Smits]

We don’t have to many tickets. We just don’t have enough contributors that
take an interest to work the tickets.

On Tue, 19 Feb 2019 at 20:54 Taher Alkhateeb 
wrote:

> I think it's not a big deal just a side comment. We have too many JIRAs and
> we really could benefit from cleaning them up. Perhaps after you close them
> all you can just mention those tickets here as a reference for the future.
>
> On Tue, Feb 19, 2019, 8:41 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com
> wrote:
>
> > I agree about the value of these Jiras.
> >
> > What do you mean/think-about exactly by
> >
> > <>
> >
> > ?
> >
> > Is Michael's answer sufficient? You can indeed search for Christian's
> > closed Jira with patches.
> >
> > Jacques
> >
> > Le 19/02/2019 à 16:20, Taher Alkhateeb a écrit :
> > > +1
> > >
> > > It would be nice to highlight somehow the tickets that have patches as
> > > I can see some value in the work in these JIRAs.
> > >
> > > On Tue, Feb 19, 2019 at 4:22 PM Jacques Le Roux
> > >  wrote:
> > >> Hi,
> > >>
> > >> There are a bunch of obsolete patches from Christian Carlow like in
> > https://issues.apache.org/jira/browse/OFBIZ-6418 and related (from
> there)
> > >>
> > >> I suggest we close all of them as won't do and will do so in 1 week
> > >>
> > >> Jacques
> > >>
> >
>
-- 
Sent from my phone

Re: Pending works from Christian Carlow

[Taher Alkhateeb]

I think it's not a big deal just a side comment. We have too many JIRAs and
we really could benefit from cleaning them up. Perhaps after you close them
all you can just mention those tickets here as a reference for the future.

On Tue, Feb 19, 2019, 8:41 PM Jacques Le Roux  I agree about the value of these Jiras.
>
> What do you mean/think-about exactly by
>
> <>
>
> ?
>
> Is Michael's answer sufficient? You can indeed search for Christian's
> closed Jira with patches.
>
> Jacques
>
> Le 19/02/2019 à 16:20, Taher Alkhateeb a écrit :
> > +1
> >
> > It would be nice to highlight somehow the tickets that have patches as
> > I can see some value in the work in these JIRAs.
> >
> > On Tue, Feb 19, 2019 at 4:22 PM Jacques Le Roux
> >  wrote:
> >> Hi,
> >>
> >> There are a bunch of obsolete patches from Christian Carlow like in
> https://issues.apache.org/jira/browse/OFBIZ-6418 and related (from there)
> >>
> >> I suggest we close all of them as won't do and will do so in 1 week
> >>
> >> Jacques
> >>
>

Re: Pending works from Christian Carlow

[Pierre Smits]

If you close those tickets that status ‘patch available’ will be lost.

On Tue, 19 Feb 2019 at 18:41 Jacques Le Roux 
wrote:

> I agree about the value of these Jiras.
>
> What do you mean/think-about exactly by
>
> <>
>
> ?
>
> Is Michael's answer sufficient? You can indeed search for Christian's
> closed Jira with patches.
>
> Jacques
>
> Le 19/02/2019 à 16:20, Taher Alkhateeb a écrit :
> > +1
> >
> > It would be nice to highlight somehow the tickets that have patches as
> > I can see some value in the work in these JIRAs.
> >
> > On Tue, Feb 19, 2019 at 4:22 PM Jacques Le Roux
> >  wrote:
> >> Hi,
> >>
> >> There are a bunch of obsolete patches from Christian Carlow like in
> https://issues.apache.org/jira/browse/OFBIZ-6418 and related (from there)
> >>
> >> I suggest we close all of them as won't do and will do so in 1 week
> >>
> >> Jacques
> >>
>
-- 
Sent from my phone

Re: Welcome to Mathieu Lirzin as new committer!

[Shi Jinghai]

Congratulations Mathieu!

Cheers,


-邮件原件-
发件人: Taher Alkhateeb [mailto:ta...@apache.org] 
发送时间: 2019年2月20日 1:16
收件人: OFBiz development mailing list
主题: Welcome to Mathieu Lirzin as new committer!

The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
we are happy to announce that he has accepted this role.

Some of the reasons for inviting Mathieu include:

- He is invested in the OFBiz project and has delivered substantial
work to the code base.
- He has demonstrated solid technical skills.
- He adopts a professional attitude towards coding and software development.
- He engages thoughtfully with others and likes to work with the community.

Please join me in welcoming and congratulating Mathieu!

Cheers,
Taher Alkhateeb

Re: Enabling HTTP/2 in the embedded Tomcat connectors

[Jacques Le Roux]

Good question, I guess most are OK, but what are Trailer Headers for instance?

BTW https://tomcat.apache.org/tomcat-9.0-doc/config/http2.html is our reference 
for the trunk

Jacques

Le 19/02/2019 à 10:24, Taher Alkhateeb a écrit :

clean and simple implementation, +1

on a side note, I wonder if we need to set any of the http2 attributes
listed in [1] or whether the defaults are okay.

[1] https://tomcat.apache.org/tomcat-8.5-doc/config/http2.html

On Mon, Feb 18, 2019 at 5:58 PM Jacques Le Roux
 wrote:

Hi Jacopo,

Sounds good to me, we can always easily revert in case of unexpected issue 
anyway

Thanks

Jacques

Le 18/02/2019 à 11:43, Jacopo Cappellato a écrit :

Hi all,

I think it is time to enable the instance of Tomcat that is embedded in
OFBiz to communicate using the HTTP/2 protocol, when the client supports it.
For your review, before I commit, I am pasting here the patch that will
enable it (it is quite simple) .
In it I have enabled HTTP/2 by default, by setting upgradeProtocol=true, in
the http and https connectors (but they will continue to support also
HTTP/1.1); if the new property "upgradeProtocol", that I have introduced
for this specific purpose, is not set (as it would be the case in custom
configuration files) then the new protocol will not be enabled. Does the
approach look good to you?

Thanks,

Jacopo

PS: you can test it, for example, using curl:

curl -vso /dev/null --http2 http://localhost:8080


Index: framework/catalina/ofbiz-component.xml
===
--- framework/catalina/ofbiz-component.xml (revision 1853787)
+++ framework/catalina/ofbiz-component.xml (working copy)
@@ -99,6 +99,7 @@
   
   
   
+
   
   
   
@@ -128,6 +129,7 @@
   
   
   
+
   
   
   
@@ -183,6 +185,7 @@
   
   
   
+
   
   
   
@@ -194,6 +197,7 @@
   
   
   
+
   
   
   
Index:
framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
===
---
framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
(revision
1853787)
+++
framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
(working
copy)
@@ -63,6 +63,7 @@
   import org.apache.catalina.util.ServerInfo;
   import org.apache.catalina.valves.AccessLogValve;
   import org.apache.catalina.webresources.StandardRoot;
+import org.apache.coyote.http2.Http2Protocol;
   import org.apache.ofbiz.base.component.ComponentConfig;
   import org.apache.ofbiz.base.concurrent.ExecutionPool;
   import org.apache.ofbiz.base.container.Container;
@@ -417,9 +418,12 @@
   private Connector prepareConnector(Property connectorProp) {
   Connector connector = new
Connector(ContainerConfig.getPropertyValue(connectorProp, "protocol",
"HTTP/1.1"));
   connector.setPort(ContainerConfig.getPropertyValue(connectorProp,
"port", 0) + Start.getInstance().getConfig().portOffset);
-
+if ("true".equals(ContainerConfig.getPropertyValue(connectorProp,
"upgradeProtocol", "false"))) {
+connector.addUpgradeProtocol(new Http2Protocol());
+Debug.logInfo("Tomcat " + connector + ": enabled HTTP/2",
module);
+}
   connectorProp.properties.values().stream()
-.filter(prop -> !"protocol".equals(prop.name) &&
!"port".equals(prop.name))
+.filter(prop -> !"protocol".equals(prop.name) &&
!"upgradeProtocol".equals(prop.name) && !"port".equals(prop.name))
   .forEach(prop -> {
   if (IntrospectionUtils.setProperty(connector, prop.name,
prop.value)) {
   if (prop.name.indexOf("Pass") != -1) {

Re: Welcome to Mathieu Lirzin as new committer!

[Jacques Le Roux]

Well deserved, welcome Mathieu!

Now a lot of commits are waiting for you ;)

Jacques

Le 19/02/2019 à 18:17, Deepak Dixit a écrit :

Many Many Congratulations Mathieu.
Welcome Aboard!!

Kind Regards,
Deepak Dixit

On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:


The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
we are happy to announce that he has accepted this role.

Some of the reasons for inviting Mathieu include:

- He is invested in the OFBiz project and has delivered substantial
work to the code base.
- He has demonstrated solid technical skills.
- He adopts a professional attitude towards coding and software
development.
- He engages thoughtfully with others and likes to work with the community.

Please join me in welcoming and congratulating Mathieu!

Cheers,
Taher Alkhateeb

Re: Pending works from Christian Carlow

[Jacques Le Roux]

I agree about the value of these Jiras.

What do you mean/think-about exactly by

   <>

?

Is Michael's answer sufficient? You can indeed search for Christian's closed 
Jira with patches.

Jacques

Le 19/02/2019 à 16:20, Taher Alkhateeb a écrit :

+1

It would be nice to highlight somehow the tickets that have patches as
I can see some value in the work in these JIRAs.

On Tue, Feb 19, 2019 at 4:22 PM Jacques Le Roux
 wrote:

Hi,

There are a bunch of obsolete patches from Christian Carlow like in 
https://issues.apache.org/jira/browse/OFBIZ-6418 and related (from there)

I suggest we close all of them as won't do and will do so in 1 week

Jacques

Re: Welcome to Mathieu Lirzin as new committer!

[Deepak Dixit]

Many Many Congratulations Mathieu.
Welcome Aboard!!

Kind Regards,
Deepak Dixit

On Tue, Feb 19, 2019 at 10:46 PM Taher Alkhateeb  wrote:

> The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> we are happy to announce that he has accepted this role.
>
> Some of the reasons for inviting Mathieu include:
>
> - He is invested in the OFBiz project and has delivered substantial
> work to the code base.
> - He has demonstrated solid technical skills.
> - He adopts a professional attitude towards coding and software
> development.
> - He engages thoughtfully with others and likes to work with the community.
>
> Please join me in welcoming and congratulating Mathieu!
>
> Cheers,
> Taher Alkhateeb
>

Welcome to Mathieu Lirzin as new committer!

[Taher Alkhateeb]

The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
we are happy to announce that he has accepted this role.

Some of the reasons for inviting Mathieu include:

- He is invested in the OFBiz project and has delivered substantial
work to the code base.
- He has demonstrated solid technical skills.
- He adopts a professional attitude towards coding and software development.
- He engages thoughtfully with others and likes to work with the community.

Please join me in welcoming and congratulating Mathieu!

Cheers,
Taher Alkhateeb

Re: Pending works from Christian Carlow

[Michael Brohl]

Hi Taher,

you can search for issues with status "Patch available" ;-)

Best regards,

Michael


Am 19.02.19 um 16:20 schrieb Taher Alkhateeb:

+1

It would be nice to highlight somehow the tickets that have patches as
I can see some value in the work in these JIRAs.

On Tue, Feb 19, 2019 at 4:22 PM Jacques Le Roux
 wrote:

Hi,

There are a bunch of obsolete patches from Christian Carlow like in 
https://issues.apache.org/jira/browse/OFBIZ-6418 and related (from there)

I suggest we close all of them as won't do and will do so in 1 week

Jacques





smime.p7s
Description: S/MIME Cryptographic Signature

Re: Pending works from Christian Carlow

[Taher Alkhateeb]

+1

It would be nice to highlight somehow the tickets that have patches as
I can see some value in the work in these JIRAs.

On Tue, Feb 19, 2019 at 4:22 PM Jacques Le Roux
 wrote:
>
> Hi,
>
> There are a bunch of obsolete patches from Christian Carlow like in 
> https://issues.apache.org/jira/browse/OFBIZ-6418 and related (from there)
>
> I suggest we close all of them as won't do and will do so in 1 week
>
> Jacques
>

Pending works from Christian Carlow

[Jacques Le Roux]

Hi,

There are a bunch of obsolete patches from Christian Carlow like in 
https://issues.apache.org/jira/browse/OFBIZ-6418 and related (from there)

I suggest we close all of them as won't do and will do so in 1 week

Jacques

Re: Enabling HTTP/2 in the embedded Tomcat connectors

[Taher Alkhateeb]

clean and simple implementation, +1

on a side note, I wonder if we need to set any of the http2 attributes
listed in [1] or whether the defaults are okay.

[1] https://tomcat.apache.org/tomcat-8.5-doc/config/http2.html

On Mon, Feb 18, 2019 at 5:58 PM Jacques Le Roux
 wrote:
>
> Hi Jacopo,
>
> Sounds good to me, we can always easily revert in case of unexpected issue 
> anyway
>
> Thanks
>
> Jacques
>
> Le 18/02/2019 à 11:43, Jacopo Cappellato a écrit :
> > Hi all,
> >
> > I think it is time to enable the instance of Tomcat that is embedded in
> > OFBiz to communicate using the HTTP/2 protocol, when the client supports it.
> > For your review, before I commit, I am pasting here the patch that will
> > enable it (it is quite simple) .
> > In it I have enabled HTTP/2 by default, by setting upgradeProtocol=true, in
> > the http and https connectors (but they will continue to support also
> > HTTP/1.1); if the new property "upgradeProtocol", that I have introduced
> > for this specific purpose, is not set (as it would be the case in custom
> > configuration files) then the new protocol will not be enabled. Does the
> > approach look good to you?
> >
> > Thanks,
> >
> > Jacopo
> >
> > PS: you can test it, for example, using curl:
> >
> > curl -vso /dev/null --http2 http://localhost:8080
> >
> >
> > Index: framework/catalina/ofbiz-component.xml
> > ===
> > --- framework/catalina/ofbiz-component.xml (revision 1853787)
> > +++ framework/catalina/ofbiz-component.xml (working copy)
> > @@ -99,6 +99,7 @@
> >   
> >   
> >   
> > +
> >   
> >   
> >   
> > @@ -128,6 +129,7 @@
> >   
> >   
> >   
> > +
> >   
> >   
> >   
> > @@ -183,6 +185,7 @@
> >   
> >   
> >   
> > +
> >   
> >   
> >   
> > @@ -194,6 +197,7 @@
> >   
> >   
> >   
> > +
> >   
> >   
> >   
> > Index:
> > framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
> > ===
> > ---
> > framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
> > (revision
> > 1853787)
> > +++
> > framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
> > (working
> > copy)
> > @@ -63,6 +63,7 @@
> >   import org.apache.catalina.util.ServerInfo;
> >   import org.apache.catalina.valves.AccessLogValve;
> >   import org.apache.catalina.webresources.StandardRoot;
> > +import org.apache.coyote.http2.Http2Protocol;
> >   import org.apache.ofbiz.base.component.ComponentConfig;
> >   import org.apache.ofbiz.base.concurrent.ExecutionPool;
> >   import org.apache.ofbiz.base.container.Container;
> > @@ -417,9 +418,12 @@
> >   private Connector prepareConnector(Property connectorProp) {
> >   Connector connector = new
> > Connector(ContainerConfig.getPropertyValue(connectorProp, "protocol",
> > "HTTP/1.1"));
> >   connector.setPort(ContainerConfig.getPropertyValue(connectorProp,
> > "port", 0) + Start.getInstance().getConfig().portOffset);
> > -
> > +if ("true".equals(ContainerConfig.getPropertyValue(connectorProp,
> > "upgradeProtocol", "false"))) {
> > +connector.addUpgradeProtocol(new Http2Protocol());
> > +Debug.logInfo("Tomcat " + connector + ": enabled HTTP/2",
> > module);
> > +}
> >   connectorProp.properties.values().stream()
> > -.filter(prop -> !"protocol".equals(prop.name) &&
> > !"port".equals(prop.name))
> > +.filter(prop -> !"protocol".equals(prop.name) &&
> > !"upgradeProtocol".equals(prop.name) && !"port".equals(prop.name))
> >   .forEach(prop -> {
> >   if (IntrospectionUtils.setProperty(connector, prop.name,
> > prop.value)) {
> >   if (prop.name.indexOf("Pass") != -1) {
> >

Re: svn commit: r1853205 - /ofbiz/tools/rat-excludes.txt

[Jacques Le Roux]

Done

Jacques

Le 08/02/2019 à 11:49, Jacques Le Roux a écrit :

Did not work, not sure why, no more time, not a big deal, will see later

Le 08/02/2019 à 11:39, jler...@apache.org a écrit :

Author: jleroux
Date: Fri Feb  8 10:39:45 2019
New Revision: 1853205

URL: http://svn.apache.org/viewvc?rev=1853205&view=rev
Log:
Just noticed that some files in build/.gradle are reported as missing license
We don't care about what is happening during Gradle build, that's temporary

Modified:
 ofbiz/tools/rat-excludes.txt

Modified: ofbiz/tools/rat-excludes.txt
URL: 
http://svn.apache.org/viewvc/ofbiz/tools/rat-excludes.txt?rev=1853205&r1=1853204&r2=1853205&view=diff
==
--- ofbiz/tools/rat-excludes.txt (original)
+++ ofbiz/tools/rat-excludes.txt Fri Feb  8 10:39:45 2019
@@ -65,3 +65,4 @@ VERSION
  **/less.min.js
  **/SamplePricatTemplate_V1.1.xlsx
  **/framework/base/src/main/java/META-INF/**
+**/build/.gradle/**
\ No newline at end of file