Re: svn commit: r1867663 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml
Hi Deepak, Happy to see your commits in action. :) Just a minor suggestion, we put Jira ticket ID in separate line in commit log. Also, add colon ':' in Thanks statement. And since the ticket type is 'Improvement', it seems to me, we should use 'Improved' instead of 'Fixed'. Here is commit template for your quick reference https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template Following commit log template will help us in producing the monthly blog development details. Thanks for your cooperation. Best regards, Swapnil M Mane, ofbiz.apache.org On Sat, Sep 28, 2019 at 3:56 PM wrote: > Author: deepaknigam > Date: Sat Sep 28 10:26:09 2019 > New Revision: 1867663 > > URL: http://svn.apache.org/viewvc?rev=1867663=rev > Log: > Fixed: Serbian CommonEntityLabels for geo entity. (OFBIZ-11209) > Added missing entity label for Serbia. > Thanks Ulrich Heidfeld for your contribution. > > Modified: > > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > > Modified: > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > URL: > http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml?rev=1867663=1867662=1867663=diff > > == > --- > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > (original) > +++ > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > Sat Sep 28 10:26:09 2019 > @@ -8011,6 +8011,10 @@ > 圣皮埃尔和密克隆群岛 > è –çš®åŸƒçˆ¾å’Œå¯†å…‹éš†ç¾¤å³¶ > > + > +Serbien > +Serbia > + > > سان تومي وبرينسيبي > Sao Tome und Principe > > >
Re: buildbot failure in on ofbizTrunkFramework
This was due to the wrong invoiceContentTypeId set for the test testCreateSimpleTextContentForInvoice. Fixed at r1867673. -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Sat, Sep 28, 2019 at 6:12 PM wrote: > The Buildbot has detected a new failure on builder ofbizTrunkFramework > while building . Full details are available at: > https://ci.apache.org/builders/ofbizTrunkFramework/builds/1084 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf947_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkFrameworkCommit' triggered this build > Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1867666 > Blamelist: jleroux,pawan > > BUILD FAILED: failed shell_2 > > Sincerely, > -The Buildbot > > > >
[DISCUSSION] R16 and R17: email password issue and releases
Hi, As reported by Rashi Dhagat in OFBIZ-11215 "Email password is not working" in R16, and actually nor in R17. It has been fixed in trunk and R18 with OFBIZ-4361. As mentioned there, it's hard to backport to R17 not even speaking about R16! I wonder if a case like that would not make R16 deprecated and start to release R18, skipping R17. Of course if people has the time, the nerves and the guts to backport to R17 and R16 they are welcome What do you think? Jacques
Re: Improvements in ProductCategoryMember
Hi Suraj, This seems legit to me, I see no harm in it and can be helpful indeed. Jacques Le 25/09/2019 à 10:51, Suraj Khurana a écrit : Hello team, We should extend ProductCategoryMember with createdByUserLogin and createdDate fields. One use case is while creating a price rule/promotion and using category in it, anyone can modify products in the category, so these fields will help in recognizing the auditor of this change. Please share your thoughts on this. -- Best Regards, Suraj Khurana Technical Consultant *HotWax Systems* *Enterprise open source experts* cell: 96697-50002 http://www.hotwaxsystems.com
