Guideline translation definition and the application there of in service functions and widget element, o.a.

2022-01-29 Thread Pierre Smits 
Hi all,

Over the years, contributions of translation definitions and contributions
to apply or change translation definitions in field and other widgets have
led to heated right-vs-wrong debates between contributors in tickets and
elsewhere. In order to unify the community, to decrease the number of these
heated debates and bring us back to happy collaborating to improve OFBiz,
 I have writtena guideline regarding this subject.

This guideline can be found here:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=199533364

I invite all to evaluate this guideline and provide feedback

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz  since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory , PMC Member*

Anyone could have been you, whereas I've always been anyone.


On Fri, Jan 28, 2022 at 4:24 PM Daniel Watford  wrote:

> Hi Michael,
>
> Yes, those labels were intentional. My view was that introducing common
> labels in cases where there were previously no labels at all was an
> improvement.
>
> Had there already been specific labels in place, these would have been left
> alone.
>
> Summary of my review approach:
> - Changing from application specific labels to common labels is unlikely to
> be committed without good reason because of the risk of losing the original
> application's intention when translated to different languages.
> - Changes from no label at all to a common label seem reasonable since we
> have the potential benefit of already existing generic translations from
> the common label set.
>
> Of course there will be exceptions to every rule, but in this case I
> thought the changes appropriate and an improvement.
>
> Thanks,
>
> Dan.
>
>
> On Fri, 28 Jan 2022 at 14:38, Michael Brohl 
> wrote:
>
> > Hi Dan,
> >
> > is this commit intentional?
> >
> > It still has unwanted changes introducing titles with common labels
> > instead of specific labels (e.g. CommonLocation for jobLocation).
> >
> > Regards,
> >
> > Michael
> >
> >
> > Am 28.01.22 um 08:49 schrieb danwatf...@apache.org:
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > danwatford pushed a commit to branch trunk
> > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> > >
> > >
> > > The following commit(s) were added to refs/heads/trunk by this push:
> > >   new b2dd912  Improved: Recruitment screens updated to use Grid
> > rather than list forms (OFBIZ-11345)
> > > b2dd912 is described below
> > >
> > > commit b2dd912794f083a6176dbd581967e2f97c3c183a
> > > Author: Pierre Smits 
> > > AuthorDate: Fri Jan 28 08:49:01 2022 +0100
> > >
> > >  Improved: Recruitment screens updated to use Grid rather than list
> > forms (OFBIZ-11345)
> > >
> > >
> > >  According to the definition in widget-form.xsd the
> > >  use of a combination of a form with type="list" is
> > >  deprecated in favour of a grid. Therefore refactored various
> > >  Recruitment forms to use grid and updated references from
> > >  relevant screens to forms.
> > >
> > >  Thanks: Pierre Smits for changes.
> > > ---
> > >   .../humanres/widget/RecruitmentScreens.xml | 12 +++
> > >   .../humanres/widget/forms/RecruitmentForms.xml | 42
> > +++---
> > >   2 files changed, 26 insertions(+), 28 deletions(-)
> > >
> > > diff --git a/applications/humanres/widget/RecruitmentScreens.xml
> > b/applications/humanres/widget/RecruitmentScreens.xml
> > > index 7072f0a..2452265 100644
> > > --- a/applications/humanres/widget/RecruitmentScreens.xml
> > > +++ b/applications/humanres/widget/RecruitmentScreens.xml
> > > @@ -20,7 +20,7 @@ under the License.
> > >   http://www.w3.org/2001/XMLSchema-instance";
> > >   xmlns="http://ofbiz.apache.org/Widget-Screen";
> xsi:schemaLocation="
> > http://ofbiz.apache.org/Widget-Screen
> > http://ofbiz.apache.org/dtds/widget-screen.xsd";>
> > >   
> > > -
> > > +
> > >   
> > >> value="PageTitleFindJobRequisition"/>
> > >   
> > > @@ -54,7 +54,7 @@ under the License.
> > >> name="FindJobRequisitions"
> > location="component://humanres/widget/forms/RecruitmentForms.xml"/>
> > >   
> > >> name="search-results">
> > > - > name="ListJobRequisitions"
> > location="component://humanres/widget/forms/RecruitmentForms.xml"/>
> > > + > name="ListJobRequisitions"
> > location="component://humanres/widget/forms/RecruitmentForms.xml"/>
> > >   
> > >   
> > >   
> > > @@ -124,7 +124,7 @@ under the License.
> > >>

Re: [GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)

2022-01-29 Thread Jacques Le Roux 

Le 27/01/2022 à 15:57, Pierre Smits a écrit :

Playing the 'blame' game is detrimental to the success of the project, and
thus to all using, contributing, making a living with...


Hi Pierre,

It seems you don't understand why I put "is broken by" references from and in Jiras and 
GH. It's not at all to play the "blame game".

It to actually allow us to better understand what is happening from where in 
the past that can be useful in the future.

OFBIZ-7024 and OFBIZ-5341 are related examples that helped me in the task for OFBIZ-12548 that was eventually 
https://github.com/apache/ofbiz-framework/commit/7562476e1e7c6cf6bac2be96c74fcc2bf754a58d


HTH

Jacques