Re: Tenant and properties
Hi Jacques, unfortunately not yet, sorry for the delay. Hope to be able to get into it this week. Thanks and regards, Michael Am 12.09.22 um 11:26 schrieb Jacques Le Roux: Hi Michael, Did you get a chance? Thanks Jacques Le 03/09/2022 à 20:21, Michael Brohl a écrit : Hi Jacques, I will dig into this further in the next days. Thanks, Michael Am 30.08.22 um 11:28 schrieb Jacques Le Roux: Le 30/08/2022 à 10:20, Jacques Le Roux a écrit : Hi, It's a long time now I, from time to time, have a look at this issue. At some point I had at least 13 related links, remain open only: https://issues.apache.org/jira/browse/OFBIZ-7112 "EntityUtilProperties" https://issues.apache.org/jira/browse/OFBIZ-6712 "Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()" https://issues.apache.org/jira/browse/OFBIZ-7754 "The big problem when loading seed." https://issues.apache.org/jira/browse/OFBIZ-6164 "Improve configurability of OFBiz" And somehow related (to review when the rest is done): https://cwiki.apache.org/confluence/display/OFBIZ/Extension+in+Multitenancy+support https://cwiki.apache.org/confluence/display/OFBIZ/Multitenancy+support We discussed a lot about that (notably*) but did not decide about it. * https://markmail.org/message/md6fuoouan377c6w (look rather at bottom of the thread where some opinionated conclusions show) For OFBIZ-7754 I notably suggested (comment there https://s.apache.org/cyx1j):> But Michael is basically against that, see bottom of the thread (markmail) above. I don't think anybody is against changing from seed to seed-initial for CommonSystemPropertyData.xml rather than removing it as suggested by Hans (who created it). I mean maybe some users are relying on that now. Note that it goes in the direction I suggested above. Then, if nobody is against, I'll close OFBIZ-7754 (and hopefully other but 7112) and create a new Jira task to separate all properties as Hans did for CommonSystemPropertyData Afterward I'll get back to OFBIZ-7112 What do you think? Note that I'll not wait forever for opinions. It will not be longer than next week. TIA Jacques Regarding Michael's then reluctance, I already suggested a maybe solution: instead of using load-initial to load alike properties from files (those that can be tenant specific) we could create a load-tenant reader that would be only used if <> or if the user prefer using DB data instead of properties in file for all properties types (ie business and system) Michael, what do you think about that? Another option, somehow related, is to use Taher's suggestion and have all properties in a sole file as HTTPD does, I'm not much inclined to that. (It's only in my memories, I can't find a reference back) I have created https://issues.apache.org/jira/browse/OFBIZ-12689 "Separate business properties from system properties" https://issues.apache.org/jira/browse/OFBIZ-12688 "Change SystemProperty entity name to BusinessProperty" (depends upon 12689) Jacques
Re: Tenant and properties
Hi Michael, Did you get a chance? Thanks Jacques Le 03/09/2022 à 20:21, Michael Brohl a écrit : Hi Jacques, I will dig into this further in the next days. Thanks, Michael Am 30.08.22 um 11:28 schrieb Jacques Le Roux: Le 30/08/2022 à 10:20, Jacques Le Roux a écrit : Hi, It's a long time now I, from time to time, have a look at this issue. At some point I had at least 13 related links, remain open only: https://issues.apache.org/jira/browse/OFBIZ-7112 "EntityUtilProperties" https://issues.apache.org/jira/browse/OFBIZ-6712 "Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()" https://issues.apache.org/jira/browse/OFBIZ-7754 "The big problem when loading seed." https://issues.apache.org/jira/browse/OFBIZ-6164 "Improve configurability of OFBiz" And somehow related (to review when the rest is done): https://cwiki.apache.org/confluence/display/OFBIZ/Extension+in+Multitenancy+support https://cwiki.apache.org/confluence/display/OFBIZ/Multitenancy+support We discussed a lot about that (notably*) but did not decide about it. * https://markmail.org/message/md6fuoouan377c6w (look rather at bottom of the thread where some opinionated conclusions show) For OFBIZ-7754 I notably suggested (comment there https://s.apache.org/cyx1j): <> But Michael is basically against that, see bottom of the thread (markmail) above. I don't think anybody is against changing from seed to seed-initial for CommonSystemPropertyData.xml rather than removing it as suggested by Hans (who created it). I mean maybe some users are relying on that now. Note that it goes in the direction I suggested above. Then, if nobody is against, I'll close OFBIZ-7754 (and hopefully other but 7112) and create a new Jira task to separate all properties as Hans did for CommonSystemPropertyData Afterward I'll get back to OFBIZ-7112 What do you think? Note that I'll not wait forever for opinions. It will not be longer than next week. TIA Jacques Regarding Michael's then reluctance, I already suggested a maybe solution: instead of using load-initial to load alike properties from files (those that can be tenant specific) we could create a load-tenant reader that would be only used if <> or if the user prefer using DB data instead of properties in file for all properties types (ie business and system) Michael, what do you think about that? Another option, somehow related, is to use Taher's suggestion and have all properties in a sole file as HTTPD does, I'm not much inclined to that. (It's only in my memories, I can't find a reference back) I have created https://issues.apache.org/jira/browse/OFBIZ-12689 "Separate business properties from system properties" https://issues.apache.org/jira/browse/OFBIZ-12688 "Change SystemProperty entity name to BusinessProperty" (depends upon 12689) Jacques
MySql8 issue with add missing on start
While working with mysql 8 database faced an issue with new ofbiz setup, ofbiz fails to add new tables in database, Environment Database server : mysql 8 Database drive : mysql 8.0.30 Steps to regenerate: - Create new database named ofbiz, configure it with ofbiz and load data (everything working fine) - Create another database named ofbiz1, configure it with ofbiz and load data This process will fails After initial debugging found while check db DatabaseMetaData.getTables returns a list of tables from the existing database, so it does not create new tables hence fails to load data. Created PR for the same [1], need to verify these changes with other databases as well, as it may fail with others. [1] https://github.com/apache/ofbiz-framework/pull/543/files [2] https://stackoverflow.com/questions/7942520/relationship-between-catalog-schema-user-and-database-instance Thanks & Regards -- Deepak Dixit ofbiz.apache.org
