[jira] [Commented] (OFBIZ-4291) No method to remove a promo code from the shopping cart
[
https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701290#comment-13701290
]
Ankit Jain commented on OFBIZ-4291:
---
Hi Nandani,
I got your question, we need to update the method to deal with all the rules,
like in your case if its a gift that will be added in cart, so we have to
remove that product if we unapply the promotion.
We need to write the logic to handle all the rules. And if someone upapply the
promotion then remove the product or discount accordingly, based on the rules
in the promotion.
I'll try to find some time to give one more patch which handles all the rules
in the promotion. Or you can also contribute, if you are planning.
Thanks.
No method to remove a promo code from the shopping cart
---
Key: OFBIZ-4291
URL: https://issues.apache.org/jira/browse/OFBIZ-4291
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: Release Branch 10.04
Reporter: Glyton Camilleri
Assignee: Jacques Le Roux
Fix For: SVN trunk
Attachments: unapplyPromotion.txt, Updated-Ofbiz-4291.patch,
Updated-Ofbiz-4291.patch
Hi,
When working with promotions and promo codes in the shopping cart, it seems
not possible to remove _one_ specific promo code from the cart neither
through the ShoppingCart and its helpers and services, nor through the
ProductPromoWorker.
ShoppingCart has the method
{{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
but no method to remove the added PromoCode. Is there any other worker,
service or event that can be called to do this? And if not, is there a
specifc reason (maybe relating to promotions application rules) for not
implementing this?
Any response is appreciated.
Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5225) The Invoice Item type dropdown have same description for different invoiceItemTypeId.
[ https://issues.apache.org/jira/browse/OFBIZ-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689245#comment-13689245 ] Ankit Jain commented on OFBIZ-5225: --- Thanks Jacques :) The Invoice Item type dropdown have same description for different invoiceItemTypeId. - Key: OFBIZ-5225 URL: https://issues.apache.org/jira/browse/OFBIZ-5225 Project: OFBiz Issue Type: Wish Components: accounting Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5225.patch, Updated-OFBIZ-5225.patch The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting. https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1 The description should be different that the invoiceItemType is for sales or purchase. Eg: Invoice Fee(Sales) Invoice Fee(Purchase) Something to differentiate between the same description. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5225) The Invoice Item type dropdown have same description for different invoiceItemTypeId.
[ https://issues.apache.org/jira/browse/OFBIZ-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5225: -- Attachment: Updated-OFBIZ-5225.patch Thanks Jacques, for the suggestion. Here is the updated the patch. The Invoice Item type dropdown have same description for different invoiceItemTypeId. - Key: OFBIZ-5225 URL: https://issues.apache.org/jira/browse/OFBIZ-5225 Project: OFBiz Issue Type: Wish Components: accounting Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5225.patch, Updated-OFBIZ-5225.patch The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting. https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1 The description should be different that the invoiceItemType is for sales or purchase. Eg: Invoice Fee(Sales) Invoice Fee(Purchase) Something to differentiate between the same description. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5230) Priority field is missing on Add/Edit Project form.
[ https://issues.apache.org/jira/browse/OFBIZ-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688096#comment-13688096 ] Ankit Jain commented on OFBIZ-5230: --- Thanks Jacques :) Priority field is missing on Add/Edit Project form. --- Key: OFBIZ-5230 URL: https://issues.apache.org/jira/browse/OFBIZ-5230 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Trivial Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5230.patch Priority field is missing on Add/Edit Project form. https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProject -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4291) No method to remove a promo code from the shopping cart
[
https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686713#comment-13686713
]
Ankit Jain commented on OFBIZ-4291:
---
Thanks Jacques. :)
No method to remove a promo code from the shopping cart
---
Key: OFBIZ-4291
URL: https://issues.apache.org/jira/browse/OFBIZ-4291
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: Release Branch 10.04
Reporter: Glyton Camilleri
Assignee: Jacques Le Roux
Fix For: SVN trunk
Attachments: unapplyPromotion.txt, Updated-Ofbiz-4291.patch,
Updated-Ofbiz-4291.patch
Hi,
When working with promotions and promo codes in the shopping cart, it seems
not possible to remove _one_ specific promo code from the cart neither
through the ShoppingCart and its helpers and services, nor through the
ProductPromoWorker.
ShoppingCart has the method
{{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
but no method to remove the added PromoCode. Is there any other worker,
service or event that can be called to do this? And if not, is there a
specifc reason (maybe relating to promotions application rules) for not
implementing this?
Any response is appreciated.
Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5230) Prioity field is missing on Add/Edit Project form.
Ankit Jain created OFBIZ-5230: - Summary: Prioity field is missing on Add/Edit Project form. Key: OFBIZ-5230 URL: https://issues.apache.org/jira/browse/OFBIZ-5230 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk, Release Branch 12.04 Prioity field is missing on Add/Edit Project form. https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProject -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5230) Prioity field is missing on Add/Edit Project form.
[ https://issues.apache.org/jira/browse/OFBIZ-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5230: -- Attachment: OFBIZ-5230.patch Attached patch fix the issue. Thanks Prioity field is missing on Add/Edit Project form. -- Key: OFBIZ-5230 URL: https://issues.apache.org/jira/browse/OFBIZ-5230 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5230.patch Prioity field is missing on Add/Edit Project form. https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProject -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5230) Priority field is missing on Add/Edit Project form.
[ https://issues.apache.org/jira/browse/OFBIZ-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5230: -- Description: Priority field is missing on Add/Edit Project form. https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProject was: Prioity field is missing on Add/Edit Project form. https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProject Summary: Priority field is missing on Add/Edit Project form. (was: Prioity field is missing on Add/Edit Project form.) Priority field is missing on Add/Edit Project form. --- Key: OFBIZ-5230 URL: https://issues.apache.org/jira/browse/OFBIZ-5230 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5230.patch Priority field is missing on Add/Edit Project form. https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProject -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5225) The Invoice Item type dropdown have same description for different invoiceItemTypeId.
Ankit Jain created OFBIZ-5225: - Summary: The Invoice Item type dropdown have same description for different invoiceItemTypeId. Key: OFBIZ-5225 URL: https://issues.apache.org/jira/browse/OFBIZ-5225 Project: OFBiz Issue Type: Wish Components: accounting Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting. https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1 The description should be different that the invoiceItemType is for sales or purchase. Eg: Invoice Fee(Sales) Invoice Fee(Purchase) Something to differentiate between the same description. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5225) The Invoice Item type dropdown have same description for different invoiceItemTypeId.
[ https://issues.apache.org/jira/browse/OFBIZ-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5225: -- Attachment: OFBIZ-5225.patch Attached a patch, modified the description for Invoice Item Type. Thanks The Invoice Item type dropdown have same description for different invoiceItemTypeId. - Key: OFBIZ-5225 URL: https://issues.apache.org/jira/browse/OFBIZ-5225 Project: OFBiz Issue Type: Wish Components: accounting Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5225.patch The Invoice Item type dropdown have same description for different invoiceItemTypeId on Agreement Terms page in accounting. https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=1 The description should be different that the invoiceItemType is for sales or purchase. Eg: Invoice Fee(Sales) Invoice Fee(Purchase) Something to differentiate between the same description. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5222) No the date fields showning on edit project page.
[ https://issues.apache.org/jira/browse/OFBIZ-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682135#comment-13682135 ] Ankit Jain commented on OFBIZ-5222: --- Jacques, I am sure. Don't check for existing projects, create a new project then try to edit project there will be no fields for dates, and same on project summary page no dates were shown because they are not set in projectInfo in getProject service. I have just created a project please have a look. https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/EditProject?projectId=1 Thanks. No the date fields showning on edit project page. - Key: OFBIZ-5222 URL: https://issues.apache.org/jira/browse/OFBIZ-5222 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Critical Fix For: SVN trunk Attachments: OFBIZ-5222.patch No date fields are showing on Edit project page(https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/EditProject?projectId=10005) for the following: Estimated Start Date Estimated Completion Date Actual Start Date Actual Completion Date Also on the Project Summary page no dates are showing in Project Information. https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/projectView?projectId=10005 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5222) No the date fields showning on edit project page.
[ https://issues.apache.org/jira/browse/OFBIZ-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5222: -- Attachment: Updated-OFBIZ-5222.patch Yes, its a typo. Here is the updated patch. Thanks Jacques for looking into it. No the date fields showning on edit project page. - Key: OFBIZ-5222 URL: https://issues.apache.org/jira/browse/OFBIZ-5222 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Critical Fix For: SVN trunk Attachments: OFBIZ-5222.patch, Updated-OFBIZ-5222.patch No date fields are showing on Edit project page(https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/EditProject?projectId=10005) for the following: Estimated Start Date Estimated Completion Date Actual Start Date Actual Completion Date Also on the Project Summary page no dates are showing in Project Information. https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/projectView?projectId=10005 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5222) No date fields showning on edit project page.
[ https://issues.apache.org/jira/browse/OFBIZ-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5222: -- Summary: No date fields showning on edit project page. (was: No the date fields showning on edit project page.) No date fields showning on edit project page. - Key: OFBIZ-5222 URL: https://issues.apache.org/jira/browse/OFBIZ-5222 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Critical Fix For: SVN trunk Attachments: OFBIZ-5222.patch, Updated-OFBIZ-5222.patch No date fields are showing on Edit project page(https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/EditProject?projectId=10005) for the following: Estimated Start Date Estimated Completion Date Actual Start Date Actual Completion Date Also on the Project Summary page no dates are showing in Project Information. https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/projectView?projectId=10005 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5222) No date fields showning on edit project page.
[ https://issues.apache.org/jira/browse/OFBIZ-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682410#comment-13682410 ] Ankit Jain commented on OFBIZ-5222: --- Thanks Jacques :) No date fields showning on edit project page. - Key: OFBIZ-5222 URL: https://issues.apache.org/jira/browse/OFBIZ-5222 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Critical Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5222.patch, Updated-OFBIZ-5222.patch No date fields are showing on Edit project page(https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/EditProject?projectId=10005) for the following: Estimated Start Date Estimated Completion Date Actual Start Date Actual Completion Date Also on the Project Summary page no dates are showing in Project Information. https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/projectView?projectId=10005 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5222) No the date fields showning on edit project page.
Ankit Jain created OFBIZ-5222: - Summary: No the date fields showning on edit project page. Key: OFBIZ-5222 URL: https://issues.apache.org/jira/browse/OFBIZ-5222 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Critical Fix For: SVN trunk No date fields are showing on Edit project page(https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/EditProject?projectId=10005) for the following: Estimated Start Date Estimated Completion Date Actual Start Date Actual Completion Date Also on the Project Summary page no dates are showing in Project Information. https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/projectView?projectId=10005 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5222) No the date fields showning on edit project page.
[ https://issues.apache.org/jira/browse/OFBIZ-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5222: -- Attachment: OFBIZ-5222.patch Attached patch fixed the issue. Thanks. No the date fields showning on edit project page. - Key: OFBIZ-5222 URL: https://issues.apache.org/jira/browse/OFBIZ-5222 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Critical Fix For: SVN trunk Attachments: OFBIZ-5222.patch No date fields are showing on Edit project page(https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/EditProject?projectId=10005) for the following: Estimated Start Date Estimated Completion Date Actual Start Date Actual Completion Date Also on the Project Summary page no dates are showing in Project Information. https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/projectView?projectId=10005 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4983) New feature to reclaim a user account - Using Security Questions
[ https://issues.apache.org/jira/browse/OFBIZ-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673162#comment-13673162 ] Ankit Jain commented on OFBIZ-4983: --- Hi Harsha, Thanks for the updated patch found few nits :) I have checked with the latest patch, 1) get an error [component://common/webcommon/getSecurityQuestion.ftl]: java.io.FileNotFoundException. Added manually from previous patch. 2) Trying to click on the Reset Password link in the mail but it's not working. Then modified the code and again changed it to submit button. After clicking on the button, entered the new password, answered the question and the password changed and I logged in. Finally worked fine after these changes. Thanks Sumit for the clarification. For security purpose asking the security question at both the end is ok. As you said for Reset password the current password is required and in the current system also auto-generated password is send on mail. I think for changing password[https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/ProfileEditUserLogin?partyId=adminuserLoginId=admin] current password should be required but not for the Reset password because we came from forgot password, user don't remember his/her password so he/she wants to Reset the password. And we don't need to send the current password as a hidden parameter. IMHO we should write a different service to handle reset password case we should not send the password in the mail. WDYT? Or we can create a different jira issue for this. Suggestions?? Thanks! New feature to reclaim a user account - Using Security Questions Key: OFBIZ-4983 URL: https://issues.apache.org/jira/browse/OFBIZ-4983 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Harsha Chadhar Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 1.png, 2.png, 3.png, 4.png, 5.png, OFBIZ-4983.patch, OFBIZ-4983.patch *Referring to Vikas's proposed model on Reclaiming User Account using security questions as follows :* When a customer create an account on eCommerce site, he will also need to answer few security questions. We can enforce restriction on the minimum number of questions that must be answered by a user before creating his profile successfully, through some configurations which are discussed in the next section. These security questions then can be used to reclaim the customer account in case he forget his password. User can also be given a choice to add his own custom questions and this would be enable/disabled again through some configurations. If the user correctly answer minimum required questions while reclaiming his account, password will be send through email notifications. This part would work in the same way as the existing functionality of email password (forget password). We would probably need the screens to configures 1) Security Question in the system. These questions will be called as Standard security questions and can only be entered by an admin (or a person with similar sort of privileges). These questions will be available to every user who create or update his profile. 2) Giving user an option to create his own custom security questions. A configuration/property that would determine whether this option is available to the user or not. These questions will be called as Custom security questions and can entered only by a user while creating or updating a profile. These questions will be available and applicable only to the owner of the questions, i.e the user who create these questions. 3) Minimum number of questions that are required to answer. This configuration/property would determine minimum number of questions that a user must answer while creating an account and as well as reclaiming an account. I think we can save above (#1, #2) configuration in database and provide screens to configure them. IMO, these configuration can be also called as a security configuration, since they are some how related to security. At this moment I have not much idea about where these sort of configuration should be saved but this could be part of the entity that saves the security configurations (which does not exist at this moment). In recent days certain properties are moved to entities and this could certainly be the done with security properties at certain point of time, until then these configuration can be kept under security properties file. Custom Data Model: The new entities that would be required for this feature are following (Scott did help in improving the data model few months back):
[jira] [Comment Edited] (OFBIZ-4983) New feature to reclaim a user account - Using Security Questions
[ https://issues.apache.org/jira/browse/OFBIZ-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673162#comment-13673162 ] Ankit Jain edited comment on OFBIZ-4983 at 6/3/13 2:42 PM: --- Hi Harsha, Thanks for the updated patch found few nits :) I have checked with the latest patch, 1) get an error [component://common/webcommon/getSecurityQuestion.ftl]: java.io.FileNotFoundException. Added manually from previous patch. File is missing in the lastest patch. 2) Trying to click on the Reset Password link in the mail but it's not working. Then modified the code and again changed it to submit button. After clicking on the button, entered the new password, answered the question and the password changed I logged in successfully. Finally worked fine after these changes. Thanks Sumit for the clarification. For security purpose asking the security question at both the end is ok. As you said for Reset password the current password is required and in the current system also auto-generated password is send on mail. I think for changing password[https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/ProfileEditUserLogin?partyId=adminuserLoginId=admin] current password should be required but not for the Reset password because we came from forgot password, user don't remember his/her password so he/she wants to Reset the password. And we don't need to send the current password as a hidden parameter. IMHO we should write a different service to handle reset password case we should not send the password in the mail. WDYT? Or we can create a different jira issue for this. Suggestions?? Thanks! was (Author: ankit.jain): Hi Harsha, Thanks for the updated patch found few nits :) I have checked with the latest patch, 1) get an error [component://common/webcommon/getSecurityQuestion.ftl]: java.io.FileNotFoundException. Added manually from previous patch. 2) Trying to click on the Reset Password link in the mail but it's not working. Then modified the code and again changed it to submit button. After clicking on the button, entered the new password, answered the question and the password changed and I logged in. Finally worked fine after these changes. Thanks Sumit for the clarification. For security purpose asking the security question at both the end is ok. As you said for Reset password the current password is required and in the current system also auto-generated password is send on mail. I think for changing password[https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/ProfileEditUserLogin?partyId=adminuserLoginId=admin] current password should be required but not for the Reset password because we came from forgot password, user don't remember his/her password so he/she wants to Reset the password. And we don't need to send the current password as a hidden parameter. IMHO we should write a different service to handle reset password case we should not send the password in the mail. WDYT? Or we can create a different jira issue for this. Suggestions?? Thanks! New feature to reclaim a user account - Using Security Questions Key: OFBIZ-4983 URL: https://issues.apache.org/jira/browse/OFBIZ-4983 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Harsha Chadhar Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 1.png, 2.png, 3.png, 4.png, 5.png, OFBIZ-4983.patch, OFBIZ-4983.patch *Referring to Vikas's proposed model on Reclaiming User Account using security questions as follows :* When a customer create an account on eCommerce site, he will also need to answer few security questions. We can enforce restriction on the minimum number of questions that must be answered by a user before creating his profile successfully, through some configurations which are discussed in the next section. These security questions then can be used to reclaim the customer account in case he forget his password. User can also be given a choice to add his own custom questions and this would be enable/disabled again through some configurations. If the user correctly answer minimum required questions while reclaiming his account, password will be send through email notifications. This part would work in the same way as the existing functionality of email password (forget password). We would probably need the screens to configures 1) Security Question in the system. These questions will be called as Standard security questions and can only be entered by an admin (or a person with similar sort of privileges). These questions will be available to every user who
[jira] [Commented] (OFBIZ-4983) New feature to reclaim a user account - Using Security Questions
[
https://issues.apache.org/jira/browse/OFBIZ-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672482#comment-13672482
]
Ankit Jain commented on OFBIZ-4983:
---
Hi,
This is a good feature to add in ofbiz.
I have applied your patch, and tested it by loading the enumeration data,
security question displayed and the party is created. Then on the forgot
password gave the answer of security question and clicked on send password.
I received an email with a button to reset password. It takes me to change
password page. I have entered the new password and answer the security
question. On clicking on submit it redirects me to the same change password
page and the password not changed. On console I get some error :
[Java] Expression parameters.password is undefined on line 39, column 63 in
component://common/webcommon/changePassword.ftl.
[java] The problematic instruction:
[java] --
[java] == ${parameters.password} [on line 39, column 61 in
component://common/webcommon/changePassword.ftl]
[java] --
[java]
[java] Java backtrace for programmers:
[java] --
[java] freemarker.core.InvalidReferenceException: Expression
parameters.password is undefined on line 39, column 63 in
component://common/webcommon/changePassword.ftl.
[java] at
freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:125)
[java] at freemarker.core.Expression.getStringValue(Expression.java:118)
[java] at freemarker.core.Expression.getStringValue(Expression.java:93)
[java] at freemarker.core.DollarVariable.accept(DollarVariable.java:76)
[java] at freemarker.core.Environment.visit(Environment.java:221)
[java] at freemarker.core.MixedContent.accept(MixedContent.java:92)
[java] at freemarker.core.Environment.visit(Environment.java:221)
[java] at freemarker.core.IfBlock.accept(IfBlock.java:82)
[java] at freemarker.core.Environment.visit(Environment.java:221)
[java] at freemarker.core.MixedContent.accept(MixedContent.java:92)
[java] at freemarker.core.Environment.visit(Environment.java:221)
[java] at freemarker.core.Environment.process(Environment.java:199)
Please have a look I have applied your patch on trunk.
Few suggestions :
1) Instead of giving button there should be a reset password link in the mail,
which is generally followed everywhere.
2) When click on the button(Reset password) in the mail it redirects me to
change password page, so here again asking the security question is redundant.
Because at the time of forgot password the one has already answered the
question.
IMO we should not send the old password in the mail as a hidden field, we
should handle this at our end. Then we also don't need to decrypt the password
here.
Rest the feature is good and should have in ofbiz and other things and code
looks good to me.
Thanks Harsha for working on this.
Thanks Regards,
Ankit
New feature to reclaim a user account - Using Security Questions
Key: OFBIZ-4983
URL: https://issues.apache.org/jira/browse/OFBIZ-4983
Project: OFBiz
Issue Type: New Feature
Components: framework
Affects Versions: SVN trunk
Reporter: Harsha Chadhar
Assignee: Jacques Le Roux
Fix For: SVN trunk
Attachments: 1.png, 2.png, 3.png, 4.png, 5.png, OFBIZ-4983.patch,
OFBIZ-4983.patch
*Referring to Vikas's proposed model on Reclaiming User Account using
security questions as follows :*
When a customer create an account on eCommerce site, he will also
need to answer few security questions. We can enforce restriction on
the minimum number of questions that must be answered by a user before
creating his profile successfully, through some configurations which
are discussed in the next section. These security questions then can
be used to reclaim the customer account in case he forget his
password. User can also be given a choice to add his own custom
questions and this would be enable/disabled again through some
configurations.
If the user correctly answer minimum required questions while
reclaiming his account, password will be send through email
notifications. This part would work in the same way as the existing
functionality of email password (forget password).
We would probably need the screens to configures
1) Security Question in the system.
These questions will be called as Standard security questions and can
only be entered by an admin (or a person with similar sort of
privileges). These questions will be available to every user who
create or update his profile.
2) Giving user an option to create his own custom security questions.
A configuration/property that would determine whether this option is
available to the user or not. These
[jira] [Commented] (OFBIZ-5206) User is redirected to showcart page when any error comes on checkout page.
[ https://issues.apache.org/jira/browse/OFBIZ-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671211#comment-13671211 ] Ankit Jain commented on OFBIZ-5206: --- To reproduce the issue, Goto OrderEntry - Add any product to cart - click on Quick finalize order now select shipping address shipping method but don't select any payment option and now click on Continue to Final Order Review link. You will be redirected to showcart page and with a error message. Please select a method of payment. And expected behaviour is to show the error message on the same checkout page. Thanks. User is redirected to showcart page when any error comes on checkout page. -- Key: OFBIZ-5206 URL: https://issues.apache.org/jira/browse/OFBIZ-5206 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-5206.patch On checkout page if any error comes it redirects user back to showcart page with an error message. Expected : Error should be shown on the same page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4161) CheckOutEvents setCheckOutPages
[ https://issues.apache.org/jira/browse/OFBIZ-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671215#comment-13671215 ] Ankit Jain commented on OFBIZ-4161: --- Hi Jacques, Here I mean without applying the Stephen's patch things are already working fine. If payment is not selected then an error message is shown. CheckOutEvents setCheckOutPages --- Key: OFBIZ-4161 URL: https://issues.apache.org/jira/browse/OFBIZ-4161 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 10.04, SVN trunk Environment: Win XP Reporter: Stephen Rufle Assignee: Jacques Le Roux Priority: Minor Attachments: OFBIZ-4161.patch There is an extra check in CheckOutEvents.setCheckOutPages that prevents an error message from being produced when no payment method is selected on the How shall you pay step of the checkout process. The screen just flashes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5206) User is redirected to showcart page when any error comes on checkout page.
[ https://issues.apache.org/jira/browse/OFBIZ-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671472#comment-13671472 ] Ankit Jain commented on OFBIZ-5206: --- Thanks Jacques :) User is redirected to showcart page when any error comes on checkout page. -- Key: OFBIZ-5206 URL: https://issues.apache.org/jira/browse/OFBIZ-5206 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Trivial Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-5206.patch On checkout page if any error comes it redirects user back to showcart page with an error message. Expected : Error should be shown on the same page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4291) No method to remove a promo code from the shopping cart
[
https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Jain updated OFBIZ-4291:
--
Attachment: Updated-Ofbiz-4291.patch
Hi Jacques,
I have updated the patch.
Thanks for your time.
No method to remove a promo code from the shopping cart
---
Key: OFBIZ-4291
URL: https://issues.apache.org/jira/browse/OFBIZ-4291
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: Release Branch 10.04
Reporter: Glyton Camilleri
Attachments: unapplyPromotion.txt, Updated-Ofbiz-4291.patch,
Updated-Ofbiz-4291.patch
Hi,
When working with promotions and promo codes in the shopping cart, it seems
not possible to remove _one_ specific promo code from the cart neither
through the ShoppingCart and its helpers and services, nor through the
ProductPromoWorker.
ShoppingCart has the method
{{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
but no method to remove the added PromoCode. Is there any other worker,
service or event that can be called to do this? And if not, is there a
specifc reason (maybe relating to promotions application rules) for not
implementing this?
Any response is appreciated.
Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5201) Find Order functions - Not working when junk values entered for product Id
[ https://issues.apache.org/jira/browse/OFBIZ-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670332#comment-13670332 ] Ankit Jain commented on OFBIZ-5201: --- Hi Guys, Thanks Parimal for the patch. I have tested the patch and changes working fine and looks good to me. Thanks. Find Order functions - Not working when junk values entered for product Id -- Key: OFBIZ-5201 URL: https://issues.apache.org/jira/browse/OFBIZ-5201 Project: OFBiz Issue Type: Bug Components: order Reporter: Parimal Gain Priority: Minor Labels: order Attachments: OFBIZ-5201.patch Problem specification and step - 1) Go to Order Manager app Find Orders 2) Enter valid product id for which order exists 3) Relevant orders with entered product value would be shown in search results 4) Enter invalid product id - JUNK value 5) Error behvaior:All orders on the system would be highlighted 6) Actual behavior: No order should be shown as search results, as no order exists with this JUNK product id on system Observation - When looked into code level found that system apply check for two condition - 1) If passes productId starts or ends with % or * then add that in condition list as it is and it returns all order that contains the word for product Ids. 2) If the above condition is failed the check if the product corresponding to product id is present or not. 3) If exists then check for variants (if its virtual)all this. 4) If product not exists then the action is missing i.e. no condition is added and it returns all order available. Recommendation - There are two ways to solve the issue - 1) If product corresponding to passes productId is not present then return message to user that order is not present. 2) If the thought process for current behavior is show all record if product not available then user should get a message as well that Order is not available for your search product but we have all these order in system to convey the correct message to user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4190) Creating return from Sales Order having more than 1 item creates payment with amount of First item only.
[ https://issues.apache.org/jira/browse/OFBIZ-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670345#comment-13670345 ] Ankit Jain commented on OFBIZ-4190: --- Working fine for me as well as checked on trunk. Jacopo, we can close this issue as its not reproducible now. Thanks Creating return from Sales Order having more than 1 item creates payment with amount of First item only. Key: OFBIZ-4190 URL: https://issues.apache.org/jira/browse/OFBIZ-4190 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release 09.04, Release Branch 10.04, SVN trunk Reporter: Chirag Manocha Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk When an order is returned which is having more than 1 item, It creates the payment with amount of 1st item only instead of full order amount(return amount). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4161) CheckOutEvents setCheckOutPages
[ https://issues.apache.org/jira/browse/OFBIZ-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670361#comment-13670361 ] Ankit Jain commented on OFBIZ-4161: --- Hi Stephen, I have checked on trunk and if no payment method is selected then its throwing an error saying Please select a method of payment. Its working as expected. Thanks. CheckOutEvents setCheckOutPages --- Key: OFBIZ-4161 URL: https://issues.apache.org/jira/browse/OFBIZ-4161 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 10.04, SVN trunk Environment: Win XP Reporter: Stephen Rufle Priority: Minor Attachments: OFBIZ-4161.patch There is an extra check in CheckOutEvents.setCheckOutPages that prevents an error message from being produced when no payment method is selected on the How shall you pay step of the checkout process. The screen just flashes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5206) User is redirected to showcart page when any error comes on checkout page.
Ankit Jain created OFBIZ-5206: - Summary: User is redirected to showcart page when any error comes on checkout page. Key: OFBIZ-5206 URL: https://issues.apache.org/jira/browse/OFBIZ-5206 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk On checkout page if any error comes it redirects user back to showcart page with an error message. Expected : Error should be shown on the same page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5206) User is redirected to showcart page when any error comes on checkout page.
[ https://issues.apache.org/jira/browse/OFBIZ-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-5206: -- Attachment: OFBIZ-5206.patch Attached patch fix the issue. Thanks. User is redirected to showcart page when any error comes on checkout page. -- Key: OFBIZ-5206 URL: https://issues.apache.org/jira/browse/OFBIZ-5206 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-5206.patch On checkout page if any error comes it redirects user back to showcart page with an error message. Expected : Error should be shown on the same page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4332) Pagination in find order screen doesn't work (With patch)
[ https://issues.apache.org/jira/browse/OFBIZ-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669327#comment-13669327 ] Ankit Jain commented on OFBIZ-4332: --- Thanks Jacques. Pagination in find order screen doesn't work (With patch) - Key: OFBIZ-4332 URL: https://issues.apache.org/jira/browse/OFBIZ-4332 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 10.04, Release Branch 11.04 Reporter: Stéphane DUCAS Assignee: Jacques Le Roux Fix For: Release Branch 10.04, Release Branch 11.04 Attachments: OFBIZ-4332-order-pagination.patch On find order screen when there is more than 20 orders to display the pagination doesn't work: when the next button is pressed no orders are displayed. Patch attached -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4291) No method to remove a promo code from the shopping cart
[
https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Jain updated OFBIZ-4291:
--
Attachment: Updated-Ofbiz-4291.patch
Hi Folks,
I have updated the patch for removing the promoCode from cart. And also added a
method to remove it from the list of product promo use.
The patch can be applied on trunk.
Thanks.
No method to remove a promo code from the shopping cart
---
Key: OFBIZ-4291
URL: https://issues.apache.org/jira/browse/OFBIZ-4291
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: Release Branch 10.04
Reporter: Glyton Camilleri
Attachments: unapplyPromotion.txt, Updated-Ofbiz-4291.patch
Hi,
When working with promotions and promo codes in the shopping cart, it seems
not possible to remove _one_ specific promo code from the cart neither
through the ShoppingCart and its helpers and services, nor through the
ProductPromoWorker.
ShoppingCart has the method
{{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
but no method to remove the added PromoCode. Is there any other worker,
service or event that can be called to do this? And if not, is there a
specifc reason (maybe relating to promotions application rules) for not
implementing this?
Any response is appreciated.
Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4332) Pagination in find order screen doesn't work (With patch)
[ https://issues.apache.org/jira/browse/OFBIZ-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13667759#comment-13667759 ] Ankit Jain commented on OFBIZ-4332: --- This is working fine as checked on 12.04 locally and on demo trunk https://demo-trunk.ofbiz.apache.org/ordermgr/control/searchorders Jacques, can we close this issue as its not reproducible? Thanks. Pagination in find order screen doesn't work (With patch) - Key: OFBIZ-4332 URL: https://issues.apache.org/jira/browse/OFBIZ-4332 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Stéphane DUCAS Attachments: OFBIZ-4332-order-pagination.patch On find order screen when there is more than 20 orders to display the pagination doesn't work: when the next button is pressed no orders are displayed. Patch attached -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5201) Find Order functions - Not working when junk values entered for product Id
[ https://issues.apache.org/jira/browse/OFBIZ-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13667764#comment-13667764 ] Ankit Jain commented on OFBIZ-5201: --- Hi Parimal, I have checked demo trunk and also found the same issue. And your first recommendation looks good to me. A message should be shown that No orders are present for that productId[] or Invalid productId. If a user is searching orders on the basis 'productId' or any other field then he should be notified, if he did any mistake. Thanks. Find Order functions - Not working when junk values entered for product Id -- Key: OFBIZ-5201 URL: https://issues.apache.org/jira/browse/OFBIZ-5201 Project: OFBiz Issue Type: Bug Components: order Reporter: parimal gain Priority: Minor Labels: order Problem specification and step - 1) Go to Order Manager app Find Orders 2) Enter valid product id for which order exists 3) Relevant orders with entered product value would be shown in search results 4) Enter invalid product id - JUNK value 5) Error behvaior:All orders on the system would be highlighted 6) Actual behavior: No order should be shown as search results, as no order exists with this JUNK product id on system Observation - When looked into code level found that system apply check for two condition - 1) If passes productId starts or ends with % or * then add that in condition list as it is and it returns all order that contains the word for product Ids. 2) If the above condition is failed the check if the product corresponding to product id is present or not. 3) If exists then check for variants (if its virtual)all this. 4) If product not exists then the action is missing i.e. no condition is added and it returns all order available. Recommendation - There are two ways to solve the issue - 1) If product corresponding to passes productId is not present then return message to user that order is not present. 2) If the thought process for current behavior is show all record if product not available then user should get a message as well that Order is not available for your search product but we have all these order in system to convey the correct message to user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4957) Error on Shopping List Page
Ankit Jain created OFBIZ-4957: - Summary: Error on Shopping List Page Key: OFBIZ-4957 URL: https://issues.apache.org/jira/browse/OFBIZ-4957 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk On the Shopping List page https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/addItemToShoppingList/editShoppingList its throwing error on line 199, column 38 in component://party/webapp/partymgr/party/editShoppingList.ftl Negative starting index for range, is lowIndex-1..highIndex-1 The problematic instruction: -- == list shoppingListItemDatas[lowIndex-1..highIndex-1] as shoppingListItemData [on line 199, column 9 in component://party/webapp/partymgr/party/editShoppingList.ftl] -- Java backtrace for programmers: -- freemarker.template.TemplateException: on line 199, column 38 in component://party/webapp/partymgr/party/editShoppingList.ftl Negative starting index for range, is lowIndex-1..highIndex-1 at freemarker.core.DynamicKeyName.dealWithRangeKey(DynamicKeyName.java:157) at -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4957) Error on Shopping List Page
[ https://issues.apache.org/jira/browse/OFBIZ-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4957: -- Attachment: OFBIZ-4957.patch Minor fix. Attached patch fix the problem. Error on Shopping List Page --- Key: OFBIZ-4957 URL: https://issues.apache.org/jira/browse/OFBIZ-4957 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4957.patch On the Shopping List page https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/addItemToShoppingList/editShoppingList its throwing error on line 199, column 38 in component://party/webapp/partymgr/party/editShoppingList.ftl Negative starting index for range, is lowIndex-1..highIndex-1 The problematic instruction: -- == list shoppingListItemDatas[lowIndex-1..highIndex-1] as shoppingListItemData [on line 199, column 9 in component://party/webapp/partymgr/party/editShoppingList.ftl] -- Java backtrace for programmers: -- freemarker.template.TemplateException: on line 199, column 38 in component://party/webapp/partymgr/party/editShoppingList.ftl Negative starting index for range, is lowIndex-1..highIndex-1 at freemarker.core.DynamicKeyName.dealWithRangeKey(DynamicKeyName.java:157) at -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4957) Error on Shopping List Page
[ https://issues.apache.org/jira/browse/OFBIZ-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13410046#comment-13410046 ] Ankit Jain commented on OFBIZ-4957: --- Jacques, In the groovy EditShoppingList.groovy the value of lowIndex is 0 thats why in the ftl we should use lowIndex instead of lowIndex-1. Thats why its throwing error Negative starting index for range, is lowIndex-1..highIndex-1 Error on Shopping List Page --- Key: OFBIZ-4957 URL: https://issues.apache.org/jira/browse/OFBIZ-4957 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4957.patch On the Shopping List page https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/addItemToShoppingList/editShoppingList its throwing error on line 199, column 38 in component://party/webapp/partymgr/party/editShoppingList.ftl Negative starting index for range, is lowIndex-1..highIndex-1 The problematic instruction: -- == list shoppingListItemDatas[lowIndex-1..highIndex-1] as shoppingListItemData [on line 199, column 9 in component://party/webapp/partymgr/party/editShoppingList.ftl] -- Java backtrace for programmers: -- freemarker.template.TemplateException: on line 199, column 38 in component://party/webapp/partymgr/party/editShoppingList.ftl Negative starting index for range, is lowIndex-1..highIndex-1 at freemarker.core.DynamicKeyName.dealWithRangeKey(DynamicKeyName.java:157) at -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4741) Error in Find Content Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395863#comment-13395863 ] Ankit Jain commented on OFBIZ-4741: --- Tom, Which firefox version you are using ?? The lookup icon is visible at my end. Yes the find(search) is not working properly. Previously I had some problems ff 12.0 but after updated it to 13.0, its working fine now. Error in Find Content Lookup Key: OFBIZ-4741 URL: https://issues.apache.org/jira/browse/OFBIZ-4741 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk Reporter: Tom Burns Assignee: Sascha Rodekamp Priority: Minor Fix For: SVN trunk Attachments: Content Missing Locale Lookup.jpg, Content With Locale Lookup on localhost.jpg To reproduce: In Content Manager select Content (https://demo-trunk.ofbiz.apache.org/content/control/findContent) Click Lookup Icon for Locale String Expected: Lookup Locale dialog Actual: Error message org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#LookupDecorator]: java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to java.util.Locale (java.util.LinkedHashMap cannot be cast to java.util.Locale) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4912) Error on Show Cart page
[ https://issues.apache.org/jira/browse/OFBIZ-4912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain closed OFBIZ-4912. - Resolution: Fixed Closing this issue, Jacopo fixed it at r1345528. Thanks Jacopo. Error on Show Cart page --- Key: OFBIZ-4912 URL: https://issues.apache.org/jira/browse/OFBIZ-4912 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Fix For: SVN trunk Attachments: OFBIZ-4912.patch Error on Showcart page after adding a product. https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem No signature of method getRelated matches the arguments The problematic instruction: -- == assignment: itemProductAssocList=cartLine.getProduct().getRelated(MainProductAssoc, Static[org.ofbiz.base.util.UtilMisc].toList(productAssocTypeId, sequenceNum), false)?if_exists [on line 215, column 15 in component://order/webapp/ordermgr/entry/cart/showcartitems.ftl] -- Java backtrace for programmers: -- freemarker.template.TemplateModelException: No signature of method getRelated matches the arguments at freemarker.ext.beans.MethodMap.getMemberAndArguments(MethodMap.java:94) at freemarker.ext.beans.OverloadedMethodModel.exec(OverloadedMethodModel.java:101) at freemarker.core.MethodCall._getAsTemplateModel(MethodCall.java:93) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.BuiltIn$if_existsBI._getAsTemplateModel(BuiltIn.java:751) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.Assignment.accept(Assignment.java:90) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:167) at freemarker.core.Environment.visit(Environment.java:428) at freemarker.core.IteratorBlock.accept(IteratorBlock.java:102) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.IfBlock.accept(IfBlock.java:82) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.Environment.process(Environment.java:199) at org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:251) at org.ofbiz.widget.screen.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:224) at org.ofbiz.widget.screen.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:269) at org.ofbiz.widget.screen.HtmlWidget.renderWidgetString(HtmlWidget.java:129) at -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4916) Replaces != null pattern in ftl file by ?? (which replaces deprecated ?if_exist)
[ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13288363#comment-13288363 ] Ankit Jain commented on OFBIZ-4916: --- Thanks Jacques :) Replaces != null pattern in ftl file by ?? (which replaces deprecated ?if_exist) Key: OFBIZ-4916 URL: https://issues.apache.org/jira/browse/OFBIZ-4916 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk, Release Branch 12.04 Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk, Release Branch 12.04 Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch As discussed with Jacopo applying change of commit r1343156 to other ftls. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4916) Applying change of commit r1343156 to other ftls.
Ankit Jain created OFBIZ-4916: - Summary: Applying change of commit r1343156 to other ftls. Key: OFBIZ-4916 URL: https://issues.apache.org/jira/browse/OFBIZ-4916 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk As discussed with Jacopo applying change of commit r1343156 to other ftls. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4916) Applying change of commit r1343156 to other ftls.
[ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4916: -- Attachment: OFBIZ-4916.patch Attached patch for the issue. Applying change of commit r1343156 to other ftls. - Key: OFBIZ-4916 URL: https://issues.apache.org/jira/browse/OFBIZ-4916 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4916.patch As discussed with Jacopo applying change of commit r1343156 to other ftls. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4916) Applying change of commit r1343156 to other ftls.
[ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287310#comment-13287310 ] Ankit Jain commented on OFBIZ-4916: --- Actually not Jacopo, Because these files showblog.ftl and showforumresponse.ftl are not using anywhere and bloglib.ftl is included in some ftls and I back trace them and in controller(/ofbiz_trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml) I found all the requests to these are commented with a not TO BE REMOVED. So does it means these files are of no use ?? I will update the patch after removing these files. Thanks Applying change of commit r1343156 to other ftls. - Key: OFBIZ-4916 URL: https://issues.apache.org/jira/browse/OFBIZ-4916 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4916.patch As discussed with Jacopo applying change of commit r1343156 to other ftls. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4916) Applying change of commit r1343156 to other ftls.
[ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4916: -- Attachment: UPDATED-OFBIZ-4916.patch Updated Patch. Applying change of commit r1343156 to other ftls. - Key: OFBIZ-4916 URL: https://issues.apache.org/jira/browse/OFBIZ-4916 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4916.patch, UPDATED-OFBIZ-4916.patch As discussed with Jacopo applying change of commit r1343156 to other ftls. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4912) Error on Show Cart page
Ankit Jain created OFBIZ-4912: - Summary: Error on Show Cart page Key: OFBIZ-4912 URL: https://issues.apache.org/jira/browse/OFBIZ-4912 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Fix For: SVN trunk Error on Showcart page after adding a product. https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem No signature of method getRelated matches the arguments The problematic instruction: -- == assignment: itemProductAssocList=cartLine.getProduct().getRelated(MainProductAssoc, Static[org.ofbiz.base.util.UtilMisc].toList(productAssocTypeId, sequenceNum), false)?if_exists [on line 215, column 15 in component://order/webapp/ordermgr/entry/cart/showcartitems.ftl] -- Java backtrace for programmers: -- freemarker.template.TemplateModelException: No signature of method getRelated matches the arguments at freemarker.ext.beans.MethodMap.getMemberAndArguments(MethodMap.java:94) at freemarker.ext.beans.OverloadedMethodModel.exec(OverloadedMethodModel.java:101) at freemarker.core.MethodCall._getAsTemplateModel(MethodCall.java:93) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.BuiltIn$if_existsBI._getAsTemplateModel(BuiltIn.java:751) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.Assignment.accept(Assignment.java:90) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:167) at freemarker.core.Environment.visit(Environment.java:428) at freemarker.core.IteratorBlock.accept(IteratorBlock.java:102) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.IfBlock.accept(IfBlock.java:82) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.Environment.process(Environment.java:199) at org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:251) at org.ofbiz.widget.screen.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:224) at org.ofbiz.widget.screen.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:269) at org.ofbiz.widget.screen.HtmlWidget.renderWidgetString(HtmlWidget.java:129) at -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4912) Error on Show Cart page
[ https://issues.apache.org/jira/browse/OFBIZ-4912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4912: -- Attachment: OFBIZ-4912.patch Attached patch will fix the issue. Error on Show Cart page --- Key: OFBIZ-4912 URL: https://issues.apache.org/jira/browse/OFBIZ-4912 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Fix For: SVN trunk Attachments: OFBIZ-4912.patch Error on Showcart page after adding a product. https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem No signature of method getRelated matches the arguments The problematic instruction: -- == assignment: itemProductAssocList=cartLine.getProduct().getRelated(MainProductAssoc, Static[org.ofbiz.base.util.UtilMisc].toList(productAssocTypeId, sequenceNum), false)?if_exists [on line 215, column 15 in component://order/webapp/ordermgr/entry/cart/showcartitems.ftl] -- Java backtrace for programmers: -- freemarker.template.TemplateModelException: No signature of method getRelated matches the arguments at freemarker.ext.beans.MethodMap.getMemberAndArguments(MethodMap.java:94) at freemarker.ext.beans.OverloadedMethodModel.exec(OverloadedMethodModel.java:101) at freemarker.core.MethodCall._getAsTemplateModel(MethodCall.java:93) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.BuiltIn$if_existsBI._getAsTemplateModel(BuiltIn.java:751) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.Assignment.accept(Assignment.java:90) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:167) at freemarker.core.Environment.visit(Environment.java:428) at freemarker.core.IteratorBlock.accept(IteratorBlock.java:102) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.IfBlock.accept(IfBlock.java:82) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:221) at freemarker.core.Environment.process(Environment.java:199) at org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:251) at org.ofbiz.widget.screen.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:224) at org.ofbiz.widget.screen.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:269) at org.ofbiz.widget.screen.HtmlWidget.renderWidgetString(HtmlWidget.java:129) at -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4866) Split Into Multiple Shipment Button is not working
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272119#comment-13272119 ] Ankit Jain commented on OFBIZ-4866: --- Jacques, In ecommerce this functionality is working, I did for ordermgr. When you place and order from backend(Ordermgr) and chose Quick Finalize Order it redirect you to quickcheckout page (https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout) here on the left side there is a button Split into multiple Shipment. When you click on this button it will show org.ofbiz.webapp.control.RequestHandlerException: Unknown request [splitship]; this request does not exist or cannot be called directly. I took the reference and also reused the code of ecommerce for this Split Shipment. Split Into Multiple Shipment Button is not working -- Key: OFBIZ-4866 URL: https://issues.apache.org/jira/browse/OFBIZ-4866 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch Split Into Multiple Shipment Button is not working on quick checkout page https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button is not working
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4866: -- Attachment: Updated_OFBIZ-4866.patch Jacques, The ordermgr code is not dependend on ecommerce code and also not a duplicate, I have modified the code and used here in ordermgr. Now we can reuse this code in ecommerce. Attaching a updated patch. Split Into Multiple Shipment Button is not working -- Key: OFBIZ-4866 URL: https://issues.apache.org/jira/browse/OFBIZ-4866 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch, Updated_OFBIZ-4866.patch Split Into Multiple Shipment Button is not working on quick checkout page https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4865) Exception there when trying to update order's Shipping Destination Address
[
https://issues.apache.org/jira/browse/OFBIZ-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271142#comment-13271142
]
Ankit Jain commented on OFBIZ-4865:
---
This is happening because of the below code in updateOrderItemShipGroup
service.
call-bsh![CDATA[
shipmentMethod = parameters.get(shipmentMethod);
if(shipmentMethod != null){
arr = shipmentMethod.split( @ );
parameters.put(shipmentMethodTypeId, arr[0]);
parameters.put(carrierPartyId, arr[1]);
parameters.put(carrierRoleTypeId, arr[2]);
}
]]/call-bsh
Exception there when trying to update order's Shipping Destination Address
Key: OFBIZ-4865
URL: https://issues.apache.org/jira/browse/OFBIZ-4865
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Leon
If click the update button of Shipping Destination Address in order view
page, an exception thrown out as:
{quote}
The Following Errors Occurred:
BeanShell execution caused an error: Sourced file: inline evaluation of: ``
shipmentMethod = parameters.get(shipmentMethod); if(s . . . ''
{quote}
I'm not familiar with beanshell and the mechanism of how ofbiz handling it,
but I'm sure that there'no such error days ago.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4866) Split Into Multiple Shipment Button is not working
Ankit Jain created OFBIZ-4866: - Summary: Split Into Multiple Shipment Button is not working Key: OFBIZ-4866 URL: https://issues.apache.org/jira/browse/OFBIZ-4866 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Split Into Multiple Shipment Button is not working on quick checkout page https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button is not working
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4866: -- Attachment: OFBIZ-4866.patch I have checked code and found that either its not implemented or code is removed. I am not sure its a bug or an improvement, I took reference from front-end Split Ship functionality and implemented it for backend quick checkout. Attaching patch for it. Split Into Multiple Shipment Button is not working -- Key: OFBIZ-4866 URL: https://issues.apache.org/jira/browse/OFBIZ-4866 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4866.patch Split Into Multiple Shipment Button is not working on quick checkout page https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button is not working
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4866: -- Fix Version/s: Release Branch 10.04 Affects Version/s: Release 10.04 Split Into Multiple Shipment Button is not working -- Key: OFBIZ-4866 URL: https://issues.apache.org/jira/browse/OFBIZ-4866 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4866.patch Split Into Multiple Shipment Button is not working on quick checkout page https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button is not working
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4866: -- Attachment: Updated_OFBIZ-4866.patch Updated patch. Split Into Multiple Shipment Button is not working -- Key: OFBIZ-4866 URL: https://issues.apache.org/jira/browse/OFBIZ-4866 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release 10.04, SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch Split Into Multiple Shipment Button is not working on quick checkout page https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4834) Continue shopping does not work
[ https://issues.apache.org/jira/browse/OFBIZ-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270262#comment-13270262 ] Ankit Jain commented on OFBIZ-4834: --- Thanks Jacques :) Continue shopping does not work --- Key: OFBIZ-4834 URL: https://issues.apache.org/jira/browse/OFBIZ-4834 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-4834.patch After submitting an order using quick checkout, when you want to add products from main page (using Continue shopping or not), at the 1st product you add you get directly to quick checkout and would have to get back to the main page to add another product -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4566) Primary Billing Address update fails with javascript error: validation is not defined
[ https://issues.apache.org/jira/browse/OFBIZ-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270261#comment-13270261 ] Ankit Jain commented on OFBIZ-4566: --- Thanks Jacques :) Primary Billing Address update fails with javascript error: validation is not defined - Key: OFBIZ-4566 URL: https://issues.apache.org/jira/browse/OFBIZ-4566 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04, SVN trunk Reporter: Kiran Gawde Assignee: Jacques Le Roux Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 Attachments: OFBIZ-4566.patch Goto profile page. Click manage addresses Click Edit 'Primary Billing Address'. Modify something and hit save. Issue: Dialog doesn't close. You will see bunch of javascript errors. One of them is validation is not defined. This prevents the update. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4851) Error on View Facility Inventory Items Details Page
[ https://issues.apache.org/jira/browse/OFBIZ-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268921#comment-13268921 ] Ankit Jain commented on OFBIZ-4851: --- Thanks Jacques. :) Error on View Facility Inventory Items Details Page --- Key: OFBIZ-4851 URL: https://issues.apache.org/jira/browse/OFBIZ-4851 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4851.patch Error on https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails Page, when you select Report Type - By Inventory Item or By Product its throwing error. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem (Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-904) Error when Inventory Facility Id is left blank in product store settings
[
https://issues.apache.org/jira/browse/OFBIZ-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268238#comment-13268238
]
Ankit Jain commented on OFBIZ-904:
--
Its working fine for me, if its not please write steps to reproduce. :)
Error when Inventory Facility Id is left blank in product store settings
--
Key: OFBIZ-904
URL: https://issues.apache.org/jira/browse/OFBIZ-904
Project: OFBiz
Issue Type: Bug
Components: product, specialpurpose/ecommerce
Environment: OFBiz Rev. 529997 on Windows XP.
Reporter: Michel Dielissen
When creating a new store and the Inventory Facility Id field is left blank
(with the store settings) then the productlist (Browse categories in the
e-commerce store) gives an error and is not rendered.
Error:
2007-04-19 10:13:16,515 (http-0.0.0.0-8080-Processor3) [
ModelScreen.java:148:ERROR] Error rendering screen
[component://ecommerce/widget/CatalogScreens.xml#productsummary]:
org.ofbiz.base.util.GeneralException: Error running BSH script at location
[component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh]:
org.ofbiz.base.util.GeneralException: Error running BSH script at
[component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
line [65]: Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm. : at Line: 65 : in file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
: if ( product != null ) {
(Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm.) (Error running BSH script
at
[component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
line [65]: Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm. : at Line: 65 : in file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
: if ( product != null ) {
(Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm.)). Rolling back transaction.
Think it has something todo with:
file:/D:/ofbiz/applications/product/script/org/ofbiz/product/inventory/InventoryServices.xml
2007-04-19 10:12:27,843 (http-0.0.0.0-8080-Processor3) [
ServiceDispatcher.java:459:DEBUG] Sync service
[ecommerce/getInventoryAvailableByFacility]
So maybe the Inventory Facility Id field has to be a required field? Or
maybe better to run the getInventoryAvailableByFacility only when an
Inventory Facility is filled with the store settings?
Comment Jacopo: this should be improved; for example the facility in the
store should be mandatory if the requireInventory flag is set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4834) Continue shopping does not work
[ https://issues.apache.org/jira/browse/OFBIZ-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4834: -- Attachment: OFBIZ-4834.patch Hi Jacques, This is happening because we have used save-current-view=true for quickCheckout request and in the addItem request we are using view-last that's why its redirecting to quickCheckout after adding item. Attached patch will resolve the issue. Continue shopping does not work --- Key: OFBIZ-4834 URL: https://issues.apache.org/jira/browse/OFBIZ-4834 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Jacques Le Roux Attachments: OFBIZ-4834.patch After submitting an order using quick checkout, when you want to add products from main page (using Continue shopping or not), at the 1st product you add you get directly to quick checkout and would have to get back to the main page to add another product -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4566) Primary Billing Address update fails with javascript error: validation is not defined
[ https://issues.apache.org/jira/browse/OFBIZ-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4566: -- Attachment: OFBIZ-4566.patch Hi Kiran, I didn't got exactly what is the issue. Please provide steps to reproduce. But on the edit contact mech page (https://localhost:8443/ecommerce/control/editcontactmech?contactMechId=10001) coming from profile page, there is one js error in the firebug. Attached patch will fix the issue. Primary Billing Address update fails with javascript error: validation is not defined - Key: OFBIZ-4566 URL: https://issues.apache.org/jira/browse/OFBIZ-4566 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04, SVN trunk Reporter: Kiran Gawde Attachments: OFBIZ-4566.patch Goto profile page. Click manage addresses Click Edit 'Primary Billing Address'. Modify something and hit save. Issue: Dialog doesn't close. You will see bunch of javascript errors. One of them is validation is not defined. This prevents the update. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-904) Error when Inventory Facility Id is left blank in product store settings
[
https://issues.apache.org/jira/browse/OFBIZ-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268286#comment-13268286
]
Ankit Jain commented on OFBIZ-904:
--
Okay got the issue. Thanks Scott.
So should inventoryFacilityId be mandatory at the time of ProductStore
creation??
Error when Inventory Facility Id is left blank in product store settings
--
Key: OFBIZ-904
URL: https://issues.apache.org/jira/browse/OFBIZ-904
Project: OFBiz
Issue Type: Bug
Components: product, specialpurpose/ecommerce
Environment: OFBiz Rev. 529997 on Windows XP.
Reporter: Michel Dielissen
When creating a new store and the Inventory Facility Id field is left blank
(with the store settings) then the productlist (Browse categories in the
e-commerce store) gives an error and is not rendered.
Error:
2007-04-19 10:13:16,515 (http-0.0.0.0-8080-Processor3) [
ModelScreen.java:148:ERROR] Error rendering screen
[component://ecommerce/widget/CatalogScreens.xml#productsummary]:
org.ofbiz.base.util.GeneralException: Error running BSH script at location
[component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh]:
org.ofbiz.base.util.GeneralException: Error running BSH script at
[component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
line [65]: Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm. : at Line: 65 : in file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
: if ( product != null ) {
(Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm.) (Error running BSH script
at
[component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh],
line [65]: Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm. : at Line: 65 : in file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
: if ( product != null ) {
(Sourced file:
component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh
internal Error: Null value in getAssignableForm.)). Rolling back transaction.
Think it has something todo with:
file:/D:/ofbiz/applications/product/script/org/ofbiz/product/inventory/InventoryServices.xml
2007-04-19 10:12:27,843 (http-0.0.0.0-8080-Processor3) [
ServiceDispatcher.java:459:DEBUG] Sync service
[ecommerce/getInventoryAvailableByFacility]
So maybe the Inventory Facility Id field has to be a required field? Or
maybe better to run the getInventoryAvailableByFacility only when an
Inventory Facility is filled with the store settings?
Comment Jacopo: this should be improved; for example the facility in the
store should be mandatory if the requireInventory flag is set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4851) Error on View Facility Inventory Items Details Page
Ankit Jain created OFBIZ-4851: - Summary: Error on View Facility Inventory Items Details Page Key: OFBIZ-4851 URL: https://issues.apache.org/jira/browse/OFBIZ-4851 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Error on https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4851) Error on View Facility Inventory Items Details Page
[ https://issues.apache.org/jira/browse/OFBIZ-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4851: -- Description: Error on https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails Page, when you select Report Type - By Inventory Item or By Product its throwing error. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem (Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem) was:Error on https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails Error on View Facility Inventory Items Details Page --- Key: OFBIZ-4851 URL: https://issues.apache.org/jira/browse/OFBIZ-4851 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Error on https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails Page, when you select Report Type - By Inventory Item or By Product its throwing error. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem (Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4851) Error on View Facility Inventory Items Details Page
[ https://issues.apache.org/jira/browse/OFBIZ-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4851: -- Attachment: OFBIZ-4851.patch Attached patch fix the issue. Error on View Facility Inventory Items Details Page --- Key: OFBIZ-4851 URL: https://issues.apache.org/jira/browse/OFBIZ-4851 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4851.patch Error on https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails Page, when you select Report Type - By Inventory Item or By Product its throwing error. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem (Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4379) Get first from list tag in screen's and form's action tag.
Get first from list tag in screen's and form's action tag.
--
Key: OFBIZ-4379
URL: https://issues.apache.org/jira/browse/OFBIZ-4379
Project: OFBiz
Issue Type: New Feature
Components: framework
Affects Versions: Release 10.04, SVN trunk
Reporter: Ankit Jain
Priority: Minor
Fix For: Release Branch 10.04, SVN trunk
In most of the cases we need to get first record from a list in screen and form
widgets then we have to do something like this:
for eg:
set field=websiteContent value=${groovy:
org.ofbiz.entity.util.EntityUtil.getFirst(websiteContentList);}/
Instead of using like this my idea is to add a tag like first-from-list/ in
Screen Form widget's action tag, so one can easily get first record from a
list.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4379) Get first from list tag in screen's and form's action tag.
[
https://issues.apache.org/jira/browse/OFBIZ-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Jain updated OFBIZ-4379:
--
Attachment: OFBIZ-4379.patch
Attaching patch for this feature.
Get first from list tag in screen's and form's action tag.
--
Key: OFBIZ-4379
URL: https://issues.apache.org/jira/browse/OFBIZ-4379
Project: OFBiz
Issue Type: New Feature
Components: framework
Affects Versions: Release 10.04, SVN trunk
Reporter: Ankit Jain
Priority: Minor
Fix For: Release Branch 10.04, SVN trunk
Attachments: OFBIZ-4379.patch
In most of the cases we need to get first record from a list in screen and
form widgets then we have to do something like this:
for eg:
set field=websiteContent value=${groovy:
org.ofbiz.entity.util.EntityUtil.getFirst(websiteContentList);}/
Instead of using like this my idea is to add a tag like first-from-list/ in
Screen Form widget's action tag, so one can easily get first record from a
list.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4379) Get first from list tag in screen's and form's action tag.
[
https://issues.apache.org/jira/browse/OFBIZ-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093047#comment-13093047
]
Ankit Jain commented on OFBIZ-4379:
---
Hello David,
I agree with what you say, and yes we can use your suggested way, but this tag
is also present in the services, so a point came in my mind why we can't use
the same tag in screens and forms. That's why created a patch for it.
HTH :)
Get first from list tag in screen's and form's action tag.
--
Key: OFBIZ-4379
URL: https://issues.apache.org/jira/browse/OFBIZ-4379
Project: OFBiz
Issue Type: New Feature
Components: framework
Affects Versions: Release 10.04, SVN trunk
Reporter: Ankit Jain
Priority: Minor
Fix For: Release Branch 10.04, SVN trunk
Attachments: OFBIZ-4379.patch
In most of the cases we need to get first record from a list in screen and
form widgets then we have to do something like this:
for eg:
set field=websiteContent value=${groovy:
org.ofbiz.entity.util.EntityUtil.getFirst(websiteContentList);}/
Instead of using like this my idea is to add a tag like first-from-list/ in
Screen Form widget's action tag, so one can easily get first record from a
list.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4369) Update is not working Shopping List.
Update is not working Shopping List. Key: OFBIZ-4369 URL: https://issues.apache.org/jira/browse/OFBIZ-4369 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor While trying to update any list item in Shopping List the Update is not working. http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/editShoppingList -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4369) Update is not working Shopping List.
[ https://issues.apache.org/jira/browse/OFBIZ-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4369: -- Attachment: OFBIZ-4369.patch Attached patch will solve the issue. Update is not working Shopping List. Key: OFBIZ-4369 URL: https://issues.apache.org/jira/browse/OFBIZ-4369 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Attachments: OFBIZ-4369.patch While trying to update any list item in Shopping List the Update is not working. http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/editShoppingList -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4369) Update is not working in Shopping List.
[ https://issues.apache.org/jira/browse/OFBIZ-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4369: -- Summary: Update is not working in Shopping List. (was: Update is not working Shopping List.) Update is not working in Shopping List. --- Key: OFBIZ-4369 URL: https://issues.apache.org/jira/browse/OFBIZ-4369 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Ankit Jain Priority: Minor Attachments: OFBIZ-4369.patch While trying to update any list item in Shopping List the Update is not working. http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/editShoppingList -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4369) Update is not working in Shopping List.
[ https://issues.apache.org/jira/browse/OFBIZ-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086246#comment-13086246 ] Ankit Jain commented on OFBIZ-4369: --- Thanks Jacques :) Update is not working in Shopping List. --- Key: OFBIZ-4369 URL: https://issues.apache.org/jira/browse/OFBIZ-4369 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Release Branch 11.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 11.04, SVN trunk Attachments: OFBIZ-4369.patch While trying to update any list item in Shopping List the Update is not working. http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/editShoppingList -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4118) Some misc issues in ebay and ebayStore component.
[ https://issues.apache.org/jira/browse/OFBIZ-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021460#comment-13021460 ] Ankit Jain commented on OFBIZ-4118: --- Thanks Jacques :) Some misc issues in ebay and ebayStore component. - Key: OFBIZ-4118 URL: https://issues.apache.org/jira/browse/OFBIZ-4118 Project: OFBiz Issue Type: Bug Components: specialpurpose/ebay, specialpurpose/ebaystore Affects Versions: SVN trunk Reporter: Arun Patidar Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 10.04-ofbiz-4118.patch, ExportProductToEbay-ofbiz-4118.patch, ExportToEbay.patch, OFBIZ-4118.patch, OFBIZ-4118.patch, Set-Complete-Status-ofbiz-4118.patch, Set-Complete-Status-ofbiz-4118.patch, Store-Category-Ofbiz-4118.patch, export-multiple-products-ofbiz-4118.patch, import-order-ofbiz-4118.patch, ofbiz-4118-ebay.patch, ofbiz-4118-ebayStore.patch, ofbiz-4118-ebayStore.patch, setShipmentMethod-ebay-ofbiz-4118.patch Following issues are exists in ebay and ebayStore component 1. Not getting ebay sub category from parent category on Export Product Listing screen of ebayStore component. 2. Error in getting category lookup form on Export Product Listing screen of ebayStore component.. 3. JS is blocking during Export Product to ebay from ebay component. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4118) Some misc issues in ebay and ebayStore component.
[ https://issues.apache.org/jira/browse/OFBIZ-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020931#comment-13020931 ] Ankit Jain commented on OFBIZ-4118: --- Thanks Jacques. :) Some misc issues in ebay and ebayStore component. - Key: OFBIZ-4118 URL: https://issues.apache.org/jira/browse/OFBIZ-4118 Project: OFBiz Issue Type: Bug Components: specialpurpose/ebay, specialpurpose/ebaystore Affects Versions: SVN trunk Reporter: Arun Patidar Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 10.04-ofbiz-4118.patch, ExportProductToEbay-ofbiz-4118.patch, ExportToEbay.patch, OFBIZ-4118.patch, Set-Complete-Status-ofbiz-4118.patch, Set-Complete-Status-ofbiz-4118.patch, export-multiple-products-ofbiz-4118.patch, import-order-ofbiz-4118.patch, ofbiz-4118-ebay.patch, ofbiz-4118-ebayStore.patch, ofbiz-4118-ebayStore.patch, setShipmentMethod-ebay-ofbiz-4118.patch Following issues are exists in ebay and ebayStore component 1. Not getting ebay sub category from parent category on Export Product Listing screen of ebayStore component. 2. Error in getting category lookup form on Export Product Listing screen of ebayStore component.. 3. JS is blocking during Export Product to ebay from ebay component. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4118) Some misc issues in ebay and ebayStore component.
[ https://issues.apache.org/jira/browse/OFBIZ-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4118: -- Attachment: OFBIZ-4118.patch I have done a minor improvement in ebay store. In the ebay account added a screen to add catalog to store , so one can add the catalogs to ebay store. After selecting an account, it redirect us to ebay account page, and here is the screen https://localhost:8443/ebaystore/control/AssociateCatalog?productStoreId=90101 so one can add the catalog to ebay store. Some misc issues in ebay and ebayStore component. - Key: OFBIZ-4118 URL: https://issues.apache.org/jira/browse/OFBIZ-4118 Project: OFBiz Issue Type: Bug Components: specialpurpose/ebay, specialpurpose/ebaystore Affects Versions: SVN trunk Reporter: Arun Patidar Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 10.04-ofbiz-4118.patch, ExportProductToEbay-ofbiz-4118.patch, ExportToEbay.patch, OFBIZ-4118.patch, OFBIZ-4118.patch, Set-Complete-Status-ofbiz-4118.patch, Set-Complete-Status-ofbiz-4118.patch, export-multiple-products-ofbiz-4118.patch, import-order-ofbiz-4118.patch, ofbiz-4118-ebay.patch, ofbiz-4118-ebayStore.patch, ofbiz-4118-ebayStore.patch, setShipmentMethod-ebay-ofbiz-4118.patch Following issues are exists in ebay and ebayStore component 1. Not getting ebay sub category from parent category on Export Product Listing screen of ebayStore component. 2. Error in getting category lookup form on Export Product Listing screen of ebayStore component.. 3. JS is blocking during Export Product to ebay from ebay component. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4118) Some misc issues in ebay and ebayStore component.
[ https://issues.apache.org/jira/browse/OFBIZ-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020901#comment-13020901 ] Ankit Jain commented on OFBIZ-4118: --- Hi Jacques, I have just changed the siteName because there are two website having the same name, its not necessary to commit as its a demo data. I made changes to avoid confusion between the two websites showing in the website dropdown. Some misc issues in ebay and ebayStore component. - Key: OFBIZ-4118 URL: https://issues.apache.org/jira/browse/OFBIZ-4118 Project: OFBiz Issue Type: Bug Components: specialpurpose/ebay, specialpurpose/ebaystore Affects Versions: SVN trunk Reporter: Arun Patidar Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 10.04-ofbiz-4118.patch, ExportProductToEbay-ofbiz-4118.patch, ExportToEbay.patch, OFBIZ-4118.patch, Set-Complete-Status-ofbiz-4118.patch, Set-Complete-Status-ofbiz-4118.patch, export-multiple-products-ofbiz-4118.patch, import-order-ofbiz-4118.patch, ofbiz-4118-ebay.patch, ofbiz-4118-ebayStore.patch, ofbiz-4118-ebayStore.patch, setShipmentMethod-ebay-ofbiz-4118.patch Following issues are exists in ebay and ebayStore component 1. Not getting ebay sub category from parent category on Export Product Listing screen of ebayStore component. 2. Error in getting category lookup form on Export Product Listing screen of ebayStore component.. 3. JS is blocking during Export Product to ebay from ebay component. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4118) Some misc issues in ebay and ebayStore component.
[ https://issues.apache.org/jira/browse/OFBIZ-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4118: -- Attachment: OFBIZ-4118.patch On the Ebay Configuration search page (https://localhost:8443/ebaystore/control/FindEbayConfigurations) a default value EBAY_STORE is shown selected and after search the same value is shown instead of the value we selected before clicking on find and same case on on Edit Ebay Configuration page (https://localhost:8443/ebaystore/control/EditEbayConfiguration?productStoreId=9000). The attached patch fixed this problem also fixed the website data. Some misc issues in ebay and ebayStore component. - Key: OFBIZ-4118 URL: https://issues.apache.org/jira/browse/OFBIZ-4118 Project: OFBiz Issue Type: Bug Components: specialpurpose/ebay, specialpurpose/ebaystore Affects Versions: SVN trunk Reporter: Arun Patidar Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 10.04-ofbiz-4118.patch, ExportProductToEbay-ofbiz-4118.patch, ExportToEbay.patch, OFBIZ-4118.patch, Set-Complete-Status-ofbiz-4118.patch, Set-Complete-Status-ofbiz-4118.patch, export-multiple-products-ofbiz-4118.patch, import-order-ofbiz-4118.patch, ofbiz-4118-ebay.patch, ofbiz-4118-ebayStore.patch, ofbiz-4118-ebayStore.patch, setShipmentMethod-ebay-ofbiz-4118.patch Following issues are exists in ebay and ebayStore component 1. Not getting ebay sub category from parent category on Export Product Listing screen of ebayStore component. 2. Error in getting category lookup form on Export Product Listing screen of ebayStore component.. 3. JS is blocking during Export Product to ebay from ebay component. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3815) Content Navigation Tree implemented with jQuery
[
https://issues.apache.org/jira/browse/OFBIZ-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000282#comment-13000282
]
Ankit Jain commented on OFBIZ-3815:
---
Thanks Sascha for fixing it.
--
Ankit :)
Content Navigation Tree implemented with jQuery
---
Key: OFBIZ-3815
URL: https://issues.apache.org/jira/browse/OFBIZ-3815
Project: OFBiz
Issue Type: Sub-task
Components: content
Affects Versions: jQuery
Reporter: Sascha Rodekamp
Assignee: Sascha Rodekamp
Fix For: jQuery, SVN trunk
Attachments: OFBIZ-3815_ContentNavigationMigration_part1.patch,
OFBIZ-3815_WebSiteCMSMigration_part2.patch, OFBIZ-3815_elrteEditorPlugin.zip,
OFBIZ-3815_jqueryExample_ContentNavigation.patch,
OFBIZ-3815_jqueryExample_ContentNavigation.patch, OFBIZ-3815_plugins.zip,
OFBIZ-3815_plugins.zip, OFBIZ_3815, image1.jpg, image2.jpg
Hi,
here is the first (test) patch for the jQuery implementation.
I changed the content navigation tree for a first test:
[https://localhost:8443/content/control/navigateContent]
The implementation was much easier than expected :-)
I choose the jsTree Plugin v. 1.0rc (in the next days their will be a final
1.0 release, that's why i choose the rc).
[http://www.jstree.com/]
I also added
{code}
jQuery.noConflict();
{code}
to the libary. That overwrites the '$( ... )' operator to prevent conflicts
with prototype. This line can be deleted after prototype is totally replaced.
For know we have to call jQuery via jQuery( ) instead of $( ... ).
To apply the patch the zip file have to copied to /images/jquery/
it contains a plugin folder with the jsTree plugin
(should look like /images/jquery/plugins/jsTree)
So long
Sascha
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-3815) Content Navigation Tree implemented with jQuery
[
https://issues.apache.org/jira/browse/OFBIZ-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Jain updated OFBIZ-3815:
--
Attachment: image2.jpg
image1.jpg
Hello Folks,
We have two issues:
# https://demo-trunk.ofbiz.apache.org:8443/content/control/findContent, the
alert box open and say Operation Aborted. see Image1.jpg
#Here https://demo-trunk.ofbiz.apache.org:8443/content/control/navigateContent
the tree is not rendering. see Image2.jpg
Both the above issue are on IE7 only they are working fine on FF and Chrome.
I have attached the two images please have a look.
Regards,
Ankit Jain :)
Content Navigation Tree implemented with jQuery
---
Key: OFBIZ-3815
URL: https://issues.apache.org/jira/browse/OFBIZ-3815
Project: OFBiz
Issue Type: Sub-task
Components: content
Affects Versions: jQuery
Reporter: Sascha Rodekamp
Assignee: Jacques Le Roux
Fix For: jQuery
Attachments: OFBIZ-3815_ContentNavigationMigration_part1.patch,
OFBIZ-3815_WebSiteCMSMigration_part2.patch, OFBIZ-3815_elrteEditorPlugin.zip,
OFBIZ-3815_jqueryExample_ContentNavigation.patch,
OFBIZ-3815_jqueryExample_ContentNavigation.patch, OFBIZ-3815_plugins.zip,
OFBIZ-3815_plugins.zip, OFBIZ_3815, image1.jpg, image2.jpg
Hi,
here is the first (test) patch for the jQuery implementation.
I changed the content navigation tree for a first test:
[https://localhost:8443/content/control/navigateContent]
The implementation was much easier than expected :-)
I choose the jsTree Plugin v. 1.0rc (in the next days their will be a final
1.0 release, that's why i choose the rc).
[http://www.jstree.com/]
I also added
{code}
jQuery.noConflict();
{code}
to the libary. That overwrites the '$( ... )' operator to prevent conflicts
with prototype. This line can be deleted after prototype is totally replaced.
For know we have to call jQuery via jQuery( ) instead of $( ... ).
To apply the patch the zip file have to copied to /images/jquery/
it contains a plugin folder with the jsTree plugin
(should look like /images/jquery/plugins/jsTree)
So long
Sascha
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4119) Form Widget hyperlink issue.
[ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12984067#action_12984067 ] Ankit Jain commented on OFBIZ-4119: --- Hello Jacques, I have checked the point raised by you and yes you are right I didn't found any hidden field with h_..., then I reverted my changes and checked once again and found the same behaviour means didn't found any hidden field, then I come to know that if the form is of type list then no hidden input generated for it if you change also-hidden=true, So it may be another issue You can check here, form type list https://localhost:28443/partymgr/control/FindSecurityGroup And its working fine for others form types. Thanks Ankit Jain Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4119.patch, OFBIZ-4119.patch If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4119) Form Widget hyperlink issue.
[ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4119: -- Attachment: OFBIZ-4119.patch Hello Jacques, This is the updated and working patch I have done the changes as Jacopo suggested, please have a look. In this patch I have completed the points of # Duplicate Ids. # Missing other templates/*FormMacroLibrary.ftl files Now if field id-name=abc and for hyperlink, display,... also-hidden=true then an hidden input created with id=h_abc. input id=h_abc value= / and for hidden / the same id will be set as given by developer. Thanks Jacopo , Jacques. Regards Ankit Jain Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4119.patch, OFBIZ-4119.patch If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4119) Form Widget hyperlink issue.
[ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983063#action_12983063 ] Ankit Jain commented on OFBIZ-4119: --- Hello Jacques, Thanks for committing the patch but you have missed the changes of the ModelForm.java Please have a look at the attached patch. Thanks Ankit Jain Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4119.patch If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4122) Duplicate view map entry in controller.
[ https://issues.apache.org/jira/browse/OFBIZ-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983064#action_12983064 ] Ankit Jain commented on OFBIZ-4122: --- Thanks Jacques :) Duplicate view map entry in controller. --- Key: OFBIZ-4122 URL: https://issues.apache.org/jira/browse/OFBIZ-4122 Project: OFBiz Issue Type: Bug Components: commonext/setup Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ_4122.patch Duplicate view map entry in the controller . view-map name=EditProductStore type=screen page=component://commonext/widget/ofbizsetup/SetupScreens.xml#EditProductStore/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4119) Form Widget hyperlink issue.
[ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983086#action_12983086 ] Ankit Jain commented on OFBIZ-4119: --- Hi Jacques, I have just seen the commit, and not read your comment properly(the word modified), May i know the reason why you didn't commit the changes of that file? FYI, the changes of the ModelForm.java file should be committed because to avoid the creation of a hidden input field with the same id as the a tag's. Regards Ankit Jain Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4119.patch If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4122) Duplicate view map entry in controller.
Duplicate view map entry in controller. --- Key: OFBIZ-4122 URL: https://issues.apache.org/jira/browse/OFBIZ-4122 Project: OFBiz Issue Type: Bug Components: commonext/setup Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: Release Branch 10.04, SVN trunk Duplicate view map entry in the controller . view-map name=EditProductStore type=screen page=component://commonext/widget/ofbizsetup/SetupScreens.xml#EditProductStore/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4122) Duplicate view map entry in controller.
[ https://issues.apache.org/jira/browse/OFBIZ-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4122: -- Attachment: OFBIZ_4122.patch Here is the Patch for the same. -- Ankit Jain Duplicate view map entry in controller. --- Key: OFBIZ-4122 URL: https://issues.apache.org/jira/browse/OFBIZ-4122 Project: OFBiz Issue Type: Bug Components: commonext/setup Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Priority: Trivial Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ_4122.patch Duplicate view map entry in the controller . view-map name=EditProductStore type=screen page=component://commonext/widget/ofbizsetup/SetupScreens.xml#EditProductStore/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4119) Form Widget hyperlink issue.
Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, SVN trunk If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4119) Form Widget hyperlink issue.
[ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-4119: -- Attachment: OFBIZ-4119.patch Here is the patch for the above issue. Form Widget hyperlink issue. Key: OFBIZ-4119 URL: https://issues.apache.org/jira/browse/OFBIZ-4119 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Ankit Jain Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4119.patch If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done, and the id attribute is not set in the a tag. By adding id attribute in the a tag then its helpful for developers to perform action on it using js or css. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3978) Ecommerce Migration
[ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12918002#action_12918002 ] Ankit Jain commented on OFBIZ-3978: --- Thanks Sascha Jacques. :) Ecommerce Migration --- Key: OFBIZ-3978 URL: https://issues.apache.org/jira/browse/OFBIZ-3978 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/ecommerce Reporter: Ankit Jain Assignee: Jacques Le Roux Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip All ecommerce js migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3978) Ecommerce Migration
Ecommerce Migration --- Key: OFBIZ-3978 URL: https://issues.apache.org/jira/browse/OFBIZ-3978 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/ecommerce Reporter: Ankit Jain All ecommerce js migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3978) Ecommerce Migration
[ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12917522#action_12917522 ] Ankit Jain commented on OFBIZ-3978: --- This task is for ecommerce js migration. Ecommerce Migration --- Key: OFBIZ-3978 URL: https://issues.apache.org/jira/browse/OFBIZ-3978 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/ecommerce Reporter: Ankit Jain All ecommerce js migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3978) Ecommerce Migration
[ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-3978: -- Attachment: CheckoutProcess.patch Hi Folks, Here is the patch for CheckoutProcess.js. HTH Ankit Jain :) Ecommerce Migration --- Key: OFBIZ-3978 URL: https://issues.apache.org/jira/browse/OFBIZ-3978 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/ecommerce Reporter: Ankit Jain Attachments: CheckoutProcess.patch All ecommerce js migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3978) Ecommerce Migration
[ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-3978: -- Attachment: CheckoutProcess.patch Hi Jacques, I dont think it will show any kind of error but we can handle the exception as a jQuery selector always returns an object rather it exists or not. We dont need to create any exist() function we can do it by checking the value greater then zero or not. So i used the .length to handle it and also updated the patch. Thanks for reminding! Ankit Jain :) Ecommerce Migration --- Key: OFBIZ-3978 URL: https://issues.apache.org/jira/browse/OFBIZ-3978 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/ecommerce Reporter: Ankit Jain Attachments: CheckoutProcess.patch, CheckoutProcess.patch All ecommerce js migration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3815) Content Navigation Tree implemented with jQuery
[
https://issues.apache.org/jira/browse/OFBIZ-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Jain updated OFBIZ-3815:
--
Attachment: OFBIZ_3815
Hello Folks,
I have updated the Sascha's Patch and now all the tree functionality is working
as it was in Dojo.
Ankit Jain :)
Content Navigation Tree implemented with jQuery
---
Key: OFBIZ-3815
URL: https://issues.apache.org/jira/browse/OFBIZ-3815
Project: OFBiz
Issue Type: Sub-task
Components: content
Affects Versions: jQuery
Reporter: Sascha Rodekamp
Assignee: Erwan de FERRIERES
Fix For: jQuery
Attachments: OFBIZ-3815_jqueryExample_ContentNavigation.patch,
OFBIZ-3815_jqueryExample_ContentNavigation.patch, OFBIZ-3815_plugins.zip,
OFBIZ-3815_plugins.zip, OFBIZ_3815
Hi,
here is the first (test) patch for the jQuery implementation.
I changed the content navigation tree for a first test:
[https://localhost:8443/content/control/navigateContent]
The implementation was much easier than expected :-)
I choose the jsTree Plugin v. 1.0rc (in the next days their will be a final
1.0 release, that's why i choose the rc).
[http://www.jstree.com/]
I also added
{code}
jQuery.noConflict();
{code}
to the libary. That overwrites the '$( ... )' operator to prevent conflicts
with prototype. This line can be deleted after prototype is totally replaced.
For know we have to call jQuery via jQuery( ) instead of $( ... ).
To apply the patch the zip file have to copied to /images/jquery/
it contains a plugin folder with the jsTree plugin
(should look like /images/jquery/plugins/jsTree)
So long
Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3247) State field is missing - Not in List or N/A
[ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903359#action_12903359 ] Ankit Jain commented on OFBIZ-3247: --- Hi Jacques, I have checked it again at https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/NewEmployee and i found the same behaviour as i mentioned above. Is it possible the site is not updated? Ankit Jain :) State field is missing - Not in List or N/A --- Key: OFBIZ-3247 URL: https://issues.apache.org/jira/browse/OFBIZ-3247 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: SVN trunk Reporter: Sam Hamilton Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3247.patch When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3247) State field is missing - Not in List or N/A
[ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903372#action_12903372 ] Ankit Jain commented on OFBIZ-3247: --- Yes Jacques its working i dont know about this that it will disappear when there is no states of the country. Thanks Ankit Jain:) State field is missing - Not in List or N/A --- Key: OFBIZ-3247 URL: https://issues.apache.org/jira/browse/OFBIZ-3247 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: SVN trunk Reporter: Sam Hamilton Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: Australia.jpg, OFBIZ-3247.patch When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3247) State field is missing - Not in List or N/A
[ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903207#action_12903207 ] Ankit Jain commented on OFBIZ-3247: --- Hi Jacques, I checked at the demo site the State dropdown disappears as the page loads, and no result of selecting any country too, i think dependent select is not working here or may be something else. Ankit Jain :) State field is missing - Not in List or N/A --- Key: OFBIZ-3247 URL: https://issues.apache.org/jira/browse/OFBIZ-3247 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: SVN trunk Reporter: Sam Hamilton Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3247.patch When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3161) We should check that the thru date is not older than the from date
[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901024#action_12901024 ] Ankit Jain commented on OFBIZ-3161: --- Hello Jacques, Thanks to look into it , i'll upadte my patch for error message, Jacques in our form-widget the ids are auto generated and is something like formName_fieldName , so how could you query through ids. Currently the code is handling two field FromDate and ThruDate , but it may be possible if anyone want to use it for WorkEffort StartDate and EndDate than? so i talked about generalised solution . As we do in ftls we add a class for field and in js we can fetch fields that have our class and do the operations accordingly , that something i was saying and if possible we'll apply here , So anyone can use for checking two date fields which have different names. Its weekend so i'll try it on Monday. Happy Weekend Thanks Regards Ankit Jain We should check that the thru date is not older than the from date -- Key: OFBIZ-3161 URL: https://issues.apache.org/jira/browse/OFBIZ-3161 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3161.patch, OFBIZ-3161.patch In any places we use a from and thru dates, we should check that the thru date is not older than the from date -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3161) We should check that the thru date is not older than the from date
[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-3161: -- Attachment: OFBIZ-3161.patch Hello All, This is something needed at many places , i created a patch in jquery and as i tested at many places its working fine . Currently the code is specific to fields having name fromDate and thruDate, further we can improve the code and make it generic. The patch is a sample and we can improve it further. Thanks Regards Ankit Jain :) We should check that the thru date is not older than the from date -- Key: OFBIZ-3161 URL: https://issues.apache.org/jira/browse/OFBIZ-3161 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3161.patch In any places we use a from and thru dates, we should check that the thru date is not older than the from date -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3161) We should check that the thru date is not older than the from date
[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-3161: -- Attachment: OFBIZ-3161.patch Sorry I missed one file in my patch, so this is the updated patch. Thanks Ankit Jain :) We should check that the thru date is not older than the from date -- Key: OFBIZ-3161 URL: https://issues.apache.org/jira/browse/OFBIZ-3161 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-3161.patch, OFBIZ-3161.patch In any places we use a from and thru dates, we should check that the thru date is not older than the from date -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3247) State field is missing - Not in List or N/A
[ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-3247: -- Attachment: OFBIZ-3247.patch Hello Sam, The Not Applicable is present in the entity Geo but its not present in the State drop-down, because the fetching was done on the constraint which is fetch all GeoIds having GeoTypeId in STATE, PROVINCE, and the _NA_ dont have any GeoTypeId, so its not there. You can just add an option tag and give the value hard coded. So i dont think that its a bug anymore. But here is the patch which can solve the issue. Thanks Regards Ankit Jain :) State field is missing - Not in List or N/A --- Key: OFBIZ-3247 URL: https://issues.apache.org/jira/browse/OFBIZ-3247 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: Sam Hamilton Priority: Trivial Attachments: OFBIZ-3247.patch When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3819) Missing not-in operator in condtion-expr tag.
Missing not-in operator in condtion-expr tag. --- Key: OFBIZ-3819 URL: https://issues.apache.org/jira/browse/OFBIZ-3819 Project: OFBiz Issue Type: Improvement Reporter: Ankit Jain Priority: Minor In the condition-expr tag the not-in operator is not working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3819) Missing not-in operator in condtion-expr tag.
[ https://issues.apache.org/jira/browse/OFBIZ-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated OFBIZ-3819: -- Attachment: not_in(3819).patch Now the not-in operator is working. Please find the attached patch for it. Thanks Ankit Jain :) Missing not-in operator in condtion-expr tag. --- Key: OFBIZ-3819 URL: https://issues.apache.org/jira/browse/OFBIZ-3819 Project: OFBiz Issue Type: Improvement Reporter: Ankit Jain Priority: Minor Attachments: not_in(3819).patch In the condition-expr tag the not-in operator is not working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3819) Missing not-in operator in condtion-expr tag.
[ https://issues.apache.org/jira/browse/OFBIZ-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12877800#action_12877800 ] Ankit Jain commented on OFBIZ-3819: --- Thanks Jacques HTH :) Missing not-in operator in condtion-expr tag. --- Key: OFBIZ-3819 URL: https://issues.apache.org/jira/browse/OFBIZ-3819 Project: OFBiz Issue Type: Improvement Reporter: Ankit Jain Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk Attachments: not_in(3819).patch In the condition-expr tag the not-in operator is not working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
