[jira] [Commented] (OFBIZ-3847) Entity ECAs not triggered correctly when using Delegator.storeAll() method
[
https://issues.apache.org/jira/browse/OFBIZ-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114427#comment-13114427
]
Anne Jessel commented on OFBIZ-3847:
This bug is one I'd like to fix. Scott's suggestion looks good to me. Anyone
have any comments or better ideas before I go ahead and implement it?
Entity ECAs not triggered correctly when using Delegator.storeAll() method
--
Key: OFBIZ-3847
URL: https://issues.apache.org/jira/browse/OFBIZ-3847
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Release Branch 10.04
Reporter: Martin Kreidenweis
Attachments: GenericDelegator.java.diff
The conditions don't work when updating (not creating) entities using the
Delegator.storeAll() method. E.g. the following condition does not work:
{code}
eca entity=Product operation=create-store event=return
condition field-name=autoCreateKeywords operator=not-equals
value=N/
action service=indexProductKeywords mode=sync
value-attr=productInstance/
/eca
{code}
The indexProductKeywords service is called anyway when the product is updated
and the autoCreateKeywords was N and stays N. It works correctly for
newly created products.
The problem is in the method GenericDelegator.storeAll(), where unchanged
field values are not passed down to the store() method. The store method
calls the ECA engine, which does not receive the unchanged values at all and
thus cannot evaluate the EECA conditions correctly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4412) Set initial ecommerce Locale/Currency based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm
[ https://issues.apache.org/jira/browse/OFBIZ-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105003#comment-13105003 ] Anne Jessel commented on OFBIZ-4412: I presume this would also work with mount-point /au having locale en-AU, mount-point /us having locale en-US, and mount-point /gb having locale en-GB (and corresponding currencies)? Set initial ecommerce Locale/Currency based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm --- Key: OFBIZ-4412 URL: https://issues.apache.org/jira/browse/OFBIZ-4412 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk Environment: Not specific Reporter: mz4wheeler Priority: Trivial Labels: patch Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-4412.patch Original Estimate: 2h Remaining Estimate: 2h Using the specified patch, it is now possible to set a users initial Locale (and even currency) based on the webapp mount point. This works with a single store, and does not require the use virtual hosts. This is especially useful when setting up sitemap.xml, which allows crawlers (like google) to correctly locate and traverse products and services in multiple languages. Here is an example where ecomclone has been modified to Locale=fr with a mount point of /fr. specialpurpose/ecommerce/ofbiz-component.xml: !-- init-param name=Currency value=EUR/ -- webapp name=ecommerce title=eCommerce server=default-server location=webapp/ecommerce mount-point=/ecommerce app-bar-display=false /webapp webapp name=ecomclone title=eCommerce Clone server=default-server location=webapp/ecomclone mount-point=/fr--- SPECIFY MOUNT app-bar-display=false init-param name=Locale value=fr/ --- SPECIFY LOCALE /webapp The below sitemap.xml would allow products with the /fr path to be indexed in french. ?xml version=1.0 encoding=UTF-8? urlset xmlns=http://www.sitemaps.org/schemas/sitemap/0.9; urllochttp://ofbizsite.com/ecommerce/products/10002/p_1001TANGRAMPUZ/loc/url urllochttp://ofbizsite.com/fr/products/10002/p_1001TANGRAMPUZ/loc/url /urlset The patch: The attached patch modifies setDefaultStoreSettings in ProductEvents.java, which is called once during the initial session creation. After a user enters the URL, they are still free to modify the language, as long as the page supports it (like the default demo store). The patch also allows the Currency to be forced as well, and it does appear to work, but should be more throughly tested. Although this patch bypasses the requirement for multiple stores, there may be issues with other aspects of the store, like emails. However, it is no different than a user who enters your English-based ecommerce store, selects french, and attempts a checkout. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4394) Replace newnote.ftl with form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097048#comment-13097048 ] Anne Jessel commented on OFBIZ-4394: I don't know either way. The permission test was in the ftl, so I copied it into the screen. If it shouldn't be there, then that's also a bug in newnote.ftl. Replace newnote.ftl with form widget Key: OFBIZ-4394 URL: https://issues.apache.org/jira/browse/OFBIZ-4394 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: REV 1165137 Reporter: Anne Jessel Priority: Trivial Attachments: OFBIZ-4394-replace-newnoteftl-with-formwidget.patch Original Estimate: 0.5h Remaining Estimate: 0.5h This patch replaces ordermgr newnote.ftl with a form widget. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4393) View entity condition-expr doesn't handle null
View entity condition-expr doesn't handle null -- Key: OFBIZ-4393 URL: https://issues.apache.org/jira/browse/OFBIZ-4393 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1165137 Reporter: Anne Jessel condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4393) View entity condition-expr doesn't handle null
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4393: --- Attachment: OFBIZ-4393-view-entity_condition-expr_null.patch This patch replaces relevant tests for null with UtilValidate.is(Not)Empty. IMPORTANT: if any code relies on a missing value attribute being converted to an empty string that is then used, then this patch will break that. I did look, and couldn't find any such code OOTB. View entity condition-expr doesn't handle null -- Key: OFBIZ-4393 URL: https://issues.apache.org/jira/browse/OFBIZ-4393 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1165137 Reporter: Anne Jessel Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch Original Estimate: 2h Remaining Estimate: 2h condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13096984#comment-13096984 ] Anne Jessel commented on OFBIZ-4393: value=null definitely doesn't work. It's what I tried first before looking at the code. Is that what should work? The current code compares value variable with null, but I can't see how value can ever be null, as it has the value returned by org.w3c.dom.Element.getAttribute, which doesn't return null. I can change patch so it looks for String null instead of using isEmpty. View entity condition-expr doesn't handle null -- Key: OFBIZ-4393 URL: https://issues.apache.org/jira/browse/OFBIZ-4393 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1165137 Reporter: Anne Jessel Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch Original Estimate: 2h Remaining Estimate: 2h condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4394) Replace newnote.ftl with form widget
Replace newnote.ftl with form widget Key: OFBIZ-4394 URL: https://issues.apache.org/jira/browse/OFBIZ-4394 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: REV 1165137 Reporter: Anne Jessel Priority: Trivial This patch replaces ordermgr newnote.ftl with a form widget. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4394) Replace newnote.ftl with form widget
[ https://issues.apache.org/jira/browse/OFBIZ-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4394: --- Attachment: OFBIZ-4394-replace-newnoteftl-with-formwidget.patch Replace newnote.ftl with form widget Key: OFBIZ-4394 URL: https://issues.apache.org/jira/browse/OFBIZ-4394 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: REV 1165137 Reporter: Anne Jessel Priority: Trivial Attachments: OFBIZ-4394-replace-newnoteftl-with-formwidget.patch Original Estimate: 0.5h Remaining Estimate: 0.5h This patch replaces ordermgr newnote.ftl with a form widget. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4373) Duplicate quote leads to editing original instead of copy
[ https://issues.apache.org/jira/browse/OFBIZ-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088500#comment-13088500 ] Anne Jessel commented on OFBIZ-4373: Just discovered this problem was actually fixed as a side-effect of OFBIZ-4357, committed in Rev 1152729. Duplicate quote leads to editing original instead of copy - Key: OFBIZ-4373 URL: https://issues.apache.org/jira/browse/OFBIZ-4373 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4373_DuplicateQuoteEditCopy.patch Currently if you duplicate a quote, you are then prompted to edit the original quote. This patch instead displays the newly-created quote for editing. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4372) Order terms not displayed correctly
[ https://issues.apache.org/jira/browse/OFBIZ-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4372: --- Attachment: OFBIZ-4372_OrderTermsDisplay.patch Replaced git-format patch with svn patch. New patch is against REV 1160087. Order terms not displayed correctly --- Key: OFBIZ-4372 URL: https://issues.apache.org/jira/browse/OFBIZ-4372 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4372_OrderTermsDisplay.patch, OFBIZ-4372_OrderTermsDisplay.patch If an order is created from a quote with terms, the terms copied to the order do not display correctly. This is because the ordermgr displays the textValue field against the Description label, and does not display the description field at all. The patch alters the display of terms within the ordermgr so that the textValue field is labelled as the Text Value, and the description field is displayed for the Description label. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4374) Support filtering on non-std date field names in performFind and prepareFind
[ https://issues.apache.org/jira/browse/OFBIZ-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4374: --- Attachment: OFBIZ-4374_FilterNonStdDateFieldNames.patch Replaced git-format patch with svn-format patch, against REV 1160087. Support filtering on non-std date field names in performFind and prepareFind Key: OFBIZ-4374 URL: https://issues.apache.org/jira/browse/OFBIZ-4374 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Trivial Attachments: OFBIZ-4374_FilterNonStdDateFieldNames.patch, OFBIZ-4374_FilterNonStdDateFieldNames.patch I had a need to filter by date ranges for entities that didn't follow the standard fromDate and thruDate field-naming pattern. I therefore enhanced prepareFind and performFind services so they could be passed the names of the fields to use in place of fromDate and thruDate when the filterByDate option was chosen. Thought this might be useful to others, even though it isn't currently used in OOTB code. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4373) Duplicate quote leads to editing original instead of copy
[ https://issues.apache.org/jira/browse/OFBIZ-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel closed OFBIZ-4373. -- Resolution: Fixed Fix Version/s: SVN trunk Fixed as a side-effect of OFBIZ-4357 in REV 1152729 Duplicate quote leads to editing original instead of copy - Key: OFBIZ-4373 URL: https://issues.apache.org/jira/browse/OFBIZ-4373 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4373_DuplicateQuoteEditCopy.patch Currently if you duplicate a quote, you are then prompted to edit the original quote. This patch instead displays the newly-created quote for editing. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4370) Support Notes on Quotes
[ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4370: --- Attachment: OFBIZ-4370_QuoteNotes.patch Updated patch, svn format. Support Notes on Quotes --- Key: OFBIZ-4370 URL: https://issues.apache.org/jira/browse/OFBIZ-4370 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch Original Estimate: 1h Remaining Estimate: 1h Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4373) Duplicate quote leads to editing original instead of copy
[ https://issues.apache.org/jira/browse/OFBIZ-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4373: --- Attachment: OFBIZ-4373_DuplicateQuoteEditCopy.patch Duplicate quote leads to editing original instead of copy - Key: OFBIZ-4373 URL: https://issues.apache.org/jira/browse/OFBIZ-4373 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4373_DuplicateQuoteEditCopy.patch Currently if you duplicate a quote, you are then prompted to edit the original quote. This patch instead displays the newly-created quote for editing. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4373) Duplicate quote leads to editing original instead of copy
Duplicate quote leads to editing original instead of copy - Key: OFBIZ-4373 URL: https://issues.apache.org/jira/browse/OFBIZ-4373 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4373_DuplicateQuoteEditCopy.patch Currently if you duplicate a quote, you are then prompted to edit the original quote. This patch instead displays the newly-created quote for editing. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4374) Support filtering on non-std date field names in performFind and prepareFind
Support filtering on non-std date field names in performFind and prepareFind Key: OFBIZ-4374 URL: https://issues.apache.org/jira/browse/OFBIZ-4374 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Trivial I had a need to filter by date ranges for entities that didn't follow the standard fromDate and thruDate field-naming pattern. I therefore enhanced prepareFind and performFind services so they could be passed the names of the fields to use in place of fromDate and thruDate when the filterByDate option was chosen. Thought this might be useful to others, even though it isn't currently used in OOTB code. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4374) Support filtering on non-std date field names in performFind and prepareFind
[ https://issues.apache.org/jira/browse/OFBIZ-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4374: --- Attachment: OFBIZ-4374_FilterNonStdDateFieldNames.patch Support filtering on non-std date field names in performFind and prepareFind Key: OFBIZ-4374 URL: https://issues.apache.org/jira/browse/OFBIZ-4374 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Trivial Attachments: OFBIZ-4374_FilterNonStdDateFieldNames.patch I had a need to filter by date ranges for entities that didn't follow the standard fromDate and thruDate field-naming pattern. I therefore enhanced prepareFind and performFind services so they could be passed the names of the fields to use in place of fromDate and thruDate when the filterByDate option was chosen. Thought this might be useful to others, even though it isn't currently used in OOTB code. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4370) Support Notes on Quotes
[ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086904#comment-13086904 ] Anne Jessel commented on OFBIZ-4370: Thanks for the feedback, Adrian. I would normally have used screen widgets instead of freemarker, but in this case much of the code was copied from Orders and Order replaced with Quote. I'll update as you suggest. Would it be worthwhile me updating some of the existing Orders code as well while I'm at it? I'm thinking in particular of replacing webapp/ordermgr/order/newnote.ftl with a screen widget. Support Notes on Quotes --- Key: OFBIZ-4370 URL: https://issues.apache.org/jira/browse/OFBIZ-4370 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4370_QuoteNotes.patch Original Estimate: 1h Remaining Estimate: 1h Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4370) Support Notes on Quotes
[ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4370: --- Attachment: OFBIZ-4370_QuoteNotes.patch Updated patch. It no longer copies style used with notes for orders. Main changes: - no freemarker - new service createQuoteNote is now minilang - less new labels My limited understanding of entity-auto services suggests it can't be used for createQuoteNote, which creates two entities. Support Notes on Quotes --- Key: OFBIZ-4370 URL: https://issues.apache.org/jira/browse/OFBIZ-4370 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch Original Estimate: 1h Remaining Estimate: 1h Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4370) Support Notes on Quotes
Support Notes on Quotes --- Key: OFBIZ-4370 URL: https://issues.apache.org/jira/browse/OFBIZ-4370 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4370) Support Notes on Quotes
[ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4370: --- Attachment: OFBIZ-4370_QuoteNotes.patch Patch is in git format. Hope this is okay. If not, let me know and I'll redo it. Support Notes on Quotes --- Key: OFBIZ-4370 URL: https://issues.apache.org/jira/browse/OFBIZ-4370 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4370_QuoteNotes.patch Original Estimate: 1h Remaining Estimate: 1h Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4372) Order terms not displayed correctly
Order terms not displayed correctly --- Key: OFBIZ-4372 URL: https://issues.apache.org/jira/browse/OFBIZ-4372 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4372_OrderTermsDisplay.patch If an order is created from a quote with terms, the terms copied to the order do not display correctly. This is because the ordermgr displays the textValue field against the Description label, and does not display the description field at all. The patch alters the display of terms within the ordermgr so that the textValue field is labelled as the Text Value, and the description field is displayed for the Description label. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4372) Order terms not displayed correctly
[ https://issues.apache.org/jira/browse/OFBIZ-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4372: --- Attachment: OFBIZ-4372_OrderTermsDisplay.patch Order terms not displayed correctly --- Key: OFBIZ-4372 URL: https://issues.apache.org/jira/browse/OFBIZ-4372 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: REV 1152668 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4372_OrderTermsDisplay.patch If an order is created from a quote with terms, the terms copied to the order do not display correctly. This is because the ordermgr displays the textValue field against the Description label, and does not display the description field at all. The patch alters the display of terms within the ordermgr so that the textValue field is labelled as the Text Value, and the description field is displayed for the Description label. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (OFBIZ-4022) Collapse all broken if hyperlink in pane
Collapse all broken if hyperlink in pane Key: OFBIZ-4022 URL: https://issues.apache.org/jira/browse/OFBIZ-4022 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1035845 Reporter: Anne Jessel Priority: Minor To reproduce the bug: - edit the EditProduct form in applications/product/widget/catalog/ProductForms.xml - add a new field with a hyperlink sub-element. - refer to this new field in the first, non-collapsible field-group in the sort-order - go to this page in the UI (edit a product in the catalog) - the Expand All and Collapse All buttons do not work properly The problem is caused by the javascript finding the added hyperlink field in the first field-group, and incorrectly assuming it is the expand/collapse link for the field-group. This causes the javascript to crash when it gets a null reference to an enclosing li element. It is not specific to the EditProduct form, but applies to any group of collapsible panes where one contains a hyperlink. The attached patch simply checks that the li element actually exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4022) Collapse all broken if hyperlink in pane
[ https://issues.apache.org/jira/browse/OFBIZ-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4022: --- Attachment: OFBIZ-4022_collapse-all-broken.patch Collapse all broken if hyperlink in pane Key: OFBIZ-4022 URL: https://issues.apache.org/jira/browse/OFBIZ-4022 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1035845 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4022_collapse-all-broken.patch Original Estimate: 0.33h Remaining Estimate: 0.33h To reproduce the bug: - edit the EditProduct form in applications/product/widget/catalog/ProductForms.xml - add a new field with a hyperlink sub-element. - refer to this new field in the first, non-collapsible field-group in the sort-order - go to this page in the UI (edit a product in the catalog) - the Expand All and Collapse All buttons do not work properly The problem is caused by the javascript finding the added hyperlink field in the first field-group, and incorrectly assuming it is the expand/collapse link for the field-group. This causes the javascript to crash when it gets a null reference to an enclosing li element. It is not specific to the EditProduct form, but applies to any group of collapsible panes where one contains a hyperlink. The attached patch simply checks that the li element actually exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4023) Wrong product displayed as associated product
Wrong product displayed as associated product - Key: OFBIZ-4023 URL: https://issues.apache.org/jira/browse/OFBIZ-4023 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Environment: Rev 1035845 Reporter: Anne Jessel Priority: Minor To reproduce: - add two associated products to a main product, both with Complementary or Cross-Sell association type - view the main product in ecommerce Expected behaviour: the two associated products are listed near the bottom of the page Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product. The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated. I will attach a patch which does fix the problem, by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4023) Wrong product displayed as associated product
[ https://issues.apache.org/jira/browse/OFBIZ-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4023: --- Attachment: OFBIZ-4023_Wrong-product-displayed-as-assoc-product.patch Wrong product displayed as associated product - Key: OFBIZ-4023 URL: https://issues.apache.org/jira/browse/OFBIZ-4023 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Environment: Rev 1035845 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4023_Wrong-product-displayed-as-assoc-product.patch To reproduce: - add two associated products to a main product, both with Complementary or Cross-Sell association type - view the main product in ecommerce Expected behaviour: the two associated products are listed near the bottom of the page Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product. The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated. I will attach a patch which does fix the problem, by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4024) Improve handling and display of additional product images
Improve handling and display of additional product images - Key: OFBIZ-4024 URL: https://issues.apache.org/jira/browse/OFBIZ-4024 Project: OFBiz Issue Type: Improvement Components: product, specialpurpose/ecommerce Affects Versions: SVN trunk Environment: Rev 1035845 Reporter: Anne Jessel Priority: Minor This patch adds several closely-related features, intended to improve the display of products and their images in the ecommerce webapp. When additional images for a product are uploaded via the Catalog, the scaled versions that were already being created in service addAdditionalViewForProduct are now recorded as ProductContent. This makes them easily available for use elsewhere. New ProductContentType values were added to identify these content types. The obviously consistent string to use for these was too long, and so I had to choose something less consistent, but shorter and hopefully still clear. I used XTRA instead of ADDITIONAL. The sizes to which additional images are rescaled has been changed, so they better fit in the ecommerce display. Relevant sizes in productdetail.ftl have been updated to match these sizes. The ecommerce product display now uses the scaled additional images if available, rather than relying on the web browser to scale the images. When displaying a single product in ecommerce, the main image is larger than the additional images. Hovering over an additional image displays a larger version in place of the main image. Clicking on an additional image displays a popup with a detailed version of the image. To use the new features, one or more large images (suggest at least 600x600) should be attached as additional images to a product, using the form on the bottom of the content tab for a product in Catalog. Viewing the product in ecommerce should then exhibit the above behaviour. I have tried to maintain backwards compatibility, so that products with the old-style use of additional images will continue to display as they did previously. This means some of the code is not as streamlined as it might be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4024) Improve handling and display of additional product images
[ https://issues.apache.org/jira/browse/OFBIZ-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4024: --- Attachment: OFBIZ-4024_additional-images-enhancements.patch Improve handling and display of additional product images - Key: OFBIZ-4024 URL: https://issues.apache.org/jira/browse/OFBIZ-4024 Project: OFBiz Issue Type: Improvement Components: product, specialpurpose/ecommerce Affects Versions: SVN trunk Environment: Rev 1035845 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4024_additional-images-enhancements.patch This patch adds several closely-related features, intended to improve the display of products and their images in the ecommerce webapp. When additional images for a product are uploaded via the Catalog, the scaled versions that were already being created in service addAdditionalViewForProduct are now recorded as ProductContent. This makes them easily available for use elsewhere. New ProductContentType values were added to identify these content types. The obviously consistent string to use for these was too long, and so I had to choose something less consistent, but shorter and hopefully still clear. I used XTRA instead of ADDITIONAL. The sizes to which additional images are rescaled has been changed, so they better fit in the ecommerce display. Relevant sizes in productdetail.ftl have been updated to match these sizes. The ecommerce product display now uses the scaled additional images if available, rather than relying on the web browser to scale the images. When displaying a single product in ecommerce, the main image is larger than the additional images. Hovering over an additional image displays a larger version in place of the main image. Clicking on an additional image displays a popup with a detailed version of the image. To use the new features, one or more large images (suggest at least 600x600) should be attached as additional images to a product, using the form on the bottom of the content tab for a product in Catalog. Viewing the product in ecommerce should then exhibit the above behaviour. I have tried to maintain backwards compatibility, so that products with the old-style use of additional images will continue to display as they did previously. This means some of the code is not as streamlined as it might be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4025) Is Empty for text-find widget broken
Is Empty for text-find widget broken Key: OFBIZ-4025 URL: https://issues.apache.org/jira/browse/OFBIZ-4025 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1036293 Reporter: Anne Jessel Priority: Minor To reproduce: - go to Facility, Inventory Items tab (or any form that uses text-find widget) - choose Is Empty from drop-down next to Product Id - click Find button Expected behaviour: no matching items listed, as all items have a Product Id. Observed behaviour: all items match. Problem is caused by find code assuming that there is no entity condition to be created if the text field is empty, but of course Is Empty is different to the other operators in that the text field is expected to be empty. The attached patch adds a special check for the Is Empty operator. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4025) Is Empty for text-find widget broken
[ https://issues.apache.org/jira/browse/OFBIZ-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4025: --- Attachment: OFBIZ-4025_Is-Empty-for-text-find-broken.patch Is Empty for text-find widget broken Key: OFBIZ-4025 URL: https://issues.apache.org/jira/browse/OFBIZ-4025 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1036293 Reporter: Anne Jessel Priority: Minor Attachments: OFBIZ-4025_Is-Empty-for-text-find-broken.patch To reproduce: - go to Facility, Inventory Items tab (or any form that uses text-find widget) - choose Is Empty from drop-down next to Product Id - click Find button Expected behaviour: no matching items listed, as all items have a Product Id. Observed behaviour: all items match. Problem is caused by find code assuming that there is no entity condition to be created if the text field is empty, but of course Is Empty is different to the other operators in that the text field is expected to be empty. The attached patch adds a special check for the Is Empty operator. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-4018) title-property should be titleProperty
title-property should be titleProperty -- Key: OFBIZ-4018 URL: https://issues.apache.org/jira/browse/OFBIZ-4018 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: Rev 1035845 Reporter: Anne Jessel Priority: Minor Some screen widgets set the field title-property instead of titleProperty. This causes errors in the logs, and means that the page title is not being set. Patch attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
Reserved words used for field names in PaymentGatewayOrbital Key: OFBIZ-2888 URL: https://issues.apache.org/jira/browse/OFBIZ-2888 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Environment: Linux, Java 1.6, Postgresql 8.3 with driver postgresql-8.3-604.jdbc4.jar Reporter: Anne Jessel Priority: Minor On starting Rev 809782 of trunk, I see the following warnings: 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= Found 2 warnings when checking the entity definitions: 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a reserved word. 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2748) Wrong calculation in UtilDateTime getIntervalInDays
Wrong calculation in UtilDateTime getIntervalInDays --- Key: OFBIZ-2748 URL: https://issues.apache.org/jira/browse/OFBIZ-2748 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04 Environment: Sun Java 6, Linux, Postgres Reporter: Anne Jessel If the two timestamps passed to getIntervalInDays are more than Integer.MAX_VALUE nanoseconds apart, the returned value is incorrect. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2748) Wrong calculation in UtilDateTime getIntervalInDays
[ https://issues.apache.org/jira/browse/OFBIZ-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-2748: --- Attachment: castbug.patch This patch (castbug.patch) fixes the problem Wrong calculation in UtilDateTime getIntervalInDays --- Key: OFBIZ-2748 URL: https://issues.apache.org/jira/browse/OFBIZ-2748 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04 Environment: Sun Java 6, Linux, Postgres Reporter: Anne Jessel Attachments: castbug.patch If the two timestamps passed to getIntervalInDays are more than Integer.MAX_VALUE nanoseconds apart, the returned value is incorrect. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2749) genericBasePermissionCheck does not work as documented
genericBasePermissionCheck does not work as documented -- Key: OFBIZ-2749 URL: https://issues.apache.org/jira/browse/OFBIZ-2749 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04 Environment: Java 6, Linux, Postgres Reporter: Anne Jessel The comments for genericBasePermissionCheck state that it can be used as a simple method or as a service, but if parameters map is not set, it does not behave properly, and hence does not work when called as a simple method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2749) genericBasePermissionCheck does not work as documented
[ https://issues.apache.org/jira/browse/OFBIZ-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-2749: --- Attachment: permissions.patch This patch (permissions.patch) fixes the problem. genericBasePermissionCheck does not work as documented -- Key: OFBIZ-2749 URL: https://issues.apache.org/jira/browse/OFBIZ-2749 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 9.04 Environment: Java 6, Linux, Postgres Reporter: Anne Jessel Attachments: permissions.patch The comments for genericBasePermissionCheck state that it can be used as a simple method or as a service, but if parameters map is not set, it does not behave properly, and hence does not work when called as a simple method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1737) Two Australian states missing from drop-down list
Two Australian states missing from drop-down list --- Key: OFBIZ-1737 URL: https://issues.apache.org/jira/browse/OFBIZ-1737 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Anne Jessel Priority: Minor Two Australian states, namely the Australian Capital Territory (AU-ACT) and Northern Territory (AU-NT) are not included in the dropdown list of states shown in many places when entering an address. They are included in the Geo entity, but as type TERRITORY, which is technically correct. The dropdown list only shows STATEs and PROVINCEs. I am attaching a patch which includes TERRITORYs in the drop down list. This approach seemed more correct than changing the ACT and NT records from TERRITORY to STATE, even though they seem to be the only TERRITORY records in the included data. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1737) Two Australian states missing from drop-down list
[ https://issues.apache.org/jira/browse/OFBIZ-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-1737: --- Attachment: territory.patch Includes TERRITORYs in list of states so that the Australian Territories (ACT and NT) will be included. Two Australian states missing from drop-down list --- Key: OFBIZ-1737 URL: https://issues.apache.org/jira/browse/OFBIZ-1737 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Anne Jessel Priority: Minor Attachments: territory.patch Original Estimate: 0.25h Remaining Estimate: 0.25h Two Australian states, namely the Australian Capital Territory (AU-ACT) and Northern Territory (AU-NT) are not included in the dropdown list of states shown in many places when entering an address. They are included in the Geo entity, but as type TERRITORY, which is technically correct. The dropdown list only shows STATEs and PROVINCEs. I am attaching a patch which includes TERRITORYs in the drop down list. This approach seemed more correct than changing the ACT and NT records from TERRITORY to STATE, even though they seem to be the only TERRITORY records in the included data. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1669) services.xsd references www.ofbiz.org
services.xsd references www.ofbiz.org - Key: OFBIZ-1669 URL: https://issues.apache.org/jira/browse/OFBIZ-1669 Project: OFBiz Issue Type: Bug Reporter: Anne Jessel Priority: Trivial The services.xsd file currently at http://ofbiz.apache.org/dtds/ has an xs:include reference to http://www.ofbiz.org/dtds/service-group.xsd. I think the host should be ofbiz.apache.org. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
