Re: OFBiz and Camel integration updated
hi all, I will not have time to work on integrating the repo into Ofbiz, but if anybody wants to do it, feel free to do so. Use the code in my repo as you wish. Bilgin On Wed, Aug 14, 2019 at 1:46 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Moving it to DEV list. My apologies if it is a nuisance. > > I have attached plugin tar to the ticket for everybody to take a look at. > Please review and try to run the plug-in and see if there is any issue with > it. > > Best, > Girish > > - Forwarded message - > From: Girish Vasmatkar > Date: Mon, Aug 5, 2019 at 9:38 PM > Subject: Re: OFBiz and Camel integration updated > To: ofbizuser > > > I've created OFBIZ-11147 < > https://issues.apache.org/jira/browse/OFBIZ-11147> to > track camel integration. I will provide the plug in along with relevant > details. > > Best, > Girish > > On Sat, Aug 3, 2019 at 5:07 PM Mathieu Lirzin > wrote: > > > Hello, > > > > Girish Vasmatkar writes: > > > > > Thanks Bilgin for taking care of pull request. If everyone is okay with > > the > > > changes, I will go ahead and create a ticket for the same to add it as > an > > > ofbiz plugin. Let me know of any issues or concerns anyone may have. > > > > > > While writing a few test cases for the various camel components (and I > am > > > using CamelTestSupport), it turned out OFBiz test container does not > pick > > > them up because it is still based on inheritance (extending TestCase) > and > > > not on annotation (any class with @Test annotated methods). I will > > probably > > > elaborate further in a separate thread, but I feel we need to add > support > > > for considering such classes as part of test suite as well. We are > using > > > JUnit 4 but it is hardly being used except for being available on the > > > classpath. Using JUnit 4 classes will make sure both mechanisms will be > > > supported. > > > > Supporting the JUnit4 runner API which make use of annotations would be > > nice if it helps improving the *sad* state of OFBiz integration tests in > > term of error reporting. > > > > For the record Junit4 annotations are already supported by OFBiz unit > > tests run by ‘./gradlew test’ which by the way should be preferred over > > integration tests in most cases because they run faster. > > > > As a side note, please avoid cross-posting to ‘devel’ and ‘user’ mailing > > lists. > > > > Thanks. > > > > -- > > Mathieu Lirzin > > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 > > > -- Bilgin Ibryam ASF Member | Architect at Red Hat http://ofbizian.com | @bibryam <https://twitter.com/bibryam> Kubernetes Patterns http://shop.oreilly.com/product/0636920242598.do Camel Design Patterns https://leanpub.com/camel-design-patterns
Re: OFBiz Premier League – Reviewers Choice Award
at the following >>>>> link: >>>>> >>>>> https://drive.google.com/drive/folders/0BxupAk96lggNTm0zT3A2alNRY1k >>>>> >>>>> Please take a look at the reports and then assign your rating score for >>>>> each team. (I've taken a quick preview of the reports already and it's >>>>> going to be a tough decision!). All the scores will be totalled and the >>>>> winning team will be the one with the most points. The scores and >>>>> winner >>>>> will be announced on the OFBiz mailing lists. >>>>> >>>>> *IMPORTANT NOTE*: All the Hotwax team members who are involved with any >>>> >>>> of >>>>> >>>>> the OPL teams _*will not*_ participate in the rating or scoring of any >>>>> of >>>>> the teams. >>>>> >>>>> >>>>> _*Rate The Teams*_ >>>>> >>>>> To rate the teams I've setup a short survey (see link) with the name of >>>>> each team and a sliding scale that you can rate them and their work >>>>> from >>>> >>>> 1 >>>>> >>>>> (Poor) to 10 (Excellent). >>>>> >>>>> https://www.surveymonkey.com/r/RXW7KVC >>>>> >>>>> Anyone from the OFBiz Community can participate in the rating the OPL >>>>> teams. The survey will be open for the next 7 days and will close on >>>> >>>> 17^th >>>>> >>>>> November 2016. The scores will be totalled and hopefully we'll find out >>>>> which team has won the award. >>>>> >>>>> Good luck to all the teams and thanks for all the OFBiz contributions >>>> >>>> that >>>>> >>>>> have been made. >>>>> >>>>> Thanks >>>>> Sharan >>>>> >>>>> >>>>> >> >> > -- Bilgin Ibryam Camel Committer at ASF & Integration Architect at Red Hat Blog: http://ofbizian.com | Twitter: @bibryam Camel Design Patterns https://leanpub.com/camel-design-patterns Instant Apache Camel Message Routing http://www.amazon.com/dp/1783283475
[jira] [Commented] (OFBIZ-7755) Geo data for Turkey
[ https://issues.apache.org/jira/browse/OFBIZ-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362264#comment-15362264 ] Bilgin Ibryam commented on OFBIZ-7755: -- thanks Tufan > Geo data for Turkey > --- > > Key: OFBIZ-7755 > URL: https://issues.apache.org/jira/browse/OFBIZ-7755 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Tufan Kaynak >Priority: Minor > Labels: address, geodata, province, regions, turkey > Attachments: ofbizGeoDataTUR02.patch > > > Please find attached the patch file for including Province data for Turkey > via GeoData_TR.xml and address format for Turkey in GeoData.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Adrian Crum
I also had the chance to meet Adrian last year and have a drink. We will miss you, rest in peace! B. On 5 January 2016 at 08:04, Pierre Smits <pierre.sm...@gmail.com> wrote: > Hi all, > > With sadness in my heart I inform you that on January 1st Adrian Crum > passed away peacefully. Adrian was hospitalised in December of last year > due to suffering from a double pneumonia. He died while being kept sedated. > > I wish his loved ones, relatives and friends strength in these difficult > times. > > Best regards, > > Pierre Smits -- Bilgin Ibryam Camel Committer at ASF & Integration Architect at Red Hat Blog: http://ofbizian.com | Twitter: @bibryam Camel Design Patterns https://leanpub.com/camel-design-patterns Instant Apache Camel Message Routing http://www.amazon.com/dp/1783283475
Re: Fw: Apache Extras changes?
There are other projects (like Apache Camel for example) which still use camel-extra actively. I'm also thinking to contribute https://github.com/bibryam/lazyplanner to extra. Cheers, On 22 December 2013 10:53, Jacques Le Roux jacques.le.r...@les7arts.comwrote: FYI in case you are not monitoring Apache Infra ML. So it seems this means that Apache Extras is doomed :/ https://code.google.com/a/apache-extras.org/hosting/search?q=label%3aOFBiz Jacques PS: sorry, I had this message in my draft folder for 2 months :/ Rob Weir wrote: On Thu, Oct 24, 2013 at 5:19 PM, Andrea Pescetti pesce...@apache.org wrote: Tony Stevenson wrote: Comedev run Apache Extras. Could you elaborate just a bit? OpenOffice uses Apache Extras for storing optional dependencies, and the URL is hard-coded in our build configuration files. I included a paragraph about our concerns with Apache Extras in the last two OpenOffice Board reports, but if there is an ongoing discussion somewhere I would very much like to know where I can find it! Apache Extras is backed by Google Code, so maybe the concern is over the announced ending of file download support in 2014? http://google-opensource.blogspot.com/2013/05/a-change-to-google-code-download-service.html It sounds like existing download files will continue to work into the indefinite future, but new downloads will not able to be added. -Rob Thanks, Andrea. -- Bilgin Ibryam Apache Camel Apache OFBiz committer Blog: ofbizian.com Twitter: @bibryam https://twitter.com/bibryam Author of Instant Apache Camel Message Routing http://www.amazon.com/dp/1783283475
Re: Potential OFBiz opportunity.
The user list is for all topics related to OFBiz usage including this one. If a topic is not related to OFBiz, I dont see how having another list may help my two cents Bilgin I think these kinds of discussions can lend valuable insight into how and where others in the community may be using ofbiz and potentially promoting cooperation and such that may be related to, but not directly to the ofbiz proper. I would like to see another mailing list being created that would foster these kinds of discussions. Does anyone else think this would be useful? Thanks, Wai -- View this message in context: http://ofbiz.135035.n4.nabble.com/Potential-OFBiz-opportunity-tp4400068p4402932.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap
On 19 December 2011 14:14, Hans Bakker mailingl...@antwebsystems.com wrote: Hi Jacopo, Hello Hans, thanks for helping me, it is good try to work together instead of personally accusing people. With the amount of commits we produce here at Antwebsystems, it can once in a while go wrong and have errors. The amount of code can be an explanation for the amount of errors, but not for its quality I am setting up a Jenkins automated test system in our company to improve on the situation. CI without self testing code doesn't mean anything (except that the code compiles). On the hand having something like Sonar (and paying attention to what it says) may help to improve the code quality. I join other committers that we also worry about the amount of changes that go into the system which could introduce errors. On the other hand without them, it will quickly kill the OFBiz system. Perhaps in the future we should insist on having junit tests for new functions and enhancements to existing functions. I totally agree with you here (about having test coverage for any new feature in the system) Cheers, Bilgin Thanks again for your help, Regards, Hans On 12/19/2011 03:38 PM, Jacopo Cappellato wrote: Yep, the problem was the line: -ProductFeatureCategory productFeatureCategoryId=IMAGE description=Image/ +ProductFeatureCategory productFeatureCategoryI=IMAGE description=Image/ I have fixed it. Even without reviewing this big commit, this kind of errors (that imply that very few tests were done) makes me feel nervous about the quality of the code committed. Jacopo On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote: This commit is throwing a lot of exceptions during data loading. See the buildbot report. -Adrian On 12/19/2011 6:40 AM, hans...@apache.org wrote: Author: hansbak Date: Mon Dec 19 06:40:18 2011 New Revision: 1220622 URL: http://svn.apache.org/viewvc?rev=1220622view=rev Log: new producttype: configurable product service, using inventory Modified: ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Product.groovy ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl ofbiz/trunk/applications/product/data/ProductTypeData.xml ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml ofbiz/trunk/applications/product/script/org/ofbiz/shipment/receipt/ShipmentReceiptServices.xml ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml Modified: ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml?rev=1220622r1=1220621r2=1220622view=diff == --- ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml (original) +++ ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml Mon Dec 19 06:40:18 2011 @@ -45,6 +45,11 @@ under the License. FixedAsset fixedAssetId=DEMO_PROD_EQUIPMT_2 fixedAssetName=Demo Production Equipment Two fixedAssetTypeId=PRODUCTION_EQUIPMENT dateAcquired=2005-01-01 00:01:00.0 expectedEndOfLife=2010-01-01 calendarId=DEMO_CALENDAR salvageValue=50 purchaseCost=1000 purchaseCostUomId=USD/ FixedAssetGeoPoint fixedAssetId=DEMO_PROD_EQUIPMT_2 geoPointId=9000 fromDate=2009-01-09 00:00:00.000/ +FixedAsset fixedAssetId=DEMO_BOOK_GROUP fixedAssetTypeId=GROUP_EQUIPMENT fixedAssetName=Demo Book Group/ +FixedAssetGeoPoint fixedAssetId=DEMO_BOOK_GROUP geoPointId=9000 fromDate=2011-08-02 00:00:00.000/ +FixedAsset fixedAssetId=DEMO_BOOK fixedAssetName=Demo Book fixedAssetTypeId=PRODUCTION_EQUIPMENT parentFixedAssetId=DEMO_BOOK_GROUP calendarId=DEMO_CALENDAR purchaseCost=200 purchaseCostUomId=USD/ +FixedAssetGeoPoint fixedAssetId=DEMO_BOOK geoPointId=9000 fromDate=2011-08-02 00:00:00.000/ + FixedAssetDepMethod depreciationCustomMethodId=STR_LINE_DEP_FORMULA fixedAssetId=DEMO_PROD_EQUIPMT_1/ FixedAssetDepMethod depreciationCustomMethodId=DBL_DECL_DEP_FORMULA fixedAssetId=DEMO_PROD_EQUIPMT_2/ /entity-engine-xml Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1220622r1=1220621r2=1220622view=diff
Re: svn commit: r1213183 - in /ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr: access/ access/jackrabbit/ api/ api/jackrabbit/ test/
Sascha,
Introducing this checked exception prevents JackrabbitFileHelper from compiling
Bilgin
On 12 December 2011 10:48, sascharodek...@apache.org wrote:
Author: sascharodekamp
Date: Mon Dec 12 10:48:04 2011
New Revision: 1213183
URL: http://svn.apache.org/viewvc?rev=1213183view=rev
Log:
Add a new test and change the exception handling when reading content from
the repository. A Path not found exception will now be thrown, when a path
not exist.
Modified:
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/ContentReader.java
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/JcrRepositoryAccessor.java
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/jackrabbit/ContentReaderJackrabbit.java
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/jackrabbit/JackrabbitRepositoryAccessor.java
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/api/JcrDataHelper.java
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/api/jackrabbit/JackrabbitArticleHelper.java
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/test/JackrabbitTests.java
Modified:
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/ContentReader.java
URL:
http://svn.apache.org/viewvc/ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/ContentReader.java?rev=1213183r1=1213182r2=1213183view=diff
==
---
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/ContentReader.java
(original)
+++
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/ContentReader.java
Mon Dec 12 10:48:04 2011
@@ -1,5 +1,6 @@
package org.ofbiz.jcr.access;
+import javax.jcr.PathNotFoundException;
import javax.jcr.RepositoryException;
import javax.jcr.query.QueryResult;
@@ -15,8 +16,9 @@ public interface ContentReader {
*
* @param nodePath
* @return
+ * @throws PathNotFoundException
*/
- OfbizRepositoryMapping getContentObject(String nodePath);
+ OfbizRepositoryMapping getContentObject(String nodePath) throws
PathNotFoundException;
/**
* Return an OfbizRepositoryMapping Object in the specified language and
@@ -28,8 +30,9 @@ public interface ContentReader {
* @param language
* @param version
* @return
+ * @throws PathNotFoundException
*/
- OfbizRepositoryMapping getContentObject(String nodePath, String version);
+ OfbizRepositoryMapping getContentObject(String nodePath, String version)
throws PathNotFoundException;
/**
* Returns a tree of all content nodes (except folders and files) in the
Modified:
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/JcrRepositoryAccessor.java
URL:
http://svn.apache.org/viewvc/ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/JcrRepositoryAccessor.java?rev=1213183r1=1213182r2=1213183view=diff
==
---
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/JcrRepositoryAccessor.java
(original)
+++
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/JcrRepositoryAccessor.java
Mon Dec 12 10:48:04 2011
@@ -3,6 +3,7 @@ package org.ofbiz.jcr.access;
import java.util.List;
import javax.jcr.ItemExistsException;
+import javax.jcr.PathNotFoundException;
import javax.jcr.RepositoryException;
import javax.jcr.Session;
import javax.jcr.query.QueryResult;
@@ -25,8 +26,9 @@ public interface JcrRepositoryAccessor {
*
* @param nodePath
* @return
+ * @throws PathNotFoundException
*/
- OfbizRepositoryMapping getContentObject(String nodePath);
+ OfbizRepositoryMapping getContentObject(String nodePath) throws
PathNotFoundException;
/**
* Return an OfbizRepositoryMapping Object in the specified version from
the
@@ -36,8 +38,9 @@ public interface JcrRepositoryAccessor {
* @param language
* @param version
* @return
+ * @throws PathNotFoundException
*/
- OfbizRepositoryMapping getContentObject(String nodePath, String version);
+ OfbizRepositoryMapping getContentObject(String nodePath, String version)
throws PathNotFoundException;
/**
* Stores the OfbizRepositoryMapping Class in the content repository.
Modified:
ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/jackrabbit/ContentReaderJackrabbit.java
URL:
http://svn.apache.org/viewvc/ofbiz/branches/jackrabbit20100709/framework/jcr/src/org/ofbiz/jcr/access/jackrabbit/ContentReaderJackrabbit.java?rev=1213183r1=1213182r2=1213183view=diff
==
---
Re: Discussion: Handling Security In Nested Services
We have lot's of fine grained small services with permission service SECAs and the current permission checks doubles its execution time because each service call requires a permission service call. With the changes you propose I believe there will be significant performance improvement. + 1 Bilgin On Wed, Nov 23, 2011 at 8:14 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: I am running into that familiar problem of handling authorization in nested services. Example: Application A Invoke Service A Authorized with permissions A Invokes Service C in Application C Authorized with permissions C In order for a user to run Service A, I have to give them permission to run Service A and Service C. This might not be desirable because granting permission C to the user could give them access to other things I didn't intend to give them access to. So far, we have handled that permission issue with permission service SECAs - where a second permission service is invoked if the first one fails. SECA Example: Invoke permission service for permissions C If permission service fails, invoke permission service for permissions A Return results of permission service A Else Return results of permission service C This solves the problem (an example can be found in the Asset Maint application), but it is cumbersome to implement. There are other places in the project where the problem is solved by invoking Service C with system or admin user credentials - which looks hackish to me. It seems to me this could be made a lot simpler by having the service dispatcher keep track of previous authorizations. In other words, move the authorization tracking (which is currently handled outside the service dispatcher) into the service dispatcher. Example: Service invoked If user previously authorized Execute service Else Execute permission service If user authorized Set previously authorized to true Execute service Set previously authorized to false With this change, giving the user permission to run Service A will automatically authorize them to run any services called by the service. Naturally, this approach does not solve the problem if permission checks are embedded in service code - it depends on the use of permission services. So, what do you think? -Adrian
Re: [VOTE] Merging Jackrabbit Branch into trunk
I'm looking into it, sorry for the delay. BTW is there any discussion thread about this branch? (I know the confluence page) Bilgin On Wed, Nov 23, 2011 at 9:49 AM, Sascha Rodekamp sascha.rodekamp.lynx...@googlemail.com wrote: ping 2011/11/15 Bilgin Ibryam bibr...@gmail.com: I promise to have a look this weekend and give my opinion and vote. I know you asked about it on dev list some time ago, but I think more time is needed, so at least few more committers have a look. It is a major feature, thanks for pushing hard for it Sascha Bilgin On Tue, Nov 15, 2011 at 7:06 AM, Sascha Rodekamp sascha.rodekamp.lynx...@googlemail.com wrote: Hi *, I would like to start a vote for merging the jackrabbit branch back into the trunk. In my opinion the first step, integrating a jcr repository in ofbiz, is done. The new API can now be used by any developer for storing, retrieving or manipulating data in the jackrabbit content repository. A bigger user group would help me to improve the integration. Have a good day Sascha -- Sascha Rodekamp Visit the new german OFBiz Blog: http://www.ofbiz.biz Lynx-Consulting GmbH Johanniskirchplatz 6 D-33615 Bielefeld http://www.lynx.de -- Sascha Rodekamp Visit the new german OFBiz Blog: http://www.ofbiz.biz Lynx-Consulting GmbH Johanniskirchplatz 6 D-33615 Bielefeld http://www.lynx.de
Re: jackrabbit branch
Hi guys, here are some notes from my first look at JCR branch: There are some jars which already exists in the project (with different versions though). Is that needed? pdfbox slf4j-api tika-core tika-parsers I see also some interfaces and classes not used at all. HealthCheck, HealthCheckJackrabbit DBAccess Constants JcrEventHandler JcrUtil - Do we need an interface for a utility class? OfbizRepositoryMappingJackrabbitArticle - can we shorten this naming convention. For example to ArticleNode RepositoryAccess - may be change it to JcrRepositoryAccessor Dublicate code in JcrFileHelper getRepositoryContent method JcrTests - may be indicate in the name that we are testing the Jackrabbit implementation. There are tests which rely on the previous test to pass successfully. I think each test should be independent. testCreateRepositoryNewsNode testReadRepositoryNewsNode Then there are tests which are actually not asserting the actual operation stated in its name. Instead they are asserting that the intermidiate object was created. testUpdateRepositoryNewsNode (for example in this test there is no need to assert assertNotNull(orm) but instead a check that the content was updated as expected is needed) testRemoveRepositoryNewsNode testCreateRepositoryFileNode testCreateRepositoryFileNode_2 testRemoveRepositoryFileNode Example component Change label jackrabbitsandbox What about creating a factory class that instantiates RepositoryAccessJackrabbit object and returns it as RepositoryAccess Then we can use that factory in JackrabbitEvents, where currently RepositoryAccessJackrabbit is created explicitely. This way we can hide the jackrabbit implementation. I was expecting to not see any jackrabbit packages, but only jcr in JackrabbitEvents but that will require more work Are there any changes to Content component, in the svn history there are changes, but then I cannot see any? HTH Bilgin Ibryam On Fri, Nov 11, 2011 at 8:36 AM, Sascha Rodekamp sascha.rodekamp.lynx...@googlemail.com wrote: Hi Sam, that is possible. At the moment the Jackrabbit Repository runs embedded in the ofbiz instance. But it is not much work to run the JCR Repository on an separate server instance and let this server stream your content. Descripted here http://jackrabbit.apache.org/standalone-server.html The only thing that have to be changed is the Repository Connection in something like: Repository repository = new URLRemoteRepository(http://localhost:8080/rmi;); (This could also be made configurable). Just a side node. For step one i didn't migrated all the content applications. There is only the API to work with the content repository, everything else will follow ... 2011/11/11 Sam Hamilton s...@sh81.com Hi Sascha - thanks for the reply! So if I understand right images will not be stored on the app servers but on another server that is running the jackrabbit storage services? After these changes are merged only one copy of a product image will need to be saved in jackrabbit and now removes the need to sync image files between app servers if you are running a load balanced or cluster setup?? Thanks Sam On 11 Nov 2011, at 15:27, Sascha Rodekamp wrote: Hi Sam, nope. Content information (images, text, files ...) will be stored in a content repository beside our normal (SQL) Database. A content repository is an information management system that provides various services for storing, accessing, and managing content. In addition to a hierarchically structured storage, common services of a content repository are versioning, access control, full text searching, and event monitoring (see http://jackrabbit.apache.org/frequently-asked-questions.html ). In our current configuration of Jackrabbit we have to differentiate between file and other content. Because files are normally larger than normal text i adviced Jackrabbit to store files directly on the file system and create a reference in the repository (that have performance reasons). On the other side text content is directly stored in the repository nodes (each item in a repository is called node, a node have different attributes which contains the content and metadata). Hope that answered your question?! Regards Sascha 2011/11/11 Sam Hamilton s...@sh81.com Hi Sascha, Please excuse my ignorance but does this branch mean that content information such as images will be stored in the database base instead of on the app servers? Thanks Sam On 8 Nov 2011, at 21:55, Sascha Rodekamp wrote: Hi Erwan, in my opinion step one is done. Includes: An abstract and completely independent framework module to attach any JCR implementations you want to OFBiz, Jackrabbit is the default implementation. The basic CRUD functions, versioning and support for different languages works and looks stable :-). What is missing: Someone who reviews the architecture
Re: deprecated JSON classes
On Wed, Nov 16, 2011 at 9:07 PM, Erwan de FERRIERES erwan.de-ferrie...@nereide.fr wrote: Hi all, the following classes are deprecated since December 2009 more than 2 years as deprecated is long enough + 1 Bilgin (https://fisheye6.atlassian.**com/changelog/ofbiz?cs=892685https://fisheye6.atlassian.com/changelog/ofbiz?cs=892685) : framework/webapp/src/org/**ofbiz/webapp/event/**JSONJavaEventHandler.java framework/webapp/src/org/**ofbiz/webapp/event/** JSONServiceEventHandler.java framework/webapp/src/org/**ofbiz/webapp/event/** JSONServiceMultiEventHandler.**java and this one should be also deprecated, since we are no more using dojo in OFBiz. framework/webapp/src/org/**ofbiz/webapp/event/** DojoJSONServiceEventHandler.**java Is this OK to remove those files ? Cheers, -- Erwan de FERRIERES www.nereide.biz
Re: [VOTE] Merging Jackrabbit Branch into trunk
I promise to have a look this weekend and give my opinion and vote. I know you asked about it on dev list some time ago, but I think more time is needed, so at least few more committers have a look. It is a major feature, thanks for pushing hard for it Sascha Bilgin On Tue, Nov 15, 2011 at 7:06 AM, Sascha Rodekamp sascha.rodekamp.lynx...@googlemail.com wrote: Hi *, I would like to start a vote for merging the jackrabbit branch back into the trunk. In my opinion the first step, integrating a jcr repository in ofbiz, is done. The new API can now be used by any developer for storing, retrieving or manipulating data in the jackrabbit content repository. A bigger user group would help me to improve the integration. Have a good day Sascha -- Sascha Rodekamp Visit the new german OFBiz Blog: http://www.ofbiz.biz Lynx-Consulting GmbH Johanniskirchplatz 6 D-33615 Bielefeld http://www.lynx.de
Re: configproductdetail.ftl useless block
On Fri, Oct 21, 2011 at 6:10 PM, Jacques Le Roux
jacques.le.r...@les7arts.com wrote:
The answer is less interesting: I think we don't...so far. Do you have an
idea?
I can see that there are code snippet doing it, but they are copied
and pasted in various places already. For example selectall.js, lines
350 to 370
It would be better to have only one js function, that checks the ajax
responses for error messages and displays in the framework.
my 2 cents
Bilgin
Jacques
From: Bilgin Ibryam bibr...@gmail.com
If I remember correct, it was used for debugging purpose and it is
safe to delete/cleanup.
The more interesting questions is do we have a generic way in place to
extract/display error/warning messages generated by ajax requests?
Bilgin
On Wed, Oct 12, 2011 at 10:15 AM, Jacques Le Roux
jacques.le.r...@les7arts.com wrote:
In both configproductdetail.ftl files, we have this whole useless block
if (data._ERROR_MESSAGE_LIST_ != undefined) {
//console.log(data._ERROR_MESSAGE_LIST_);
//alert(data._ERROR_MESSAGE_LIST_);
}else if (data._ERROR_MESSAGE_ != undefined) {
//console.log(data._ERROR_MESSAGE_);
//alert(data._ERROR_MESSAGE_);
}else {
//console.log(data.totalPrice);
//console.log(data.configId);
Is there a reason to keep it?
Jacques
Re: latest trunk code is broken
Trunk is working fine for me. You might have corrupted instance. Bilgin On Thu, Oct 27, 2011 at 6:12 PM, Wai bzb.of...@gmail.com wrote: After checking out the latest source from the trunk. I get the following error message when trying to access the partymgr component. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.IllegalArgumentException: Template location is empty (Template location is empty) Thanks -- View this message in context: http://ofbiz.135035.n4.nabble.com/latest-trunk-code-is-broken-tp3945234p3945234.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: configproductdetail.ftl useless block
If I remember correct, it was used for debugging purpose and it is
safe to delete/cleanup.
The more interesting questions is do we have a generic way in place to
extract/display error/warning messages generated by ajax requests?
Bilgin
On Wed, Oct 12, 2011 at 10:15 AM, Jacques Le Roux
jacques.le.r...@les7arts.com wrote:
In both configproductdetail.ftl files, we have this whole useless block
if (data._ERROR_MESSAGE_LIST_ != undefined) {
//console.log(data._ERROR_MESSAGE_LIST_);
//alert(data._ERROR_MESSAGE_LIST_);
}else if (data._ERROR_MESSAGE_ != undefined) {
//console.log(data._ERROR_MESSAGE_);
//alert(data._ERROR_MESSAGE_);
}else {
//console.log(data.totalPrice);
//console.log(data.configId);
Is there a reason to keep it?
Jacques
Re: widgetVerbose
On Tue, Sep 13, 2011 at 9:54 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: Thanks Scott - those are my feelings exactly. I like the way the design worked previously, and changing it because a user might accidentally leave the comments enabled in production seems silly. That is a user's QC problem, not a widget comment design problem. -Adrian + 1 Bilgin
Re: Policy about supported releases
On Wed, Sep 7, 2011 at 8:30 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: In my mind, it's only about bug fixes backport, nothing else. I do as much as I can, but for instance it's a while now I don't do it for R4.0. I want to make that clear and have a reference for users... + 1 Jacques From: David E Jones d...@me.com Do we even have a policy about supporting releases, let alone a policy about which releases to support? In other words, what can a user of Apache OFBiz expect to get as part of this official support? -David On Sep 6, 2011, at 9:28 AM, Jacques Le Roux wrote: Thanks Hans, Yes of course this is only Apache OFBiz policy... Jacques From: Hans Bakker mailingl...@antwebsystems.com When you do not get a response in a reasonable time. I would suggest to ahead with the subject as you proposed. yes, I think it is safe to assume Lazy Consensus in this case In general this is a fair statement, in practice providers will support the customers independent of the version they use? Regards, Hans On Tue, 2011-09-06 at 06:41 +0200, Jacques Le Roux wrote: I can't believe nobody is interested in this? Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com I'd simply suggest to not support releases older than 4 years... This would be a perfect timing for R4.0 (was in 2007) that we can't reasonnably no longer support and is a simple policy anybody can remember easily So we could annonce that officialy has did Tomcat team below, opinions? Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi, I'd suggest that we define a simple official policy about supported releases. There are still people asking for support on 4.0. But this version is more than 4 years old and I think any of the commiters still use it regularly and want to support it. For instance it's now hard to backport things there. We could take Tomcat policy as an example: The Apache Tomcat team announces that support for Apache Tomcat 5.5.x will end on 30 September 2012. This means that after 30 September 2012: - releases from the 5.5.x branch are highly unlikely - bugs affecting only the 5.5.x branch will not be addressed - security vulnerability reports will not be checked against the 5.5.x branch Three months later (i.e. after 31 December 2012) - the 5.5.x download pages will be removed - the latest 5.5.x release will be removed from the mirror system - the 5.5.x branch in svn will move from /tomcat/tc5.5.x to /tomcat/archive/tc5.5.x - the links to the 5.5.x documentation will be removed from tomcat.apache.org - The bugzilla project for 5.5.x will be made read-only Note that all 5.5.x releases will always be available from the archive. It is anticipated that the final 5.5.x release will be made shortly before 30 September 2012. Thoughts? Jacques -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Alternative ofbiz website: http://www.ofbiz.info http://www.antwebsystems.com : Quality services for competitive rates.
Re: cdyne
I'd suggest we mark it as @Deprecated and remove after some time. Bilgin On Tue, Aug 9, 2011 at 8:02 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Then indeed we could consider to remove it. If anybody really need it s/he could still find it in one of the releases... Jacques From: Tim Ruppert tim.rupp...@hotwaxmedia.com They changed their name and rebuilt all of the web services a few years ago. That being said, I have no idea if anyone is using it any longer - but it stopped working for us a while back so we stopped using it. Cheers, Ruppert On Aug 8, 2011, at 12:41 PM, David E Jones wrote: We have a general precedence for not removing things people might be using, which is anything in the project, especially without reasonable notice (like waiting a while for comment). On the other hand, if the company behind these services no longer existed or something like that (I don't know if this is the case), then yes might as well remove them right away. -David On Aug 8, 2011, at 12:37 PM, Jacques Le Roux wrote: Everybody agree? Jacques From: Tim Ruppert tim.rupp...@hotwaxmedia.com It's a likely out of date old web services API - my guess is we could drop it all together. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Aug 5, 2011, at 8:11 AM, Jacques Le Roux wrote: Hi, I really wonder if CdyneServices.java should be in commons or rather in commonext. It looks like an application util to me. Jacques
Re: showcartitems.ftl: should desired delivery date use renderDateTimeField?
On Tue, Aug 9, 2011 at 1:54 AM, Paul Foxworthy p...@cohsoft.com.au wrote:
Yes, thanks Bilgin.
Input fields and the display widget use the locale for date formatting, but
at least some Freemarker templates don't. It would be nice if they were
consistent.
Can you give an example what you want to achieve?
The datetime_format for freemarker in ofbiz is set to -MM-dd
HH:mm:ss.SSS that's why it is rendered in this format for any locales.
If you want to display timestamps in a specific format containing i18n
part (for example the day/month printed in a specific language) you
can do it by explicitely setting the formatting in that ftl file like
this:
${cartLine.getDesiredDeliveryDate()?string(, dd, ,
hh:mm:ss a '('zzz')')}
HTH
Bilgin Ibryam
Cheers
Paul Foxworthy
--
View this message in context:
http://ofbiz.135035.n4.nabble.com/showcartitems-ftl-should-desired-delivery-date-use-renderDateTimeField-tp3724548p3728726.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Closed] (OFBIZ-4330) Overview of invoices in AP and AR don't show invoices with status approved
[ https://issues.apache.org/jira/browse/OFBIZ-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-4330. Resolution: Fixed Assignee: Bilgin Ibryam Thanks Pierre, your patch is in trunk r1155300 Overview of invoices in AP and AR don't show invoices with status approved -- Key: OFBIZ-4330 URL: https://issues.apache.org/jira/browse/OFBIZ-4330 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Reporter: Pierre Smits Assignee: Bilgin Ibryam Labels: patch Fix For: SVN trunk Attachments: ofbiz-trunk-accounting-invoiceReport-20110706.patch Original Estimate: 2h Remaining Estimate: 2h Currently the overviews of invoices of both AP and AR don't show invoices with status 'INVOICE_READY'. Also the overviews of invoices in the future don't differentiate between AP and AR invoices. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: showcartitems.ftl: should desired delivery date use renderDateTimeField?
renderDateTimeField will render it as html input field, whereas desired delivery date is only displayed, isn't it? Bilgin On Sun, Aug 7, 2011 at 8:51 AM, Paul Foxworthy p...@cohsoft.com.au wrote: Hi all, The line in showcartitems.ftl that presents the desired delivery date doesn't use the renderDateTimeField macro, so won't be internationalised. See: https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl?hb=true#to140 Lines 199 and 205 do have the renderDateTimeField. Is there a good reason for this? I'll submit a Jira issue and patch if not. Cheers Paul Foxworthy -- View this message in context: http://ofbiz.135035.n4.nabble.com/showcartitems-ftl-should-desired-delivery-date-use-renderDateTimeField-tp3724548p3724548.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Closed] (OFBIZ-4357) CopyQuote service return new quote id
[ https://issues.apache.org/jira/browse/OFBIZ-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-4357. Resolution: Fixed Assignee: Bilgin Ibryam Thanks Leon, I made the quoteId field INOUT so it can be used to return the new quote Id. It is in trunk r1152729 CopyQuote service return new quote id - Key: OFBIZ-4357 URL: https://issues.apache.org/jira/browse/OFBIZ-4357 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Leon Assignee: Bilgin Ibryam Priority: Trivial Attachments: CopyQuote.patch To be able to extend sales quote copy function, we modify current CopyQuote service to return the id of new created quote. It's a very very trivial update. I wonder whether it's worth of a commit. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4345) voided payments are auto-applied to new order invoices
[
https://issues.apache.org/jira/browse/OFBIZ-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam reassigned OFBIZ-4345:
Assignee: Bilgin Ibryam
voided payments are auto-applied to new order invoices
--
Key: OFBIZ-4345
URL: https://issues.apache.org/jira/browse/OFBIZ-4345
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Reporter: Martin Kreidenweis
Assignee: Bilgin Ibryam
Attachments: OFBIZ-4345-voidedAutoApply.patch
{{InvoiceServices.createInvoiceForOrder}} automatically creates
{{PaymentApplication}} records when unapplied payments exist for the order.
Unfortunately this doesn't consider the {{Payment.statusId}}.
So when a user accidentally enters a wrong payment and voids it right away,
it is still automatically applied to the invoice on invoice creation. The GUI
then provides no way to un-apply the payment, because it assumes that for
voided payments no payment applications can exist any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4345) voided payments are auto-applied to new order invoices
[
https://issues.apache.org/jira/browse/OFBIZ-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073590#comment-13073590
]
Bilgin Ibryam commented on OFBIZ-4345:
--
Martin,
your patch seems to be OK, but what about also filtering out
OrderPaymentPreference with statusId PAYMENT_CANCELLED?
Is it going to work fine in your case?
voided payments are auto-applied to new order invoices
--
Key: OFBIZ-4345
URL: https://issues.apache.org/jira/browse/OFBIZ-4345
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Reporter: Martin Kreidenweis
Assignee: Bilgin Ibryam
Attachments: OFBIZ-4345-voidedAutoApply.patch
{{InvoiceServices.createInvoiceForOrder}} automatically creates
{{PaymentApplication}} records when unapplied payments exist for the order.
Unfortunately this doesn't consider the {{Payment.statusId}}.
So when a user accidentally enters a wrong payment and voids it right away,
it is still automatically applied to the invoice on invoice creation. The GUI
then provides no way to un-apply the payment, because it assumes that for
voided payments no payment applications can exist any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1137433 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/form/MacroFormRenderer.java templates/htmlFormMacroLibrary.ftl
Adrian,
On Mon, Jun 20, 2011 at 11:32 AM, Adrian Crum
adrian.c...@sandglass-software.com wrote:
Are you serious? That macro has the exact same parameters and they aren't
documented either. Actually, all that macro does is call the
renderLookupField macro, so I don't understand why it's even there.
htmlTemplate.lookupField is there(I created it during ajax lookup
implementation) to set some default values, otherwise you I had to call
renderLookupField from other FTLs with 30 attributes.
BUT I agree with you that it duplicates the code, could get easily
outdated...
I think default values should be set only in one place, preferably from
renderLookupField macro itselft but not from MacroFormRenderer.java and
htmlTemplate.ftl
Bilgin
I would prefer to use the same macro the widgets use for one very good
reason that is made obvious in this commit: Those macros will be maintained,
while the htmlTemplate macros will not.
-Adrian
On 6/20/2011 10:46 AM, Jacques Le Roux wrote:
Hi Adrian,
Why not using @htmlTemplate.lookupField ? There are plenty of examples
HTH
Jacques
Adrian Crum wrote:
Jacques,
Coincidentally, I am trying to use the renderLookupField macro in a
Freemarker template. Do you have any idea what all of the macro
parameters are for? I am having a difficult time sorting out what
arguments to pass to get it to work.
-Adrian
On 6/19/2011 9:59 PM, jler...@apache.org wrote:
Author: jleroux
Date: Sun Jun 19 20:59:35 2011
New Revision: 1137433
URL:
http://svn.apache.org/viewvc?**rev=1137433view=revhttp://svn.apache.org/viewvc?rev=1137433view=rev
Log:
A patch from LeonsetUserPreference goes to main page instead last
view if current form includes any lookup field
https://issues.apache.org/**jira/browse/OFBIZ-4313https://issues.apache.org/jira/browse/OFBIZ-4313When
I open a form which include lookup field and then click the
expand/collapse button around the upper right corner in the the
header, the page will go to main after user preference is settled. The
cause is the requests initiated by lookup field does not remember the last
view name. It simply use main instead.
Patch to make lookup requests remember the LAST_VIEW_NAME correctly.
Modified:
ofbiz/trunk/framework/widget/**src/org/ofbiz/widget/form/**
MacroFormRenderer.java
ofbiz/trunk/framework/widget/**templates/**htmlFormMacroLibrary.ftl
Modified: ofbiz/trunk/framework/widget/**src/org/ofbiz/widget/form/**
MacroFormRenderer.java
URL:
http://svn.apache.org/viewvc/**ofbiz/trunk/framework/widget/**
src/org/ofbiz/widget/form/**MacroFormRenderer.java?rev=**
1137433r1=1137432r2=1137433**view=diffhttp://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java?rev=1137433r1=1137432r2=1137433view=diff
==**==**==
---
ofbiz/trunk/framework/widget/**src/org/ofbiz/widget/form/**MacroFormRenderer.java
(original) +++
ofbiz/trunk/framework/widget/**src/org/ofbiz/widget/form/**MacroFormRenderer.java
Sun Jun 19 20:59:35 2011 @@ -2149,6 +2149,14 @@
public class MacroFormRenderer implement boolean showDescription =
Y.equals(UtilProperties.**getPropertyValue(widget, widget.lookup.*
*showDescription, N));
+// lastViewName, used by lookup to remember the real last view
name
+String lastViewName = request.getParameter(_LAST_**VIEW_NAME_);
// Try to get it from parameters firstly
+if (UtilValidate.isEmpty(**lastViewName)) { // get from
session
+lastViewName = (String) request.getSession().**
getAttribute(_LAST_VIEW_NAME_**);
+}
+if (UtilValidate.isEmpty(**lastViewName)) {
+lastViewName = ;
+}
StringWriter sr = new StringWriter();
sr.append(@renderLookupField );
sr.append( className=\);
@@ -2208,6 +2216,8 @@ public class MacroFormRenderer implement
sr.append(Boolean.toString(**showDescription));
sr.append(\ initiallyCollapsed=\);
sr.append(Boolean.toString(**isInitiallyCollapsed));
+sr.append(\ lastViewName=\);
+sr.append(lastViewName);
sr.append(\ /);
executeMacro(writer, sr.toString());
Modified: ofbiz/trunk/framework/widget/**templates/**
htmlFormMacroLibrary.ftl
URL:
http://svn.apache.org/viewvc/**ofbiz/trunk/framework/widget/**
templates/**htmlFormMacroLibrary.ftl?rev=**
1137433r1=1137432r2=1137433**view=diffhttp://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=1137433r1=1137432r2=1137433view=diff
==**==**==
---
ofbiz/trunk/framework/widget/**templates/**htmlFormMacroLibrary.ftl
(original) +++
ofbiz/trunk/framework/widget/**templates/**htmlFormMacroLibrary.ftl Sun
Jun 19 20:59:35 2011 @@ -543,7 +543,7 @@
${item.description}/span /#if
/#macro
-#macro
Re: Freemarker Macro Library
Hi Adrian, On Fri, Jun 3, 2011 at 6:12 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: I'm working on a project where screen widgets can't be used and I need to use Freemarker templates instead. I would like to use the Freemarker macros found in the widget macro library, but they are cumbersome to use because they have MANY parameters - and almost all of them are set up as required parameters. The markup the macros generate requires only a handful of the parameters, and the rest of them are optional. So, I would like to work on the macro library and provide default arguments for any parameters that aren't required by the markup. Any thoughts or objections? I reused form widget lookup macros in freemarker templates using similar approach. Just create a wrapper macro with default values and then call the widget macros. For an example check how htmlTemplate.lookupField macro is used and implemented in htmlTemplate.ftl HTH Bilgin Ibryam
[jira] [Commented] (OFBIZ-3557) Enforced sequence does not work with concurrent access
[ https://issues.apache.org/jira/browse/OFBIZ-3557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040205#comment-13040205 ] Bilgin Ibryam commented on OFBIZ-3557: -- Jacopo, your example cases seems logical to me, one question though: You said createInvoice for B assigns InvoiceId 12 and when attempts to store the invoice it gets a duplicated PK error; Why there would be duplicate PK error? the previous invoice had id 11? I think in the second case there wouldn't be any duplicated PK errors. There might be other errors preventing invoice creation and lead to invoiceId gaps? Enforced sequence does not work with concurrent access -- Key: OFBIZ-3557 URL: https://issues.apache.org/jira/browse/OFBIZ-3557 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 09.04, SVN trunk Reporter: Wickersheimer Jeremy Attachments: OFBIZ-3557-1.patch, OFBIZ-3557-2.patch There is a fundamental issue with enforced sequences (for orders, invoices, etc ..) and concurrency. For example if two users are creating an order at the same time one of them will see the creation fail with a PK error. The problem is that the getNextXXXId rely on the party accounting preference entity, but there is absolutely no guarantee that the last number in the sequence gets updated before another service can read it. This is at best very annoying when used only internally but may be unpractical for e-commerce sites. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Search Products in webpos
Hi hmalovekar, please ask further OFBiz usage question in the user list. This is one of the areas in webpos that needs to be improved before use. The reason for the slow response I believe is due to the fact that it searches all the product in the system, i.e. there is no filtering by store, catalog, category... Also this exposes products that are not supposed the displayed to the user (expired products, configurable product components...). Another thing to fix is restrict the number of results returned in the response, as currently it returns all of the found products. Bilgin Ibryam On Tue, May 10, 2011 at 8:26 AM, hmalovekar eng_hishamab...@yahoo.comwrote: in Webpos Main Screen search products say by product name it is very Slow i must wait about 1 minute then i start writing to make autocomplete how can i make it operate faster? -- View this message in context: http://ofbiz.135035.n4.nabble.com/Search-Products-in-webpos-tp3511179p3511179.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Discussion: New TransactionUtil.java Methods
I like it, seems less error prone and I don't see any bad consequences using
it.
Bilgin
On Mon, Apr 25, 2011 at 5:13 PM, Adrian Crum
adrian.c...@sandglass-software.com wrote:
Setting up transactions properly can be complicated. I've seen cases where
it was done wrong. Even when it's done right, it adds a lot of client code
that gets repeated every time a transaction is used. I have an idea to make
transaction handling easier and more reliable:
1. Create an interface:
public interface TransactionTask {
void run() throws GenericEntityException;
}
2. Add a method to TransactionUtil.java:
public static void runTransactionTask(TransactionTask task, boolean
suspendCurrent) throws GenericEntityException, GenericTransactionException {
...
}
The TransactionUtil.runTransactionTask method will contain all of the
correct begin, suspend, commit, resume, rollback, try, catch, finally logic.
All the client code needs to do is put the transaction-protected code in a
TransactionTask instance run() method and call the
TransactionUtil.runTransactionTask method. Bottom line - less code, better
results.
Example:
TransactionTask task = new TransactionTask() {
public void run() throws GenericEntityException {
GenericValue target = delegator...;
target.set(someField, someValue);
target.store();
}
};
TransactionUtil.runTransactionTask(task, true);
What do you think?
-Adrian
Re: how to print Invoice in WebPOS?
I think it is not implemented in webpos yet, but surely you can add a printing functionality similar to the one in order manager. Please take a look at it: Order Manager - Find Orders and then select a printer to print on. HTH Bilgin Ibryam On Tue, Apr 19, 2011 at 10:41 AM, hmalovekar eng_hishamab...@yahoo.comwrote: any one reply to me -- View this message in context: http://ofbiz.135035.n4.nabble.com/how-to-print-Invoice-in-WebPOS-tp3459957p3459959.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: My vision for the OFBiz Framework
On Fri, Apr 8, 2011 at 3:39 PM, Ean Schuessler e...@brainfood.com wrote:
To me the convenience is being able to program to a straight AWT like
interface. It is just so convenient to be able to do things like:
myButton = new Button(Click Me, new Button.ClickListener() {
public void buttonClick(ClickEvent event) {
myLabel.setValue(You clicked my button); // simple stuff like this
dispatcher.runSync(SetPartyRole, [roleTypeId: 'BUTTON_CLICKER']); // or
even things like this
}
});
The process of binding these events to URLs to trigger services and
worrying through AJAX processing just falls away. I could add a dozen
buttons to a page and concentrate on the logic they trigger instead of a
pile of oddly named events and url bindings. Sure there is some memory
overhead there, sure it has state but man does it make some things easier.
I think your answer (as I've illustrated above) makes perfect sense and you
can definitely just trigger a service engine from these other frameworks.
However, I've wondered for a while why we couldn't construct stateful graphs
of UI objects from the XML widget descriptors and have the event bindings
attach directly to the widgets.
There is Declarative Layout in GWT which is similar to what you have
described, but it still requires writing java classes. You can see it here:
http://code.google.com/webtoolkit/doc/latest/DevGuideUiBinder.html
Bilgin
- David E Jones wrote:
That's a tough one. I just did some research on Vaadin, and in some ways
it looks similar to Wicket, and I suppose in some ways similar to JSF as
well, though Vaadin appears to be a sort of extension to GWT and the unlike
Wicket where the Java code is mostly run on the server (if I understand
right) in Vaadin most of the Java code is transformed using GWT and run on
the client, turning the client into almost a desktop app that communicates
with the server to mostly pass data around.
How to get any two technologies like these to work together is a good
question, or at least how to get them to work together seamlessly. Say you
want to write part of your app in Vaadin and part of it in Wicket... how
will you get them to work together well? I think the answer is that you
could have them both deployed in the same webapp, and pages written in each
could link to each other, but sharing decoration (except by including the
same text or using a tool to interpret a template that they can both
include) and navigation and such would be a nightmare.
In Moqui, like in OFBiz, most of the web UI stuff is based on writing to
a writer or stream and being able to assemble various pieces of text to
create a single web page. Without getting into lower level code, I looked at
each of these three (Vaadin, JSF, and Wicket) and it does not look like they
have a way to generate text to be included in a web page, and perhaps worse
handling navigation and links is so ingrained in the way the tools are
designed that nothing there could be shared (not in ways that I could find,
though of course with enough creative coding anything could be done in
theory).
So, I guess the answer is that just like with OFBiz, with Moqui Framework
if you want to use one of those web UI frameworks then use that instead of
the Moqui XML Screens/Forms, and just use other parts of the Moqui API
through the ExecutionContext that could be inited/destroyed in an event
listener instead of the MoquiServlet (since the MoquiServlet wouldn't be
used in that case), or if desperate you could use the Moqui class for static
init of the ExecutionContextFactory and ExecutionContext.
That parts easy, ie use Moqui API for services, entities, and other tools
but not for the web UI... trying to merge and share artifacts between these
kinds of restrictive UI approaches would be tough. On the other hand, if you
can get plain text out of them, you can include that in any Moqui XML
Screen.
I don't think a better solution to this exists. Personally, I blame JSP
and their restrictive nature that has been considered acceptable over the
years, and those sorts of restrictions now seem to bleed into all sorts of
web UI frameworks.
--
Ean Schuessler, CTO
e...@brainfood.com
214-720-0700 x 315
Brainfood, Inc.
http://www.brainfood.com
Re: soap web service simplifications
Hi Chris, did you see OFBIZ-3877 in Ofbiz jira? If it gets committed we will get rid of this annoying xml structure. Bilgin Ibryam On Thu, Mar 17, 2011 at 9:51 PM, chris snow chsnow...@gmail.com wrote: The current soap web service implementation uses org.ofbiz.service.engine.SoapSerializer to serialize/deserialize requests and responses. This results in an awkward xml structure, e.g. map-Map ns2:map-Entry ns2:map-Key ns2:std-String value=partyId/ /ns2:map-Key ns2:map-Value ns2:std-String value=1/ /ns2:map-Value /ns2:map-Entry ... There are many options for tidying up the xml, one example is: List Map Entry *key-class*=String key=partyId *value-class*=String value=1/ Entry *key-class*=String key=partyId *value-class*=String value=2/ /Map /List Does anyone have any experience or views on how the xml should be structured? Many thanks, Chris
Re: SVG
BJ, it is not clear to me what is your question but I have used svg to visualize ofbiz data the following way: Create/modify an svg template using inkscape or even a simple xml editor. Then before rendering it as part of ofbiz screen, parse it (it is an xml) and populate with real data from the system. You can also call javascript functions (when the user clicks or mouseover on different elements) or create links in the svg file, which makes it kind of interactive compared to other image formats Bilgin Ibryam On Wed, Feb 16, 2011 at 4:30 AM, BJ Freeman bjf...@free-man.net wrote: is see it is defined for FOP. I have not dug into how it is implemments, hopeing someone will give me a pionter to docs that will help me. what I want to use this for is diagraming ofbiz using this http://free-man.net/customersupport/svg/blackbox.svg where a toplevel black box you could click on and get the links to the black box that are included. then you finally get down to the code of a minilanq for a method in a class. ultimately this would be used to automatically generate junit tests and to give representation in projectmgr of process requirements, in a task. = BJ Freeman Strategic Power Office with Supplier Automation http://www.businessesnetwork.com/automation/viewforum.php?f=52 Specialtymarket.com http://www.specialtymarket.com/ Systems Integrator-- Glad to Assist Chat Y! messenger: bjfr33man
[jira] Commented: (OFBIZ-3862) Ajax requests prevent externalLoginKey parameters from working correctly
[ https://issues.apache.org/jira/browse/OFBIZ-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991396#comment-12991396 ] Bilgin Ibryam commented on OFBIZ-3862: -- I'm also concerned about the security, but I think it is ok Ajax requests prevent externalLoginKey parameters from working correctly Key: OFBIZ-3862 URL: https://issues.apache.org/jira/browse/OFBIZ-3862 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Scott Gray Attachments: externalKey.patch, externalKey.patch A new external login key is generated for every request so if an ajax request fires on a page then the externalLoginKey used in any links on the page is invalidated. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Autocomplete at 1st letter
Isn't it configurable in widget.properties or somewhere else? Bilgin On Sun, Jan 30, 2011 at 7:13 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi, IIRW previously we waited the 3rd entered letter before activating the autocomplete stuff. Now it's at 1st, I'd like to be at 2d, agreed? Jacques
Re: externalLoginKey
Jacques, I think it is related to OFBIZ-3862, ie if there is any ajax event on a page that triggers a screen rendering (even partial one) this generates a new externalLoginKey at the server side, and makes the current externalLoginKey that is already appended to urls not valid. In my opinion the solution is to prevent generating of new externalLoginKeys for ajax calls as proposed on the OFBIZ-3862 Bilgin Ibryam On Sun, Jan 30, 2011 at 11:10 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi, I don't know why but now (for a week or a month?) when I switch from an app to another I have more than before to re-enter the credentials. I tested with FF, Opera and Chrome . Have a delay been changed, any other ideas? Jacques
Re: Groovysh container
I agree with BJ here - keep it same as beanshell container. If you want to comment them out (which I don't mind), we should discuss it in another thread for default enabled containers/features in trunk... my 2c On Sun, Jan 23, 2011 at 6:25 PM, BJ Freeman bjf...@free-man.net wrote: I would say keep the dev friendly pattern in the trunk. I would change it in the relaase branches since they are more targeted as end users. write up a docbook section for the Tech on how to deal with them and the security issues. use the id= in the section so you can put a link on the wiki to the section on the localhost. add demo server script to comment them out if necessary. on a side note, it would be great to add a note on the nightly builds that these are meant for users without configuration. = BJ Freeman Strategic Power Office with Supplier Automation http://www.businessesnetwork.com/automation/viewforum.php?f=52 Specialtymarket.com http://www.specialtymarket.com/ Systems Integrator-- Glad to Assist Chat Y! messenger: bjfr33man Jacques Le Roux sent the following on 1/23/2011 10:04 AM: Hi, Thanks to Rene Scheibe, I have just commited (completed at revision: 1062476) a Groovysh container. It's just fine (though when you type a char on Windows it's duplicated, but it works, see https://issues.apache.org/jira/browse/OFBIZ-3954) but I wonder if we should not rather provide those Beanshell and Groovysh containers commented out. I know it will break the policy we use that provide OOTB a develop friendly version rather than an user/production ready. But it will prevent any admin/user oversights, because it's an important security concern. If a dev needs them, it's really easy to uncomment? What do you think? Thanks Jacques
Re: Wicket in OFBiz
On Mon, Jan 24, 2011 at 12:57 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi devs, James yong submitted a patch (simple enough to be quickly read) proposing to introduce Wicket as an OFBiz framework component. I's be interested to read your comments about pros and cons Note the urlrewrite stuff... One cons I see is maintenance... (We will see if James is still around, he created the Jira issue in August) I tried that patch, it is working and demonstrates an interesting way to use wicket as ofbiz frontend, but it is kind of a hack. I don't think it would be useful at its current stage to the community. For now we use jira for this kind of POC code, but I think there the code dies after some time. May be it is a good idea to have a branch in svn for stuff like this: code that is not complete enough to go in example component or special purpose folder but still valuable as POC or starting point. GWT patch is another similar candidate for it, but it is currently part of googlecode. Regards, Bilgin Ibryam
Re: [VOTE] [RELEASE] Apache OFBiz 10.04
+ 1 Bilgin On Fri, Jan 14, 2011 at 1:04 PM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: This is the vote thread to transform our release candidate 10.04 into an official release. This will be the first release of the 10.04 series (that contains the features up to 2010-04). The files can be downloaded from here: http://people.apache.org/~jacopoc/dist/http://people.apache.org/%7Ejacopoc/dist/ Vote: [ +1] release as Apache OFBiz 10.04 [ -1] do not release For more details about this process please read this http://www.apache.org/foundation/voting.html Kind Regards, Jacopo
Re: ajaxAutocompleteOptions screen
On Fri, Dec 17, 2010 at 9:12 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi, I wonder about this in ajaxAutocompleteOptions screen framework/common/widget/CommonScreens.xml FindAutocompleteOptions.groovy FIXME: Disabled because it represents a security hole. Should we care about it, or simply remove the commentted out snippet? Thanks Jacques You can remove the comment without worries. It applies to the old version of the FindAutocompleteOptions.groovy where entityName was retrieved from parameters, thus allowing users to query any entity. Bilgin
Re: Develop Screen as Google Web Toolkit
Good points Jacques. In case both projects are doing the same thing, it would make reviewing and eventual inclusion of gwt to ofbiz sooner than later. (btw it is no my todo list to check both projects) Bilgin On Thu, Nov 25, 2010 at 7:47 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: BTW, there is also http://code.google.com/p/ofbizify/ Maybe http://code.google.com/p/ofbiz-gwt/ and http://code.google.com/p/ofbizify/ could work together? My 2 cts Jacques From: Chatree Srichart chatree.srich...@gmail.com I added the changing language feature to the OFBiz-GWThttp://code.google.com/p/ofbiz-gwt/project. It would get different languages from exist UI label files. To try this please apply ofbiz-patches and re-compile again. Regards, Chatree Srichart
[jira] Commented: (OFBIZ-3842) Security Update for forgotten passwords
[ https://issues.apache.org/jira/browse/OFBIZ-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934798#action_12934798 ] Bilgin Ibryam commented on OFBIZ-3842: -- + 1 looks nice I think by default requirePasswordChange should behave the same way as in Email password feature. If it is not required to change the password after using Email password link, then it shouldn't be also after generating a random password. Still it is not a big deal, since it is configurable Security Update for forgotten passwords --- Key: OFBIZ-3842 URL: https://issues.apache.org/jira/browse/OFBIZ-3842 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Sascha Rodekamp Assignee: Erwan de FERRIERES Fix For: SVN trunk Attachments: OFBIZ-3842_security.patch, OFBIZ-3842_security.patch, OFBIZ-3842_security.patch Hi everybody, here is a patch that generated a radom Password when the require new password function is called. In the current Trunk it's a kind of hard coded password that will be send to the user. After generating a new pass the requireNewPassword flag will be set to true (configurable). Have a good day Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Opinions wanted
Hi Jacques, I didn't see your message because you used the same thread for jQuery UI docs and demo which was resolved with Jacopo's help :) I think the whole point of moving to jQuery was to have only one javascrip library, so we should get rid of prototype and dojo. But the way to do it should be similar to deprecating methods from the framework: mark the use of these libraries as deprecated, and keep them up to the next ofbiz release. WDYT? Bilgin Ibryam
[jira] Commented: (OFBIZ-3862) Ajax requests prevent externalLoginKey parameters from working correctly
[ https://issues.apache.org/jira/browse/OFBIZ-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12919486#action_12919486 ] Bilgin Ibryam commented on OFBIZ-3862: -- I think a soltuion would be to skip generating of new external login key for ajax requests. Ajax requests can be identified by presens of 'X-Requested-With': 'XMLHttpRequest', http header. It is set by most of the javascript libraries we use: prototype, jquery. WDYT? Bilgin Ajax requests prevent externalLoginKey parameters from working correctly Key: OFBIZ-3862 URL: https://issues.apache.org/jira/browse/OFBIZ-3862 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Scott Gray A new external login key is generated for every request so if an ajax request fires on a page then the externalLoginKey used in any links on the page is invalidated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Multi events same action on widget?
Hi Jacques, I assume you are asking about javasript events and actions. Even the event attribute documentation says events in multiple, the code is able to handle only one event and action. Having the same action would not be a aproblem, the problem is that you can specify one event only for a field. I think for now you will end up writing some additional javascript to catch multiple events (which is very simple with jquery) Bilgin On Thu, Sep 23, 2010 at 9:20 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi, Is there a way to set multi events and same action on a field in a form? Else I will certainly take the time to add that later... Also, if it does not exist yet, more than one event each with its action. Thanks Jacques
Re: svn commit: r995384 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
I have no access to eclıpse for one more week. Feel free to make changes ıf
needed.
Bılgın
On Fri, Sep 10, 2010 at 8:01 AM, Ashish Vijaywargiya
vijaywargiya.ash...@gmail.com wrote:
Thanks Scott for your comment.
Bilgin, can you please look into this issue and provide/propose better
solution that works for both of us?
--
Ashish
On Fri, Sep 10, 2010 at 4:18 AM, Scott Gray scott.g...@hotwaxmedia.com
wrote:
Hi Ashish,
It looks like you and Bilgin are going back and forth on this:
http://svn.apache.org/viewvc?view=revisionrevision=894359
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 9/09/2010, at 11:32 PM, ash...@apache.org wrote:
Author: ashish
Date: Thu Sep 9 11:32:28 2010
New Revision: 995384
URL: http://svn.apache.org/viewvc?rev=995384view=rev
Log:
Fixing bug of reading node name. When we read first child element of the
response of any third party integration for example ups etc, node name can't
be read using node.getLocalName(). So changing node.getLocalName() --
node.getNodeName().
Thanks Vivek for the contribution.
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?rev=995384r1=995383r2=995384view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java
(original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java Thu
Sep 9 11:32:28 2010
@@ -803,7 +803,7 @@ public class UtilXml {
if (node != null) {
do {
if (node.getNodeType() == Node.ELEMENT_NODE
(childElementName == null ||
-childElementName.equals(node.getLocalName(
{
+childElementName.equals(node.getNodeName( {
Element childElement = (Element) node;
return childElement;
}
Re: Removing the ShoppingCart.containOnlyDigitalGoods
+ 1 Bilgin On Wed, Jul 7, 2010 at 11:39 AM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: What about removing the ShoppingCart.containOnlyDigitalGoods methods and use instead the public boolean shippingApplies() ? (We will also need a new shippingApplies method that takes as input the shipgroup). In fact the logic in shippingApplies is the one used in several other places to determine the shipping charges. Kind regards, Jacopo
Re: svn commit: r948439 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java
We should probably restart the conversation about why it is included in OFBiz at some point. Regards Scott Good idea Bilgin
Re: subcribe
You can do it from here https://cwiki.apache.org/confluence/display/OFBADMIN/Mailing+Lists Bilgin On Tue, May 25, 2010 at 7:15 AM, Parihar, Awdesh apari...@emforium.comwrote: Hi, I want to subscribe developer mailing list on my Id , I have been working with ofbiz for last 2.5 year . -- Thanks Awdesh Parihar
Re: Using only ${OFBIZ_HOME}/specialpurpose/ecommerce component
You can disable specialpurpose components w/o much worries. As for the components in application and framework, you have to do that by checking each component separately, because most of them are internally used by ecommerce. For example party, catalog, order, facility, accounting, content are all required for ecommerce to work properly. If you need only a web store application, you may even consider other solutions (like osCommerce), because ofbiz is more than a web store. Bilgin On Tue, May 25, 2010 at 10:40 AM, rrhati2010 rr.h...@tcs.com wrote: Hi, I want to use only the ecommerce component. So what all components I need to prevent from loading during the ofbiz application start-up i.e from component-load.xml present the a. application b. framework c. specialpurpose folders, so that, the application uses less memory and improve it's performance. -- View this message in context: http://ofbiz.135035.n4.nabble.com/Using-only-OFBIZ-HOME-specialpurpose-ecommerce-component-tp2229735p2229735.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: svn commit: r942576 - in /ofbiz/trunk/framework/example: config/ExampleUiLabels.xml widget/example/FormWidgetExampleForms.xml
On Mon, May 10, 2010 at 7:52 AM, Jacques Le Roux
jacques.le.r...@les7arts.com wrote:
This is great and I better explained all that in the user ML. But I wonder
now why there is no show-description boolean attribute for the lookup
field.
Also a bit of documentation (at least in widget-form.xsd, maybe a word in
new feature wiki page) would not hurt, Bilgin? Do I still miss something?
Jacques,
there is no show-description but I will add it very soon. Also will update
the xsd.
Thanks for the reminder.
Bilgin
Thanks
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
Hi Scott,
Yes you are right this was not what I was looking for, and BTW it's true
by default.
I remember now that at r936638 Bilgin has activated by default the option
(Enabled lookup descriptions) I was looking for (for an explanation on
lookups on user ML).
It's just that sometimes it does not work just because of
client-autocomplete-field, sometimes it does (on the same browser), not sure
why, anyway not a big deal.
I removed it, since it's redundant and useless, at r942667
Thanks
Jacques
Scott Gray wrote:
I'm not sure if this affects what you've committed but
client-autocomplete is not ajax autocomplete, it just tells the browser
whether or not to try and autocomplete with values previously entered.
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 10/05/2010, at 6:39 AM, jler...@apache.org wrote:
Author: jleroux
Date: Sun May 9 18:39:03 2010
New Revision: 942576
URL: http://svn.apache.org/viewvc?rev=942576view=rev
Log:
Show client-autocomplete-field usage
Modified:
ofbiz/trunk/framework/example/config/ExampleUiLabels.xml
ofbiz/trunk/framework/example/widget/example/FormWidgetExampleForms.xml
Modified: ofbiz/trunk/framework/example/config/ExampleUiLabels.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/example/config/ExampleUiLabels.xml?rev=942576r1=942575r2=942576view=diff
==
---
ofbiz/trunk/framework/example/config/ExampleUiLabels.xml (original) +++
ofbiz/trunk/framework/example/config/ExampleUiLabels.xml
Sun May 9 18:39:03 2010 @@ -447,8 +447,8 @@
value xml:lang=frLookup de type layer (only test)/value
/property
property key=ExampleLookupFields
-value xml:lang=enExamples Lookup Fields (first of type
popup, second layered)/value
-value xml:lang=frExemples de champs de recherche (le
premier de type popup, le second de type layer)/value
+value xml:lang=enExamples Lookup Fields (first of type
popup using also autocomplete, second layered and showing
use of set_values underneath, ie returning not only Id but also another
value)/value +value xml:lang=frExemples de
champs de recherche (le premier de type popup utilisant aussi
l'autocompletion, le second de type layer avec usage
sous-jacent de set_values qui permet de traiter non seulement une
référence mais aussi une autre valeur)/value
/property property key=ExampleMainPage value
xml:lang=enExample Main Page/value
Modified:
ofbiz/trunk/framework/example/widget/example/FormWidgetExampleForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/example/widget/example/FormWidgetExampleForms.xml?rev=942576r1=942575r2=942576view=diff
==
---
ofbiz/trunk/framework/example/widget/example/FormWidgetExampleForms.xml
(original) +++
ofbiz/trunk/framework/example/widget/example/FormWidgetExampleForms.xml
Sun May 9 18:39:03 2010 @@ -285,7 +285,7 @@ under the
License. !-- Lookup (in a popup windows, old style) --
!-- Using separated labels is not recommended (it's better using
sentences than words for translation) but here we use
only Common labels to avoid dependencies from application to
framework -- field name=partyIdFrom
title=${uiLabelMap.CommonPartyID} ${uiLabelMap.CommonFrom}!-- we use
partyIdFrom here only to differentiate from the other
partyId field we use below, ie partyIdTo-- -lookup
target-form-name=LookupPartyExample presentation=window/ +
lookup target-form-name=LookupPartyExample
presentation=window client-autocomplete-field=true/ /field
!-- Standard Lookup in a layer (new style)--
!-- passes the name in one and the id in another field --
[jira] Commented: (OFBIZ-3211) Ajaxifying lookup fields
[ https://issues.apache.org/jira/browse/OFBIZ-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863161#action_12863161 ] Bilgin Ibryam commented on OFBIZ-3211: -- Thanks Adrian. BTW in rev 940274 I moved the span and img creation to javascript, but I think it doesn't solve the empty src attribute problem. At least now it the renderer is cleaner. Ajaxifying lookup fields Key: OFBIZ-3211 URL: https://issues.apache.org/jira/browse/OFBIZ-3211 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ajax-loader.gif, ajaxLookup.patch, ajaxLookup.patch To see how it works, apply the patch (optionally add ajax-loader.gif to framework\images\webapp\images\) and go to Accounting - Find Invoices (or to any other screen with form widget that uses LookupPartyName lookup ). Then type some letters to From Party ID or To Party ID fields. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [VOTE] [BRANCH] Creation of the Release Branch release10.04
+ 1 Bilgin This is the vote thread to create a new release branch (not a release yet) named release10.04. This branch will represent a feature freeze and releases will be created over time out of it: all the commits in this branch will be for bug fixes only, no new features. Vote: [ +1] create the branch release10.04 [ -1] do not create the branch We will use the same rules for votes on releases (vote passes if there are more binding +1 than -1 and if there are at least 3 binding +1) For more details about this process please read this http://www.apache.org/foundation/voting.html Kind Regards, Jacopo
Re: Consistent required field indicators
Inline
Adrian Crum wrote:
--- On Fri, 4/23/10, Robert Morley rmor...@emforium.com wrote:
+1 - I think properly modeling the
field using the required-field attribute makes perfect
sense. I would think our html form renderer
implementation should probably just apply a class required
at render time and the visual should be handled by css.
I believe I was the one who introduced the required CSS class and that was my
reasoning - have the style sheet determine what a required field looks like.
At the time, the asterisk was being used to indicate a required field. The
problem was, most forms didn't have an explanation as to what the asterisk
meant. So the result looked odd.
Asterix is used to indicate required fields, and it is pretty common
practice http://simplyaccessible.org/examples/required-form-fields
No best practice was discussed or decided upon. I just put the new CSS class
in the style sheet and I left it to the community to decide by using it or not.
It seems community is still not agreed on what to use, and the result is
a mess
I like the idea of service definitions driving the required fields.
When a form is based on a service definition (auto-fields-service) not
optional fields are marked as required. My intention is not to change or
extend this behavior. It is already working correct. My intention is to
cleanup other forms which have manually set required indicators.
Sure, that would be nice. However, what happens when service A calls
service B, and service C sometimes dependening on the situation. How
would you chain the validations, so that no processing code was run in
A until both B and C were satisified that the data was correct?
This thread is only about:
1. Cleaning up the forms: remove the required label
(tooltip=${uiLabelMap.CommonRequired}) and css style
(widget-style=required) and add in their place required-field=true
2. Change macro renderer so that if a field is required it is indicated
by asterix (as it is right now) plus a css style (the same as
widget-style=required)
Are there any objections to this?
Bilgin
-Adrian
On Apr 23, 2010, at 2:35 PM, Bilgin Ibryam wrote:
Here is what I propose:
Remove all the ${uiLabelMap.CommonRequired} tooltips
from form definitions. The tooltip should be used to provide
other information as it is for not required fields (the
purpose of the field, the format)
Remove all the widget-style=required from form
definitions.
If a field is required, (on form widget) set only its
attribute required-field=true. In cases when the form is
based on service definition (auto-fields-service) it is not
neccessary to set this attribute. Then no need to add
tooltip=${uiLabelMap.CommonRequired} or
widget-style=required attibutes on the form definition.
The renderer should decide how to indicate the required
field.
Change form renderer, so if a field is required it is
indicated by asterix plus required style ( same as
widget-style=required)
[jira] Closed: (OFBIZ-3515) Use UiLabel for required
[ https://issues.apache.org/jira/browse/OFBIZ-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3515. Assignee: Bilgin Ibryam Resolution: Fixed Thanks Deepak, your patch is in trunk rev 937278 Use UiLabel for required --- Key: OFBIZ-3515 URL: https://issues.apache.org/jira/browse/OFBIZ-3515 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Deepak Dixit Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3515.patch There are too many places where required is hard coded , need to use appropriate uiLabel for the same. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Consistent required field indicators
I see 3 different ways to indicate required fields in the system:
1. asterix generated from form widget when required-field=true (55
occurrences + 346 auto-fields-service occurrences which also have some
required fields)
2. gray background of text field done by widget-style=required (122
occurrences )
3. required the label is set in FTLs and also in form widgets using
tooltip=${uiLabelMap.CommonRequired} (280 occurrences )
There are also different combinations of above 3 ways
I don't know why there are 3 different ways and what is the current best
practice but I think we should agree on one way to indicate required
fields and use it all over the framework.
Here is what I propose:
Remove all the ${uiLabelMap.CommonRequired} tooltips from form
definitions. The tooltip should be used to provide other information as
it is for not required fields (the purpose of the field, the format)
Remove all the widget-style=required from form definitions.
If a field is required, (on form widget) set only its attribute
required-field=true. In cases when the form is based on service
definition (auto-fields-service) it is not neccessary to set this
attribute. Then no need to add tooltip=${uiLabelMap.CommonRequired} or
widget-style=required attibutes on the form definition. The renderer
should decide how to indicate the required field.
Change form renderer, so if a field is required it is indicated by
asterix plus required style ( same as widget-style=required)
WDYT?
Bilgin Ibryam
Re: Lookups desccriptions
Jacques Le Roux wrote: Hi, At r933130 Bilgin introduced a nice feature which allows to show the related descriptions (if exist) of Ids used/rendered in lookups fields. There is also a showDescription lookup attribute to hide if needed. I wonder if we could not show them by default (Bilgin set the widget.lookup.showDescription to N in widget.properties) and hide descriptions where they will be annoying (for instance in the Catalog main/landing page left column ) Jacques In rev 936638 I enabled lookup descriptions. They are annoying when there is not enough space, for instance if the lookup is on the left bar, or when the form has more than one column. Anyway, it is easy to disable them if needed. Or we can make the descriptions to appear as html tooltips ie they may appear only when user puts the mouse over the ID. Bilgin
[jira] Commented: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12858573#action_12858573 ] Bilgin Ibryam commented on OFBIZ-3555: -- Thanks for testing Jacques. I saw your post in OFBIZ-3442 that actually there is no error. I tested the lookup descriptions in catalog and order manager, and it is working correct in both places using FTL. If you find a specific screen, let me know and I will check it. In the mean time I did a fix in rev 935644, which was needed after changes in the generated html Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r935387 - in /ofbiz/trunk: applications/accounting/data/ applications/party/data/ applications/workeffort/data/ framework/service/data/ framework/service/entitydef/ framework/webtools/
Adrian Crum wrote: Bilgin, Thank you for working on this. It would be better to make the descriptions more like plain English. Instead of Day of Week Range 1 just have Sunday, etc. Maybe spend some time constructing a few temporal expressions to help find a balance between plain English and selecting the correct expression. -Adrian Thanks for the suggestions Adrian. Updated some of the descriptions in rev 935695 Feel free to change them if you think that are not appropriate. Bilgin
[jira] Closed: (OFBIZ-3521) Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN
[ https://issues.apache.org/jira/browse/OFBIZ-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3521. Assignee: Bilgin Ibryam Fix Version/s: SVN trunk Resolution: Fixed Added the field in rev 935387. Feel free to improve the descriptions. Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN - Key: OFBIZ-3521 URL: https://issues.apache.org/jira/browse/OFBIZ-3521 Project: OFBiz Issue Type: Improvement Components: workeffort Affects Versions: SVN trunk Reporter: chris snow Assignee: Bilgin Ibryam Priority: Trivial Fix For: SVN trunk To improve usability of the example DAYOFWEEK_0x expressions, they would be more easily understood if they use the actual day name. Looking at DAYOFWEEK_01, I wasn't sure whether this was SUN or MON without looking at the expression definition. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Bug in svn commit: r931416 - Added support for setting a class attribute (using widget-style) on the div rendered by ContainerField.
Blas Rodriguez Somoza wrote:
Hello
There is an bug in this commit, htmlFormMacroLibrary.ftl expects
arguments id and className and HtmlFormRenderer.java and
MacroFormRenderer.java provides id and class.
The error is visible in SFA Manager- [Accounts | Contacts | Leads ]
Macro renderContainerField has no such argument: class The problematic
instruction: -- == macro renderContainerField [on line 505,
column 1 in component://widget/templates/htmlFormMacroLibrary.ftl] in
user-directive renderContainerField [on line 1, column 1 in Mon Apr 12
03:01:04 CEST 2010] -- Java backtrace for programmers:
-- freemarker.template.TemplateException: Macro
renderContainerField has no such argument:
#macro renderContainerField id classNamediv id=${id}
class=${className}//#macro
MacroFormRenderer.java
public void renderContainerFindField(Appendable writer,
MapString, Object context, ContainerField containerField)
throws IOException {
String id = containerField.getId();
String className =
UtilFormatOut.checkNull(containerField.getModelFormField().getWidgetStyle());
StringWriter sr = new StringWriter();
sr.append(@renderContainerField );
sr.append(id=\);
sr.append(id);
sr.append(\ class=\);
sr.append(className);
sr.append(\ /);
executeMacro(writer, sr.toString());
}
HtmlFormRenderer.java
public void renderContainerFindField(Appendable writer, MapString,
Object context, ContainerField containerField) throws IOException {
writer.append(div );
String id = containerField.getId();
if (UtilValidate.isNotEmpty(id)) {
writer.append(id=\);
writer.append(id);
writer.append(\ );
}
String className =
containerField.getModelFormField().getWidgetStyle();
if (UtilValidate.isNotEmpty(className)) {
writer.append(class=\);
writer.append(className);
writer.append(\ );
}
writer.append(/);
}
Regards
Blas
Thanks for reporting Blas, fixed in rev 933099
Bilgin
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12855856#action_12855856 ] Bilgin Ibryam commented on OFBIZ-3541: -- Thanks Blas, fixed in rev 933108 Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Fix For: SVN trunk Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3555. Resolution: Fixed Committed to trunk in rev 933130 To see this feature in action set widget.lookup.showDescription to Y in widget.properties Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] [RELEASE] Apache OFBiz 09.04
Jacopo Cappellato wrote: This is the vote thread to transform our release candidate 09.04 into an official release. The files can be downloaded from here: http://people.apache.org/~jacopoc/dist/ Vote: [ +1] release as Apache OFBiz 09.04 [ -1] do not release For more details about this process please read this http://www.apache.org/foundation/voting.html Kind Regards, Jacopo + 1 Bilgin
[jira] Updated: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch Made show/hide lookup description configurable from widget.properties Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853924#action_12853924 ] Bilgin Ibryam commented on OFBIZ-3541: -- Jacques, I applied your patch, browsed a little bit and didn't notice anything wrong. Bilgin Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: squareFootage with decimals
Jacques Le Roux wrote: The only piece we could possibly neglict is IMO the service part (it's the longer part). If we provide a simple SQL script I think it's enough for people to at least infer what to do on their own DB(s). Jacques Jacques, I agree with you on this proposal - the process should be easier for developers but also available for users willing to do the data migration. Bilgin
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853245#action_12853245 ] Bilgin Ibryam commented on OFBIZ-3541: -- Jacques, In rev 930660 I committed my patch (I don't want it to get obsolete) and also updated yours (replaced ormrenderer.renderLookupField with htmlTemplate.lookupField) Also could you tell me why we need to replace targets in controllers? Can't we reuse existing requests? I can't see the related discussion about this change? Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3541: - Attachment: OFBIZ-3541 Using Widgets html form templates in FTL files.patch Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)
[
https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853247#action_12853247
]
Bilgin Ibryam commented on OFBIZ-3623:
--
Blas,
in rev 930670 I removed double ampersands from autoCompleterTarget because it
was breaking the lookup autocompleter.
Why do we need double ampersands there in case that autoCompleterTarget is not
a real url, but part of javscript code?
Bilgin
XHTML validation errors (framework/widget)
--
Key: OFBIZ-3623
URL: https://issues.apache.org/jira/browse/OFBIZ-3623
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Blas Rodriguez Somoza
Assignee: Adrian Crum
Priority: Trivial
Fix For: SVN trunk
Attachments: OFBIZ-3623_framework_widget_xhtml.diff,
OFBIZ-3623_framework_widget_xhtml_v2.diff
XHTML validation errors
* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without
* Uppercase tags or attributes.
* Unencoded ampersands in urls.
Other errors:
htmlFormMacroLibrary.ftl
Line 452. img tag must have src and alt attributes.
span id=${id}_indicator style=display: none class=indicatorimg
//span
htmlScreenMacroLibrary.ftl
Wrong markup at Line 143. Entity without final ;
nbsp/a/li
Changes in java classes:
MacroFormRenderer.java (renderSortField)
The sort URL must use encoded ampersands.
HtmlFormRenderer.java (renderDisplayField)
The alert style must be included in the class attribute not appear as a
attribute name (which is what happens now)
HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
XHTML don't like empty UL. To avoid that, the renderMenuOpen and
renderMenuClose methods need to know how many menu items pass the condition
and so will be included.
ModelMenu.java (public int passConditionCount)
New method to get how many menu items pass the condition.
ModelMenuItem (public boolean passCondition)
New method to get if the menu item pass the condition.
Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Use of internal direct variable access, or using accessor methods
Adam Heath wrote: ComparableRange has inconsistent access to the instance variables of other ComparableRanges. There are several methods that do some kind of comparison with another range. Sometimes, those methods call the accessor methods. Other times, direct variable access is used. Here's my take on this issue, based on the Concurrency in Practice book. If ComparableRange is final, and not meant to be extended, then always do direct access, period. If ComparableRange is supposed to be extended by other classes, then make the instance variables final(to force extended classes to use the accessors), How can making an instance variable final force using accessors? Do you mean private instead of final? Bilgin then the base class always must use the accessors. Of course, this kind of design pattern needs to be imployed in the rest of the code too.
[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups
[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851381#action_12851381 ] Bilgin Ibryam commented on OFBIZ-3442: -- Jacques, what I tried to say is that the default position (it doesn't matter for me if it is center , normal or something else) should be set only in xsd file, but not in all the forms and fields. This way, changing the default position will require only a change in xsd file instead of all the form fields. Replace popup lookups by layer lookups -- Key: OFBIZ-3442 URL: https://issues.apache.org/jira/browse/OFBIZ-3442 Project: OFBiz Issue Type: Sub-task Components: ALL APPLICATIONS Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Minor Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups. For that please find a patch attached. In this patch I followed a simple S/R tactic: * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens * I replaced all occurences of lookup by lookup presentation=layer position=center It's as simple as this. For the moment I decided to use as default position=center because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position=center and use the default (position=normal) which does not move the layer from the point it's called and will be more aesthetic. I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far. The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in. Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them. There are issues to be fixed prior to a commit, see OFBIZ-3446. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Calendar Popup Issues
Adrian Crum wrote: There is a Jira issue somewhere. I remember suggesting that we should serve the calendar popup from the server (like we do with lookup windows) to solve those issues. -Adrian I think this was the calendar: https://issues.apache.org/jira/browse/OFBIZ-1628 Bilgin
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3541: - Attachment: widgetMacrosInFtlImprove.patch.diff Bruno, I made some improvements to your code in order to add autocompleter support in ftl lookups. To achieve this, I introduced the initial template file you created and set there all the default values needed by htmlFormMacroLibrary.ftl. This gives more possibilities to get the default values in case they are not fixed strings (like autocompleter url) and keeps the rendering ftl cleaner. I attached the patch here, in case you (or someone else) wants to check it, before committing. Next strep would be to replace all the lookup fields (around 70) in ftl files with new lookup macro. Bilgin Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco Assignee: Bruno Busco Attachments: widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reopened OFBIZ-3541: -- Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco Assignee: Bruno Busco Attachments: widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Valid party Ids
Scott Gray wrote: On 17/03/2010, at 10:37 AM, Jacques Le Roux wrote: Bilgin, I guess Scott spoke about ContainsOnly at http://commons.apache.org/lang/api/org/apache/commons/lang/StringUtils.html That's the right class but I was talking about StringUtils.isNumeric(String) Jacques From: Bilgin Ibryam bibr...@gmail.com Marc Morin wrote: We use a prefix for each instance, so our id's are of the format \\d+-\d+. So, looks like this kind of check, is a function of how your entityengine.xml file is configured. Scott, I can't find the method in StringUtil, but the regex proposed by Adam is enough. Marc, could you elaborate more on how these IDs are related to entityengine? Bilgin Thanks all. Done in trunk rev 924685
Valid party Ids
createPerson and createPartyGroup services don't accept party Ids starting with a number. I wonder what is the reason for this restriction? I suppose it is done to prevent users from entering numbers as partyId which may interfere with auto generated Ids. If this is the case I propose to change the logic, so instead of checking only the first character, it checks all the characters from the Id and refuse it ONLY IF all the characters are numbers. WDYT? I faced this problem while trying to import data in ofbiz, where the Ids start with number but contains also some letters. In this case it is not possible to interfere with auto generated Ids but still they are not accepted as valid Ids. Bilgin
Re: Valid party Ids
Marc Morin wrote: We use a prefix for each instance, so our id's are of the format \\d+-\d+. So, looks like this kind of check, is a function of how your entityengine.xml file is configured. Scott, I can't find the method in StringUtil, but the regex proposed by Adam is enough. Marc, could you elaborate more on how these IDs are related to entityengine? Bilgin
[jira] Updated: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3555) Show lookup value descriptions
Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845321#action_12845321 ] Bilgin Ibryam commented on OFBIZ-3555: -- Jacques, I think we are on the same page. The final goal is to have possibility for displaying description/name instead_of OR together_with the ID. In most of other web based systems it is the way you described: the ID is stored in a hidden field, and the description is in the input box. I think this can be easily done once we have the descriptions available. But as you already know ofbiz lookup definitions don't have information about how to get the description information (there is only lookup url) so I decided to reuse the autocompleter logic and get the description the same way. Note that autocompleter and lookup descriptions are available only to form widget lookups which refer to lookup screens with autocompleter support. Once we are sure that it is covered in most of ofbiz screen we can think on hiding the IDs totally (or it can be configured) and display only the description. Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: add story field also on custRequest header
Scott Gray wrote: Hi Hans, I would recommend using the custRequestItem for the story, the implementation can be simple enough by using a service to create the header and item in a single call and a view entity could could them back to you as a single record. Conceptually what you really have is a customer request with a single item. I don't like the idea of modifying the data model when it is already quite capable of meeting your needs. Regards, Scott Agreed with Scott. Having two places for the same information will be confusing/redundant and such a change should not go to ofbiz svn in that case. Bilgin
[jira] Commented: (OFBIZ-3529) Derby database can truncate entity fields 8K
[ https://issues.apache.org/jira/browse/OFBIZ-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12843971#action_12843971 ] Bilgin Ibryam commented on OFBIZ-3529: -- Hi Mike, could you check if the error is gone after rev 921455 Bilgin Derby database can truncate entity fields 8K --- Key: OFBIZ-3529 URL: https://issues.apache.org/jira/browse/OFBIZ-3529 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: OS X, Derby database Reporter: Mike Voytovich I was attempting to use the UPS shipment code in OFBiz to generate shipping labels. Note that this was using the default Derby database. OFBiz is able to send the confirm/accept requests and receive the responses, but an error is returned from UPS in handleUpsShipmentAcceptResponse - The XML document is not well formed. It turns out that we're properly receiving a 20,000 byte ShipmentDigest from UPS in the handleUpsShipmentConfirmResponse method; but it looks like this is being truncated to exactly 8K when written out to the ShipmentRouteSegment entity. i.e., the ShipmentDigest data is truncated to 8K when being read back from the entity. The trackingDigest field-type is very-long with a SQL type of CLOB, so I would expect it to save ~20K without issue. I switched over to MySQL for the database, and now the data is stored correctly. Note that there are no error messages in the logs regarding this truncation, and there's nothing in the documentation indicating that entity fields are limited to 8K when using the Derby database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r902341 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/MiscConverters.java
adri...@apache.org wrote:
Author: adrianc
Date: Sat Jan 23 05:38:09 2010
New Revision: 902341
URL: http://svn.apache.org/viewvc?rev=902341view=rev
Log:
Small improvement to ClobToString converter.
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/MiscConverters.java
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/MiscConverters.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/MiscConverters.java?rev=902341r1=902340r2=902341view=diff
==
---
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/MiscConverters.java
(original)
+++
ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/MiscConverters.java
Sat Jan 23 05:38:09 2010
@@ -108,15 +108,13 @@
}
public String convert(Clob obj) throws ConversionException {
-StringBuilder strBuf = new StringBuilder();
-char[] inCharBuffer = new char[CHAR_BUFFER_SIZE];
-int charsRead = 0;
+char[] charBuffer = null;
Reader clobReader = null;
try {
-clobReader = obj.getCharacterStream();
-while ((charsRead = clobReader.read(inCharBuffer, 0,
CHAR_BUFFER_SIZE)) 0) {
-strBuf.append(inCharBuffer, 0, charsRead);
-}
+int clobLength = (int) obj.length();
+charBuffer = new char[clobLength];
+clobReader = obj.getCharacterStream();
+clobReader.read(charBuffer, 0, clobLength);
} catch (Exception e) {
throw new ConversionException(e);
}
@@ -127,7 +125,7 @@
} catch (IOException e) {}
}
}
-return strBuf.toString();
+return new String(charBuffer);
}
}
Adrian, there is a problem with this improvement:
the following line
clobReader.read(charBuffer, 0, clobLength);
can't read more than 8192 chars when used with derby database (I didn't check
with other databases).
The bug appeared when I tried to read big xml file stored in ElectronicText
entity and got the xml truncated.
Also I think this is the cause for
https://issues.apache.org/jira/browse/OFBIZ-3529
Bilgin
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3541: - Attachment: widgetMacrosInFtl.patch Bruno, I tested your patch, good work, thanks for it. Also updated the patch, so we don't need to import the macros in each template. Bilgin Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco Attachments: widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3521) Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN
[ https://issues.apache.org/jira/browse/OFBIZ-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12842001#action_12842001 ] Bilgin Ibryam commented on OFBIZ-3521: -- I also think a description would be helpful, IDs are not very user friendly Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN - Key: OFBIZ-3521 URL: https://issues.apache.org/jira/browse/OFBIZ-3521 Project: OFBiz Issue Type: Improvement Components: workeffort Affects Versions: SVN trunk Reporter: chris snow Priority: Trivial To improve usability of the example DAYOFWEEK_0x expressions, they would be more easily understood if they use the actual day name. Looking at DAYOFWEEK_01, I wasn't sure whether this was SUN or MON without looking at the expression definition. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Consistent result messages
Thanks guys, done in rev 917467 Bilgin
Consistent result messages
Hi, When call-service element is used in simple method and there is no error or success message in the result, a default message is returned The action was performed successfully The problem is that this message is returned only in simple methods when call-service is used, and the user gets a wrong impression that other clicks don't perform any actions. Recently I even faced a screen where simple method was used for data gathering and the message was displayed w/o performing an action on the screen. My proposal is to remove this default message value (actually it is the default value for the default-message element in call-service), and if there is no default-message specified, to return no message as it is other places. WDYT? Bilgin
Re: Form extension mechanims and sort-order
Jacques Le Roux wrote: Hi, Is there a reson why the sort-order block is not extended by default when you extend a form? I don't see any reason. You have to duplicate it in case it's the same... Jacques + 1 to extend also sort-order element. Bilgin
[jira] Closed: (OFBIZ-3368) workeffort calendar bug when no demo data is installed
[ https://issues.apache.org/jira/browse/OFBIZ-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3368. Resolution: Fixed Assignee: Bilgin Ibryam Thanks Chris. A modified version is committed to trunk rev 916703 Bilgin workeffort calendar bug when no demo data is installed -- Key: OFBIZ-3368 URL: https://issues.apache.org/jira/browse/OFBIZ-3368 Project: OFBiz Issue Type: Bug Components: workeffort Affects Versions: Release Branch 9.04, SVN trunk Reporter: chris snow Assignee: Bilgin Ibryam Attachments: workeffortCalendar_Trunk.diff I have installed the extseed data, but NOT the demo data. When I go to the Calendar in webtools (logged in as admin) using the URL https://localhost:8443/workeffort/control/day, I get the following exception. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://workeffort/widget/CalendarScreens.xml#CalendarDay]: org.ofbiz.base.util.GeneralException: Error running Groovy script at location [component://workeffort/webapp/workeffort/WEB-INF/actions/calendar/Days.groovy] (Service [getWorkEffortEventsByPeriod] target threw an unexpected exception (null)) (Error running Groovy script at location [component://workeffort/webapp/workeffort/WEB-INF/actions/calendar/Days.groovy] (Service [getWorkEffortEventsByPeriod] target threw an unexpected exception (null))) I'm not sure if this is a bug, but I would have expected is to work with extseed data. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r916710 - in /ofbiz/branches/release09.04: ./ applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
I'm using for the first time mergefromtrunk.bat and I wonder are these prop changes coming from it? bibr...@apache.org wrote: Author: bibryam Date: Fri Feb 26 15:15:33 2010 New Revision: 916710 URL: http://svn.apache.org/viewvc?rev=916710view=rev Log: Applied fix from trunk for revision: 916703 r916703 | bibryam | 2010-02-26 16:59:14 +0200 (ЇҐв, 26 䥢а 2010) | 3 lines Committed a modified patch from Chris Snow workeffort calendar bug when no demo data is installed https://issues.apache.org/jira/browse/OFBIZ-3368 Modified: ofbiz/branches/release09.04/ (props changed) ofbiz/branches/release09.04/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java Propchange: ofbiz/branches/release09.04/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Fri Feb 26 15:15:33 2010 @@ -1 +1 @@ -/ofbiz/trunk:765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770308,770997,771073,771477,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,68,92,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,806914,808786-808787,808792,809141,810370,810438,810465,810 807,810809,810814,810832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,818976,819275-819276,819282,819337,821263,821270,822659,823877-823878,823883,823888,823892,824511,825181-825182,826253,827730,828971,829085,829376,829412,829416,829527,830091,830112,830366,830528,830677,830874,830880,831238,831801,832361,832698,832776,832908,833324,833686,833703,834825,835161,835357,835585,836015,881194,881713,882072,882326,882918,883933,884023,884529,884546,884758,885122,885702,887916,888111,888559,888587,889666,890050,890107,890245,891378,891620,896649,899188,899833,900024,900026,900050,900217,900273,901628,907342-907343,910460,912587,915332,916252 +/ofbiz/trunk:765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770308,770997,771073,771477,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,68,92,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,806914,808786-808787,808792,809141,810370,810438,810465,810 807,810809,810814,810832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,818976,819275-819276,819282,819337,821263,821270,822659,823877-823878,823883,823888,823892,824511,825181-825182,826253,827730,828971,829085,829376,829412,829416,829527,830091,830112,830366,830528,830677,830874,830880,831238,831801,832361,832698,832776,832908,833324,833686,833703,834825,835161,835357,835585,836015,881194,881713,882072,882326,882918,883933,884023,884529,884546,884758,885122,885702,887916,888111,888559,888587,889666,890050,890107,890245,891378,891620,896649,899188,899833,900024,900026,900050,900217,900273,901628,907342-907343,910460,912587,915332,916252,916703 Modified:
Re: svn commit: r916710 - in /ofbiz/branches/release09.04: ./ applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java
Jacques Le Roux wrote: Yes it is Jacques ok, thanks Jacques Bilgin
[jira] Closed: (OFBIZ-3484) Field which do not show any info or cannot be edited needs to be hidden
[ https://issues.apache.org/jira/browse/OFBIZ-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3484. Resolution: Fixed Fix Version/s: SVN trunk Assignee: Bilgin Ibryam Thanks Babu, it is fixed in trunk rev 916206 Field which do not show any info or cannot be edited needs to be hidden --- Key: OFBIZ-3484 URL: https://issues.apache.org/jira/browse/OFBIZ-3484 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk Environment: SVN Rev. 910622 Reporter: Babu Sreekanth Assignee: Bilgin Ibryam Priority: Trivial Fix For: SVN trunk Attachments: screenshot.3.png In Accounting Manager -- Agreements -- Create Agreement Item screen, Agreement Item Seq Id label is displayed without any text or input field. See the attached image. This field probably needs to be hidden. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: MSSQL datetime issue with ofbiz UtilDatetime.getDayEnd function
Thanks for the solution Adrian. Done in trunk rev 912509 Bilgin We could set the nanoseconds to zero with a note that it is for MySql compatibility. -Adrian --- On Mon, 2/15/10, Bilgin Ibryam bibr...@gmail.com wrote: From: Bilgin Ibryam bibr...@gmail.com Subject: MSSQL datetime issue with ofbiz UtilDatetime.getDayEnd function To: dev@ofbiz.apache.org Date: Monday, February 15, 2010, 3:25 AM Hi all, I have a problem with UtilDate.getDayEnd function used with MSSQL database. Ofbiz timestamp fields on the forms usually have millisecond precision, like this 2010-2-25 1:10:15.268 But when UtilDate.getDayEnd is used, it sets the nano seconds to 9 and the timestamp is stored in DB as 2010-2-25 23:59:59.9 And when MSSQL is used this timestamp gets rounded and becomes 2010-2-26 00:00:00.0 because MSSQL datetime field has accuracy of 3 milliseconds - http://msdn.microsoft.com/en-us/library/aa258277%28SQL.80%29.aspx ie there is no .999 but only .997 and then .000 milliseconds. Any idea how to deal with this problem? Do we really need nano second precision for day end? May we should have it configurable so MSSQL users can set a value of 99000 in their instances Thanks in advance. Bilgin
MSSQL datetime issue with ofbiz UtilDatetime.getDayEnd function
Hi all, I have a problem with UtilDate.getDayEnd function used with MSSQL database. Ofbiz timestamp fields on the forms usually have millisecond precision, like this 2010-2-25 1:10:15.268 But when UtilDate.getDayEnd is used, it sets the nano seconds to 9 and the timestamp is stored in DB as 2010-2-25 23:59:59.9 And when MSSQL is used this timestamp gets rounded and becomes 2010-2-26 00:00:00.0 because MSSQL datetime field has accuracy of 3 milliseconds - http://msdn.microsoft.com/en-us/library/aa258277%28SQL.80%29.aspx ie there is no .999 but only .997 and then .000 milliseconds. Any idea how to deal with this problem? Do we really need nano second precision for day end? May we should have it configurable so MSSQL users can set a value of 99000 in their instances Thanks in advance. Bilgin
Re: svn commit: r910235 - in /ofbiz/trunk/framework/common: servicedef/services_test.xml src/org/ofbiz/common/CommonServices.java
Adrian Crum wrote:
Adam Heath wrote:
bibr...@apache.org wrote:
Author: bibryam
Date: Mon Feb 15 15:14:32 2010
New Revision: 910235
URL: http://svn.apache.org/viewvc?rev=910235view=rev
Log:
Added a generic cascadeDelete service which can be used for data
deletion. It uses recursion to delete all the related data entries.
Modified:
ofbiz/trunk/framework/common/servicedef/services_test.xml
ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java
Modified: ofbiz/trunk/framework/common/servicedef/services_test.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services_test.xml?rev=910235r1=910234r2=910235view=diff
==
--- ofbiz/trunk/framework/common/servicedef/services_test.xml
(original)
+++ ofbiz/trunk/framework/common/servicedef/services_test.xml Mon
Feb 15 15:14:32 2010
@@ -210,4 +210,11 @@
descriptionTest Ping Service/description
attribute name=message type=String mode=INOUT
optional=true/
/service
+
+service name=cascadeDelete engine=java
+location=org.ofbiz.common.CommonServices
invoke=cascadeDelete
+descriptionRemove generic value and its related
values/description
+attribute name=entityName type=String mode=IN/
+attribute name=pkFields type=Map mode=IN/
+/service /services
Modified:
ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java?rev=910235r1=910234r2=910235view=diff
==
---
ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java
(original)
+++
ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonServices.java
Mon Feb 15 15:14:32 2010
@@ -45,6 +45,7 @@
import org.apache.log4j.Logger;
import org.ofbiz.base.util.Debug;
import org.ofbiz.base.util.UtilDateTime;
+import org.ofbiz.base.util.UtilGenerics;
import org.ofbiz.base.util.UtilValidate;
import static org.ofbiz.base.util.UtilGenerics.checkList;
@@ -54,6 +55,8 @@
import org.ofbiz.entity.GenericEntityException;
import org.ofbiz.entity.GenericValue;
import org.ofbiz.entity.model.ModelEntity;
+import org.ofbiz.entity.model.ModelRelation;
+import org.ofbiz.entity.model.ModelViewEntity;
import org.ofbiz.entity.transaction.TransactionUtil;
import org.ofbiz.service.DispatchContext;
import org.ofbiz.service.GenericServiceException;
@@ -534,5 +537,42 @@
return ServiceUtil.returnError(Invalid count returned
from database);
}
}
++public static MapString, Object
cascadeDelete(DispatchContext dctx, MapString, Object context) {
+Delegator delegator = dctx.getDelegator();
+String entityName = (String) context.get(entityName);
+MapString, Object pkFields =
UtilGenerics.checkMap(context.get(pkFields));
++try {
+GenericValue value =
delegator.findByPrimaryKey(entityName, pkFields);
+ModelEntity modelEntity =
delegator.getModelEntity(entityName);
+ListModelRelation relations =
modelEntity.getRelationsManyList();
++if (value == null || modelEntity
instanceof ModelViewEntity) { +return
ServiceUtil.returnSuccess();
+}
++for (ModelRelation relation : relations) {
+String combinedName = relation.getCombinedName();
+ListGenericValue relatedValues =
value.getRelated(combinedName);
+for (GenericValue relatedValue : relatedValues) {
+pkFields =
relatedValue.getPrimaryKey().getAllFields();
+entityName = relatedValue.getEntityName();
+MapString, Object newContext =
UtilMisc.toMap(entityName, entityName, pkFields, pkFields);
+MapString, Objectresult =
CommonServices.cascadeDelete(dctx, newContext);
+if (ServiceUtil.isError(result)) {
+return result;
+}
+}
+}
+
+Debug.logInfo(Removing value: + value , module);
+delegator.removeValue(value);
+} catch (GenericEntityException e) {
+return ServiceUtil.returnError(e.getMessage());
+}
+ +return ServiceUtil.returnSuccess();
+}
}
No, don't do this. This is very bad.
UserLogin-Party-Person-PartyContactMech-ContactMechType-ContactMech(all)-PartyContactMech(all)-Party(all)
You could end up removing everything from the database so easily.
Please remove this service, it's too dangerous.
I agree. This type of thing has been deliberately left out of the
project for that reason.
Thanks for your review guys, I appreciate that. I agree that it is
dangerous(as ant clean-all ;) and I was
Re: svn commit: r908602 - in /ofbiz/trunk/applications: content/script/org/ofbiz/content/layout/ product/config/ product/entitydef/ product/script/org/ofbiz/product/storage/ product/servicedef/ produc
Jacopo Cappellato wrote: Yes, simply copy this file http://ofbiz.apache.org/svn/config to your .subversion folder (in your user home folder) and the standard properties will be automatically associated to the new files (svn add) you will commit. Jacopo On Feb 10, 2010, at 8:24 PM, Jacques Le Roux wrote: Use config subversion file http://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Source+Repository+and+Access#OFBizSourceRepositoryandAccess-DeveloperAccess Jacques Thanks guys, I copied the file. Bilgin
Re: FacilityContent
Ean Schuessler wrote: Bilgin Ibryam wrote: I need to upload and assign documents to facilities. These includes maps of the facility, documents related to the facility etc. To achieve this, I'm planning to create FacilityContent and FacilityContentType entities which will be similar to existing entities used to assign content to other entities (PartyContent, OrderContent). Also I will provide a screen in facility application where the user can upload and see content related to the selected facility. Are there any objections or ideas to incorporate into this proposal? Seems like a worthwhile addition. I've always been a little bit bothered by the seeming redundancy of the _content_type fields but that is the established pattern. I can see exactly why you want the feature. I'd say go for it! Adam, Ean, In data mode resource book content entities are not described and I don't know what was the original idea behind _content_type entity. I suppose it is not the type of the content but the type of the relation. I decided to include it only to keep the consistency with the previous entities. I also don't need it and ContentPurpose seems to be enough. I also see the last addition - CustRequestContent didn't follow this pattern - there is not CustRequestContentType. I will add only FacilityContent entity. Thanks for sharing your ideas. Bilgin
