HTTP Caching in OFBiz
Hi All, I wanted to bring attention to the handling of HTTP caching in OFBiz. We can segregate three different areas(possibly more) which involve the cache. These are listed below: 1. Cache Web resources in CMS. 2. View Rendering. 3. Request Redirects. Furthermore, details are listed down below which includes the current implementation, possible improvements, and other related information. *Cache Web resources in CMS* In CMS Events, cache headers are set as no-cache. This prevents the browsers to cache various web resources which are rendered using CMS. In my opinion, here is a scope of improvement needed. Possibly using the mimeType or by any other method, the system must be configured to cache the resources. *View Rendering* In the current system, a view can be configured so that it can't be cached. Also, in the absence of this configuration, the system is not setting any cache headers. It's up to the browser to handle it. *Request Redirects* Currently, there is no way to configure the cache of the requests being redirected. I am not sure whether this is the desired behavior. On research, I have found that browsers do cache such requests as well. But need more inputs on this. Summarizing the above, we can conclude that the current system is lacking adequate support for handling the cache headers. In existing implementation, few areas can be configured only to set no-cache. There is no mechanism to set the cache on them. The best practices regarding setting the cache headers can be determined and implemented. Also, I would like to have your thoughts on the appropriate ways of caching the request redirects. Kind Regards, Chinmay Patidar
Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members
Congratulations Gil and Mathieu !!! Kind Regards, Chinmay Patidar On Tue, Dec 3, 2019 at 3:56 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become > members of the committee and we are glad to announce that they have > accepted the nomination. > > On behalf of the OFBiz PMC, welcome on board! >
Re: Welcome Pranay Pandey as a new PMC member
Many congratulations Pranay! Kind Regards, Chinmay Patidar Technical Consultant *HotWax Systems* *Enterprise open source experts* On Tue, Sep 24, 2019 at 9:07 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pranay Pandey to become a new member of the > committee and we are glad to announce that he has accepted the nomination. > > Welcome on board Pranay! > > Jacques (on behalf of the OFBiz PMC) > >
Re: Permission overrides auth parameter of service
Just missed a point. To regenerate the issue one has to update the 'Auto Save Cart' to 'Y' for the e-commerce product store record. Thanks, *Chinmay Patidar* | Sr. Enterprise Software Engineer HotWax Commerce by HotWax Systems Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore, M.P, India - 452010 Cell phone: +91-9713978795 On Sat, Dec 23, 2017 at 5:08 PM, Chinmay Patidar < chinmay.pati...@hotwaxsystems.com> wrote: > Hello All, > > Adding to the Suraj's example of CreateShoppingList, I would like to > elaborate more on the same. > > In current implementation, 'checkShoppingListSecurity' service is a > permission-service for 'createShoppingList' service. The system creates a > shopping list for an anonymous user on the ecommerce when adding an item to > the cart (try in incognito window so it doesn't pick party from the cache). > But with the current implementation, checkShoppingListSecurity returns an > error saying that "You must be logged in to complete the process". In > simple words, the 'createShoppingList' service gets called for an anonymous > user which eventually triggers 'checkShoppingListSecurity' service. > > The above explanation gives an example of a use case where one could > possibly have no userLogin but has a permission service implemented(for > covering use cases of userLogin). > > Also, it seems that one can't use a permission-service when no > userLogin would be present. > > Also, for now, to fix the issue we can call the > "checkShoppingListSecurity" service from the service > declaration/implementation to overcome the error of no userLogin. Although, > it creates confusion to me that the same service when called internally > works fine but when called as a permission service, returns an error. > > Please let me know if calling the security service internally would be the > proper approach. > > Thanks, > *Chinmay Patidar* | Sr. Enterprise Software Engineer > HotWax Commerce by HotWax Systems > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, > Indore, M.P, India - 452010 > Cell phone: +91-9713978795 > > On Mon, Dec 11, 2017 at 5:43 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Hi Suraj, >> >> I don't see how you could check permissions for an anonymous user. >> Maybe by giving anonymous users specific permissions in the context of >> ecommerce? >> >> But does it makes sense, I'm not sure. Then maybe as mentioned Rishi we >> should fix services like CreateShoppingList >> BTW did you cross any issues with anonymous users or is that only you >> thinking? >> >> Jacques >> >> >> >> Le 01/12/2017 à 09:41, Suraj Khurana a écrit : >> >>> Thanks everyone for your inputs. >>> >>> Yes, there are similar occurrences where permission service is defined >>> and >>> service is used in case of an anonymous user as well. >>> Example: *CreateShoppingList* and related services >>> >>> I was presuming we can execute any service as permission service >>> irrespective of taking *userLogin *into consideration. Please correct me >>> if >>> I am wrong or missing something. >>> >>> -- >>> Thanks and Regards, >>> *Suraj Khurana* | Sr. Enterprise Software Engineer >>> *HotWax Commerce* by *HotWax Systems* >>> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >>> >>> >>> On Wed, Nov 29, 2017 at 7:35 PM, Rishi Solanki <rishisolan...@gmail.com> >>> wrote: >>> >>> If an service implements and do checks for the permissions then it must >>>> have the auth set as true. If any occurrences found then it should be by >>>> mistake and service definition should be fix to match. >>>> >>>> So I think the behavior we have is correct, whenever we want to check >>>> the >>>> permission it should have the user in context. >>>> >>>> Suraj, Any scenario you have in mind where we only require permission >>>> service without user? >>>> >>>> >>>> Rishi Solanki >>>> Sr Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> www.hotwax.co >>>> >>>> On Wed, Nov 29, 2017 at 1:39 PM, Scott Gray < >>>> scott.g...@hotwaxsystems.com> >>>> wrote: >>>> >>>> auth="false" and a permission service are completely incompatible >>&g
Re: Permission overrides auth parameter of service
Hello All, Adding to the Suraj's example of CreateShoppingList, I would like to elaborate more on the same. In current implementation, 'checkShoppingListSecurity' service is a permission-service for 'createShoppingList' service. The system creates a shopping list for an anonymous user on the ecommerce when adding an item to the cart (try in incognito window so it doesn't pick party from the cache). But with the current implementation, checkShoppingListSecurity returns an error saying that "You must be logged in to complete the process". In simple words, the 'createShoppingList' service gets called for an anonymous user which eventually triggers 'checkShoppingListSecurity' service. The above explanation gives an example of a use case where one could possibly have no userLogin but has a permission service implemented(for covering use cases of userLogin). Also, it seems that one can't use a permission-service when no userLogin would be present. Also, for now, to fix the issue we can call the "checkShoppingListSecurity" service from the service declaration/implementation to overcome the error of no userLogin. Although, it creates confusion to me that the same service when called internally works fine but when called as a permission service, returns an error. Please let me know if calling the security service internally would be the proper approach. Thanks, *Chinmay Patidar* | Sr. Enterprise Software Engineer HotWax Commerce by HotWax Systems Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore, M.P, India - 452010 Cell phone: +91-9713978795 On Mon, Dec 11, 2017 at 5:43 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > I don't see how you could check permissions for an anonymous user. > Maybe by giving anonymous users specific permissions in the context of > ecommerce? > > But does it makes sense, I'm not sure. Then maybe as mentioned Rishi we > should fix services like CreateShoppingList > BTW did you cross any issues with anonymous users or is that only you > thinking? > > Jacques > > > > Le 01/12/2017 à 09:41, Suraj Khurana a écrit : > >> Thanks everyone for your inputs. >> >> Yes, there are similar occurrences where permission service is defined and >> service is used in case of an anonymous user as well. >> Example: *CreateShoppingList* and related services >> >> I was presuming we can execute any service as permission service >> irrespective of taking *userLogin *into consideration. Please correct me >> if >> I am wrong or missing something. >> >> -- >> Thanks and Regards, >> *Suraj Khurana* | Sr. Enterprise Software Engineer >> *HotWax Commerce* by *HotWax Systems* >> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >> >> >> On Wed, Nov 29, 2017 at 7:35 PM, Rishi Solanki <rishisolan...@gmail.com> >> wrote: >> >> If an service implements and do checks for the permissions then it must >>> have the auth set as true. If any occurrences found then it should be by >>> mistake and service definition should be fix to match. >>> >>> So I think the behavior we have is correct, whenever we want to check the >>> permission it should have the user in context. >>> >>> Suraj, Any scenario you have in mind where we only require permission >>> service without user? >>> >>> >>> Rishi Solanki >>> Sr Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> www.hotwax.co >>> >>> On Wed, Nov 29, 2017 at 1:39 PM, Scott Gray < >>> scott.g...@hotwaxsystems.com> >>> wrote: >>> >>> auth="false" and a permission service are completely incompatible >>>> scenarios. In what situation could you possibly have no userLogin and >>>> successfully run a permission service? >>>> >>>> What would you expect to happen instead of the current behavior? >>>> >>>> Regards >>>> Scott >>>> >>>> On 3 November 2017 at 17:35, Suraj Khurana <suraj.khurana@hotwaxsystems. >>>> com> >>>> wrote: >>>> >>>> Hello team, >>>>> >>>>> I noticed that in any service definition if auth is set to false and >>>>> permission service is also the service definition, it overrides the >>>>> >>>> auth >>> >>>> parameter to true by itself. >>>>> >>>>> For quick reference, it is written at *createPermission* method of >>>>> *ModelServiceReader* class. >>>>> Can someone please elaborate this behavior. IMO, this should not >>>>> >>>> happen. >>> >>>> -- >>>>> Thanks and Regards, >>>>> *Suraj Khurana* | Sr. Enterprise Software Engineer >>>>> *HotWax* *Commerce* by *HotWax Systems* >>>>> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >>>>> >>>>> >
[Proposal] Support for more decimals in price fields
Hello Devs, Ofbiz places a restriction on saving more than 3 decimal places in price related entity-fields. But there can be a number of use cases where a user needs to store more than 2 or 3 decimal places in the currency related entity-fields. I even saw some discussions related to this but didn't found any conclusions from them. Even one issue <https://issues.apache.org/jira/browse/OFBIZ-494> has been created but for limited fields. So, I would like to propose support for multiple or more than 2/3 decimals in price related fields. Following are some findings related to the currency fields which would be helpful to examine the requirement: Ofbiz uses two field types to store the currency related entity-fields. These two types are 'currency-amount' and 'currency-precise' with their respective types being NUMBER(18,2) and NUMBER(18,3). Upon initial research, one can conclude that changing the field definitions of 'currency-amount' and 'currency-precise' would achieve the requirement. But doing so will raise following questions which need to be answered. Feel free to add in them. - What would be the precise value of precision(number of decimals)? - Will these changes can make the system inconsistent? In addition, I would like to know the significance of having two separate field types, i.e. 'currency-amount' and 'currency-precise'. Also, I have marked one improvement which will be needed to realize the solution. There are multiple occurrences where hardcoded scaling of 2 has been set to either display or store a currency field. This needs to be changed and must be set dynamically. I'd like to hear your thoughts. Thanks, *Chinmay Patidar*
[Proposal] Create separate Permission Service for security checks
Hello Devs, Recently, I came across the CRUD operation services for ShoppingList and ShoppingListItem entities. The security related checks are present inline in these services which violate the best practice of keeping security implementation different from the business logic. I would like to propose creating security services for such operations and to call them as a permission-service from the CRUD operation services definition. This will also enable users to easily modify the security checks for their custom implementation. ill then, I would like to know your thoughts on this idea. Thanks, *Chinmay Patidar*
Re: Welcome Akash Jain as a New Committer!
Many congratulations Akash Jain !!! Kind Regards - Chinmay Patidar On Wed, Aug 9, 2017 at 2:28 PM, Sharan Foga <sha...@apache.org> wrote: > The OFBiz PMC has invited Akash Jain to become a new committer and are > happy to announce that he has accepted. > > Some of the key factors considered for inviting him were as follows: > > - He has been involved with the OFBiz project for quite a while which > shows his dedication and commitment > - He has a lot of good knowledge (both functional and technical) that he > is happy to share which shows he is a good team player > - He is very active, positive and respectful to others in the community > - He has contributed patches and shows a willingness to learn which is > really important as the project continues to go through changes > > Please join me in welcoming and congratulating Akash. > > Thanks > Sharan >
Re: Welcome Rishi Solanki as a New Committer!
Many congratulations Rishi Solanki !!! Kind Regards - Chinmay Patidar On Wed, Aug 9, 2017 at 2:26 PM, Sharan Foga <sha...@apache.org> wrote: > The OFBiz PMC has invited Rishi Solanki to become a new committer and are > happy to announce that he has accepted. > > Some of the key factors considered for inviting him were as follows: > > - He has been involved with the OFBiz project for quite a while which > shows dedication and commitment > - He has a lot of good knowledge that he is happy to share which shows he > is a good team player > - His work is consistent, has good code quality and he has provided a > range of patches > - He is friendly, respectful and keen to help out others in the community > > Please join me in welcoming and congratulating Rishi! > > Thanks > Sharan >
Re: New ASF Members from OFBiz Community
Congratulations to everyone !!! :) Thanks & Regards, Chinmay Patidar Senior Enterprise Software Engineer Hotwax Systems www.hotwaxsystems.com On Wed, Apr 5, 2017 at 10:52 AM, Gaurav Saini <gauravsain...@gmail.com> wrote: > Congratulations to everyone :) > > On Wed, Apr 5, 2017 at 10:48 AM, Yash Sharma < > yash.sha...@hotwaxsystems.com> > wrote: > > > Many congratulations to Michael Brohl, Taher Alkhateeb, Anil Patel, > Ashish > > Vijaywargiya and Bilgin ! > > > > On Wed, Apr 5, 2017 at 10:44 AM Deepak Dixit <deepak.dixit@hotwaxsystems. > > com> > > wrote: > > > > > Many Many Congrats Anil, Ashish and Bilgin! > > > > > > Thanks & Regards > > > -- > > > Deepak Dixit > > > www.hotwaxsystems.com > > > > > > On Wed, Apr 5, 2017 at 12:32 AM, Sharan Foga <sha...@apache.org> > wrote: > > > > > > > Hi Everyone > > > > > > > > Wow – we have even more good news! Another three people from our > > > community > > > > have been invited to become members of the Apache Software > Foundation. > > > They > > > > are Anil Patel, Ashish Vijaywargiya and Bilgin Ibryam > > > > > > > > Many congratulations Anil, Ashish and Bilgin !!! > > > > > > > > Thanks > > > > Sharan > > > > > > > > On 2017-04-03 11:06 (+0200), "Sharan Foga"<sha...@apache.org> wrote: > > > > > Hi Everyone > > > > > > > > > > Please join me in congratulating Michael Brohl and Taher Alkhateeb > as > > > > being invited to become members of the Apache Software Foundation. > > > > > > > > > > Congratulations Michael and Taher! > > > > > > > > > > Thanks > > > > > Sharan > > > > > > > > > > > > > > > > > > > -- > > Thanks & Regards, > > > > *Pradhan Yash Sharma* > > *HotWax Systems* | www.hotwaxsystems.com > > > > > > -- > Regards, > *Gaurav Saini* >
[jira] [Updated] (OFBIZ-7873) Improvements in BillingAccountTermAttr entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7873: --- Attachment: OFBIZ-7873.patch Providing the patch for the improvement needed for BillingAccountTermAttr entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in BillingAccountTermAttr entity definition and services > - > > Key: OFBIZ-7873 > URL: https://issues.apache.org/jira/browse/OFBIZ-7873 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7873.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7869: --- Attachment: OFBIZ-7869.patch > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar > Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7869.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7869: --- Attachment: (was: OFBIZ-7869.patch) > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar > Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380750#comment-15380750 ] Chinmay Patidar edited comment on OFBIZ-7869 at 7/20/16 5:02 AM: - Providing the patch for the improvement needed for AgreementTermAttribute entity. Also verified the changes from webtools. Thanks [~arunpati] for the detailed explanation. was (Author: chinmay.patidar): Providing the patch for the improvement needed for AgreementTermAttribute entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar > Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7869.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7869: --- Attachment: OFBIZ-7869.patch Providing the patch for the improvement needed for AgreementTermAttribute entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar > Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7869.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7873) Improvements in BillingAccountTermAttr entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7873: -- Assignee: Chinmay Patidar > Improvements in BillingAccountTermAttr entity definition and services > - > > Key: OFBIZ-7873 > URL: https://issues.apache.org/jira/browse/OFBIZ-7873 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7869) Improvements in AgreementTermAttribute entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7869: -- Assignee: Chinmay Patidar > Improvements in AgreementTermAttribute entity definition and services > - > > Key: OFBIZ-7869 > URL: https://issues.apache.org/jira/browse/OFBIZ-7869 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Arun Patidar > Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7847) Improvements in AcctgTransEntryType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7847: --- Attachment: OFBIZ-7847.patch Providing the patch for the improvement needed for AcctgTransEntryType entity. Also verified the changes from webtools. Thanks [~rishisolankii] for the detailed explanation. > Improvements in AcctgTransEntryType entity definition and services > -- > > Key: OFBIZ-7847 > URL: https://issues.apache.org/jira/browse/OFBIZ-7847 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7847.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/trhu date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7847) Improvements in AcctgTransEntryType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7847: -- Assignee: Chinmay Patidar > Improvements in AcctgTransEntryType entity definition and services > -- > > Key: OFBIZ-7847 > URL: https://issues.apache.org/jira/browse/OFBIZ-7847 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/trhu date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7809) Enforce noninstantiability to UtilXml class
[ https://issues.apache.org/jira/browse/OFBIZ-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7809: --- Attachment: OFBIZ-7809.patch Provided patch for the issue. Thanks [~rishisolankii] for providing the detailed explanation. > Enforce noninstantiability to UtilXml class > --- > > Key: OFBIZ-7809 > URL: https://issues.apache.org/jira/browse/OFBIZ-7809 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7809.patch > > > - Make class as final. > - Add a private constructor. > No variables need to change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802.patch
Provided patch for the issue. Thanks [~rishisolankii] for providing detailed
explanation.
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Comment: was deleted
(was: Providing the patch for the issue. Thanks [~rishisolankii] for the
detailed explanation.)
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: (was: OFBIZ-7802)
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802
Providing the patch for the issue. Thanks [~rishisolankii] for the detailed
explanation.
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7809) Enforce noninstantiability to UtilXml class
[ https://issues.apache.org/jira/browse/OFBIZ-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7809: -- Assignee: Chinmay Patidar > Enforce noninstantiability to UtilXml class > --- > > Key: OFBIZ-7809 > URL: https://issues.apache.org/jira/browse/OFBIZ-7809 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables need to change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7802:
--
Assignee: Chinmay Patidar
> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7687) Enforce noninstantiability to KeywordSearchUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7687:
--
Assignee: Chinmay Patidar
> Enforce noninstantiability to KeywordSearchUtil class
> -
>
> Key: OFBIZ-7687
> URL: https://issues.apache.org/jira/browse/OFBIZ-7687
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static Set thesaurusRelsToInclude = new HashSet();
> public static Set thesaurusRelsForReplace = new HashSet();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7688) Enforce noninstantiability to StatusWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7688: -- Assignee: Chinmay Patidar > Enforce noninstantiability to StatusWorker class > > > Key: OFBIZ-7688 > URL: https://issues.apache.org/jira/browse/OFBIZ-7688 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7455) ImportProductHelper class
[
https://issues.apache.org/jira/browse/OFBIZ-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7455:
---
Attachment: OFBIZ-7455.patch
Attached the patch for the issue. Thanks [~rishisolankii] for the detailed
description.
> ImportProductHelper class
> -
>
> Key: OFBIZ-7455
> URL: https://issues.apache.org/jira/browse/OFBIZ-7455
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7455.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as public static final.
> {code}
> static String module = ImportProductHelper.class.getName();
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7447) ImageManagementHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7447: --- Attachment: OFBIZ-7447.patch Attached the patch for the issue. Thanks [~rishisolankii] for the detailed description. > ImageManagementHelper class > --- > > Key: OFBIZ-7447 > URL: https://issues.apache.org/jira/browse/OFBIZ-7447 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7447.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7447) ImageManagementHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7447: -- Assignee: Chinmay Patidar > ImageManagementHelper class > --- > > Key: OFBIZ-7447 > URL: https://issues.apache.org/jira/browse/OFBIZ-7447 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7455) ImportProductHelper class
[
https://issues.apache.org/jira/browse/OFBIZ-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7455:
--
Assignee: Chinmay Patidar
> ImportProductHelper class
> -
>
> Key: OFBIZ-7455
> URL: https://issues.apache.org/jira/browse/OFBIZ-7455
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as public static final.
> {code}
> static String module = ImportProductHelper.class.getName();
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7431) SeoUrlUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7431: --- Attachment: OFBIZ-7431.patch Attached the patch for the issue. > SeoUrlUtil class > > > Key: OFBIZ-7431 > URL: https://issues.apache.org/jira/browse/OFBIZ-7431 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7431.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7419) PartyRelationshipHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7419: --- Attachment: OFBIZ-7419.patch Attached the patch for the issue. > PartyRelationshipHelper class > - > > Key: OFBIZ-7419 > URL: https://issues.apache.org/jira/browse/OFBIZ-7419 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7419.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7431) SeoUrlUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7431: -- Assignee: Chinmay Patidar > SeoUrlUtil class > > > Key: OFBIZ-7431 > URL: https://issues.apache.org/jira/browse/OFBIZ-7431 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7419) PartyRelationshipHelper class
[ https://issues.apache.org/jira/browse/OFBIZ-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7419: -- Assignee: Chinmay Patidar > PartyRelationshipHelper class > - > > Key: OFBIZ-7419 > URL: https://issues.apache.org/jira/browse/OFBIZ-7419 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7398) SolrUtil Class
[
https://issues.apache.org/jira/browse/OFBIZ-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7398:
---
Attachment: OFBIZ-7398.patch
Attached is the patch for the issue. Thanks [~arunpati] for detailed
description which made the effort so smooth.
> SolrUtil Class
> --
>
> Key: OFBIZ-7398
> URL: https://issues.apache.org/jira/browse/OFBIZ-7398
> Project: OFBiz
> Issue Type: Sub-task
> Components: specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7398.patch
>
>
> - Add a private constructor.
> - Make the following private static variable as final.
> {code}
> private static String[] solrProdAttribute = { "productId",
> "internalName", "manu", "size", "smallImage", "mediumImage", "largeImage",
> "listPrice", "defaultPrice", "inStock", "isVirtual" };
> {code}
> - Make the following public static variables as private
> {code}
> public static final String solrConfigName = "solrconfig.properties";
> public static final String solrUrl = makeSolrWebappUrl();
> {code}
> - Make the following protected static variables as private
> {code}
> protected static final String socketTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.socket.timeout");
>
> protected static final String connectionTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.connection.timeout");
>
> protected static final String clientUsername =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.username");
>
> protected static final String clientPassword =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.password");
> protected static final Integer socketTimeout = getSocketTimeout();
>
> protected static final Integer connectionTimeout = getConnectionTimeout();
>
> protected static final String trustSelfSignedCertString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.trust.selfsigned.cert", "false");
>
> protected static final boolean trustSelfSignedCert =
> getTrustSelfSignedCert();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7398) SolrUtil Class
[
https://issues.apache.org/jira/browse/OFBIZ-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar reassigned OFBIZ-7398:
--
Assignee: Chinmay Patidar
> SolrUtil Class
> --
>
> Key: OFBIZ-7398
> URL: https://issues.apache.org/jira/browse/OFBIZ-7398
> Project: OFBiz
> Issue Type: Sub-task
> Components: specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Add a private constructor.
> - Make the following private static variable as final.
> {code}
> private static String[] solrProdAttribute = { "productId",
> "internalName", "manu", "size", "smallImage", "mediumImage", "largeImage",
> "listPrice", "defaultPrice", "inStock", "isVirtual" };
> {code}
> - Make the following public static variables as private
> {code}
> public static final String solrConfigName = "solrconfig.properties";
> public static final String solrUrl = makeSolrWebappUrl();
> {code}
> - Make the following protected static variables as private
> {code}
> protected static final String socketTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.socket.timeout");
>
> protected static final String connectionTimeoutString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.connection.timeout");
>
> protected static final String clientUsername =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.username");
>
> protected static final String clientPassword =
> UtilProperties.getPropertyValue(solrConfigName, "solr.client.password");
> protected static final Integer socketTimeout = getSocketTimeout();
>
> protected static final Integer connectionTimeout = getConnectionTimeout();
>
> protected static final String trustSelfSignedCertString =
> UtilProperties.getPropertyValue(solrConfigName,
> "solr.client.trust.selfsigned.cert", "false");
>
> protected static final boolean trustSelfSignedCert =
> getTrustSelfSignedCert();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7380) SagePayUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar updated OFBIZ-7380: --- Attachment: OFBIZ-7380.patch Providing the patch for the issue. Thanks, Arun and Rishi for the discussion. > SagePayUtil class > - > > Key: OFBIZ-7380 > URL: https://issues.apache.org/jira/browse/OFBIZ-7380 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > Attachments: OFBIZ-7380.patch > > > - Make class as final. > - Add a private constructor. > No variables exists in the class so nothing to change here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7380) SagePayUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-7380: -- Assignee: Chinmay Patidar > SagePayUtil class > - > > Key: OFBIZ-7380 > URL: https://issues.apache.org/jira/browse/OFBIZ-7380 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Chinmay Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables exists in the class so nothing to change here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7272) Enforce noninstantiability with a private constructor
[
https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinmay Patidar updated OFBIZ-7272:
---
Attachment: OFBIZ-7272.patch
Here is the patch for the issue. Thanks Rishi Solanki and Arun Patidar for
guidance and the discussion. Following are the classes on which added private
constructor:
{code}
applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceWorker.java
applications/accounting/src/org/ofbiz/accounting/payment/PaymentWorker.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java
applications/accounting/src/org/ofbiz/accounting/util/UtilAccounting.java
applications/content/src/org/ofbiz/content/ContentManagementWorker.java
applications/content/src/org/ofbiz/content/data/DataResourceWorker.java
applications/content/src/org/ofbiz/content/layout/LayoutWorker.java
applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java
applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMHelper.java
applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ProductionRunHelper.java
applications/marketing/src/org/ofbiz/marketing/report/ReportHelper.java
applications/order/src/org/ofbiz/order/order/OrderChangeHelper.java
applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java
applications/order/src/org/ofbiz/order/task/TaskWorker.java
applications/party/src/org/ofbiz/party/party/PartyRelationshipHelper.java
applications/party/src/org/ofbiz/party/party/PartyTypeHelper.java
applications/product/src/org/ofbiz/product/category/SeoConfigUtil.java
applications/product/src/org/ofbiz/product/category/SeoUrlUtil.java
applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java
applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementHelper.java
applications/product/src/org/ofbiz/product/inventory/InventoryWorker.java
applications/product/src/org/ofbiz/product/product/ProductUtilServices.java
applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java
applications/product/src/org/ofbiz/product/store/ProductStoreWorker.java
applications/product/src/org/ofbiz/shipment/shipment/ShipmentWorker.java
applications/workeffort/src/org/ofbiz/workeffort/workeffort/ICalWorker.java
applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortWorker.java
framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
framework/base/src/org/ofbiz/base/util/BshUtil.java
framework/base/src/org/ofbiz/base/util/FileUtil.java
framework/base/src/org/ofbiz/base/util/KeyStoreUtil.java
framework/base/src/org/ofbiz/base/util/SSLUtil.java
framework/base/src/org/ofbiz/base/util/UtilCodec.java
framework/base/src/org/ofbiz/base/util/UtilDateTime.java
framework/base/src/org/ofbiz/base/util/UtilFormatOut.java
framework/base/src/org/ofbiz/base/util/UtilGenerics.java
framework/base/src/org/ofbiz/base/util/UtilHttp.java
framework/base/src/org/ofbiz/base/util/UtilIO.java
framework/base/src/org/ofbiz/base/util/UtilJavaParse.java
framework/base/src/org/ofbiz/base/util/UtilNumber.java
framework/base/src/org/ofbiz/base/util/UtilPlist.java
framework/base/src/org/ofbiz/base/util/UtilProperties.java
framework/base/src/org/ofbiz/base/util/UtilURL.java
framework/base/src/org/ofbiz/base/util/UtilValidate.java
framework/base/src/org/ofbiz/base/util/UtilXml.java
framework/base/src/org/ofbiz/base/util/string/UelUtil.java
framework/base/src/org/ofbiz/base/util/template/FreeMarkerWorker.java
framework/common/src/org/ofbiz/common/CommonWorkers.java
framework/common/src/org/ofbiz/common/KeywordSearchUtil.java
framework/common/src/org/ofbiz/common/UrlServletHelper.java
framework/common/src/org/ofbiz/common/authentication/AuthHelper.java
framework/common/src/org/ofbiz/common/geo/GeoWorker.java
framework/common/src/org/ofbiz/common/period/PeriodWorker.java
framework/common/src/org/ofbiz/common/preferences/PreferenceWorker.java
framework/common/src/org/ofbiz/common/status/StatusWorker.java
framework/entity/src/org/ofbiz/entity/finder/EntityFinderUtil.java
framework/entity/src/org/ofbiz/entity/jdbc/DatabaseUtil.java
framework/entity/src/org/ofbiz/entity/jdbc/SqlJdbcUtil.java
framework/entity/src/org/ofbiz/entity/model/ModelUtil.java
framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
framework/entity/src/org/ofbiz/entity/util/EntityTypeUtil.java
framework/entity/src/org/ofbiz/entity/util/EntityUtil.java
framework/entity/src/org/ofbiz/entity/util/EntityUtilProperties.java
framework/entityext/src/org/ofbiz/entityext/EntityGroupUtil.java
framework/entityext/src/org/ofbiz/entityext/eca/EntityEcaUtil.java
framework/service/src/org/ofbiz/service/ServiceUtil.java
framework/service/src/org/ofbiz/service/calendar/RecurrenceUtil.java
framework/service/src/org/ofbiz/service/calendar/TemporalExpressionWorker.java
