Re: [PROPOSAL] freeze trunk for new features in favor of a release 24.x branch preparation / future roadmap

2024-04-21 Thread Deepak Dixit
Sounds good to me!!

I wanted to propose a change in process regarding the stabilization of code
releases.

Instead of restricting commits directly to the trunk, I suggest creating a
branch named "24.04" or "24.05" (depending on the release version)
specifically for stabilization purposes. This branch will serve as a
dedicated space for stabilizing the code without impacting ongoing work in
the trunk.

By implementing this approach, we can focus on stabilizing the release
branch independently while allowing continuous development to proceed on
the trunk. The only additional overhead will be the need to backport bug
fixes from the release branch to the trunk or vice versa.

I believe this strategy will help us maintain a more organized and
efficient development workflow, ensuring that our releases are stable and
reliable without disrupting ongoing development efforts.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, Apr 21, 2024 at 7:20 PM Michael Brohl 
wrote:

> Hi everyone,
>
> we agreed to work towards a stabilizing trunk to be able to create a
> 24.x release branch, which means we have to thoroughly decide which
> changes should go into trunk. There are currently lots of changes going
> into trunk with PR's created and rapidly be merged into the codebase.
> This causes potential for errors being introduced in trunk, potentially
> leading to delay the creation of the next release branch even more.
>
> In my opinion, this is contraproductive to the goal of creating a stable
> release branch 24.x in due time.
>
> I propose to make a decision to have a code freeze for new features and
> improvements and focus on bug fixes until we have created a 24.x branch.
>
> I also propose that we start organizing a roadmap to give the community
> some guidelines where to focus and which main features can be expected
> in the next release branches. It might also give developers some goals
> to provide the features according to planned releases and maybe work
> together to reach those project goals.
>
> For example, there are some initiatives for Tomcat migration,
> introducing REST functionality in the framework and others which we can
> assign to future release branches. Maybe we can have a plan for a 25.x
> release branch which introduces those features.
>
> I do not intend to make this an unflexible roadmap, means there can
> always be more planned/unplanned features be added to the roadmap and be
> discussed. We should have some deadlines for new features though, just
> to be able to create the next feature branch in the planned time periods.
>
> What do you think?
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
>


CVE-2023-51467: Apache OFBiz: Pre-authentication Remote Code Execution (RCE) vulnerability

2023-12-26 Thread Deepak Dixit
Severity: critical

Affected versions:

- Apache OFBiz before 18.12.11

Description:

The vulnerability allows attackers to bypass authentication to achieve a simple 
Server-Side Request Forgery (SSRF)

This issue is being tracked as OFBIZ-12873 

Credit:

Hasib Vhora, Senior Threat Researcher, SonicWall  (finder)
Gao Tian (finder)
L0ne1y (finder)

References:

https://ofbiz.apache.org/download.html
https://ofbiz.apache.org/security.html
https://ofbiz.apache.org/release-notes-18.12.11.html
https://issues.apache.org/jira/browse/OFBIZ-12873
https://ofbiz.apache.org/
https://www.cve.org/CVERecord?id=CVE-2023-51467
https://issues.apache.org/jira/browse/OFBIZ-12873



Re: [VOTE] Release Apache OFBiz 18.12.11

2023-12-18 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Dec 18, 2023 at 4:43 PM Michael Brohl 
wrote:

> +1
>
> ../ofbiz-tools/verify-ofbiz-release.sh  -a apache-ofbiz-18.12.11
>
> Everything is OK
>
> OpenJDK Runtime Environment (Temurin)(build 1.8.0_352-b08)
>
> Mac OS Sonoma 14.12
>
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 16.12.23 um 11:02 schrieb Jacopo Cappellato:
> > This is the vote thread to publish "Apache OFBiz 18.12.11", eleventh
> > release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.11.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.11.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.11.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.11
> > [ -1] do not release
> >
> > This vote is open for at least 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
>


Re: Issue with OFBiz Job Scheduler and Daylight Saving Time

2023-11-05 Thread Deepak Dixit
Thanks Scott for the review and input.

I agree we can use UTC, but in this case we need to reschedule the job
timings according to the user timezone.
eg.
- Reporting jobs that runs on specific time
- Some business process, like order routing job etc. that should run on
specific time,

Please correct me if I am missing something?


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Fri, Nov 3, 2023 at 2:38 PM Scott Gray 
wrote:

> Hi Deepak,
>
> IMO the best general solution is to not run OFBiz or the database
> configured with a timezone that observes DST, instead use UTC or similar.
> This achieves the same result but without needing any extra fields.
>
> I'm not objecting to your solution, just sharing this tip out loud since
> the JobSandbox is only one of many places that can have trouble with
> ambiguous DST date/times and it is very difficult to change timezone at the
> db level once it's filled with production data.
>
> Regards
> Scott
>
> On Mon, 30 Oct 2023 at 13:05, Deepak Dixit  wrote:
>
> > The issue occurs when DST changes, and OFBiz fails to schedule recurring
> > jobs properly.
> > This is due to a condition in the PersistedServiceJob.createRecurrence
> > method where it compares the next scheduled time (next) with the start
> time
> > (startTime) for the job.
> >
> >
> > *Proposed Solution:*To address the issue, adding a new field named
> > JobSandbox.runTimeEpoch. This field would store the UTC epoch
> milliseconds
> > of the runtime date.
> > When scheduling or rescheduling recurring jobs, the system would use the
> > UTC epoch stored in JobSandbox.runTimeEpoch for recurring job comparison.
> >
> > This solution ensures that the system uses a consistent, UTC-based time
> for
> > scheduling and rescheduling recurring jobs, even when DST changes affect
> > the local time.
> >
> > To implement this solution, we need to do following things:
> >
> > - Modify the PersistedServiceJob.createRecurrence method to calculate and
> > store the UTC epoch milliseconds in the JobSandbox.runTimeEpoch field.
> > - Update the code responsible for polling and rescheduling jobs to use
> the
> > JobSandbox.runTimeEpoch field when it is set. If the field is not set, It
> > would fall back to getting the runtime date to filter the jobs.
> >
> > By using this approach, the system should be able to handle recurring job
> > scheduling more reliably, especially when DST changes are involved, as it
> > ensures that all time comparisons are made in a consistent UTC format.
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Tue, Oct 17, 2023 at 11:00 AM Deepak Dixit  wrote:
> >
> > > Hi Dev,
> > >
> > > I wanted to draw your attention to an issue we've encountered with the
> > > OFBiz job scheduler, particularly when it comes to handling Daylight
> > Saving
> > > Time (DST) changes.
> > >
> > > It appears that the job scheduler fails to create new recurring jobs
> when
> > > DST ends, especially when the tempExprTypeId is set to FREQUENCY (e.g.,
> > 15
> > > minutes, 30 minutes).
> > >
> > > Upon further investigation, we've identified that the following
> condition
> > > in PersistedServiceJob.createRecurrence might be the root of the issue:
> > >
> > > java
> > >
> > > if (next > startTime) {
> > > // ...
> > > // ...
> > > }
> > >
> > > I'm curious to know if anyone else has encountered a similar problem or
> > if
> > > you have any insights to share regarding this issue.
> > >
> > > Thanks & Regards
> > >
> > > --
> > > Deepak Dixit
> > > ofbiz.apache.org
> > >
> >
>


Re: Issue with OFBiz Job Scheduler and Daylight Saving Time

2023-10-30 Thread Deepak Dixit
Here is the PR for reference
https://github.com/apache/ofbiz-framework/pull/674/files

Please review and share your feedback!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Oct 30, 2023 at 6:53 PM Michael Brohl 
wrote:

> +1
>
> Thanks Deepak,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 30.10.23 um 14:03 schrieb Deepak Dixit:
> > The issue occurs when DST changes, and OFBiz fails to schedule recurring
> > jobs properly.
> > This is due to a condition in the PersistedServiceJob.createRecurrence
> > method where it compares the next scheduled time (next) with the start
> time
> > (startTime) for the job.
> >
> >
> > *Proposed Solution:*To address the issue, adding a new field named
> > JobSandbox.runTimeEpoch. This field would store the UTC epoch
> milliseconds
> > of the runtime date.
> > When scheduling or rescheduling recurring jobs, the system would use the
> > UTC epoch stored in JobSandbox.runTimeEpoch for recurring job comparison.
> >
> > This solution ensures that the system uses a consistent, UTC-based time
> for
> > scheduling and rescheduling recurring jobs, even when DST changes affect
> > the local time.
> >
> > To implement this solution, we need to do following things:
> >
> > - Modify the PersistedServiceJob.createRecurrence method to calculate and
> > store the UTC epoch milliseconds in the JobSandbox.runTimeEpoch field.
> > - Update the code responsible for polling and rescheduling jobs to use
> the
> > JobSandbox.runTimeEpoch field when it is set. If the field is not set, It
> > would fall back to getting the runtime date to filter the jobs.
> >
> > By using this approach, the system should be able to handle recurring job
> > scheduling more reliably, especially when DST changes are involved, as it
> > ensures that all time comparisons are made in a consistent UTC format.
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Tue, Oct 17, 2023 at 11:00 AM Deepak Dixit  wrote:
> >
> >> Hi Dev,
> >>
> >> I wanted to draw your attention to an issue we've encountered with the
> >> OFBiz job scheduler, particularly when it comes to handling Daylight
> Saving
> >> Time (DST) changes.
> >>
> >> It appears that the job scheduler fails to create new recurring jobs
> when
> >> DST ends, especially when the tempExprTypeId is set to FREQUENCY (e.g.,
> 15
> >> minutes, 30 minutes).
> >>
> >> Upon further investigation, we've identified that the following
> condition
> >> in PersistedServiceJob.createRecurrence might be the root of the issue:
> >>
> >> java
> >>
> >> if (next > startTime) {
> >>  // ...
> >>  // ...
> >> }
> >>
> >> I'm curious to know if anyone else has encountered a similar problem or
> if
> >> you have any insights to share regarding this issue.
> >>
> >> Thanks & Regards
> >>
> >> --
> >> Deepak Dixit
> >> ofbiz.apache.org
> >>
>


Re: Issue with OFBiz Job Scheduler and Daylight Saving Time

2023-10-30 Thread Deepak Dixit
Here is the task for reference
https://issues.apache.org/jira/browse/OFBIZ-12864

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Oct 30, 2023 at 6:33 PM Deepak Dixit  wrote:

> The issue occurs when DST changes, and OFBiz fails to schedule recurring
> jobs properly.
> This is due to a condition in the PersistedServiceJob.createRecurrence
> method where it compares the next scheduled time (next) with the start time
> (startTime) for the job.
>
>
> *Proposed Solution:*To address the issue, adding a new field named
> JobSandbox.runTimeEpoch. This field would store the UTC epoch milliseconds
> of the runtime date.
> When scheduling or rescheduling recurring jobs, the system would use the
> UTC epoch stored in JobSandbox.runTimeEpoch for recurring job comparison.
>
> This solution ensures that the system uses a consistent, UTC-based time
> for scheduling and rescheduling recurring jobs, even when DST changes
> affect the local time.
>
> To implement this solution, we need to do following things:
>
> - Modify the PersistedServiceJob.createRecurrence method to calculate and
> store the UTC epoch milliseconds in the JobSandbox.runTimeEpoch field.
> - Update the code responsible for polling and rescheduling jobs to use the
> JobSandbox.runTimeEpoch field when it is set. If the field is not set, It
> would fall back to getting the runtime date to filter the jobs.
>
> By using this approach, the system should be able to handle recurring job
> scheduling more reliably, especially when DST changes are involved, as it
> ensures that all time comparisons are made in a consistent UTC format.
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Tue, Oct 17, 2023 at 11:00 AM Deepak Dixit  wrote:
>
>> Hi Dev,
>>
>> I wanted to draw your attention to an issue we've encountered with the
>> OFBiz job scheduler, particularly when it comes to handling Daylight Saving
>> Time (DST) changes.
>>
>> It appears that the job scheduler fails to create new recurring jobs when
>> DST ends, especially when the tempExprTypeId is set to FREQUENCY (e.g., 15
>> minutes, 30 minutes).
>>
>> Upon further investigation, we've identified that the following condition
>> in PersistedServiceJob.createRecurrence might be the root of the issue:
>>
>> java
>>
>> if (next > startTime) {
>> // ...
>> // ...
>> }
>>
>> I'm curious to know if anyone else has encountered a similar problem or
>> if you have any insights to share regarding this issue.
>>
>> Thanks & Regards
>>
>> --
>> Deepak Dixit
>> ofbiz.apache.org
>>
>


Re: Issue with OFBiz Job Scheduler and Daylight Saving Time

2023-10-30 Thread Deepak Dixit
The issue occurs when DST changes, and OFBiz fails to schedule recurring
jobs properly.
This is due to a condition in the PersistedServiceJob.createRecurrence
method where it compares the next scheduled time (next) with the start time
(startTime) for the job.


*Proposed Solution:*To address the issue, adding a new field named
JobSandbox.runTimeEpoch. This field would store the UTC epoch milliseconds
of the runtime date.
When scheduling or rescheduling recurring jobs, the system would use the
UTC epoch stored in JobSandbox.runTimeEpoch for recurring job comparison.

This solution ensures that the system uses a consistent, UTC-based time for
scheduling and rescheduling recurring jobs, even when DST changes affect
the local time.

To implement this solution, we need to do following things:

- Modify the PersistedServiceJob.createRecurrence method to calculate and
store the UTC epoch milliseconds in the JobSandbox.runTimeEpoch field.
- Update the code responsible for polling and rescheduling jobs to use the
JobSandbox.runTimeEpoch field when it is set. If the field is not set, It
would fall back to getting the runtime date to filter the jobs.

By using this approach, the system should be able to handle recurring job
scheduling more reliably, especially when DST changes are involved, as it
ensures that all time comparisons are made in a consistent UTC format.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Oct 17, 2023 at 11:00 AM Deepak Dixit  wrote:

> Hi Dev,
>
> I wanted to draw your attention to an issue we've encountered with the
> OFBiz job scheduler, particularly when it comes to handling Daylight Saving
> Time (DST) changes.
>
> It appears that the job scheduler fails to create new recurring jobs when
> DST ends, especially when the tempExprTypeId is set to FREQUENCY (e.g., 15
> minutes, 30 minutes).
>
> Upon further investigation, we've identified that the following condition
> in PersistedServiceJob.createRecurrence might be the root of the issue:
>
> java
>
> if (next > startTime) {
> // ...
> // ...
> }
>
> I'm curious to know if anyone else has encountered a similar problem or if
> you have any insights to share regarding this issue.
>
> Thanks & Regards
>
> --
> Deepak Dixit
> ofbiz.apache.org
>


Re: [VOTE] Apache OFBiz 18.12.09

2023-10-30 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Oct 30, 2023 at 3:45 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Jacopo,
>
> +1, all works for me
>
> Jacques
>
> Le 29/10/2023 à 13:16, Jacopo Cappellato a écrit :
> > This is the vote thread to publish "Apache OFBiz 18.12.09", ninth
> > release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.09.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.09.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.09.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.09
> > [ -1] do not release
> >
> > This vote is open for at least 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
>


Re: HTTP/2 disabled on demo-trunk

2023-10-29 Thread Deepak Dixit
Thanks for the update Daniel!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Fri, Oct 27, 2023 at 12:20 PM Daniel Watford  wrote:

> Hi Deepak,
>
> Not yet, but I've now assigned the task to myself so that it appears more
> readily in my todo list.
>
>
> On Fri, 27 Oct 2023 at 06:38, Deepak Dixit  wrote:
>
> > Hi Daniel!!
> >
> > Did you get a chance to look at this?
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Tue, Aug 22, 2023 at 2:29 PM Deepak Dixit  wrote:
> >
> > > Here is the task for the same
> > > https://issues.apache.org/jira/browse/OFBIZ-12846
> > >
> > > HTTP/2 should be enabled by default. Need to check if we are disabling
> > > this while container build.
> > >
> > >
> > > Thanks & Regards
> > > --
> > > Deepak Dixit
> > > ofbiz.apache.org
> > >
> > >
> > > On Tue, Aug 22, 2023 at 2:22 PM Deepak Dixit 
> wrote:
> > >
> > >> Sure Daniel!!
> > >>
> > >>
> > >> Thanks & Regards
> > >> --
> > >> Deepak Dixit
> > >> ofbiz.apache.org
> > >>
> > >>
> > >> On Tue, Aug 22, 2023 at 1:25 PM Daniel Watford 
> > wrote:
> > >>
> > >>> Hi Deepak,
> > >>>
> > >>> Please could you raise a ticket to get it added to the container
> > builds.
> > >>>
> > >>> Thanks,
> > >>>
> > >>> Dan.
> > >>>
> > >>> On Tue, 22 Aug 2023 at 07:57, Deepak Dixit 
> wrote:
> > >>>
> > >>> > Hi,
> > >>> >
> > >>> > demo-trunk not using http/2 protocol, http/2 support was added long
> > >>> ago.
> > >>> > It's working fine on localhost.
> > >>> >
> > >>> > Is there any specific reason to disable http/2 on demo-trunk?
> > >>> >
> > >>> >
> > >>> > Thanks & Regards
> > >>> > --
> > >>> > Deepak Dixit
> > >>> > ofbiz.apache.org
> > >>> >
> > >>>
> > >>>
> > >>> --
> > >>> Daniel Watford
> > >>>
> > >>
> >
>
>
> --
> Daniel Watford
>


Re: HTTP/2 disabled on demo-trunk

2023-10-26 Thread Deepak Dixit
Hi Daniel!!

Did you get a chance to look at this?

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Aug 22, 2023 at 2:29 PM Deepak Dixit  wrote:

> Here is the task for the same
> https://issues.apache.org/jira/browse/OFBIZ-12846
>
> HTTP/2 should be enabled by default. Need to check if we are disabling
> this while container build.
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Tue, Aug 22, 2023 at 2:22 PM Deepak Dixit  wrote:
>
>> Sure Daniel!!
>>
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> ofbiz.apache.org
>>
>>
>> On Tue, Aug 22, 2023 at 1:25 PM Daniel Watford  wrote:
>>
>>> Hi Deepak,
>>>
>>> Please could you raise a ticket to get it added to the container builds.
>>>
>>> Thanks,
>>>
>>> Dan.
>>>
>>> On Tue, 22 Aug 2023 at 07:57, Deepak Dixit  wrote:
>>>
>>> > Hi,
>>> >
>>> > demo-trunk not using http/2 protocol, http/2 support was added long
>>> ago.
>>> > It's working fine on localhost.
>>> >
>>> > Is there any specific reason to disable http/2 on demo-trunk?
>>> >
>>> >
>>> > Thanks & Regards
>>> > --
>>> > Deepak Dixit
>>> > ofbiz.apache.org
>>> >
>>>
>>>
>>> --
>>> Daniel Watford
>>>
>>


Issue with OFBiz Job Scheduler and Daylight Saving Time

2023-10-16 Thread Deepak Dixit
Hi Dev,

I wanted to draw your attention to an issue we've encountered with the
OFBiz job scheduler, particularly when it comes to handling Daylight Saving
Time (DST) changes.

It appears that the job scheduler fails to create new recurring jobs when
DST ends, especially when the tempExprTypeId is set to FREQUENCY (e.g., 15
minutes, 30 minutes).

Upon further investigation, we've identified that the following condition
in PersistedServiceJob.createRecurrence might be the root of the issue:

java

if (next > startTime) {
// ...
// ...
}

I'm curious to know if anyone else has encountered a similar problem or if
you have any insights to share regarding this issue.

Thanks & Regards

--
Deepak Dixit
ofbiz.apache.org


Re: Ofbiz not working when ecommerce plugin is pulled

2023-10-06 Thread Deepak Dixit
It seems ecommerce is dependent on solr and lucene plugins.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, Oct 1, 2023 at 11:44 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Amol,
>
> That's because you need also, at least, the lucene plugin, and maybe more.
> To avoid similar issues I recommend to load all the plugins.
>
> Jacques
>
> Le 01/10/2023 à 16:04, Amol Patil a écrit :
> > Hello Jacques,
> >
> > Thank you for replying to my email.
> >
> > I have attached a zip folder which contains step by step images of cmd
> in which, in the 6th image, you will see the error, please let me know what
> > the error is.
> >
> > Thank you.
> >
> > On Sat, Sep 30, 2023 at 1:29 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
> >
> > Hi Amol,
> >
> > The trunk HEAD with plugins, including ecommerce, works at
> https://demo-trunk.ofbiz.apache.org/ecomseo
> >
> > So you need to send us more information. I mean what Gradle tells
> you in console.
> >
> > HTH
> >
> > Jacques
> >
> > Le 30/09/2023 à 08:05, Amol Patil a écrit :
> > > Hello,
> > >
> > > Cloned latest git of Ofbiz, and then installed/pulled official
> ecommerce
> > > plugin. and tried to start ofbiz, but Build getting failed with
> below
> > > reason:
> > >
> > > * What went wrong:
> > > Execution failed for task ':compileGroovy'.
> > >
> > > What could be the problem?
> > >
> >
> >
> >
> > --
> > Regards,
> > Amol Patil.


Re: HTTP/2 disabled on demo-trunk

2023-08-22 Thread Deepak Dixit
Here is the task for the same
https://issues.apache.org/jira/browse/OFBIZ-12846

HTTP/2 should be enabled by default. Need to check if we are disabling this
while container build.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Aug 22, 2023 at 2:22 PM Deepak Dixit  wrote:

> Sure Daniel!!
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Tue, Aug 22, 2023 at 1:25 PM Daniel Watford  wrote:
>
>> Hi Deepak,
>>
>> Please could you raise a ticket to get it added to the container builds.
>>
>> Thanks,
>>
>> Dan.
>>
>> On Tue, 22 Aug 2023 at 07:57, Deepak Dixit  wrote:
>>
>> > Hi,
>> >
>> > demo-trunk not using http/2 protocol, http/2 support was added long ago.
>> > It's working fine on localhost.
>> >
>> > Is there any specific reason to disable http/2 on demo-trunk?
>> >
>> >
>> > Thanks & Regards
>> > --
>> > Deepak Dixit
>> > ofbiz.apache.org
>> >
>>
>>
>> --
>> Daniel Watford
>>
>


Re: HTTP/2 disabled on demo-trunk

2023-08-22 Thread Deepak Dixit
Sure Daniel!!


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Aug 22, 2023 at 1:25 PM Daniel Watford  wrote:

> Hi Deepak,
>
> Please could you raise a ticket to get it added to the container builds.
>
> Thanks,
>
> Dan.
>
> On Tue, 22 Aug 2023 at 07:57, Deepak Dixit  wrote:
>
> > Hi,
> >
> > demo-trunk not using http/2 protocol, http/2 support was added long ago.
> > It's working fine on localhost.
> >
> > Is there any specific reason to disable http/2 on demo-trunk?
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
>
>
> --
> Daniel Watford
>


HTTP/2 disabled on demo-trunk

2023-08-22 Thread Deepak Dixit
Hi,

demo-trunk not using http/2 protocol, http/2 support was added long ago.
It's working fine on localhost.

Is there any specific reason to disable http/2 on demo-trunk?


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


Re: Resource leaks in EntitySQLProcessor.groovy?

2023-07-11 Thread Deepak Dixit
Hi Paul,

The resource should be closed properly, we can use groovy withClosable or
groovy 3 try with resource.

No one touched the groovy code for the ARM.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Jul 11, 2023 at 11:09 AM Paul Foxworthy 
wrote:

> Hi all,
>
> I want to check in case I'm missing something, but I think there are some
> problems with
>
> framework/webtools/groovyScripts/entity/EntitySQLProcessor.groovy
>
> At line 35
>
> https://github.com/apache/ofbiz-framework/blob/e080f0bfa657b8b6ffd4cbf5629e0c648440b5f0/framework/webtools/groovyScripts/entity/EntitySQLProcessor.groovy#L35
>
> it creates an SQLProcessor. SQLProcessor has a Close method and implements
> AutoCloseable, but we're not using try-with-resources, nor directly calling
> the Close method. I'm thinking there should be a try-with-resources. Any
> reason why not?
>
> Similarly,
>
>
> https://github.com/apache/ofbiz-framework/blob/e080f0bfa657b8b6ffd4cbf5629e0c648440b5f0/framework/webtools/groovyScripts/entity/EntitySQLProcessor.groovy#L38
>
> obtains a java.sql.Resultset, which will be closed when everything works,
> but would leak if there was an exception. Again, we should be using
> try-with-resources.
>
> Note that according to
>
>
> https://docs.oracle.com/en/java/javase/20/docs/api/java.sql/java/sql/ResultSet.html#close()
>
> "Calling the method close on a ResultSet object that is already closed is a
> no-op.", if you obtain a ResultSet from the SQLProcessor and directly close
> that ResultSet, it's not a problem when the SQLProcessor.close also
> attempts to close the ResultSet.
>
> The problem is minor, most of the time. The groovy script is in the
> webtools, so used for developer tinkering and not production use.
>
> When you're doing a SELECT, the script is closing the ResultSet, so the
> important resources are cleaned up (assuming no exception occurred).
>
> However, if you are doing INSERT, UPDATE or DELETE, the script creates a
> prepared statement that is not closed, so there's a resource leak.
>
> Am I missing anything? I'll create a Jira if necessary.
>
> Thanks
>
> Paul Foxworthy
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Australia
>
> Phone: +61 3 9585 6788
> Web: http://www.coherentsoftware.com.au/
> Email: i...@coherentsoftware.com.au
>


Re: [VOTE] Apache OFBiz 18.12.08

2023-05-28 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Fri, May 26, 2023 at 7:10 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> +1, all works as expected
>
> Jacques
>
> Le 26/05/2023 à 11:33, Jacopo Cappellato a écrit :
> > This is the vote thread to publish "Apache OFBiz 18.12.08", eighth
> > release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.08.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.08.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.08.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.08
> > [ -1] do not release
> >
> > This vote is open for at least 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
>


Re: Migration from ci.a.o

2023-04-26 Thread Deepak Dixit
Here is the PR for xml rpc related code removal. Please review and let me
know if it looks good.

https://github.com/apache/ofbiz-framework/pull/630/files

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Wed, Apr 26, 2023 at 11:01 AM Deepak Dixit  wrote:

> Hi Jacques,
>
> I agree we should remove the xml rpc related code from trunk,
> Here is the task for the issue, I'll create PR for the same
> https://issues.apache.org/jira/browse/OFBIZ-12812
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Tue, Dec 14, 2021 at 2:05 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Hi All,
>>
>> I have created https://issues.apache.org/jira/browse/OFBIZ-12456 as a
>> clone of INFRA-22279 "Migrate Ofbiz bb 0.8 config to 3.2"
>>
>> Long story short, the XMLRPC integration tests, that needs HTTP and 8080
>> port, don't pass on the new BuildBot and getting back to the old one is
>> impossible (more info OFBiz side in OFBIZ-12456).
>>
>> In INFRA-22279, I have asked Gavin if we could allow the new BuildBot to
>> allow HTTP and 8080 port as it was on the old one.
>>
>> I also wonder if we should not get rid of Apache XMLRPC knowing that it's
>> no longer maintained: https://github.com/advisories/GHSA-6vwp-35w3-xph8
>>
>> I'm not aware of an easy replacement for Apache XMLRPC.
>>
>> What do you think?
>>
>> Jacques
>>
>> Le 31/08/2021 à 14:08, Jacques Le Roux a écrit :
>> > Hi Gavin,
>> >
>> > Answering there
>> >
>> > Jacques
>> >
>> > Le 31/08/2021 à 11:32, Gavin McDonald a écrit :
>> >> I have created a Jira ticket where we can liaise on the migration
>> which I
>> >> would like to do ASAP.
>> >
>>
>


Re: Migration from ci.a.o

2023-04-25 Thread Deepak Dixit
Hi Jacques,

I agree we should remove the xml rpc related code from trunk,
Here is the task for the issue, I'll create PR for the same
https://issues.apache.org/jira/browse/OFBIZ-12812

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Dec 14, 2021 at 2:05 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi All,
>
> I have created https://issues.apache.org/jira/browse/OFBIZ-12456 as a
> clone of INFRA-22279 "Migrate Ofbiz bb 0.8 config to 3.2"
>
> Long story short, the XMLRPC integration tests, that needs HTTP and 8080
> port, don't pass on the new BuildBot and getting back to the old one is
> impossible (more info OFBiz side in OFBIZ-12456).
>
> In INFRA-22279, I have asked Gavin if we could allow the new BuildBot to
> allow HTTP and 8080 port as it was on the old one.
>
> I also wonder if we should not get rid of Apache XMLRPC knowing that it's
> no longer maintained: https://github.com/advisories/GHSA-6vwp-35w3-xph8
>
> I'm not aware of an easy replacement for Apache XMLRPC.
>
> What do you think?
>
> Jacques
>
> Le 31/08/2021 à 14:08, Jacques Le Roux a écrit :
> > Hi Gavin,
> >
> > Answering there
> >
> > Jacques
> >
> > Le 31/08/2021 à 11:32, Gavin McDonald a écrit :
> >> I have created a Jira ticket where we can liaise on the migration which
> I
> >> would like to do ASAP.
> >
>


Re: [VOTE] Apache OFBiz 18.12.07

2023-04-04 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Apr 4, 2023 at 6:33 PM Michael Brohl 
wrote:

> +1
>
> Thanks,
>
> Michael
>
> Am 03.04.23 um 09:47 schrieb Jacopo Cappellato:
> > This is the vote thread to publish "Apache OFBiz 18.12.07", seventh
> > and probably final release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.07.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.07.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.07.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.07
> > [ -1] do not release
> >
> > This vote is open for at least 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
>


Re: Welcome to Daniel Watford as new PMC member

2023-02-01 Thread Deepak Dixit
Many manu Congratulations Daniel!

Kind Regards,
Deepak Dixit


On Wed, Feb 1, 2023 at 6:28 PM Priya Sharma  wrote:

> Many Congratulations Daniel!
>
> On Tue, 31 Jan 2023 at 15:05, Daniel Watford  wrote:
>
> > Thanks all - I appreciate the invitation and am happy to be here :)
> >
> > On Mon, 30 Jan 2023 at 16:33, gil.portenseigne <
> > gil.portensei...@nereide.fr>
> > wrote:
> >
> > > Welcome Daniel, and Congrats !
> > >
> > > Gil
> > > On 28/01/23 11:57, Jacopo Cappellato wrote:
> > > > The OFBiz PMC has invited Daniel Watford as a new PMC member and we
> > > > are glad to announce that Daniel has accepted the nomination.
> > > >
> > > > On behalf of the OFBiz PMC, welcome on board!
> > >
> >
> >
> > --
> > Daniel Watford
> >
>


Re: svn commit: r1798086 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java

2022-12-04 Thread Deepak Dixit
I am working on some performance related thing, while reviewing code I
found the code snippet where eli closed explicitly,
That's why I landed up on this commit.

Please feel free to revert this commit,
We can also remove explicitly eli.close call from handleOutput(), else will
get unnecessary console warning from EntityListIterator.close() method.
```

Debug.logWarning("This EntityListIterator for Entity [" +
modelEntityName + "] has already been closed, not closing again.",
module);

```




Please feel free to
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, Dec 4, 2022 at 10:43 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> You are right, I missed to conclude what I said at the end of the commit
> comment ("I have to check the whole thing").
> So did not see that the called handleOutput() closes the eli var, well
> spotted.
>
> Now if we look at both r1797097
> <http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java?r1=1797097=1797096=1797097>
> and r1798086
> <http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java?r1=1798086=1798085=1798086>
> we can see they really have no effects. r1797097 uses try-with-ressource
> r1798086  removes it.
> The question could be "what happens if we manually close a resource inside
> a try-with-ressource block" (as in r1797097)
> According to
> https://stackoverflow.com/questions/21254547/manual-closing-inside-try-with-resource
> it should be OK.
>
> So I finally think the real problem with r1798086 is the confusing comment
> in code. Because in both cases (try-with-ressource or not) eli will be
> closed by handleOutput .
>
>  // NOTE: the eli EntityListIterator is not closed here.
>It SHOULD be closed later after the returned list
>will be used (eg see EntityAnd.getChildren() in ModelTree.java)
>
> Moreover it's confusing because ModelTree is completely unrelated. I
> should have "check[ed] the whole thing" (maybe I confused the 2
> EntityFinderUtil::handleOutput) :/
>
> Nevertheless, it sounds better reverting. In case an eli unrelated issue
> happens inside handleOutput() before it closes eli. It's mostly
> improbable but you never know :)
>
> I just have a question how did you get there? I guess you did not cross an
> issue. So you stumbled upon this weird comment, right?
>
> I can revert if you like.
> Thanks
>
> Jacques
> Le 01/12/2022 à 09:04, Deepak Dixit a écrit :
>
> Hi Jacques,
>
> I know it's quite an old commit :)
>
> Do you remember the case where eli closed after the returned list has been
> used?
>
> As handleOutput method closes the eli inline.
>
> I am planning to revert this commit, Please share your thoughts.
>
>
> Thanks & Regards
> --
> Deepak Dixitofbiz.apache.org
>
>
> On Thu, Jun 8, 2017 at 9:46 PM   
> wrote:
>
>
> Author: jleroux
> Date: Thu Jun  8 16:16:29 2017
> New Revision: 1798086
>
> URL: http://svn.apache.org/viewvc?rev=1798086=rev
> Log:
> This fixes a bug introduced with r1797097
>
> As noted in code the EntityListIterator was not closed for a "good"
> reason: it
> might be used later by the framework though not passed as a var. I think I
> found
> 1 case where it's closed after the returned list have been used (in
> EntityAnd.getChildren() in ModelTree.java); but I have to
>
> Modified:
>
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
> URL:http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java?rev=1798086=1798085=1798086=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
> Thu Jun  8 16:16:29 2017
> @@ -207,11 +207,13 @@ public abstract class ListFinder extends
>  options.setMaxRows(size * (index + 1));
>  }
>  boolean beganTransaction = false;
> -try (EntityListIterator eli = delegator.find(entityName,
> whereEntityCondition, havingEntityCondition, fieldsToSelect, orderByFields,
> options)) {
> +try {
>   

Re: svn commit: r1798086 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java

2022-12-01 Thread Deepak Dixit
Hi Jacques,

I know it's quite an old commit :)

Do you remember the case where eli closed after the returned list has been
used?

As handleOutput method closes the eli inline.

I am planning to revert this commit, Please share your thoughts.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Jun 8, 2017 at 9:46 PM  wrote:

> Author: jleroux
> Date: Thu Jun  8 16:16:29 2017
> New Revision: 1798086
>
> URL: http://svn.apache.org/viewvc?rev=1798086=rev
> Log:
> This fixes a bug introduced with r1797097
>
> As noted in code the EntityListIterator was not closed for a "good"
> reason: it
> might be used later by the framework though not passed as a var. I think I
> found
> 1 case where it's closed after the returned list have been used (in
> EntityAnd.getChildren() in ModelTree.java); but I have to check the whole
> thing
>
> Modified:
>
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java?rev=1798086=1798085=1798086=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java
> Thu Jun  8 16:16:29 2017
> @@ -207,11 +207,13 @@ public abstract class ListFinder extends
>  options.setMaxRows(size * (index + 1));
>  }
>  boolean beganTransaction = false;
> -try (EntityListIterator eli = delegator.find(entityName,
> whereEntityCondition, havingEntityCondition, fieldsToSelect, orderByFields,
> options)) {
> +try {
>  if (useTransaction) {
>  beganTransaction = TransactionUtil.begin();
>  }
> +EntityListIterator eli = delegator.find(entityName,
> whereEntityCondition, havingEntityCondition, fieldsToSelect, orderByFields,
> options);
>  this.outputHandler.handleOutput(eli, context,
> listAcsr);
> +// NOTE: the eli EntityListIterator is not closed
> here. It SHOULD be closed later after the returned list will be used (eg
> see EntityAnd.getChildren() in ModelTree.java)
>  } catch (GenericEntityException e) {
>  String errMsg = "Failure in by " + label + " find
> operation, rolling back transaction";
>  Debug.logError(e, errMsg, module);
>
>
>


Re: MySql8 issue with add missing on start

2022-09-13 Thread Deepak Dixit
Please let me know if it looks good, I'll merge this.
This may cause issues with some of the databases.

I verified it's working fine with mysql and derby.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Sep 12, 2022 at 1:33 PM Deepak Dixit  wrote:

>
> While working with mysql 8 database faced an issue with new ofbiz setup,
> ofbiz fails to add new tables in database,
>
> Environment
> Database server : mysql 8
> Database drive : mysql 8.0.30
>
> Steps to regenerate:
>
>- Create new database named ofbiz, configure it with ofbiz and load
>data (everything working fine)
>- Create another database named ofbiz1, configure it with ofbiz and
>load data
>This process will fails
>
> After initial debugging found while check db DatabaseMetaData.getTables
> returns a list of tables from the existing database, so it does not create
> new tables hence fails to load data.
> Created PR for the same [1], need to verify these changes with other
> databases as well, as it may fail with others.
>
>
> [1] https://github.com/apache/ofbiz-framework/pull/543/files
>
> [2]
> https://stackoverflow.com/questions/7942520/relationship-between-catalog-schema-user-and-database-instance
>
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>


MySql8 issue with add missing on start

2022-09-12 Thread Deepak Dixit
While working with mysql 8 database faced an issue with new ofbiz setup,
ofbiz fails to add new tables in database,

Environment
Database server : mysql 8
Database drive : mysql 8.0.30

Steps to regenerate:

   - Create new database named ofbiz, configure it with ofbiz and load data
   (everything working fine)
   - Create another database named ofbiz1, configure it with ofbiz and load
   data
   This process will fails

After initial debugging found while check db DatabaseMetaData.getTables
returns a list of tables from the existing database, so it does not create
new tables hence fails to load data.
Created PR for the same [1], need to verify these changes with other
databases as well, as it may fail with others.


[1] https://github.com/apache/ofbiz-framework/pull/543/files

[2]
https://stackoverflow.com/questions/7942520/relationship-between-catalog-schema-user-and-database-instance



Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


Re: [VOTE] Apache OFBiz 18.12.06

2022-08-26 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Aug 25, 2022 at 6:34 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Jacopo,
>
> +1
>
> Checksum and GPG OK, running OFBiz too.
>
> Thanks
>
> Jacques
>
> Le 25/08/2022 à 10:10, Jacopo Cappellato a écrit :
> > This is the vote thread to publish "Apache OFBiz 18.12.06", the sixth and
> > final release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.06.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.06.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.06.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.06
> > [ -1] do not release
> >
> > This vote is open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
>
>


Re: [VOTE] [RELEASE] Apache OFBiz 18.12.04 (third attempt)

2021-12-19 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, Dec 19, 2021 at 4:34 PM Michael Brohl 
wrote:

> +1
>
>
> ===
>
> ~/Projects/apache-ofbiz/dist  ./../ofbiz-tools/verify-ofbiz-release.sh
> -a apache-ofbiz-18.12.04
>
> Processing files for release: apache-ofbiz-18.12.04...
> Downloading files for apache-ofbiz-18.12.04.zip...
> Done!
>
> Verifying files...
> sha check of file: apache-ofbiz-18.12.04.zip
> Using sha file: apache-ofbiz-18.12.04.zip.sha512
> apache-ofbiz-18.12.04.zip: B0790566 38A7F01A 95584866 15BE7F04 46828308
> FF698A00 69600690 F5C0EAA3 CBEED7CC E805AB04 55F2DB94 8727DB6B D622F07B
> 2FBD70E7 2D4251EA FA4DEB47
> apache-ofbiz-18.12.04.zip: B0790566 38A7F01A 95584866 15BE7F04 46828308
> FF698A00 69600690 F5C0EAA3 CBEED7CC E805AB04 55F2DB94 8727DB6B D622F07B
> 2FBD70E7 2D4251EA FA4DEB47
> sha checksum OK
>
> GPG verification output
>
> Unpacking release file archive apache-ofbiz-18.12.04.zip...
> Archive:  apache-ofbiz-18.12.04.zip
> ...
> Initializing Gradle wrapper...
>   === Prepare operation ===
> /Users/mbrohl/Projects/apache-ofbiz/dist/apache-ofbiz-18.12.04/gradle/wrapper/gradle-wrapper.jar
>
> not found, we download it
>   === Download gradle-wrapper.jar ===
>   === Download gradle-wrapper.properties ===
>   === Control downloaded files ===
> gradle/wrapper/gradle-wrapper.jar: OK
> gradle/wrapper/gradle-wrapper.properties: OK
> gradlew: OK
> Running tests...
> Starting a Gradle Daemon (subsequent builds will be faster)
> ...
> BUILD SUCCESSFUL in 4m 43s
> 27 actionable tasks: 22 executed, 5 up-to-date
> Done processing files for release apache-ofbiz-18.12.04
>
> ===
>
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 19.12.21 um 11:20 schrieb Jacopo Cappellato:
> > This is the third vote thread to release a new bug fix release for the
> > release18.12 branch. This new release, "Apache OFBiz 18.12.04" will
> > supersede all the previous releases from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-18.12.04.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.04.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.04.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see [*]).
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 18.12.04
> > [ -1] do not release
> >
> > For more details about this process please read [**].
> > [*]
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
> > [**] http://www.apache.org/foundation/voting.html
>


Re: [VOTE] Apache OFBiz 18.12.03

2021-12-12 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, Dec 12, 2021 at 11:02 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> +1
>
> Jacopo
>
> On Sun, Dec 12, 2021 at 1:14 PM Jacopo Cappellato
>  wrote:
> >
> > This is the vote thread to publish "Apache OFBiz 18.12.03", the third
> > release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.03.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.03.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.03.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> > instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.03
> > [ -1] do not release
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
>


Re: [VOTE] Apache OFBiz 18.12.01

2021-10-27 Thread Deepak Dixit
+1
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Wed, Oct 27, 2021 at 1:06 PM Gil Portenseigne <
gil.portensei...@nereide.fr> wrote:

> +1
>
> Thanks,
>
> Gil
> On Sat, Oct 23, 2021 at 05:08:32PM +0200, Jacopo Cappellato wrote:
> > This is the vote thread to publish "Apache OFBiz 18.12.01", the first
> > release from the release17.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.01.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.01.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.01.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.01
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
>


Re: VERY IMPORTANT Premature end of file ofbiz-containers

2021-07-19 Thread Deepak Dixit
Hi Nicolas,

It's a good idea to ask infra for the same.

Kind Regards,
Deepak Dixit




On Tue, Jul 20, 2021 at 12:35 AM Nicolas Malin 
wrote:

> [1] https://github.com/apache/ofbiz-site/blob/master/.htaccess
>
> ctrl+enter too speed :D
>
> On 19/07/2021 21:04, Nicolas Malin wrote:
> > Hi Deepak,
> >
> > After a check from my part, I didn't understand why the rewrite rule [1]
> > to escape https redirect on dtd, didn't work on ofbiz site after the
> > last jacques's commit
> >
> > If you have an idea, else I will open an issue for infra asf team
> >
> > Nicolas
> >
> > On 19/07/2021 20:58, Deepak Dixit wrote:
> >> Hi Kevin,
> >>
> >> This is related to https://issues.apache.org/jira/browse/OFBIZ-10590.
> >> Proper fix is to update the namespace schema location from http to
> https,
> >> After adding the redirect rule it was working fine, but something
> changes
> >> since last Friday,
> >> I am also facing this issue after installing the latest jkd security
> >> update.
> >>
> >> It was working well with the openjdk version "1.8.0_222", after
> updating to
> >> the latest version (openjdk version "1.8.0_292") I am facing this issue.
> >>
> >>
> >> Kind Regards,
> >> Deepak Dixit
> >> DIRECTOR OF PRODUCT ENGINEERING
> >> mobile: +91 9826754548
> >> email: deepak.di...@hotwax.co
> >> *www.hotwax.co <http://www.hotwax.co/>*
> >>
> >>
> >> On Mon, Jul 19, 2021 at 10:44 PM Kevin Aland
> 
> >> wrote:
> >>
> >>> Dear OFBiz Team,
> >>>
> >>>
> >>>
> >>> we have got a very import problem in our productive OFBiz environment.
> We
> >>> describe this problem in this ticket
> >>> https://issues.apache.org/jira/browse/OFBIZ-12285.
> >>>
> >>>
> >>>
> >>> Please can you help us.
> >>>
> >>>
> >>>
> >>> https://www.hmmh.de/leistungen/connected-crm
> >>>
> >>>
> >>>
> >>> Best regards
> >>>
> >>>
> >>>
> >>> *Kevin Aland*
> >>>
> >>> Software Engineer
> >>>
> >>> hmmh multimediahaus AG
> >>>
> >>> Leading in Connected Commerce
> >>>
> >>> Am Weser-Terminal 1 · 28217 Bremen
> >>>
> >>> Telefon +49 421 696 50 - 290 · Telefax +49 421 696 50 - 190
> >>>
> >>> hmmh.de <http://www.hmmh.de/> · *kevin.al...@hmmh.de
> >>> *
> >>>
> >>>
> >>>
> >>> *Up to date! *Erhalten Sie exklusiv alle News von hmmh - abonnieren Sie
> >>> unseren Newsletter <https://www.hmmh.de/newsletter/>.
> >>>
> >>> *Näher dran!* Lernen Sie hmmh besser kennen und folgen Sie uns auf
> >>> linkedin.com/hmmh-ag <https://www.linkedin.com/company/hmmh-ag>.
> >>>
> >>>
> >>>
> >>> HR Bremen B 20536 · St.Nr. 60 102 / 03285 · EG Ust.-ID: DE 114413710
> >>>
> >>> Vorstand: Stefan Messerknecht (Sprecher), Björn Portillo · Vorsitzender
> >>> des Aufsichtsrats: Florian Haller
> >>>
> >>> P Please consider the environment before printing this e-mail.
> >>>
> >>>
> >>>
>


Re: VERY IMPORTANT Premature end of file ofbiz-containers

2021-07-19 Thread Deepak Dixit
Hi Kevin,

This is related to https://issues.apache.org/jira/browse/OFBIZ-10590.
Proper fix is to update the namespace schema location from http to https,
After adding the redirect rule it was working fine, but something changes
since last Friday,
I am also facing this issue after installing the latest jkd security
update.

It was working well with the openjdk version "1.8.0_222", after updating to
the latest version (openjdk version "1.8.0_292") I am facing this issue.


Kind Regards,
Deepak Dixit
DIRECTOR OF PRODUCT ENGINEERING
mobile: +91 9826754548
email: deepak.di...@hotwax.co
*www.hotwax.co <http://www.hotwax.co/>*


On Mon, Jul 19, 2021 at 10:44 PM Kevin Aland 
wrote:

> Dear OFBiz Team,
>
>
>
> we have got a very import problem in our productive OFBiz environment. We
> describe this problem in this ticket
> https://issues.apache.org/jira/browse/OFBIZ-12285.
>
>
>
> Please can you help us.
>
>
>
> https://www.hmmh.de/leistungen/connected-crm
>
>
>
> Best regards
>
>
>
> *Kevin Aland*
>
> Software Engineer
>
> hmmh multimediahaus AG
>
> Leading in Connected Commerce
>
> Am Weser-Terminal 1 · 28217 Bremen
>
> Telefon +49 421 696 50 - 290 · Telefax +49 421 696 50 - 190
>
> hmmh.de <http://www.hmmh.de/> · *kevin.al...@hmmh.de
> *
>
>
>
> *Up to date! *Erhalten Sie exklusiv alle News von hmmh - abonnieren Sie
> unseren Newsletter <https://www.hmmh.de/newsletter/>.
>
> *Näher dran!* Lernen Sie hmmh besser kennen und folgen Sie uns auf
> linkedin.com/hmmh-ag <https://www.linkedin.com/company/hmmh-ag>.
>
>
>
> HR Bremen B 20536 · St.Nr. 60 102 / 03285 · EG Ust.-ID: DE 114413710
>
> Vorstand: Stefan Messerknecht (Sprecher), Björn Portillo · Vorsitzender
> des Aufsichtsrats: Florian Haller
>
> P Please consider the environment before printing this e-mail.
>
>
>


Re: Welcome to Priya Sharma as new committer!

2021-03-12 Thread Deepak Dixit
Many Many Congratulations !!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sat, Mar 13, 2021 at 8:41 AM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Many congratulations, Priya.
>
> Best,
> Girish
>
> On Fri, Mar 12, 2021, 23:48 Sharan Foga  wrote:
>
> > Huge congratulations and welcome Priya! :-)
> >
> > Thanks
> > Sharan
> >
> > On 2021/03/11 13:01:23, Pawan Verma  wrote:
> > > The OFBiz PMC has invited Priya to become a new committer and we are
> > > pleased to announce that she has accepted the nomination.
> > >
> > > Welcome onboard Priya, more power to you!
> > >
> > >
> > > Pawan
> > >
> >
>


Re: Welcome Akash Jain as new PMC member

2021-01-28 Thread Deepak Dixit
Welcome aboard Akash!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Jan 28, 2021 at 10:10 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> The OFBiz PMC has invited Akash Jain to become member of the committee and
> we are glad to announce he has accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome Akash!
>
>


Re: Welcome Girish Vasmatkar as new PMC member

2021-01-28 Thread Deepak Dixit
Welcome aboard Girish!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Jan 28, 2021 at 10:10 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> The OFBiz PMC has invited Girish Vasmatkar to become member of the
> committee and we are glad to announce he has accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome Girish!
>
>


Re: Remove JQuery UI from OFBiz website

2021-01-04 Thread Deepak Dixit
Hi Aditya,

I don't see any issue in removing jquery ui, It was added at initial
commit.
If everything works fine we can remove this.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jan 4, 2021 at 8:02 PM Aditya Sharma 
wrote:

> Hi team,
>
> While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI is
> no longer used. I propose to remove it with the following PR:
>
> https://github.com/apache/ofbiz-site/pull/6/files
>
> I haven't found any code reference related to it and the site works well
> without any console errors. Do let me know if anyone having any idea why it
> was used or if there is something missed at my end.
>
> Thanks and regards,
> Aditya Sharma
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.05 - Second attempt

2021-01-04 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jan 4, 2021 at 4:05 PM Nicola Mazzoni 
wrote:

> +1
>
> Il giorno lun 4 gen 2021 alle ore 11:32 Jacopo Cappellato <
> jacopo.cappell...@gmail.com> ha scritto:
>
> > This is the vote thread (second attempt) to release a new bug fix release
> > for the release17.12 branch. This new release, "Apache OFBiz 17.12.05"
> will
> > supersede all the previous releases from the same branch.
> >
> > Please consider that this may be the last release in the 17.12 series and
> > in the future releases will be published from the newer series, which is
> > 18.12.
> >
> > The release files can be downloaded from here:
> >
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> >
> > * apache-ofbiz-17.12.05.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.05.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.05.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Please cast your vote:
> >
> > [ +1] release Apache OFBiz 17.12.05
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
>
>
> --
> Nicola Mazzoni
>
>
> *Mp Styl**e Srl*
> via Meucci, 37
> 41019 Limidi di Soliera (MO)
> T 059/684916
> M 347/9905529
>
> www.mpstyle.it
>


Re: buildbot failure in on ofbizBranch17FrameworkPlugins

2021-01-04 Thread Deepak Dixit
Hi All,

Here [1] is the PR for the fix, Updated the lucene and solr dependencies,
took reference from [2]
I merged this MR and now buildbot success in on
ofbizBranch17FrameworkPlugins [3]

[1] https://github.com/apache/ofbiz-plugins/pull/48/files
[2]
https://github.com/apache/ofbiz-plugins/commit/4f19b762f3d9fc7988a347a896997f49196427e9
[3] https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/622


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jan 4, 2021 at 12:09 PM Deepak Dixit  wrote:

> We can update the solr and lucene dependency as well to latest,  let me
> check
>
> Kind Regards,
> Deepak Dixit
>
>
> On Sun, Jan 3, 2021 at 3:32 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Though one clue is perhaps that it works in trunk
>>
>> Le 03/01/2021 à 10:15, Jacques Le Roux a écrit :
>> > That makes sense Jacopo, how to solve the conundrum is less obvious. I
>> have reopened OFBIZ-12100 as a blocker.
>> >
>> > Jacques
>> >
>> > Le 03/01/2021 à 09:44, Jacopo Cappellato a écrit :
>> >> I suspect that the new version of the tika libraries are dependent on a
>> >> version of Guava that is not compatible with the one required by the
>> solr
>> >> component.
>> >>
>> >> Jacopo
>> >>
>> >>
>> >> On Sun, Jan 3, 2021 at 9:40 AM Jacopo Cappellato <
>> >> jacopo.cappell...@gmail.com> wrote:
>> >>
>> >>> I am actually getting the same error on R17.
>> >>> The error is the one reported in:
>> >>> https://issues.apache.org/jira/browse/OFBIZ-9444
>> >>> In fact disabling the "solr" component resolves the issue.
>> >>>
>> >>> Jacopo
>> >>>
>> >>>
>> >>> On Sun, Jan 3, 2021 at 9:22 AM jler...@apache.org > >
>> >>> wrote:
>> >>>
>> >>>> Hi Deepak, All,
>> >>>>
>> >>>> The same error (not failure) exists in both R17 and R18. I reproduce
>> >>>> locally with R18. It seems related to OFBIZ-9442 and OFBIZ-9444
>> >>>>
>> >>>> Reverting the change allows
>> >>>>
>> >>>>  gradlew "ofbiz --test component=solr --test suitename=solrtests"
>> >>>>
>> >>>> to pass
>> >>>>
>> >>>> I believe this is a blocker for the releases.
>> >>>>
>> >>>> HTH
>> >>>>
>> >>>> Jacques
>> >>>>
>> >>>>
>> >>>> Le 31/12/2020 à 14:33, Deepak Dixit a écrit :
>> >>>>> I don't think this build failure due to dependency update
>> >>>>>
>> >>>>> solrTests is failing
>> >>>>>
>> >>>>
>> /=/
>> >>>>> /2020-12-31 11:58:34,947 |main |TestRunContainer |I| [JUNIT] Pass:
>> >>>> false | # Tests: 5 | # Failed: 0 # Errors: 1 2020-12-31 11:58:34,947
>> |main
>> >>>>> |TestRunContainer |I| [JUNIT] - ERRORS
>> >>>> - [JUNIT] 2020-12-31 11:58:34,947 |main
>> >>>>> |TestRunContainer |I| -->
>> >>>> testAddProductToIndex(org.apache.ofbiz.solr.test.SolrTests): Could
>> not
>> >>>> commit transaction for service [solrProductsSearch]
>> >>>>> call: Roll back error, could not commit transaction, was rolled back
>> >>>> instead because of: Error in Service [runSolrQuery]:
>> >>>>>
>> org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:
>> >>>> Error from server at https://localhost:8443/solr/solrdefault
>> >>>>> <https://localhost:8443/solr/solrdefault>:
>> >>>> java.lang.NoSuchMethodError:
>> >>>>
>> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
>> >>>> 2020-12-31 11:58:34,948 |main |TestRunContainer
>> >>>>> |I| org.apache.ofbiz.service.GenericServiceException: Could not
>> commit
>> >>>> transaction for service [solrProductsSearch] call: Roll back error,
>> could
>> >>>> not
>> >>>>> commit transaction, was rolled back instead because of: Error in
>&g

Re: Welcome to Daniel Watford as new committer!

2021-01-04 Thread Deepak Dixit
Many Many Congrats Daniel!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jan 4, 2021 at 1:16 PM Daniel Watford  wrote:

> Thank you everyone - it's good to be here :)
>
> On Mon, 4 Jan 2021 at 06:53, Devanshu Vyas 
> wrote:
>
> > Congratulations Daniel and welcome aboard!!
> >
> >
> > Thanks & Regards,
> > Devanshu Vyas.
> >
> >
> > On Mon, Jan 4, 2021 at 10:58 AM Aditya Sharma 
> > wrote:
> >
> > > Felicitations Daniel
> > > Welcome aboard !!
> > >
> > > Thanks and Regards,
> > > Aditya Sharma
> > >
> > > On Thu, Dec 31, 2020 at 9:50 PM Jacopo Cappellato <
> > > jacopo.cappell...@gmail.com> wrote:
> > >
> > > > The OFBiz PMC has invited Daniel to become a new committer and we are
> > > > pleased  to announce that he has accepted the nomination.
> > > >
> > > > Welcome onboard Daniel!
> > > >
> > > > Jacopo
> > > >
> > >
> >
>
>
> --
> Daniel Watford
>


Re: buildbot failure in on ofbizBranch17FrameworkPlugins

2021-01-03 Thread Deepak Dixit
We can update the solr and lucene dependency as well to latest,  let me
check

Kind Regards,
Deepak Dixit


On Sun, Jan 3, 2021 at 3:32 PM Jacques Le Roux 
wrote:

> Though one clue is perhaps that it works in trunk
>
> Le 03/01/2021 à 10:15, Jacques Le Roux a écrit :
> > That makes sense Jacopo, how to solve the conundrum is less obvious. I
> have reopened OFBIZ-12100 as a blocker.
> >
> > Jacques
> >
> > Le 03/01/2021 à 09:44, Jacopo Cappellato a écrit :
> >> I suspect that the new version of the tika libraries are dependent on a
> >> version of Guava that is not compatible with the one required by the
> solr
> >> component.
> >>
> >> Jacopo
> >>
> >>
> >> On Sun, Jan 3, 2021 at 9:40 AM Jacopo Cappellato <
> >> jacopo.cappell...@gmail.com> wrote:
> >>
> >>> I am actually getting the same error on R17.
> >>> The error is the one reported in:
> >>> https://issues.apache.org/jira/browse/OFBIZ-9444
> >>> In fact disabling the "solr" component resolves the issue.
> >>>
> >>> Jacopo
> >>>
> >>>
> >>> On Sun, Jan 3, 2021 at 9:22 AM jler...@apache.org 
> >>> wrote:
> >>>
> >>>> Hi Deepak, All,
> >>>>
> >>>> The same error (not failure) exists in both R17 and R18. I reproduce
> >>>> locally with R18. It seems related to OFBIZ-9442 and OFBIZ-9444
> >>>>
> >>>> Reverting the change allows
> >>>>
> >>>>  gradlew "ofbiz --test component=solr --test suitename=solrtests"
> >>>>
> >>>> to pass
> >>>>
> >>>> I believe this is a blocker for the releases.
> >>>>
> >>>> HTH
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>>> Le 31/12/2020 à 14:33, Deepak Dixit a écrit :
> >>>>> I don't think this build failure due to dependency update
> >>>>>
> >>>>> solrTests is failing
> >>>>>
> >>>>
> /=/
> >>>>> /2020-12-31 11:58:34,947 |main |TestRunContainer |I| [JUNIT] Pass:
> >>>> false | # Tests: 5 | # Failed: 0 # Errors: 1 2020-12-31 11:58:34,947
> |main
> >>>>> |TestRunContainer |I| [JUNIT] - ERRORS
> >>>> - [JUNIT] 2020-12-31 11:58:34,947 |main
> >>>>> |TestRunContainer |I| -->
> >>>> testAddProductToIndex(org.apache.ofbiz.solr.test.SolrTests): Could not
> >>>> commit transaction for service [solrProductsSearch]
> >>>>> call: Roll back error, could not commit transaction, was rolled back
> >>>> instead because of: Error in Service [runSolrQuery]:
> >>>>> org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:
> >>>> Error from server at https://localhost:8443/solr/solrdefault
> >>>>> <https://localhost:8443/solr/solrdefault>:
> >>>> java.lang.NoSuchMethodError:
> >>>>
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> >>>> 2020-12-31 11:58:34,948 |main |TestRunContainer
> >>>>> |I| org.apache.ofbiz.service.GenericServiceException: Could not
> commit
> >>>> transaction for service [solrProductsSearch] call: Roll back error,
> could
> >>>> not
> >>>>> commit transaction, was rolled back instead because of: Error in
> >>>> Service [runSolrQuery]:
> >>>>> org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:
> >>>> Error from server at https://localhost:8443/solr/solrdefault
> >>>>> <https://localhost:8443/solr/solrdefault>:
> >>>> java.lang.NoSuchMethodError:
> >>>>
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> >>>> at
> >>>>
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:563)
> >>>> /
> >>>>> /
> >>>>> /
> >>>>>
> >>>>
> /=/
> >>>>> Thanks & Regards
> >>>>> --
> >>>>> Deepak Dixit
> >>>>> ofbiz.apache.org <http://ofbiz.apache.org>
> >>>>>
> >>>>>
> >>>>>  The Buildbot has detected a new failure on builder
> >>>> ofbizBranch17FrameworkPlugins while building ofbiz-framework. Full
> details
> >>>> are available at:
> >>>>
> https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/621 <
> >>>>
> https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/621>
> >>>>>  Buildbot URL: https://ci.apache.org/ <https://ci.apache.org/>
> >>>>>
> >>>>>  Buildslave for this Build: asf946_ubuntu
> >>>>>
> >>>>>  Build Reason: downstream
> >>>>>  Build Source Stamp: [branch release17.12]
> >>>> 24d9328cdf6489ba0e4c2d9b849f08c66658a5e2
> >>>>>  Blamelist: Deepak Dixit  >>>> deepak.di...@hotwax.co>>
> >>>>>  BUILD FAILED: failed shell_7
> >>>>>
> >>>>>  Sincerely,
> >>>>>   -The Buildbot
> >>>>>
> >>>>>
> >>>>>
>


Re: buildbot failure in on ofbizBranch17FrameworkPlugins

2020-12-31 Thread Deepak Dixit
I don't think this build failure due to dependency update

solrTests is failing
*=*

*2020-12-31 11:58:34,947 |main |TestRunContainer
   |I| [JUNIT] Pass: false | # Tests: 5 | # Failed: 0 # Errors: 1
2020-12-31 11:58:34,947 |main |TestRunContainer
  |I| [JUNIT] - ERRORS
- [JUNIT]
2020-12-31 11:58:34,947 |main |TestRunContainer
  |I| --> testAddProductToIndex(org.apache.ofbiz.solr.test.SolrTests):
Could not commit transaction for service [solrProductsSearch] call:
Roll back error, could not commit transaction, was rolled back instead
because of: Error in Service [runSolrQuery]:
org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:
Error from server at https://localhost:8443/solr/solrdefault
<https://localhost:8443/solr/solrdefault>:
java.lang.NoSuchMethodError:
com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
2020-12-31 11:58:34,948 |main |TestRunContainer
  |I| org.apache.ofbiz.service.GenericServiceException: Could not
commit transaction for service [solrProductsSearch] call: Roll back
error, could not commit transaction, was rolled back instead because
of: Error in Service [runSolrQuery]:
org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException:
Error from server at https://localhost:8443/solr/solrdefault
<https://localhost:8443/solr/solrdefault>:
java.lang.NoSuchMethodError:
com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:563)
*


*=*

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Dec 31, 2020 at 5:29 PM  wrote:

> The Buildbot has detected a new failure on builder
> ofbizBranch17FrameworkPlugins while building ofbiz-framework. Full details
> are available at:
>
> https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/621
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf946_ubuntu
>
> Build Reason: downstream
> Build Source Stamp: [branch release17.12]
> 24d9328cdf6489ba0e4c2d9b849f08c66658a5e2
> Blamelist: Deepak Dixit 
>
> BUILD FAILED: failed shell_7
>
> Sincerely,
>  -The Buildbot
>
>
>
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.05

2020-12-31 Thread Deepak Dixit
Issue reported under [1] has been fixed

[1] https://issues.apache.org/jira/browse/OFBIZ-12100

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Dec 31, 2020 at 1:32 PM Deepak Dixit  wrote:

> Additional information
> https://issues.apache.org/jira/browse/OFBIZ-12100
> This is also blocker
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Sat, Dec 26, 2020 at 3:16 PM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
>> Hi Jacques,
>>
>> yes we can cancel the current vote and I can prepare new release files.
>> Before we proceed with the above plan, could you please verify and confirm
>> that there is nothing more to fix for OFBIZ-12101?
>>
>> Thanks,
>>
>> Jacopo
>>
>>
>> On Sat, Dec 26, 2020 at 9:18 AM Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> > Hi Jacopo,
>> >
>> > I'm sorry but due to
>> > https://github.com/apache/ofbiz-framework/commit/ba6470b/ I have
>> > introduced a stupid bug in R17 fixed with OFBIZ-12101.
>> >
>> > If  there is nothing more to fix for OFBIZ-12101, maybe we could release
>> > with this fix in?
>> >
>> > Jacques
>> >
>> >
>> > Le 25/12/2020 à 19:12, Jacopo Cappellato a écrit :
>> > >   This is the vote thread to release a new bug fix release for the
>> > > release17.12 branch. This new release, "Apache OFBiz 17.12.05" will
>> > > supersede all the previous releases from the same branch.
>> > >
>> > > Please consider that this may be the last release in the 17.12 series
>> and
>> > > in the future releases will be published from the newer series, which
>> is
>> > > 18.12.
>> > >
>> > > The release files can be downloaded from here:
>> > >
>> > > https://dist.apache.org/repos/dist/dev/ofbiz/
>> > >
>> > > and are:
>> > >
>> > > * apache-ofbiz-17.12.05.zip
>> > > * KEYS: text file with keys
>> > > * apache-ofbiz-17.12.05.zip.asc: the detached signature file
>> > > * apache-ofbiz-17.12.05.zip.sha512: checksum file
>> > >
>> > > Please download and test the zip file and its signatures (for
>> > instructions
>> > > on testing the signatures see
>> > http://www.apache.org/info/verification.html).
>> > >
>> > > Please cast your vote:
>> > >
>> > > [ +1] release Apache OFBiz 17.12.05
>> > > [ -1] do not release
>> > >
>> > > This vote will be open for 5 days.
>> > >
>> > > For more details about this process please read
>> > > http://www.apache.org/foundation/voting.html
>> > >
>> > > Thanks!!!
>> >
>> >
>>
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.05

2020-12-31 Thread Deepak Dixit
Additional information
https://issues.apache.org/jira/browse/OFBIZ-12100
This is also blocker

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sat, Dec 26, 2020 at 3:16 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> Hi Jacques,
>
> yes we can cancel the current vote and I can prepare new release files.
> Before we proceed with the above plan, could you please verify and confirm
> that there is nothing more to fix for OFBIZ-12101?
>
> Thanks,
>
> Jacopo
>
>
> On Sat, Dec 26, 2020 at 9:18 AM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi Jacopo,
> >
> > I'm sorry but due to
> > https://github.com/apache/ofbiz-framework/commit/ba6470b/ I have
> > introduced a stupid bug in R17 fixed with OFBIZ-12101.
> >
> > If  there is nothing more to fix for OFBIZ-12101, maybe we could release
> > with this fix in?
> >
> > Jacques
> >
> >
> > Le 25/12/2020 à 19:12, Jacopo Cappellato a écrit :
> > >   This is the vote thread to release a new bug fix release for the
> > > release17.12 branch. This new release, "Apache OFBiz 17.12.05" will
> > > supersede all the previous releases from the same branch.
> > >
> > > Please consider that this may be the last release in the 17.12 series
> and
> > > in the future releases will be published from the newer series, which
> is
> > > 18.12.
> > >
> > > The release files can be downloaded from here:
> > >
> > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > >
> > > and are:
> > >
> > > * apache-ofbiz-17.12.05.zip
> > > * KEYS: text file with keys
> > > * apache-ofbiz-17.12.05.zip.asc: the detached signature file
> > > * apache-ofbiz-17.12.05.zip.sha512: checksum file
> > >
> > > Please download and test the zip file and its signatures (for
> > instructions
> > > on testing the signatures see
> > http://www.apache.org/info/verification.html).
> > >
> > > Please cast your vote:
> > >
> > > [ +1] release Apache OFBiz 17.12.05
> > > [ -1] do not release
> > >
> > > This vote will be open for 5 days.
> > >
> > > For more details about this process please read
> > > http://www.apache.org/foundation/voting.html
> > >
> > > Thanks!!!
> >
> >
>


Re: Releasing 17.12.05, 18.12.01 and freezing R20

2020-12-21 Thread Deepak Dixit
>>>3 years support of r17 and 5 years support starting with r18.

+1


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Dec 21, 2020 at 7:27 PM Michael Brohl 
wrote:

> +1 for the initial proposal
>
> with an additional idea: maybe better skip r20 and make a r21 right at
> the beginning of the year with the chance to release also in 21.
>
> This would allow us to catch up and have a more up-to-date release
> cycle. It seems a bit outdated to read that r18 is released in 2021...
>
> What do you think?
>
> Also +1 for 3 years support of r17 and 5 years support starting with r18.
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 21.12.20 um 10:54 schrieb Jacques Le Roux:
> > Hi Deepak,
> >
> > The reason I propose that is because it's more and more difficult to
> > backport to R17, when for R18 it's still OK. Also 3 years seems good
> > enough for me.
> >
> > Of course if people think 5 years would be better then the backporting
> > question should be discussed...
> >
> > We could revise that later, because there was much change between R17
> > an trunk and there are less and less now. So we could support R18 for
> > 5 years
> >
> > Jacques
> >
> > Le 21/12/2020 à 10:38, Deepak Dixit a écrit :
> >> +1
> >>
> >> I have a question regarding the following point, rest looks good to me.
> >>
> >> What is the minimum supported year for a release?
> >> Do we have any policy regarding this?
> >>
> >> We should support a release for at least 5 year.
> >>
> >> Thoughts?
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> ofbiz.apache.org
> >>
> >>
> >> On Mon, Dec 21, 2020 at 2:51 PM Jacopo Cappellato <
> >> jacopo.cappell...@gmail.com> wrote:
> >>
>


Re: Releasing 17.12.05, 18.12.01 and freezing R20

2020-12-21 Thread Deepak Dixit
Thanks Jacques, sounds good to me.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Dec 21, 2020 at 3:24 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> The reason I propose that is because it's more and more difficult to
> backport to R17, when for R18 it's still OK. Also 3 years seems good enough
> for me.
>
> Of course if people think 5 years would be better then the backporting
> question should be discussed...
>
> We could revise that later, because there was much change between R17 an
> trunk and there are less and less now. So we could support R18 for 5 years
>
> Jacques
>
> Le 21/12/2020 à 10:38, Deepak Dixit a écrit :
> > +1
> >
> > I have a question regarding the following point, rest looks good to me.
> >
> > What is the minimum supported year for a release?
> > Do we have any policy regarding this?
> >
> > We should support a release for at least 5 year.
> >
> > Thoughts?
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Mon, Dec 21, 2020 at 2:51 PM Jacopo Cappellato <
> > jacopo.cappell...@gmail.com> wrote:
> >
>


Re: Releasing 17.12.05, 18.12.01 and freezing R20

2020-12-21 Thread Deepak Dixit
+1

I have a question regarding the following point, rest looks good to me.

>>>  * we release 17.12.05 as the last release of R17.

What is the minimum supported year for a release?
Do we have any policy regarding this?

We should support a release for at least 5 year.

Thoughts?

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Dec 21, 2020 at 2:51 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> Hi Jacques,
>
> It sounds like a good plan to me and I can prepare the artifacts as soon as
> we are ready.
> We could first publish 17.12.05 and then start the process for 18.12.01; in
> the meantime we could tag the new R20 branch.
>
> Thanks,
>
> Jacopo
>
>
> On Sun, Dec 20, 2020 at 2:08 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi All,
> >
> > We have no longer any pending security issues, even post-auth ones (those
> > with no CVE). As Marj J. Cox  - VP of ASF security - said once to me:
> <<"No
> > CVE" is a great outcome>> ;)
> >
> > I propose that
> >
> >   * we release 17.12.05 as the last release of R17.
> >   * We release 18.12.01 as the first release of R18.
> >   * That we make R18 our current stable branch, and so R17 the old one.
> >   * And finally that we freeze a new R20 branch.
> >
> > What do you people think?
> >
> > If it's OK with everybody could you handle it, or part of it if we don't
> > agree on all, Jacopo?
> >
> > Thanks
> >
> > Jaques
> >
> >
>


Re: I would like to contribute

2020-10-24 Thread Deepak Dixit
Thanks Madhu, now your email has been delivered to the dev list properly.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sat, Oct 24, 2020 at 12:24 PM Madhu Mohan 
wrote:

> Hi Deepak,
>
> I have subscribed already, sent an email to the dev group. Please let me
> know if I am added to subscribers list.
>
>
>
> Best Regards
> Madhu
>
> On Sat, 24 Oct 2020 at 14:20, Deepak Dixit  wrote:
>
>> Hi Madhu,
>>
>> Your message has been moderated, else it would not have reached this
>> Mailing List.
>>
>> Please subscribe to the mailing list, See why here
>> http://ofbiz.apache.org/mailing-lists.html.
>>
>> You will get better support, people can answer you on the ML. The wider
>> the
>> audience the better the answers you might get.
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> ofbiz.apache.org
>>
>>
>> On Sat, Oct 24, 2020 at 11:50 AM Madhu Mohan 
>> wrote:
>>
>>> Hi,
>>> I would like to add a billing plugin to Ofbiz. But before that I need
>>> certain information on the existing services which I don't find much
>>> information online. Can someone please help me.
>>>
>>> Best Regards
>>> Madhu
>>>
>>


Re: I would like to contribute

2020-10-24 Thread Deepak Dixit
Hi Madhu,

Your message has been moderated, else it would not have reached this
Mailing List.

Please subscribe to the mailing list, See why here
http://ofbiz.apache.org/mailing-lists.html.

You will get better support, people can answer you on the ML. The wider the
audience the better the answers you might get.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sat, Oct 24, 2020 at 11:50 AM Madhu Mohan 
wrote:

> Hi,
> I would like to add a billing plugin to Ofbiz. But before that I need
> certain information on the existing services which I don't find much
> information online. Can someone please help me.
>
> Best Regards
> Madhu
>


Re: Headless Commerce Plugin Implementation

2020-10-20 Thread Deepak Dixit
I think we should find some better way to handle this, we should check the
possibility to have separate plugins repository.
Its not a good idea to add each plugin in plugins repo, it will increase
size of ofbiz-plugins.

Kind Regards,
Deepak Dixit



On Tue, Oct 20, 2020 at 5:34 PM Pawan Verma 
wrote:

> Hi Ravi,
>
> I would suggest #2, create a branch from ofbiz_plugins fork, and create a
> new PR in WIP so that code changes are easily visible for review and
> contributors can suggest/request changes.
>
> We can also rewrite commit history before merging it to the official
> repository.
>
> HTH
> --
> Thanks & Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> http://www.hotwaxsystems.com
>
>
> On Tue, Oct 20, 2020 at 2:43 PM Ravi Lodhi  wrote:
>
> > Hello Devs,
> >
> > As the community is already aware that the planning effort to develop a
> > Headless commerce plugin is in discussion [1]. In this effort, we have
> > prepared documents to list down the OOTB OFBiz eCommerce feature set [2],
> > requirement specifications [3], and an API roadmap [4] to expose these
> > features. These documents are work in progress and will get refined as we
> > get more participation/feedback from the community. Meanwhile, I am
> > planning to start the implementation of the headless commerce plugin. I
> > think the OFBiz rest capabilities are now matured enough to start
> > implementing the API endpoints. We can start with the customer profile
> > endPoints which are straightforward before jumping to complex
> > functionalities.
> >
> > So to start the implementation which approach should I take -
> > 1. Should I create a separate git repo from my Github account for the
> > headless commerce plugins and start working on it until we have something
> > in good shape?
> >  or
> > 2. Should I start directly by creating a branch from the ofbiz_plugins
> fork
> > and start implementing it?
> >
> > What would be the best approach such that the community can collaborate
> on
> > the implementation?
> >
> > [1] https://markmail.org/thread/7rdoepdc4sj54wpm
> > [2]
> >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/WIP%3A+OOTB+OFBiz+eCommerce+Feature+Set
> > [3]
> >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/WIP%3A+Headless+Commerce+Requirement+Specification
> > [4]
> >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/WIP%3A+Headless+Commerce+%28OFBiz%29+-+API+Roadmap
> >
> >
> > Kind Regards,
> > --
> > Ravi Lodhi
> >
>


Re: [Question] prioritise pending jobs

2020-10-14 Thread Deepak Dixit
Hi Lalit,

Have you explored the jobSandbox.priority field?

Please refer following task for more detail, it seems this will fulfill
your requirement
https://issues.apache.org/jira/browse/OFBIZ-10865


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Wed, Oct 14, 2020 at 5:15 PM Lalit Dashora <
lalit.dash...@hotwaxsystems.com> wrote:

> Hi team,
>
> I was wondering about the scenario where I need to prioritise a few
> specific jobs.
>
> Suppose on an instance there are 10K jobs in PENDING status. Based on the
> server configuration the job pooler will pick and execute jobs. If I add
> one more job (runTime < nowTimeStamp) with the requirement to execute ASAP.
> But the job pooler picks this job after completing 10K jobs in FIFO manner.
>
> is there any way to prioritise jobs?
>
> Thanks and Regards,
> Lalit Dashora
>


Re: OFBiz REST implementation session #2 (10/07/2020)

2020-10-07 Thread Deepak Dixit
Thanks Girish for the informative session.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Wed, Oct 7, 2020 at 4:04 PM Deepak Dixit  wrote:

> Thanks Girissh for update.
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Tue, Oct 6, 2020 at 7:45 PM Girish Vasmatkar <
> girish.vasmat...@hotwaxsystems.com> wrote:
>
>> Hi All
>>
>> Please note the meeting details for tomorrow's session -
>>
>> Topic: REST Session #2
>> Time: Oct 7, 2020 04:00 PM Mumbai, Kolkata, New Delhi, 12:30 PM CET
>>
>> Join Zoom Meeting
>> https://us04web.zoom.us/j/2504311919?pwd=WHpkS2pCOEVNRi85Znczc2lMeHYvQT09
>>
>> Meeting ID: 250 431 1919
>> Passcode: 4jmxz0
>>
>> I have also prepared a POSTMAN collection
>> <https://www.postman.com/collection/> with API request examples that I'll
>> be walking you through. You can import it on your local workspace. Please
>> follow the link below.
>>
>> https://www.getpostman.com/collections/5ef56c4f090b715112bc
>>
>> Best,
>> Girish
>>
>> On Wed, Sep 30, 2020 at 9:07 PM Girish Vasmatkar <
>> girish.vasmat...@hotwaxsystems.com> wrote:
>>
>> > Hi Everyone!
>> >
>> > Please find details of the next session I am planning to hold on OFBiz
>> > REST implementation. This will have some hands-on examples that will
>> help
>> > everyone using it.
>> >
>> > Date :  10/07/2020
>> > Time :  4 PM IST, 12:30 PM CET
>> > Meeting URL : TBD, I will send the invite link the day before.
>> > Agenda :
>> >
>> > 1. Preconfigured Resources (Resources that come OTB)
>> >
>> >-
>> >
>> >Authentication Token Generating Resource (How to invoke and example
>> >usage)
>> >-
>> >
>> >   POST /auth/token
>> >   -
>> >
>> >Exportable Services Resource (How to call services with export=true
>> >via REST interface with example usage)
>> >-
>> >
>> >   GET | POST | PUT | DELETE | PATCH /services/{serviceName}
>> >   -
>> >
>> >   GET vs POST service in parameters difference. How to invoke
>> service
>> >   defined as GET vs POST | POST | PATCH.
>> >   -
>> >
>> >OpenAPI Resource
>> >-
>> >
>> >   GET /openapi.json
>> >   -
>> >
>> >   GET /openapi.yaml
>> >   -
>> >
>> >WADL Resource (WADL is to REST as  WSDL is to SOAP)
>> >-
>> >
>> >   GET /application.wadl
>> >
>> > 2.  Standard API responses supported for various use cases (with
>> examples)
>> > and how to interpret them.
>> >
>> >-
>> >
>> >HTTP 200 OK
>> >-
>> >
>> >HTTP 400 Bad Request
>> >-
>> >
>> >HTTP 401 Unauthorized
>> >-
>> >
>> >HTTP 403 Forbidden
>> >-
>> >
>> >HTTP 422 Unprocessable Entity
>> >-
>> >
>> >HTTP 405 Method Not Allowed
>> >-
>> >
>> >HTTP 406 Not Acceptable
>> >-
>> >
>> >HTTP 415 Unsupported Media Type
>> >
>> > 3. Content Negotiation (JSON)
>> >
>> >-
>> >
>> >Accept : application/json
>> >-
>> >
>> >Content-Type : application/json
>> >
>> > 4. Q session
>> >
>> > Best,
>> > Girish Vasmatkar
>> >
>> >
>> >
>>
>


Re: OFBiz REST implementation session #2 (10/07/2020)

2020-10-07 Thread Deepak Dixit
Thanks Girissh for update.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Oct 6, 2020 at 7:45 PM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi All
>
> Please note the meeting details for tomorrow's session -
>
> Topic: REST Session #2
> Time: Oct 7, 2020 04:00 PM Mumbai, Kolkata, New Delhi, 12:30 PM CET
>
> Join Zoom Meeting
> https://us04web.zoom.us/j/2504311919?pwd=WHpkS2pCOEVNRi85Znczc2lMeHYvQT09
>
> Meeting ID: 250 431 1919
> Passcode: 4jmxz0
>
> I have also prepared a POSTMAN collection
> <https://www.postman.com/collection/> with API request examples that I'll
> be walking you through. You can import it on your local workspace. Please
> follow the link below.
>
> https://www.getpostman.com/collections/5ef56c4f090b715112bc
>
> Best,
> Girish
>
> On Wed, Sep 30, 2020 at 9:07 PM Girish Vasmatkar <
> girish.vasmat...@hotwaxsystems.com> wrote:
>
> > Hi Everyone!
> >
> > Please find details of the next session I am planning to hold on OFBiz
> > REST implementation. This will have some hands-on examples that will help
> > everyone using it.
> >
> > Date :  10/07/2020
> > Time :  4 PM IST, 12:30 PM CET
> > Meeting URL : TBD, I will send the invite link the day before.
> > Agenda :
> >
> > 1. Preconfigured Resources (Resources that come OTB)
> >
> >-
> >
> >Authentication Token Generating Resource (How to invoke and example
> >usage)
> >-
> >
> >   POST /auth/token
> >   -
> >
> >Exportable Services Resource (How to call services with export=true
> >via REST interface with example usage)
> >-
> >
> >   GET | POST | PUT | DELETE | PATCH /services/{serviceName}
> >   -
> >
> >   GET vs POST service in parameters difference. How to invoke service
> >   defined as GET vs POST | POST | PATCH.
> >   -
> >
> >OpenAPI Resource
> >-
> >
> >   GET /openapi.json
> >   -
> >
> >   GET /openapi.yaml
> >   -
> >
> >WADL Resource (WADL is to REST as  WSDL is to SOAP)
> >-
> >
> >   GET /application.wadl
> >
> > 2.  Standard API responses supported for various use cases (with
> examples)
> > and how to interpret them.
> >
> >-
> >
> >HTTP 200 OK
> >-
> >
> >HTTP 400 Bad Request
> >-
> >
> >HTTP 401 Unauthorized
> >-
> >
> >HTTP 403 Forbidden
> >-
> >
> >HTTP 422 Unprocessable Entity
> >-
> >
> >HTTP 405 Method Not Allowed
> >-
> >
> >HTTP 406 Not Acceptable
> >-
> >
> >HTTP 415 Unsupported Media Type
> >
> > 3. Content Negotiation (JSON)
> >
> >-
> >
> >Accept : application/json
> >-
> >
> >Content-Type : application/json
> >
> > 4. Q session
> >
> > Best,
> > Girish Vasmatkar
> >
> >
> >
>


Re: Welcome Swapnil Shah as new PMC member!!

2020-09-27 Thread Deepak Dixit
Many many congrats Swapnil 

Kind Regards,
Deepak Dixit



On Sat, Sep 26, 2020 at 8:14 PM Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Congratulations Swapnil!
> Best regards,
> Pranay Pandey
>
>
> On Sat, Sep 26, 2020 at 7:10 PM Swapnil Shah <
> swapnil.s...@hotwaxsystems.com>
> wrote:
>
> > Thank you everyone for your continuous support and kind wishes.
> >
> > Thanks,
> > Swapnil
> >
> > > -Original Message-
> > > From: Ashish Vijaywargiya 
> > > Sent: 18 September 2020 12:56
> > > To: dev@ofbiz.apache.org
> > > Subject: Welcome Swapnil Shah as new PMC member!!
> > >
> > > The OFBiz PMC has invited Swapnil Shah to become a member of the
> > committee
> > > and we are glad to announce that he has accepted the nomination.
> > >
> > > On behalf of the OFBiz PMC, welcome on board Swapnil!
> >
>


Re: Welcome Mridul Pathak as new PMC member!!

2020-09-26 Thread Deepak Dixit
Many many congrats Mridul 

Thanks & Regards
—
Deepak Dixit

On Sat, 26 Sep 2020 at 6:09 PM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Many congratulations Mridul!
>
>
>
> Best regards,
>
> Pranay Pandey
>
>
>
>
>
> On Fri, Sep 18, 2020 at 12:55 PM Ashish Vijaywargiya 
>
> wrote:
>
>
>
> > The OFBiz PMC has invited Mridul Pathak to become a member of the
> committee
>
> > and we are glad to announce that he has accepted the nomination.
>
> >
>
> > On behalf of the OFBiz PMC, welcome on board Mridul!
>
> >
>
> --
Thanks & Regards
—
Deepak Dixit


Re: [PROPOSAL] Separate login service for API calls

2020-09-26 Thread Deepak Dixit
Hi Girish,

I think it's a good idea to use a separate login method for REST to
avoid sessions.

We have *userLogin* service that do the login related work, so we can have
separate wrapper method for REST like LoginWorker.login()


Kind Regards,
Deepak Dixit


On Sat, Sep 26, 2020 at 2:54 PM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hello
> I am not sure if we can talk about sessions when we're talking about REST.
> The REST implementation is mapping Resources with OFBiz services and the
> services are executing in a context using "userLogin" and that is all the
> REST implementation is doing. Extracting userLogin from token and supplying
> to the OFBiz service.
>
> The session you get from running userLogin service is not getting used for
> subsequent API calls made using JWT token because usual OFBiz flow
> (ContextFilter, ControlServlet) don't come in picture. Therefore, I feel,
> as far as REST implementation is concerned, it is better to create a
> separate service that does just authentication and doesn't create sessions.
>
> Also, a properly designed REST endpoint without cookies means no CSRF.
>
> Best,
> Girish
> HotWax System
>
>
>
>
>
>
>
>
> On Sat, Sep 26, 2020 at 2:04 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Thanks Gavin,
> >
> > I'd just note that in this case your are not protected from CSRF.
> > Fortunately the REST effort is only in trunk. And, as explained in
> > security.properties, in trunk we can use
> > org.apache.ofbiz.security.CsrfDefenseStrategy in such case.
> >
> > Jacques
> >
> > Le 26/09/2020 à 07:38, Gavin Mabie a écrit :
> > > Sessions are extremely useful and even indispensable for an ERP system
> > > where statefullnes are critical for audit trail purposes. Stateless
> > > requests don't care about transactions beyond the actual
> > request/response.
> > > Besides, sessions are only problematic when a new session gets created
> > for
> > > each REST API request. You can prevent this by setting the cookie
> > SameSite
> > > property to "None".  That way sessions and REST request can happily
> live
> > > together.
> > >
> > > On Sat, Sep 26, 2020 at 6:35 AM Girish Vasmatkar <
> > > girish.vasmat...@hotwaxsystems.com> wrote:
> > >
> > >> Hi
> > >>
> > >> I am using userLogin service to authenticate users before generating
> > auth
> > >> tokens for REST API and GraphQL calls. However, I figured that a
> > session is
> > >> also getting created and returned in response which is defeating the
> > >> purpose of having an API in place. Even though that session is not
> > getting
> > >> used anywhere when subsequent calls are made using the token, I still
> > think
> > >> it is an extra session lying around in tomcat's session cache.
> > >>
> > >> I propose to implement a new basic userLogin service
> > (basicAuthUserLogin)
> > >> that would just do username/password matching and be done with it
> > without
> > >> ever calling request.getSession(). This will ensure that APIs are
> > stateless
> > >> and no session is generated.
> > >>
> > >> Anything else you think should be part of the new service instead of
> > just
> > >> username/password validation?
> > >>
> > >> Best,
> > >> Girish
> > >> HotWax Systems
> > >>
> >
>


Re: [VOTE] to use Lombok inside OFBiz

2020-09-08 Thread Deepak Dixit
-1

https://medium.com/@vgonzalo/dont-use-lombok-672418daa819

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Sep 8, 2020 at 5:11 PM Nicola Mazzoni 
wrote:

> -1
>
> Lombok helps reduce code when using an orm.  Fortunately ofbiz uses the
> generic value;  a db record is a map and not an object 
>
> Il mar 8 set 2020, 09:37 Jacques Le Roux  ha
> scritto:
>
> > Hi,
> >
> > Following our discussions about using Lombok inside OFBiz, as it's not
> > clear if we should, here is a vote to decide about that.
> >
> > The question is: "should we use Lombok inside OFBiz?"
> >
> > Please cast your vote:
> >
> > [+1]to use Lombok inside OFBiz
> > [0] to abstain
> > [-1]to not use Lombok inside OFBiz
> >
> > This vote will be open for a week.
> >
> > Thanks
> >
> > Jacques
> >
> >
>


Re: Headless Commerce Plugin for OFBiz

2020-08-20 Thread Deepak Dixit
Hi Arpit,

Sounds like a plan, As now ofbiz supports rest, so we can think of headless
commerce.

I think you need to work on the B2C ordering process, as per current
implementation it's tightly coupled with ShoppingCart.
All the e-commerce related processes are bound with ShoppingCart and OFBiz
use session to maintain shoppingCart.



Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Aug 18, 2020 at 8:52 PM Arpit Mor 
wrote:

> Hi Devs,
>
> Hope everyone is safe and healthy amidst Covid-19 pandemic
>
> Most of you might have heard about “Headless Commerce” or API first
> commerce, but in case you haven’t, here is a brief summary of what headless
> commerce is and why it is the need of the hour.
>
> What is Headless Commerce?
> In its simplest form, headless commerce is the decoupling of the
> presentation layer (frontend) of an eCommerce from backend such that both
> are able to function independently. This decoupling is achieved by using
> APIs to expose core backend functionalities.
>
> Why Headless Commerce?
> Today, customers are consuming context from various channels and
> touch-points. Gone are the days when customers primarily needed to visit a
> website to buy online. With the rise of smartphones and the Internet of
> Things (IoT), customers can now shop from multiple channels like IoT
> devices, progressive web apps (PWAs), social media platforms, mobile apps,
> smart assistants, smart TV, kiosks, and many more.
> By decoupling frontend from backend - user interface, social commerce,
> mobile apps, IoT, and many more – can be changed or updated individually,
> without interfering with backend. Data is available to separate frontend
> applications via API calls and the backend runs invisibly in the
> background.
>
> Benefits of Headless Commerce
> Unlimited Channels and Touchpoints: With API first Headless Commerce,
> integration with the new channels and touchpoints becomes easy, economical,
> and quick.
>
> Innovation and Engaging User Experience: With traditional monolithic
> Commerce, making user-centric changes to your website requires both a front
> and backend transformation. But with headless commerce, all the
> frontend/app developers have to focus on is user experience,
> personalization, and consistency without having to worry about changes to
> the backend.
>
> Easy-to-Manage Integrations: Headless commerce not only includes providing
> API support to the frontend, but it also includes communication between
> various components (like ERP, WMS, OMS, CRM, POS, etc.) via APIs. This will
> reduce the complexity of the integration and its maintenance.
>
> Business Agility & less time to market: Companies must be able to respond
> quickly to new market opportunities by constantly releasing new features.
> In traditional commerce, each component is tightly coupled with another
> which makes changes a complex task. But with Headless commerce different
> components communicate via APIs, which make changes to one component easy
> without having to worry about changes to other components.
>
> I’d like to put forward a suggestion for developing a headless commerce
> plugin, to keep the competitive edge of OFBiz with the rapidly changing
> technological trends by exposing core backend functionalities via APIs (The
> REST capabilities are already added to OFBiz recently).
>
> Looking forward to suggestions and feedback.
>
> Thanks & Regards
> Arpit Mor
>


Re: Move 'SecurityPermission' data to seed data files

2020-08-04 Thread Deepak Dixit
IMO SecurityPermission data should be moved to Seed data,
and SecurityGroup and SecurityGroupPermission data is part of demo data

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Fri, Jul 31, 2020 at 5:43 PM Priya Sharma 
wrote:

> Hello All,
>
> As per discussion on
> https://issues.apache.org/jira/browse/OFBIZ-10575, we would like to
> confirm whether all security data (i.e SecurityPermission,
> SecurityGroupPermission and hence SecurityGroup) be moved to seed data
> files or only SecurityPermission data.
>
> Is there any particular use-case that may be harmed or any other
> potential security threat that may arise with this change?
>
> Please provide your feedback, concerns, or suggestions.
>
> --
> Best Regards,
> Priya
>


Re: Welcome Pawan Verma as new PMC member

2020-07-28 Thread Deepak Dixit
Many Many congrats Pawan..!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Jul 28, 2020 at 2:18 PM Pritam Kute 
wrote:

> Congratulations Pawan!
>
> Kind Regards,
> --
> Pritam Kute
>
>
> On Tue, Jul 28, 2020 at 2:16 PM Girish Vasmatkar <
> girish.vasmat...@hotwaxsystems.com> wrote:
>
> > Many congratulations Pawan.
> >
> > Best,
> > Girish
> >
> > On Tue, Jul 28, 2020 at 2:10 PM Devanshu Vyas  >
> > wrote:
> >
> > > Many many Congratulations Pawan!!
> > >
> > >
> > > Thanks & Regards,
> > > Devanshu Vyas.
> > >
> > >
> > > On Tue, Jul 28, 2020 at 1:53 PM Aditya Sharma  >
> > > wrote:
> > >
> > > > Felicitation Pawan!!
> > > >
> > > > Thanks and Regards,
> > > > Aditya Sharma
> > > >
> > > > On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux <
> > > > jacques.le.r...@les7arts.com> wrote:
> > > >
> > > > > The OFBiz PMC has invited Pawan Verma to become member of the
> > committee
> > > > > and we are glad to announce that he has accepted the nomination.
> > > > >
> > > > > On behalf of the OFBiz PMC, welcome on board Pawan!
> > > > >
> > > > >
> > > >
> > >
> >
>


Re: Welcome Arun Patidar as new PMC member

2020-07-06 Thread Deepak Dixit
Many Many Congratulations Arun !!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jul 6, 2020 at 2:07 PM Mohammad Kathawala <
mohammad.kathaw...@hotwaxsystems.com> wrote:

> Congratulations Arun!
>
> Kind Regards,
> Mohammad Kathawala
> Senior Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> cell: +91-7772858789
> office: 0731-409-3684
> http://www.hotwaxsystems.com
>
>
> On Mon, Jul 6, 2020 at 12:30 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Arun Patidar to become member of the committee
> > and we are glad to announce that he has accepted the nomination.
> >
> > On behalf of the OFBiz PMC, welcome on board Arun!
> >
> >
>


Re: Welcome Aditya Sharma as new PMC member

2020-07-05 Thread Deepak Dixit
Many Many Congratulations Aditya !!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jul 6, 2020 at 9:47 AM Pritam Kute 
wrote:

> Congratulations Aditya.
>
> Kind Regards,
> --
> Pritam Kute
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> cell: +91 95793 66013
> http://www.hotwaxsystems.com
>
>
> On Sun, Jul 5, 2020 at 11:14 PM Pawan Verma  wrote:
>
> > Many congratulations Aditya!
> >
> > On Sun, Jul 5, 2020, 10:24 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com>
> > wrote:
> >
> > > The OFBiz PMC has invited Aditya Sharma to become member of the
> committee
> > > and we are glad to announce that he has accepted the nomination.
> > >
> > > On behalf of the OFBiz PMC, welcome on board Aditya!
> > >
> > >
> >
>


Re: Welcome Suraj Khurana as new PMC member

2020-07-05 Thread Deepak Dixit
Many Many Congratulations Suraj!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jul 6, 2020 at 9:45 AM Pritam Kute 
wrote:

> Congratulations Suraj
>
> Kind Regards,
> --
> Pritam Kute
>
>
> On Sat, Jul 4, 2020 at 5:53 PM Pawan Verma  wrote:
>
> > Many congratulations Suraj!
> > --
> > Thanks & Regards
> > Pawan Verma
> > ofbiz.apache.org
> >
> >
> > On Sat, Jul 4, 2020 at 5:22 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com>
> > wrote:
> >
> > > The OFBiz PMC has invited Suraj Khurana to become member of the
> committee
> > > and we are glad to announce that he has accepted the nomination.
> > >
> > > On behalf of the OFBiz PMC, welcome on board Suraj!
> > >
> > >
> >
>


Re: Add CHANGELOG.md file

2020-06-19 Thread Deepak Dixit
Here is the link for task
https://issues.apache.org/jira/browse/OFBIZ-11839

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Jun 18, 2020 at 10:22 AM Swapnil M Mane 
wrote:

> +1
>
> - Best regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Wed, Jun 17, 2020 at 11:23 AM Deepak Dixit  wrote:
>
> > Hi Dev,
> >
> > As we have already moved to git for the version control system, I propose
> > to add a changelog file to maintain the changelogs[1].
> > What is a changelog?
> >
> > A changelog is a file which contains a curated, chronologically ordered
> > list of notable changes for each version of a project.
> > Why keep a changelog?
> >
> > To make it easier for users and contributors to see precisely what
> notable
> > changes have been made between each release (or version) of the project.
> > Who needs a changelog?
> >
> > People do. Whether consumers or developers, the end users of software are
> > human beings who care about what's in the software. When the software
> > changes, people want to know why and how.
> >
> > We can have our own process to generate changelog, It may be either
> manual
> > entries, or some tool or using git log. We can discuss this
> independently.
> >
> > https://keepachangelog.com/en/1.0.0/
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
>


Add CHANGELOG.md file

2020-06-16 Thread Deepak Dixit
Hi Dev,

As we have already moved to git for the version control system, I propose
to add a changelog file to maintain the changelogs[1].
What is a changelog?

A changelog is a file which contains a curated, chronologically ordered
list of notable changes for each version of a project.
Why keep a changelog?

To make it easier for users and contributors to see precisely what notable
changes have been made between each release (or version) of the project.
Who needs a changelog?

People do. Whether consumers or developers, the end users of software are
human beings who care about what's in the software. When the software
changes, people want to know why and how.

We can have our own process to generate changelog, It may be either manual
entries, or some tool or using git log. We can discuss this independently.

https://keepachangelog.com/en/1.0.0/

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


Github PR template

2020-05-13 Thread Deepak Dixit
Hi Dev,

I think we should add the github PR request [1] template for ofbiz
repositories.
It will help to guide new contributors to follow our practices and we will
have a generic template for PR.

[1]
https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


Re: new widget

2020-05-06 Thread Deepak Dixit
Hi James,

We can achieve this using a decorator pattern, we can set the screen level
js file on screen and can be included in the header.

Am I missing something here?

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Wed, May 6, 2020 at 10:03 PM James Yong  wrote:

> Hi all,
>
> There are javascript files that only applies to a specific screen.
> While the javascript can be added via ftl templates, the Content Security
> Policy will need to be relaxed to allow inline scripts.
> Using requireJs is not an appropriate solution as there is little
> reusability between different screens.
>
> Propose a new  widget tag will add a script tag inside html
> head tag, or after body tag.
> e.g.
> 
> 
> 
>
> will render as:
> 
> 
> …
> 

Re: Add notice on previous repository

2020-05-05 Thread Deepak Dixit
+1

I think we can archive this as well
https://help.github.com/en/github/creating-cloning-and-archiving-repositories/archiving-repositories

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, May 4, 2020 at 8:54 PM Jacques Le Roux 
wrote:

> Le 04/05/2020 à 15:16, James Yong a écrit :
> > Hi all,
> >
> > I saw some recent PR from https://github.com/apache/ofbiz
> > Suggest to add a notice to indicate the repository is old and for user
> to use https://github.com/apache/ofbiz-framework instead.
> >
> > Regards,
> > James
> +1
>
> Jacques
>
>


Re: OFBIZ-9826 & "Duplicate Service ECA" warning

2020-05-04 Thread Deepak Dixit
Hi Jacques,

I think we need to check why we are getting false positives on
testIntegration, I also cross checked some of the warning and it seems
there is no duplicate seca rule.

There are no duplicate seca warning on ./gradlew loadAll or on ./gradlew
ofbiz


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, May 3, 2020 at 3:34 PM Jacques Le Roux 
wrote:

> Hi,
>
> With OFBIZ-9826 we have introduced a "Duplicate Service ECA" warning.
>
> I see a lot of them in log when running integration test[1].
>
> Is it not time to take care of removing those duplicates, or is it a side
> effect due to tests?
>
> Thanks
>
> [1]
> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1318/steps/shell_5/logs/stdio
>
> Jacques
>
>


Re: Welcome Rishi Solanki as new PMC member

2020-04-28 Thread Deepak Dixit
Many many congrats Rishi!!

Thanks & Regards
—
Deepak Dixit

On Tue, 28 Apr 2020 at 9:29 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Felicitations Rishi!
>
> Jacques
>
> Le 28/04/2020 à 17:46, Swapnil M Mane a écrit :
> > Many congratulations Rishi, welcome on board!
> >
> >
> > - Best regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Tue, Apr 28, 2020 at 7:53 PM Jacopo Cappellato <
> > jacopo.cappell...@gmail.com> wrote:
> >
> >> The OFBiz PMC has invited Rishi Solanki to become member of the
> committee
> >> and we are glad to announce that he has accepted the nomination.
> >>
> >> On behalf of the OFBiz PMC, welcome on board!
> >>
>
-- 
Thanks & Regards
—
Deepak Dixit


Re: Welcome Swapnil M Mane as new PMC member

2020-04-23 Thread Deepak Dixit
Welcome aboard  Swapnil M.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Apr 23, 2020 at 5:02 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> The OFBiz PMC has invited Swapnil M Mane to become member of the committee
> and we are glad to announce that he has accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome on board!
>
>


Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Deepak Dixit
Many Many Congratulations Girish!!


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Apr 23, 2020 at 10:46 AM Harsh Vijaywargiya <
harsh.vijaywarg...@hotwaxsystems.com> wrote:

> Many Congratulations Girish!!
>
> Thanks & Regards,
> Harsh
>
> On Thu, Apr 23, 2020 at 10:22 AM Devanshu Vyas 
> wrote:
>
> > Congratulations Girish!
> >
> > Thanks & Regards,
> > Devanshu Vyas.
> >
> >
> > On Wed, Apr 22, 2020 at 3:09 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > The OFBiz PMC has invited Girish to become a new committer and we are
> > > pleased  to announce that he has accepted.
> > >
> > > Girish is part of the community for near 2 years and has proposed
> several
> > > smart propositions notably related to security and GraphQL, but not
> only.
> > >
> > > Please join me in welcoming and congratulating Girish.
> > >
> > > Jacques
> > >
> > >
> > >
> >
>


Re: Welcome James Young as new PMC member

2020-04-22 Thread Deepak Dixit
Many Many congrats James!!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Apr 23, 2020 at 11:03 AM Devanshu Vyas 
wrote:

> Congratulations James!
>
> Thanks & Regards,
> Devanshu Vyas.
>
>
> On Wed, Apr 22, 2020 at 2:08 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited James Young to become member of the committee
> > and we are glad to announce that he has accepted the nomination.
> >
> > On behalf of the OFBiz PMC, welcome on board!
> >
> >
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.03

2020-04-21 Thread Deepak Dixit
+1



Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Apr 21, 2020 at 1:22 PM Michael Brohl 
wrote:

> +1
>
> ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.03 
> ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.03.zip
> sha check of file: apache-ofbiz-17.12.03.zip
> Using sha file: apache-ofbiz-17.12.03.zip.sha512
> apache-ofbiz-17.12.03.zip: E4E49620 661FA7B0 9BA4610E DC63B0CE E849DC3A
> 91536311 595ECD8C 5246C2F5 5751A339 9FFCCFFE 02F06CBD DEF8A589 06483077
> AC172AFC E945DC8B 0BE20AEC
> apache-ofbiz-17.12.03.zip: E4E49620 661FA7B0 9BA4610E DC63B0CE E849DC3A
> 91536311 595ECD8C 5246C2F5 5751A339 9FFCCFFE 02F06CBD DEF8A589 06483077
> AC172AFC E945DC8B 0BE20AEC
> sha checksum OK
>
> GPG verification output
> gpg: Signature made Mon Apr 20 10:42:14 2020 CEST using RSA key ID 847AF9E0
> gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> " [ultimate]
>
> ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.03/apache-ofbiz-17.12.03
>  ./gradle/init-gradle-wrapper.sh
>   === Prepare operation ===
> /Users/mbrohl/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.03/apache-ofbiz-17.12.03/gradle/wrapper/gradle-wrapper.jar
>
> not found, we download it
>   === Download gradle-wrapper.jar ===
>   === Download gradle-wrapper.properties ===
>   === Control downloaded files ===
> gradle/wrapper/gradle-wrapper.jar: OK
> gradle/wrapper/gradle-wrapper.properties: OK
> gradlew: OK
>
> ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.03/apache-ofbiz-17.12.03
>  ./gradlew loadAll testIntegration
>
> ...
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 20.04.20 um 11:03 schrieb Jacopo Cappellato:
> > This is the vote thread to release a new bug fix release for the
> > release17.12 branch. This new release, "Apache OFBiz 17.12.03" will
> > supersede the previous release from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-17.12.03.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.03.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.03.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 17.12.03
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
> >
>
>


Re: [VOTE] [RESULT] Apache OFBiz 17.12.02

2020-04-20 Thread Deepak Dixit
+1 sounds good to me.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Apr 20, 2020 at 12:58 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> ouch, thank you for catching that Deepak.
> Here is my proposal:
> 1) I prepare the new release files for 17.12.03 and we vote on it
> 2) we leave 17.12.02 in our records and archive (because we have formally
> published it, so it is a release) but we do not announce it
> 3) we will announce the new 17.12.03 release only, with a notice about the
> 17.12.02 gap.
>
> What do you think?
>
> Jacopo
>
>
> On Mon, Apr 20, 2020 at 8:04 AM Deepak Dixit  wrote:
>
> > Hi Jacopo,
> > I think we need to do vote release once again,
> > Blocker: https://issues.apache.org/jira/browse/OFBIZ-11601
> >
> > We need to
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Fri, Apr 17, 2020 at 12:34 PM Jacopo Cappellato <
> > jacopo.cappell...@gmail.com> wrote:
> >
> > > The vote to release Apache OFBiz 17.12.02 is successful with 11
> positive
> > > (i.e. "+1") votes, of which 5 binding votes.
> > >
> > > Thank you everyone for the participation. I am going to proceed with
> the
> > > next steps and we will be announcing the release in a couple of days.
> > >
> > > Best regards,
> > >
> > > Jacopo
> > >
> > > On Fri, Apr 10, 2020 at 12:05 PM Jacopo Cappellato <
> > > jacopo.cappell...@gmail.com> wrote:
> > >
> > > > This is the vote thread to release a new bug fix release for the
> > > > release17.12 branch. This new release, "Apache OFBiz 17.12.02" will
> > > > supersede the previous release from the same branch.
> > > >
> > > > The release files can be downloaded from here:
> > > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > > > and are:
> > > > * apache-ofbiz-17.12.02.zip
> > > > * KEYS: text file with keys
> > > > * apache-ofbiz-17.12.02.zip.asc: the detached signature file
> > > > * apache-ofbiz-17.12.02.zip.sha512: checksum file
> > > >
> > > > Please download and test the zip file and its signatures (for
> > > instructions
> > > > on testing the signatures see
> > > http://www.apache.org/info/verification.html
> > > > ).
> > > >
> > > > Vote:
> > > > [ +1] release as Apache OFBiz 17.12.02
> > > > [ -1] do not release
> > > >
> > > > This vote will be open for 5 days.
> > > >
> > > > For more details about this process please refer to
> > > > http://www.apache.org/foundation/voting.html
> > > >
> > > > Best Regards,
> > > >
> > > > Jacopo
> > > >
> > >
> >
>


Re: [VOTE] [RESULT] Apache OFBiz 17.12.02

2020-04-20 Thread Deepak Dixit
Hi Jacopo,
I think we need to do vote release once again,
Blocker: https://issues.apache.org/jira/browse/OFBIZ-11601

We need to
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Fri, Apr 17, 2020 at 12:34 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> The vote to release Apache OFBiz 17.12.02 is successful with 11 positive
> (i.e. "+1") votes, of which 5 binding votes.
>
> Thank you everyone for the participation. I am going to proceed with the
> next steps and we will be announcing the release in a couple of days.
>
> Best regards,
>
> Jacopo
>
> On Fri, Apr 10, 2020 at 12:05 PM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> > This is the vote thread to release a new bug fix release for the
> > release17.12 branch. This new release, "Apache OFBiz 17.12.02" will
> > supersede the previous release from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-17.12.02.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.02.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.02.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 17.12.02
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
> >
>


Re: service with entity engine= auto for invoke = read

2020-04-17 Thread Deepak Dixit
Hi Vinay,

You can use the performFind service to fetch the data from entities without
writing additional code


Kind Regards,
Deepak Dixit
DIRECTOR OF PRODUCT ENGINEERING
mobile: +91 9826754548
email: deepak.di...@hotwax.co
*www.hotwax.co <http://www.hotwax.co/>*


On Fri, Apr 17, 2020 at 3:02 PM Vinay T M  wrote:

> Hi,
> I am new to ofbiz, my question is how to create service for read
> operation(fetch all from database)?
> is it possible without writing additional java service ?
> please Help
>
> Reards,
> Vinay T M
>


Re: GraphQL API for OFBiz

2020-03-27 Thread Deepak Dixit
Great initiative Girish.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Mar 26, 2020 at 9:18 PM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi All
>
> I'm planning an introduction of the OFBiz-GraphQL component that we have
> developed so far. Please find below the hangout meet details -
>
> Date : 03/27/2020 9:00 PM IST, 11:30 AM EST, 3:30 PM GMT.
> Join Hangout Meet : https://meet.google.com/gja-jdwt-wpi
> Join By Phone : +1 661-237-5173‬ PIN: ‪585 477 050‬#
>
> Meeting agenda -
>
>- GraphQL briefing
>   - Queries
>   - Mutations
>- OFBiz-GraphQL component
>   - Architecture
>   - Entity Fetchers
>   - Service Fetchers
>- What Next
>   - Pagination
>   - Interface
>   - Batching
>   - Subscriptions
>
>
> Best Regards
> Girish Vasmatkar
>
>
>
> On Wed, Feb 12, 2020 at 7:04 PM Girish Vasmatkar <
> girish.vasmat...@hotwaxsystems.com> wrote:
>
> > Thanks Pierre.
> >
> > Here's the ticket for the same. I'll keep posting updates to it.
> >
> > https://issues.apache.org/jira/browse/OFBIZ-11347
> >
> > Best,
> > Girish
> >
> > On Mon, Feb 10, 2020 at 4:48 PM Pierre Smits 
> > wrote:
> >
> >> Hi Girish,
> >>
> >> Thank you for making the greater OFBiz community aware of this
> endeavour.
> >> I
> >> welcome such initiatives as it increases the appeal of our main product.
> >> Not only does it increase the appeal of OFBiz for (potential) adopters,
> >> but
> >> it may also lead to more parties willing to contribute.
> >>
> >> Best regards,
> >>
> >> Pierre Smits
> >> *Proud* *contributor* (but without privileges)* of* Apache OFBiz
> >> <https://ofbiz.apache.org/>, since 2008
> >>
> >> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> >> *Apache Directory <https://directory.apache.org>, PMC Member*
> >> Apache Incubator <https://incubator.apache.org>, committer
> >> Apache Steve <https://steve.apache.org>, committer
> >>
> >>
> >> On Mon, Feb 10, 2020 at 11:40 AM Girish Vasmatkar <
> >> girish.vasmat...@hotwaxsystems.com> wrote:
> >>
> >> > Hello
> >> >
> >> > I had been working on adding GraphQL support to OFBiz and could come
> up
> >> > with something that might be of interest to the community. Wanted to
> >> gauge
> >> > community's interest on the same.
> >> >
> >> > Essentially, I have first tried to enable GraphQL support such that
> >> OFBiz
> >> > is able to server GraphQL queries, mutations and subscriptions as per
> >> the
> >> > GraphQL specification (http://spec.graphql.org/). The Java GraphQL
> >> library
> >> > mostly takes care of it.
> >> >
> >> > The other major part is writing GraphQL schema and I have tried to
> >> include
> >> > both SDL and programmatic approach to generate the schema. Included a
> >> demo
> >> > query in the SDL approach to showcase hw OFBiz can server GraphQL
> >> requests.
> >> >
> >> > This is the part that I feel needs more work in order to make it more
> >> > generalised and I am still working on this.
> >> >
> >> > I have included GraphiQL(https://github.com/graphql/graphiql) and
> >> > Playground (https://github.com/prisma-labs/graphql-playground) as two
> >> > visual editor tools as well.
> >> >
> >> > Here's the github link for the plug in.
> >> > https://github.com/hotwax/ofbiz-graphql
> >> >
> >> > Any feedback, questions, concerns or suggestions are welcome.
> >> >
> >> > Best,
> >> > Girish
> >> >
> >>
> >
>


Re: [ofbiz-plugins] 01/02: Improved: "auth" should be true for all the request url used for Application components

2020-03-17 Thread Deepak Dixit
Hi Jacques,

Something went wrong with commit, In this commit controller.xml deleted.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Mar 17, 2020 at 1:18 PM  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> jleroux pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>
> commit 9f87efe7ba035febcb5aa4f827a62de3316ecbab
> Author: Jacques Le Roux 
> AuthorDate: Mon Mar 16 11:31:48 2020 +0100
>
> Improved: "auth" should be true for all the request url used for
> Application
> components
>
> (OFBIZ-4956)
>
> Put back getAssociatedStateList requesdt in ecommerce to auth="false"
> to allow
> the anonymous flow
>
> Thanks: Deepak for spotting an reporting the issue
> ---
>  ecommerce/webapp/ecommerce/WEB-INF/controller.xml | 2008
> -
>  1 file changed, 2008 deletions(-)
>
> diff --git a/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> b/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> deleted file mode 100644
> index 27a0383..000
> --- a/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> +++ /dev/null
> @@ -1,2008 +0,0 @@
> -
> -
> -
> -http://www.w3.org/2001/XMLSchema-instance;
> -xmlns="http://ofbiz.apache.org/Site-Conf; xsi:schemaLocation="
> http://ofbiz.apache.org/Site-Conf
> http://ofbiz.apache.org/dtds/site-conf.xsd;>
> -OFBiz: eCommerce Controller Configuration
> File
> -/error/error.jsp
> -
> - class="org.apache.ofbiz.webapp.event.JavaEventHandler"/>
> - class="org.apache.ofbiz.webapp.event.GroovyEventHandler"/>
> - class="org.apache.ofbiz.webapp.event.SOAPEventHandler"/>
> - class="org.apache.ofbiz.webapp.event.ServiceEventHandler"/>
> - class="org.apache.ofbiz.webapp.event.ServiceMultiEventHandler"/>
> - class="org.apache.ofbiz.webapp.event.SimpleEventHandler"/>
> - class="org.apache.ofbiz.webapp.event.RomeEventHandler"/>
> -
> - class="org.apache.ofbiz.webapp.view.JspViewHandler"/>
> - class="org.apache.ofbiz.webapp.view.HttpViewHandler"/>
> - class="org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler"/>
> - class="org.apache.ofbiz.content.view.SimpleContentViewHandler"/>
> -
> -
> -
> -
> - path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="autoLoginCheck"/>
> - path="org.apache.ofbiz.marketing.tracking.TrackingCodeEvents"
> invoke="checkTrackingCodeCookies"/>
> - path="org.apache.ofbiz.product.product.ProductEvents"
> invoke="setDefaultStoreSettings"/>
> - path="org.apache.ofbiz.order.shoppinglist.ShoppingListEvents"
> invoke="createGuestShoppingListCookies"/>
> - path="org.apache.ofbiz.order.shoppinglist.ShoppingListEvents"
> invoke="restoreAutoSaveList"/>
> -
> -
> -
> -
> -
> - path="org.apache.ofbiz.webapp.control.ExternalLoginKeysManager"
> invoke="checkExternalLoginKey"/>
> - path="org.apache.ofbiz.ecommerce.misc.ThirdPartyEvents"
> invoke="setAssociationId"/>
> - path="org.apache.ofbiz.marketing.tracking.TrackingCodeEvents"
> invoke="checkTrackingCodeUrlParam"/>
> - path="org.apache.ofbiz.marketing.tracking.TrackingCodeEvents"
> invoke="checkPartnerTrackingCodeUrlParam"/>
> - path="org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents"
> invoke="keepCartUpdated"/>
> - path="org.apache.ofbiz.webapp.control.LoginWorker" invoke="autoLoginCheck"/>
> -
> -
> -
> -
> -
> -
> - path="org.apache.ofbiz.ecommerce.misc.ThirdPartyEvents"
> invoke="updateAssociatedDistributor"/>
> - path="org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents"
> invoke="keepCartUpdated"/>
> -
> - path="org.apache.ofbiz.order.shoppinglist.ShoppingListEvents"
> invoke="restoreAutoSaveList"/>
> -
> - path="org.apache.ofbiz.order.shoppinglist.ShoppingListEvents"
> invoke="saveCartToAutoSaveList"/>
> - path="org.apache.ofbiz.order.shoppinglist.ShoppingListEvents"
> invoke="clearGuestShoppingListCookies"/>
> -
> -
> -
> -
> -
> -
> -
&g

Re: [ofbiz-plugins] branch trunk updated: Improved: "auth" should be true for all the request url used for Application components

2020-03-16 Thread Deepak Dixit
Like add Billing/shipping address while  anon checkout, New customer
registration etc.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Mar 16, 2020 at 1:14 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> Yes, I wondered about that too, but in which case/s do you think
> getAssociatedStateList can be requested w/o being authenticated?
>
> Thanks
>
> Jacques
> Le 16/03/2020 à 06:49, Deepak Dixit a écrit :
>
> Hi Jacques,
>
> I think we can't make auth true for getAssociatedStateList, this will
> break the anon checkout flow.
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Sat, Mar 14, 2020 at 1:19 PM  wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> jleroux pushed a commit to branch trunk
>> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>>
>>
>> The following commit(s) were added to refs/heads/trunk by this push:
>>  new e72e134  Improved: "auth" should be true for all the request url
>> used for Application components
>> e72e134 is described below
>>
>> commit e72e1348c13f892cfbd3ffdb78f536c4e4aa6b68
>> Author: Jacques Le Roux 
>> AuthorDate: Sat Mar 14 08:49:54 2020 +0100
>>
>> Improved: "auth" should be true for all the request url used for
>> Application
>> components
>>
>> (OFBIZ-4956)
>>
>> Currently there are some URLs present in application components with
>> auth="false". So anyone can hit these URLs and access these resources
>> without
>> authorization.
>>
>> I think all the URLs should be secure with auth="true"
>>
>> Thanks: Amardeep Singh Jhajj for report and initial fix
>> ---
>>  ecommerce/webapp/ecommerce/WEB-INF/controller.xml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> b/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> index 5f7031c..27a0383 100644
>> --- a/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> +++ b/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> @@ -1605,7 +1605,7 @@ under the License.
>>  
>>
>>  
>> -
>> +
>>  
>>  
>>  
>>
>>


Re: [ofbiz-plugins] branch trunk updated: Improved: "auth" should be true for all the request url used for Application components

2020-03-15 Thread Deepak Dixit
Hi Jacques,

I think we can't make auth true for getAssociatedStateList, this will break
the anon checkout flow.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sat, Mar 14, 2020 at 1:19 PM  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> jleroux pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>
>
> The following commit(s) were added to refs/heads/trunk by this push:
>  new e72e134  Improved: "auth" should be true for all the request url
> used for Application components
> e72e134 is described below
>
> commit e72e1348c13f892cfbd3ffdb78f536c4e4aa6b68
> Author: Jacques Le Roux 
> AuthorDate: Sat Mar 14 08:49:54 2020 +0100
>
> Improved: "auth" should be true for all the request url used for
> Application
> components
>
> (OFBIZ-4956)
>
> Currently there are some URLs present in application components with
> auth="false". So anyone can hit these URLs and access these resources
> without
> authorization.
>
> I think all the URLs should be secure with auth="true"
>
> Thanks: Amardeep Singh Jhajj for report and initial fix
> ---
>  ecommerce/webapp/ecommerce/WEB-INF/controller.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> b/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> index 5f7031c..27a0383 100644
> --- a/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> +++ b/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> @@ -1605,7 +1605,7 @@ under the License.
>  
>
>  
> -
> +
>  
>  
>  
>
>


Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Deepak Dixit
+1 Swapnil

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Feb 27, 2020 at 1:48 PM Swapnil M Mane 
wrote:

> Hi team,
> Should we move these Git notification to notificati...@ofbiz.apache.org
> list [1] that we created in the past to avoid notification traffic on dev
> list, thoughts?
>
> [1] https://s.apache.org/0jdhc
>
>
> Best regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Wed, Feb 26, 2020 at 3:24 PM GitBox  wrote:
>
> > PierreSmits commented on issue #1: Improved: widget-theme.xsd typos
> > (OFBIZ-11421)
> > URL: https://github.com/apache/ofbiz-site/pull/1#issuecomment-591338641
> >
> >
> >Done.
> >
> > 
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > For queries about this service, please contact Infrastructure at:
> > us...@infra.apache.org
> >
> >
> > With regards,
> > Apache Git Services
> >
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #2

2020-02-25 Thread Deepak Dixit
Agree Jacopo, We should cancel this VOTE.
There are some fixes that should be included while publishing

E.g
https://github.com/apache/ofbiz-framework/commit/f5c92c053c500737b2dfcc0422dba1bd6ff99783

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Feb 25, 2020 at 4:18 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> Hi all!
>
> Considering that during the last weekend (because of the Community Day) a
> series of bugs have been fixed in the 17.12 branch [*], I think it would be
> a good idea to cancel this vote, prepare new release files and start a new
> vote thread. Any objections?
>
> Jacopo
>
>
> [*] https://issues.apache.org/jira/projects/OFBIZ/versions/12347034
>
>
> On Fri, Feb 21, 2020 at 9:24 AM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> > This is the vote thread (2nd attempt) to release "Apache OFBiz 17.12.01":
> > this is the first release, containing the framework, applications and all
> > the plugins from the 17.12 release branches.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-17.12.01.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.01.zip.sha512: checksum file
> >
> > Please download the zip file, build and test OFBiz and verify the
> > signature and checksum (for instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 17.12.01
> > [ -1] do not release
> >
> > This vote will be open for 4 days.
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
> >
> >
>


Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Deepak Dixit
Hi Michael,

Please see the details for failure
https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466/steps/shell_1/logs/stdio

I fixed these errors in commit
https://github.com/apache/ofbiz-framework/commit/1a8903e1d529540238798ce234b39c8f45256cb1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, Feb 23, 2020 at 5:42 PM Michael Brohl 
wrote:

> Hi Deepak,
>
> the failures in the given buildbot link seem not to match with the build
> erros shown below.
>
> Am I missing something or is something wrong with this report?
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 23.02.20 um 12:17 schrieb Deepak Dixit:
> > Hi Dev,
> >
> > https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466
> >
> > Build failing for release 17.12, please be very careful while backporting
> > changes to release branches, Please make sure you are
> > verifying changes after merge/backport.
> >
> > Also please check the build boat failure notification, and before
> > committing please run the testIntegration task on local box.
> > ==
> >
> >
> :compileJava/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:452:
> > error: cannot find symbol
> >  .where("userLoginId", userLoginId)
> >^
> >symbol:   variable userLoginId
> >location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:450:
> > error: cannot find symbol
> >  EntityQuery eq = EntityQuery.use(delegator)
> >   ^
> >symbol:   variable delegator
> >location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475:
> > error: cannot find symbol
> >  GenericValue userLoginPwdHistToCreate =
> > delegator.makeValue("UserLoginPasswordHistory",
> > UtilMisc.toMap("userLoginId", userLoginId,"fromDate", nowTimestamp));
> >  ^
> >symbol:   variable delegator
> >location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475:
> > error: cannot find symbol
> >  GenericValue userLoginPwdHistToCreate =
> > delegator.makeValue("UserLoginPasswordHistory",
> > UtilMisc.toMap("userLoginId", userLoginId,"fromDate", nowTimestamp));
> >
> > ^
> >symbol:   variable userLoginId
> >location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:476:
> > error: cannot find symbol
> >  userLoginPwdHistToCreate.set("currentPassword",
> currentPassword);
> >  ^
> >symbol:   variable currentPassword
> >location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:945:
> > error: variable delegator is already defined in method
> >
> checkNewPassword(GenericValue,String,String,String,String,List,boolean,Locale)
> >  Delegator delegator = userLogin.getDelegator();
> >^
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:947:
> > error: variable currentPassword is already defined in method
> >
> checkNewPassword(GenericValue,String,String,String,String,List,boolean,Locale)
> >  String currentPassword = userLogin.getString("currentPassword");
> > ^
> > Note: Some input files use or override a deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > Note: Some input files use unchecked or unsafe operations.
> > Note: Recompile with -Xlint:unchecked for details.
> > 7 errors FAILED
> >
> > ==
> >
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
&

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Deepak Dixit
Thanks Pierre, I'll check and reply on it.

@Dev: Please review your changes those were backported to 17.12, we can't
publish broken 17.12 release,

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sun, Feb 23, 2020 at 4:55 PM Pierre Smits  wrote:

> Hi Deepak,
>
> I guess this also validates my proposal to do an automated vetting of
>  contributor's code changes before these be added to the codebase.
>
> See https://ofbiz.markmail.org/message/gkpej7gcxwidggvl?q=vetting for more
> information.
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor* (but unfortunately without privileges)* of* Apache
> OFBiz <https://ofbiz.apache.org/>, since 2008
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Sun, Feb 23, 2020 at 12:17 PM Deepak Dixit  wrote:
>
> > Hi Dev,
> >
> > https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466
> >
> > Build failing for release 17.12, please be very careful while backporting
> > changes to release branches, Please make sure you are
> > verifying changes after merge/backport.
> >
> > Also please check the build boat failure notification, and before
> > committing please run the testIntegration task on local box.
> > ==
> >
> >
> :compileJava/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:452:
> error: cannot find symbol
> > .where("userLoginId", userLoginId)
> >   ^
> >   symbol:   variable userLoginId
> >   location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:450:
> error: cannot find symbol
> > EntityQuery eq = EntityQuery.use(delegator)
> >  ^
> >   symbol:   variable delegator
> >   location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475:
> error: cannot find symbol
> > GenericValue userLoginPwdHistToCreate =
> delegator.makeValue("UserLoginPasswordHistory",
> UtilMisc.toMap("userLoginId", userLoginId,"fromDate", nowTimestamp));
> > ^
> >   symbol:   variable delegator
> >   location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475:
> error: cannot find symbol
> > GenericValue userLoginPwdHistToCreate =
> delegator.makeValue("UserLoginPasswordHistory",
> UtilMisc.toMap("userLoginId", userLoginId,"fromDate", nowTimestamp));
> >
>  ^
> >   symbol:   variable userLoginId
> >   location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:476:
> error: cannot find symbol
> > userLoginPwdHistToCreate.set("currentPassword", currentPassword);
> > ^
> >   symbol:   variable currentPassword
> >   location: class LoginServices
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:945:
> error: variable delegator is already defined in method
> checkNewPassword(GenericValue,String,String,String,String,List,boolean,Locale)
> > Delegator delegator = userLogin.getDelegator();
> >   ^
> >
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:947:
> error: variable currentPassword is already defined in method
> checkNewPassword(GenericValue,String,String,String,String,List,boolean,Locale)
> > String currentPassword = userLogin.getString("currentPassword");
> >^
> > Note: Some input files use or override a deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > Note: Some input files use unchecked or unsafe operations.
> > Note: Recompile

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Deepak Dixit
Hi Dev,

https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466

Build failing for release 17.12, please be very careful while backporting
changes to release branches, Please make sure you are
verifying changes after merge/backport.

Also please check the build boat failure notification, and before
committing please run the testIntegration task on local box.
==

:compileJava/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:452:
error: cannot find symbol
.where("userLoginId", userLoginId)
  ^
  symbol:   variable userLoginId
  location: class LoginServices
/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:450:
error: cannot find symbol
EntityQuery eq = EntityQuery.use(delegator)
 ^
  symbol:   variable delegator
  location: class LoginServices
/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475:
error: cannot find symbol
GenericValue userLoginPwdHistToCreate =
delegator.makeValue("UserLoginPasswordHistory",
UtilMisc.toMap("userLoginId", userLoginId,"fromDate", nowTimestamp));
^
  symbol:   variable delegator
  location: class LoginServices
/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475:
error: cannot find symbol
GenericValue userLoginPwdHistToCreate =
delegator.makeValue("UserLoginPasswordHistory",
UtilMisc.toMap("userLoginId", userLoginId,"fromDate", nowTimestamp));

   ^
  symbol:   variable userLoginId
  location: class LoginServices
/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:476:
error: cannot find symbol
userLoginPwdHistToCreate.set("currentPassword", currentPassword);
^
  symbol:   variable currentPassword
  location: class LoginServices
/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:945:
error: variable delegator is already defined in method
checkNewPassword(GenericValue,String,String,String,String,List,boolean,Locale)
Delegator delegator = userLogin.getDelegator();
  ^
/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:947:
error: variable currentPassword is already defined in method
checkNewPassword(GenericValue,String,String,String,String,List,boolean,Locale)
String currentPassword = userLogin.getString("currentPassword");
   ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
7 errors FAILED

==



Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sat, Feb 22, 2020 at 2:38 PM  wrote:

> The Buildbot has detected a build exception on builder
> ofbizBranch17FrameworkPlugins while building ofbiz-framework. Full details
> are available at:
>
> https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf947_ubuntu
>
> Build Reason: downstream
> Build Source Stamp: [branch release17.12]
> afae70b71a7602543b289d5c4ffce505bc09161e
> Blamelist: Jacques Le Roux 
>
> BUILD FAILED: exception shell_1 upload_2
>
> Sincerely,
>  -The Buildbot
>
>
>
>


Re: In preparation for the first release from 17.12

2020-02-11 Thread Deepak Dixit
>>>Should we release two products or just one as in the past?
Two products mean:
"Apache OFBiz Framework 17.12.01"
and
"Apache OFBiz Plugins 17.12.01"

Thanks Michael, sorry for the confusing reply,
I replied +1 for the above proposal

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Tue, Feb 11, 2020 at 7:19 PM Michael Brohl 
wrote:

> Hi Deepak,
>
> to which of the alternatives do you refer with your +1 ?
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 11.02.20 um 13:05 schrieb Deepak Dixit:
> > +1
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Sat, Feb 8, 2020 at 3:34 PM Jacopo Cappellato <
> > jacopo.cappell...@gmail.com> wrote:
> >
> >> Hi all,
> >>
> >> based on various threads in this list, the time we will prepare the
> first
> >> release from the 17.12 branch is getting close and, since this is the
> first
> >> one in which the plugins are separated from the framework, there are a
> >> few decisions to take.
> >>
> >> Should we release two products or just one as in the past?
> >> Two products mean:
> >> "Apache OFBiz Framework 17.12.01"
> >> and
> >> "Apache OFBiz Plugins 17.12.01"
> >> One product mean"
> >> "Apache OFBiz 17.12.01" (framework + plugins)
> >>
> >> Alternatively, we could publish the two products at different times;
> first
> >> publish "Apache OFBiz Framework 17.12.01" and then later in the year
> >> publish "Apache OFBiz Plugins 17.12.01"; if this is going to happen
> then we
> >> could have for example multiple releases of the Plugins based on the
> same
> >> release of the framework.
> >>
> >> One other option is to release independently each plugin (or the ones
> that
> >> we consider stable enough) rather than all the plugins in one file.
> >>
> >> Thanks,
> >>
> >> Jacopo
> >>
>
>


Re: In preparation for the first release from 17.12

2020-02-11 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Sat, Feb 8, 2020 at 3:34 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> Hi all,
>
> based on various threads in this list, the time we will prepare the first
> release from the 17.12 branch is getting close and, since this is the first
> one in which the plugins are separated from the framework, there are a
> few decisions to take.
>
> Should we release two products or just one as in the past?
> Two products mean:
> "Apache OFBiz Framework 17.12.01"
> and
> "Apache OFBiz Plugins 17.12.01"
> One product mean"
> "Apache OFBiz 17.12.01" (framework + plugins)
>
> Alternatively, we could publish the two products at different times; first
> publish "Apache OFBiz Framework 17.12.01" and then later in the year
> publish "Apache OFBiz Plugins 17.12.01"; if this is going to happen then we
> could have for example multiple releases of the Plugins based on the same
> release of the framework.
>
> One other option is to release independently each plugin (or the ones that
> we consider stable enough) rather than all the plugins in one file.
>
> Thanks,
>
> Jacopo
>


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

2020-01-30 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Jan 30, 2020 at 9:56 PM Nicolas Malin 
wrote:

> +1
>
> Same result from my local
>
> Nicolas
>
> On 30/01/2020 16:06, Michael Brohl wrote:
> > +1
> >
> >
> > ~/Projects/apache-ofbiz/check-release-16.11.07 
> > ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-16.11.07.zip
> > sha check of file: apache-ofbiz-16.11.07.zip
> > Using sha file: apache-ofbiz-16.11.07.zip.sha512
> > apache-ofbiz-16.11.07.zip: EF6D32A6 7A2C2776 50FBE2B4 47E43D45
> > BB503EA5 2C84A604 9CA62AD3 6F180589 1C9C7CC3 F4EE67D2 1393957F
> > E51B9525 0A203A6F D093698E 7B8A9A5B DACC8920
> > apache-ofbiz-16.11.07.zip: EF6D32A6 7A2C2776 50FBE2B4 47E43D45
> > BB503EA5 2C84A604 9CA62AD3 6F180589 1C9C7CC3 F4EE67D2 1393957F
> > E51B9525 0A203A6F D093698E 7B8A9A5B DACC8920
> > sha checksum OK
> >
> > GPG verification output
> > gpg: Signature made Thu Jan 30 12:24:18 2020 CET using RSA key ID
> > 847AF9E0
> > gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
> > " [ultimate]
> >
> >
> > ~/Projects/apache-ofbiz/check-release-16.11.07/apache-ofbiz-16.11.07 
> > ./gradlew loadDefault testIntegration
> >
> > ...
> >
> > BUILD SUCCESSFUL
> >
> > Total time: 3 mins 45.218 secs
> >
> >
> > Thanks,
> >
> > Michael
> >
> >
> >
> >
> > Michael Brohl
> > Geschäftsführer
> >
> > Fon  +49 521 448 157-91
> > Fax  +49 521 448 157-99
> > Mobil+49 160 3664918
> > Xing xing.com/profile/Michael_Brohl
> > LinkedIn linkedin.com/in/michaelbrohl
> >
> > Company and Management Headquarters:
> > ecomify GmbH, Gustav-Winkler-Str. 22, 33699 Bielefeld, Deutschland
> > Fon: +49 521 448157-90, Fax: +49 521 448157-99, www.ecomify.de
> >
> > Court Registration: Amtsgericht Bielefeld HRB 41683
> > Chief Executive Officer: Martin Becker, Michael Brohl
> >
> > Am 30.01.20 um 15:13 schrieb Jacopo Cappellato:
> >>   This is the vote thread to release a new bug fix release for the
> >> release16.11 branch. This new release, "Apache OFBiz 16.11.07" will
> >> supersede all the previous releases from the same branch.
> >> Please consider that this may be the last release in the 16.11 series
> >> and
> >> in the future releases will be published from the newer series only.
> >>
> >> The release files can be downloaded from here:
> >> https://dist.apache.org/repos/dist/dev/ofbiz/
> >>
> >> and are:
> >> * apache-ofbiz-16.11.07.zip
> >> * KEYS: text file with keys
> >> * apache-ofbiz-16.11.07.zip.asc: the detached signature file
> >> * apache-ofbiz-16.11.07.zip.sha512: checksum file
> >>
> >> Please download and test the zip file and its signatures (for
> >> instructions
> >> on testing the signatures see
> >> http://www.apache.org/info/verification.html).
> >>
> >> Vote:
> >> [ +1] release as Apache OFBiz 16.11.07
> >> [ -1] do not release
> >>
> >> This vote will be open for 5 days.
> >> For more details about this process refer to
> >> http://www.apache.org/foundation/voting.html
> >>
> >> Kind Regards,
> >>
> >> Jacopo
> >>
> >
>


Re: Welcome to Olivier Heintz as new committer!

2020-01-27 Thread Deepak Dixit
Many Many congratulations Olivier Heintz !!

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Wed, Jan 22, 2020 at 4:37 PM Michael Brohl 
wrote:

> Congratulations and welcome on board, Olivier!
>
> Michael
>
>
> Am 16.01.20 um 15:23 schrieb Taher Alkhateeb:
> > The OFBiz PMC has invited Olivier Heintz to become a new committer and
> > we are happy to announce that he has accepted this role.
> >
> > Some of the reasons for inviting Olivier Heintz include:
> >
> > - He is invested in the OFBiz project and has been a member for many
> years
> > - He is taking an initiative towards improving the UI part of the system
> > - He has functional experience in various areas of the framework
> > - He enjoys working with the community and collaborating with others
> >
> > Please join me in welcoming and congratulating Olivier!
> >
> > Cheers,
> > Taher Alkhateeb
>
>


Re: [ofbiz-framework] branch trunk updated: Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field (OFBIZ-10879)

2020-01-27 Thread Deepak Dixit
I think this is not the right fix for reported problems.
As we are updating so we don't need to pass the to,cc and bcc. And
redirectTo will be used in dev mode only.
We can fix the subject length only.

IMO we should revert this.

Kind Regards,
Deepak Dixit
DIRECTOR OF PRODUCT ENGINEERING
mobile: +91 9826754548
email: deepak.di...@hotwax.co
*www.hotwax.co <http://www.hotwax.co/>*


On Sat, Jan 25, 2020 at 3:55 PM  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> pawan pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
>
> The following commit(s) were added to refs/heads/trunk by this push:
>  new 832076c  Fixed: Potensial bug under
> CommunicationEventServices#updateCommEventAfterEmail for
> CommunicationEvent.subject field (OFBIZ-10879)
> 832076c is described below
>
> commit 832076ce91dbca182ffab38d27ea72ca5e2cb0be
> Author: Pawan Verma 
> AuthorDate: Sat Jan 25 15:54:37 2020 +0530
>
> Fixed: Potensial bug under
> CommunicationEventServices#updateCommEventAfterEmail for
> CommunicationEvent.subject field
> (OFBIZ-10879)
>
> CommunicationEventServices#updateCommEventAfterEmail could generate
> wrong result. If general.properties value 'mail.notifications.redirectTo'
> is used, it is possible that the subject string has more than 255 character.
>
> Thanks, Ulrich Heidfeld for your contribution.
> ---
>  .../communication/CommunicationEventServices.java  | 23
> ++
>  1 file changed, 23 insertions(+)
>
> diff --git
> a/applications/party/src/main/java/org/apache/ofbiz/party/communication/CommunicationEventServices.java
> b/applications/party/src/main/java/org/apache/ofbiz/party/communication/CommunicationEventServices.java
> index 85f1134..dfb6012 100644
> ---
> a/applications/party/src/main/java/org/apache/ofbiz/party/communication/CommunicationEventServices.java
> +++
> b/applications/party/src/main/java/org/apache/ofbiz/party/communication/CommunicationEventServices.java
> @@ -43,6 +43,7 @@ import javax.mail.internet.InternetAddress;
>  import javax.servlet.http.HttpServletRequest;
>  import javax.servlet.http.HttpServletResponse;
>
> +import org.apache.commons.lang.StringUtils;
>  import org.apache.ofbiz.base.location.FlexibleLocation;
>  import org.apache.ofbiz.base.util.Debug;
>  import org.apache.ofbiz.base.util.GeneralException;
> @@ -823,6 +824,7 @@ public class CommunicationEventServices {
>   */
>  public static Map
> updateCommEventAfterEmail(DispatchContext dctx, Map Object> context) {
>  LocalDispatcher dispatcher = dctx.getDispatcher();
> +Delegator delegator = dctx.getDelegator();
>
>  GenericValue userLogin = (GenericValue) context.get("userLogin");
>  String communicationEventId = (String)
> context.get("communicationEventId");
> @@ -838,6 +840,27 @@ public class CommunicationEventServices {
>  commEventMap.put("userLogin", userLogin);
>  commEventMap.put("content", wrapper.getMessageBody());
>
> +String subject = wrapper.getSubject();
> +String redirectAddress =
> EntityUtilProperties.getPropertyValue("general",
> +"mail.notifications.redirectTo", delegator);
> +if (UtilValidate.isNotEmpty(redirectAddress) &&
> subject.endsWith("]") && subject.contains(" [To: ")) {
> +// Format of subject for redirected mail from sendMail
> service:
> +// "Original subject [To: , Cc: , Bcc:
> ]"
> +String origSendTo = StringUtils.substringBetween(subject,
> "[To: ", ", Cc:");
> +String origSendCc = StringUtils.substringBetween(subject, ",
> Cc: ", ", Bcc:");
> +String origSendBcc = StringUtils.substringBetween(subject, ",
> Bcc: ", "]");
> +
> +// ignore "null" Strings in subject
> +if (origSendTo != "null") commEventMap.put("toString",
> origSendTo);
> +if (origSendCc != "null") commEventMap.put("ccString",
> origSendCc);
> +if (origSendBcc != "null") commEventMap.put("bccString",
> origSendBcc);
> +
> +// Format of subject in commEvent: "Original subject
> [RedirectedTo: recipi...@example.com]"
> +subject = StringUtils.substringBefore(subject, "[To: ")
> ++ "[RedirectedTo: " + commEventMap.get("fromString")
> + "]";
> +commEventMap.put("subject", StringUtils.abbreviate(subject,
> 255));
> +}
> +
>  // populate the address (to/from/cc/bcc) data
>  populateAddressesFromMessage(wrapper, commEventMap);
>
>
>


Re: [VOTE] Do not release R17 and directly publish R18 instead.

2020-01-27 Thread Deepak Dixit
-1

Kind Regards,
Deepak Dixit


On Sun, Jan 26, 2020 at 10:24 PM Martin Becker 
wrote:

> -1
>
> Martin Becker
>
>
>
>
> On 2020/01/24 10:27:15, Jacques Le Roux wrote:
> > Hi,>
> >
> > R16 is now an old distribution and has almost reached its end of
> support. We can soon expect a last release but we need to think about the
> next to be >
> > released package>
> >
> > Some would prefer to release R17 before releasing R18, some would prefer
> to bypass R17 release and directly publish R18 instead.>
> >
> > Vote:>
> > [ +1] Do not release R17 and directly publish R18 instead.>
> > [ -1]  Release R17 before releasing R18>
> >
> > We had already 3 months to discuss without reaching a consensus, so this
> vote will be only open for a week.>
> >
> > Note that it's not a formal vote to release R17 or R18, as that is
> another process documented at>
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz>
>
> >
> > Thank you for your attention>
> >
> > Jacques>
> >
>
>
>


Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Deepak Dixit
Welcome aboard!
Many Many congrats Gil and Mathieu.

Kind Regards,
Deepak Dixit



On Tue, Dec 3, 2019 at 3:56 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become
> members of the committee and we are glad to announce that they have
> accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome on board!
>


Re: Git repo for each ofbiz plugin

2019-11-13 Thread Deepak Dixit
On Sun, Nov 10, 2019 at 4:12 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 07/11/2019 à 11:50, Deepak Dixit a écrit :
> > As per current git repo, How user can only checkout and use ecommerce or
> bi
> > or any single component?
> >
> > It was possible in with svn, but in git we need separate repository
>
> Hi Deepak,
>
> A Github feature[1] allows that. You can do it by checking out from
> Github. Simply try
>
> svn co https://github.com/apache/ofbiz-plugins/trunk/ecommerce
>
> If you then Svn commit, the Github repo will be the ending container and
> will sync to ASF Gitbox
>
> I have used the same in build.Gradle: OFBIZ-11276
>
> I don't say it's a definitive solution. At least it allows to think more
> about the best solution...
>
> [1]
> https://help.github.com/en/github/importing-your-projects-to-github/working-with-subversion-on-github



Thanks Jacques for sharing, I am not aware of this feature, I'll explore
this.

Kind Regards,
Deepak Dixit




>
>
> Jacques
>
>


Re: Git repo for each ofbiz plugin

2019-11-07 Thread Deepak Dixit
>>How a great deal is that? I mean compared to what we already know about
"framework" dependencies on plugins and related issues. And we certainly
miss
some others...

I am not comparing, we already discussed this at the time of cutting
plugins from framework.
To achieve this right way is to have different git repository for each
plugins.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Nov 7, 2019 at 6:18 PM Jacques Le Roux 
wrote:

> Le 07/11/2019 à 11:50, Deepak Dixit a écrit :
> > Agree we may some issues, we need to find out and fix if found.
>
> We have already found several, most are in:
>
> https://issues.apache.org/jira/browse/OFBIZ-3500
>
> https://issues.apache.org/jira/browse/OFBIZ-9322
>
> >
> > As per current git repo, How user can only checkout and use ecommerce or
> bi
> > or any single component?
> >
> > It was possible in with svn, but in git we need separate repository :)
>
> How a great deal is that? I mean compared to what we already know about
> "framework" dependencies on plugins and related issues. And we certainly
> miss
> some others...
>
> Jacques
>
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Thu, Nov 7, 2019 at 1:16 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com>
> > wrote:
> >
> >> Le 07/11/2019 à 08:16, Deepak Dixit a écrit :
> >>>> For instance, some features in applications are dependent on ecommerce
> >>>> (maybe some other plugins). And a lot of
> >>>> data used by applications are in ecommerce, and maybe even other
> >> plugins.
> >>> I think we already had an effort to remove plugin dependencies from
> >>> framework/applications.
> >>>
> >>> --
> >>> Deepak Dixit
> >> Sincerely I don't see much efforts put in this issue. And IMO it needs
> to
> >> be resolved before thinking about splitting the plugins. I expect some
> >> issues else...
> >>
> >> Jacques
> >>
> >>
>


Re: Git repo for each ofbiz plugin

2019-11-07 Thread Deepak Dixit
Agree we may some issues, we need to find out and fix if found.

As per current git repo, How user can only checkout and use ecommerce or bi
or any single component?

It was possible in with svn, but in git we need separate repository :)

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Thu, Nov 7, 2019 at 1:16 PM Jacques Le Roux 
wrote:

> Le 07/11/2019 à 08:16, Deepak Dixit a écrit :
> >> For instance, some features in applications are dependent on ecommerce
> >> (maybe some other plugins). And a lot of
> >> data used by applications are in ecommerce, and maybe even other
> plugins.
> >>
> > I think we already had an effort to remove plugin dependencies from
> > framework/applications.
> >
> > --
> > Deepak Dixit
> Sincerely I don't see much efforts put in this issue. And IMO it needs to
> be resolved before thinking about splitting the plugins. I expect some
> issues else...
>
> Jacques
>
>


Re: Git repo for each ofbiz plugin

2019-11-06 Thread Deepak Dixit
Hi Mathieu,

On Wed, Nov 6, 2019 at 10:58 PM Mathieu Lirzin 
wrote:

> Hello Deepak,
>
> Deepak Dixit  writes:
>
> > As we moved to from svn to git, so I think now its time to create new git
> > repository for each and indiviaual plugins instead of maintaing single
> > ofbiz-plugins.git
> >
> > It will help to manage the plugin life cycle properly,
> > if anyone want to use single or set of plugins they can easiliy setup
> with
> > the proposed way.
> >
> > If we create git repo for each plugins definately we have to manage the
> > dependencies and release properly, I am confident that as a community we
> > can manage this thing :)
> >
> > If this looks good, I'll initiate further process for the same.
> >
> > Please share your thoughts on this.
>
> I sympathise with the intent of having better modularity.  However I
> think OFBiz plugin API is still in its infancy and should become more
> mature before considering moving in the direction of splitting every
> plugin we are maintaining into its own Version Control System (VCS)
> repository.  Let me give you a concrete example demonstrating the kind
> of problems that splitting plugins into multiple VCS repositories will
> bring.
>
> One major limitation of the current OFBiz plugin API is that you cannot
> use Gradle plugins that depends on the java plugin (like the scala
> plugin for example) inside your local ‘build.gradle’ file without
> breaking the global build.  Fixing that bug will likely mean introducing
> breaking changes to the OFBiz plugin API that would then need to be
> propagated in every plugin we maintain.


Agree, we need to define the way how we will manage the plugins lifecycle,
Here we can create release branches each time when we
create release for ofbiz-framework.



> With 2 VCS repositories
> (framework + plugins) things are already not ideal, but with ‘n’ VCS
> repositories a committer would need to create ‘n’ commits


I think here you don't need to clone unused repository,



> and users
> would need to run ‘git pull’ in ‘n’ repositories which is not
> manageable.
>

This should be done with simple command in development mode. With user
perspective its easy to manage,
Like If I want to use only ecommerce, I can clone and use it, no need to
keep unnecessary plugins all the time or worry about them



> Basically to mitigate this maintenance nightmare we would then need a
> custom meta VCS that would be reponsible of managing our set of VCS
> repositories to pull, commit, push... But do we really want that? Do we
> have the shoulders to build and maintain our custom package manager? I
> would say no.
>

Agree, it will increase some additional work, but will have lots of
flexibility with user perspective.
I think here some confusion, I am not proposing to maintain custom package
manger.



> As a side note, one major reason for using a VCS is the ability to
> reproduce the state of a specific version when dealing with bugs (‘git
> bisect’ is meant to help in that regard).  However when splitting a code
> base into multiple VCS repositories without having a versioned
> dependency manifest we simply loose such capability.
>

Agree, but I think while svntogit migration we can have all the previous
commit history,



>
> Sorry for ruining the party. :-)
>

You are doing great Job Mathieu :)


--
Deepak Dixit


> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>


Re: Git repo for each ofbiz plugin

2019-11-06 Thread Deepak Dixit
Hi Jacques,



On Wed, Nov 6, 2019 at 9:38 PM Jacques Le Roux 
wrote:

> Le 06/11/2019 à 10:01, Deepak Dixit a écrit :
> > If we create git repo for each plugins definately we have to manage the
> > dependencies and release properly, I am confident that as a community we
> > can manage this thing:)
>
> Hi Deepak,
>
> I'm not sure what you mean by that.


Here I am proposing to have independent git repository for all the plugin,
currently we are managing one repository (ofbiz-plugins.git)
As per the current way we can't use the independent plugins, we need to
clone whole ofbiz-plugins



> For instance, some features in applications are dependent on ecommerce
> (maybe some other plugins). And a lot of
> data used by applications are in ecommerce, and maybe even other plugins.
>


I think we already had an effort to remove plugin dependencies from
framework/applications.

--
Deepak Dixit




>
> BTW while working on the RAT build. I used a Github specific feature which
> allows to export a file from an automated mirrored svn repo there. I have
> just used this feature to temporary fix the pull plugins source tasks
> which were still relying on the now read-only ASF svn repo.
>
> I'll create a Jira for that before committing. I need also to fix the
> trunk demo...
>
> I guess we should later use https://github.com/ajoberstar/gradle-git
>
> Jacques
>
>


Git repo for each ofbiz plugin

2019-11-06 Thread Deepak Dixit
Hi All,

As we moved to from svn to git, so I think now its time to create new git
repository for each and indiviaual plugins instead of maintaing single
ofbiz-plugins.git

It will help to manage the plugin life cycle properly,
if anyone want to use single or set of plugins they can easiliy setup with
the proposed way.

If we create git repo for each plugins definately we have to manage the
dependencies and release properly, I am confident that as a community we
can manage this thing :)

If this looks good, I'll initiate further process for the same.

Please share your thoughts on this.

Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


Re: Migrating to Git

2019-11-04 Thread Deepak Dixit
Here is the task for svn to git migration post actions
https://issues.apache.org/jira/browse/OFBIZ-11268
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Nov 4, 2019 at 11:36 AM Deepak Dixit  wrote:

> I think we can create ticket to track all the migration steps. It will
> help to cross check and for future reference
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Mon, Nov 4, 2019 at 12:46 AM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Le 03/11/2019 à 18:58, Jacques Le Roux a écrit :
>> > Le 03/11/2019 à 18:29, Jacques Le Roux a écrit :
>> >> we have no Git repo for 16.11. I guess the repo is not read only and
>> we can continue to use it. But anyway, then backporting will be come
>> >>harder...
>> > Is the repo read-only https://ci.apache.org/builders/ofbizBranch16 ?
>>
>> OK, missed that all Buildbot servers are offline :/ Wait for it...
>>
>> Jacques
>>
>>


Re: Migrating to Git

2019-11-03 Thread Deepak Dixit
I think we can create ticket to track all the migration steps. It will help
to cross check and for future reference


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Nov 4, 2019 at 12:46 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 03/11/2019 à 18:58, Jacques Le Roux a écrit :
> > Le 03/11/2019 à 18:29, Jacques Le Roux a écrit :
> >> we have no Git repo for 16.11. I guess the repo is not read only and we
> can continue to use it. But anyway, then backporting will be come
> >>harder...
> > Is the repo read-only https://ci.apache.org/builders/ofbizBranch16 ?
>
> OK, missed that all Buildbot servers are offline :/ Wait for it...
>
> Jacques
>
>


Re: Migrating to Git

2019-11-01 Thread Deepak Dixit
Just to update you all we are done with git migration.

@all committers
Please use gitbox repo for code commit, as ofbiz svn location is locked.
Here are the list of repositories url:

- https://gitbox.apache.org/repos/asf/ofbiz-framework.git
- https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
- https://gitbox.apache.org/repos/asf/ofbiz-site.git
- https://gitbox.apache.org/repos/asf/ofbiz-tools.git

Will proceed with migration steps one by one.

Please refer following task for more detail
https://issues.apache.org/jira/browse/INFRA-19308
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Oct 21, 2019 at 2:13 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> On Sat, Oct 19, 2019 at 5:31 PM Mathieu Lirzin 
> wrote:
>
> > Hello,
> >
> > Swapnil M Mane  writes:
> >
> > > As discussed previously, all the essential details are incorporated in
> > this
> > > document [1] to help us in migrating from SVN to Git.
> > > Please have a look and let us know your kind feedback/thoughts.
> > > Here are references [2] [3] to our previous discussions for your quick
> > > reference.
> >
> > Thanks for thise reminder, I think this workflow document is
> > sufficiently well thought to move forward.  I have open the following
> > ticket:
> >
> >https://issues.apache.org/jira/browse/INFRA-19308
> >
> > Thanks.
> >
> > --
> > Mathieu Lirzin
> > GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> >
>
> Great!
>
> Jacopo
>


  1   2   3   4   5   6   7   8   9   10   >