[jira] [Comment Edited] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391227#comment-15391227 ] Hans Bakker edited comment on OFBIZ-7754 at 7/25/16 1:11 AM: - if you move these initial property settings to the database is fine with me, As long as you delete the general.properties file, because that file does not do anything anymore because overridden by the database settings... But here you will upset the people upgrading who did previously used the general properties file. was (Author: hansbak): if you move these initial property settings to the database is fine with me, As long as you delete the general.properties file, because that file does not do anything anymore because overridden by the database settings... > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Pierre Smits > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391227#comment-15391227 ] Hans Bakker commented on OFBIZ-7754: if you move these initial property settings to the database is fine with me, As long as you delete the general.properties file, because that file does not do anything anymore because overridden by the database settings... > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Pierre Smits > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376506#comment-15376506 ] Hans Bakker commented on OFBIZ-7754: Can only repeat: simply remove the framework/common/data/CommonSystemPropertyData.xml file from ofbiz-component is my suggestion. then the file general.properties is active again. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370065#comment-15370065 ] Hans Bakker commented on OFBIZ-7754: Looks like my emails about this subject did not come through I am sorry Jacques, it still think this change solves a problem which does not exists. Referring to database settings we do not have in properties files is not justifying it. I was asking for actual examples. Anyway if you people think it is a good idea, i am fine but would like to propose to disable the file framework/common/data/CommonSystemPropertyData.xml completely and just use it as an example how to use systemproperties. So even not use it for initial seed. Then the general.properties gets active again and is not confusing for new users. Regards, Hans > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367112#comment-15367112 ] Hans Bakker commented on OFBIZ-7754: here it shows that we always need a business reason for the change. This issue is a nice example that is trying to provide a solution for a technical problem for which i do not see a business reason. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (OFBIZ-7112) EntityUtilProperties
[ https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reopened OFBIZ-7112: please see my comment at: https://issues.apache.org/jira/browse/OFBIZ-7754 where i propose to revert this change. > EntityUtilProperties > > > Key: OFBIZ-7112 > URL: https://issues.apache.org/jira/browse/OFBIZ-7112 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, > OFBIZ-7112.patch > > > Ofbiz reads properties from either a properties file or the > entity:SystemProperty. The way it works previously is that ofbiz reads from > the entity:SystemProperty first and if there is no value associated with the > target propertyname, it would then locate the value from the relevant > properties file. > In other words, if there is a database entry for a property, the database > entry should override the associated properties file. > The issue is that if a database entry exist but the value is empty, it would > look for a value from the properties file. It should not do so. If a > database entry exists for the propertyname of interest, the value should be > taken from the database even if it holds an empty value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7754) The big problem when load seed.
[ https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363576#comment-15363576 ] Hans Bakker commented on OFBIZ-7754: After more thought I would like to question the whole implementation of OFBIZ-7112. As far as i understood it, it was initiated because it was not possible to set a properties value to 'blank' or Empty, sure, accepted that is true. (although set in the properties file set to blank would be a solution?) But is it required? Please give me a number of examples where this is needed. As far as I can see a properties value always has content either Y/N or False/True or a value. Further, anybody just starting with the system will try to change the most important properties file 'general.properties' and will see no result. then as Kongrath (we call him Joe) mentioned an upgrade will be much more difficult if you set your parameters in general.properties or even worse set them in the DB and they get overwritten and sure should not be seed. So my proposal: please revert this change in OFBIZ-7112 it causes far more problems than it solves. > The big problem when load seed. > --- > > Key: OFBIZ-7754 > URL: https://issues.apache.org/jira/browse/OFBIZ-7754 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Jacques Le Roux > Attachments: OFBIZ-7754.patch > > > Hi All, > Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112] > That's good for who start on use the ofbiz with initial setup, but not for > the site that already online and has to update the OFBiz core. Because when > has update OFBiz core they will use command load-seed for update. > The problem is if we use load-seed mean the configuration data that's already > exists will be replaced by the data from this file, > *CommonSystemPropertyData.xml* > So, for my suggestion should change the reader from *seed* to *seed-initial* > or remove systemPropertyValue from the data file. > Thank you, > Kongrath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6783) Refactor start.java
[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281216#comment-15281216 ] Hans Bakker commented on OFBIZ-6783: wouldn't it be nice (or even required?) to write an automated jUnit test for this new start.java? > Refactor start.java > --- > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > StartCommandUtil.java > > > Looking at the main method and design of Start.java looks ugly. The things I > would like to fix so far are: > - the file is too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important file, I will provide a patch to be > reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-2219) Special issue to allow submitting patches for online help update
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-2219: --- Assignee: (was: Hans Bakker) > Special issue to allow submitting patches for online help update > > > Key: OFBIZ-2219 > URL: https://issues.apache.org/jira/browse/OFBIZ-2219 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Attachments: HelpAccounting.jpg, > OFBIZ-2219_DocbookAccountingHelp10.patch, build.xml > > > *This issue should not be closed, at least until the online help is > completed...* > in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from > OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan > if she could update this links, while she is improving documentation, and she > agreed. So this issue is to allow her, and anybody else, to submit patches to > improve the online help (not only accounting of course hence the ALL > COMPONENTS) > We commit only the [ones > completed|https://issues.apache.org/jira/browse/OFBIZ-4175?focusedCommentId=12993718=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12993718] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-4502) Improved CMS tree: more functionality and faster for large trees
[ https://issues.apache.org/jira/browse/OFBIZ-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-4502: --- Assignee: (was: Hans Bakker) > Improved CMS tree: more functionality and faster for large trees > > > Key: OFBIZ-4502 > URL: https://issues.apache.org/jira/browse/OFBIZ-4502 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Martin Kreidenweis > Attachments: CMS-Tree-Improvement-2.patch, CMS-Tree-Improvement.patch > > > We here at [Lusini|http://www.lusini.de/] did several improvements to the CMS > backend to make it more useable for large CMS installations. > * Improved performance of CMS tree > ** loading nodes dynamically using AJAX > *** Created ContentJsonEvents to handle the JSON calls > ** use OFBiz entity caches > ** removed duplicate execution of WebSitePublishPoint.groovy > *** removed reference from controller.xml as it is not used anywhere > * Moving nodes in CMS tree possible now using drag'n'drop > ** ContentJsonEvents returns updated node attributes > ** Adjusted WebSiteCMSNav.ftl to update the moved node with the data from the > ajax request > ** Needed to replace the jstree jQuery plugin by the current version > available on the jstree website > * Made nodes deleteable > ** added remove to context menu > ** We did not want to delete the WebSitePathAlias entities right away, so we > added a fromDate and thruDate to it. > *** extended WebSitePathAlias entity definition: added fromDate and thruDate > *** now checking for date range everywhere when accessing path aliases > *** This also allows users to publish or unpublish contents under a certain > URL automatically at some time in the future. > ** created event to "delete" a node > *** thruDate of all assocs pointing to this node are set to current timestamp > *** thruDate of WebSitePathAliases pointing to this content or any contents > below are set to current timestamp > *** this way nothing is actually removed from the DB and a "undo" would be > possible if necessary > ** extracted context menu to variable so it can be reused for all trees > * fixed missing references to uiLabels in CMS menu bar > * Activated cookie plugin so the selected node is remembered > To migrate existing path aliases the following SQL statements can be used: > BEGIN; > UPDATE web_site_path_alias SET from_date=w.created_stamp FROM > web_site_path_alias w WHERE w.path_alias=web_site_path_alias.path_alias; > ALTER TABLE web_site_path_alias > DROP CONSTRAINT pk_web_site_path_alias, > ADD CONSTRAINT pk_web_site_path_alias PRIMARY KEY (web_site_id, > path_alias, from_date); > COMMIT; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-2531) Enhancements in Trainings under HR module
[ https://issues.apache.org/jira/browse/OFBIZ-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-2531: --- Assignee: (was: Hans Bakker) > Enhancements in Trainings under HR module > - > > Key: OFBIZ-2531 > URL: https://issues.apache.org/jira/browse/OFBIZ-2531 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk > Environment: Windows XP >Reporter: Simranjeet Singh >Priority: Minor > Attachments: ASF.LICENSE.NOT.GRANTED--Trng Write Up.txt, > HR_Training_improvements.patch, HR_Trainings.patch, HR_Trainings.patch, > HR_Trainings.patch > > > Hi users, > We are working on enhancement of "Trainings" under HR module. We have > modified the existing Trainings tab by adding a Training calendar to it. We > have planned to integrate following functionalities by doing some > modifications and enhancements under HR module > *In GlobalHRSettings tab* > 1. Added "Training Types" tab where admin can add/delete/update the types of > trainings available in an organization. > 2. Implemented the functionality of "Training Calendar" where training > schedules are maintained. All the trainings are listed with their names, > from/thru date and target audience. Admin can create/update/delete any > calendar entry. > *In Trainings tab* > 1. Added "Trainings" sub-tab where employee can apply for available > trainings. Approver/Admin can assign any training from training calendar to > the employee. > 2. Added "Trainings Status" tab where employee/approver can check their > training request status. Approver/Admin can approve/reject requested trainings > We would like to upload the implemented trainings patch ASAP. Before > uploading patch we would like to discuss our approach with community members. > Any comments/suggestions on this would be appreciated. > Regards > Simranjeet Singh > iLabs, L & T Infotech Ltd. > Mumbai. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6985) New Theme spnsored by an end user.
[ https://issues.apache.org/jira/browse/OFBIZ-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-6985: --- Description: This theme was created by a big ofbiz customer and contributed to the the ofbiz community. A demo you can see in GrowERP: https://minimum.growerpdemo.com/backend/control/main?PASSWORD=ofbiz=admin was:This theme was created by a big ofbiz customer and contributed to the the ofbiz community. > New Theme spnsored by an end user. > -- > > Key: OFBIZ-6985 > URL: https://issues.apache.org/jira/browse/OFBIZ-6985 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Upcoming Branch >Reporter: Hans Bakker >Priority: Minor > > This theme was created by a big ofbiz customer and contributed to the the > ofbiz community. > A demo you can see in GrowERP: > https://minimum.growerpdemo.com/backend/control/main?PASSWORD=ofbiz=admin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6985) New Theme spnsored by an end user.
Hans Bakker created OFBIZ-6985: -- Summary: New Theme spnsored by an end user. Key: OFBIZ-6985 URL: https://issues.apache.org/jira/browse/OFBIZ-6985 Project: OFBiz Issue Type: Improvement Components: themes Affects Versions: Upcoming Branch Reporter: Hans Bakker Priority: Minor This theme was created by a big ofbiz customer and contributed to the the ofbiz community. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use
[ https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196910#comment-15196910 ] Hans Bakker commented on OFBIZ-6923: correction\ committed 1735189 > Improve the decorator for manufacturing/order/facility component for re-use > --- > > Key: OFBIZ-6923 > URL: https://issues.apache.org/jira/browse/OFBIZ-6923 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing, order, product >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Hans Bakker > Fix For: Upcoming Branch > > Attachments: OFBIZ-6923.patch, OFBIZ-6923.patch > > > We have a problem on organize the existing decorator. In this case is > manufacturing decorator and also in another decorator too. We cannot use the > existing decorator with *main-decorator* that define on another component in > *hot-deploy*. > So, I thought we should make reorganization for decorator like in the > partymgr component > *applications/party/widget/partymgr/CommonScreens.xml* > All screen should call the common decorator and each common decorator call > *main-decorator* in each commonent, so if we have create the new component in > *hot-deploy* and it should use the *main-decorator* in their. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use
[ https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-6923. -- Resolution: Fixed Fix Version/s: Upcoming Branch Committed revision 1735178. Thank you Kongrath Suankaewmanee for your contribution. > Improve the decorator for manufacturing/order/facility component for re-use > --- > > Key: OFBIZ-6923 > URL: https://issues.apache.org/jira/browse/OFBIZ-6923 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing, order, product >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Hans Bakker > Fix For: Upcoming Branch > > Attachments: OFBIZ-6923.patch > > > We have a problem on organize the existing decorator. In this case is > manufacturing decorator and also in another decorator too. We cannot use the > existing decorator with *main-decorator* that define on another component in > *hot-deploy*. > So, I thought we should make reorganization for decorator like in the > partymgr component > *applications/party/widget/partymgr/CommonScreens.xml* > All screen should call the common decorator and each common decorator call > *main-decorator* in each commonent, so if we have create the new component in > *hot-deploy* and it should use the *main-decorator* in their. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use
[ https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-6923: --- Component/s: product order > Improve the decorator for manufacturing/order/facility component for re-use > --- > > Key: OFBIZ-6923 > URL: https://issues.apache.org/jira/browse/OFBIZ-6923 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing, order, product >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Hans Bakker > Attachments: OFBIZ-6923.patch > > > We have a problem on organize the existing decorator. In this case is > manufacturing decorator and also in another decorator too. We cannot use the > existing decorator with *main-decorator* that define on another component in > *hot-deploy*. > So, I thought we should make reorganization for decorator like in the > partymgr component > *applications/party/widget/partymgr/CommonScreens.xml* > All screen should call the common decorator and each common decorator call > *main-decorator* in each commonent, so if we have create the new component in > *hot-deploy* and it should use the *main-decorator* in their. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use
[ https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-6923: --- Summary: Improve the decorator for manufacturing/order/facility component for re-use (was: Improve the decorator for manufacturing component.) > Improve the decorator for manufacturing/order/facility component for re-use > --- > > Key: OFBIZ-6923 > URL: https://issues.apache.org/jira/browse/OFBIZ-6923 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee > Attachments: OFBIZ-6923.patch > > > We have a problem on organize the existing decorator. In this case is > manufacturing decorator and also in another decorator too. We cannot use the > existing decorator with *main-decorator* that define on another component in > *hot-deploy*. > So, I thought we should make reorganization for decorator like in the > partymgr component > *applications/party/widget/partymgr/CommonScreens.xml* > All screen should call the common decorator and each common decorator call > *main-decorator* in each commonent, so if we have create the new component in > *hot-deploy* and it should use the *main-decorator* in their. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use
[ https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reassigned OFBIZ-6923: -- Assignee: Hans Bakker > Improve the decorator for manufacturing/order/facility component for re-use > --- > > Key: OFBIZ-6923 > URL: https://issues.apache.org/jira/browse/OFBIZ-6923 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Hans Bakker > Attachments: OFBIZ-6923.patch > > > We have a problem on organize the existing decorator. In this case is > manufacturing decorator and also in another decorator too. We cannot use the > existing decorator with *main-decorator* that define on another component in > *hot-deploy*. > So, I thought we should make reorganization for decorator like in the > partymgr component > *applications/party/widget/partymgr/CommonScreens.xml* > All screen should call the common decorator and each common decorator call > *main-decorator* in each commonent, so if we have create the new component in > *hot-deploy* and it should use the *main-decorator* in their. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6923) Improve the decorator for manufacturing component.
[ https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186278#comment-15186278 ] Hans Bakker commented on OFBIZ-6923: + does not seem right > Improve the decorator for manufacturing component. > -- > > Key: OFBIZ-6923 > URL: https://issues.apache.org/jira/browse/OFBIZ-6923 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee > Attachments: manufacturing-decorator.diff > > > We have a problem on organize the existing decorator. In this case is > manufacturing decorator and also in another decorator too. We cannot use the > existing decorator with *main-decorator* that define on another component in > *hot-deploy*. > So, I thought we should make reorganization for decorator like in the > partymgr component > *applications/party/widget/partymgr/CommonScreens.xml* > All screen should call the common decorator and each common decorator call > *main-decorator* in each commonent, so if we have create the new component in > *hot-deploy* and it should use the *main-decorator* in their. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6847) use organizationPartyId from Application decorator instead of retrieve organizationPartyId that sent from other request, to support change accounting company.
[ https://issues.apache.org/jira/browse/OFBIZ-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-6847. -- Resolution: Fixed Fix Version/s: Upcoming Branch implemented with https://issues.apache.org/jira/browse/OFBIZ-6802 > use organizationPartyId from Application decorator instead of retrieve > organizationPartyId that sent from other request, to support change > accounting company. > -- > > Key: OFBIZ-6847 > URL: https://issues.apache.org/jira/browse/OFBIZ-6847 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Parinya Wongjina > Fix For: Upcoming Branch > > > This implement related to proposal of issue OFBIZ-6802 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker closed OFBIZ-6802.
--
Resolution: Fixed
Fix Version/s: Upcoming Branch
just committed the corrective patch for xml and pdf problem
accounting/control/IncomeStatement?organizationPartyId=Company
Thank you Bank for the patch
> be able to set accounting company in the header, so other companent can
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6802-fix-bug.patch, OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker reopened OFBIZ-6802:
jacopo reported a problem at
https://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
> be able to set accounting company in the header, so other companent can
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix-bug.patch, OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-6845) On the balance sheet, it display incorrect value on the total of long-term asset.
[
https://issues.apache.org/jira/browse/OFBIZ-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker closed OFBIZ-6845.
--
Resolution: Fixed
Fix Version/s: Trunk
Committed revision 1730456
thank you Supatthra Nawicha for the contribution.
> On the balance sheet, it display incorrect value on the total of long-term
> asset.
> -
>
> Key: OFBIZ-6845
> URL: https://issues.apache.org/jira/browse/OFBIZ-6845
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Supatthra Nawicha
> Fix For: Trunk
>
> Attachments: addConditionForLongTermAsset.patch
>
>
> Now, it display the totals of all transactions of any assets. I have checked
> on the code and I have found the missing condition checked in there.
> {code:title=BalanceSheet.groovy|borderStyle=solid}
> List longtermAssetAndExprs = mainAndExprs as LinkedList;
> longtermAssetAndExprs.add(EntityCondition.makeCondition("glAccountClassId",
> EntityOperator.IN, longtermAssetAccountClassIds));
> transactionTotals = select("glAccountId", "accountName", "accountCode",
> "debitCreditFlag",
> "amount").from("AcctgTransEntrySums").orderBy("glAccountId").queryList();
> {code}
> Actually, it should be:
> {code:java}
> List longtermAssetAndExprs = mainAndExprs as LinkedList;
> longtermAssetAndExprs.add(EntityCondition.makeCondition("glAccountClassId",
> EntityOperator.IN, longtermAssetAccountClassIds));
> transactionTotals = select("glAccountId", "accountName", "accountCode",
> "debitCreditFlag",
> "amount").from("AcctgTransEntrySums").where(longtermAssetAndExprs).orderBy("glAccountId").queryList();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, so other
companent can change it too. (was: be able to set accounting company in the
header, remove from accounting, so other companent can change it too.)
> be able to set accounting company in the header, so other companent can
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other companent can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, remove from
accounting, so other companent can change it too. (was: be able to set
accounting company in the header, so other components can change it too.)
> be able to set accounting company in the header, remove from accounting, so
> other companent can change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker closed OFBIZ-6802.
--
Resolution: Fixed
Committed revision 1728584. Thank you Parinya Wongjina for the patch.
> be able to set accounting company in the header, so other companent can
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, so other components can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, so other
components can change it too. (was: be able to set accounting company in the
header, remove from accounting, so other components can change it too.)
> be able to set accounting company in the header, so other components can
> change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker updated OFBIZ-6802:
---
Attachment: (was: OFBIZ-6802.patch)
> be able to set accounting company in the header, remove from accounting, so
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6875) Update various accounting labels regarding the dutch locale
[ https://issues.apache.org/jira/browse/OFBIZ-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reassigned OFBIZ-6875: -- Assignee: Hans Bakker (was: Pierre Smits) > Update various accounting labels regarding the dutch locale > --- > > Key: OFBIZ-6875 > URL: https://issues.apache.org/jira/browse/OFBIZ-6875 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Hans Bakker > Labels: Nederlands > Attachments: OFBIZ-6875-AccountingLabels-v2.patch, > OFBIZ-6875-AccountingLabels.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6875) Update various accounting labels regarding the dutch locale
[ https://issues.apache.org/jira/browse/OFBIZ-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131508#comment-15131508 ] Hans Bakker commented on OFBIZ-6875: Hi Pierre, you changed 'bestelling' to 'order' That is fine with me, however there are 17 other labels using 'bestelling' further is there a suggested translation list for the Dutch language which lists that the translation for order should be 'order' in Dutch? > Update various accounting labels regarding the dutch locale > --- > > Key: OFBIZ-6875 > URL: https://issues.apache.org/jira/browse/OFBIZ-6875 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Hans Bakker > Labels: Nederlands > Attachments: OFBIZ-6875-AccountingLabels-v2.patch, > OFBIZ-6875-AccountingLabels.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122728#comment-15122728
]
Hans Bakker commented on OFBIZ-6802:
I tested the patch according the test instructions and it works well.
When the patch is applied there is no visible change in the ofbiz user
interface when there is only a single accounting company. It becomes only
visible when there is more than one in the header of all themes where it will
show the current selected accounting company.
Also the accounting company list in accounting is not changed (yet).
Please provide your comments, when there are no objections, i will commit this
change in a week.
> be able to set accounting company in the header, remove from accounting, so
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch, OFBIZ-6802.patch
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6791) Various fixes related with sales opportunity
[ https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114656#comment-15114656 ] Hans Bakker commented on OFBIZ-6791: Jacques, i admire your dedication, but, sorry to say, i still think that making the lead party mandatory would have been much easier and even cleaner too..what is an opportunity without a lead? > Various fixes related with sales opportunity > > > Key: OFBIZ-6791 > URL: https://issues.apache.org/jira/browse/OFBIZ-6791 > Project: OFBiz > Issue Type: Bug > Components: marketing, order >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 14.12.01, Upcoming Branch > > Attachments: sfa.patch > > > Hans directly committed > * r1723007 "sales opportunity creation: required-field removed, disturbed the > form submission, entityone no value field, error in the log" > * and r1723248 "various fixes to the salesopportunity list and create > functions" > I wanted to backport them and create this Jira for releases notes. But before > I checked the commits and found an issue, see > http://markmail.org/message/mspie3qdjcac2tci -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6791) Various fixes related with sales opportunity
[ https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-6791: --- Attachment: sfa.patch patch to change the opportunitylist to show an opportunity even if no lead or account attached > Various fixes related with sales opportunity > > > Key: OFBIZ-6791 > URL: https://issues.apache.org/jira/browse/OFBIZ-6791 > Project: OFBiz > Issue Type: Bug > Components: marketing, order >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: sfa.patch > > > Hans directly committed > * r1723007 "sales opportunity creation: required-field removed, disturbed the > form submission, entityone no value field, error in the log" > * and r1723248 "various fixes to the salesopportunity list and create > functions" > I wanted to backport them and create this Jira for releases notes. But before > I checked the commits and found an issue, see > http://markmail.org/message/mspie3qdjcac2tci -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6791) Various fixes related with sales opportunity
[ https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111949#comment-15111949 ] Hans Bakker commented on OFBIZ-6791: My apologies if I upset you Jacques, it was not my intention. this problems can be solved either, changing the seca to make the lead mandatory, which you do not seem to like or we change the listing program so it will list all opportunities even if there is no lead or account Attached a patch for the second possibility. in this case however it is not possible to select only the lead of the role so depending on availability either the lead or the account is shown. anyway that is all i can do.. > Various fixes related with sales opportunity > > > Key: OFBIZ-6791 > URL: https://issues.apache.org/jira/browse/OFBIZ-6791 > Project: OFBiz > Issue Type: Bug > Components: marketing, order >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Hans directly committed > * r1723007 "sales opportunity creation: required-field removed, disturbed the > form submission, entityone no value field, error in the log" > * and r1723248 "various fixes to the salesopportunity list and create > functions" > I wanted to backport them and create this Jira for releases notes. But before > I checked the commits and found an issue, see > http://markmail.org/message/mspie3qdjcac2tci -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6791) Various fixes related with sales opportunity
[ https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107806#comment-15107806 ] Hans Bakker commented on OFBIZ-6791: Jacques, perhaps you missed it but I answered on the mailing list with: because this change makes the leadparty a mandatory field. If not filled in, it will not appear in the list screen. Regards, Hans To re-produce the error now: create a new opportunity with just the opportunity name filled in. go back to the opportunity list, and your newly opportunity will not appear. > Various fixes related with sales opportunity > > > Key: OFBIZ-6791 > URL: https://issues.apache.org/jira/browse/OFBIZ-6791 > Project: OFBiz > Issue Type: Bug > Components: marketing, order >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Hans directly committed > * r1723007 "sales opportunity creation: required-field removed, disturbed the > form submission, entityone no value field, error in the log" > * and r1723248 "various fixes to the salesopportunity list and create > functions" > I wanted to backport them and create this Jira for releases notes. But before > I checked the commits and found an issue, see > http://markmail.org/message/mspie3qdjcac2tci -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104188#comment-15104188
]
Hans Bakker commented on OFBIZ-6802:
Using the position the current user has in the company structure is an
interesting idea and sure would be ideal implementation. This means however
that this information needs to be available what is not always the case
When no objections we will implement the following:
When there is only a single INTERNAL_ORGANIZATIO company, then the header
should not change and this company is automatically selected.
When there are more than a single company, a click-able accounting company name
should be shown in the header.
Show the selected company in the user preferences, when not available use the
system preferences, when not available use the oldest accounting company
created, when nothing found show the accounting company setup screen where the
partyid can be selected or created.
When the accounting company name in the header is clicked, show a popup with a
list of accounting companies.
Check if the current user is part of an accounting company(partyRelationship),
when yes, show that company and all accounting companies lower in the
accounting company tree. A user can be part of more than a single company.
When the current user is not part of an accounting company, show all companies
alphabetically with the role INTERNAL_ORGANIZATIO.
Let the user select the company and update the context and user preference.
> be able to set accounting company in the header, remove from accounting, so
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by
> {code}
> "${organization} setup' and '${organization} accounting where ${organization}
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonext component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker updated OFBIZ-6802:
---
Description:
Currently it is possible to set the current accounting company in the option
under organization GL settings and in party preferences.
The proposal is to remove it from accounting and set it in the theme header so
it will be available in all components. In order to make the system not more
complicated, this setting is only available when there is more than a single
accounting company.
Then replace the organization GL settings in accounting by "${organization}
setup' and '${organization} accounting where ${organization} is the current
selected accounting company in the header.
The global setting of the current organization is already done in the
application decorator in the commonex component.
was:
Currently it is possible to set the current accounting company in the option
under organization GL settings and in party preferences.
The proposal is to remove it from accounting and set it in the theme header so
it will be available in all components. In order to make the system not more
complicated, this setting is only available when there is more than a single
accounting company.
Then replace the organization GL settings by "${organization} setup' and
'${organization} accounting where ${organization} is the current selected
accounting company in the header.
The global setting of the current organization is already done in the
application decorator in the commonex component.
> be able to set accounting company in the header, remove from accounting, so
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: trun
> Environment: any
>Reporter: Hans Bakker
> Fix For: tru
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings in accounting by "${organization}
> setup' and '${organization} accounting where ${organization} is the current
> selected accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonex component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other companent can change it too.
Hans Bakker created OFBIZ-6802:
--
Summary: be able to set accounting company in the header, remove
from accounting, so other companent can change it too.
Key: OFBIZ-6802
URL: https://issues.apache.org/jira/browse/OFBIZ-6802
Project: OFBiz
Issue Type: Improvement
Components: accounting
Affects Versions: trun
Environment: any
Reporter: Hans Bakker
Fix For: tru
Currently it is possible to set the current accounting company in the option
under organization GL settings and in party preferences.
The proposal is to remove it from accounting and set it in the theme header so
it will be available in all components. In order to make the system not more
complicated, this setting is only available when there is more than a single
accounting company.
Then replace the organization GL settings by "${organization} setup' and
'${organization} accounting where ${organization} is the current selected
accounting company in the header.
The global setting of the current organization is already done in the
application decorator in the commonex component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.
[
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, remove from
accounting, so other components can change it too. (was: be able to set
accounting company in the header, remove from accounting, so other companent
can change it too.)
> be able to set accounting company in the header, remove from accounting, so
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: trun
> Environment: any
>Reporter: Hans Bakker
> Fix For: tru
>
>
> Currently it is possible to set the current accounting company in the option
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header
> so it will be available in all components. In order to make the system not
> more complicated, this setting is only available when there is more than a
> single accounting company.
> Then replace the organization GL settings by "${organization} setup' and
> '${organization} accounting where ${organization} is the current selected
> accounting company in the header.
> The global setting of the current organization is already done in the
> application decorator in the commonex component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user
[ https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006123#comment-15006123 ] Hans Bakker commented on OFBIZ-6703: at the time, i also did not agree, but he really pushed it and i gave up on it > Cannot create more than one lead in the SFA component by same user > -- > > Key: OFBIZ-6703 > URL: https://issues.apache.org/jira/browse/OFBIZ-6703 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Fix For: 14.12.01, Upcoming Branch > > > Repeat steps: > # go to SFA component and click on leads > # click on create new > # fill mandatory information and save > # repeat the above steps again and observe failure > The reason for the failure is that the implementation of the createLead > service tries to create a PartyRole of type OWNER every time a lead is > created. So it works only the first time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6708) Missing userLogin error on party profile screen when 1st content is non public
[
https://issues.apache.org/jira/browse/OFBIZ-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker reassigned OFBIZ-6708:
--
Assignee: Hans Bakker
> Missing userLogin error on party profile screen when 1st content is non public
> --
>
> Key: OFBIZ-6708
> URL: https://issues.apache.org/jira/browse/OFBIZ-6708
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Hans Bakker
>Priority: Minor
>
> When a party 1st non content public the serveObjectData event is called in
> party profile screen and it misses the userLogin in session.
> This was implemented with
> [r1199681|http://svn.apache.org/viewvc?view=revision=1199681] ([see
> this|http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml?r1=1199681=1199680=1199681])
> which is a back hack. I guess the idea was if a "Logo Image URL" was
> assigned to a party like "Company" it should be displayed in the profile
> screen, that works w/o error in the log. But when you have a party 1st non
> content of other type for other parties (like admin for instance) it does not
> make sense, and show an error in log.
> {code}
> [java] 2015-11-03 12:05:12,856 |ttp-bio-8443-exec-11 |DataEvents
>|E| null
> [java] org.ofbiz.service.ServiceAuthException: User authorization is
> required for this service: genericContentPermission
> [java] at
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:356)
> ~[ofbiz-service.jar:?]
> [java] at
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
> ~[ofbiz-service.jar:?]
> [java] at
> org.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> ~[ofbiz-service.jar:?]
> [java] at
> org.ofbiz.content.data.DataEvents.serveObjectData(DataEvents.java:139)
> [ofbiz-content.jar:?]
> [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) ~[?:1.8.0_51]
> [java] at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_51]
> [java] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_51]
> [java] at java.lang.reflect.Method.invoke(Method.java:497)
> ~[?:1.8.0_51]
> [java] at
> org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:92)
> [ofbiz-webapp.jar:?]
> [java] at
> org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:78)
> [ofbiz-webapp.jar:?]
> [java] at
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:759)
> [ofbiz-webapp.jar:?]
> [java] at
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:476)
> [ofbiz-webapp.jar:?]
> [java] at
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213)
> [ofbiz-webapp.jar:?]
> [java] at
> javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
> [servlet-api-3.0.jar:?]
> [java] at
> javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
> [servlet-api-3.0.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:324)
> [ofbiz-webapp.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> [tomcat-7.0.64-catalina.jar:7.0.64]
> [java] at
>
[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user
[ https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981765#comment-14981765 ] Hans Bakker commented on OFBIZ-6703: so, it could well be that older versions do not need patching. > Cannot create more than one lead in the SFA component by same user > -- > > Key: OFBIZ-6703 > URL: https://issues.apache.org/jira/browse/OFBIZ-6703 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Fix For: Upcoming Branch > > > Repeat steps: > # go to SFA component and click on leads > # click on create new > # fill mandatory information and save > # repeat the above steps again and observe failure > The reason for the failure is that the implementation of the createLead > service tries to create a PartyRole of type OWNER every time a lead is > created. So it works only the first time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user
[ https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981756#comment-14981756 ] Hans Bakker commented on OFBIZ-6703: this was caused, because the internal check for existence was removed from the createPartyRole service for whatever reason, and the sfa component was not updated accordingly > Cannot create more than one lead in the SFA component by same user > -- > > Key: OFBIZ-6703 > URL: https://issues.apache.org/jira/browse/OFBIZ-6703 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Fix For: Upcoming Branch > > > Repeat steps: > # go to SFA component and click on leads > # click on create new > # fill mandatory information and save > # repeat the above steps again and observe failure > The reason for the failure is that the implementation of the createLead > service tries to create a PartyRole of type OWNER every time a lead is > created. So it works only the first time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user
[ https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981756#comment-14981756 ] Hans Bakker edited comment on OFBIZ-6703 at 10/30/15 2:36 AM: -- this was caused, because the internal check for existence was removed from the createPartyRole service for whatever reason, and the sfa component was not updated accordingly if i will remember well Nicolas? was (Author: hansbak): this was caused, because the internal check for existence was removed from the createPartyRole service for whatever reason, and the sfa component was not updated accordingly > Cannot create more than one lead in the SFA component by same user > -- > > Key: OFBIZ-6703 > URL: https://issues.apache.org/jira/browse/OFBIZ-6703 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Fix For: Upcoming Branch > > > Repeat steps: > # go to SFA component and click on leads > # click on create new > # fill mandatory information and save > # repeat the above steps again and observe failure > The reason for the failure is that the implementation of the createLead > service tries to create a PartyRole of type OWNER every time a lead is > created. So it works only the first time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968330#comment-14968330
]
Hans Bakker commented on OFBIZ-6618:
Thank you for your help in this matter and holding up further development in
the area of continuous testing.
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Hans Bakker
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> {code}
> git clone https://gerrit.antwebsystems.com/growerptest
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker closed OFBIZ-6618.
--
Assignee: Hans Bakker (was: Jacques Le Roux)
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Hans Bakker
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> git clone https://gerrit.antwebsystems.com/growerptest
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hans Bakker resolved OFBIZ-6618.
Resolution: Fixed
Fix Version/s: Trunk
THank you Ruud for the patch: Committed revision 1709516
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> git clone https://gerrit.antwebsystems.com/growerptest
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966114#comment-14966114
]
Hans Bakker commented on OFBIZ-6618:
Sorry Jacques, if i did not follow the rules, was not aware that you have in
interest in this. the issue is now more than a month old, enough time for
comments and objections?
The growerptest component is being worked on, so keeping it in our repository
makes it easier for us. Since we are not using $windows, sure that could be a
problem. I have asked Ruud to have a look at the problems you found.
Concerning Ant, you should use the version supplied within the OFBiz
distribution?
Regards,
Hans
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Hans Bakker
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> git clone https://gerrit.antwebsystems.com/growerptest
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966137#comment-14966137
]
Hans Bakker commented on OFBIZ-6618:
perhaps read this issue more closely?
make it easy for you:
git clone https://gerrit.antwebsystems.com/growerptest
will get you a copy..
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Hans Bakker
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> git clone https://gerrit.antwebsystems.com/growerptest
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files
[
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966292#comment-14966292
]
Hans Bakker commented on OFBIZ-6618:
Should we include it in ofbiz in view of the slim down actions?
I would rather go for having a wiki page with components like this one, who
maintains them with the 'master' repository name.
In this case i can even give peer-write access to this repository to people who
requested it.
Regards,
Hans
> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
> Issue Type: Test
> Components: framework
>Reporter: Ruud Griepsma
>Assignee: Hans Bakker
>Priority: Minor
> Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without
> writing any Java code. This will help making GUI tests quicker and easier to
> create. Test steps and instances are defined in XML files, like example
> below, which tests the login procedure for the admin user.
> {code}
>
>
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>
>
>
>
>
>
>
>
>
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt
> file):
> {code}
> git clone https://gerrit.antwebsystems.com/growerptest
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6599) Scrum backlog status chart show errors
[ https://issues.apache.org/jira/browse/OFBIZ-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730305#comment-14730305 ] Hans Bakker commented on OFBIZ-6599: Sure Jacques, i expected such a comment, and sounds fine to me. and very good in-line with the slim down actions. > Scrum backlog status chart show errors > -- > > Key: OFBIZ-6599 > URL: https://issues.apache.org/jira/browse/OFBIZ-6599 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Wai > > Use this link > https://localhost:8443/scrum/control/ViewProduct?productId=DEMO-PRODUCT-1 > Also found errors on screen via... > https://localhost:8443/scrum/control/ProductStatistics -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6599) Scrum backlog status chart show errors
[ https://issues.apache.org/jira/browse/OFBIZ-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730305#comment-14730305 ] Hans Bakker edited comment on OFBIZ-6599 at 9/4/15 4:49 AM: Sure Jacques, i expected such a comment, and sounds fine to me. and very good in-line with the slim down actions. Perhaps we should set up a list of component providers in the wiki where users can find alternative components and add-ons. was (Author: hansbak): Sure Jacques, i expected such a comment, and sounds fine to me. and very good in-line with the slim down actions. > Scrum backlog status chart show errors > -- > > Key: OFBIZ-6599 > URL: https://issues.apache.org/jira/browse/OFBIZ-6599 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Wai > > Use this link > https://localhost:8443/scrum/control/ViewProduct?productId=DEMO-PRODUCT-1 > Also found errors on screen via... > https://localhost:8443/scrum/control/ProductStatistics -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6599) Scrum backlog status chart show errors
[ https://issues.apache.org/jira/browse/OFBIZ-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730329#comment-14730329 ] Hans Bakker commented on OFBIZ-6599: I sure will take some time before that will happenwasn't there a travel expense initiative? We could already start now with a wiki page, and use that later on for the initiative you mention? > Scrum backlog status chart show errors > -- > > Key: OFBIZ-6599 > URL: https://issues.apache.org/jira/browse/OFBIZ-6599 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Wai > > Use this link > https://localhost:8443/scrum/control/ViewProduct?productId=DEMO-PRODUCT-1 > Also found errors on screen via... > https://localhost:8443/scrum/control/ProductStatistics -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6599) Scrum backlog status chart show errors
[ https://issues.apache.org/jira/browse/OFBIZ-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730146#comment-14730146 ] Hans Bakker commented on OFBIZ-6599: We further developed the scrum component outside of the OFBiz environment. It is still available as open source and can downloaded from our git repository at: https://gerrit.antwebsystems.com/#/admin/projects/scrum > Scrum backlog status chart show errors > -- > > Key: OFBIZ-6599 > URL: https://issues.apache.org/jira/browse/OFBIZ-6599 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Wai > > Use this link > https://localhost:8443/scrum/control/ViewProduct?productId=DEMO-PRODUCT-1 > Also found errors on screen via... > https://localhost:8443/scrum/control/ProductStatistics -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6494) New implementation of the two-way cryptographic services of OFBiz based on Apache Shiro
[ https://issues.apache.org/jira/browse/OFBIZ-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581002#comment-14581002 ] Hans Bakker commented on OFBIZ-6494: thank you Jacopo, also for the junit testsgreat improvement... New implementation of the two-way cryptographic services of OFBiz based on Apache Shiro --- Key: OFBIZ-6494 URL: https://issues.apache.org/jira/browse/OFBIZ-6494 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Jacopo Cappellato Assignee: Jacopo Cappellato Fix For: Upcoming Branch New implementation of the two-way cryptographic services of OFBiz based on Apache Shiro: * two-way encryption is now delegated to Apache Shiro, with stronger initialization vectors * the mechanism is backward compatible * new tools to update the encryption of private keys, useful to upgrade older versions of OFBiz and most of all to replace old keys with new ones (this is critical to implement stronger security practices as requested by PCI) * unit tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5971) Form ListRequestItemNotes is not referenced in Screens
[ https://issues.apache.org/jira/browse/OFBIZ-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547453#comment-14547453 ] Hans Bakker commented on OFBIZ-5971: probably forgot to delete the form when it was not used anymorecan delete i assume when not used... Form ListRequestItemNotes is not referenced in Screens -- Key: OFBIZ-5971 URL: https://issues.apache.org/jira/browse/OFBIZ-5971 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: customer, note, request The form exists, but isn't referenced in a Screen in Projectmgr. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6041) form renderer insert strange html code....
[ https://issues.apache.org/jira/browse/OFBIZ-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-6041: --- Summary: form renderer insert strange html code (was: form renderer inseert starnge html code) form renderer insert strange html code -- Key: OFBIZ-6041 URL: https://issues.apache.org/jira/browse/OFBIZ-6041 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Environment: ubuntu Reporter: Hans Bakker Fix For: Upcoming Branch When going to : https://localhost:8443/catalog/control/EditProductStoreCatalogs?productStoreId=9000 with the demo data loaded and clicking on one of the catalog id's gives the popup error: null -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6041) form renderer inseert starnge html code....
Hans Bakker created OFBIZ-6041: -- Summary: form renderer inseert starnge html code Key: OFBIZ-6041 URL: https://issues.apache.org/jira/browse/OFBIZ-6041 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Environment: ubuntu Reporter: Hans Bakker Fix For: Upcoming Branch When going to : https://localhost:8443/catalog/control/EditProductStoreCatalogs?productStoreId=9000 with the demo data loaded and clicking on one of the catalog id's gives the popup error: null -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6041) form renderer insert strange html code....
[ https://issues.apache.org/jira/browse/OFBIZ-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298080#comment-14298080 ] Hans Bakker commented on OFBIZ-6041: try the tomahawk theme... Regards,Hans form renderer insert strange html code -- Key: OFBIZ-6041 URL: https://issues.apache.org/jira/browse/OFBIZ-6041 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Environment: ubuntu Reporter: Hans Bakker Fix For: Upcoming Branch When going to : https://localhost:8443/catalog/control/EditProductStoreCatalogs?productStoreId=9000 with the demo data loaded and clicking on one of the catalog id's gives the popup error: null -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5853) The createPartyRole service does not check a duplicate key.
[ https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213431#comment-14213431 ] Hans Bakker commented on OFBIZ-5853: if you think that changing services incompatible to previous versions and therefore make upgrading unnessaryly difficult is a good idea, then go ahead. Actually esspecially here where the problem will only show in user functions, external to the standard ofbiz will only show in production. I can only wonder why you want to do that Hans The createPartyRole service does not check a duplicate key. --- Key: OFBIZ-5853 URL: https://issues.apache.org/jira/browse/OFBIZ-5853 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Supatthra Nawicha Assignee: Nicolas Malin Priority: Minor Fix For: Trunk Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5853) The createPartyRole service does not check a duplicate key.
[ https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204210#comment-14204210 ] Hans Bakker commented on OFBIZ-5853: I am sorry, i have better ways to spend my time, my last comment: revert the change you did on createPartyRole for reason it is incompatible with the previous version and it is used many times inside OFBiz and in user code. Hans The createPartyRole service does not check a duplicate key. --- Key: OFBIZ-5853 URL: https://issues.apache.org/jira/browse/OFBIZ-5853 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Supatthra Nawicha Assignee: Nicolas Malin Priority: Minor Fix For: Trunk Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5853) The createPartyRole service does not check a duplicate key.
[ https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201436#comment-14201436 ] Hans Bakker commented on OFBIZ-5853: I am sorry Party Role is a special case, not the same as other single index entities. Many entities have the role in the key. If you want to add a record in such an entity you have to check if the user has the RoletypeId and when not add it. THat is why the existence check is in the addRoletype service. As your peer committer I ask you to please put the orginal service back which has existence check. Do not force me to change the service name only you want to put the autoservice everywhere. This is a special case. Regards,'Hans The createPartyRole service does not check a duplicate key. --- Key: OFBIZ-5853 URL: https://issues.apache.org/jira/browse/OFBIZ-5853 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Supatthra Nawicha Assignee: Nicolas Malin Priority: Minor Fix For: Trunk Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5853) The createPartyRole service does not check a duplicate key.
[ https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201439#comment-14201439 ] Hans Bakker commented on OFBIZ-5853: remember many people have build there own services and you force these to change the servicename, only because you like it. Not enough reason. Sorry. The createPartyRole service does not check a duplicate key. --- Key: OFBIZ-5853 URL: https://issues.apache.org/jira/browse/OFBIZ-5853 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Supatthra Nawicha Assignee: Nicolas Malin Priority: Minor Fix For: Trunk Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5846) Field definition problem, program should use purposeFromDate in stead of fromDate.
[ https://issues.apache.org/jira/browse/OFBIZ-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-5846. -- Resolution: Fixed Committed revision 1636493. Field definition problem, program should use purposeFromDate in stead of fromDate. -- Key: OFBIZ-5846 URL: https://issues.apache.org/jira/browse/OFBIZ-5846 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Supachai Chaima-ngua Labels: partymgr Fix For: Trunk Attachments: ofbizbug-deleltecontectmech.patch field definition problem, program should use purposeFromDate in stead of fromDate. deletePcmCtx.put(fromDate, tempVal.get(purposeFromDate)); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5845) The createSalesOpportunityLeadRole service does not check if PartyRole already exist.
[ https://issues.apache.org/jira/browse/OFBIZ-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5845: --- Summary: The createSalesOpportunityLeadRole service does not check if PartyRole already exist. (was: The createSalesOpportunityLeadRole service does not check existing PartyRole.) The createSalesOpportunityLeadRole service does not check if PartyRole already exist. - Key: OFBIZ-5845 URL: https://issues.apache.org/jira/browse/OFBIZ-5845 Project: OFBiz Issue Type: Bug Components: marketing Affects Versions: Trunk Reporter: Supachai Chaima-ngua Labels: marketing Fix For: Trunk Attachments: ofbizbug-partyrolelead.patch When I create SalesOpportunity by using existing lead party then system will automatic create party role lead with out party role checking. So the system will return error and do not make sense. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5845) The createSalesOpportunityLeadRole service does not check if PartyRole already exist.
[ https://issues.apache.org/jira/browse/OFBIZ-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-5845. -- Resolution: Fixed Committed revision 1636495 The createSalesOpportunityLeadRole service does not check if PartyRole already exist. - Key: OFBIZ-5845 URL: https://issues.apache.org/jira/browse/OFBIZ-5845 Project: OFBiz Issue Type: Bug Components: marketing Affects Versions: Trunk Reporter: Supachai Chaima-ngua Labels: marketing Fix For: Trunk Attachments: ofbizbug-partyrolelead.patch When I create SalesOpportunity by using existing lead party then system will automatic create party role lead with out party role checking. So the system will return error and do not make sense. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5631) service getFxConversion is never used
[ https://issues.apache.org/jira/browse/OFBIZ-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177813#comment-14177813 ] Hans Bakker commented on OFBIZ-5631: Just because that the service is not used in the standard ERP application is not a reason to remove. If the E-commerce would have the automatic price conversion in different exchange rates, you would use this service. If you would have looked a bit further you can see that it is not so easy to get the exchange rate conversion function used and that is why the service was created. I suggest to keep it. Regards,'Hans service getFxConversion is never used - Key: OFBIZ-5631 URL: https://issues.apache.org/jira/browse/OFBIZ-5631 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Pierre Smits Assignee: Hans Bakker Priority: Minor service getFxConversion got incorporated in r891159. However, it is not used anywhere. I propose to remove it as part of the trim down effort -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-5631) service getFxConversion is never used
[ https://issues.apache.org/jira/browse/OFBIZ-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177813#comment-14177813 ] Hans Bakker edited comment on OFBIZ-5631 at 10/21/14 1:46 AM: -- Just because that the service is not used in the standard ERP application is not a reason to remove. If the E-commerce would have the automatic price conversion in different exchange rates, you would use this service. There are much more services and entity views created which are not used but try to solve common world problems If you would have looked a bit further you can see that it is not so easy to get the exchange rate conversion function used and that is why the service was created. I suggest to keep it. Regards,'Hans was (Author: hansbak): Just because that the service is not used in the standard ERP application is not a reason to remove. If the E-commerce would have the automatic price conversion in different exchange rates, you would use this service. If you would have looked a bit further you can see that it is not so easy to get the exchange rate conversion function used and that is why the service was created. I suggest to keep it. Regards,'Hans service getFxConversion is never used - Key: OFBIZ-5631 URL: https://issues.apache.org/jira/browse/OFBIZ-5631 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Pierre Smits Assignee: Hans Bakker Priority: Minor service getFxConversion got incorporated in r891159. However, it is not used anywhere. I propose to remove it as part of the trim down effort -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5699) NPE on a virtual product in configurable good
[ https://issues.apache.org/jira/browse/OFBIZ-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159782#comment-14159782 ] Hans Bakker commented on OFBIZ-5699: Or provide a junit test case which shows the error? That would really be nice! Regards, Hans NPE on a virtual product in configurable good - Key: OFBIZ-5699 URL: https://issues.apache.org/jira/browse/OFBIZ-5699 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release Branch 13.07 Reporter: Guillaume Sigoigne Assignee: Nicolas Malin In a configurable good, I have an option with a component. This component is a virtual product with several variants products. When the configurable good is ordered, a NPE appears instead of configuration page. The NPE is here : ProductConfigWorker.storeProductConfigWrapper() l.347 String componentOption = oneOption.componentOptions.get(component.getString(productId)); oneOption exists, but oneOption.componentOptions is null -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-5642) remove BLOB fields from sales opportunity
Hans Bakker created OFBIZ-5642: -- Summary: remove BLOB fields from sales opportunity Key: OFBIZ-5642 URL: https://issues.apache.org/jira/browse/OFBIZ-5642 Project: OFBiz Issue Type: Improvement Components: specialpurpose/assetmaint Affects Versions: SVN trunk Reporter: Hans Bakker Priority: Minor Fix For: SVN trunk the description and nextStep fields are currently defined as CLOB which causes searching these fields in certain databases while a CLOB is not required at all. They should be changed to VARCAHR(255) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (OFBIZ-2117) Add payrol functions to ofbiz
[ https://issues.apache.org/jira/browse/OFBIZ-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-2117. -- Resolution: Fixed We are working on this and will contribute this function later Add payrol functions to ofbiz - Key: OFBIZ-2117 URL: https://issues.apache.org/jira/browse/OFBIZ-2117 Project: OFBiz Issue Type: New Feature Components: accounting, humanres Affects Versions: SVN trunk Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: payrol.txt Add payrol functions, in other words be able to enter and calculate the payslip for the employees -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OFBIZ-5040) Backend widget application HTML clean-up
[ https://issues.apache.org/jira/browse/OFBIZ-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882287#comment-13882287 ] Hans Bakker commented on OFBIZ-5040: Jacques, i completely agree with you, forms should be used as much as possible, I am talking backend. Frontend macros would be nice. Forms are much easier to create and maintain, but sure have their limitations. However if there is a limitation, try to add a functions to the widget to solve that not sure but did we had this discussion before? I implemented the project manager and had to replace tons of ftl screens in a earlier much more simple version. Regards, Hans Backend widget application HTML clean-up -- Key: OFBIZ-5040 URL: https://issues.apache.org/jira/browse/OFBIZ-5040 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Reporter: Paul Piper Labels: html, webapp, widget, widgetrendering I am sure that this is a common thing to know: the current backoffice application relies heavily on widgets. This is good, but the current standard-html-structure is not flexible enough and often lacks proper w3c implementation. To make matters worse, you can often find applications avoiding widgets at all and rather overriding the standards with custom ftl implementations. It is these customizations that break the html on numerous screens and make it difficult, if not tedious to create new themes for the backoffice. This task is hence to: * Find a consensus on a new widget standard * Go over each of the application ftls and convert these to the new standard * Recreate the themes and simplify/clean-up special rules Since redoing the theme is a rather large task, we should consider to add an additional css for now which stylises the replacement html instead of working with the old. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857343#comment-13857343 ] Hans Bakker commented on OFBIZ-5282: Hi Jacopo, thank you for your valuable input and your time. I agree with all of the comments regarding the implementation coding, As you noticed there are a number of rough edges, however the function works what is the most important. Another point what i would like to mention is that this function is hardly visible for someone who does not want to use it, however can save us a lot of time keeping this large patch updated as an alternative what we currently do in our git repository. Leaves the major point of this Issue, can it be committed to the trunk? This would certain help our implementation with this large customer which should benefit Apache OFBiz tremendously by the acceptance in larger companies. Regards, Hans Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Fix For: SVN trunk Attachments: ledgersegment-2013-12-24.patch, ledgersegmentOct18.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853630#comment-13853630 ] Hans Bakker commented on OFBIZ-5282: It is a pity that this community not seems to be interested in functionality which is essential for large companies such as accounting segments or sometimes called accounting tagging or tags. The current patch is already out of date. So for large companies we have created a git repository called Growerp-Prof at http://gerrit.antwebsystems.com which is the OFBiz trunk converted from OFBiz SVN to Git which will be updated daily and where we will keep the functionality of ledger segments or tags updated among other functionality important for large companies. i will close this issue for now. Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Jacopo Cappellato Fix For: SVN trunk Attachments: ledgersegmentOct18.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Closed] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-5282. -- Resolution: Won't Fix Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Jacopo Cappellato Fix For: SVN trunk Attachments: ledgersegmentOct18.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Comment Edited] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853630#comment-13853630 ] Hans Bakker edited comment on OFBIZ-5282 at 12/20/13 4:21 AM: -- It is a pity that this community not seems to be interested in functionality which is essential for large companies such as accounting segments or sometimes called accounting tagging or tags. The current patch is already out of date. So for large companies we have created a git repository called Growerp-Prof at http://gerrit.antwebsystems.com which is the OFBiz trunk converted from OFBiz SVN to Git which will be updated daily and where we will keep the functionality of ledger segments or tags updated among other functionality important for large companies. Please note that all repositories visible at jenkins.antwebsystems.com all have the apache 2 license and can be downloaded without restriction with any Git client program. i will close this issue for now. was (Author: hansbak): It is a pity that this community not seems to be interested in functionality which is essential for large companies such as accounting segments or sometimes called accounting tagging or tags. The current patch is already out of date. So for large companies we have created a git repository called Growerp-Prof at http://gerrit.antwebsystems.com which is the OFBiz trunk converted from OFBiz SVN to Git which will be updated daily and where we will keep the functionality of ledger segments or tags updated among other functionality important for large companies. i will close this issue for now. Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Jacopo Cappellato Fix For: SVN trunk Attachments: ledgersegmentOct18.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848605#comment-13848605 ] Hans Bakker commented on OFBIZ-5282: this topic is now outstanding for almost 6 months without substantial comments and the latest update for review is now 5 weeks old. When there are no further objections I will commit this the end of next week. Regards, Hans Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Jacopo Cappellato Fix For: SVN trunk Attachments: ledgersegmentOct18.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegment.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentOct18.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: ledgersegmentOct18.patch latest patch, correcting problems with quickly add transactions no updates foreseen in the near future...would like to commit. Jacopo, can you have a look? Regards, Hans Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentOct18.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to safe
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801399#comment-13801399
]
Hans Bakker commented on OFBIZ-5254:
sounds fine Jacques and thanks taking care of of this.
Regards,
Hans
Services allow arbitrary HTML for parameters with allow-html set to safe
--
Key: OFBIZ-5254
URL: https://issues.apache.org/jira/browse/OFBIZ-5254
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Christoph Neuroth
Assignee: Jacques Le Roux
Labels: security
For any given service with allow-html=safe parameters, the parameter data is
not properly validated. See Model.Service.java:588:
{code}
StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
errorMessageList);
{code}
Looking at that method:
{code}
public static String checkStringForHtmlSafeOnly(String valueName, String
value, ListString errorMessageList) {
ValidationErrorList vel = new ValidationErrorList();
value = defaultWebValidator.getValidSafeHTML(valueName, value,
Integer.MAX_VALUE, true, vel);
errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
String.class));
return value;
}
{code}
you can see that it expects the defaultWebValidator.getValidSafeHTML would
add all validation errors to the given ValidationErrorList, but if you look
at the implementation of ESAPI that is not the case. First, consider the
overloaded getValidSafeHTML that takes the ValidationErrorList:
{code}public String getValidSafeHTML(String context, String input,
int maxLength, boolean allowNull, ValidationErrorList errors) throws
IntrusionException {
try {
return getValidSafeHTML(context, input, maxLength,
allowNull);
} catch (ValidationException e) {
errors.addError(context, e);
}
return input;
}
{code}
Then, step into that method to see that ValidationExceptions are only thrown
for things like exceeding the maximum length - not for policy violations that
can be cleaned, such as tags that are not allowed by the policy:
{code}
AntiSamy as = new AntiSamy();
CleanResults test = as.scan(input, antiSamyPolicy);
List errors = test.getErrorMessages();
if ( errors.size() 0 ) {
// just create new exception to get it logged
and intrusion detected
new ValidationException( Invalid HTML input:
context= + context, Invalid HTML input: context= + context + , errors= +
errors, context );
}
{code}
I guess that is an expected, although maybe not clearly documented behavior
of ESAPI: Non-cleanable violations throw the exception and therefore will
fail the ofbiz service, while non-allowed tags are cleaned. However, if you
consider ModelService:588 and following lines again:
{code}
StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
errorMessageList);
//(...)
if (errorMessageList.size() 0) {
throw new ServiceValidationException(errorMessageList, this,
mode);
}
{code}
the cleaned return value is ignored. Therefore, you will see an
IntrusionDetection in the logs, giving you a false sense of security but
the unfiltered HTML will still go into the service. So, if you want the
service to fail if non-allowed HTML is encountered, you should use
isValidSafeHTML instead. If you want the incoming HTML to be filtered, you
should use the return value of getValidSafeHTML.
Some additional notes on this:
* When changing this, it should be properly documented as users may well be
relying on this behavior - for example, we send full HTML mails to our
customers for their ecommerce purchases and require HTML to go through - so
maybe for services like the communicationEvents allowing only safe HTML might
not be desired.
* The ESAPI code samples above are from version 1.4.4. I was really surprised
to find a JAR that is not only outdated, but patched and built by a third
party, without even indicating that in the filename in OfBiz trunk. This has
been there for years (see OFBIZ-3135) and should really be replaced with an
official, up to date version since that issue was fixed upstream years ago.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: ledgersegment.patch Latest patch now including trial balance report to show the ledger is also balanced at a segment level when posting from order - invoice Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegment.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegmentOct14.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegment.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to safe
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798755#comment-13798755
]
Hans Bakker commented on OFBIZ-5254:
not sure what comment you want, but '' '' and '' should be possible in
descriptions and names what was the reason of the change to ';safe'
Services allow arbitrary HTML for parameters with allow-html set to safe
--
Key: OFBIZ-5254
URL: https://issues.apache.org/jira/browse/OFBIZ-5254
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Christoph Neuroth
Assignee: Jacques Le Roux
Labels: security
For any given service with allow-html=safe parameters, the parameter data is
not properly validated. See Model.Service.java:588:
{code}
StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
errorMessageList);
{code}
Looking at that method:
{code}
public static String checkStringForHtmlSafeOnly(String valueName, String
value, ListString errorMessageList) {
ValidationErrorList vel = new ValidationErrorList();
value = defaultWebValidator.getValidSafeHTML(valueName, value,
Integer.MAX_VALUE, true, vel);
errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
String.class));
return value;
}
{code}
you can see that it expects the defaultWebValidator.getValidSafeHTML would
add all validation errors to the given ValidationErrorList, but if you look
at the implementation of ESAPI that is not the case. First, consider the
overloaded getValidSafeHTML that takes the ValidationErrorList:
{code}public String getValidSafeHTML(String context, String input,
int maxLength, boolean allowNull, ValidationErrorList errors) throws
IntrusionException {
try {
return getValidSafeHTML(context, input, maxLength,
allowNull);
} catch (ValidationException e) {
errors.addError(context, e);
}
return input;
}
{code}
Then, step into that method to see that ValidationExceptions are only thrown
for things like exceeding the maximum length - not for policy violations that
can be cleaned, such as tags that are not allowed by the policy:
{code}
AntiSamy as = new AntiSamy();
CleanResults test = as.scan(input, antiSamyPolicy);
List errors = test.getErrorMessages();
if ( errors.size() 0 ) {
// just create new exception to get it logged
and intrusion detected
new ValidationException( Invalid HTML input:
context= + context, Invalid HTML input: context= + context + , errors= +
errors, context );
}
{code}
I guess that is an expected, although maybe not clearly documented behavior
of ESAPI: Non-cleanable violations throw the exception and therefore will
fail the ofbiz service, while non-allowed tags are cleaned. However, if you
consider ModelService:588 and following lines again:
{code}
StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
errorMessageList);
//(...)
if (errorMessageList.size() 0) {
throw new ServiceValidationException(errorMessageList, this,
mode);
}
{code}
the cleaned return value is ignored. Therefore, you will see an
IntrusionDetection in the logs, giving you a false sense of security but
the unfiltered HTML will still go into the service. So, if you want the
service to fail if non-allowed HTML is encountered, you should use
isValidSafeHTML instead. If you want the incoming HTML to be filtered, you
should use the return value of getValidSafeHTML.
Some additional notes on this:
* When changing this, it should be properly documented as users may well be
relying on this behavior - for example, we send full HTML mails to our
customers for their ecommerce purchases and require HTML to go through - so
maybe for services like the communicationEvents allowing only safe HTML might
not be desired.
* The ESAPI code samples above are from version 1.4.4. I was really surprised
to find a JAR that is not only outdated, but patched and built by a third
party, without even indicating that in the filename in OfBiz trunk. This has
been there for years (see OFBIZ-3135) and should really be replaced with an
official, up to date version since that issue was fixed upstream years ago.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: ledgersegmentOct14.patch updated patch for trunk. Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentOct14.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegmentOct10.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentOct14.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: ledgersegmentOct10.patch The latest patch for the following functions: 1. patch now works on the latest trunk 2. a combination of segment values can now be attached to an accounting entry 3. implemented on purchase order/invoice and (quick) manual transaction entry. 4. reformatting removed Regards, Hans Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentOct10.patch, ledgersegmentsR1517434 .patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegmentsR1517434 .patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentOct10.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: segmentImport.xml) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentOct10.patch We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13783579#comment-13783579 ] Hans Bakker commented on OFBIZ-5282: we are still working on this function, looks like unwanted re-formatting has taken place which will be taken out later. Expect another patch next week. Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentsR1517434 .patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: ledgersegmentsR1517434 .patch improved patch now including segments for 'quick create acct transaction' and showing segments at the transactions details. Improved and better re-ugae of code. This patch still for ofbiz R1517434 Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, ledgersegmentsR1517434 .patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegments.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentsR1517434 .patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779690#comment-13779690 ] Hans Bakker edited comment on OFBIZ-5282 at 9/27/13 6:02 AM: - improved patch now including segments for 'quick create acct transaction' and showing segments at the transactions details. Improved and better re-usage of code. This patch still for ofbiz R1517434 was (Author: hansbak): improved patch now including segments for 'quick create acct transaction' and showing segments at the transactions details. Improved and better re-ugae of code. This patch still for ofbiz R1517434 Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegmentsR1517434 .patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegments.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: ledgersegments.patch latest patch with entity field adjustments, created some new services. This patch is a commit candidate, comments welcome. Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756428#comment-13756428 ] Hans Bakker commented on OFBIZ-5282: Thank you Jacopo, looking forward to your comments. Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: ledgersegments.patch junit tests did not run, corrected in this patch Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegments.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegment.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: stannahAccnt.5.diff) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: ledgersegments.patch, segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5282) Introduce Accounting ledger segmentation
[ https://issues.apache.org/jira/browse/OFBIZ-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5282: --- Attachment: (was: ledgersegments.patch) Introduce Accounting ledger segmentation Key: OFBIZ-5282 URL: https://issues.apache.org/jira/browse/OFBIZ-5282 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Environment: any Reporter: Hans Bakker Assignee: Hans Bakker Fix For: SVN trunk Attachments: segmentImport.xml We have the possibility here to be able to introduce Apache OFBiz accounting in a large multi company organization. This organization is evaluating the several alternatives and after evaluation of OFBiz, came up with a function which OFBiz needs to have, in order to be considered. The user story: Although OFBiz accounting has the 'costcenter' function, it is not fine-grained enough, we need to be able to segment the ledger to a lower level that the GL accounts namely to the accounting transaction.. Further, all existing reports should have the facility to be able to select a segment of the ledger for either costing, profit or other purposes like special projects. The proposed user interface. We need at least at the order item level the ability to specify a parent-segment/segment and a percentage, if the percentange is not 100% the remainder to 100% should be assigned to another segment. These segments can be defined and assigned by the user to the order item upon entry. When the related invoice is created the segment(s) will be copied and can overridden before posting when these segment names will be copied to the accounting transaction. The proposed user reporting. All existing ledger reports will have the additional ability to select these segments and will only incorporate accounting transactions where this segment is specified. The proposed technical implementation. 1. add a new entity called LedgerSegment with fields: ledgerSegmentId, parentSegmentId, description 2. add another 3 similar entities: OrderItemSegment, InvoiceItemSegment, AcctTransSegment to make the relation to the LedgerSegment entity and to specify the percentage. 3. Change the order, invoice, accounting transaction screens and ledger report entity views to be able to use the segment names when available in the LedgerSegment entity As i said , please let me know what you think, this is a great opportunity for OFBiz accounting. Regards, Hans Bakker CEO AntWebsystems.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
