[jira] [Commented] (OFBIZ-4765) build.xml in hot-deploy folder is not called correctly in the main build.xml
[ https://issues.apache.org/jira/browse/OFBIZ-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244009#comment-13244009 ] Markus M. May commented on OFBIZ-4765: -- The applied patch is pretty much the same solution as before. Only if a hot-deploy/build.xml is available, the main build.xml is using this one. In all other cases the solution is doing the same as before. Could you please review the patch and apply it? build.xml in hot-deploy folder is not called correctly in the main build.xml Key: OFBIZ-4765 URL: https://issues.apache.org/jira/browse/OFBIZ-4765 Project: OFBiz Issue Type: Wish Affects Versions: SVN trunk Reporter: Markus M. May Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4765-fix-buildxml.patch, OFBIZ-4765-use-hotdeploy-buildxml-if-available.patch In the current build.xml in the ofbiz-Home-folder, the build target is executed for each subdirectory (framework, application, specialpurpose) with the fileset: filelist dir=. files=specialpurpose/build.xml/ Only for the hot-deploy folder the fileset is quite different: fileset dir=${basedir}/hot-deploy casesensitive=no exclude name=disabled/**/ include name=*/build.xml/ /fileset This is calling the build.xml directly in the hot-deploy components, which is an error, if you do have several dependent components in there, which needs to get build in the right order. I propose to use the following filelist: filelist dir=. files=hot-deploy/build.xml/ Problem could be, that not every project do have an build.xml file in this folder (or is this already a requirement?). If it is not then we would need to check, if this build.xml is there, then execute this, and otherwise use the already existing one. A patch will be applied for the first solution. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4763) create and use startup profiles
[ https://issues.apache.org/jira/browse/OFBIZ-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240311#comment-13240311 ] Markus M. May commented on OFBIZ-4763: -- I really do like the solution Michael proposed (I am currently working with this one). In the light of the OFBIZ diet I definitly would like to suggest to keep the configuration-templates in the corresponding components (in contrast to Michaels solution). Furthermore we probably need to adopt the solution slightly in that the profile configuration files should be splitted, so that there is not a central, big configuration like e.g. local.properties, but ones for components e.g. local-base.properties or production-base.properties. I guess that not all configuration parameters could/should be stored in the DB (e.g. port configurations, or even db connection parameters itself). Therefor we do have IMHO two kind of properties, technical and functional properties. Technical properties are more likely to not end up in the db and these should definitly be configured in property files and these are right now not really easy to handle. WDYT? create and use startup profiles --- Key: OFBIZ-4763 URL: https://issues.apache.org/jira/browse/OFBIZ-4763 Project: OFBiz Issue Type: New Feature Affects Versions: SVN trunk Reporter: Erwan de FERRIERES Assignee: Erwan de FERRIERES Fix For: SVN trunk from this thread http://ofbiz.135035.n4.nabble.com/OFBiz-integration-in-Apache-sonar-instance-td4484597.html we should be able to choose a profile when starting OFBiz, which will configure at least the ports used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4763) create and use startup profiles
[ https://issues.apache.org/jira/browse/OFBIZ-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239903#comment-13239903 ] Markus M. May commented on OFBIZ-4763: -- Hello, I would like to use the following process, like already written in the ML (see above thread): 1) read environment variables 2) read variables from a set profile-properties file 3) read default variables 4) set variables in the configuration-XML-files of ofbiz The profile-specific properties (e.g. local, test, production) are read from the profile-properties files, which are named like the profile (above mentioned local, test and production) and which are chosen based on the environment variable profile. So, if a variable -Dprofile=local is given on the ant command line, the property file runtime/config/local.properties is read. If no variable is given a default value is used (local?). All variables set in these files can be set via command line parameters as well. The main point here is now how to replace the variables in the already existing configuration files (e.g. framework/base/config/ofbiz-containers.xml). IMHO, we should move these configuration files to the framework/base/conf-templates directory and put the variables (e.g. ${port}) in there. On the call of the config-task in ant (which is a dependency of the run-task) these files are copied and the variables are replaced through the set values. This would mean, that we do move several files and put the original ones into the .gitignore, .hgignore, svn:ignore properties/files. Most probably we would also need to check if these files do exist in the platform specific startup-scripts, otherwise the ant-task would need to get called or an error message is to be thrown. We need to define, what kind of properties we would like to configure centrally. This could be a start small approach or an all or nothing approach. I would like to keep it simple and just start with the hostname and port-stuff, which is the reason why this issue came up. WDYT? create and use startup profiles --- Key: OFBIZ-4763 URL: https://issues.apache.org/jira/browse/OFBIZ-4763 Project: OFBiz Issue Type: New Feature Affects Versions: SVN trunk Reporter: Erwan de FERRIERES Assignee: Erwan de FERRIERES Fix For: SVN trunk from this thread http://ofbiz.135035.n4.nabble.com/OFBiz-integration-in-Apache-sonar-instance-td4484597.html we should be able to choose a profile when starting OFBiz, which will configure at least the ports used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235469#comment-13235469 ] Markus M. May commented on OFBIZ-2628: -- Hello, I have already written a short comment on [#OFBIZ-2837], this does not seem to be resolved, we still face this issue in the ecommerce application. We are using ofbiz trunk. No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Assignee: Sascha Rodekamp Priority: Critical Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2837) Wildcard (%) characters in search fields are manipulated/truncated in screens throughout the system
[ https://issues.apache.org/jira/browse/OFBIZ-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235021#comment-13235021 ] Markus M. May commented on OFBIZ-2837: -- I am having the same issue with special characters (Umlaute) in the search field still. Probably still an issue with OFIBZ-2628? Wildcard (%) characters in search fields are manipulated/truncated in screens throughout the system --- Key: OFBIZ-2837 URL: https://issues.apache.org/jira/browse/OFBIZ-2837 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Vince Clark Priority: Critical Original thread from Nabble: http://www.nabble.com/-CA-bug-td24764527.html#a24764527 Examples: 02S%000 - I searched on this string in the orderId field of OrderHeader in entity data maintenance. Got an error on this one: (ERROR: invalid byte sequence for encoding UTF8: 0x00) When I shorten it or change it up a bit I don't get the error but the % get's replaced with a space and I get no results. For example: 02S%09070201 gets replaced with 02S 070201 (the % and 09 were removed). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221951#comment-13221951 ] Markus M. May commented on OFBIZ-4715: -- No problem using the same variable all over ;-) The patch calls now postalAddressHtmlFormatter or postalAddressPdfFormatter in the PartyScreens.xml from Contact.ftl and companyHeader.fo.ftl and ordercontactinfo.ftl as well as quoteReportContactMechs.fo.ftl. A ${setRequestAttribute(postalAddress, toPostalAddress)} is called before the screen is rendered, to set the postalAddress accordingly. The postalAddress.fo.ftl as well as postalAddress.ftl are aggregated into the applications/party/webapp/partymgr/party/contactmechtemplates/ folder. Hope this helps ;-) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code Key: OFBIZ-4715 URL: https://issues.apache.org/jira/browse/OFBIZ-4715 Project: OFBiz Issue Type: Bug Components: party, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Markus M. May Assignee: Jacopo Cappellato Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13219357#comment-13219357 ] Markus M. May commented on OFBIZ-4715: -- Hi Jacopo, thanks for the Input. I can try to use postalAddress instead of usedPostalAddress, I just wanted to avoid Naming Conflicts for the variables, so that we are able to use the same script for multiple Screens. I was thinking along the lines that the same script multiple could only be called multiple times, if the corresponding variable is not already used in the same Screen. Otherwise the variable in the Screen would probably overwrite an already existing variable and therefor would return a wrong result. Am I wrong with this assumption? Other then that, I will dig into this and will try to solve this asap. Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code Key: OFBIZ-4715 URL: https://issues.apache.org/jira/browse/OFBIZ-4715 Project: OFBiz Issue Type: Bug Components: party, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Markus M. May Assignee: Jacopo Cappellato Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214522#comment-13214522 ] Markus M. May commented on OFBIZ-4715: -- These are a lot of different ways on how to do this. How should this be implemented in a common way. I am thinking about a configuration via an XML-Locale file. This is on the other hand a misuse of locales, since I would retrieve the locale via the country code and not from the user locale. What do you think? Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code Key: OFBIZ-4715 URL: https://issues.apache.org/jira/browse/OFBIZ-4715 Project: OFBiz Issue Type: Bug Components: party, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Markus M. May Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214573#comment-13214573 ] Markus M. May commented on OFBIZ-4715: -- Jacopo: This solution is interesting. The only problem I do see is that we do need a new database entity (PostalAddressFTL) which references the CountryCode and also the ftl for this (e.g. PostalAddress_USA.ftl). Furthermore if an FTL does not exist for a countryCode we need a default ftl (PostalAddress.ftl). Then this data needs to get retrieved from the DB (which is quite easy), and the seed data needs to get extended for each FTL. Sounds like a lot of effort and also a lot of things, which could be forgotten or could go wrong. WDYT? Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code Key: OFBIZ-4715 URL: https://issues.apache.org/jira/browse/OFBIZ-4715 Project: OFBiz Issue Type: Bug Components: party, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Markus M. May Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214884#comment-13214884 ] Markus M. May commented on OFBIZ-4715: -- I am currently a little lost in this task. Guess I will push it back a little ;-( Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code Key: OFBIZ-4715 URL: https://issues.apache.org/jira/browse/OFBIZ-4715 Project: OFBiz Issue Type: Bug Components: party, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Markus M. May Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4664) logs are no more generated
[ https://issues.apache.org/jira/browse/OFBIZ-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212481#comment-13212481 ] Markus M. May commented on OFBIZ-4664: -- I checked this as well, and in our installation the logs occur just fine. logs are no more generated -- Key: OFBIZ-4664 URL: https://issues.apache.org/jira/browse/OFBIZ-4664 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: SVN trunk Reporter: Erwan de FERRIERES Assignee: Sascha Rodekamp Priority: Critical Fix For: SVN trunk with trunk rev 1232158 runtime/logs/ofbiz.html is no more existing. runtime/logs has just in it the access-log Is this coming from the sl4j changes ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212482#comment-13212482 ] Markus M. May commented on OFBIZ-2628: -- The patch is not attached to this ticket anymore. Would like to help out here, do you still have the patch somewhere, so that the start is easier? No Url encoding for get parameters -- Key: OFBIZ-2628 URL: https://issues.apache.org/jira/browse/OFBIZ-2628 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk Environment: All Reporter: Patrick Antivackis Priority: Critical Original Estimate: 4h Remaining Estimate: 4h Let's say I want to create a new category which ID is DVD+R Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId= of the url is wrong as it's not url encoded, so we have : https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD#43;R instead of https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR Both @ofbizUrl tag and menu widgets are not encoding get parameters. Way to correct : framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder Beofre i do the fix, can a core developper let me know about possible side effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3844) Splitting CommonRate and CommonProductRating
[ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208346#comment-13208346 ] Markus M. May commented on OFBIZ-3844: -- +1 for Adrians Suggestion Splitting CommonRate and CommonProductRating Key: OFBIZ-3844 URL: https://issues.apache.org/jira/browse/OFBIZ-3844 Project: OFBiz Issue Type: Improvement Components: framework, product Affects Versions: Release 09.04 Environment: irrelevant, only XML and FTL changes Reporter: Carsten Schinzer Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 09.04 Attachments: 0001-OFBIZ-3844_commonRate_and_commonRating.patch, 0002-OFBIZ-3844_commonRate_and_commonRating.patch, OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch Original Estimate: 1h Remaining Estimate: 1h The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made. The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label. Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3868) Adding de UI Lables on framework CommonUILabels
[ https://issues.apache.org/jira/browse/OFBIZ-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208027#comment-13208027 ] Markus M. May commented on OFBIZ-3868: -- Added a new patch which should be working ;-) Adding de UI Lables on framework CommonUILabels --- Key: OFBIZ-3868 URL: https://issues.apache.org/jira/browse/OFBIZ-3868 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: irrelevant; XML config data Reporter: Carsten Schinzer Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 0001-OFBIZ-3868_UI_Labels_on_CommonUiLabels.patch, OFBIZ-3868_Adding de UI Lables on framework CommonUILabels.patch, OFBIZ-3868_Adding de UI Lables on framework CommonUILabels.patch Original Estimate: 1h Remaining Estimate: 1h All missing de UI labels have been added in the CommonUiLables.xml file. Note: This patch also includes the UI Labels required for JIRA issue OFBIZ-3844 (i.e. replacing the OFBIZ-3844_Splitting CommonRate and CommonProductRating_part2.patch which has now been removed from OFBIY-3844. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3844) Splitting CommonRate and CommonProductRating
[ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208043#comment-13208043 ] Markus M. May commented on OFBIZ-3844: -- The attached patches will most probably only work if issue OFBIZ-3868 is already resolved. Splitting CommonRate and CommonProductRating Key: OFBIZ-3844 URL: https://issues.apache.org/jira/browse/OFBIZ-3844 Project: OFBiz Issue Type: Improvement Components: framework, product Affects Versions: Release 09.04 Environment: irrelevant, only XML and FTL changes Reporter: Carsten Schinzer Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 09.04 Attachments: 0001-OFBIZ-3844_commonRate_and_commonRating.patch, 0002-OFBIZ-3844_commonRate_and_commonRating.patch, OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch Original Estimate: 1h Remaining Estimate: 1h The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made. The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label. Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3946) add an SQL query manager
[ https://issues.apache.org/jira/browse/OFBIZ-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206462#comment-13206462 ] Markus M. May commented on OFBIZ-3946: -- Hi, I found this issue kind of interesting. The patch is already in my local working branch and seems to be working (well, mostly). Unfortunately there seems to be a dependency added from webtools to the application/content, because of an entity defined in there needed for the webtools. Question is now, how to approach something like this correctly. IMHO it is a no-go to reference the application/content from the webtools. Should this tool be packed into its own component then? add an SQL query manager Key: OFBIZ-3946 URL: https://issues.apache.org/jira/browse/OFBIZ-3946 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Gaudin Pierre Assignee: Erwan de FERRIERES Fix For: SVN trunk Attachments: query_manager_patch.txt This is a new feature to manage SQL queries. You can : - store/update/delete SQL query - store/update/delete parameters for this query - execute query and view results into worksheet This SQL query manager is usefull to run frequently queries (ie: for maintenance report) How to use it : - goes to webtools/Entity Engine Tools - select SQL queries library item - create a new query and fill in SQL. If you want to use parameters, add them like this : select * from facility where facility_Id = '${facilityId}' - to declare parameters for this query then goes to Add or update query parameter screenlet and fill in fields : description = facility id ; Parameter = facilityId - to execute SQl query then press buton run - fill in parameters value adn press buton run - worksheet should automaticaly open -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3946) add an SQL query manager
[ https://issues.apache.org/jira/browse/OFBIZ-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206499#comment-13206499 ] Markus M. May commented on OFBIZ-3946: -- Ah, sure. The patch references application/content because the results are transformed to XLS, and therefor it needs the POI dependencies found in the application/content component. Guess this whole thing is not really what I wanted. Anyway, thanks for your input. add an SQL query manager Key: OFBIZ-3946 URL: https://issues.apache.org/jira/browse/OFBIZ-3946 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Gaudin Pierre Assignee: Erwan de FERRIERES Fix For: SVN trunk Attachments: query_manager_patch.txt This is a new feature to manage SQL queries. You can : - store/update/delete SQL query - store/update/delete parameters for this query - execute query and view results into worksheet This SQL query manager is usefull to run frequently queries (ie: for maintenance report) How to use it : - goes to webtools/Entity Engine Tools - select SQL queries library item - create a new query and fill in SQL. If you want to use parameters, add them like this : select * from facility where facility_Id = '${facilityId}' - to declare parameters for this query then goes to Add or update query parameter screenlet and fill in fields : description = facility id ; Parameter = facilityId - to execute SQl query then press buton run - fill in parameters value adn press buton run - worksheet should automaticaly open -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4622) Avoiding confusion of 'Vendor' and 'Supplier' in the German locale translations
[ https://issues.apache.org/jira/browse/OFBIZ-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206501#comment-13206501 ] Markus M. May commented on OFBIZ-4622: -- Vendor in German is most likely a Verkäufer or Anbieter. I would vote for Verkäufer. What do you think? Avoiding confusion of 'Vendor' and 'Supplier' in the German locale translations --- Key: OFBIZ-4622 URL: https://issues.apache.org/jira/browse/OFBIZ-4622 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: Release 09.04, Release 10.04 Environment: irrelevant, this is about XML label files Reporter: Carsten Schinzer Labels: i18n, label, locale:de, locale:de_DE Fix For: Release Branch 10.04, SVN trunk Original Estimate: 2h Remaining Estimate: 2h On the user mailing list, the concepts of 'vendor' vs. 'supplier' were discussed and as a matter of fact, many labels in the German translation files of OFBiz are pointing to the term 'Lieferant' for both, especially the role select-boxes in the Party Manager application. As this is confusing and sharper terms can be found and defined in German for these two roles as well, this Issue will track the implementation of such 'sharpened' working in the translation files of all applications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira