[jira] [Created] (OFBIZ-7957) RateAmount is not found when the level is 'WorkEffort'
Montalbano Florian created OFBIZ-7957: - Summary: RateAmount is not found when the level is 'WorkEffort' Key: OFBIZ-7957 URL: https://issues.apache.org/jira/browse/OFBIZ-7957 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Trunk Reporter: Montalbano Florian When you create a RateAmount, you can determine for which WorkEffort it should apply. But when this RateAmount is retrieved for a specific WorkEffort, it fails to find the good RateAmount. The problem comes from the check done to retrieve the RateAmount at a WorkEffort level. This is the used check : {code} {code} In this 'entity-and', the partyId is set as a constraint. But it is possible to enable a special RateAmount only for a WorkEffort without regarding the partyId. I think we have 2 options here : - Remove the partyId constraint but then the retrieving may be less accurate - Make the retrieving more accurate by checking first the WorkEffort, then from the retrieved list, check if the partyId matches and finally from this second retrieval, check if the emplPositionTypeId match. At the end, we would have the most accurate RateAmount. What do you think of it ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7950) Improve consistency of service createEmployee
[ https://issues.apache.org/jira/browse/OFBIZ-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7950: -- Attachment: OFBIZ-7950_proposition.patch Here is a proposition to harmonize things : A Employee is at the very least just a Party with a Role of Employee and a RelationShip with a PartyGroup. That's why the only required field is the Internal Organization. Then, you can fill whatever fields you need. But if you fill the first name field, you have to provide at least the last name too. Same way for the address. What do you think of this ? Is this a good idea or should we go the other way arround with adding constraint to the service ? > Improve consistency of service createEmployee > - > > Key: OFBIZ-7950 > URL: https://issues.apache.org/jira/browse/OFBIZ-7950 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: consistency, create, employee, service > Attachments: OFBIZ-7950_proposition.patch > > > In the humanres component, we can create an employee through the form > https://localhost:8443/humanres/control/NewEmployee . > This form has required fields that are not the same requirement than the > service called when submitting the form. > The service called is createEmployee. > In the service, everything is declared optional but the > postalAddContactMechPurpTypeId (which is set in the form as an hidden field). > This means we could create an Employee without forcing a telephone number or > a primary address or even a first name. > But then, within the service, a check is done on the firstName and lastName > parameters and if missing, an error shows up. > We could harmonize things a little. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7950) Improve consistency of service createEmployee
Montalbano Florian created OFBIZ-7950: - Summary: Improve consistency of service createEmployee Key: OFBIZ-7950 URL: https://issues.apache.org/jira/browse/OFBIZ-7950 Project: OFBiz Issue Type: Improvement Components: humanres Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor In the humanres component, we can create an employee through the form https://localhost:8443/humanres/control/NewEmployee . This form has required fields that are not the same requirement than the service called when submitting the form. The service called is createEmployee. In the service, everything is declared optional but the postalAddContactMechPurpTypeId (which is set in the form as an hidden field). This means we could create an Employee without forcing a telephone number or a primary address or even a first name. But then, within the service, a check is done on the firstName and lastName parameters and if missing, an error shows up. We could harmonize things a little. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7947) Create a Customer fails because password is missing
Montalbano Florian created OFBIZ-7947: - Summary: Create a Customer fails because password is missing Key: OFBIZ-7947 URL: https://issues.apache.org/jira/browse/OFBIZ-7947 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Montalbano Florian When creating a New Customer from the Party component, the following error message is displayed : {quote} The Following Errors Occurred: Password is Missing Password or verify password missing. {quote} The problem is that there is no field to submit a password in the form. I have an older revision where the required fields are displayed, so I'm guessing a recent change is at cause here. Step to reproduce : - Access at the Customer creation form : https://localhost:8443/partymgr/control/NewCustomer - Try to create a Customer - No field are related to the password requirement -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7135) Adding role for a party show error on the second add
[ https://issues.apache.org/jira/browse/OFBIZ-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402379#comment-15402379 ] Montalbano Florian commented on OFBIZ-7135: --- Hi, I checked the issue OFBIZ-6746. It is the same root problem but in this current issue, the target used in the forms were some kind of "hack" that doesn't seem necessary here. In the other issue, the need is at another level. I'm going over this issue with now a little more experience, and the patch provided seems to work well for resolving the add role problem. Any review is welcomed ! Thanks. > Adding role for a party show error on the second add > > > Key: OFBIZ-7135 > URL: https://issues.apache.org/jira/browse/OFBIZ-7135 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: addrole, party > Attachments: OFBIZ-7135.patch > > > Hi all, > How to reproduce : > 1) Go to the profile of a party and then to the "Role" tab : > https://localhost:8443/partymgr/control/viewroles?partyId=admin > 2) Add any role > 3) Wait for the page to reload > 4) Try to add another role > 5) Notice the error showing up and the redirection to the "profile" page > Problem : The problem comes from a bad request send. When you select a "main > role" (without clicking on the add button), a request is send to get the form > for the "secondary role". On the first time, there is no problem, the request > is something such as : > https://localhost:8443/partymgr/control/addsecondaryroles > On the second time, it becomes something like this : > https://localhost:8443/partymgr/control/addrole/addsecondaryroles > When the controller receives this second request, it does both the "addrole" > and the "addsecondaryroles" request. So when you chose a role in the first > select, it actually sends a request to add the role before you even click on > the "add" button. > Root of the problem : > First, the target of the forms (PartyForms#AddPartyRole, > PartyForms#AddPartyMainRole and PartyForms#AddPartySecondaryRole) adding the > "main" and "secondary" roles is "addrole/viewroles" (it seems to be the only > place in the code where a target is done this way). To clear up the request, > I tried to remove the "/viewroles" to match what is done in another case : > when a task is added to a project. > It seems to work but I want to know what is your point of view on this. > Then, in the controller, there is a weird redirection to "viewprofile" > instead of allowing the user to stay on "viewroles". All of this seems > related to an update of the coding way in the project that didn't affect this > part yet. > I'll provide a patch that seems to work. > Thanks, > Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5473) Expense Declaration application
[ https://issues.apache.org/jira/browse/OFBIZ-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401746#comment-15401746 ] Montalbano Florian commented on OFBIZ-5473: --- Hi [~pfm.smits], hi all, I searched in the trunk a way to do exactly what was discussed in this thread but it seems that it was not pushed yet. After browsing the different issues linked to this one and the archives of the mailing list, I can't dertermine the status of this improvement. Does someone know if this is still in development ? I tried to access to the demo : https://demo.orrtiz.com/essterr/control/ but it seems that I'm a little too late. I'm quite interested in trying this feature, is there still a way to test it ? Have a nice day, Thanks. > Expense Declaration application > --- > > Key: OFBIZ-5473 > URL: https://issues.apache.org/jira/browse/OFBIZ-5473 > Project: OFBiz > Issue Type: New Feature > Components: accounting >Reporter: Pierre Smits > Labels: Expense > Attachments: ExpenseReport-10020.pdf, Screen Shot 2014-02-26 at > 16.33.11.png, Screen Shot 2014-02-26 at 16.33.43.png, Screen Shot 2014-02-26 > at 16.35.47.png, Screen Shot 2014-02-26 at 16.51.38.png > > > Have a new application to register expenses incurred by employees (and > others) and have these reviewed for approval. > This is the place holder issue for all sub issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401686#comment-15401686 ] Montalbano Florian commented on OFBIZ-7923: --- I found where this replacement was done but before opening a Jira, I would like to fully understand the comment put above the replace : (found in the file GenericEntity.java at line 1166 in the function writeXmlText) {code} /* * Some common character for these invalid values, have seen these are mostly from MS Word, but may be part of some standard: * 5 = ... 18 = apostrophe 19 = left quotation mark 20 = right quotation mark 22 = – 23 = - 25 = tm */ {code} After this, there is a switch checking some specials characters such as ' , " , & , < and > . If useful, we could remove the replace for all those characters. But I don't know the range of this modification. Do you have more intel about this matter ? > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux >Priority: Minor > Labels: campaign, data, demo, marketing > Fix For: Upcoming Branch > > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[ https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7929: -- Attachment: OFBIZ-7929_15.12.patch Patch for the release 15.12 . Is it ok or should I do the release 14.12 too ? > Scrum find Total Backlog Item is not working in non-English language > > > Key: OFBIZ-7929 > URL: https://issues.apache.org/jira/browse/OFBIZ-7929 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux > Labels: backlog, find, item, scrum > Fix For: Upcoming Branch > > Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch, OFBIZ-7929.patch, > OFBIZ-7929.patch, OFBIZ-7929_15.12.patch > > > The Find form for Product Backlog Item does not work in language other than > English when no "statusId" or "custRequestTypeId" are selected. > Step to reproduce : > - Go to the Scrum component and select a product > - Go to the "Total Backlog" tab > or use this linl : > https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1 > - Hit the search button, the find action is performed and return a non-empty > list. > - Set your language preference to a non english language (french for > example). > - Click again on the "Total Backlog" tab, and hit the "Rechercher" button. > - No results are found. > Where does the problem come from ? > The results displayed are from a list named "backlogList" which is built in > the following script : FindProductBacklogItem.groovy . > In this script, there were a check on the parameter "custRequestTypeId" and > on the parameter "statusId". > But the value was hardcoded : > {code} > if("Any".equals(parameters.custRequestTypeId)) > {code} > and > {code} > if(!"Any".equals(parameters.statusId)) > {code} > Obviously, when the form is in another language than english, those > conditions aren't valid anymore (for exemple, "Any" is "Dont" in French") -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7934) Add tax to billed hours
Montalbano Florian created OFBIZ-7934: - Summary: Add tax to billed hours Key: OFBIZ-7934 URL: https://issues.apache.org/jira/browse/OFBIZ-7934 Project: OFBiz Issue Type: Improvement Components: accounting, specialpurpose/projectmgr, specialpurpose/scrum Affects Versions: Trunk Reporter: Montalbano Florian Following the discussion on this thread : https://lists.apache.org/thread.html/ff183c2f074bc35479a07b5acf80b58721d66b8b8c6b753f97f755aa@%3Cuser.ofbiz.apache.org%3E To sum up : When creating an invoice from a project (from thje Scrum or Project component), we can't apply any taxes because there is no Product associated to the invoice item (the billied hours). The main solution aims to link the WorkEffort, on which the hours are spent, to a Product by using the entity WorkEffortGoodSatandard. This Jira can be used to improve/complete the solution and to pass from conception step to implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7830) Upload Communication Content functionality is not working from the Internal Note creation screen
[ https://issues.apache.org/jira/browse/OFBIZ-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395643#comment-15395643 ] Montalbano Florian commented on OFBIZ-7830: --- Hi, the problem comes from a javascript error (you can check it with the dev tools inspector of a web navigator). When uploading, the javascript called try to access information about an element of the Dom which is "EditEmail" . It is a form that does exist in OFBiz. But on this page, there is no such form. Instead, we need to access "EditInternalNote" (which has all the information we need). I tried to change the javascript of the submit button in the file "CommunicationEventForms.xml" and it works. I'm not updating a patch yet because I didn't check if the same form was used to upload content for an email and for an internal note (then it would repair one form while breaking the other). Btw, there is the same problem with "adding a communication event roles" to the email. I hope that will be useful. > Upload Communication Content functionality is not working from the Internal > Note creation screen > > > Key: OFBIZ-7830 > URL: https://issues.apache.org/jira/browse/OFBIZ-7830 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > 1) Go to Party component. > 2) Navigate to My Communication page. > 3) Go to create New Internal Note screen. > 4) Here under Communication Content section, try to upload any content. > Not be able to upload any content. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7866) Client side validation is missing at Add Ebay Configuration form
[ https://issues.apache.org/jira/browse/OFBIZ-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395226#comment-15395226 ] Montalbano Florian commented on OFBIZ-7866: --- HI, I looked at this issue and I was wondering the meaning of the value "Any" from the drop down for the Product Store. Does that mean that the configuration should be applied for every store ? Or to none ? I don't have much experience in the ebay component. What is the goal of an "Ebay Configuration" ? Have a nice day, Thanks. > Client side validation is missing at Add Ebay Configuration form > > > Key: OFBIZ-7866 > URL: https://issues.apache.org/jira/browse/OFBIZ-7866 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ebaystore >Reporter: Deepak Nigam >Priority: Minor > > Client side validations are missing at 'Add Ebay Configuration' feature. > Error from server side is being thrown if we do not provide the required > fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[ https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7929: -- Attachment: OFBIZ-7929.patch Patch created from an up-to-date OFBiz trunk version > Scrum find Total Backlog Item is not working in non-English language > > > Key: OFBIZ-7929 > URL: https://issues.apache.org/jira/browse/OFBIZ-7929 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux > Labels: backlog, find, item, scrum > Fix For: Upcoming Branch > > Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch, OFBIZ-7929.patch, > OFBIZ-7929.patch > > > The Find form for Product Backlog Item does not work in language other than > English when no "statusId" or "custRequestTypeId" are selected. > Step to reproduce : > - Go to the Scrum component and select a product > - Go to the "Total Backlog" tab > or use this linl : > https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1 > - Hit the search button, the find action is performed and return a non-empty > list. > - Set your language preference to a non english language (french for > example). > - Click again on the "Total Backlog" tab, and hit the "Rechercher" button. > - No results are found. > Where does the problem come from ? > The results displayed are from a list named "backlogList" which is built in > the following script : FindProductBacklogItem.groovy . > In this script, there were a check on the parameter "custRequestTypeId" and > on the parameter "statusId". > But the value was hardcoded : > {code} > if("Any".equals(parameters.custRequestTypeId)) > {code} > and > {code} > if(!"Any".equals(parameters.statusId)) > {code} > Obviously, when the form is in another language than english, those > conditions aren't valid anymore (for exemple, "Any" is "Dont" in French") -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393421#comment-15393421 ] Montalbano Florian commented on OFBIZ-7923: --- Thanks for the review :) By the hardest way, do you mean updating the function Exporting All Data ? I think it may be better to open a new issue for that. But I didn't check the code yet so it may be a specific issue to exporting this entity (or maybe the appears when creating a marketing campaign ?). If those datas are ok, I'll add the remaining one. I'll stop when we can have at least a navigation to the second page (for the testing purpose). > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[ https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7929: -- Attachment: OFBIZ-7929.patch Thank you for your review and advice ! I put it all in this new version of the patch : - Changed UtilValidate test to Groovy Truth test on string - Changed the big first test by a test on "noConditionFind" - Added some commentaries - Harmonization of hte if test - Removed the uiLabelMap.CommonAny in the file (the two others belonged to another form --> "FindTotalBacklog") - Added a "noConditionFind" field to this form --> "FindTotalBacklog" Both forms seem to work fine. I hope I didn't forget anything this time ; ) The second form can be accessed by : - Scrum component - Administration Tab - All Backlog subTab If those change are fine, I'll create a patch for the other versions. > Scrum find Total Backlog Item is not working in non-English language > > > Key: OFBIZ-7929 > URL: https://issues.apache.org/jira/browse/OFBIZ-7929 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux > Labels: backlog, find, item, scrum > Fix For: Upcoming Branch > > Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch, OFBIZ-7929.patch > > > The Find form for Product Backlog Item does not work in language other than > English when no "statusId" or "custRequestTypeId" are selected. > Step to reproduce : > - Go to the Scrum component and select a product > - Go to the "Total Backlog" tab > or use this linl : > https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1 > - Hit the search button, the find action is performed and return a non-empty > list. > - Set your language preference to a non english language (french for > example). > - Click again on the "Total Backlog" tab, and hit the "Rechercher" button. > - No results are found. > Where does the problem come from ? > The results displayed are from a list named "backlogList" which is built in > the following script : FindProductBacklogItem.groovy . > In this script, there were a check on the parameter "custRequestTypeId" and > on the parameter "statusId". > But the value was hardcoded : > {code} > if("Any".equals(parameters.custRequestTypeId)) > {code} > and > {code} > if(!"Any".equals(parameters.statusId)) > {code} > Obviously, when the form is in another language than english, those > conditions aren't valid anymore (for exemple, "Any" is "Dont" in French") -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[ https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7929: -- Attachment: OFBIZ-7929.patch Found two ugly things in the patch so I'm updating it (sorry for the first one, I was too careless). - Used UtilValidate.isEmpty instead of "".equals - Removed the useless line at the start of the file (when removing the ?: part of the condition, I forgot to remove the remaining part of the line) > Scrum find Total Backlog Item is not working in non-English language > > > Key: OFBIZ-7929 > URL: https://issues.apache.org/jira/browse/OFBIZ-7929 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian > Labels: backlog, find, item, scrum > Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch > > > The Find form for Product Backlog Item does not work in language other than > English when no "statusId" or "custRequestTypeId" are selected. > Step to reproduce : > - Go to the Scrum component and select a product > - Go to the "Total Backlog" tab > or use this linl : > https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1 > - Hit the search button, the find action is performed and return a non-empty > list. > - Set your language preference to a non english language (french for > example). > - Click again on the "Total Backlog" tab, and hit the "Rechercher" button. > - No results are found. > Where does the problem come from ? > The results displayed are from a list named "backlogList" which is built in > the following script : FindProductBacklogItem.groovy . > In this script, there were a check on the parameter "custRequestTypeId" and > on the parameter "statusId". > But the value was hardcoded : > {code} > if("Any".equals(parameters.custRequestTypeId)) > {code} > and > {code} > if(!"Any".equals(parameters.statusId)) > {code} > Obviously, when the form is in another language than english, those > conditions aren't valid anymore (for exemple, "Any" is "Dont" in French") -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
Montalbano Florian created OFBIZ-7929: - Summary: Scrum find Total Backlog Item is not working in non-English language Key: OFBIZ-7929 URL: https://issues.apache.org/jira/browse/OFBIZ-7929 Project: OFBiz Issue Type: Bug Components: specialpurpose/scrum Affects Versions: Trunk Reporter: Montalbano Florian The Find form for Product Backlog Item does not work in language other than English when no "statusId" or "custRequestTypeId" are selected. Step to reproduce : - Go to the Scrum component and select a product - Go to the "Total Backlog" tab or use this linl : https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1 - Hit the search button, the find action is performed and return a non-empty list. - Set your language preference to a non english language (french for example). - Click again on the "Total Backlog" tab, and hit the "Rechercher" button. - No results are found. Where does the problem come from ? The results displayed are from a list named "backlogList" which is built in the following script : FindProductBacklogItem.groovy . In this script, there were a check on the parameter "custRequestTypeId" and on the parameter "statusId". But the value was hardcoded : {code} if("Any".equals(parameters.custRequestTypeId)) {code} and {code} if(!"Any".equals(parameters.statusId)) {code} Obviously, when the form is in another language than english, those conditions aren't valid anymore (for exemple, "Any" is "Dont" in French") -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[ https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7929: -- Attachment: OFBIZ-7929.patch I removed the option based on "uiLabelMap.CommonAny" in the form for both the "custRequestTypeId" and the "statusId". And I set the "allow-empty" attribute of the drop-down to "true". Please tell me what you think about that solution (I'm not sure about the "allow-empty" thing). > Scrum find Total Backlog Item is not working in non-English language > > > Key: OFBIZ-7929 > URL: https://issues.apache.org/jira/browse/OFBIZ-7929 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian > Labels: backlog, find, item, scrum > Attachments: OFBIZ-7929.patch > > > The Find form for Product Backlog Item does not work in language other than > English when no "statusId" or "custRequestTypeId" are selected. > Step to reproduce : > - Go to the Scrum component and select a product > - Go to the "Total Backlog" tab > or use this linl : > https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1 > - Hit the search button, the find action is performed and return a non-empty > list. > - Set your language preference to a non english language (french for > example). > - Click again on the "Total Backlog" tab, and hit the "Rechercher" button. > - No results are found. > Where does the problem come from ? > The results displayed are from a list named "backlogList" which is built in > the following script : FindProductBacklogItem.groovy . > In this script, there were a check on the parameter "custRequestTypeId" and > on the parameter "statusId". > But the value was hardcoded : > {code} > if("Any".equals(parameters.custRequestTypeId)) > {code} > and > {code} > if(!"Any".equals(parameters.statusId)) > {code} > Obviously, when the form is in another language than english, those > conditions aren't valid anymore (for exemple, "Any" is "Dont" in French") -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391619#comment-15391619 ] Montalbano Florian edited comment on OFBIZ-7923 at 7/25/16 9:50 AM: Replaced {code}{code} by {code}'{code} (simple quote) was (Author: florian m): Replaced by ' (simple quote) > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7923: -- Attachment: OFBIZ-7923.patch Replaced by ' (simple quote) > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391460#comment-15391460 ] Montalbano Florian commented on OFBIZ-7923: --- Thanks for the improvment [~jacques.le.roux] ! I'll do the change. Those " came from the functionnality "Export all XML data" in the webtools. If they can be replaced, maybe it can be done in this function too ? > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7923: -- Attachment: OFBIZ-7923.patch Here are some extra datas. Can someone confirm if the datas are significant and respect the standard ? Thanks. > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7923) Improve the Marketing Demo data
Montalbano Florian created OFBIZ-7923: - Summary: Improve the Marketing Demo data Key: OFBIZ-7923 URL: https://issues.apache.org/jira/browse/OFBIZ-7923 Project: OFBiz Issue Type: Improvement Components: marketing Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor In the following issue : OFBIZ-7922, there was a problem with the pagination of the Marketing Campaing list. Because there is not enough data in the demo, it was more difficult to find this bug. To help the testing of this component, we can add some Marketing Campaign in the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7922) Pagination through marketing campains is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389107#comment-15389107 ] Montalbano Florian commented on OFBIZ-7922: --- It is a good idea ! Should I try to create campaigns with different value (description, date, ...) ? I don't know very well what all fields mean so I may end up with irrelevant datas at some point. I'll put what I can in a new issue and others may be able to improve the datas. > Pagination through marketing campains is broken > --- > > Key: OFBIZ-7922 > URL: https://issues.apache.org/jira/browse/OFBIZ-7922 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Michael Brohl > Attachments: MarketingCampaign.xml, OFBIZ-7922.patch > > > Go to /marketing/control/FindMarketingCampaign and select another view size > or paginate - an error occurs because the forms target is > listMarketingCampain which does not exist in the controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7922) Pagination through marketing campains is broken
[ https://issues.apache.org/jira/browse/OFBIZ-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7922: -- Attachment: MarketingCampaign.xml Hi [~mbrohl], the patch is working well for me (trunk version) For those who wants to test it with the default-data, there isn't enough Marketing Campaign to test it. So you can import the following attached file with the web tools import : MarketingCampaing.xml > Pagination through marketing campains is broken > --- > > Key: OFBIZ-7922 > URL: https://issues.apache.org/jira/browse/OFBIZ-7922 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Michael Brohl > Attachments: MarketingCampaign.xml, OFBIZ-7922.patch > > > Go to /marketing/control/FindMarketingCampaign and select another view size > or paginate - an error occurs because the forms target is > listMarketingCampain which does not exist in the controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7917) Use Agreement Items in Quote
Montalbano Florian created OFBIZ-7917: - Summary: Use Agreement Items in Quote Key: OFBIZ-7917 URL: https://issues.apache.org/jira/browse/OFBIZ-7917 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor When we create a Quote from the Order component, we can't use the agreements defined with a customer (such as price, payment condition, ...). It could be nice to have the same agreement selection than the one available in the creation of an order. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7706) Error in Create Billing Account From SFA
[ https://issues.apache.org/jira/browse/OFBIZ-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385561#comment-15385561 ] Montalbano Florian commented on OFBIZ-7706: --- Hi, I tested the patch and the creation of the billing account is working well. Is there a way to enhance the redirection after the creation of the account ? We don't have any way to go back to the profile we came from after the creation at the moment. > Error in Create Billing Account From SFA > > > Key: OFBIZ-7706 > URL: https://issues.apache.org/jira/browse/OFBIZ-7706 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Chandan Khandelwal > Attachments: OFBIZ-7706.patch > > > # Go to profile page > (https://localhost:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT=Company) > # Create new billing address > Error in Create Billing Account From SFA > URL : https://localhost:8443/sfa/control/EditBillingAccount?partyId=Company -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7875) Broken screen on adding billing account through any account
[ https://issues.apache.org/jira/browse/OFBIZ-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385557#comment-15385557 ] Montalbano Florian commented on OFBIZ-7875: --- I saw just a little too late that this issue is a duplicate of OFBIZ-7706 . There is a proper patch (different from the one in OFBIZ-7827). Can someone update the status of this issue to duplicate ? > Broken screen on adding billing account through any account > > > Key: OFBIZ-7875 > URL: https://issues.apache.org/jira/browse/OFBIZ-7875 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Deepak Baghel > Attachments: AddingBillingAccountError.png > > > Step to regenerate this issue : > 1. Login to the SFA component. > 2. Go to the account section. > 3. Select any one of account and go to its overview page. > 4. Try to add new billing account from payment method information panel. > 5. Broken screen occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7875) Broken screen on adding billing account through any account
[ https://issues.apache.org/jira/browse/OFBIZ-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385541#comment-15385541 ] Montalbano Florian edited comment on OFBIZ-7875 at 7/20/16 8:32 AM: Hi, I think this is related to OFBIZ-7827 . The error is the same in both cases and applying the patch proposed in the other issue seems to work (no error and the billing account is created). It only lacks a good redirection after the creation of the account. Can you try applying the patch of OFBIZ-7827 and give feedback ? Have a nice day. was (Author: florian m): Hi, I think this is related to OFBIZ-7827 . The error is the same in both cases and applying the patch proposed in the other issue seems to work (no error and the billing account is created). It only lacks a good redirection after the creation of the account. Can you try to apply the patch of OFBIZ-7827 and give feedback ? Have a nice day. > Broken screen on adding billing account through any account > > > Key: OFBIZ-7875 > URL: https://issues.apache.org/jira/browse/OFBIZ-7875 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Deepak Baghel > Attachments: AddingBillingAccountError.png > > > Step to regenerate this issue : > 1. Login to the SFA component. > 2. Go to the account section. > 3. Select any one of account and go to its overview page. > 4. Try to add new billing account from payment method information panel. > 5. Broken screen occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7875) Broken screen on adding billing account through any account
[ https://issues.apache.org/jira/browse/OFBIZ-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385541#comment-15385541 ] Montalbano Florian commented on OFBIZ-7875: --- Hi, I think this is related to OFBIZ-7827 . The error is the same in both cases and applying the patch proposed in the other issue seems to work (no error and the billing account is created). It only lacks a good redirection after the creation of the account. Can you try to apply the patch of OFBIZ-7827 and give feedback ? Have a nice day. > Broken screen on adding billing account through any account > > > Key: OFBIZ-7875 > URL: https://issues.apache.org/jira/browse/OFBIZ-7875 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Deepak Baghel > Attachments: AddingBillingAccountError.png > > > Step to regenerate this issue : > 1. Login to the SFA component. > 2. Go to the account section. > 3. Select any one of account and go to its overview page. > 4. Try to add new billing account from payment method information panel. > 5. Broken screen occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7835) Unable to identify the fields on the edit of product attributes, facilities, payment types, Meters, work effort, parties
[ https://issues.apache.org/jira/browse/OFBIZ-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381982#comment-15381982 ] Montalbano Florian commented on OFBIZ-7835: --- Hi, this patch works well ! The title of each columns is now aligned with its column and there is more space between the columns, improving the readability. I found some more forms that could use your improvement : - ListProductGeos - UpdateProductPrice (the result is a little weird though) - UpdateProductGoodIdentifications - UpdateProductCategoryMember (the result is a little awkward too) - ListProductGlAccounts Do you think some of these forms could benefit from your improvement ? Also, I think that this issue can be set as an "Improvement" instead of a "Bug". Have a nice day. > Unable to identify the fields on the edit of product attributes, facilities, > payment types, Meters, work effort, parties > > > Key: OFBIZ-7835 > URL: https://issues.apache.org/jira/browse/OFBIZ-7835 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Aditi Patidar >Assignee: Aditi Patidar >Priority: Minor > Attachments: OFBIZ-7835.patch, edit product facilities.png > > > Steps to regenerate issue: > 1. Navigate to Catalog -> Products. > 2. Browse the product. > 3. Press 'Facilities' or 'Payment Types' or 'Meters' or 'Work Effort' or > 'Parties' tab to look UI issue. > Refer the attached screenshot to view the UI issue on the edit of product > facilities. Same kind of UI issue exists in above mentioned areas. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7820) Empty scroll bar in party component.
[ https://issues.apache.org/jira/browse/OFBIZ-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381908#comment-15381908 ] Montalbano Florian commented on OFBIZ-7820: --- Hi, I think this issue is linked to this one : OFBIZ-7817 When we look at the form with the web tools, we can see that this empty scroll bar is created by the field "partyClassificationGroupId" which should be a drop down of the missing entity "PartyClassificationGroupAndType". As the entity is not found, the field can not display any value and as the size of this dropdown is set to 20, we have 20 empty entries displayed on the page. > Empty scroll bar in party component. > > > Key: OFBIZ-7820 > URL: https://issues.apache.org/jira/browse/OFBIZ-7820 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Akshay Modak >Assignee: Akshay Modak >Priority: Minor > > Steps to regenerate: > 1) Login to party component. > 2) Switch to parties tab. > 3) Under search button, an empty scroll bar can be seen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7777) QuoteId field displayed with no value
[ https://issues.apache.org/jira/browse/OFBIZ-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-: -- Attachment: OFBIZ-.patch Here is the patch for this issue. I added a use-when condition to display the field when the quote already exist (edition) and to hide the field when the quote is being created. > QuoteId field displayed with no value > - > > Key: OFBIZ- > URL: https://issues.apache.org/jira/browse/OFBIZ- > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Trivial > Labels: form, null, quote, quoteid > Attachments: OFBIZ-.patch > > > When creating a new quote, the field quoteId is displayed even though its > value is "null". > Step to reproduce : > - Go to the "Order" component > - Go on the "Quotes" tab > - Click on create a new quote > - See the "quoteId" field displaying no value > (quick link : https://localhost:8443/ordermgr/control/EditQuote) > Expected behaviour : > The field "quoteId" should not appear when creating a new Quote -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7777) QuoteId field displayed with no value
Montalbano Florian created OFBIZ-: - Summary: QuoteId field displayed with no value Key: OFBIZ- URL: https://issues.apache.org/jira/browse/OFBIZ- Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Montalbano Florian Priority: Trivial When creating a new quote, the field quoteId is displayed even though its value is "null". Step to reproduce : - Go to the "Order" component - Go on the "Quotes" tab - Click on create a new quote - See the "quoteId" field displaying no value (quick link : https://localhost:8443/ordermgr/control/EditQuote) Expected behaviour : The field "quoteId" should not appear when creating a new Quote -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7586) Error in Create Billing Account From HR
[ https://issues.apache.org/jira/browse/OFBIZ-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7586: -- Attachment: OFBIZ-7586.patch I was about to open a ticket for the same problem appearing in the party component. It seems that the same screen is used in both Humanres and Partymgr. The screen is "PaymentMethodScreens.xml#EditBillingAccount". I read the parent ticket of this one and it was about moving common xml resources to the commonext component. This resource is located in the Party component. Should we move it along in this ticket or create a proper task for this component ? The patch does not move the resources to the commonext component, it simply corrects the URI in the controller (of the Party component) and add a default value (BILL_TO_CUSTOMER) for the roleTypeId in the context of the screen. What should we do about moving these resources ? > Error in Create Billing Account From HR > --- > > Key: OFBIZ-7586 > URL: https://issues.apache.org/jira/browse/OFBIZ-7586 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > Attachments: OFBIZ-7586.patch > > > # Go To HR > # Select Comapny > # Create Billing Account > # Save > URL : > https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING > getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown > request [createBillingAccountAndRole]; this request does not exist or cannot > be called directly." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7759) Link in LookupContent causes unwanted behaviour
Montalbano Florian created OFBIZ-7759: - Summary: Link in LookupContent causes unwanted behaviour Key: OFBIZ-7759 URL: https://issues.apache.org/jira/browse/OFBIZ-7759 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor How to reproduce : - Log in the Content component - Go to the Content tab - In the search form, open the lookup of the field ' Owner Content Id ' - Click on the search button - In the result list, click on a button link in the column 'Data Resource Id' - The form to edit the Content will be displayed (a whole OFBiz seems to be accessible from this new page) - Close the lookup. - Try to reopen it, it doesn't show anything anymore. The only hint I've found for explaining this problem is that the request to open the lookup is somehow changed. At first it is : https://localhost:8443/content/control/LookupContent But then it becomes : https://localhost:8443/content/control/LookupLocale The other lookup seems unusable too after that. Did you already encounter this kind of problem before ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7734) Add content to task does not work
[ https://issues.apache.org/jira/browse/OFBIZ-7734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362171#comment-15362171 ] Montalbano Florian commented on OFBIZ-7734: --- It seems that I'm still a little sleepy ;) The issue I'm talking about was about the fact that a non-declared variable in the context was not evaluated as 'null' . [~pandeypranay] said here : https://issues.apache.org/jira/browse/OFBIZ-7184?focusedCommentId=15320273=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15320273 that "If not found in parameter it [a variable from the context] should have been set to null, that's the issue we have at framework level." > Add content to task does not work > - > > Key: OFBIZ-7734 > URL: https://issues.apache.org/jira/browse/OFBIZ-7734 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/projectmgr >Affects Versions: Trunk >Reporter: Montalbano Florian > Labels: content, task > Attachments: OFBIZ-7734.patch > > > The form to add a content to a task does not allow to add anything because > the field "ContentId" is in display only. > How to reproduce : > - Go to the Project Manager component > - Select a project with at least 1 task > - Select a task from this project > - Go to the tab "Content" of this task > - See the form "Add Task Content", the 'Content Id' field cannot be completed > and thus the create fails > ( shortcut > https://localhost:8443/projectmgr/control/EditTaskContents?workEffortId=9002 ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7734) Add content to task does not work
[ https://issues.apache.org/jira/browse/OFBIZ-7734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362142#comment-15362142 ] Montalbano Florian commented on OFBIZ-7734: --- I'm sorry for the dilution, it seemed to me that all the subjects were tied together. I'll create the corresponding issue for each one. Do you have the reference for the issue 'that has the has already been reported aspect' ? I tried to find it searching with the keyword "task, content" but I didn't find the duplicate. > Add content to task does not work > - > > Key: OFBIZ-7734 > URL: https://issues.apache.org/jira/browse/OFBIZ-7734 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/projectmgr >Affects Versions: Trunk >Reporter: Montalbano Florian > Labels: content, task > Attachments: OFBIZ-7734.patch > > > The form to add a content to a task does not allow to add anything because > the field "ContentId" is in display only. > How to reproduce : > - Go to the Project Manager component > - Select a project with at least 1 task > - Select a task from this project > - Go to the tab "Content" of this task > - See the form "Add Task Content", the 'Content Id' field cannot be completed > and thus the create fails > ( shortcut > https://localhost:8443/projectmgr/control/EditTaskContents?workEffortId=9002 ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7734) Add content to task does not work
[ https://issues.apache.org/jira/browse/OFBIZ-7734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7734: -- Attachment: OFBIZ-7734.patch Here is a patch correcting this issue. The problem was that in the context, the field 'workEffortContent' was not defined in the screen. So, in the form, every condition 'workEffortContent==null' was evaluated to false (it is weird and has already been reported). That made every field and the target of the form preparing for an update of content instead of a creation. The lookup autocompletion weren't working too. I added it to the patch. I noticed that adding content to a task from the 'WorkEffort' component (https://localhost:8443/workeffort/control/EditWorkEffortContents?workEffortId=9002) does not use the same form than in ProjectMgr. Is there a reason for that ? And in the Scrum component, you can't add content after the creation of a backlog task. Would it be useful to allow adding content to scrum task (after their creation) ? > Add content to task does not work > - > > Key: OFBIZ-7734 > URL: https://issues.apache.org/jira/browse/OFBIZ-7734 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/projectmgr >Affects Versions: Trunk >Reporter: Montalbano Florian > Labels: content, task > Attachments: OFBIZ-7734.patch > > > The form to add a content to a task does not allow to add anything because > the field "ContentId" is in display only. > How to reproduce : > - Go to the Project Manager component > - Select a project with at least 1 task > - Select a task from this project > - Go to the tab "Content" of this task > - See the form "Add Task Content", the 'Content Id' field cannot be completed > and thus the create fails > ( shortcut > https://localhost:8443/projectmgr/control/EditTaskContents?workEffortId=9002 ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7731) Allow filtering Task by Phase Name
[ https://issues.apache.org/jira/browse/OFBIZ-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361473#comment-15361473 ] Montalbano Florian commented on OFBIZ-7731: --- Hi [~pfm.smits], thanks for your questions. It is applicable in the same way that you can filter by "Project Name". So : - It search through both open and close project - You can access every project informations as long as you are granted 'user permission' for the ProjectManager component (same behaviour than before, just try to access https://localhost:8443/projectmgr/control/FindTask with minimum permission and all tasks can be displayed) I checked in the screen (TaskScreens.xml#FindTask) and in the forms (TaskForms.xml#FindTask and TaskForms.xml#ListTasks) that do this search and the only restrictions I found were the following : {code} {code} Does that answer your questions ? > Allow filtering Task by Phase Name > -- > > Key: OFBIZ-7731 > URL: https://issues.apache.org/jira/browse/OFBIZ-7731 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/projectmgr >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: filter, phase, task > Attachments: OFBIZ-7731.patch > > > When searching for Tasks here : > https://localhost:8443/projectmgr/control/FindTask, we can see that the > result list shows a column 'Phase Name'. This correspond to the phase the > task belongs to. > However, it is not possible to filter this list by Phase. > I propose to add a field in the search form to allow users to filter the task > by the phase they are related to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7734) Add content to task does not work
Montalbano Florian created OFBIZ-7734: - Summary: Add content to task does not work Key: OFBIZ-7734 URL: https://issues.apache.org/jira/browse/OFBIZ-7734 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: Trunk Reporter: Montalbano Florian The form to add a content to a task does not allow to add anything because the field "ContentId" is in display only. How to reproduce : - Go to the Project Manager component - Select a project with at least 1 task - Select a task from this project - Go to the tab "Content" of this task - See the form "Add Task Content", the 'Content Id' field cannot be completed and thus the create fails ( shortcut https://localhost:8443/projectmgr/control/EditTaskContents?workEffortId=9002 ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7731) Allow filtering Task by Phase Name
[ https://issues.apache.org/jira/browse/OFBIZ-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7731: -- Attachment: OFBIZ-7731.patch Here is the patch for the improvement. What do you think of this idea ? > Allow filtering Task by Phase Name > -- > > Key: OFBIZ-7731 > URL: https://issues.apache.org/jira/browse/OFBIZ-7731 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/projectmgr >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: filter, phase, task > Attachments: OFBIZ-7731.patch > > > When searching for Tasks here : > https://localhost:8443/projectmgr/control/FindTask, we can see that the > result list shows a column 'Phase Name'. This correspond to the phase the > task belongs to. > However, it is not possible to filter this list by Phase. > I propose to add a field in the search form to allow users to filter the task > by the phase they are related to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7731) Allow filtering Task by Phase Name
Montalbano Florian created OFBIZ-7731: - Summary: Allow filtering Task by Phase Name Key: OFBIZ-7731 URL: https://issues.apache.org/jira/browse/OFBIZ-7731 Project: OFBiz Issue Type: Improvement Components: specialpurpose/projectmgr Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor When searching for Tasks here : https://localhost:8443/projectmgr/control/FindTask, we can see that the result list shows a column 'Phase Name'. This correspond to the phase the task belongs to. However, it is not possible to filter this list by Phase. I propose to add a field in the search form to allow users to filter the task by the phase they are related to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7721) auto-completer does not work to search Data Resource Id and owner content id
[ https://issues.apache.org/jira/browse/OFBIZ-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361022#comment-15361022 ] Montalbano Florian commented on OFBIZ-7721: --- Hi, I tried the patch and now the autocomplete is going well ! But I think there is a problem with the LookupContent used for the field "Owner Content Id". When you click on the lookup icon and perform a search, you can access, inside the lookup, to the edition page of the content (click on the 'data source id' or the 'owner content id'). Up to here everything is ok, but when you close the lookup and try to open it again, the page doesn't react anymore. When I looked at the request sent to the sertver, instead of 'https://localhost:8443/content/control/LookupContent' there was 'https://localhost:8443/content/control/LookupLocale'. I don't think it is related to your patch but can you confirm this problem (or not ) ? I'll open a new issue if needed. Have a nice day, Thanks. > auto-completer does not work to search Data Resource Id and owner content id > -- > > Key: OFBIZ-7721 > URL: https://issues.apache.org/jira/browse/OFBIZ-7721 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Ankush Upadhyay > Attachments: OFBIZ-7721.patch > > > Steps to reproduce: > 1. Login to content manager. > 2. Go to find content page. > 3. Search data resource id or owner content id using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7262) Error on closing and re-opening of project
[ https://issues.apache.org/jira/browse/OFBIZ-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355312#comment-15355312 ] Montalbano Florian commented on OFBIZ-7262: --- Hi [~anurag.chan...@hotwaxsystems.com], I found just this problem on the trunk and I applied your patch. Now closing and opening a Scrum Project works perfectly and there is no error in the console anymore. Thank you ! > Error on closing and re-opening of project > -- > > Key: OFBIZ-7262 > URL: https://issues.apache.org/jira/browse/OFBIZ-7262 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Anurag Chandak >Assignee: Anurag Chandak >Priority: Blocker > Fix For: Upcoming Branch > > Attachments: OFBIZ-7262.patch > > > Steps to regenerate: > - Go to the Scrum component and select a project > (https://localhost:8443/scrum/control/viewScrumProject?projectId=DEMO-PROJECT-1) > - Close the project > - The following error is shown: > {code} > The Following Errors Occurred: > Exception thrown while creating the "goodStandardMap" GenericValue: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:WorkEffortGoodStandard][createdStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][createdTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][fromDate,2016-06-09 > 12:16:46.489(java.sql.Timestamp)][lastUpdatedStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][statusId,WEGS_CREATED(java.lang.String)][workEffortGoodStdTypeId,SCRUM_PRO_WORKEFF(java.lang.String)][workEffortId,DEMO-PROJECT-1(java.lang.String)] > (SQL Exception while executing the following:INSERT INTO > OFBIZ.WORK_EFFORT_GOOD_STANDARD (WORK_EFFORT_ID, PRODUCT_ID, > WORK_EFFORT_GOOD_STD_TYPE_ID, FROM_DATE, THRU_DATE, STATUS_ID, > ESTIMATED_QUANTITY, ESTIMATED_COST, LAST_UPDATED_STAMP, > LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, > ?, ?, ?, ?, ?, ?, ?, ?) (Column 'PRODUCT_ID' cannot accept a NULL value.)) > (Error while inserting: > [GenericEntity:WorkEffortGoodStandard][createdStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][createdTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][fromDate,2016-06-09 > 12:16:46.489(java.sql.Timestamp)][lastUpdatedStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][statusId,WEGS_CREATED(java.lang.String)][workEffortGoodStdTypeId,SCRUM_PRO_WORKEFF(java.lang.String)][workEffortId,DEMO-PROJECT-1(java.lang.String)] > (SQL Exception while executing the following:INSERT INTO > OFBIZ.WORK_EFFORT_GOOD_STANDARD (WORK_EFFORT_ID, PRODUCT_ID, > WORK_EFFORT_GOOD_STD_TYPE_ID, FROM_DATE, THRU_DATE, STATUS_ID, > ESTIMATED_QUANTITY, ESTIMATED_COST, LAST_UPDATED_STAMP, > LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, > ?, ?, ?, ?, ?, ?, ?, ?) (Column 'PRODUCT_ID' cannot accept a NULL value.))) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7262) Error on closing and re-opening of project
[ https://issues.apache.org/jira/browse/OFBIZ-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355312#comment-15355312 ] Montalbano Florian edited comment on OFBIZ-7262 at 6/29/16 2:24 PM: Hi [~anurag.chan...@hotwaxsystems.com], I just found this problem on the trunk and I applied your patch. Now closing and opening a Scrum Project works perfectly and there is no error in the console anymore. Thank you ! was (Author: florian m): Hi [~anurag.chan...@hotwaxsystems.com], I found just this problem on the trunk and I applied your patch. Now closing and opening a Scrum Project works perfectly and there is no error in the console anymore. Thank you ! > Error on closing and re-opening of project > -- > > Key: OFBIZ-7262 > URL: https://issues.apache.org/jira/browse/OFBIZ-7262 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Anurag Chandak >Assignee: Anurag Chandak >Priority: Blocker > Fix For: Upcoming Branch > > Attachments: OFBIZ-7262.patch > > > Steps to regenerate: > - Go to the Scrum component and select a project > (https://localhost:8443/scrum/control/viewScrumProject?projectId=DEMO-PROJECT-1) > - Close the project > - The following error is shown: > {code} > The Following Errors Occurred: > Exception thrown while creating the "goodStandardMap" GenericValue: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:WorkEffortGoodStandard][createdStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][createdTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][fromDate,2016-06-09 > 12:16:46.489(java.sql.Timestamp)][lastUpdatedStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][statusId,WEGS_CREATED(java.lang.String)][workEffortGoodStdTypeId,SCRUM_PRO_WORKEFF(java.lang.String)][workEffortId,DEMO-PROJECT-1(java.lang.String)] > (SQL Exception while executing the following:INSERT INTO > OFBIZ.WORK_EFFORT_GOOD_STANDARD (WORK_EFFORT_ID, PRODUCT_ID, > WORK_EFFORT_GOOD_STD_TYPE_ID, FROM_DATE, THRU_DATE, STATUS_ID, > ESTIMATED_QUANTITY, ESTIMATED_COST, LAST_UPDATED_STAMP, > LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, > ?, ?, ?, ?, ?, ?, ?, ?) (Column 'PRODUCT_ID' cannot accept a NULL value.)) > (Error while inserting: > [GenericEntity:WorkEffortGoodStandard][createdStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][createdTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][fromDate,2016-06-09 > 12:16:46.489(java.sql.Timestamp)][lastUpdatedStamp,2016-06-09 > 12:16:46.65(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-09 > 12:16:46.248(java.sql.Timestamp)][statusId,WEGS_CREATED(java.lang.String)][workEffortGoodStdTypeId,SCRUM_PRO_WORKEFF(java.lang.String)][workEffortId,DEMO-PROJECT-1(java.lang.String)] > (SQL Exception while executing the following:INSERT INTO > OFBIZ.WORK_EFFORT_GOOD_STANDARD (WORK_EFFORT_ID, PRODUCT_ID, > WORK_EFFORT_GOOD_STD_TYPE_ID, FROM_DATE, THRU_DATE, STATUS_ID, > ESTIMATED_QUANTITY, ESTIMATED_COST, LAST_UPDATED_STAMP, > LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, > ?, ?, ?, ?, ?, ?, ?, ?) (Column 'PRODUCT_ID' cannot accept a NULL value.))) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen
[ https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352837#comment-15352837 ] Montalbano Florian commented on OFBIZ-7655: --- I'll do that for the next times. Thanks for your answers :) > Use 'conditionFields' instead of 'andCondition' in Lookup screen > > > Key: OFBIZ-7655 > URL: https://issues.apache.org/jira/browse/OFBIZ-7655 > Project: OFBiz > Issue Type: Improvement > Components: party, product >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocompletion, conditionFields, lookup > > In order to improve a little the readibility, we can replace the use of > direct call of groovy in Lookup screen for the autocompletion parameters. > Instead, we can use the field 'conditionFields', which is a map key/value, to > declare those parameters. > This is a main task and a sub task will be created for each lookup involved. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen
[ https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352731#comment-15352731 ] Montalbano Florian commented on OFBIZ-7655: --- Ok, I'm taking note for the next time :) Should I create 1 issue by screen or 1 only patch for all the screen ? > Use 'conditionFields' instead of 'andCondition' in Lookup screen > > > Key: OFBIZ-7655 > URL: https://issues.apache.org/jira/browse/OFBIZ-7655 > Project: OFBiz > Issue Type: Improvement > Components: party, product >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocompletion, conditionFields, lookup > > In order to improve a little the readibility, we can replace the use of > direct call of groovy in Lookup screen for the autocompletion parameters. > Instead, we can use the field 'conditionFields', which is a map key/value, to > declare those parameters. > This is a main task and a sub task will be created for each lookup involved. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7658) Use 'conditionFields' in LookupInternalOrganization
[ https://issues.apache.org/jira/browse/OFBIZ-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7658: -- Attachment: OFBIZ-7658.patch Thanks to a comment from [~deepakddixit], the patch can be lighter and the code easier to read. Change : The map 'conditionFields' does not need to be declared empty. The minilang will do that when the first field will be set. > Use 'conditionFields' in LookupInternalOrganization > --- > > Key: OFBIZ-7658 > URL: https://issues.apache.org/jira/browse/OFBIZ-7658 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7658.patch, OFBIZ-7658.patch > > > Change 'andCondition' (which use groovy as a value) to 'conditionsField' in > the lookup LookupScreens#LookupInternalOrganization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7656) Use 'conditionField' in LookupCustomerName
[ https://issues.apache.org/jira/browse/OFBIZ-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7656: -- Attachment: OFBIZ-7656.patch Thanks to a comment from [~deepakddixit], the patch can be lighter and the code easier to read ! Change : The map 'conditionFields' does not need to be declared empty. It is done by minilang when the first field of the map is set. > Use 'conditionField' in LookupCustomerName > -- > > Key: OFBIZ-7656 > URL: https://issues.apache.org/jira/browse/OFBIZ-7656 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7655.patch, OFBIZ-7656.patch > > > Change the field 'andCondition' (which use direct call to groovy) to > 'conditionFields' in the lookup LookupScreens#LookupCustomerName. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7657) Use 'conditionFields' in LookupContact
[ https://issues.apache.org/jira/browse/OFBIZ-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7657: -- Attachment: OFBIZ-7657.patch Thanks to the comment from [~deepakddixit], the patch can be even lighter and the code easier to read ! > Use 'conditionFields' in LookupContact > -- > > Key: OFBIZ-7657 > URL: https://issues.apache.org/jira/browse/OFBIZ-7657 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7657.patch, OFBIZ-7657.patch > > > Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in > the lookup LookupScreens#LookupContact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7659) Use 'conditionFields' in LookupVirtualProduct
[ https://issues.apache.org/jira/browse/OFBIZ-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7659: -- Attachment: OFBIZ-7659.patch Thanks to a comment from [~deepakddixit], the patch can be even lighter ! Here the change : No need to declare the empty map 'conditionFields', it is done by the minilang when we set up the first key. > Use 'conditionFields' in LookupVirtualProduct > - > > Key: OFBIZ-7659 > URL: https://issues.apache.org/jira/browse/OFBIZ-7659 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7659.patch, OFBIZ-7659.patch > > > Change 'andCondition' (which uses groovy as a value) to 'conditionFields' in > the lookup LookupScreens#LookupVirtualProduct. > Any Review/Test is welcome ! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7657) Use 'conditionFields' in LookupContact
[ https://issues.apache.org/jira/browse/OFBIZ-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352671#comment-15352671 ] Montalbano Florian commented on OFBIZ-7657: --- Hi [~deepakddixit], you are right, both are doing the same thing. I asked in OFBIZ-7576 if there was a difference and [~jacques.le.roux] said it was just epsilon difference in performance but easier to read. That's why, I'm changing the 'andCondition' to 'conditionFields'. I read your other comment and if there is no need to declare the 'conditionFields' as a map then it's even better ! Is that ok for you ? > Use 'conditionFields' in LookupContact > -- > > Key: OFBIZ-7657 > URL: https://issues.apache.org/jira/browse/OFBIZ-7657 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7657.patch > > > Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in > the lookup LookupScreens#LookupContact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7659) Use 'conditionFields' in LookupVirtualProduct
[ https://issues.apache.org/jira/browse/OFBIZ-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7659: -- Attachment: OFBIZ-7659.patch Here is the patch. > Use 'conditionFields' in LookupVirtualProduct > - > > Key: OFBIZ-7659 > URL: https://issues.apache.org/jira/browse/OFBIZ-7659 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7659.patch > > > Change 'andCondition' (which uses groovy as a value) to 'conditionFields' in > the lookup LookupScreens#LookupVirtualProduct. > Any Review/Test is welcome ! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7659) Use 'conditionFields' in LookupVirtualProduct
Montalbano Florian created OFBIZ-7659: - Summary: Use 'conditionFields' in LookupVirtualProduct Key: OFBIZ-7659 URL: https://issues.apache.org/jira/browse/OFBIZ-7659 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor Change 'andCondition' (which uses groovy as a value) to 'conditionFields' in the lookup LookupScreens#LookupVirtualProduct. Any Review/Test is welcome ! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7658) Use 'conditionFields' in LookupInternalOrganization
[ https://issues.apache.org/jira/browse/OFBIZ-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7658: -- Attachment: OFBIZ-7658.patch Here is the patch. Any Review/Test is welcome ! > Use 'conditionFields' in LookupInternalOrganization > --- > > Key: OFBIZ-7658 > URL: https://issues.apache.org/jira/browse/OFBIZ-7658 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7658.patch > > > Change 'andCondition' (which use groovy as a value) to 'conditionsField' in > the lookup LookupScreens#LookupInternalOrganization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7658) Use 'conditionFields' in LookupInternalOrganization
Montalbano Florian created OFBIZ-7658: - Summary: Use 'conditionFields' in LookupInternalOrganization Key: OFBIZ-7658 URL: https://issues.apache.org/jira/browse/OFBIZ-7658 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor Change 'andCondition' (which use groovy as a value) to 'conditionsField' in the lookup LookupScreens#LookupInternalOrganization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7658) Use 'conditionFields' in LookupInternalOrganization
[ https://issues.apache.org/jira/browse/OFBIZ-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7658: -- Labels: andCondition autocomplete conditionFields lookup (was: ) > Use 'conditionFields' in LookupInternalOrganization > --- > > Key: OFBIZ-7658 > URL: https://issues.apache.org/jira/browse/OFBIZ-7658 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > > Change 'andCondition' (which use groovy as a value) to 'conditionsField' in > the lookup LookupScreens#LookupInternalOrganization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7657) Use 'conditionFields' in LookupContact
[ https://issues.apache.org/jira/browse/OFBIZ-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7657: -- Attachment: OFBIZ-7657.patch Here is the patch. I couldn't test it because I didn't find where this lookup was used. Test/Review are welcome ! > Use 'conditionFields' in LookupContact > -- > > Key: OFBIZ-7657 > URL: https://issues.apache.org/jira/browse/OFBIZ-7657 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7657.patch > > > Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in > the lookup LookupScreens#LookupContact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7657) Use 'conditionFields' in LookupContact
Montalbano Florian created OFBIZ-7657: - Summary: Use 'conditionFields' in LookupContact Key: OFBIZ-7657 URL: https://issues.apache.org/jira/browse/OFBIZ-7657 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in the lookup LookupScreens#LookupContact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7656) Use 'conditionField' in LookupCustomerName
[ https://issues.apache.org/jira/browse/OFBIZ-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7656: -- Attachment: OFBIZ-7655.patch The patch using 'conditionFields' instead of 'andCondition'. Every review/test are welcome ! > Use 'conditionField' in LookupCustomerName > -- > > Key: OFBIZ-7656 > URL: https://issues.apache.org/jira/browse/OFBIZ-7656 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7655.patch > > > Change the field 'andCondition' (which use direct call to groovy) to > 'conditionFields' in the lookup LookupScreens#LookupCustomerName. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7656) Use 'conditionField' in LookupCustomerName
[ https://issues.apache.org/jira/browse/OFBIZ-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7656: -- Description: Change the field 'andCondition' (which use direct call to groovy) to 'conditionFields' in the lookup LookupScreens#LookupCustomerName. (was: Change the field 'andCondition' (which use direct call to groovy) to 'conditionFields' in the lookup LookupForm#lookupCustomerName. ) > Use 'conditionField' in LookupCustomerName > -- > > Key: OFBIZ-7656 > URL: https://issues.apache.org/jira/browse/OFBIZ-7656 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > > Change the field 'andCondition' (which use direct call to groovy) to > 'conditionFields' in the lookup LookupScreens#LookupCustomerName. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7656) Use 'conditionField' in LookupCustomerName
[ https://issues.apache.org/jira/browse/OFBIZ-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7656: -- Description: Change the field 'andCondition' (which use direct call to groovy) to 'conditionFields' in the lookup LookupForm#lookupCustomerName. (was: Change the field 'andCondition' (which use direct call to groovy) to 'conditionFields'. ) > Use 'conditionField' in LookupCustomerName > -- > > Key: OFBIZ-7656 > URL: https://issues.apache.org/jira/browse/OFBIZ-7656 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > > Change the field 'andCondition' (which use direct call to groovy) to > 'conditionFields' in the lookup LookupForm#lookupCustomerName. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7656) Use 'conditionField' in LookupCustomerName
Montalbano Florian created OFBIZ-7656: - Summary: Use 'conditionField' in LookupCustomerName Key: OFBIZ-7656 URL: https://issues.apache.org/jira/browse/OFBIZ-7656 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor Change the field 'andCondition' (which use direct call to groovy) to 'conditionFields'. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen
Montalbano Florian created OFBIZ-7655: - Summary: Use 'conditionFields' instead of 'andCondition' in Lookup screen Key: OFBIZ-7655 URL: https://issues.apache.org/jira/browse/OFBIZ-7655 Project: OFBiz Issue Type: Improvement Components: party, product Affects Versions: Trunk Reporter: Montalbano Florian Priority: Minor In order to improve a little the readibility, we can replace the use of direct call of groovy in Lookup screen for the autocompletion parameters. Instead, we can use the field 'conditionFields', which is a map key/value, to declare those parameters. This is a main task and a sub task will be created for each lookup involved. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352502#comment-15352502 ] Montalbano Florian commented on OFBIZ-7576: --- Hi [~jacques.le.roux], thanks for your review. I'll check those cases right away. > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Ankush Upadhyay >Assignee: Jacques Le Roux > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7560) While adding new skill to any party the old skills are get disappeared from the party skill list
[ https://issues.apache.org/jira/browse/OFBIZ-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350627#comment-15350627 ] Montalbano Florian edited comment on OFBIZ-7560 at 6/27/16 8:28 AM: Thanks for your advice [~pritam.kute] ! (i didn't see your patch immediately ^^' sorry for the doublon) was (Author: florian m): Thanks for your advice [~pritam.kute] ! I tried to create a patch with the . Is this what you were thinking about ? > While adding new skill to any party the old skills are get disappeared from > the party skill list > > > Key: OFBIZ-7560 > URL: https://issues.apache.org/jira/browse/OFBIZ-7560 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Ashish Vijaywargiya >Priority: Minor > Attachments: OFBIZ-7560-Trunk.patch, Party_Skills 1.png, Party_Skills > 2.png, Party_Skills 3.png > > > Step to regenerate > 1. Login into party component. > 2. Go to the party skill section and add skills. > 3. If there is already any skill then after adding the new skill all the > other skills get disappeared from the list. > 4. The Same thing can be seen after updating and deletion of already existing > skill. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7560) While adding new skill to any party the old skills are get disappeared from the party skill list
[ https://issues.apache.org/jira/browse/OFBIZ-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7560: -- Attachment: (was: OFBIZ-7560.patch) > While adding new skill to any party the old skills are get disappeared from > the party skill list > > > Key: OFBIZ-7560 > URL: https://issues.apache.org/jira/browse/OFBIZ-7560 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Ashish Vijaywargiya >Priority: Minor > Attachments: OFBIZ-7560-Trunk.patch, Party_Skills 1.png, Party_Skills > 2.png, Party_Skills 3.png > > > Step to regenerate > 1. Login into party component. > 2. Go to the party skill section and add skills. > 3. If there is already any skill then after adding the new skill all the > other skills get disappeared from the list. > 4. The Same thing can be seen after updating and deletion of already existing > skill. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7560) While adding new skill to any party the old skills are get disappeared from the party skill list
[ https://issues.apache.org/jira/browse/OFBIZ-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7560: -- Attachment: OFBIZ-7560.patch Thanks for your advice [~pritam.kute] ! I tried to create a patch with the . Is this what you were thinking about ? > While adding new skill to any party the old skills are get disappeared from > the party skill list > > > Key: OFBIZ-7560 > URL: https://issues.apache.org/jira/browse/OFBIZ-7560 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Ashish Vijaywargiya >Priority: Minor > Attachments: OFBIZ-7560-Trunk.patch, Party_Skills 1.png, Party_Skills > 2.png, Party_Skills 3.png > > > Step to regenerate > 1. Login into party component. > 2. Go to the party skill section and add skills. > 3. If there is already any skill then after adding the new skill all the > other skills get disappeared from the list. > 4. The Same thing can be seen after updating and deletion of already existing > skill. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350498#comment-15350498 ] Montalbano Florian commented on OFBIZ-7576: --- Hi [~jacques.le.roux], I made a mistake removing the StatusCondition.groovy. But for the 'andCondition', I replaced it with the 'conditionFields' which is defined in FindAutocompleteOptions.groovy. And that was my question, which is the best between the 'andCondition' and the 'conditionFields' ? > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Ankush Upadhyay >Assignee: Jacques Le Roux > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7576: -- Attachment: OFBIZ-7576_proposition.patch Hi, I was wondering the difference between the submitted patch and this solution (proposition.patch). Is there one with better performance or are they quite equivalent ? Thanks. > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Ankush Upadhyay >Assignee: Jacques Le Roux > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7560) While adding new skill to any party the old skills are get disappeared from the party skill list
[ https://issues.apache.org/jira/browse/OFBIZ-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346377#comment-15346377 ] Montalbano Florian commented on OFBIZ-7560: --- Hi, the skills don't appear in the list but there are not deleted. They don't appear because when we call a create or a delete action (update too), more data are sent by the request. In the form where the list is created (PartySkillForms#ListPartySkills), a regular "performFind" is called to retrieve the list. It uses the parameters from the request to do that. So, when we arrive on the screen the first time, only the partyId is send. But then, upon creation of a new skill, the skillTypeId, the rating, etc... are sent too. The "performFind" tries then to retrieve all the skills matching every parameters of the request (with a AND condition). That's why upon creation, only the created one appears and that upon deletion, there is nothing. To correct that, we can either create a specific service or nullify the paramter of the request in the form retrieving the list. What do you think ? > While adding new skill to any party the old skills are get disappeared from > the party skill list > > > Key: OFBIZ-7560 > URL: https://issues.apache.org/jira/browse/OFBIZ-7560 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Deepak Baghel >Priority: Minor > Attachments: Party_Skills 1.png, Party_Skills 2.png, Party_Skills > 3.png > > > Step to regenerate > 1. Login into party component. > 2. Go to the party skill section and add skills. > 3. If there is already any skill then after adding the new skill all the > other skills get disappeared from the list. > 4. The Same thing can be seen after updating and deletion of already existing > skill. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7555) Pagination at the bottom on find party screen is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346033#comment-15346033 ] Montalbano Florian commented on OFBIZ-7555: --- Hi [~deepak.baghel], I'm unsuccessful in reproducing the problem. Can you post a screen-shot of the problem ? It may be related to the issue OFBIZ-7020 , which was resolved 2 days ago. I suggest you to try to update your version of the trunk, the patch was added in the recent version. Have a nice day. > Pagination at the bottom on find party screen is not working > > > Key: OFBIZ-7555 > URL: https://issues.apache.org/jira/browse/OFBIZ-7555 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Deepak Baghel >Priority: Minor > > Step to regenerate > 1. Login into the find party component and then click on search. > 2. All the list of parties will be shown in the form of the table. > 3. We can see the two paginations kept at top and bottom of the result table. > 4. If I change the item per page count form top pagination section then It > doesn't reflect in bottom section or bottom section is not updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7513) alt-target tag is not working as expected in Form Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344502#comment-15344502 ] Montalbano Florian commented on OFBIZ-7513: --- Can't we just swap the two adding instructions ? {code} ModelForm.java (Line: 380-388) ArrayList altTargets = new ArrayList(); for (Element altTargetElement : UtilXml.childElementList(formElement, "alt-target")) { altTargets.add(new AltTarget(altTargetElement)); } if (parentModel != null) { altTargets.addAll(parentModel.altTargets); } altTargets.trimToSize(); this.altTargets = Collections.unmodifiableList(altTargets); {code} Does someone know if something is added to the list when there is no child ? And what should happen if there is multiple children for the same element ? (is that possible ?) > alt-target tag is not working as expected in Form Widget > > > Key: OFBIZ-7513 > URL: https://issues.apache.org/jira/browse/OFBIZ-7513 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute > > While working on the issue OFBIZ-7252, I found one problem in Form Widgets. > When we use attribute in child form, the system should consider > overridden in child form. This is default expected behaviour. > But in this case, it is always considering the of the parent > form. > For example: > > > > > > > > In above example, expectation is 'executeChildTarget' target should get > executed but actually 'executeParentTarget' is getting executed. > When we looked into framework level code of Form Widgets, we got the > following code snippets: > ModelForm.java (Line: 380-388) > ArrayList altTargets = new ArrayList(); > if (parentModel != null) { > altTargets.addAll(parentModel.altTargets); > } > for (Element altTargetElement : UtilXml.childElementList(formElement, > "alt-target")) { > altTargets.add(new AltTarget(altTargetElement)); > } > altTargets.trimToSize(); > this.altTargets = Collections.unmodifiableList(altTargets); > Here we can see that all alt-targets present in parent form are added to the > list first and then all alt-targets present in child form are added. > This causes a problem as method getTarget() of ModelForm.java (Line: > 1352-1384) returns the first element in the list as alt-target. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7252) Error adding task to backlog
[ https://issues.apache.org/jira/browse/OFBIZ-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341970#comment-15341970 ] Montalbano Florian commented on OFBIZ-7252: --- Hi, thank you for your explanation [~pritam.kute]. I saw another issue with a problem related to this in inherited form. Did you start the discussion you talked about ? I'm interested in following it. Do you think the patch will be committed ? I would like to stay in phase with the standard and from what you said, this problem seems deeper than what it seemed to be. Have a nice day. > Error adding task to backlog > > > Key: OFBIZ-7252 > URL: https://issues.apache.org/jira/browse/OFBIZ-7252 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Ashish Vijaywargiya > Labels: error, form, scrum, sprint, task > Attachments: OFBIZ-7252-Trunk.patch > > > There are several problems in the form to add a new task in a backlog. Step > to reproduce : > - Go to the Scrum component and select a product sprint > (https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1=DEMO-PROJECT-1) > - Scroll down to the Sprint Backlog List > - Click on a button "Add Task" > - See the error in the console. > From there, it's not possible to create a new task. When clicking on the > create button, there is an error and the target is > "https://localhost:8443/scrum/control/updateSprintTask; where it should be > "https://localhost:8443/scrum/control/createSprintBacklogTask;. > I tried to solve the problem but it's beyond me. The form causing the problem > is scrumForms.xml#NewTaskForSprintBacklog and it extends the form > TaskForms.xml#EditSprintTask . > Thanks, > Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7186) Find Facility Inventory Items shows same 20 items on all pagination page.
[ https://issues.apache.org/jira/browse/OFBIZ-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341269#comment-15341269 ] Montalbano Florian commented on OFBIZ-7186: --- Thank you for your review and corrections [~arvind.singh] ! > Find Facility Inventory Items shows same 20 items on all pagination page. > - > > Key: OFBIZ-7186 > URL: https://issues.apache.org/jira/browse/OFBIZ-7186 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Arvind Singh Tomar >Assignee: Mridul Pathak > Labels: facility, inventory > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7186.patch, OFBIZ-7186_2_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7186) Find Facility Inventory Items shows same 20 items on all pagination page.
[ https://issues.apache.org/jira/browse/OFBIZ-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335761#comment-15335761 ] Montalbano Florian edited comment on OFBIZ-7186 at 6/17/16 9:20 AM: Hi, I retried to solve this issue and I found a way to patch the problem. I'm attaching the file to this issue. The problem was that the way to find the result is done manually in a groovy file (ViewFacilityInventoryByProduct.groovy). Thus, the case were only a partial list should appear was not considered. I think this groovy file could use some refactoring. I don't understand very well all the requests done in this file, so this patch may seem quite ugly. I think we can call the function "performFindList" at some point but I don't know how to pass the condition for the request. For some reason, when you navigate on the different result page, the parameters of the request sent are 'VIEW_SIZE_1' and 'VIEW_INDEX_1'. Is this the normal behavior ? The patch corrects the problem but I think it could be improved. Any comment on this problem is welcomed ! Have a nice day. was (Author: florian m): Hi, I retried to solve this issue and I found a way to patch the problem. I'm attaching the file to this issue. The problem was that the way to find the result is done manually in a groovy file (ViewFacilityInventoryByProduct.groovy). Thus, the case were only a partial list should appears was not considered. I think this groovy file could use some refactoring. I don't understand very well all the requests done in this file, so this patch may seems quite ugly. I think we can call the function "performFindList" at some point but I don't know how to pass the condition for the request. For some reason, when you navigate on the different result page, the request parameters sent are 'VIEW_SIZE_1' and 'VIEW_INDEX_1'. Is this the normal behavior ? The patch corrects the problem but I think it could be improved. Have a nice day. > Find Facility Inventory Items shows same 20 items on all pagination page. > - > > Key: OFBIZ-7186 > URL: https://issues.apache.org/jira/browse/OFBIZ-7186 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Arvind Singh Tomar >Priority: Critical > Labels: facility, inventory > Fix For: Trunk > > Attachments: OFBIZ-7186.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7186) Find Facility Inventory Items shows same 20 items on all pagination page.
[ https://issues.apache.org/jira/browse/OFBIZ-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7186: -- Attachment: OFBIZ-7186.patch Hi, I retried to solve this issue and I found a way to patch the problem. I'm attaching the file to this issue. The problem was that the way to find the result is done manually in a groovy file (ViewFacilityInventoryByProduct.groovy). Thus, the case were only a partial list should appears was not considered. I think this groovy file could use some refactoring. I don't understand very well all the requests done in this file, so this patch may seems quite ugly. I think we can call the function "performFindList" at some point but I don't know how to pass the condition for the request. For some reason, when you navigate on the different result page, the request parameters sent are 'VIEW_SIZE_1' and 'VIEW_INDEX_1'. Is this the normal behavior ? The patch corrects the problem but I think it could be improved. Have a nice day. > Find Facility Inventory Items shows same 20 items on all pagination page. > - > > Key: OFBIZ-7186 > URL: https://issues.apache.org/jira/browse/OFBIZ-7186 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Arvind Singh Tomar >Priority: Critical > Labels: facility, inventory > Fix For: Trunk > > Attachments: OFBIZ-7186.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7362) Add paginate target to list forms to fix the pagination error
[ https://issues.apache.org/jira/browse/OFBIZ-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335714#comment-15335714 ] Montalbano Florian commented on OFBIZ-7362: --- Ok, I see now. So, some forms lack the parameter 'paginate-target' and that makes the URL accepting parameters from the form instead of passing them to the request parameters ? > Add paginate target to list forms to fix the pagination error > - > > Key: OFBIZ-7362 > URL: https://issues.apache.org/jira/browse/OFBIZ-7362 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > > I found issue in pagination on some screens when we do any operation (like > update, delete) on list item. > For example: I have updated the content type from list in Content Setup Menu > in Content application and then clicked on next link of pagination, I got the > following error: > {code} > The Following Errors Occurred: > Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL > parameter [contentTypeId] passed to secure (https) request-map with uri > [updateContentType] with an event that calls service [updateContentType]; > this is not allowed for security reasons! > {code} > The above error is unexpected as I just tried to see next list records of > ContentType. The reason of error is pagination URL which is same as URL of > page i.e. updateContentType. This URL is the update operation URL and it is > not redirected to appropriate page after operation. > Pagination target URL should be independent of page URL and it should be > added on form using paginate-target attribute of form widget. > This is a parent ticket and child tickets will be added in it for components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7362) Add paginate target to list forms to fix the pagination error
[ https://issues.apache.org/jira/browse/OFBIZ-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335599#comment-15335599 ] Montalbano Florian commented on OFBIZ-7362: --- Hi, I think it's a sub task of OFBIZ-2330. I reproduced the problem and got the error message too. The end of the message is the following : {code} The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help.{code} Can you confirm that you have the same error message ? > Add paginate target to list forms to fix the pagination error > - > > Key: OFBIZ-7362 > URL: https://issues.apache.org/jira/browse/OFBIZ-7362 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > > I found issue in pagination on some screens when we do any operation (like > update, delete) on list item. > For example: I have updated the content type from list in Content Setup Menu > in Content application and then clicked on next link of pagination, I got the > following error: > {code} > The Following Errors Occurred: > Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL > parameter [contentTypeId] passed to secure (https) request-map with uri > [updateContentType] with an event that calls service [updateContentType]; > this is not allowed for security reasons! > {code} > The above error is unexpected as I just tried to see next list records of > ContentType. The reason of error is pagination URL which is same as URL of > page i.e. updateContentType. This URL is the update operation URL and it is > not redirected to appropriate page after operation. > Pagination target URL should be independent of page URL and it should be > added on form using paginate-target attribute of form widget. > This is a parent ticket and child tickets will be added in it for components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7143) Error on cancelling agreement
[ https://issues.apache.org/jira/browse/OFBIZ-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7143: -- Attachment: OFBIZ-7143.patch I just encountered this problem once again. I found this solution while searching for this issue. It seems simpler than the one you already proposed [~lodhiravi]. I'll try to update the status of this JIRA for helping with the resolution of this issue. > Error on cancelling agreement > - > > Key: OFBIZ-7143 > URL: https://issues.apache.org/jira/browse/OFBIZ-7143 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Minor > Attachments: OFBIZ-7143.patch, OFBIZ-7143_1412.patch, > OFBIZ-7143_1512.patch, OFBIZ-7143_trunk.patch > > > Step to regenerate: > 1) Go to Agreements screen under Accounting > component.(https://localhost:8443/accounting/control/FindAgreement) > 2) Cancel an agreement from the list. > 3) See the error on Search Results section. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7324) From facility location should be product based in stock move form.
[ https://issues.apache.org/jira/browse/OFBIZ-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7324: -- Attachment: OFBIZ-7324_tryV2.patch Hi [~deepak.dixit], sorry for the duplicate work but given that I'm new to OFBiz, I think it's a good experience for me to try to provide some patch while following your work. I used the work proposed in OFBIZ-7350 to provide the filtering on the auto-completion of the product location based on the product id given. There are some changes that I'm unsure of : - The auto-completion calls the service StockMoveServices#findProductInventorylocations , so I modified it to do a "like" operator check on the field 'locationSeqId'. I feel that modifying this service may have not been appropriated. What is the good way ? - The screen LookupScreens.xml#LookupProductInventoryLocation now support call with an undefined 'parameters.productId', answering with a more user-friendly error message. In this same screen, I used the field 'conditionFields' to filter the auto-completion but I didn't find this way of doing thing in another part of OFBiz, so I'm wondering if it is ok. Please give me your thought about this patch. I tried to apply it on a clean trunk and it works (for the Move stock problem only (for now)). But it still doesn't work on other form that could benefit from it (LookupQuoteItem). > From facility location should be product based in stock move form. > -- > > Key: OFBIZ-7324 > URL: https://issues.apache.org/jira/browse/OFBIZ-7324 > Project: OFBiz > Issue Type: Improvement >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-7324_try.patch, OFBIZ-7324_tryV2.patch > > > From facility location should be product based in stock move form. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7324) From facility location should be product based in stock move form.
[ https://issues.apache.org/jira/browse/OFBIZ-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7324: -- Attachment: OFBIZ-7324_try.patch Here is a patch proposition. This patch restricts the choices of the product 'from location'. Only the location where the product is available can be selected. The form "LookupScreens.xml#LookupProductInventoryLocation" was modified to prevent crash when the 'productId' is not defined. I put the change to use more easily the "'targetParameterIter" option used in the PickMoveStock.ftl . Please note that this patch is certainly causing regression problem (as said in previous comment). But it can at least show the possibilities of "targetParameterIter" to solve this kind of issue. I hope this can be a stepping stone for solving this issue. > From facility location should be product based in stock move form. > -- > > Key: OFBIZ-7324 > URL: https://issues.apache.org/jira/browse/OFBIZ-7324 > Project: OFBiz > Issue Type: Improvement >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-7324_try.patch > > > From facility location should be product based in stock move form. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7309) Stock Move: Unable to select From Stock location from List Facility Location popup
[ https://issues.apache.org/jira/browse/OFBIZ-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327112#comment-15327112 ] Montalbano Florian commented on OFBIZ-7309: --- Thank you all for your comments :) I followed them to try to solve OFBIZ-7324 . > Stock Move: Unable to select From Stock location from List Facility Location > popup > -- > > Key: OFBIZ-7309 > URL: https://issues.apache.org/jira/browse/OFBIZ-7309 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Ankush Upadhyay >Assignee: Jacques Le Roux > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-7309.patch, StockMoves.png > > > Functionality working as expected over ofbiz-13.07.03 but failing in trunk. > Steps to reproduce: > 1. Login to facility component. > 2. Select any facility. > 2. Navigate to Stock Moves tab. > 3. Click on From Location lookup from Quick Stock Move section against > GZ-8544 product. > 4. Try to select any location from List Facility Location popup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7324) From facility location should be product based in stock move form.
[ https://issues.apache.org/jira/browse/OFBIZ-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327107#comment-15327107 ] Montalbano Florian commented on OFBIZ-7324: --- Hi again, I took your comment into consideration. I tried to use the "targetParameterIter" but I encountered some difficulties. Here is how I used it in the ftl file : {code} <@htmlTemplate.lookupField formName="quickStockMove" name="locationSeqId" id="locationSeqId" fieldFormName="LookupProductInventoryLocation?facilityId=${facilityId}" targetParameterIter=["productId"]/> {code} The value of productId is passed through the request parameters but with the name "parm0". So, the lookup doesn't know what to do with this value. I found where the name of the request's parameters was set and I found a fix to put the name of the field of the form as the name of the parameter in the request. But as the fix is in the file "fieldlookup.js", I'm pretty sure that this will create some problem. Here is the change I've made in the function "_dialogOpen" : Before : {code} queryArgs += "" + i + "=" + jQuery(options.args[i]).val(); {code} After : {code} queryArgs += "&" + jQuery(options.args[i]).attr("name") + "=" + jQuery(options.args[i]).val(); {code} (there is similar code in "lookup_popup2" but i'm not sure of what this code does so I didn't touch it for now) This allows to name the parameters of the request with the name of the field in the form. For this specific issue it works. I searched for occurences of "parm0" and "parm1" in the trunk source but there were only 3 relevant matches. Would this change be useful for the OFBiz project ? > From facility location should be product based in stock move form. > -- > > Key: OFBIZ-7324 > URL: https://issues.apache.org/jira/browse/OFBIZ-7324 > Project: OFBiz > Issue Type: Improvement >Reporter: Deepak Dixit >Assignee: Deepak Dixit > > From facility location should be product based in stock move form. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7319) Remove product feature in Quick Admin page not secure
[ https://issues.apache.org/jira/browse/OFBIZ-7319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7319: -- Affects Version/s: Trunk Labels: feature parameters remove secure (was: ) Component/s: (was: ALL COMPONENTS) product > Remove product feature in Quick Admin page not secure > - > > Key: OFBIZ-7319 > URL: https://issues.apache.org/jira/browse/OFBIZ-7319 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: feature, parameters, remove, secure > > When trying to remove a product feature from the quick admin page of a > product, you get the following error : > {code} > The Following Errors Occurred: > Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL > parameter [productId] passed to secure (https) request-map with uri > [quickAdminRemoveFeatureFromProduct] with an event that calls service > [removeFeatureFromProduct]; this is not allowed for security reasons! The > data should be encrypted by making it part of the request body (a form field) > instead of the request URL. Moreover it would be kind if you could create a > Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check > before if a sub-task for this error does not exist). If you are not sure how > to create a Jira issue please have a look before at > http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help. > {code} > As the error aks for, I'm creating this Jira. > I checked in the created sub-task and this one was not registered (but there > was one for removing feature in Product Category). > Step to reproduce the error : > - Go to the catalog and search for any product > (https://localhost:8443/catalog/control/FindProduct) > - Go to the "Quick Admin" tab > (https://localhost:8443/catalog/control/EditProductQuickAdmin?productId=WG-9943-B3) > - Add a standard feature type (Color for example) > - Select an option from the drop-down of the feature type (Black for example) > and add the feature. > - Try to delete it by clicking on the button with a cross. > - The error shows up -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7319) Remove product feature in Quick Admin page not secure
Montalbano Florian created OFBIZ-7319: - Summary: Remove product feature in Quick Admin page not secure Key: OFBIZ-7319 URL: https://issues.apache.org/jira/browse/OFBIZ-7319 Project: OFBiz Issue Type: Sub-task Reporter: Montalbano Florian Priority: Minor When trying to remove a product feature from the quick admin page of a product, you get the following error : {code} The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [productId] passed to secure (https) request-map with uri [quickAdminRemoveFeatureFromProduct] with an event that calls service [removeFeatureFromProduct]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help. {code} As the error aks for, I'm creating this Jira. I checked in the created sub-task and this one was not registered (but there was one for removing feature in Product Category). Step to reproduce the error : - Go to the catalog and search for any product (https://localhost:8443/catalog/control/FindProduct) - Go to the "Quick Admin" tab (https://localhost:8443/catalog/control/EditProductQuickAdmin?productId=WG-9943-B3) - Add a standard feature type (Color for example) - Select an option from the drop-down of the feature type (Black for example) and add the feature. - Try to delete it by clicking on the button with a cross. - The error shows up -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7308) Add standard product features is not working from Quick Admin page
[ https://issues.apache.org/jira/browse/OFBIZ-7308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326967#comment-15326967 ] Montalbano Florian commented on OFBIZ-7308: --- Hi [~lodhiravi], I tested the patch on the feature type "color" and it's working well. At first, I had the error too and the feature was not added but with your patch it works fine. I tried to remove a feature too but I ended up with the following error : {code} The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [productId] passed to secure (https) request-map with uri [quickAdminRemoveFeatureFromProduct] with an event that calls service [removeFeatureFromProduct]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help. {code} I'll check if a Jira already exists or else create a new one. It seems that once you added a feature, you cannot add more feature type to this product. Is this the normal behaviour ? > Add standard product features is not working from Quick Admin page > -- > > Key: OFBIZ-7308 > URL: https://issues.apache.org/jira/browse/OFBIZ-7308 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7308_trunk.patch > > > Steps to regenerate: > 1) Go to Catalog -> Products > 2) Find products and go to the Quick Admin page of that product. > 3) Add Standard Features. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7309) Stock Move: Unable to select From Stock location from List Facility Location popup
[ https://issues.apache.org/jira/browse/OFBIZ-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7309: -- Attachment: OFBIZ-7309.patch > Stock Move: Unable to select From Stock location from List Facility Location > popup > -- > > Key: OFBIZ-7309 > URL: https://issues.apache.org/jira/browse/OFBIZ-7309 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Ankush Upadhyay > Attachments: OFBIZ-7309.patch, StockMoves.png > > > Functionality working as expected over ofbiz-13.07.03 but failing in trunk. > Steps to reproduce: > 1. Login to facility component. > 2. Select any facility. > 2. Navigate to Stock Moves tab. > 3. Click on From Location lookup from Quick Stock Move section against > GZ-8544 product. > 4. Try to select any location from List Facility Location popup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7309) Stock Move: Unable to select From Stock location from List Facility Location popup
[ https://issues.apache.org/jira/browse/OFBIZ-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326943#comment-15326943 ] Montalbano Florian commented on OFBIZ-7309: --- Hi, we looked into the problem and found what seems to be the root of this bug. The form with the not working lookup is described in the following ftl file : PickLiveStock.ftl . For some reason, the 'Product' input and the 'To Location' input are created with the macro @htmlTemplate.lookupField (and are working well) but the 'From Location' field is created by a direct call to a javascript function (and is not working well). That causes the lookup to open in another window and to lose the context. That's why the selection didn't work. Moreover, the theme was not rendered with Saphir. I'll provide a patch but I'm quite new to ftl so every review is welcome ! Have a nice day. > Stock Move: Unable to select From Stock location from List Facility Location > popup > -- > > Key: OFBIZ-7309 > URL: https://issues.apache.org/jira/browse/OFBIZ-7309 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Ankush Upadhyay > Attachments: StockMoves.png > > > Functionality working as expected over ofbiz-13.07.03 but failing in trunk. > Steps to reproduce: > 1. Login to facility component. > 2. Select any facility. > 2. Navigate to Stock Moves tab. > 3. Click on From Location lookup from Quick Stock Move section against > GZ-8544 product. > 4. Try to select any location from List Facility Location popup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7295) Create WorkEffort Request Item not working, getting error
[ https://issues.apache.org/jira/browse/OFBIZ-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7295: -- Attachment: OFBiz-7295.patch Hi, I looked into the problem and it seems that it was a problem in the "createWorkEffortRequestItem" . The entity-name used in the 'find-by-primary-key' was "QuoteWorkEffort" instead of "CustRequestItemWorkEffort". It may be an error from a copy/paste. I attached a patch to the issue. > Create WorkEffort Request Item not working, getting error > - > > Key: OFBIZ-7295 > URL: https://issues.apache.org/jira/browse/OFBIZ-7295 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-7295-Screen-Shot.png, OFBiz-7295.patch > > > Please find attached screenshot. > Steps to regenerate: > 1. Go to > https://localhost:8443/workeffort/control/ListWorkEffortRequests?workEffortId=TASK11 > 2. Create WorkEffortRequestItem from "Add Work Effort RequestItem", error > occurs. > I will provide patch soon. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7115) Timesheet overview page of projectmgr throw error on terminal
[ https://issues.apache.org/jira/browse/OFBIZ-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Montalbano Florian updated OFBIZ-7115: -- Attachment: OFBIZ-7115-bis Hi, I just stumbled across this error on the Scrum component. I'm attaching the patch correcting all the remaining occurrences of the bad evaluation with the solution proposed in the original patch. It corrected the error I was getting on the form but I didn't check the other forms for possible regression. > Timesheet overview page of projectmgr throw error on terminal > - > > Key: OFBIZ-7115 > URL: https://issues.apache.org/jira/browse/OFBIZ-7115 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/projectmgr >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Vaibhav Jain >Assignee: Pranay Pandey >Priority: Minor > Attachments: OFBIZ-7115-bis, OFBIZ-7115.patch > > > Steps to regenerate (load the system with demo data) > 1. Go to "PROJECT" menu (https://localhost:8443/projectmgr/control/main) > 2. Select the 'Timesheet' sub-menu option > 3. Click on "find" button. > 4. Click on DEMO-TIMESHEET1 in the list. > 5. The system working as expected but the terminal throws the following error > {code} > [java] 2016-05-21 18:25:47,631 |ttp-nio-8443-exec-13 > |FlexibleStringExpander|W| Error evaluating scriptlet > [${groovy:workEffortId!=void&&!"Totals".equals(workEffortId)?workEffortId:""}]; > error was: groovy.lang.MissingPropertyException: No such property: > workEffortId for class: script1463806799411782919921 > [java] groovy.lang.MissingPropertyException: No such property: > workEffortId for class: script1463806799411782919921 > [java] at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53) > ~[groovy-all-2.4.5.jar:2.4.5] > [java] at > org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:52) > ~[groovy-all-2.4.5.jar:2.4.5] > [java] at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGroovyObjectGetProperty(AbstractCallSite.java:307) > ~[groovy-all-2.4.5.jar:2.4.5] > and > |W| Could not get a system property for widget.autocompleter.defaultDelay : > null > [java] 2016-05-21 18:25:47,732 |ttp-nio-8443-exec-13 |UtilXml > |E| XmlFileLoader: File > file:/home/common/ofbiz/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml > process error. Line: 209. Error message: cvc-complex-type.4: Attribute > 'value-field' must appear on element 'entity-one'. > [java] 2016-05-21 18:25:47,795 |ttp-nio-8443-exec-13 |UtilXml > |E| XmlFileLoader: File > file:/home/common/ofbiz/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml > process error. Line: 209. Error message: cvc-complex-type.4: Attribute > 'value-field' must appear on element 'entity-one'. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7252) Error adding task to backlog
[ https://issues.apache.org/jira/browse/OFBIZ-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322512#comment-15322512 ] Montalbano Florian commented on OFBIZ-7252: --- Thank you [~pritam.kute] ! I just tried it on the trunk and it's working like a charm. As well for the creation, the update and the deletion of a task. What do you mean by the "replacement of custRequestId" ? Is that parameter not used anymore ? I see that there is a check to ignore it if empty just after the removed line. Is that condition still ok ? > Error adding task to backlog > > > Key: OFBIZ-7252 > URL: https://issues.apache.org/jira/browse/OFBIZ-7252 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Pritam Kute > Labels: error, form, scrum, sprint, task > Attachments: OFBIZ-7252-Trunk.patch > > > There are several problems in the form to add a new task in a backlog. Step > to reproduce : > - Go to the Scrum component and select a product sprint > (https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1=DEMO-PROJECT-1) > - Scroll down to the Sprint Backlog List > - Click on a button "Add Task" > - See the error in the console. > From there, it's not possible to create a new task. When clicking on the > create button, there is an error and the target is > "https://localhost:8443/scrum/control/updateSprintTask; where it should be > "https://localhost:8443/scrum/control/createSprintBacklogTask;. > I tried to solve the problem but it's beyond me. The form causing the problem > is scrumForms.xml#NewTaskForSprintBacklog and it extends the form > TaskForms.xml#EditSprintTask . > Thanks, > Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7252) Error adding task to backlog
Montalbano Florian created OFBIZ-7252: - Summary: Error adding task to backlog Key: OFBIZ-7252 URL: https://issues.apache.org/jira/browse/OFBIZ-7252 Project: OFBiz Issue Type: Bug Components: specialpurpose/scrum Affects Versions: Trunk Reporter: Montalbano Florian There are several problems in the form to add a new task in a backlog. Step to reproduce : - Go to the Scrum component and select a product sprint (https://localhost:8443/scrum/control/ViewSprint?sprintId=DEMO-SPRINT-1=DEMO-PROJECT-1) - Scroll down to the Sprint Backlog List - Click on a button "Add Task" - See the error in the console. >From there, it's not possible to create a new task. When clicking on the >create button, there is an error and the target is >"https://localhost:8443/scrum/control/updateSprintTask; where it should be >"https://localhost:8443/scrum/control/createSprintBacklogTask;. I tried to solve the problem but it's beyond me. The form causing the problem is scrumForms.xml#NewTaskForSprintBacklog and it extends the form TaskForms.xml#EditSprintTask . Thanks, Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7205) Create party resume not working. ResumeId doesn't have text field to enter
[ https://issues.apache.org/jira/browse/OFBIZ-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320198#comment-15320198 ] Montalbano Florian commented on OFBIZ-7205: --- We could remove the actions 'add' and 'edit' in the Party component but let the possibility to view these informations from this component. I'm trying to think in practice mode : If I want to check both the Resume and the Skills of a Party, it may be nice to have these as tabs in the Party component, but only with read-only mode. By the way, the problem of the JIRA comes from the PartySrcreens#EditPartyResumes from the Party component. It was lacking the line : {code} {code} in the action of the screen. Then in the form PartyResumeForms#EditPartyResume , the condition {code}{code} was triggered somehow (this may mean that a non defined map is not 'null' but something else). And then, the field was displayed with no 'resumeId' defined. And the list of resumes from the Party component was not working too. In the same screen than before PartySrcreens#EditPartyResumes, the following setting was missing : {code} {code} This "partyResumeCtx" is used as the input field map in the form PartyResumeForms#ListPartyResumes. So, the form was searching resume without information about the partyId. > Create party resume not working. ResumeId doesn't have text field to enter > -- > > Key: OFBIZ-7205 > URL: https://issues.apache.org/jira/browse/OFBIZ-7205 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-7205-Screen-Shot.png > > > Please refer attached screenshot. > Steps to regenerate: > 1. Go to > https://localhost:8443/partymgr/control/EditPartyResumes?partyId=admin. > 2. Create Resume form does not have ResumeId text field. Cannot add resume to > party from here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7181) Error on Product Requirement Creation
[ https://issues.apache.org/jira/browse/OFBIZ-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318123#comment-15318123 ] Montalbano Florian commented on OFBIZ-7181: --- I confirm the problem on the trunk version. The patch is working well for me (still on the trunk). Well done ! With a quick look at the code of the other version, it seems that this patch could be useful for the 15.12 and the 13.07 versions of OFBiz. > Error on Product Requirement Creation > - > > Key: OFBIZ-7181 > URL: https://issues.apache.org/jira/browse/OFBIZ-7181 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7181_trunk.patch > > > Step to regenerate: > 1) Got to Order -> Requirements -> New Requirement > 2) On Create Requirement form select Requirement Type Id equals to "Product > Requirement" > 3) Select any product and submit the form. > 4) Here you get the broken screen. > Root Cause: > There is a seca rule on "createRequirement" service that triggered > "autoAssignRequirementToSupplier" for requirementTypeId equals to > "PRODUCT_REQUIREMENT". This service is generating error when quantity is not > passed to it. One can easily submit the form to create new requirement > without passing quantity as there is not client side validation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7184) 'Data Source Id' should be editable/visible on error view screen of createDataSource
[ https://issues.apache.org/jira/browse/OFBIZ-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318099#comment-15318099 ] Montalbano Florian commented on OFBIZ-7184: --- The form to look at is DataSourceForms.xml#EditDataSource. In this form, we look for the value of the dataSource and the dataSourceId. When the form is submitted without a dataSourceId, the controller send the same form with an error and in the form, the following condition is triggered : {code}{code} DataSource is null (else, the first field would show something else). So, the dataSourceId is somehow not considered "null". I think it may be because the createDataSource service return a empty String when there is an error. I tried to display the value of dataSourceId in a field but nothing shows up... The condition that we need to hit is the following : {code}{code} So either we change this condition, either we send a dataSourceId with a null value. Do you have any idea about this ? > 'Data Source Id' should be editable/visible on error view screen of > createDataSource > > > Key: OFBIZ-7184 > URL: https://issues.apache.org/jira/browse/OFBIZ-7184 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Chandan Khandelwal >Assignee: Vaibhav Jain > Attachments: screenshot-1.png > > > Steps to regenerate the issue- > # Go to https://localhost:8443/marketing/control/main > # Click on sub-menu DataSource > # Click on create data source > # Click "Save" without filling input fields > # Instead of input field, label is shown Could not be found: [] > (Please refer screenshot for more details) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7020) Page navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316601#comment-15316601 ] Montalbano Florian commented on OFBIZ-7020: --- The patch is working fine. Thank you [~rohit.koushal] ! I see that this "NO_PAGINATOR" doesn't appear in other forms. Should we put a comment to explain what it is doing here ? Something such as : "This field "NO_PAGINATOR" prevents the incrementation of the paginator of the page. In this grid, when multiple login exist for a same Party, a grid was included in the parent grid, incrementing the paginator. Thus, the bottom page paginator was created with invalid value preventing access to the next page of data." (it may be a little too long). What do you think of it ? > Page navigation problem with grid and include-grid > -- > > Key: OFBIZ-7020 > URL: https://issues.apache.org/jira/browse/OFBIZ-7020 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Arun Patidar >Priority: Minor > Labels: grid, include-grid, pagination > Attachments: OFBIZ-7020.patch > > > The bottom navigation buttons are not working correctly in pages with grid > and include-grid. > How to reproduce : > 1) Connect to OFBiz > 2) Go to the Party component > 3) Let all field blank and do a search > 4) Scroll down and try to use the next result page button > Result : The result page is still the same, the upper navigation bar shows > "Page 1" and the bottom one "Page 2". > Problem : With some help, I figured out where the problem is. > The result of the search is displayed in a grid. But inside this grid can > show up "include-grid" (the field User Login ID for example). Each time a > grid is created, it calls the function > "WidgetWorker.incrementPaginatorNumber(context);" which increments the > paginator number by one. > So when there are more than one grid (and include-grid) on a page, the > paginator number is modified. This means that the upper navigation bar > paginator number and the one from the bottom bar is not the same. > The bottom navigation bar is then set with wrong value and the URL put in > each navigation button is corrupted, thus not correctly redirecting to the > good page. > If you look at the URL after clicking on the bottom next button, you will see > the "bad" paginator number. > I hope this can lead someone to a solution, I lack experiences on OFBiz to > provide a patch on this issue. > Thanks, > Florian Montalbano -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7186) Find Facility Inventory Items shows same 20 items on all pagination page.
[ https://issues.apache.org/jira/browse/OFBIZ-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316507#comment-15316507 ] Montalbano Florian commented on OFBIZ-7186: --- Hi, I confirm this problem. To provide more detail about the step to reproduce : - Go to Facility - Submit the facility "Web Store Warehouse" - Go to the "Invetory" tab - In the form field "Show Products Per Page", enter 5 - Perform the find - Try to access another page, the same elements are showing up I looked into the code, it seems that this component uses old fashioned coding way (but I'm not quite sure, maybe it's actually cutting-edge). The target of the form to perform the search is set to : {code} target="${facilityInventoryByProductScreen}" {code} I didn't find what it was targeting. Maybe the screen "ViewFacilityInvertoryByProduct" ? It does not match anything in the controller, so I'm quite lost at this point. Is someone understanding this target ? Have a nice day. > Find Facility Inventory Items shows same 20 items on all pagination page. > - > > Key: OFBIZ-7186 > URL: https://issues.apache.org/jira/browse/OFBIZ-7186 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Arvind Singh Tomar >Priority: Critical > Labels: facility, inventory > Fix For: Trunk > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7162) Delete Child Period in EditCustomTimePeriod not secure
[ https://issues.apache.org/jira/browse/OFBIZ-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316315#comment-15316315 ] Montalbano Florian commented on OFBIZ-7162: --- I tested the patch for the trunk and the 15.12 version. It working fine, there is no error showing up (unless you count the error "caused a violation of foreign key constraint 'GLACCT_HST_CTP' " which is not very user friendly but at least it's not a bug) and the custom time period is deleted. Well done ! I'm fetching the two other versions of OFBiz to try it out on them. > Delete Child Period in EditCustomTimePeriod not secure > -- > > Key: OFBIZ-7162 > URL: https://issues.apache.org/jira/browse/OFBIZ-7162 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Montalbano Florian >Assignee: Pranay Pandey >Priority: Minor > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7162-13_07.patch, OFBIZ-7162-14_12.patch, > OFBIZ-7162-15_12.patch, OFBIZ-7162.patch > > > When deleting a Child Periods here : > https://localhost:8443/accounting/control/EditCustomTimePeriod . The > following error shows up : > "The Following Errors Occurred: > Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL > parameter [customTimePeriodId] passed to secure (https) request-map with uri > [deleteCustomTimePeriod] with an event that calls service > [deleteCustomTimePeriod]; this is not allowed for security reasons! The data > should be encrypted by making it part of the request body (a form field) > instead of the request URL. Moreover it would be kind if you could create a > Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check > before if a sub-task for this error does not exist). If you are not sure how > to create a Jira issue please have a look before at > http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help." > I checked the sub task of OFBIZ-2330 and didn't see this one yet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7151) Product one time setup fields not visible on EditProduct screen.
[ https://issues.apache.org/jira/browse/OFBIZ-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313778#comment-15313778 ] Montalbano Florian commented on OFBIZ-7151: --- That works well ! But, should we stay with one form for both the Creation and the Editon of a product ? > Product one time setup fields not visible on EditProduct screen. > > > Key: OFBIZ-7151 > URL: https://issues.apache.org/jira/browse/OFBIZ-7151 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7151-Proposition.patch, OFBIZ-7151.patch > > > Currently we have some filed in product entity that can be configured only > during create product flow. Currently these fields are only available on > create form on edit product screen these fields are missing. > These fields should be display on edit form in read only (display) mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)