[jira] [Updated] (OFBIZ-7944) Improve log visualisation throught webtools
[ https://issues.apache.org/jira/browse/OFBIZ-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7944: - Attachment: OFBIZ-7944-13.07.patch If you want use the fecth log functionnality on 13.07 I load a backport patch from trunk > Improve log visualisation throught webtools > --- > > Key: OFBIZ-7944 > URL: https://issues.apache.org/jira/browse/OFBIZ-7944 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: log, webtools > Fix For: Upcoming Branch > > Attachments: OFBIZ-7944-13.07.patch > > > Currently we have two methods for display log in OFBiz throught webtools : > * https://localhost:8443/webtools/control/LogView > * https://localhost:8443/webtools/control/FetchLogs > Each method use the same line rendering and the difference is : LogView > display only runtime/logs/ofbiz.log (or you can surcharge it vith > debug.properties) and FecthLogs list all file name ofbiz* present on > runtime/logs/ofbiz.log and offert the possibility to search only line that > macth a string. > I review the code to use only one script (remove LogView.groovy) and improve > following points : > * Optimise the FetchLog.groovy to display with same velocity a file with or > without string chain filtering > * Add a property to change the root log directory. Under linux we use > /var/log/ofbiz/ > * Add a regExp to match the file name of file present in the directory. > Helpful when you want to see error.log > * Complete debug.properties with comment for describe example for new > properties > And last point, add refresh button on the end page to reload the log without > lost your state on the page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7944) Improve log visualisation throught webtools
[ https://issues.apache.org/jira/browse/OFBIZ-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7944. Resolution: Implemented Works done at revision 1755302 > Improve log visualisation throught webtools > --- > > Key: OFBIZ-7944 > URL: https://issues.apache.org/jira/browse/OFBIZ-7944 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: log, webtools > Fix For: Upcoming Branch > > > Currently we have two methods for display log in OFBiz throught webtools : > * https://localhost:8443/webtools/control/LogView > * https://localhost:8443/webtools/control/FetchLogs > Each method use the same line rendering and the difference is : LogView > display only runtime/logs/ofbiz.log (or you can surcharge it vith > debug.properties) and FecthLogs list all file name ofbiz* present on > runtime/logs/ofbiz.log and offert the possibility to search only line that > macth a string. > I review the code to use only one script (remove LogView.groovy) and improve > following points : > * Optimise the FetchLog.groovy to display with same velocity a file with or > without string chain filtering > * Add a property to change the root log directory. Under linux we use > /var/log/ofbiz/ > * Add a regExp to match the file name of file present in the directory. > Helpful when you want to see error.log > * Complete debug.properties with comment for describe example for new > properties > And last point, add refresh button on the end page to reload the log without > lost your state on the page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7944) Improve log visualisation throught webtools
[ https://issues.apache.org/jira/browse/OFBIZ-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409366#comment-15409366 ] Nicolas Malin edited comment on OFBIZ-7944 at 8/5/16 12:06 PM: --- Works done on trunk at revision 1755302 was (Author: soledad): Works done at revision 1755302 > Improve log visualisation throught webtools > --- > > Key: OFBIZ-7944 > URL: https://issues.apache.org/jira/browse/OFBIZ-7944 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: log, webtools > Fix For: Upcoming Branch > > > Currently we have two methods for display log in OFBiz throught webtools : > * https://localhost:8443/webtools/control/LogView > * https://localhost:8443/webtools/control/FetchLogs > Each method use the same line rendering and the difference is : LogView > display only runtime/logs/ofbiz.log (or you can surcharge it vith > debug.properties) and FecthLogs list all file name ofbiz* present on > runtime/logs/ofbiz.log and offert the possibility to search only line that > macth a string. > I review the code to use only one script (remove LogView.groovy) and improve > following points : > * Optimise the FetchLog.groovy to display with same velocity a file with or > without string chain filtering > * Add a property to change the root log directory. Under linux we use > /var/log/ofbiz/ > * Add a regExp to match the file name of file present in the directory. > Helpful when you want to see error.log > * Complete debug.properties with comment for describe example for new > properties > And last point, add refresh button on the end page to reload the log without > lost your state on the page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7944) Improve log visualisation throught webtools
[ https://issues.apache.org/jira/browse/OFBIZ-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7944: - Description: Currently we have two methods for display log in OFBiz throught webtools : * https://localhost:8443/webtools/control/LogView * https://localhost:8443/webtools/control/FetchLogs Each method use the same line rendering and the difference is : LogView display only runtime/logs/ofbiz.log (or you can surcharge it vith debug.properties) and FecthLogs list all file name ofbiz* present on runtime/logs/ofbiz.log and offert the possibility to search only line that macth a string. I review the code to use only one script (remove LogView.groovy) and improve following points : * Optimise the FetchLog.groovy to display with same velocity a file with or without string chain filtering * Add a property to change the root log directory. Under linux we use /var/log/ofbiz/ * Add a regExp to match the file name of file present in the directory. Helpful when you want to see error.log * Complete debug.properties with comment for describe example for new properties And last point, add refresh button on the end page to reload the log without lost your state on the page. was: Currently we have two methods or display log in OFBiz throught webtools : * https://localhost:8443/webtools/control/LogView * https://localhost:8443/webtools/control/FetchLogs Each method use the same line rendering and the difference is, LogView display only runtime/logs/ofbiz.log (or you can surcharge it vith debug.properties) and FecthLogs list all file name ofbiz* on runtime/logs/ofbiz.log and offert the possibility to search only line that macth a string. I review the code to use only one script and improve following points : * Optimise the FetchLog.groovy to display with same velocity a file with or without string chain filtering * Add a property to change the root log directory. Under linux we use /var/log/ofbiz/ * Add a regExp to match the file name of file present in the directory. Helpful when you want to see error.log * Complete debug.properties with comment for describe example for new properties And last point, add refresh button on the end page to reload the log without lost your state on the page. > Improve log visualisation throught webtools > --- > > Key: OFBIZ-7944 > URL: https://issues.apache.org/jira/browse/OFBIZ-7944 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: log, webtools > Fix For: Upcoming Branch > > > Currently we have two methods for display log in OFBiz throught webtools : > * https://localhost:8443/webtools/control/LogView > * https://localhost:8443/webtools/control/FetchLogs > Each method use the same line rendering and the difference is : LogView > display only runtime/logs/ofbiz.log (or you can surcharge it vith > debug.properties) and FecthLogs list all file name ofbiz* present on > runtime/logs/ofbiz.log and offert the possibility to search only line that > macth a string. > I review the code to use only one script (remove LogView.groovy) and improve > following points : > * Optimise the FetchLog.groovy to display with same velocity a file with or > without string chain filtering > * Add a property to change the root log directory. Under linux we use > /var/log/ofbiz/ > * Add a regExp to match the file name of file present in the directory. > Helpful when you want to see error.log > * Complete debug.properties with comment for describe example for new > properties > And last point, add refresh button on the end page to reload the log without > lost your state on the page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7944) Improve log visualisation throught webtools
Nicolas Malin created OFBIZ-7944: Summary: Improve log visualisation throught webtools Key: OFBIZ-7944 URL: https://issues.apache.org/jira/browse/OFBIZ-7944 Project: OFBiz Issue Type: Improvement Components: framework/webtools Affects Versions: Trunk Reporter: Nicolas Malin Assignee: Nicolas Malin Priority: Minor Fix For: Upcoming Branch Currently we have two methods or display log in OFBiz throught webtools : * https://localhost:8443/webtools/control/LogView * https://localhost:8443/webtools/control/FetchLogs Each method use the same line rendering and the difference is, LogView display only runtime/logs/ofbiz.log (or you can surcharge it vith debug.properties) and FecthLogs list all file name ofbiz* on runtime/logs/ofbiz.log and offert the possibility to search only line that macth a string. I review the code to use only one script and improve following points : * Optimise the FetchLog.groovy to display with same velocity a file with or without string chain filtering * Add a property to change the root log directory. Under linux we use /var/log/ofbiz/ * Add a regExp to match the file name of file present in the directory. Helpful when you want to see error.log * Complete debug.properties with comment for describe example for new properties And last point, add refresh button on the end page to reload the log without lost your state on the page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-4850) When Use Add Tax button on invoice summary, duplicate existed tax line
[ https://issues.apache.org/jira/browse/OFBIZ-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-4850: Assignee: Nicolas Malin > When Use Add Tax button on invoice summary, duplicate existed tax line > --- > > Key: OFBIZ-4850 > URL: https://issues.apache.org/jira/browse/OFBIZ-4850 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-4850.patch > > > When you click on "add tax" button on invoice summary, the service create a > invoice item list and generate sale tax by list iterate. > Two problem : > 1. When you have 3 lignes with one without productId, the service may skip > to set tax on valid invoice item > 2. If sale tax is present, the service duplicate it and generate a tax on > the tax (since a productId is on the line). > I propose a patch to : > 1. remove all exiting tax associate to a product before analyze > 2. take only invoice item with a productId -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7801: Assignee: Nicolas Malin > Duplicate invoice tax by using "Add Tax" button. > > > Key: OFBIZ-7801 > URL: https://issues.apache.org/jira/browse/OFBIZ-7801 > Project: OFBiz > Issue Type: Bug >Reporter: Chula Lathong >Assignee: Nicolas Malin > Attachments: OFBIZ-7801.patch > > > A bug occurs when users generate tax by click the "Add Tax" button. > If an invoice has tax in invoice items list, the system will generate tax of > tax invoice items . > The problem is the system should not generate tax of tax invoice items. > This patch shall change process of "Add Tax" service to remove all tax > invoice items before generating new tax invoice items. > And I have a suggestion about "Add Tax" service, for each invoice the invoice > items it is possible to have the product item that has productId and no > productId. > But in the "Add Tax" service they have check on each product item should have > a productId if it's not the sevice will return error no productId. > So, I think the service should ignore to calculate tax on invoice item that's > not has a productId link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401693#comment-15401693 ] Nicolas Malin commented on OFBIZ-7801: -- Hello, :) I will check this issue and my old OFBIZ-4850. > Duplicate invoice tax by using "Add Tax" button. > > > Key: OFBIZ-7801 > URL: https://issues.apache.org/jira/browse/OFBIZ-7801 > Project: OFBiz > Issue Type: Bug >Reporter: Chula Lathong > Attachments: OFBIZ-7801.patch > > > A bug occurs when users generate tax by click the "Add Tax" button. > If an invoice has tax in invoice items list, the system will generate tax of > tax invoice items . > The problem is the system should not generate tax of tax invoice items. > This patch shall change process of "Add Tax" service to remove all tax > invoice items before generating new tax invoice items. > And I have a suggestion about "Add Tax" service, for each invoice the invoice > items it is possible to have the product item that has productId and no > productId. > But in the "Add Tax" service they have check on each product item should have > a productId if it's not the sevice will return error no productId. > So, I think the service should ignore to calculate tax on invoice item that's > not has a productId link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7673) Create demo PartyStatus data for existing parties for applications component
[ https://issues.apache.org/jira/browse/OFBIZ-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7673. Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Suraj it's done on trunk at revision 1753797 > Create demo PartyStatus data for existing parties for applications component > > > Key: OFBIZ-7673 > URL: https://issues.apache.org/jira/browse/OFBIZ-7673 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Reporter: Suraj Khurana >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7673.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7603) There should be a demo data set for the PartyStatus entity
[ https://issues.apache.org/jira/browse/OFBIZ-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7603. Resolution: Done Ok sub task are done, I close this issue, thanks pierre for the submission > There should be a demo data set for the PartyStatus entity > -- > > Key: OFBIZ-7603 > URL: https://issues.apache.org/jira/browse/OFBIZ-7603 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Nicolas Malin > > Currently there is no demo data for the PartyStatus entity. This complicates > tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7672) Create demo PartyStatus data for existing parties for special purpose component
[ https://issues.apache.org/jira/browse/OFBIZ-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7672. Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Suraj, it's done on trunk at revision 1753795 > Create demo PartyStatus data for existing parties for special purpose > component > --- > > Key: OFBIZ-7672 > URL: https://issues.apache.org/jira/browse/OFBIZ-7672 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/ebaystore, specialpurpose/ecommerce, > specialpurpose/projectmgr, specialpurpose/scrum >Reporter: Suraj Khurana >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7672.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7821) Remove unused system generated fields from all data files
[ https://issues.apache.org/jira/browse/OFBIZ-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7821: Assignee: Nicolas Malin > Remove unused system generated fields from all data files > - > > Key: OFBIZ-7821 > URL: https://issues.apache.org/jira/browse/OFBIZ-7821 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Nicolas Malin >Priority: Minor > > There are four system generated fields for every entity as lastUpdatedStamp, > lastUpdatedTxStamp, createdStamp and createdTxStamp > To increase readability of data files, these fields are not necessary to be > there in data files, as it gets generated every time when data load occurs. > This ticket will be served as a parent ticket and I will be creating child > tickets component wise for all affected components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7619) Add "changeByUserLoginId" field for BudgetStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7619. Resolution: Implemented Fix Version/s: Upcoming Branch Ok work for me, commited on trunk at revision 1752602 Thanks Nameet > Add "changeByUserLoginId" field for BudgetStatus > > > Key: OFBIZ-7619 > URL: https://issues.apache.org/jira/browse/OFBIZ-7619 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7619.patch, OFBIZ-7619.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7619) Add "changeByUserLoginId" field for BudgetStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7619: Assignee: Nicolas Malin > Add "changeByUserLoginId" field for BudgetStatus > > > Key: OFBIZ-7619 > URL: https://issues.apache.org/jira/browse/OFBIZ-7619 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7619.patch, OFBIZ-7619.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7781) Have a configurable solution with respect to the default fields of all entities
[ https://issues.apache.org/jira/browse/OFBIZ-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376571#comment-15376571 ] Nicolas Malin commented on OFBIZ-7781: -- +1, the advantage with track user on EntityStatus is the direct benefit to follow activity on sensible process. A good compromise between useful and resource. Track all entities Oo sorry I can't believe it. A better way would be improve entity-audit-log engine, to enable it when you want at the fly and have a screen to analyse. > Have a configurable solution with respect to the default fields of all > entities > --- > > Key: OFBIZ-7781 > URL: https://issues.apache.org/jira/browse/OFBIZ-7781 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Pierre Smits > > This issue follows up on comments posted in the OFBIZ-7622 sub-task. > Currently the fields to be added to all entities are defined in > ModelEntity.java. This is a limited list consisting of: > * public static final String STAMP_FIELD = "lastUpdatedStamp"; > * public static final String STAMP_TX_FIELD = "lastUpdatedTxStamp"; > * public static final String CREATE_STAMP_FIELD = "createdStamp"; > * public static final String CREATE_STAMP_TX_FIELD = "createdTxStamp"; > After the implemented code change of the sub task mentioned above, a new > discussion evolved through postings of comments on the subject of how to get > more flexibility in. > This issue is a starting point and potentially a place holder for sub > subtasks to get to a more flexible solution. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7623) Add "changeByUserLoginId" field for FinAccountStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372625#comment-15372625 ] Nicolas Malin commented on OFBIZ-7623: -- What Jacques ? I'm Nicolas not Gil ! ^^ this is the gil's code This issue is http://svn.apache.org/viewvc?rev=1752232=rev and you give the code http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java?view=diff=1752230=1752231=1752231 > Add "changeByUserLoginId" field for FinAccountStatus > > > Key: OFBIZ-7623 > URL: https://issues.apache.org/jira/browse/OFBIZ-7623 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7623.patch, OFBIZ-7623.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7618) Add "changeByUserLoginId" field for ShipmentStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7618. Resolution: Implemented Fix Version/s: Upcoming Branch Ok it's commited on trunk at revision 1752233 thanks [~nj] and [~charles steltzlen] for the resolution > Add "changeByUserLoginId" field for ShipmentStatus > -- > > Key: OFBIZ-7618 > URL: https://issues.apache.org/jira/browse/OFBIZ-7618 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7618.patch, ofbiz-7618-ShipmentStatus.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7623) Add "changeByUserLoginId" field for FinAccountStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7623. Resolution: Implemented Fix Version/s: Upcoming Branch Ok commited on trunk at revision 1752232, thks Nameet. > Add "changeByUserLoginId" field for FinAccountStatus > > > Key: OFBIZ-7623 > URL: https://issues.apache.org/jira/browse/OFBIZ-7623 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7623.patch, OFBIZ-7623.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7623) Add "changeByUserLoginId" field for FinAccountStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7623: - Attachment: OFBIZ-7623.patch > Add "changeByUserLoginId" field for FinAccountStatus > > > Key: OFBIZ-7623 > URL: https://issues.apache.org/jira/browse/OFBIZ-7623 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7623.patch, OFBIZ-7623.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7623) Add "changeByUserLoginId" field for FinAccountStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371836#comment-15371836 ] Nicolas Malin commented on OFBIZ-7623: -- I found on this entity an other date time field *statusEndDate* that store on the previous entity status change the date end for this cover. I manage it directly on the entity-auto but I'm not sure if this field is useful because the value can be found with analyse the next EntityStatus value stored. > Add "changeByUserLoginId" field for FinAccountStatus > > > Key: OFBIZ-7623 > URL: https://issues.apache.org/jira/browse/OFBIZ-7623 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7623.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7623) Add "changeByUserLoginId" field for FinAccountStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7623: Assignee: Nicolas Malin (was: Renuka Srishti) > Add "changeByUserLoginId" field for FinAccountStatus > > > Key: OFBIZ-7623 > URL: https://issues.apache.org/jira/browse/OFBIZ-7623 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7623.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7765) Replace call with
[ https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7765: - Attachment: OFBIZ-7765.patch Deepak, I relaod a new patch with two correct revert xml header on applications/product/minilang/product/test/GroupOrderTest.xml and remove ]]> on ShoppingCartTest.xml now the test pass ! :) > Replace call with
[jira] [Commented] (OFBIZ-7765) Replace call with
[ https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367564#comment-15367564 ] Nicolas Malin commented on OFBIZ-7765: -- What you thanks me ! :/ for a work that I realized with less successful than you ! crazy ^^ Don't reversing the charges, the thanks is to you and Deepak. Ok we wait Deepak, during this a detect some test failed, I will analyse the reason > Replace call with
[jira] [Commented] (OFBIZ-7765) Replace call with
[ https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367502#comment-15367502 ] Nicolas Malin commented on OFBIZ-7765: -- +1 > Replace call with
[jira] [Commented] (OFBIZ-7765) Replace call with
[ https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367497#comment-15367497 ] Nicolas Malin commented on OFBIZ-7765: -- Ok sorry deepak, Jacopo already done on OFBIZ-7763 , I'm coming after the war :/ > Replace call with
[jira] [Updated] (OFBIZ-7765) Replace call with
[ https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7765: - Attachment: (was: OFBIZ-7765.patch) > Replace call with
[jira] [Updated] (OFBIZ-7765) Replace call with
[ https://issues.apache.org/jira/browse/OFBIZ-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7765: - Attachment: OFBIZ-7765.patch Also good to me, I update a new patch with remove callBsh class because it's unusable in few time. Maybe we can improve the script documentation to indicate that it can replace by
[jira] [Commented] (OFBIZ-7760) Removed from UtilCache the ability to persist entries in the file system
[ https://issues.apache.org/jira/browse/OFBIZ-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366422#comment-15366422 ] Nicolas Malin commented on OFBIZ-7760: -- Thanks Jacopo for this issue that resolve the problem with jdbm. Maybe if the need appears to use cache with file system store wecan be inspired by this issue ! > Removed from UtilCache the ability to persist entries in the file system > > > Key: OFBIZ-7760 > URL: https://issues.apache.org/jira/browse/OFBIZ-7760 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato > Fix For: Upcoming Branch > > Attachments: OFBIZ-7760.patch > > > Removed from UtilCache the ability to persist entries in the file system. > This feature has been contributed a long time ago as an experimental feature > but never really matured into a production ready artifact: since it was > contributed, no users asked about how to use it, or tested it, or reported > bugs or enhancement requests. > More importantly, the feature has always been disabled in the OFBiz framework > (i.e. the widget code and the entity engine code were not using it). > This removal should not impact our user base; however, after the removal, an > entry to the Attic will be created to keep track of it and to make it easier, > to interested users, to get this code, improve it (e.g. by making it > dependent on a live external jar, for example MapDB instead of JDBM) and > possibly contribute it back to the project. > The most compelling reason for its removal is that the feature was based on a > snapshot, unreleased version of JDBM, which is now a mostly dead project: for > licensing reasons we are no more allowed to bundle jars in our releases. > Additionally, having code that relies an old jar from a no more active > project represents a maintenance issue for the community. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364884#comment-15364884 ] Nicolas Malin commented on OFBIZ-7680: -- :) Yes at first time I was going for correct all instantiation error but after this discover I don't know well these form to be sure not introduce a regression. And on second time I found that indicate context on value-field is really explicit when you read the form code ;) > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[
https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364205#comment-15364205
]
Nicolas Malin commented on OFBIZ-7680:
--
On framework/entity/src/org/ofbiz/entity/finder/PrimaryKeyFinder:90 I found
this (use by AbstractModelAction)
{code}
if (!valueNameAcsr.isEmpty()) {
this.valueNameAcsr.put(context, valueOut);
} else {
if (valueOut != null) {
context.putAll(valueOut);
}
}
{code}
I think we can extend like that
{code}
String originalValueName = this.valueNameAcsr.getOriginalName();
if (originalValueName.isEmpty()) {
originalValueName = "context";
}
if ( !"context".equals(originalValueName)) {
this.valueNameAcsr.put(context, valueOut);
} else {
if (valueOut != null) {
context.putAll(valueOut);
}
}
{code}
And correct Forms file like that
{code}
{code}
To
{code}
{code}
Your remarks?
> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-7680
> URL: https://issues.apache.org/jira/browse/OFBIZ-7680
> Project: OFBiz
> Issue Type: Bug
> Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>
> I found these errors
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 25
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 57
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 93
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. CompDocTemplateTree.xml
> /ofbiz/applications/content/widget/compdoc line 125
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. ContentForms.xml
> /ofbiz/applications/content/widget/content line 235
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. ContentSetupForms.xml
> /ofbiz/applications/content/widget/contentsetup line 217
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. EmploymentAppForms.xml
> /ofbiz/applications/humanres/widget/forms line 27
> cvc-complex-type.4: Attribute 'value-field' must appear on element
> 'entity-one'. PayGradeForms.xml
> /ofbiz/applications/humanres/widget/forms line 65
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component
[ https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364171#comment-15364171 ] Nicolas Malin commented on OFBIZ-7544: -- instead replace by check box, why replace just by a multiple select input ? > OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for > 'Manufacturing' component > --- > > Key: OFBIZ-7544 > URL: https://issues.apache.org/jira/browse/OFBIZ-7544 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Swapnil Shah >Assignee: Swapnil Shah > Attachments: OFBIZ-7544.patch > > > Please refer to details shared over OFBIZ-7542 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7673) Create demo PartyStatus data for existing parties for applications component
[ https://issues.apache.org/jira/browse/OFBIZ-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7673: Assignee: Nicolas Malin (was: Suraj Khurana) > Create demo PartyStatus data for existing parties for applications component > > > Key: OFBIZ-7673 > URL: https://issues.apache.org/jira/browse/OFBIZ-7673 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Reporter: Suraj Khurana >Assignee: Nicolas Malin > Attachments: OFBIZ-7673.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7603) There should be a demo data set for the PartyStatus entity
[ https://issues.apache.org/jira/browse/OFBIZ-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7603: Assignee: Nicolas Malin > There should be a demo data set for the PartyStatus entity > -- > > Key: OFBIZ-7603 > URL: https://issues.apache.org/jira/browse/OFBIZ-7603 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Nicolas Malin > > Currently there is no demo data for the PartyStatus entity. This complicates > tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7672) Create demo PartyStatus data for existing parties for special purpose component
[ https://issues.apache.org/jira/browse/OFBIZ-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7672: Assignee: Nicolas Malin (was: Suraj Khurana) > Create demo PartyStatus data for existing parties for special purpose > component > --- > > Key: OFBIZ-7672 > URL: https://issues.apache.org/jira/browse/OFBIZ-7672 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/ebaystore, specialpurpose/ecommerce, > specialpurpose/projectmgr, specialpurpose/scrum >Reporter: Suraj Khurana >Assignee: Nicolas Malin > Attachments: OFBIZ-7672.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6907) 1
[ https://issues.apache.org/jira/browse/OFBIZ-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-6907. Resolution: Later Assignee: Nicolas Malin I close this issue because it's too fuzzy, don't hesitate to open a new issue with specific case to improve ;) > 1 > - > > Key: OFBIZ-6907 > URL: https://issues.apache.org/jira/browse/OFBIZ-6907 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/ecommerce >Reporter: xin chang >Assignee: Nicolas Malin > > many of us think of the UI so bad,developer need to modify it,it meant need > more time to do this,I hope that your team can fix it,with many thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7680: Assignee: Nicolas Malin > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
[ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364159#comment-15364159 ] Nicolas Malin commented on OFBIZ-7680: -- negative, value-field is required at any time, it's an error on theses form > Attribute 'value-field' must appear on element 'entity-one' > --- > > Key: OFBIZ-7680 > URL: https://issues.apache.org/jira/browse/OFBIZ-7680 > Project: OFBiz > Issue Type: Bug > Components: content, humanres >Affects Versions: Trunk >Reporter: Jacques Le Roux > > I found these errors > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 25 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 57 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 93 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. CompDocTemplateTree.xml > /ofbiz/applications/content/widget/compdoc line 125 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentForms.xml > /ofbiz/applications/content/widget/content line 235 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. ContentSetupForms.xml > /ofbiz/applications/content/widget/contentsetup line 217 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. EmploymentAppForms.xml > /ofbiz/applications/humanres/widget/forms line 27 > cvc-complex-type.4: Attribute 'value-field' must appear on element > 'entity-one'. PayGradeForms.xml > /ofbiz/applications/humanres/widget/forms line 65 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363088#comment-15363088 ] Nicolas Malin commented on OFBIZ-7611: -- I commit the first version on trunk at revision 1751530. We can review the subtask to use this concept :) > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7617) Add "changeByUserLoginId" field for InvoiceStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7617. Resolution: Implemented Fix Version/s: Upcoming Branch Ok Nameet, it's on trunk at revision 1751543 with a refactoring to pass by entity-auto service :) Thanks for this issue > Add "changeByUserLoginId" field for InvoiceStatus > - > > Key: OFBIZ-7617 > URL: https://issues.apache.org/jira/browse/OFBIZ-7617 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7617.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4467) Improve auto-fields-entity (select include field and auto drop-down)
[ https://issues.apache.org/jira/browse/OFBIZ-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361703#comment-15361703 ] Nicolas Malin commented on OFBIZ-4467: -- ouch too old patch ... Ok I will review it later because it's on conflict with the adrian's works > Improve auto-fields-entity (select include field and auto drop-down) > > > Key: OFBIZ-4467 > URL: https://issues.apache.org/jira/browse/OFBIZ-4467 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Screen Widget Redesign, Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-4467-example.patch, OFBIZ-4467-example.patch, > OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.png > > > Hi > Here are two improvments to complete the element 'auto-fields-entity' of > forms. > The first one consists in adding one fields allowing to select which fields > are include in the form (same way as what is made on the definitions of > service): > For example: > default-field-type="display"/> > => To display only the primary key fields of the Example entity > default-field-type="edit"> > => To display only the non primary key fields of the Example entity > > => To exclude one precise fields of an entity > The second one consists in including for fields with relation a drop-down or > a display entity according to EntityType > Any comments are welcome -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4467) Improve auto-fields-entity (select include field and auto drop-down)
[ https://issues.apache.org/jira/browse/OFBIZ-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360495#comment-15360495 ] Nicolas Malin commented on OFBIZ-4467: -- Ok Ashish I will do it ;) > Improve auto-fields-entity (select include field and auto drop-down) > > > Key: OFBIZ-4467 > URL: https://issues.apache.org/jira/browse/OFBIZ-4467 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Screen Widget Redesign, Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-4467-example.patch, OFBIZ-4467-example.patch, > OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.png > > > Hi > Here are two improvments to complete the element 'auto-fields-entity' of > forms. > The first one consists in adding one fields allowing to select which fields > are include in the form (same way as what is made on the definitions of > service): > For example: > default-field-type="display"/> > => To display only the primary key fields of the Example entity > default-field-type="edit"> > => To display only the non primary key fields of the Example entity > > => To exclude one precise fields of an entity > The second one consists in including for fields with relation a drop-down or > a display entity according to EntityType > Any comments are welcome -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360145#comment-15360145 ] Nicolas Malin commented on OFBIZ-7611: -- Yes you right, you start just to add changeByUserLoginId field and I continue the idea to define a EntityStatus concept manage by entity-auto and help developer to respect it. I think we can just change the issues name and get it all done in one fell swoop ? I can finish the entity improvement and we use subtask to add the missing field like you already done, add the create service by entity-auto and propagate his call > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7611: - Attachment: OFBIZ-7611.patch I update the patch with I my ideas. If ok for you Nameet I finish the label message and add unit test. > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358654#comment-15358654 ] Nicolas Malin commented on OFBIZ-7611: -- Oh nice Nameet, I will continue, I have some idea in my brain ;) > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357735#comment-15357735 ] Nicolas Malin commented on OFBIZ-7611: -- Nameet, I am hesitant. I review your patch, no problem with you work. I just a doubt an the solution. I think we can realize a beautiful implementation of your initial proposition with improve the entity-auto and automatically manage this field and the statusDate by the engine. You won't mind if I will try to improve the entity-engine before commit your works ? > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-7266.
Resolution: Implemented
Fix Version/s: Upcoming Branch
I commited the last patch on trunk at rev 1750856
Thanks Kongrath for the submit and all other for remarks ;)
Pierre, you know, feel free to open issue for your ideas ^^
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7266-NMA.patch, OFBIZ-7266-NMA.patch,
> OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355724#comment-15355724 ] Nicolas Malin commented on OFBIZ-7611: -- enable-audit-log is complex technical element to analyse what's going on. The advantage to add changeByUserLoginId on spotted entities is to present this information to end user (it's not easy with audit-log) > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355701#comment-15355701
]
Nicolas Malin commented on OFBIZ-7266:
--
Pierre,
{quote}renaming the ?Name variables to ?Var (e.g. fromDateName to fromDateVar),
so that is more inline with general conventions.
{quote}
I ear your remark, but I'm not totally compliant with this for two point :
* ?Name is a abbrev to fieldName related of GenericValue concept
* fromDateName is present 68 occurrence on ofbiz code instead of 0 for
fromDateVar : so I prefer to not introduce an other syntax for the same element
on this issue and manage the replacement if it's really needed on an other issue
+1 for Ux but like you said it's an other issue ;)
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266-NMA.patch, OFBIZ-7266-NMA.patch,
> OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7617) Add "changeByUserLoginId" field for InvoiceStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7617: Assignee: Nicolas Malin > Add "changeByUserLoginId" field for InvoiceStatus > - > > Key: OFBIZ-7617 > URL: https://issues.apache.org/jira/browse/OFBIZ-7617 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7617.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7618) Add "changeByUserLoginId" field for ShipmentStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7618: Assignee: Nicolas Malin > Add "changeByUserLoginId" field for ShipmentStatus > -- > > Key: OFBIZ-7618 > URL: https://issues.apache.org/jira/browse/OFBIZ-7618 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7618.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7616) Add "changeByUserLoginId" field for PartyStatus
[ https://issues.apache.org/jira/browse/OFBIZ-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7616: Assignee: Nicolas Malin > Add "changeByUserLoginId" field for PartyStatus > --- > > Key: OFBIZ-7616 > URL: https://issues.apache.org/jira/browse/OFBIZ-7616 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7616.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-7266:
-
Attachment: OFBIZ-7266-NMA.patch
Ok I review the patch and do some test.
I have a second proposal with these changes :
* We check only if conditionDates is present on context
** if yes analyse from/thruDateName and the date value
** if both from/thruDateName are empty, use default fromDate, thruDate
Advantage :
* quick to activate by default the filter
* possibility to realize a filter only on the fromDateName (or thruDateName)
example :
default with fromDate thruDate
{code}
{code}
only on salesDiscontinuationDate
{code}
{code}
only on fromDate
{code}
{code}
What do you thinks about this last version ?
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266-NMA.patch, OFBIZ-7266-NMA.patch,
> OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen
[ https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7655: Assignee: Nicolas Malin > Use 'conditionFields' instead of 'andCondition' in Lookup screen > > > Key: OFBIZ-7655 > URL: https://issues.apache.org/jira/browse/OFBIZ-7655 > Project: OFBiz > Issue Type: Improvement > Components: party, product >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocompletion, conditionFields, lookup > > In order to improve a little the readibility, we can replace the use of > direct call of groovy in Lookup screen for the autocompletion parameters. > Instead, we can use the field 'conditionFields', which is a map key/value, to > declare those parameters. > This is a main task and a sub task will be created for each lookup involved. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7658) Use 'conditionFields' in LookupInternalOrganization
[ https://issues.apache.org/jira/browse/OFBIZ-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7658. Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Florian, commited on trunk at revision 1750492 > Use 'conditionFields' in LookupInternalOrganization > --- > > Key: OFBIZ-7658 > URL: https://issues.apache.org/jira/browse/OFBIZ-7658 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Fix For: Upcoming Branch > > Attachments: OFBIZ-7658.patch, OFBIZ-7658.patch > > > Change 'andCondition' (which use groovy as a value) to 'conditionsField' in > the lookup LookupScreens#LookupInternalOrganization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7657) Use 'conditionFields' in LookupContact
[ https://issues.apache.org/jira/browse/OFBIZ-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7657. Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Florian, commited on trunk at revision 1750492 > Use 'conditionFields' in LookupContact > -- > > Key: OFBIZ-7657 > URL: https://issues.apache.org/jira/browse/OFBIZ-7657 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Fix For: Upcoming Branch > > Attachments: OFBIZ-7657.patch, OFBIZ-7657.patch > > > Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in > the lookup LookupScreens#LookupContact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7659) Use 'conditionFields' in LookupVirtualProduct
[ https://issues.apache.org/jira/browse/OFBIZ-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7659. Resolution: Implemented Assignee: Nicolas Malin Fix Version/s: Upcoming Branch Commited on trunk at revision 1750491. Thanks florian for this issue > Use 'conditionFields' in LookupVirtualProduct > - > > Key: OFBIZ-7659 > URL: https://issues.apache.org/jira/browse/OFBIZ-7659 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Fix For: Upcoming Branch > > Attachments: OFBIZ-7659.patch, OFBIZ-7659.patch > > > Change 'andCondition' (which uses groovy as a value) to 'conditionFields' in > the lookup LookupScreens#LookupVirtualProduct. > Any Review/Test is welcome ! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7658) Use 'conditionFields' in LookupInternalOrganization
[ https://issues.apache.org/jira/browse/OFBIZ-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7658: Assignee: Nicolas Malin > Use 'conditionFields' in LookupInternalOrganization > --- > > Key: OFBIZ-7658 > URL: https://issues.apache.org/jira/browse/OFBIZ-7658 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7658.patch, OFBIZ-7658.patch > > > Change 'andCondition' (which use groovy as a value) to 'conditionsField' in > the lookup LookupScreens#LookupInternalOrganization. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen
[ https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352838#comment-15352838 ] Nicolas Malin commented on OFBIZ-7655: -- Agree with this ! > Use 'conditionFields' instead of 'andCondition' in Lookup screen > > > Key: OFBIZ-7655 > URL: https://issues.apache.org/jira/browse/OFBIZ-7655 > Project: OFBiz > Issue Type: Improvement > Components: party, product >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: andCondition, autocompletion, conditionFields, lookup > > In order to improve a little the readibility, we can replace the use of > direct call of groovy in Lookup screen for the autocompletion parameters. > Instead, we can use the field 'conditionFields', which is a map key/value, to > declare those parameters. > This is a main task and a sub task will be created for each lookup involved. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7656) Use 'conditionField' in LookupCustomerName
[ https://issues.apache.org/jira/browse/OFBIZ-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7656. Resolution: Implemented Fix Version/s: Upcoming Branch Ok it's fine for me also :) It's commited on trunk at revision 1750475 > Use 'conditionField' in LookupCustomerName > -- > > Key: OFBIZ-7656 > URL: https://issues.apache.org/jira/browse/OFBIZ-7656 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Fix For: Upcoming Branch > > Attachments: OFBIZ-7655.patch, OFBIZ-7656.patch > > > Change the field 'andCondition' (which use direct call to groovy) to > 'conditionFields' in the lookup LookupScreens#LookupCustomerName. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7657) Use 'conditionFields' in LookupContact
[ https://issues.apache.org/jira/browse/OFBIZ-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7657: Assignee: Nicolas Malin > Use 'conditionFields' in LookupContact > -- > > Key: OFBIZ-7657 > URL: https://issues.apache.org/jira/browse/OFBIZ-7657 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > Attachments: OFBIZ-7657.patch > > > Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in > the lookup LookupScreens#LookupContact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7656) Use 'conditionField' in LookupCustomerName
[ https://issues.apache.org/jira/browse/OFBIZ-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7656: Assignee: Nicolas Malin > Use 'conditionField' in LookupCustomerName > -- > > Key: OFBIZ-7656 > URL: https://issues.apache.org/jira/browse/OFBIZ-7656 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: andCondition, autocomplete, conditionFields, lookup > > Change the field 'andCondition' (which use direct call to groovy) to > 'conditionFields' in the lookup LookupScreens#LookupCustomerName. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351725#comment-15351725 ] Nicolas Malin commented on OFBIZ-7534: -- Taher, I tested your works and my remarks : * Good documentation * Gradle is a little disturbing for guy like me that know only ant but I'm sure the learning time is a good invest :) * Tested some command (not all) and it's work fine, the unit test isn't break ;) I resume by "Great job". I appreciate the readme conversion to markdown > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7575) Styling is not applied on Logs in LogView screen
[ https://issues.apache.org/jira/browse/OFBIZ-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351626#comment-15351626 ] Nicolas Malin commented on OFBIZ-7575: -- difficult in this case to differentiate bug or improvement because this functionality existed with log4j. It was broken with log4j2 and the new pattern log file. But in all case, thks all for this correction ;) > Styling is not applied on Logs in LogView screen > > > Key: OFBIZ-7575 > URL: https://issues.apache.org/jira/browse/OFBIZ-7575 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Swapnil M Mane >Assignee: Pranay Pandey > Fix For: 14.12.01, 15.12.01, 13.07.04 > > Attachments: OFBIZ-7575-after.png, OFBIZ-7575-before.png, > OFBIZ-7575.patch > > > In LogView screen (https://localhost:8443/webtools/control/LogView) the > styling on logs should be applied on the basis of its type. > for e.g. the error should be shown in red, the warning should be in blue etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7631) Remove XmlFormRenderer Class after removing its dependency
[ https://issues.apache.org/jira/browse/OFBIZ-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7631. Resolution: Implemented Fix Version/s: Upcoming Branch Done on trunk at revision 1750400 by patch application. I delete de empty directory xml at revision 1750401 Thanks Ravi for these issues ;) > Remove XmlFormRenderer Class after removing its dependency > -- > > Key: OFBIZ-7631 > URL: https://issues.apache.org/jira/browse/OFBIZ-7631 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7631_trunk.patch > > > XmlFormRenderer should be deprecated in favor of the MacroFormRenderer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7633) Remove TextScreenRenderer Class after removing its dependency
[ https://issues.apache.org/jira/browse/OFBIZ-7633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7633. Resolution: Implemented Fix Version/s: Upcoming Branch Done on trunk at revision 1750401 The commit delete also the empty directory framework/widget/src/org/ofbiz/widget/renderer/xml related to OFBIZ-7631 > Remove TextScreenRenderer Class after removing its dependency > - > > Key: OFBIZ-7633 > URL: https://issues.apache.org/jira/browse/OFBIZ-7633 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > Attachments: OFBIZ-7633_trunk.patch > > > TextScreenRenderer should be deprecated in favor of the Macro Renderer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7632) Remove TextFormRenderer Class after removing its dependency
[ https://issues.apache.org/jira/browse/OFBIZ-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7632. Resolution: Implemented Assignee: Nicolas Malin (was: Ravi Lodhi) Fix Version/s: Upcoming Branch See OFBIZ-7633 > Remove TextFormRenderer Class after removing its dependency > --- > > Key: OFBIZ-7632 > URL: https://issues.apache.org/jira/browse/OFBIZ-7632 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Nicolas Malin > Fix For: Upcoming Branch > > > TextFormRenderer should be deprecated in favor of the MacroFormRenderer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7633) Remove TextScreenRenderer Class after removing its dependency
[ https://issues.apache.org/jira/browse/OFBIZ-7633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7633: Assignee: Nicolas Malin (was: Ravi Lodhi) > Remove TextScreenRenderer Class after removing its dependency > - > > Key: OFBIZ-7633 > URL: https://issues.apache.org/jira/browse/OFBIZ-7633 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Nicolas Malin > Attachments: OFBIZ-7633_trunk.patch > > > TextScreenRenderer should be deprecated in favor of the Macro Renderer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7631) Remove XmlFormRenderer Class after removing its dependency
[ https://issues.apache.org/jira/browse/OFBIZ-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7631: Assignee: Nicolas Malin (was: Ravi Lodhi) > Remove XmlFormRenderer Class after removing its dependency > -- > > Key: OFBIZ-7631 > URL: https://issues.apache.org/jira/browse/OFBIZ-7631 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Nicolas Malin > Attachments: OFBIZ-7631_trunk.patch > > > XmlFormRenderer should be deprecated in favor of the MacroFormRenderer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-7266:
-
Attachment: OFBIZ-7266-NMA.patch
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266-NMA.patch, OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350889#comment-15350889
]
Nicolas Malin commented on OFBIZ-7266:
--
Kongrath I reviewed the patch and I realized some optimization but not tested
yes . Do you have an example to implement this search to test ?
Otherwise, I will prepare some data to do this.
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7611: Assignee: Nicolas Malin > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350659#comment-15350659
]
Nicolas Malin commented on OFBIZ-7266:
--
I will try to check it today
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin reassigned OFBIZ-7266:
Assignee: Nicolas Malin
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7155) Remove jce-jdk13-154.jar
[
https://issues.apache.org/jira/browse/OFBIZ-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344225#comment-15344225
]
Nicolas Malin commented on OFBIZ-7155:
--
I loaded this library needed by tika to analyse on test case the screen engine
result on page rendering by view type screenfop.
If jce-jdk13-154.jar is problematic when can disable this test and remove it
> Remove jce-jdk13-154.jar
>
>
> Key: OFBIZ-7155
> URL: https://issues.apache.org/jira/browse/OFBIZ-7155
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Christian Geisert
>Assignee: Christian Geisert
> Fix For: Upcoming Branch, 15.12.01
>
>
> After updating our project to the latest release15.12 branch we got the
> following error when accessing OFBiz pages:
> {code}
> 2016-06-01 14:37:14,040 |http-nio-8443-exec-2 |NioEndpoint
> |E|
> java.lang.RuntimeException: Could not generate DH keypair
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1429)
> ~[?:1.8.0_77]
> ...
> Caused by: java.security.InvalidAlgorithmParameterException: parameter object
> not a ECParameterSpec
> at
> org.bouncycastle.jcajce.provider.asymmetric.ec.KeyPairGeneratorSpi$EC.initialize(Unknown
> Source) ~[jce-jdk13-154.jar:1.54.0]
> ...
> {code}
> It turned out that jce-jdk13-154.jar was the culprit. After removing this Jar
> everything worked as expected. As this jar is an optional dependency of
> PDFBox (which is used by Tika) and is only need for Java < 1.7 I propose to
> remove it from OFBiz.
> I'll wait a few days and if there are no objections I'll remove the jar
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7248) Improve the layout of PDF documents
[ https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344217#comment-15344217 ] Nicolas Malin commented on OFBIZ-7248: -- I wrote an example here OFBIZ-5759, but we can extend this idea to all generic document. Now the first step proposed by Mohammad is also good, more easier to resolve and nice for end user when discover OFBiz the first time ;) > Improve the layout of PDF documents > --- > > Key: OFBIZ-7248 > URL: https://issues.apache.org/jira/browse/OFBIZ-7248 > Project: OFBiz > Issue Type: Improvement >Reporter: Mohammad Kathawala > Fix For: Trunk > > > The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, > Shipment etc. does not look very good and is not very readable for end users. > We need to have a properly structured PDF documents which is easy to read. > I am going to create sub-tasks of this parent task for all the different > objects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application
[
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344183#comment-15344183
]
Nicolas Malin edited comment on OFBIZ-7511 at 6/22/16 12:02 PM:
Thanks Diversh for the explanation, I had some difficulty than Jacques to
understand exactly the problem.
When we extend a form we can surcharge a field with only the wanted attribute
to complete or change. Maybe override a field came from auto-field-* element
would be treated like that.
{code}
{code}
Or for not disturbing developer and xsd, we can change the field analyse like
service definition
{code}
{code}
I quite aware of going off on a tangent, but sometime a hight level idea can
resolve a specific case and some others ! :)
was (Author: soledad):
Thanks Diversh for the explanation, I had some difficulty than Jacques to
understand exactly the problem.
When we extend a form we can surcharge a field with only the wanted attribute
to complete or change. Maybe override a field came from auto-field-* element
would be treated like that.
{code}
{code}
Or for not disturbing developer and xsd, we can change the field analyse like
service definition
{code}
{code}
I quite aware of going off on a tangent, but sometime an hight level idea can
resolve a specif case and some others ! :)
> Add proper form validation across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application
[
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344183#comment-15344183
]
Nicolas Malin commented on OFBIZ-7511:
--
Thanks Diversh for the explanation, I had some difficulty than Jacques to
understand exactly the problem.
When we extend a form we can surcharge a field with only the wanted attribute
to complete or change. Maybe override a field came from auto-field-* element
would be treated like that.
{code}
{code}
Or for not disturbing developer and xsd, we can change the field analyse like
service definition
{code}
{code}
I quite aware of going off on a tangent, but sometime an hight level idea can
resolve a specif case and some others ! :)
> Add proper form validation across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344167#comment-15344167 ] Nicolas Malin commented on OFBIZ-7519: -- I confirm, this patch is good. When I converted simple to entity-auto I just control that we haven't regression to centralise the modification only on the engine, and with this issue you finish to correct the service definition. Thanks for that > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager
[ https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343829#comment-15343829 ] Nicolas Malin commented on OFBIZ-7518: -- Hi Ankush, On the other case, ensurePartyRole is call by seca. What advantage to define this chain call on a service group ? It seems less adaptive than seca call > Unable to create Product Store Roles from Party manager > --- > > Key: OFBIZ-7518 > URL: https://issues.apache.org/jira/browse/OFBIZ-7518 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay > Attachments: EnsureAndCreateProductStoreRole.patch, > ProductStoreRoleError.png, RenderPartyAssignedRolesInDropDown.patch > > > System throws error while adding new product store role. > Steps to reproduce: > 1. Login to party manager and go to Company party profile page. > 2. Navigate to Product Store Roles tab. > 3. Try to create new product store role for any product store and any > roleTypeId. > 4. System should show violation of foreign key constraint error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7364) Failed to open BIRT charts on Product Statistics page.
[ https://issues.apache.org/jira/browse/OFBIZ-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7364. Ok I close, thks Rohit > Failed to open BIRT charts on Product Statistics page. > -- > > Key: OFBIZ-7364 > URL: https://issues.apache.org/jira/browse/OFBIZ-7364 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt, specialpurpose/scrum >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Nicolas Malin > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7364.patch > > > Ofbiz failed to open 3 BIRT charts on Product Statistics page. > 1. Project and Sprint > 2. Task by Type > 3. Task by status > Steps to regenerate the issue. > 1. Go to screen [Product > Statistics|https://ofbiz-vm.apache.org:8443//scrum/control/ProductStatistics] > 2. Select Product Name and Click on Submit button. > 3. Screen rendered with 3 empty sections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7364) Failed to open BIRT charts on Product Statistics page.
[ https://issues.apache.org/jira/browse/OFBIZ-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335799#comment-15335799 ] Nicolas Malin edited comment on OFBIZ-7364 at 6/17/16 12:21 PM: :/ I agree, shame on me and this commit, how could I do this. Thanks Rohit and Jacopo for the blame ! :) I correct this typo on trunk at revision 1748824, and 15.12 at revision 1748846 I checked on scrum report, and it's ok but Rohit can you confirm that this commit resolve this issue ? was (Author: soledad): :/ I agree, shame on me and this commit, how could I do this. Thanks Rohit and Jacopo for the blame ! :) I correct this typo on trunk at revision 1748824 I checked on scrum report, and it's ok but Rohit can you confirm that this commit resolve this issue ? > Failed to open BIRT charts on Product Statistics page. > -- > > Key: OFBIZ-7364 > URL: https://issues.apache.org/jira/browse/OFBIZ-7364 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt, specialpurpose/scrum >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Nicolas Malin > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7364.patch > > > Ofbiz failed to open 3 BIRT charts on Product Statistics page. > 1. Project and Sprint > 2. Task by Type > 3. Task by status > Steps to regenerate the issue. > 1. Go to screen [Product > Statistics|https://ofbiz-vm.apache.org:8443//scrum/control/ProductStatistics] > 2. Select Product Name and Click on Submit button. > 3. Screen rendered with 3 empty sections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7364) Failed to open BIRT charts on Product Statistics page.
[ https://issues.apache.org/jira/browse/OFBIZ-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7364: - Fix Version/s: Upcoming Branch > Failed to open BIRT charts on Product Statistics page. > -- > > Key: OFBIZ-7364 > URL: https://issues.apache.org/jira/browse/OFBIZ-7364 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt, specialpurpose/scrum >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Nicolas Malin > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7364.patch > > > Ofbiz failed to open 3 BIRT charts on Product Statistics page. > 1. Project and Sprint > 2. Task by Type > 3. Task by status > Steps to regenerate the issue. > 1. Go to screen [Product > Statistics|https://ofbiz-vm.apache.org:8443//scrum/control/ProductStatistics] > 2. Select Product Name and Click on Submit button. > 3. Screen rendered with 3 empty sections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7364) Failed to open BIRT charts on Product Statistics page.
[ https://issues.apache.org/jira/browse/OFBIZ-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7364: - Fix Version/s: 15.12.01 > Failed to open BIRT charts on Product Statistics page. > -- > > Key: OFBIZ-7364 > URL: https://issues.apache.org/jira/browse/OFBIZ-7364 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt, specialpurpose/scrum >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Nicolas Malin > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7364.patch > > > Ofbiz failed to open 3 BIRT charts on Product Statistics page. > 1. Project and Sprint > 2. Task by Type > 3. Task by status > Steps to regenerate the issue. > 1. Go to screen [Product > Statistics|https://ofbiz-vm.apache.org:8443//scrum/control/ProductStatistics] > 2. Select Product Name and Click on Submit button. > 3. Screen rendered with 3 empty sections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7364) Failed to open BIRT charts on Product Statistics page.
[ https://issues.apache.org/jira/browse/OFBIZ-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-7364: - Affects Version/s: Trunk Release Branch 15.12 > Failed to open BIRT charts on Product Statistics page. > -- > > Key: OFBIZ-7364 > URL: https://issues.apache.org/jira/browse/OFBIZ-7364 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt, specialpurpose/scrum >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Nicolas Malin > Fix For: Upcoming Branch, 15.12.01 > > Attachments: OFBIZ-7364.patch > > > Ofbiz failed to open 3 BIRT charts on Product Statistics page. > 1. Project and Sprint > 2. Task by Type > 3. Task by status > Steps to regenerate the issue. > 1. Go to screen [Product > Statistics|https://ofbiz-vm.apache.org:8443//scrum/control/ProductStatistics] > 2. Select Product Name and Click on Submit button. > 3. Screen rendered with 3 empty sections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7364) Failed to open BIRT charts on Product Statistics page.
[ https://issues.apache.org/jira/browse/OFBIZ-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335804#comment-15335804 ] Nicolas Malin commented on OFBIZ-7364: -- I corrected also on specialpurpose/birt/webapp/ : * AcctgTransEntriesSearchResultsInvoiceAndPayment.rptdesign * InvoiceAcctgTransEntry.rptdesign * TrialBalance.rptdesign * CouponSalesReport.rptdesign * Last3MonthsSalesReport.rptdesign My apologies for this unquality. > Failed to open BIRT charts on Product Statistics page. > -- > > Key: OFBIZ-7364 > URL: https://issues.apache.org/jira/browse/OFBIZ-7364 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt, specialpurpose/scrum >Reporter: Rohit Koushal >Assignee: Nicolas Malin > Attachments: OFBIZ-7364.patch > > > Ofbiz failed to open 3 BIRT charts on Product Statistics page. > 1. Project and Sprint > 2. Task by Type > 3. Task by status > Steps to regenerate the issue. > 1. Go to screen [Product > Statistics|https://ofbiz-vm.apache.org:8443//scrum/control/ProductStatistics] > 2. Select Product Name and Click on Submit button. > 3. Screen rendered with 3 empty sections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7364) Failed to open BIRT charts on Product Statistics page.
[ https://issues.apache.org/jira/browse/OFBIZ-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7364: Assignee: Nicolas Malin (was: Rohit Koushal) > Failed to open BIRT charts on Product Statistics page. > -- > > Key: OFBIZ-7364 > URL: https://issues.apache.org/jira/browse/OFBIZ-7364 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt, specialpurpose/scrum >Reporter: Rohit Koushal >Assignee: Nicolas Malin > Attachments: OFBIZ-7364.patch > > > Ofbiz failed to open 3 BIRT charts on Product Statistics page. > 1. Project and Sprint > 2. Task by Type > 3. Task by status > Steps to regenerate the issue. > 1. Go to screen [Product > Statistics|https://ofbiz-vm.apache.org:8443//scrum/control/ProductStatistics] > 2. Select Product Name and Click on Submit button. > 3. Screen rendered with 3 empty sections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.
[
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322433#comment-15322433
]
Nicolas Malin commented on OFBIZ-7266:
--
Your proposal is fine.
In detail I'mn't really fan to set all parameter on the context root. Why don't
use a dedicate map like conditionDate as conditionFields ?
Where you can set all your parameters related to your expression date like :
{code}
{code}
after to resolve this, from my mind, when a nowTimestamp is present, we can't
use the cache. I prefer use a post treatment to filter.
I says that but on other point, the auto completion realize a findList without
cache. I didn't see why we don'tu use the cache here.
> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Priority: Minor
> Attachments: auto-complete-fix.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service
> work) able to filter the result from date. so, in the auto complete for
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
>
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
>
>
>
> {code}
> Best Regards,
> Kongrath
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7248) Improve the layout of PDF documents
[ https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322393#comment-15322393 ] Nicolas Malin commented on OFBIZ-7248: -- No, in the past on the dead neogia project we use ireport (a nigthmare). My proposal come from my experience on customer project. I realize this on many case, and I would be good to define some pattern to set it generic at all. > Improve the layout of PDF documents > --- > > Key: OFBIZ-7248 > URL: https://issues.apache.org/jira/browse/OFBIZ-7248 > Project: OFBiz > Issue Type: Improvement >Reporter: Mohammad Kathawala > Fix For: Trunk > > > The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, > Shipment etc. does not look very good and is not very readable for end users. > We need to have a properly structured PDF documents which is easy to read. > I am going to create sub-tasks of this parent task for all the different > objects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7135) Adding role for a party show error on the second add
[ https://issues.apache.org/jira/browse/OFBIZ-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7135: Assignee: Nicolas Malin > Adding role for a party show error on the second add > > > Key: OFBIZ-7135 > URL: https://issues.apache.org/jira/browse/OFBIZ-7135 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Nicolas Malin >Priority: Minor > Labels: addrole, party > Attachments: OFBIZ-7135.patch > > > Hi all, > How to reproduce : > 1) Go to the profile of a party and then to the "Role" tab : > https://localhost:8443/partymgr/control/viewroles?partyId=admin > 2) Add any role > 3) Wait for the page to reload > 4) Try to add another role > 5) Notice the error showing up and the redirection to the "profile" page > Problem : The problem comes from a bad request send. When you select a "main > role" (without clicking on the add button), a request is send to get the form > for the "secondary role". On the first time, there is no problem, the request > is something such as : > https://localhost:8443/partymgr/control/addsecondaryroles > On the second time, it becomes something like this : > https://localhost:8443/partymgr/control/addrole/addsecondaryroles > When the controller receives this second request, it does both the "addrole" > and the "addsecondaryroles" request. So when you chose a role in the first > select, it actually sends a request to add the role before you even click on > the "add" button. > Root of the problem : > First, the target of the forms (PartyForms#AddPartyRole, > PartyForms#AddPartyMainRole and PartyForms#AddPartySecondaryRole) adding the > "main" and "secondary" roles is "addrole/viewroles" (it seems to be the only > place in the code where a target is done this way). To clear up the request, > I tried to remove the "/viewroles" to match what is done in another case : > when a task is added to a project. > It seems to work but I want to know what is your point of view on this. > Then, in the controller, there is a weird redirection to "viewprofile" > instead of allowing the user to stay on "viewroles". All of this seems > related to an update of the coding way in the project that didn't affect this > part yet. > I'll provide a patch that seems to work. > Thanks, > Florian -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7249) Error on removing scrum members
[
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321478#comment-15321478
]
Nicolas Malin commented on OFBIZ-7249:
--
Hi Anurag,
Yes it's not the good solution to delete ProductRole, but don't worries because
the function deleteScrumResource hurt my eyes.
A PartyRole would be never remove if it's use on the system because you loose
the historicist. So If you want correct this : Check when the role is use and
expire the relation.
If you check the function end
{code}
{code}
It's also not correct, why init nowtimestamp to didn't use and delete
userLoginSecurityGroup instead of expire it ?
:) so the best solution is more complicated than delete each data
> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/scrum
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12
>Reporter: Anurag Chandak
>Assignee: Anurag Chandak
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service
> deletePartyRole: org.ofbiz.entity.GenericEntityException:
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the
> following entity:
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
> (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception
> while deleting the following entity:
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
> (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7155) Remove jce-jdk13-154.jar
[
https://issues.apache.org/jira/browse/OFBIZ-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321442#comment-15321442
]
Nicolas Malin commented on OFBIZ-7155:
--
No objection, you can remove Christian :)
> Remove jce-jdk13-154.jar
>
>
> Key: OFBIZ-7155
> URL: https://issues.apache.org/jira/browse/OFBIZ-7155
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Christian Geisert
>Assignee: Christian Geisert
> Fix For: Upcoming Branch, 15.12.01
>
>
> After updating our project to the latest release15.12 branch we got the
> following error when accessing OFBiz pages:
> {code}
> 2016-06-01 14:37:14,040 |http-nio-8443-exec-2 |NioEndpoint
> |E|
> java.lang.RuntimeException: Could not generate DH keypair
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1429)
> ~[?:1.8.0_77]
> ...
> Caused by: java.security.InvalidAlgorithmParameterException: parameter object
> not a ECParameterSpec
> at
> org.bouncycastle.jcajce.provider.asymmetric.ec.KeyPairGeneratorSpi$EC.initialize(Unknown
> Source) ~[jce-jdk13-154.jar:1.54.0]
> ...
> {code}
> It turned out that jce-jdk13-154.jar was the culprit. After removing this Jar
> everything worked as expected. As this jar is an optional dependency of
> PDFBox (which is used by Tika) and is only need for Java < 1.7 I propose to
> remove it from OFBiz.
> I'll wait a few days and if there are no objections I'll remove the jar
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-7247) Humanres : Arrange UI Labels in alphabetic order according to best practice
[ https://issues.apache.org/jira/browse/OFBIZ-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-7247. Resolution: Fixed Assignee: Nicolas Malin It's done on trunk at revision 1747453, thanks Shivangi Tanwar > Humanres : Arrange UI Labels in alphabetic order according to best practice > --- > > Key: OFBIZ-7247 > URL: https://issues.apache.org/jira/browse/OFBIZ-7247 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Shivangi Tanwar >Assignee: Nicolas Malin >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7247_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7248) Improve the layout of PDF documents
[ https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321416#comment-15321416 ] Nicolas Malin edited comment on OFBIZ-7248 at 6/8/16 8:48 PM: -- I have a proposal :) , for many case : # Generic Document, quick configure for a project : ** Define a generic decorator on common oriented to rendering xsl-fo standard page. ** This Decorator would be use directly on application component to rendering document or surcharge on hot-deploy to extend for each project ** easy to realize and homogenise all document and code # Configure Document for each party ** The document rendering through content system ** Define a partyContentTypeId for each document type ** When you render a document, you check if the party on relation (on most of case the defaultOrganizationPartyId) have a partyContent on this type and call the content rendering ** This support multi-tenant, multi organization on same instance, support different technology For each document call, we use a Worker to resolve the method to render (by screen and what screen or by content) I hope that would be helpfully for this issue was (Author: soledad): I have a proposal :) , for many case : 1. Generic Document, quick configure for a project : * Define a generic decorator on common oriented to rendering xsl-fo standard page. * This Decorator would be use directly on application component to rendering document or surcharge on hot-deploy to extend for each project * easy to realize and homogenise all document and code 2. Configure Document for each party * The document rendering through content system * Define a partyContentTypeId for each document type * When you render a document, you check if the party on relation (on most of case the defaultOrganizationPartyId) have a partyContent on this type and call the content rendering * This support multi-tenant, multi organization on same instance, support different technology For each document call, we use a Worker to resolve the method to render (by screen and what screen or by content) I hope that would be helpfully for this issue > Improve the layout of PDF documents > --- > > Key: OFBIZ-7248 > URL: https://issues.apache.org/jira/browse/OFBIZ-7248 > Project: OFBiz > Issue Type: Improvement >Reporter: Mohammad Kathawala > Fix For: Trunk > > > The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, > Shipment etc. does not look very good and is not very readable for end users. > We need to have a properly structured PDF documents which is easy to read. > I am going to create sub-tasks of this parent task for all the different > objects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7248) Improve the layout of PDF documents
[ https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321416#comment-15321416 ] Nicolas Malin commented on OFBIZ-7248: -- I have a proposal :) , for many case : 1. Generic Document, quick configure for a project : * Define a generic decorator on common oriented to rendering xsl-fo standard page. * This Decorator would be use directly on application component to rendering document or surcharge on hot-deploy to extend for each project * easy to realize and homogenise all document and code 2. Configure Document for each party * The document rendering through content system * Define a partyContentTypeId for each document type * When you render a document, you check if the party on relation (on most of case the defaultOrganizationPartyId) have a partyContent on this type and call the content rendering * This support multi-tenant, multi organization on same instance, support different technology For each document call, we use a Worker to resolve the method to render (by screen and what screen or by content) I hope that would be helpfully for this issue > Improve the layout of PDF documents > --- > > Key: OFBIZ-7248 > URL: https://issues.apache.org/jira/browse/OFBIZ-7248 > Project: OFBiz > Issue Type: Improvement >Reporter: Mohammad Kathawala > Fix For: Trunk > > > The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, > Shipment etc. does not look very good and is not very readable for end users. > We need to have a properly structured PDF documents which is easy to read. > I am going to create sub-tasks of this parent task for all the different > objects. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-382) Implement Party lookup by External Id
[ https://issues.apache.org/jira/browse/OFBIZ-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321361#comment-15321361 ] Nicolas Malin commented on OFBIZ-382: - Hello, I don't understand the interest to use an externalId on party while we have a partyIdentification entity. I think it would be better to use PartyIdentification like GoodIdentification from Product to extend the search on external ofbiz id. [my life] I never realize a project without 3 or 4 different external party identification[/my life] so when I see this issue, it's a little bit light on comparison with the existing ;) > Implement Party lookup by External Id > - > > Key: OFBIZ-382 > URL: https://issues.apache.org/jira/browse/OFBIZ-382 > Project: OFBiz > Issue Type: New Feature > Components: party >Reporter: John Martin >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-382.patch, OFBIZ-382_new.patch > > > It would be helpful for anyone whom is integrating ofBiz with an external > application to be able to expose the externalId property in the Party entity. > > The tasks to complete include: > - Update the findparty.ftl to include the prompt/form input field for the > external id > - Update the PartyServices.findParty() method to include the logic to handle > the externalId argument > - Add new method getPartyFromExternalId to PartyServices > - Add getPartyFromExternalId service definition in Party > servicedef/services_view.xml > - Add misc local strings to UI label resource file > Need to determine if the External Id: input form field should be > configuarable so that it only appears if feature is enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6931) Add XLS renderer
[ https://issues.apache.org/jira/browse/OFBIZ-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-6931. Resolution: Implemented Fix Version/s: Upcoming Branch Ok It's commited at revision 1746045 on trunk > Add XLS renderer > > > Key: OFBIZ-6931 > URL: https://issues.apache.org/jira/browse/OFBIZ-6931 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS, framework >Affects Versions: Trunk >Reporter: Leila Mekika >Assignee: Nicolas Malin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6931.patch, OFBIZ-6931.patch, Sélection_154.png, > xls-renderer.patch > > > Add a new renderer type in order to enable XLS file output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6931) Add XLS renderer
[ https://issues.apache.org/jira/browse/OFBIZ-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-6931: - Attachment: OFBIZ-6931.patch I updated the patch the last remark and the refactor work realise by Deepak If no other suggest I will commit :) > Add XLS renderer > > > Key: OFBIZ-6931 > URL: https://issues.apache.org/jira/browse/OFBIZ-6931 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS, framework >Affects Versions: Trunk >Reporter: Leila Mekika >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-6931.patch, OFBIZ-6931.patch, Sélection_154.png, > xls-renderer.patch > > > Add a new renderer type in order to enable XLS file output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6931) Add XLS renderer
[
https://issues.apache.org/jira/browse/OFBIZ-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304162#comment-15304162
]
Nicolas Malin commented on OFBIZ-6931:
--
This call directly the standard message :
{quote}
البحث
Vyhledat
Suchen
Search
Buscar
Chercher
खोजे
Ricerca
検索
Zoek
Procurar
Pesquisar
Cauta
Искать
ค้นหา
Tìm kiếm
搜索
搜尋
{quote}
And I think we can also remove position="1"
> Add XLS renderer
>
>
> Key: OFBIZ-6931
> URL: https://issues.apache.org/jira/browse/OFBIZ-6931
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS, framework
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-6931.patch, Sélection_154.png, xls-renderer.patch
>
>
> Add a new renderer type in order to enable XLS file output.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6931) Add XLS renderer
[
https://issues.apache.org/jira/browse/OFBIZ-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304096#comment-15304096
]
Nicolas Malin commented on OFBIZ-6931:
--
{quote}
+
?
I'm not against, just wondering because maybe we could harmonize everywhere?
{quote}
Yes you right Jacques, maybe I change it when I view the code. If we set an
image here with hard link we can't surcharge it by the theme.
{quote}
Why not rather?
View as spreadsheet
{quote}
No pb with it !
> Add XLS renderer
>
>
> Key: OFBIZ-6931
> URL: https://issues.apache.org/jira/browse/OFBIZ-6931
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS, framework
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-6931.patch, Sélection_154.png, xls-renderer.patch
>
>
> Add a new renderer type in order to enable XLS file output.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7138) Manage Triangular European VAT
[
https://issues.apache.org/jira/browse/OFBIZ-7138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304070#comment-15304070
]
Nicolas Malin commented on OFBIZ-7138:
--
To manage this I extend the function TaxAuthorityServices.getTaxAuthorities
with this (I implement the solution on 13.07):
{code}
EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
EntityCondition.makeCondition("partyId", payToPartyId),
EntityCondition.makeCondition("isNexus", "Y")));
List taxAuthorityRawList =
delegator.findList("PartyTaxAuthInfo", cond, null, null, null, true);
List taxCondList = new ArrayList();
if (!taxAuthorityRawList.isEmpty()) {
taxCondList.add(EntityCondition.makeCondition("taxAuthPartyId",
EntityOperator.IN, EntityUtil.getFieldListFromEntityList(taxAuthorityRawList,
"taxAuthPartyId", true)));
if (Debug.infoOn()) Debug.logInfo("Search tax authority relation
for " + payToPartyId + " " + taxCondList, module);
if (originAddress == null) {
originAddress =
ContactMechWorker.getTaxOriginAddress(delegator, payToPartyId);
}
if (billingAddress == null) {
billingAddress =
ContactMechWorker.getTaxBillingAddress(delegator, billToPartyId);
}
if (originAddress != null && billingAddress != null) {
if
(originAddress.getString("countryGeoId").equals(billingAddress.getString("countryGeoId")))
{
//ok we will analyse the country where come from the flow
address = originAddress;
}
}
if (Debug.infoOn()) {
Debug.logInfo(" shipping found " +
shippingAddress.getString("countryGeoId"), module);
Debug.logInfo(" origin found " +
originAddress.getString("countryGeoId"), module);
Debug.logInfo(" billing found " +
billingAddress.getString("countryGeoId"), module);
Debug.logInfo(" country found " +
address.getString("countryGeoId"), module);
}
} else {
if (Debug.infoOn()) Debug.logInfo("No specific relation, run the
std resolution", module);
}
{code}
The idea, when an order check the vat, I resolv the taxAuth to use first with
the payToParty. I check if this party have a dedicate relation with a specific
tax authority by PartyTaxAuthInfo. If yes, I check with the shipping and the
billing adress to understand if this order is cover by the same country.
If no I continue with the standard method.
This is a simple hack, because a better solution would be use the
orderContachMech to resolve the shipping, billing and origin adress, but this
works fine like that :) .
The rest is only data configuration on the PartyAuth and bill from vendor.
After to implement a specific text on invoice template and resolve the reason
of an exoneration, I use a seca like this :
{code}
{code}
The service checkInvoiceForVATExemptReason, check if the invoice have vat line
and if not call this :
{code}
GenericValue partyAuth = EntityUtil.getFirst(partyAuths);
EntityCondition condTax = EntityCondition.makeCondition(UtilMisc.toList(
EntityExpr.makeCondition("taxAuthPartyId",
partyAuth.get("taxAuthPartyId")),
EntityExpr.makeCondition("taxAuthGeoId",
partyAuth.get("taxAuthGeoId")),
EntityExpr.makeCondition("taxPercentage",
GenericEntity.NULL_FIELD),
EntityExpr.makeCondition("taxAmount",GenericEntity.NULL_FIELD),
EntityCondition.makeCondition("taxAuthorityRateTypeId",
EntityOperator.NOT_EQUAL, "SALES_TAX")));
List taxRates =
delegator.findList("TaxAuthorityRateProduct", condTax, null,
UtilMisc.toList("sequenceNum"), null, true);
if (Debug.infoOn()) Debug.logInfo(" ### taxRates " + taxRates.size(),
module);
taxRates = EntityUtil.filterByDate(taxRates,
invoice.getTimestamp("invoiceDate"));
if (UtilValidate.isEmpty(taxRates)) {
if (Debug.infoOn()) Debug.logInfo(" no specific rules find",
module);
return result;
}
//check match case rate
for (GenericValue taxRate : taxRates) {
GenericValue custMethod = null;
String serviceName = null;
if (UtilValidate.isNotEmpty(taxRate.getString("customMethodId"))) {
custMethod = delegator.findOne("CustomMethod", true,
"customMethodId", taxRate.get("customMethodId"));
}
if (custMethod != null) serviceName =
custMethod.getString("customMethodName");
if (UtilValidate.isNotEmpty(serviceName)) {
ModelService service = dctx.getModelService(serviceName);
if (service != null) {
if (Debug.infoOn())
