[jira] [Updated] (OFBIZ-7891) Improvements in BudgetRevisionImpact entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7891: - Attachment: OFBIZ-7891.patch Thanks for the details [~rishisolankii]. Here is the patch for the issue. > Improvements in BudgetRevisionImpact entity definition and services > --- > > Key: OFBIZ-7891 > URL: https://issues.apache.org/jira/browse/OFBIZ-7891 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7891.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7891) Improvements in BudgetRevisionImpact entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7891: Assignee: Rohit Koushal > Improvements in BudgetRevisionImpact entity definition and services > --- > > Key: OFBIZ-7891 > URL: https://issues.apache.org/jira/browse/OFBIZ-7891 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is not optional while > create service. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7758:
Assignee: Rohit Koushal
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7758.patch
>
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7870) Improvements in AgreementTypeAttr entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7870: - Attachment: OFBIZ-7870.patch Added the patch to fix this issue. Thanks, Arun Patidar for the detailed description. > Improvements in AgreementTypeAttr entity definition and services > > > Key: OFBIZ-7870 > URL: https://issues.apache.org/jira/browse/OFBIZ-7870 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7870.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7870) Improvements in AgreementTypeAttr entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7870: Assignee: Rohit Koushal > Improvements in AgreementTypeAttr entity definition and services > > > Key: OFBIZ-7870 > URL: https://issues.apache.org/jira/browse/OFBIZ-7870 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is not optional while > create service as there is composite primary key. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7853) Improvements in AcctgTransType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7853: Assignee: Rohit Koushal > Improvements in AcctgTransType entity definition and services > - > > Key: OFBIZ-7853 > URL: https://issues.apache.org/jira/browse/OFBIZ-7853 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7853.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7853) Improvements in AcctgTransType entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7853: - Attachment: OFBIZ-7853.patch Patch provided. Thanks [~arunpati] for the guidance. > Improvements in AcctgTransType entity definition and services > - > > Key: OFBIZ-7853 > URL: https://issues.apache.org/jira/browse/OFBIZ-7853 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7853.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7831) Improvements in AccommodationClass entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7831: - Attachment: OFBIZ-7831.patch Added patch to fix this issue. Thanks,[~rishisolankii] for the detailed description. > Improvements in AccommodationClass entity definition and services > - > > Key: OFBIZ-7831 > URL: https://issues.apache.org/jira/browse/OFBIZ-7831 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7831.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/trhu date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7831) Improvements in AccommodationClass entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-7831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7831: Assignee: Rohit Koushal > Improvements in AccommodationClass entity definition and services > - > > Key: OFBIZ-7831 > URL: https://issues.apache.org/jira/browse/OFBIZ-7831 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/trhu date exists in entity, so nothing needs to be > taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7810) Enforce noninstantiability to UelUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7810:
-
Attachment: OFBIZ-7810.patch
Added the patch to fix this issue. Thanks, Rishi Solanki for the detailed
description.
> Enforce noninstantiability to UelUtil class
> ---
>
> Key: OFBIZ-7810
> URL: https://issues.apache.org/jira/browse/OFBIZ-7810
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7810.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected static final ExpressionFactory exprFactory =
> JuelConnector.newExpressionFactory();
> protected static final ELResolver defaultResolver = new
> ExtendedCompositeResolver()
> {code}
> - Make following protected classes as private and do related changes for
> variables in them;
> {code}
> protected static class BasicContext extends ELContext
> protected static class ReadOnlyContext extends ELContext
>protected static class ReadOnlyVariableMapper extends VariableMapper
> protected static class BasicVariableMapper extends VariableMapper
> protected static class ReadOnlyExpression extends ValueExpression
> protected static class BasicValueExpression extends ValueExpression
> protected static class ExtendedCompositeResolver extends
> CompositeELResolver
> protected static class ExtendedListResolver extends ListELResolver
> protected static class ExtendedMapResolver extends MapELResolver
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7810) Enforce noninstantiability to UelUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7810:
Assignee: Rohit Koushal
> Enforce noninstantiability to UelUtil class
> ---
>
> Key: OFBIZ-7810
> URL: https://issues.apache.org/jira/browse/OFBIZ-7810
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7810.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
> protected static final ExpressionFactory exprFactory =
> JuelConnector.newExpressionFactory();
> protected static final ELResolver defaultResolver = new
> ExtendedCompositeResolver()
> {code}
> - Make following protected classes as private and do related changes for
> variables in them;
> {code}
> protected static class BasicContext extends ELContext
> protected static class ReadOnlyContext extends ELContext
>protected static class ReadOnlyVariableMapper extends VariableMapper
> protected static class BasicVariableMapper extends VariableMapper
> protected static class ReadOnlyExpression extends ValueExpression
> protected static class BasicValueExpression extends ValueExpression
> protected static class ExtendedCompositeResolver extends
> CompositeELResolver
> protected static class ExtendedListResolver extends ListELResolver
> protected static class ExtendedMapResolver extends MapELResolver
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7803) Enforce noninstantiability to UtilMisc class
[
https://issues.apache.org/jira/browse/OFBIZ-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7803:
-
Attachment: OFBIZ-7803.patch
Added the patch to fix this issue. Thanks, Rishi Solanki for the detailed
description.
> Enforce noninstantiability to UtilMisc class
>
>
> Key: OFBIZ-7803
> URL: https://issues.apache.org/jira/browse/OFBIZ-7803
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7803.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final BigDecimal ZERO_BD = BigDecimal.ZERO;
> {code}
> - Nothing needs to be change for the private static class as it follows all
> patterns;
> {code}
> // Private lazy-initializer class
> private static class LocaleHolder
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7803) Enforce noninstantiability to UtilMisc class
[
https://issues.apache.org/jira/browse/OFBIZ-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7803:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilMisc class
>
>
> Key: OFBIZ-7803
> URL: https://issues.apache.org/jira/browse/OFBIZ-7803
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final BigDecimal ZERO_BD = BigDecimal.ZERO;
> {code}
> - Nothing needs to be change for the private static class as it follows all
> patterns;
> {code}
> // Private lazy-initializer class
> private static class LocaleHolder
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7799) Enforce noninstantiability to CatalogWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7799: - Attachment: OFBIZ-7799.patch Thanks for the details [~rishisolankii]. Here is the patch for the issue. > Enforce noninstantiability to CatalogWorker class > - > > Key: OFBIZ-7799 > URL: https://issues.apache.org/jira/browse/OFBIZ-7799 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7799.patch > > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7799) Enforce noninstantiability to CatalogWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7799: Assignee: Rohit Koushal > Enforce noninstantiability to CatalogWorker class > - > > Key: OFBIZ-7799 > URL: https://issues.apache.org/jira/browse/OFBIZ-7799 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Private constructor already exists, by making it final we just matching the > patterns from other utility classes. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page
[
https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7758:
-
Attachment: OFBIZ-7758.patch
Hi [~jacques.le.roux] and [~jamesyong],
Found out the problematic area, In AbstractModelAction.java below code snippet
causing the duplicacy in the JavaScripts and StyleSheets List.
{code}
// this is a hack for backward compatibility with the JPublish page
object
Map page =
UtilGenerics.checkMap(context.get("page"));
if (page != null) {
this.field.put(page, newValue);
}
{code}
The duplicacy can be because of context, globalContext and page contain the
reference of single object(i.e layoutSettings).
I Don't know the consequences of removing the above code. So for now providing
the alternate solution in the attached patch.
Please let me know if we are good to remove the above code snippet.
> jquery.jgrowl.min.css is linked twice in html page
> --
>
> Key: OFBIZ-7758
> URL: https://issues.apache.org/jira/browse/OFBIZ-7758
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
> Attachments: OFBIZ-7758.patch
>
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate
> linking of jquery.jgrowl.min.css i.e.
> {code}
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css"
> type="text/css"/>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7744) Enforce noninstantiability to MiniLangUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7744:
-
Attachment: OFBIZ-7744.patch
Here is the patch for the issue.
> Enforce noninstantiability to MiniLangUtil class
>
>
> Key: OFBIZ-7744
> URL: https://issues.apache.org/jira/browse/OFBIZ-7744
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
> Attachments: OFBIZ-7744.patch
>
>
> - Make below variable as private
> {code}
> public static final Set SCRIPT_PREFIXES;
> {code}
> - Moved constructor below the variable declaration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7744) Enforce noninstantiability to MiniLangUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7744:
Assignee: Rohit Koushal
> Enforce noninstantiability to MiniLangUtil class
>
>
> Key: OFBIZ-7744
> URL: https://issues.apache.org/jira/browse/OFBIZ-7744
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>
> - Make below variable as private
> {code}
> public static final Set SCRIPT_PREFIXES;
> {code}
> - Moved constructor below the variable declaration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-7744) Enforce noninstantiability to MiniLangUtil class
Rohit Koushal created OFBIZ-7744:
Summary: Enforce noninstantiability to MiniLangUtil class
Key: OFBIZ-7744
URL: https://issues.apache.org/jira/browse/OFBIZ-7744
Project: OFBiz
Issue Type: Sub-task
Affects Versions: Trunk
Reporter: Rohit Koushal
- Make below variable as private
{code}
public static final Set SCRIPT_PREFIXES;
{code}
- Moved constructor below the variable declaration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7742) Enforce noninstantiability to EntityGroupUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7742: - Attachment: OFBIZ-7742.patch > Enforce noninstantiability to EntityGroupUtil class > --- > > Key: OFBIZ-7742 > URL: https://issues.apache.org/jira/browse/OFBIZ-7742 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7742.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7742) Enforce noninstantiability to EntityGroupUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7742: - Attachment: (was: OFBIZ-7742.patch) > Enforce noninstantiability to EntityGroupUtil class > --- > > Key: OFBIZ-7742 > URL: https://issues.apache.org/jira/browse/OFBIZ-7742 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7742) Enforce noninstantiability to EntityGroupUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7742: Assignee: Rohit Koushal (was: Arun Patidar) > Enforce noninstantiability to EntityGroupUtil class > --- > > Key: OFBIZ-7742 > URL: https://issues.apache.org/jira/browse/OFBIZ-7742 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7742.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7742) Enforce noninstantiability to EntityGroupUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7742: - Attachment: OFBIZ-7742.patch Thanks for the details [~arun.patidar]. Here is the patch for the issue. > Enforce noninstantiability to EntityGroupUtil class > --- > > Key: OFBIZ-7742 > URL: https://issues.apache.org/jira/browse/OFBIZ-7742 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7742.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7740) Enforce noninstantiability to EntityUtilProperties class
[
https://issues.apache.org/jira/browse/OFBIZ-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7740:
-
Attachment: OFBIZ-7740.patch
Thanks [~arun.patidar] for the details. Here is the patch for the issue.
> Enforce noninstantiability to EntityUtilProperties class
>
>
> Key: OFBIZ-7740
> URL: https://issues.apache.org/jira/browse/OFBIZ-7740
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7740.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected method as private
> {code}
> protected static Map getSystemPropertyValue(
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7740) Enforce noninstantiability to EntityUtilProperties class
[
https://issues.apache.org/jira/browse/OFBIZ-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7740:
Assignee: Rohit Koushal (was: Arun Patidar)
> Enforce noninstantiability to EntityUtilProperties class
>
>
> Key: OFBIZ-7740
> URL: https://issues.apache.org/jira/browse/OFBIZ-7740
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected method as private
> {code}
> protected static Map getSystemPropertyValue(
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7733) Enforce noninstantiability to EntityUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7733: - Attachment: OFBIZ-7733.patch > Enforce noninstantiability to EntityUtil class > -- > > Key: OFBIZ-7733 > URL: https://issues.apache.org/jira/browse/OFBIZ-7733 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7733.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7733) Enforce noninstantiability to EntityUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7733: - Attachment: (was: OFBIZ-7733.patch) > Enforce noninstantiability to EntityUtil class > -- > > Key: OFBIZ-7733 > URL: https://issues.apache.org/jira/browse/OFBIZ-7733 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7733.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7733) Enforce noninstantiability to EntityUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7733: - Attachment: OFBIZ-7733.patch Thanks [~arun.patidar] for the details. Here is the patch for the problem. > Enforce noninstantiability to EntityUtil class > -- > > Key: OFBIZ-7733 > URL: https://issues.apache.org/jira/browse/OFBIZ-7733 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7733.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7710) Enforce noninstantiability to EntityFinderUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7710: - Attachment: OFBIZ-7710.patch > Enforce noninstantiability to EntityFinderUtil class > > > Key: OFBIZ-7710 > URL: https://issues.apache.org/jira/browse/OFBIZ-7710 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7710.patch > > > - Make class as final. > - Add a private constructor. > - Many public static classes are defined, but all are in use outside of the > class. No changes required. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7710) Enforce noninstantiability to EntityFinderUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7710: - Attachment: (was: OFBIZ-7710.patch) > Enforce noninstantiability to EntityFinderUtil class > > > Key: OFBIZ-7710 > URL: https://issues.apache.org/jira/browse/OFBIZ-7710 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7710.patch > > > - Make class as final. > - Add a private constructor. > - Many public static classes are defined, but all are in use outside of the > class. No changes required. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7733) Enforce noninstantiability to EntityUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7733: Assignee: Rohit Koushal (was: Arun Patidar) > Enforce noninstantiability to EntityUtil class > -- > > Key: OFBIZ-7733 > URL: https://issues.apache.org/jira/browse/OFBIZ-7733 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7732) Enforce noninstantiability to ModelUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7732:
-
Attachment: OFBIZ-7732.patch
Thanks for the details [~arun.patidar]. Here is the patch for the issue.
> Enforce noninstantiability to ModelUtil class
> -
>
> Key: OFBIZ-7732
> URL: https://issues.apache.org/jira/browse/OFBIZ-7732
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7732.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private and final
> {code}
> public static String vowelBag = "aeiouyAEIOUY";
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7732) Enforce noninstantiability to ModelUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7732:
Assignee: Rohit Koushal (was: Arun Patidar)
> Enforce noninstantiability to ModelUtil class
> -
>
> Key: OFBIZ-7732
> URL: https://issues.apache.org/jira/browse/OFBIZ-7732
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private and final
> {code}
> public static String vowelBag = "aeiouyAEIOUY";
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7715) Enforce noninstantiability to SqlJdbcUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7715:
-
Attachment: OFBIZ-7715.patch
Thanks [~rishisolankii] for the details. Here is the patch for the issue.
> Enforce noninstantiability to SqlJdbcUtil class
> ---
>
> Key: OFBIZ-7715
> URL: https://issues.apache.org/jira/browse/OFBIZ-7715
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7715.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int CHAR_BUFFER_SIZE = 4096;
> {code}
> - Make the following protected variable as private and move it and static
> block to top of class.
> {code}
> protected static Map fieldTypeMap = new HashMap Integer>();
> static {
> fieldTypeMap.put("java.lang.String", 1);
> fieldTypeMap.put("String", 1);
> fieldTypeMap.put("java.sql.Timestamp", 2);
> fieldTypeMap.put("Timestamp", 2);
> fieldTypeMap.put("java.sql.Time", 3);
> fieldTypeMap.put("Time", 3);
> fieldTypeMap.put("java.sql.Date", 4);
> fieldTypeMap.put("Date", 4);
> fieldTypeMap.put("java.lang.Integer", 5);
> fieldTypeMap.put("Integer", 5);
> fieldTypeMap.put("java.lang.Long", 6);
> fieldTypeMap.put("Long", 6);
> fieldTypeMap.put("java.lang.Float", 7);
> fieldTypeMap.put("Float", 7);
> fieldTypeMap.put("java.lang.Double", 8);
> fieldTypeMap.put("Double", 8);
> fieldTypeMap.put("java.math.BigDecimal", 9);
> fieldTypeMap.put("BigDecimal", 9);
> fieldTypeMap.put("java.lang.Boolean", 10);
> fieldTypeMap.put("Boolean", 10);
> fieldTypeMap.put("java.lang.Object", 11);
> fieldTypeMap.put("Object", 11);
> fieldTypeMap.put("java.sql.Blob", 12);
> fieldTypeMap.put("Blob", 12);
> fieldTypeMap.put("byte[]", 12);
> fieldTypeMap.put("java.nio.ByteBuffer", 12);
> fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
> fieldTypeMap.put("java.sql.Clob", 13);
> fieldTypeMap.put("Clob", 13);
> fieldTypeMap.put("java.util.Date", 14);
> // all of these treated as Collection
> fieldTypeMap.put("java.util.ArrayList", 15);
> fieldTypeMap.put("java.util.HashSet", 15);
> fieldTypeMap.put("java.util.LinkedHashSet", 15);
> fieldTypeMap.put("java.util.LinkedList", 15);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7715) Enforce noninstantiability to SqlJdbcUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7715:
Assignee: Rohit Koushal
> Enforce noninstantiability to SqlJdbcUtil class
> ---
>
> Key: OFBIZ-7715
> URL: https://issues.apache.org/jira/browse/OFBIZ-7715
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int CHAR_BUFFER_SIZE = 4096;
> {code}
> - Make the following protected variable as private and move it and static
> block to top of class.
> {code}
> protected static Map fieldTypeMap = new HashMap Integer>();
> static {
> fieldTypeMap.put("java.lang.String", 1);
> fieldTypeMap.put("String", 1);
> fieldTypeMap.put("java.sql.Timestamp", 2);
> fieldTypeMap.put("Timestamp", 2);
> fieldTypeMap.put("java.sql.Time", 3);
> fieldTypeMap.put("Time", 3);
> fieldTypeMap.put("java.sql.Date", 4);
> fieldTypeMap.put("Date", 4);
> fieldTypeMap.put("java.lang.Integer", 5);
> fieldTypeMap.put("Integer", 5);
> fieldTypeMap.put("java.lang.Long", 6);
> fieldTypeMap.put("Long", 6);
> fieldTypeMap.put("java.lang.Float", 7);
> fieldTypeMap.put("Float", 7);
> fieldTypeMap.put("java.lang.Double", 8);
> fieldTypeMap.put("Double", 8);
> fieldTypeMap.put("java.math.BigDecimal", 9);
> fieldTypeMap.put("BigDecimal", 9);
> fieldTypeMap.put("java.lang.Boolean", 10);
> fieldTypeMap.put("Boolean", 10);
> fieldTypeMap.put("java.lang.Object", 11);
> fieldTypeMap.put("Object", 11);
> fieldTypeMap.put("java.sql.Blob", 12);
> fieldTypeMap.put("Blob", 12);
> fieldTypeMap.put("byte[]", 12);
> fieldTypeMap.put("java.nio.ByteBuffer", 12);
> fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
> fieldTypeMap.put("java.sql.Clob", 13);
> fieldTypeMap.put("Clob", 13);
> fieldTypeMap.put("java.util.Date", 14);
> // all of these treated as Collection
> fieldTypeMap.put("java.util.ArrayList", 15);
> fieldTypeMap.put("java.util.HashSet", 15);
> fieldTypeMap.put("java.util.LinkedHashSet", 15);
> fieldTypeMap.put("java.util.LinkedList", 15);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360090#comment-15360090 ] Rohit Koushal edited comment on OFBIZ-7515 at 7/2/16 1:09 PM: -- Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. !BalanceSheetScreenshot.jpg|thumbnail! Can you please check it again ? Thanks! was (Author: rohit.koushal): Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. !BalanceSheetScreenshot.png|thumbnail! Can you please check it again ? Thanks! > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: BalanceSheet.png, BalanceSheetScreenshot.jpg, > OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7515: - Attachment: BalanceSheetScreenshot.jpg > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: BalanceSheet.png, BalanceSheetScreenshot.jpg, > OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7515: - Attachment: (was: BalanceSheetScreenshot.png) > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: BalanceSheet.png, BalanceSheetScreenshot.jpg, > OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360090#comment-15360090 ] Rohit Koushal edited comment on OFBIZ-7515 at 7/2/16 1:07 PM: -- Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. !BalanceSheetScreenshot.png|thumbnail! Can you please check it again ? Thanks! was (Author: rohit.koushal): Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. !BalanceSheetScreenshot.png|small! Can you please check it again ? Thanks! > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: BalanceSheet.png, BalanceSheetScreenshot.png, > OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360090#comment-15360090 ] Rohit Koushal edited comment on OFBIZ-7515 at 7/2/16 1:06 PM: -- Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. !BalanceSheetScreenshot.png|small! Can you please check it again ? Thanks! was (Author: rohit.koushal): Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. !BalanceSheetScreenshot.png|thumbnail! Can you please check it again ? Thanks! > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: BalanceSheet.png, BalanceSheetScreenshot.png, > OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360090#comment-15360090 ] Rohit Koushal edited comment on OFBIZ-7515 at 7/2/16 9:46 AM: -- Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. !BalanceSheetScreenshot.png|thumbnail! Can you please check it again ? Thanks! was (Author: rohit.koushal): Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. Can you please check it again ? Thanks! > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: BalanceSheet.png, BalanceSheetScreenshot.png, > OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7515: - Attachment: BalanceSheetScreenshot.png Hi [~jacques.le.roux], It works for me on ofbiz-trunk. I followed the step mentioned under the description. Attaching the screenshot for your reference. Can you please check it again ? Thanks! > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Arun Patidar > Fix For: Trunk, 14.12.01, 15.12.01 > > Attachments: BalanceSheet.png, BalanceSheetScreenshot.png, > OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6639) Birt issues in accounting reports
[
https://issues.apache.org/jira/browse/OFBIZ-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360074#comment-15360074
]
Rohit Koushal commented on OFBIZ-6639:
--
Thanks [~jacques.le.roux], I will check it once again.
> Birt issues in accounting reports
> -
>
> Key: OFBIZ-6639
> URL: https://issues.apache.org/jira/browse/OFBIZ-6639
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, specialpurpose/birt
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Jacques Le Roux
>Assignee: Arun Patidar
> Fix For: Trunk, 14.12.01, 15.12.01
>
>
> The followings are Birt issues
> https://ofbiz-vm.apache.org:8443/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
> https://ofbiz-vm.apache.org:8443/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> https://ofbiz-vm.apache.org:8443/accounting/control/TrialBalance?organizationPartyId=Company
> (PDF export)
> They work in stable demo, there is no Birt there
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> Here is Arun's comment about that
> {quote}
> There are some report forms with hyper-link that are throwing error in pdf
> export. We will have to find a way to use these form in both process ie
> report rendering and pdf export
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7690) Enforce noninstantiability to PreferenceWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7690:
-
Attachment: OFBIZ-7690.patch
Thanks [~rishisolankii] for the details. Here is the patch for the issue.
> Enforce noninstantiability to PreferenceWorker class
>
>
> Key: OFBIZ-7690
> URL: https://issues.apache.org/jira/browse/OFBIZ-7690
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7690.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static final variables as private
> {code}
> public static final String ADMIN_PERMISSION = "USERPREF_ADMIN";
> public static final String LOGINID_PARAMETER_NAME = "userPrefLoginId";
> public static final String DEFAULT_UID = "_NA_";
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7690) Enforce noninstantiability to PreferenceWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7690:
Assignee: Rohit Koushal
> Enforce noninstantiability to PreferenceWorker class
>
>
> Key: OFBIZ-7690
> URL: https://issues.apache.org/jira/browse/OFBIZ-7690
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static final variables as private
> {code}
> public static final String ADMIN_PERMISSION = "USERPREF_ADMIN";
> public static final String LOGINID_PARAMETER_NAME = "userPrefLoginId";
> public static final String DEFAULT_UID = "_NA_";
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7710) Enforce noninstantiability to EntityFinderUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7710: - Attachment: OFBIZ-7710.patch Thanks [~rishisolankii] for the details. Here is the patch for the issue. > Enforce noninstantiability to EntityFinderUtil class > > > Key: OFBIZ-7710 > URL: https://issues.apache.org/jira/browse/OFBIZ-7710 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7710.patch > > > - Make class as final. > - Add a private constructor. > - Many public static classes are defined, but all are in use outside of the > class. No changes required. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7551:
-
Attachment: (was: OFBIZ-7551.patch)
> Enforce noninstantiability to SSLUtil class
> ---
>
> Key: OFBIZ-7551
> URL: https://issues.apache.org/jira/browse/OFBIZ-7551
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7551.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int HOSTCERT_NO_CHECK = 0;
> public static final int HOSTCERT_MIN_CHECK = 1;
> public static final int HOSTCERT_NORMAL_CHECK = 2;
> {code}
> - Add getHostCertNoCheck(), getHostCertMinCheck() and
> getHostCertNormalCheck() public static methods and use them in following
> classes, Also check if any class remains;
> {code}
> HttpClient.java
> URLConnector.java
> AliasSupportedTransportFactory.java
> WidgetMacroLibraryTests.java
> OagisServices.java
> {code}
> - Move following static class at top and make it private.
> {code}
> static class TrustAnyManager implements X509TrustManager
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7551:
-
Attachment: OFBIZ-7551.patch
> Enforce noninstantiability to SSLUtil class
> ---
>
> Key: OFBIZ-7551
> URL: https://issues.apache.org/jira/browse/OFBIZ-7551
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7551.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int HOSTCERT_NO_CHECK = 0;
> public static final int HOSTCERT_MIN_CHECK = 1;
> public static final int HOSTCERT_NORMAL_CHECK = 2;
> {code}
> - Add getHostCertNoCheck(), getHostCertMinCheck() and
> getHostCertNormalCheck() public static methods and use them in following
> classes, Also check if any class remains;
> {code}
> HttpClient.java
> URLConnector.java
> AliasSupportedTransportFactory.java
> WidgetMacroLibraryTests.java
> OagisServices.java
> {code}
> - Move following static class at top and make it private.
> {code}
> static class TrustAnyManager implements X509TrustManager
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7710) Enforce noninstantiability to EntityFinderUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7710: Assignee: Rohit Koushal (was: Arun Patidar) > Enforce noninstantiability to EntityFinderUtil class > > > Key: OFBIZ-7710 > URL: https://issues.apache.org/jira/browse/OFBIZ-7710 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > - Many public static classes are defined, but all are in use outside of the > class. No changes required. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7710) Enforce noninstantiability to EntityFinderUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7710: Assignee: Rohit Koushal > Enforce noninstantiability to EntityFinderUtil class > > > Key: OFBIZ-7710 > URL: https://issues.apache.org/jira/browse/OFBIZ-7710 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > - Many public static classes are defined, but all are in use outside of the > class. No changes required. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7315) Order Discount Code Report is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7315: - Affects Version/s: Release Branch 14.12 Trunk Release Branch 15.12 > Order Discount Code Report is not working > - > > Key: OFBIZ-7315 > URL: https://issues.apache.org/jira/browse/OFBIZ-7315 > Project: OFBiz > Issue Type: Sub-task > Components: order, specialpurpose/birt >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: OrderDiscountCodeReport.patch > > > Order Discount Code Report is not working > Screen : > https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions > Section : Order Discount Code Report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7648) Page bottom navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7648: - Description: This ticket is in reference of issue OFBIZ-7020. In the fix we need to manually specify the "NO_PAGINATOR" in golbalContext to stop inner grid pagination. Under this ticket we looking for a framework level fix. (was: This ticket is in reference of issue [OFBIZ-7020|https://issues.apache.org/jira/browse/OFBIZ-7020]. In the fix we need to manually specify the "NO_PAGINATOR" in golbalContext to stop inner grid pagination. Under this ticket we looking for a framework level fix.) > Page bottom navigation problem with grid and include-grid > - > > Key: OFBIZ-7648 > URL: https://issues.apache.org/jira/browse/OFBIZ-7648 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: OFBIZ-7648.patch > > > This ticket is in reference of issue OFBIZ-7020. In the fix we need to > manually specify the "NO_PAGINATOR" in golbalContext to stop inner grid > pagination. Under this ticket we looking for a framework level fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7648) Page bottom navigation problem with grid and include-grid
[ https://issues.apache.org/jira/browse/OFBIZ-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7648: - Attachment: OFBIZ-7648.patch This patch will fix the problem in pagination when grid is used under another grid. > Page bottom navigation problem with grid and include-grid > - > > Key: OFBIZ-7648 > URL: https://issues.apache.org/jira/browse/OFBIZ-7648 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: OFBIZ-7648.patch > > > This ticket is in reference of issue > [OFBIZ-7020|https://issues.apache.org/jira/browse/OFBIZ-7020]. In the fix we > need to manually specify the "NO_PAGINATOR" in golbalContext to stop inner > grid pagination. Under this ticket we looking for a framework level fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7648) Page bottom navigation problem with grid and include-grid
Rohit Koushal created OFBIZ-7648: Summary: Page bottom navigation problem with grid and include-grid Key: OFBIZ-7648 URL: https://issues.apache.org/jira/browse/OFBIZ-7648 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Rohit Koushal Assignee: Rohit Koushal This ticket is in reference of issue [OFBIZ-7020|https://issues.apache.org/jira/browse/OFBIZ-7020]. In the fix we need to manually specify the "NO_PAGINATOR" in golbalContext to stop inner grid pagination. Under this ticket we looking for a framework level fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7591) Enforce noninstantiability to UtilJavaParse class
[
https://issues.apache.org/jira/browse/OFBIZ-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7591:
-
Attachment: OFBIZ-7591.patch
Thanks [~rishisolankii] for the details. Here is the patch for the issue.
> Enforce noninstantiability to UtilJavaParse class
> -
>
> Key: OFBIZ-7591
> URL: https://issues.apache.org/jira/browse/OFBIZ-7591
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7591.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private and move them to top
> of class. Also move the static block initializing it.
> {code}
> // FIXME: Not thread safe
> public static Set serviceMethodNames = new HashSet();
> static {
> serviceMethodNames.add("runSync");
> serviceMethodNames.add("runSyncIgnore");
> serviceMethodNames.add("runAsync");
> serviceMethodNames.add("runAsyncWait");
> serviceMethodNames.add("registerCallback");
> serviceMethodNames.add("schedule"); // NOTE: the service name may be
> the 1st, 2nd or 3rd param for variations on this
> serviceMethodNames.add("addRollbackService");
> serviceMethodNames.add("addCommitService");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7591) Enforce noninstantiability to UtilJavaParse class
[
https://issues.apache.org/jira/browse/OFBIZ-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7591:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilJavaParse class
> -
>
> Key: OFBIZ-7591
> URL: https://issues.apache.org/jira/browse/OFBIZ-7591
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private and move them to top
> of class. Also move the static block initializing it.
> {code}
> // FIXME: Not thread safe
> public static Set serviceMethodNames = new HashSet();
> static {
> serviceMethodNames.add("runSync");
> serviceMethodNames.add("runSyncIgnore");
> serviceMethodNames.add("runAsync");
> serviceMethodNames.add("runAsyncWait");
> serviceMethodNames.add("registerCallback");
> serviceMethodNames.add("schedule"); // NOTE: the service name may be
> the 1st, 2nd or 3rd param for variations on this
> serviceMethodNames.add("addRollbackService");
> serviceMethodNames.add("addCommitService");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7601) Enforce noninstantiability to UtilURL class
[ https://issues.apache.org/jira/browse/OFBIZ-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7601: - Attachment: OFBIZ-7601.patch Thanks [~rishisolankii] for the details. Here is the patch for the issue. > Enforce noninstantiability to UtilURL class > --- > > Key: OFBIZ-7601 > URL: https://issues.apache.org/jira/browse/OFBIZ-7601 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7601.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7601) Enforce noninstantiability to UtilURL class
[ https://issues.apache.org/jira/browse/OFBIZ-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7601: Assignee: Rohit Koushal > Enforce noninstantiability to UtilURL class > --- > > Key: OFBIZ-7601 > URL: https://issues.apache.org/jira/browse/OFBIZ-7601 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7590) Enforce noninstantiability to UtilIO class
[ https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7590: - Attachment: OFBIZ-7590.patch > Enforce noninstantiability to UtilIO class > -- > > Key: OFBIZ-7590 > URL: https://issues.apache.org/jira/browse/OFBIZ-7590 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7590.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7590) Enforce noninstantiability to UtilIO class
[ https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7590: - Attachment: (was: OFBIZ-7590.patch) > Enforce noninstantiability to UtilIO class > -- > > Key: OFBIZ-7590 > URL: https://issues.apache.org/jira/browse/OFBIZ-7590 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7590.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7590) Enforce noninstantiability to UtilIO class
[
https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7590:
-
Attachment: OFBIZ-7590.patch
1. Class is already final.
2. Making below public variable as private
{code}
public static final Charset UTF8 = Charset.forName("UTF-8");
{code}
3. Wrote a getter method getUtf8() and replace its occurrences in file
{code}
UtilIOTests.java
{code}
Thanks [~rishisolankii] for the details.
> Enforce noninstantiability to UtilIO class
> --
>
> Key: OFBIZ-7590
> URL: https://issues.apache.org/jira/browse/OFBIZ-7590
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7590.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7589:
-
Attachment: (was: OFBIZ-7589.patch)
> Enforce noninstantiability to UtilHttp class
>
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7589.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH =
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH =
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH =
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(),
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7589:
-
Attachment: OFBIZ-7589.patch
> Enforce noninstantiability to UtilHttp class
>
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7589.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH =
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH =
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH =
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(),
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7590) Enforce noninstantiability to UtilIO class
[ https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7590: Assignee: Rohit Koushal > Enforce noninstantiability to UtilIO class > -- > > Key: OFBIZ-7590 > URL: https://issues.apache.org/jira/browse/OFBIZ-7590 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7589:
-
Attachment: OFBIZ-7589.patch
Thanks [~rishisolankii] for the details. Here is the patch for the ticket
> Enforce noninstantiability to UtilHttp class
>
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7589.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH =
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH =
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH =
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(),
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7589) Enforce noninstantiability to UtilHttp class
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7589:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilHttp class
>
>
> Key: OFBIZ-7589
> URL: https://issues.apache.org/jira/browse/OFBIZ-7589
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String MULTI_ROW_DELIMITER = "_o_";
> public static final String ROW_SUBMIT_PREFIX = "_rowSubmit_o_";
> public static final String COMPOSITE_DELIMITER = "_c_";
> public static final int MULTI_ROW_DELIMITER_LENGTH =
> MULTI_ROW_DELIMITER.length();
> public static final int ROW_SUBMIT_PREFIX_LENGTH =
> ROW_SUBMIT_PREFIX.length();
> public static final int COMPOSITE_DELIMITER_LENGTH =
> COMPOSITE_DELIMITER.length();
> public static final String SESSION_KEY_TIMEZONE = "timeZone";
> {code}
> - Add public static methods as getMultiRowDelimiter(), getRowSubmitPrefix(),
> and use them in following classes/scripts;
> {code}
> GlEvents.java
> ShoppingCartEvents.java
> CheckAction.groovy
> CheckRejected.groovy
> ServiceMultiEventHandler.java
> EbayEvents.java
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7587) Enforce noninstantiability to UtilFormatOut class
[
https://issues.apache.org/jira/browse/OFBIZ-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7587:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilFormatOut class
> -
>
> Key: OFBIZ-7587
> URL: https://issues.apache.org/jira/browse/OFBIZ-7587
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as private static final. Also move it to
> begining of the class with FIXME: comment
> {code}
> // --- price format handlers ---
> // FIXME: This is not thread-safe! DecimalFormat is not synchronized.
> static DecimalFormat priceDecimalFormat = new
> DecimalFormat(UtilProperties.getPropertyValue("general",
> "currency.decimal.format", "#,##0.00"));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7588) Enforce noninstantiability to UtilGenerics class
[ https://issues.apache.org/jira/browse/OFBIZ-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7588: - Attachment: OFBIZ-7588.patch Thanks [~rishisolankii] for the details. Here is the patch for the issue. > Enforce noninstantiability to UtilGenerics class > > > Key: OFBIZ-7588 > URL: https://issues.apache.org/jira/browse/OFBIZ-7588 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7588.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7588) Enforce noninstantiability to UtilGenerics class
[ https://issues.apache.org/jira/browse/OFBIZ-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7588: Assignee: Rohit Koushal > Enforce noninstantiability to UtilGenerics class > > > Key: OFBIZ-7588 > URL: https://issues.apache.org/jira/browse/OFBIZ-7588 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7540) Enforce noninstantiability to FileUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7540:
Assignee: Rohit Koushal
> Enforce noninstantiability to FileUtil class
>
>
> Key: OFBIZ-7540
> URL: https://issues.apache.org/jira/browse/OFBIZ-7540
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7540.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following public static class as private and move it to the top of the
> class.
> {code}
> public static class SearchTextFilesFilter implements FilenameFilter
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7562) Enforce noninstantiability to UtilDateTime class
[
https://issues.apache.org/jira/browse/OFBIZ-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7562:
-
Attachment: OFBIZ-7562.patch
Thanks [~rishisolankii] for the details. Here is the patch for the ticket.
> Enforce noninstantiability to UtilDateTime class
>
>
> Key: OFBIZ-7562
> URL: https://issues.apache.org/jira/browse/OFBIZ-7562
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7562.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String[] months = {
> "January", "February", "March", "April", "May", "June",
> "July", "August", "September", "October", "November",
> "December"
> };
> public static final String[] days = {
> "Monday", "Tuesday", "Wednesday",
> "Thursday", "Friday", "Saturday", "Sunday"
> };
> public static final String[][] timevals = {
> {"1000", "millisecond"},
> {"60", "second"},
> {"60", "minute"},
> {"24", "hour"},
> {"168", "week"}
> };
> public static final DecimalFormat df = new DecimalFormat("0.00;-0.00");
> public static final String DATE_FORMAT = "-MM-dd";
> public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
> public static final String TIME_FORMAT = "HH:mm:ss";
> {code}
> - Add public static methods as getDateFormat(), getDateTimeFormat() and
> getTimeFormat() methods and use them in following classes;
> {code}
> DateTimeConverters.java
> UelFunctions.java
> CommonWidgetModels.java
> ModelFormField.java
> SetCalendar.java
> EbayStoreAutoPreferences.java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7562) Enforce noninstantiability to UtilDateTime class
[
https://issues.apache.org/jira/browse/OFBIZ-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7562:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilDateTime class
>
>
> Key: OFBIZ-7562
> URL: https://issues.apache.org/jira/browse/OFBIZ-7562
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String[] months = {
> "January", "February", "March", "April", "May", "June",
> "July", "August", "September", "October", "November",
> "December"
> };
> public static final String[] days = {
> "Monday", "Tuesday", "Wednesday",
> "Thursday", "Friday", "Saturday", "Sunday"
> };
> public static final String[][] timevals = {
> {"1000", "millisecond"},
> {"60", "second"},
> {"60", "minute"},
> {"24", "hour"},
> {"168", "week"}
> };
> public static final DecimalFormat df = new DecimalFormat("0.00;-0.00");
> public static final String DATE_FORMAT = "-MM-dd";
> public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
> public static final String TIME_FORMAT = "HH:mm:ss";
> {code}
> - Add public static methods as getDateFormat(), getDateTimeFormat() and
> getTimeFormat() methods and use them in following classes;
> {code}
> DateTimeConverters.java
> UelFunctions.java
> CommonWidgetModels.java
> ModelFormField.java
> SetCalendar.java
> EbayStoreAutoPreferences.java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7551:
-
Attachment: OFBIZ-7551.patch
Thanks [~rishisolankii] for the details. Here is the patch for the ticket.
> Enforce noninstantiability to SSLUtil class
> ---
>
> Key: OFBIZ-7551
> URL: https://issues.apache.org/jira/browse/OFBIZ-7551
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7551.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int HOSTCERT_NO_CHECK = 0;
> public static final int HOSTCERT_MIN_CHECK = 1;
> public static final int HOSTCERT_NORMAL_CHECK = 2;
> {code}
> - Add getHostCertNoCheck(), getHostCertMinCheck() and
> getHostCertNormalCheck() public static methods and use them in following
> classes, Also check if any class remains;
> {code}
> HttpClient.java
> URLConnector.java
> AliasSupportedTransportFactory.java
> WidgetMacroLibraryTests.java
> OagisServices.java
> {code}
> - Move following static class at top and make it private.
> {code}
> static class TrustAnyManager implements X509TrustManager
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7551:
Assignee: Rohit Koushal
> Enforce noninstantiability to SSLUtil class
> ---
>
> Key: OFBIZ-7551
> URL: https://issues.apache.org/jira/browse/OFBIZ-7551
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int HOSTCERT_NO_CHECK = 0;
> public static final int HOSTCERT_MIN_CHECK = 1;
> public static final int HOSTCERT_NORMAL_CHECK = 2;
> {code}
> - Add getHostCertNoCheck(), getHostCertMinCheck() and
> getHostCertNormalCheck() public static methods and use them in following
> classes, Also check if any class remains;
> {code}
> HttpClient.java
> URLConnector.java
> AliasSupportedTransportFactory.java
> WidgetMacroLibraryTests.java
> OagisServices.java
> {code}
> - Move following static class at top and make it private.
> {code}
> static class TrustAnyManager implements X509TrustManager
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7540) Enforce noninstantiability to FileUtil class
[
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7540:
-
Attachment: OFBIZ-7540.patch
Thanks [~rishisolankii] for the details. Here is the patch for the ticket.
> Enforce noninstantiability to FileUtil class
>
>
> Key: OFBIZ-7540
> URL: https://issues.apache.org/jira/browse/OFBIZ-7540
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7540.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following public static class as private and move it to the top of the
> class.
> {code}
> public static class SearchTextFilesFilter implements FilenameFilter
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6639) Birt issues in accounting reports
[
https://issues.apache.org/jira/browse/OFBIZ-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341155#comment-15341155
]
Rohit Koushal edited comment on OFBIZ-6639 at 6/21/16 6:03 AM:
---
The error is due to the browser problem. Some browser like Chrome and Chromium
fire 2 request for PDF download in which one request contain the desired
parameter and another request does not contain any parameter. Hence in some
PDF document(*.rptdesign) some parameters are mandatory due to which BIRT
engine throw exception.
Here are some refrence link about it.
[Do most browsers make multiple HTTP Requests when displaying a PDF from within
the
browser|http://stackoverflow.com/questions/1817750/do-most-browsers-make-multiple-http-requests-when-displaying-a-pdf-from-within-t]
[Chrome sends two requests when downloading a
PDF|http://stackoverflow.com/questions/32725608/chrome-sends-two-requests-when-downloading-a-pdf-and-cancels-one-of-them]
[Why does chrome do 2 requests for a pdf
file|http://stackoverflow.com/questions/33419721/why-does-chrome-do-2-requests-for-a-pdf-file]
was (Author: rohit.koushal):
The error is due to the browser problem. Some browser like Chrome and Chromium
fire 2 request for PDF download in which one request contain the desired
parameter and another request does not contain any parameter. Hence in some
PDF document some parameters are mandatory due to which BIRT engine throw
exception.
Here are some refrence link about it.
[Do most browsers make multiple HTTP Requests when displaying a PDF from within
the
browser|http://stackoverflow.com/questions/1817750/do-most-browsers-make-multiple-http-requests-when-displaying-a-pdf-from-within-t]
[Chrome sends two requests when downloading a
PDF|http://stackoverflow.com/questions/32725608/chrome-sends-two-requests-when-downloading-a-pdf-and-cancels-one-of-them]
[Why does chrome do 2 requests for a pdf
file|http://stackoverflow.com/questions/33419721/why-does-chrome-do-2-requests-for-a-pdf-file]
> Birt issues in accounting reports
> -
>
> Key: OFBIZ-6639
> URL: https://issues.apache.org/jira/browse/OFBIZ-6639
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, specialpurpose/birt
>Reporter: Jacques Le Roux
>Assignee: Rohit Koushal
>
> The followings are Birt issues
> https://ofbiz-vm.apache.org:8443/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
> https://ofbiz-vm.apache.org:8443/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> https://ofbiz-vm.apache.org:8443/accounting/control/TrialBalance?organizationPartyId=Company
> (PDF export)
> They work in stable demo, there is no Birt there
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> Here is Arun's comment about that
> {quote}
> There are some report forms with hyper-link that are throwing error in pdf
> export. We will have to find a way to use these form in both process ie
> report rendering and pdf export
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6639) Birt issues in accounting reports
[
https://issues.apache.org/jira/browse/OFBIZ-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341155#comment-15341155
]
Rohit Koushal commented on OFBIZ-6639:
--
The error is due to the browser problem. Some browser like Chrome and Chromium
fire 2 request for PDF download in which one request contain the desired
parameter and another request does not contain any parameter. Hence in some
PDF document some parameters are mandatory due to which BIRT engine throw
exception.
Here are some refrence link about it.
[Do most browsers make multiple HTTP Requests when displaying a PDF from within
the
browser|http://stackoverflow.com/questions/1817750/do-most-browsers-make-multiple-http-requests-when-displaying-a-pdf-from-within-t]
[Chrome sends two requests when downloading a
PDF|http://stackoverflow.com/questions/32725608/chrome-sends-two-requests-when-downloading-a-pdf-and-cancels-one-of-them]
[Why does chrome do 2 requests for a pdf
file|http://stackoverflow.com/questions/33419721/why-does-chrome-do-2-requests-for-a-pdf-file]
> Birt issues in accounting reports
> -
>
> Key: OFBIZ-6639
> URL: https://issues.apache.org/jira/browse/OFBIZ-6639
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, specialpurpose/birt
>Reporter: Jacques Le Roux
>Assignee: Rohit Koushal
>
> The followings are Birt issues
> https://ofbiz-vm.apache.org:8443/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
> https://ofbiz-vm.apache.org:8443/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> https://ofbiz-vm.apache.org:8443/accounting/control/TrialBalance?organizationPartyId=Company
> (PDF export)
> They work in stable demo, there is no Birt there
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> Here is Arun's comment about that
> {quote}
> There are some report forms with hyper-link that are throwing error in pdf
> export. We will have to find a way to use these form in both process ie
> report rendering and pdf export
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-6638: - Attachment: OFBIZ-6638.patch This patch will fix the problem, but in the workflow I find out that TrialBalancce PDF export data only when we close the ["Time Periods"|https://ofbiz-vm.apache.org:8443/accounting/control/TimePeriods] which a weird behaviour. Expected behaviour is should be same like export CSV functionality. Let me know if its is desired behaviour. Thanks > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Rohit Koushal > Attachments: OFBIZ-6638.patch > > > # Get to > http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7514) Income Statement PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7514: - Attachment: OFBIZ-7514.patch This patch will fix the Income Statement PDF issue. > Income Statement PDF export fails > - > > Key: OFBIZ-7514 > URL: https://issues.apache.org/jira/browse/OFBIZ-7514 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: OFBIZ-7514.patch > > > Income Statement PDF exported with empty data. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Income Statement report. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7515: - Attachment: OFBIZ-7515.patch This patch will fix Balance sheet PDF export issue. > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: BalanceSheet.png, OFBIZ-7515.patch > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7514) Income Statement PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7514: - Description: Income Statement PDF exported with empty data. To replicate : 1. Go to Organization GL Settings in accounting. 2. Under Reports we will find Income Statement report. 3. Submit the form and try to export data in PDF. was: Income Statement PDF exported with no data. To replicate : 1. Go to Organization GL Settings in accounting. 2. Under Reports we will find Income Statement report. 3. Submit the form and try to export data in PDF. > Income Statement PDF export fails > - > > Key: OFBIZ-7514 > URL: https://issues.apache.org/jira/browse/OFBIZ-7514 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > > Income Statement PDF exported with empty data. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Income Statement report. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7515) Balance Sheet PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7515: - Attachment: BalanceSheet.png > Balance Sheet PDF export fails > -- > > Key: OFBIZ-7515 > URL: https://issues.apache.org/jira/browse/OFBIZ-7515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, specialpurpose/birt >Affects Versions: Trunk >Reporter: Rohit Koushal >Assignee: Rohit Koushal > Attachments: BalanceSheet.png > > > Balance Sheet PDF export fails getting error attached in the screenshot. > To replicate : > 1. Go to Organization GL Settings in accounting. > 2. Under Reports we will find Balance sheet. > 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7515) Balance Sheet PDF export fails
Rohit Koushal created OFBIZ-7515: Summary: Balance Sheet PDF export fails Key: OFBIZ-7515 URL: https://issues.apache.org/jira/browse/OFBIZ-7515 Project: OFBiz Issue Type: Sub-task Components: accounting, specialpurpose/birt Affects Versions: Trunk Reporter: Rohit Koushal Assignee: Rohit Koushal Balance Sheet PDF export fails getting error attached in the screenshot. To replicate : 1. Go to Organization GL Settings in accounting. 2. Under Reports we will find Balance sheet. 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7514) Income Statement PDF export fails
Rohit Koushal created OFBIZ-7514: Summary: Income Statement PDF export fails Key: OFBIZ-7514 URL: https://issues.apache.org/jira/browse/OFBIZ-7514 Project: OFBiz Issue Type: Sub-task Components: accounting, specialpurpose/birt Affects Versions: Trunk Reporter: Rohit Koushal Assignee: Rohit Koushal Income Statement PDF exported with no data. To replicate : 1. Go to Organization GL Settings in accounting. 2. Under Reports we will find Income Statement report. 3. Submit the form and try to export data in PDF. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7474) ServiceMcaUtil Class
[ https://issues.apache.org/jira/browse/OFBIZ-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7474: - Attachment: OFBIZ-7474.patch Thanks [~rishisolankii] and [~arunpati] for details. Here is the patch for the task. > ServiceMcaUtil Class > > > Key: OFBIZ-7474 > URL: https://issues.apache.org/jira/browse/OFBIZ-7474 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7474.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7474) ServiceMcaUtil Class
[ https://issues.apache.org/jira/browse/OFBIZ-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7474: Assignee: Rohit Koushal > ServiceMcaUtil Class > > > Key: OFBIZ-7474 > URL: https://issues.apache.org/jira/browse/OFBIZ-7474 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7459) ApacheFopWorker Class
[
https://issues.apache.org/jira/browse/OFBIZ-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7459:
-
Attachment: OFBIZ-7459.patch
Thanks [~arunpati] and [~rishisolankii] for the details. Here is the patch for
the issue
> ApacheFopWorker Class
> -
>
> Key: OFBIZ-7459
> URL: https://issues.apache.org/jira/browse/OFBIZ-7459
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7459.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected variable as private
> {code}
> protected static FopFactory fopFactory = null;
> {code}
> - Make the following public variable as private
> {code}
> public static final String tempFilePrefix =
> "org.ofbiz.webapp.view.ApacheFopWorker-";
> public static final int encryptionLengthBitsDefault = 128;
>
> public static final String encryptionLengthDefault =
> UtilProperties.getPropertyValue("fop", "fop.encryption-length.default",
> String.valueOf(encryptionLengthBitsDefault));
> public static final String userPasswordDefault =
> UtilProperties.getPropertyValue("fop", "fop.userPassword.default");
> public static final String ownerPasswordDefault =
> UtilProperties.getPropertyValue("fop", "fop.ownerPassword.default");
> public static final String allowPrintDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowPrint.default", "true");
> public static final String allowCopyContentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowCopyContent.default",
> "true");
> public static final String allowEditContentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowEditContent.default",
> "true");
> public static final String allowEditAnnotationsDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowEditAnnotations.default",
> "true");
> public static final String allowFillInFormsDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowFillInForms.default",
> "true");
> public static final String allowAccessContentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowAccessContent.default",
> "true");
> public static final String allowAssembleDocumentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowAssembleDocument.default",
> "true");
> public static final String allowPrintHqDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowPrintHq.default", "true");
> public static final String encryptMetadataDefault =
> UtilProperties.getPropertyValue("fop", "fop.encrypt-metadata.default",
> "true");
>
> public static final String fopPath =
> UtilProperties.getPropertyValue("fop", "fop.path",
> "/framework/webapp/config");
>
> public static final String fopFontBaseProperty =
> UtilProperties.getPropertyValue("fop", "fop.font.base.url",
> "/framework/webapp/config/");
> {code}
> - Make getter methods for all above converted private variables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7459) ApacheFopWorker Class
[
https://issues.apache.org/jira/browse/OFBIZ-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7459:
Assignee: Rohit Koushal
> ApacheFopWorker Class
> -
>
> Key: OFBIZ-7459
> URL: https://issues.apache.org/jira/browse/OFBIZ-7459
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected variable as private
> {code}
> protected static FopFactory fopFactory = null;
> {code}
> - Make the following public variable as private
> {code}
> public static final String tempFilePrefix =
> "org.ofbiz.webapp.view.ApacheFopWorker-";
> public static final int encryptionLengthBitsDefault = 128;
>
> public static final String encryptionLengthDefault =
> UtilProperties.getPropertyValue("fop", "fop.encryption-length.default",
> String.valueOf(encryptionLengthBitsDefault));
> public static final String userPasswordDefault =
> UtilProperties.getPropertyValue("fop", "fop.userPassword.default");
> public static final String ownerPasswordDefault =
> UtilProperties.getPropertyValue("fop", "fop.ownerPassword.default");
> public static final String allowPrintDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowPrint.default", "true");
> public static final String allowCopyContentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowCopyContent.default",
> "true");
> public static final String allowEditContentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowEditContent.default",
> "true");
> public static final String allowEditAnnotationsDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowEditAnnotations.default",
> "true");
> public static final String allowFillInFormsDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowFillInForms.default",
> "true");
> public static final String allowAccessContentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowAccessContent.default",
> "true");
> public static final String allowAssembleDocumentDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowAssembleDocument.default",
> "true");
> public static final String allowPrintHqDefault =
> UtilProperties.getPropertyValue("fop", "fop.allowPrintHq.default", "true");
> public static final String encryptMetadataDefault =
> UtilProperties.getPropertyValue("fop", "fop.encrypt-metadata.default",
> "true");
>
> public static final String fopPath =
> UtilProperties.getPropertyValue("fop", "fop.path",
> "/framework/webapp/config");
>
> public static final String fopFontBaseProperty =
> UtilProperties.getPropertyValue("fop", "fop.font.base.url",
> "/framework/webapp/config/");
> {code}
> - Make getter methods for all above converted private variables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7453) WebDavUtil Class
[
https://issues.apache.org/jira/browse/OFBIZ-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7453:
Assignee: Rohit Koushal
> WebDavUtil Class
>
>
> Key: OFBIZ-7453
> URL: https://issues.apache.org/jira/browse/OFBIZ-7453
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7453.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
> public static final String RFC1123_DATE_FORMAT = "EEE, dd MMM
> HH:mm:ss zzz";
> {code}
> - Add getRFC1123DateFormat() and replace use of
> WebDavUtil.RFC1123_DATE_FORMAT from class 'ICalWorker'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7453) WebDavUtil Class
[
https://issues.apache.org/jira/browse/OFBIZ-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7453:
-
Attachment: OFBIZ-7453.patch
Thanks [~arunpati] and [~rishisolankii] for the details. Here is the patch for
issue.
> WebDavUtil Class
>
>
> Key: OFBIZ-7453
> URL: https://issues.apache.org/jira/browse/OFBIZ-7453
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7453.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
> public static final String RFC1123_DATE_FORMAT = "EEE, dd MMM
> HH:mm:ss zzz";
> {code}
> - Add getRFC1123DateFormat() and replace use of
> WebDavUtil.RFC1123_DATE_FORMAT from class 'ICalWorker'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7453) WebDavUtil Class
[
https://issues.apache.org/jira/browse/OFBIZ-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7453:
-
Description:
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
public static final String RFC1123_DATE_FORMAT = "EEE, dd MMM HH:mm:ss
zzz";
{code}
- Add getRFC1123DateFormat() and replace use of WebDavUtil.RFC1123_DATE_FORMAT
from class 'ICalWorker'
was:
- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
public static final String RFC1123_DATE_FORMAT = "EEE, dd MMM HH:mm:ss
zzz";
{code}
- Add getRFC1123DateFormate() and replace use of WebDavUtil.RFC1123_DATE_FORMAT
from class 'ICalWorker'
> WebDavUtil Class
>
>
> Key: OFBIZ-7453
> URL: https://issues.apache.org/jira/browse/OFBIZ-7453
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Arun Patidar
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
> public static final String RFC1123_DATE_FORMAT = "EEE, dd MMM
> HH:mm:ss zzz";
> {code}
> - Add getRFC1123DateFormat() and replace use of
> WebDavUtil.RFC1123_DATE_FORMAT from class 'ICalWorker'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7446) WebSiteWorker Class
[ https://issues.apache.org/jira/browse/OFBIZ-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7446: - Attachment: OFBIZ-7446.patch Thanks [~arunpati] and [~rishisolankii] for the details. Here is the patch for the issue > WebSiteWorker Class > --- > > Key: OFBIZ-7446 > URL: https://issues.apache.org/jira/browse/OFBIZ-7446 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7446.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7446) WebSiteWorker Class
[ https://issues.apache.org/jira/browse/OFBIZ-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-7446: Assignee: Rohit Koushal > WebSiteWorker Class > --- > > Key: OFBIZ-7446 > URL: https://issues.apache.org/jira/browse/OFBIZ-7446 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Arun Patidar >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7422) WidgetDataResourceWorker Class
[
https://issues.apache.org/jira/browse/OFBIZ-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7422:
-
Attachment: OFBIZ-7422.patch
Thanks [~rishisolankii] and [~arunpati] for the details. Here is the patch for
the issue.
> WidgetDataResourceWorker Class
> --
>
> Key: OFBIZ-7422
> URL: https://issues.apache.org/jira/browse/OFBIZ-7422
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7422.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static DataResourceWorkerInterface dataresourceWorker = null;
> {code}
> - Add a getDataresourceWorker() method and replace use of
> DataResourceWorkerInterface.dataresourceWorker from classes
> 'HtmlScreenRenderer' and 'MacroScreenRenderer'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7422) WidgetDataResourceWorker Class
[
https://issues.apache.org/jira/browse/OFBIZ-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7422:
Assignee: Rohit Koushal
> WidgetDataResourceWorker Class
> --
>
> Key: OFBIZ-7422
> URL: https://issues.apache.org/jira/browse/OFBIZ-7422
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static DataResourceWorkerInterface dataresourceWorker = null;
> {code}
> - Add a getDataresourceWorker() method and replace use of
> DataResourceWorkerInterface.dataresourceWorker from classes
> 'HtmlScreenRenderer' and 'MacroScreenRenderer'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7412) UtilHelpText Class
[ https://issues.apache.org/jira/browse/OFBIZ-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7412: - Summary: UtilHelpText Class (was: UtilHelpText.txt) > UtilHelpText Class > -- > > Key: OFBIZ-7412 > URL: https://issues.apache.org/jira/browse/OFBIZ-7412 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7412.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7408) ProductDisplayWorker class
[
https://issues.apache.org/jira/browse/OFBIZ-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7408:
-
Attachment: OFBIZ-7408.patch
Thanks [~rishisolankii] and [~arunpati] for the help and guidance. Adding patch
for this issue.
> ProductDisplayWorker class
> --
>
> Key: OFBIZ-7408
> URL: https://issues.apache.org/jira/browse/OFBIZ-7408
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
> Attachments: OFBIZ-7408.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static class as private
> {code}
> static class ProductByMapComparator implements Comparator
> {code}
> No variables needs to be change for this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7391) OpenOfficeWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7391: - Attachment: OFBIZ-7391.patch > OpenOfficeWorker class > -- > > Key: OFBIZ-7391 > URL: https://issues.apache.org/jira/browse/OFBIZ-7391 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7391.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7391) OpenOfficeWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7391: - Attachment: (was: OFBIZ-7383.patch) > OpenOfficeWorker class > -- > > Key: OFBIZ-7391 > URL: https://issues.apache.org/jira/browse/OFBIZ-7391 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7391) OpenOfficeWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-7391: - Attachment: (was: OFBIZ-7383.patch) > OpenOfficeWorker class > -- > > Key: OFBIZ-7391 > URL: https://issues.apache.org/jira/browse/OFBIZ-7391 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-7383.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
