Re: [GitHub] [ofbiz-framework] mbrohl commented on pull request #496: Improved: List and Grid (OFBIZ-11345)

2022-02-07 Thread Pierre Smits
You don't get the point, Michael.

You DON'T get to dictate what is being contributed to the project for the
public good.

Should not be so hard to understand for a member of a project's PMC and the
ASF.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz  since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory , PMC Member*

Anyone could have been you, whereas I've always been anyone.


On Mon, Feb 7, 2022 at 5:05 PM Michael Brohl 
wrote:

> You don't get the point, Pierre.
>
> You are actively REMOVING elements others have contributed and put
> effort in.
>
> Shouldn't be too hard to understand.
>
> Michael
>
>
> Am 07.02.22 um 16:52 schrieb Pierre Smits:
> > *Re: Other contributors have taken their time to structure the code into
> > readable blocks and comment them.*
> > Other contributors have taken their time to provide clean code without
> [...]
> >
>


Re: [GitHub] [ofbiz-framework] mbrohl commented on pull request #496: Improved: List and Grid (OFBIZ-11345)

2022-02-07 Thread Michael Brohl

You don't get the point, Pierre.

You are actively REMOVING elements others have contributed and put 
effort in.


Shouldn't be too hard to understand.

Michael


Am 07.02.22 um 16:52 schrieb Pierre Smits:

*Re: Other contributors have taken their time to structure the code into
readable blocks and comment them.*
Other contributors have taken their time to provide clean code without

[...]




Re: [GitHub] [ofbiz-framework] mbrohl commented on pull request #496: Improved: List and Grid (OFBIZ-11345)

2022-02-07 Thread Pierre Smits
*Re: Other contributors have taken their time to structure the code into
readable blocks and comment them.*
Other contributors have taken their time to provide clean code without
caring for readable blocks or commenting those, and their contributions
also went into the codebase.
Other contributors have collaborated to get to cleaner (code) files, and
the result of these collaborations also went into the codebase.

*Re: If you want the functional changes go in, either stop removing those
elements or, if that's the problem, learn how to configure your XML Editor
to leave blank lines and comments as-is*
Again? Extortion of compliance to* "your"* rules? Trying that 'approach'
again?
You, again, try to dictate what can be contributed, when, how and by whom.
I will not comport with your dictatorship.

Stop being an embarrassment to the project and the ASF. These actions of
yours result in nothing more than a hostile environment that chases
(potential) contributors away and hurts collaboration between contributors.

Re:
https://github.com/apache/ofbiz-framework/pull/496#issuecomment-1031457572
The changes committed in this pull request are in line with guidelines and
best practices established over the course of the project under the wings
of the ASF, which were applied on merged pull request as recent as 7 days
ago.

 If you want the guidelines changed, you are welcome to start a discussion
in dev@.

 You can **NOT** unilaterally decide what will and will not be merged by
other volunteers. That is **dictatorship**!

Pierre Smits
*Proud* *contributor** of* Apache OFBiz  since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory , PMC Member*

Anyone could have been you, whereas I've always been anyone.


On Mon, Feb 7, 2022 at 4:05 PM GitBox  wrote:

>
> mbrohl commented on pull request #496:
> URL:
> https://github.com/apache/ofbiz-framework/pull/496#issuecomment-1031566131
>
>
>Other contributors have taken their time to structure the code into
> readable blocks and comment them.
>You are removing this work and make the code look worse than before at
> those locations, therefore it cannot be accepted.
>
>If you want the functional changes go in, either stop removing those
> elements or, if that's the problem, learn how to configure your XML Editor
> to leave blank lines and comments as-is.
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
>