[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347109#comment-15347109 ] Peter Arnold edited comment on OFBIZ-6576 at 6/23/16 8:52 PM: -- Dear Ankush and Divesh; thank you for the suggestions and the patch. I think your solution is correct since the variant should inherit information from its corresponding virtual product, if not specified directly on the variant. I have tested the patch and it works fine up to the "Final Check-Out Review" where still some strange values are indicateed: Formating unfortunately is messed up Order Items Product Qty Ordered Unit Price Adjustments Subtotal DA-DA163 - DecoArt Americana Honey Brown 2Oz 1CLP1,690 CLP0 CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not added to totals) CLP0 Subtotal CLP3,380 Shipping and Handling CLP0 Sales Tax CLP0 Grand Total CLP3,380 The first Product has the price inherited from its corresponding Virtual product. The second product has the price defined directly in the variant. Difference is that for the product which inherits price information from its virtual product still a Sales Tax is calculated which is rather confusing, even though it is not added to the Grand Total amount which is fine. This screen still needs further improvement. I will investigate this problem but it will take me some time. was (Author: peter arnold): Dear Ankush and Divesh; thank you for the suggestions and the patch. I think your solution is correct since the variant should inherit information from its corresponding virtual product, if not specified directly on the variant. I have tested the patch and it works fine up to the "Final Check-Out Review" where still some strange values are indicateed: Decrease zoom in order to see proper format. Order Items Product Qty Ordered Unit Price Adjustments Subtotal DA-DA163 - DecoArt Americana Honey Brown 2Oz 1CLP1,690 CLP0 CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not added to totals) CLP0 Subtotal CLP3,380 Shipping and Handling CLP0 Sales Tax CLP0 Grand Total CLP3,380 The first Product has the price inherited from its corresponding Virtual product. The second product has the price defined directly in the variant. Difference is that for the product which inherits price information from its virtual product still a Sales Tax is calculated which is rather confusing, even though it is not added to the Grand Total amount which is fine. This screen still needs further improvement. I will investigate this problem but it will take me some time. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop
[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343832#comment-15343832 ] Divesh Dutta edited comment on OFBIZ-6576 at 6/22/16 8:53 AM: -- Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are same , they are both taxes levied by tax authority on a sale. I guess we can remove the if and else statements in code for SALES_TAX or VAT_TAX. Also I think Sales tax can also be put on Purchase order, when you want to put approximate tax which supplier will take from you. So I think VAT and Sales tax does not differ . was (Author: diveshdut): Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are same , they are both taxes levied by tax authority on a sale. I guess we can remove the if and else statements in code for SALES_TAX or VAT_TAX. Also I think Sales tax also be put on Purchase order, when you want to put approximate tax which supplier will take from you. So I think VAT and Sales tax does not differ . > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue:
[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342285#comment-15342285
]
Jacques Le Roux edited comment on OFBIZ-6576 at 6/22/16 8:47 AM:
-
Issue is caused by the code further below in TaxAuthorityServices.java:
_
Since for a variant product the "productPrice" and "taxInPrice" is set only on
the corresponding virtual product, the Else part of below code becomes active
and does the following:
{code}
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
{code}
Therewith Sales tax is added later on to the Variant Product.
By temporary replacing in above mentioned code line "SALES_TAX" by "VAT_TAX"
the issue seems to be resolved.
However this can only be a temporary fix.
{code}
GenericValue taxAdjValue = delegator.makeValue("OrderAdjustment");
if (productPrice != null &&
"Y".equals(productPrice.getString("taxInPrice"))) {
// tax is in the price already, so we want the adjustment
to be a VAT_TAX adjustment to be subtracted instead of a SALES_TAX adjustment
to be added
taxAdjValue.set("orderAdjustmentTypeId", "VAT_TAX");
// the amount will be different because we want to figure
out how much of the price was tax, and not how much tax needs to be added
// the formula is: taxAmount = priceWithTax -
(priceWithTax/(1+taxPercentage/100))
BigDecimal taxAmountIncluded =
itemAmount.subtract(itemAmount.divide(BigDecimal.ONE.add(taxRate.divide(PERCENT_SCALE,
4, BigDecimal.ROUND_HALF_UP)), 3, BigDecimal.ROUND_HALF_UP));
taxAdjValue.set("amountAlreadyIncluded", taxAmountIncluded);
taxAdjValue.set("amount", BigDecimal.ZERO);
} else {
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
taxAdjValue.set("amount", taxAmount);
}
{code}
was (Author: peter arnold):
Issue is caused by the code further below in TaxAuthorityServices.java:
_
Since for a variant product the "productPrice" and "taxInPrice" is set only on
the corresponding virtual product, the Else part of below code becomes active
and does the following:
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
Therewith Sales tax is added later on to the Variant Product.
By temporary replacing in above mentioned code line "SALES_TAX" by "VAT_TAX"
the issue seems to be resolved.
However this can only be a temporary fix.
___
Code:
___
GenericValue taxAdjValue = delegator.makeValue("OrderAdjustment");
if (productPrice != null &&
"Y".equals(productPrice.getString("taxInPrice"))) {
// tax is in the price already, so we want the adjustment
to be a VAT_TAX adjustment to be subtracted instead of a SALES_TAX adjustment
to be added
taxAdjValue.set("orderAdjustmentTypeId", "VAT_TAX");
// the amount will be different because we want to figure
out how much of the price was tax, and not how much tax needs to be added
// the formula is: taxAmount = priceWithTax -
(priceWithTax/(1+taxPercentage/100))
BigDecimal taxAmountIncluded =
itemAmount.subtract(itemAmount.divide(BigDecimal.ONE.add(taxRate.divide(PERCENT_SCALE,
4, BigDecimal.ROUND_HALF_UP)), 3, BigDecimal.ROUND_HALF_UP));
taxAdjValue.set("amountAlreadyIncluded", taxAmountIncluded);
taxAdjValue.set("amount", BigDecimal.ZERO);
} else {
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
taxAdjValue.set("amount", taxAmount);
}
> Pricing error in Variant Products when setup with VAT-Tax and price set on
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
> Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual-
> variant- products and the price is defined only on the virtual product and
> with "Tax in Price" set to "Y", its variants should inherit the set price
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product
> is added to the shopping cart. Currently sales-tax is added to the product
> price.
> Here is a detailed procedure to
[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343728#comment-15343728 ] Ankush Upadhyay edited comment on OFBIZ-6576 at 6/22/16 5:36 AM: - Thanks [~Peter Arnold] for reporting the issue and research notes. I have also noticed the same issue and about to going to create JIRA ticket for the same to provide the solution. But it seems instead of duplicating tickets I am attaching the patch to provide the generic and correct fix for this issue. Solution summary: If we did not find the product price on the variant level then the system should lookup it on virtual level instead of returning the error or skip the workflow. [~Peter Arnold] The solution you adopting is not recommended solution, in that case, you can't create sales tax adjustment anymore in system. Please review the changes and let me know if anything else needs to be taken care under this. was (Author: ankush.upadhyay): Thanks [~Peter Arnold] for reporting the issue and research notes. I have also noticed the same issue and about to going to create JIRA ticket for the same to provide the solution. But it seems instead of duplicating tickets I am attaching patch to fix this issue. Please review the changes and let me know if anything else need to be taken care under this. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on
[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702919#comment-14702919 ] Sharan Foga edited comment on OFBIZ-6576 at 8/20/15 9:14 AM: - Hi Jacques - I have run a test on 12.04 and yes it has the same error. Thanks was (Author: sharan ): Hi Jacques - I will run a test on 12.04 and let you know. Thanks Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product -- Key: OFBIZ-6576 URL: https://issues.apache.org/jira/browse/OFBIZ-6576 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk Reporter: Peter Arnold Priority: Minor Fix For: 14.12.01, 13.07.03, Upcoming Branch In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- variant- products and the price is defined only on the virtual product and with Tax in Price set to Y, its variants should inherit the set price without adding any further taxes. This is currently not the case when in the e-commerce shop a variant product is added to the shopping cart. Currently sales-tax is added to the product price. Here is a detailed procedure to reproduce the error: In Party Manager: 1. Create new Party Group with Name SII_CHL (Leave all settings for group creation as per standard) 2. Assign Role Tax Authority to party SII_CHL In Accounting Module / Tax Autorities: 3. Create New Tax Authority with following settings: Geo:CHL Party: SII_CHL Include Tax in Price: Y Leave other setting as is 4. Under Product Rates create new tax with following settings: Type: Value Added Tax Tax Percentage: 19 From Date: Now Leave other settings as is 5. Expire the Sales Tax created under tax authority _NA_ by setting its corresponding thru date to NOW. 6. Under Catalog Manager / Stores: Modify following Settings for OFBiz Ecommerce Store (ID:9000) Tax settings: Show Prices with VAT tax included: Y VAT Tax Auth Geo Id: CHL VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the created Tax Authority SII_CHL) 7. Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all thru-dates to NOW 8. Under Catalog Manager / Products: Create New Product with following settings: Internal Name: T-Shirt Is Virtual Product: Y 9. Under Catalog Manager / Products / Categories Assign the virtual product T-Shirt to the products category ID 200 (Widgets) - Product Category ID: 200 - From Date: Now Add 10 Under Catalog Manager / Products / Content In override Simple Fields Set Product Name to: T-Shirt Virtual Update 11. Under Catalog Manager / Features: Create New Feature Category. - Description: T-Shirt Colors Submit 12. Create new Feature within feature Category T-Shirt Colors: Create New Feature - Feature Type: Color - Description: Red Update Create New Feature - Feature Type: Color - Description: Blue Update 13. Create 2 variant products under the virtual product T-Shirt Under Catalog Manager / Products Find T-Shirt Product Once T-Shirt Product is selected: Press Features Tab Under Add product features from Category or Group - Choose T-Shirt Colors Category - Feature Application Type: Selectable Add Screen with Blue and Red T-Shirt Colors appears. Set for both colors From Date: Now Sequence:1 for blue Sequence:2 for red Set a tick on each feature in order to select the feature for adding it. Apply 14. Under Catalog Manager / Products with T-Shirt virtual product selected press the Variants tab The Quick add Variants screen appears. Define Product IDs for Blue and Red features. Blue: T-Shirt Blue Red: T-Shirt Red Set tick on both features in order to select for variant product creation. Create 15. Under Catalog Manager / Products / Prices set 2 new product prices for the created virtual product T-Shirt: - Default Price - From Date: Now - Price: 11.9 - Tax Percentage: 19 - Tax in price: Y Create - List Price - From Date: Now - Price: 11.9 - Tax Percentage: 19 - Tax in price: Y Create Now the products should be visible in
