[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264599#comment-13264599 ] Jacques Le Roux commented on OFBIZ-4602: OK, for now at r1331996 I commented out the line element.setAttribute(name, GenericEntity.NULL_FIELD.toString()); It's not a complete solution and induces more problems thant it solves (notably in RuntimeData for jobs), to be continued... > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1361#comment-1361 ] Nicolas Malin commented on OFBIZ-4602: -- Hi Jacques, I tested the entity-sync process, and I confirm the [null-field] break it when an entity field is an other type that String. I not solve it, I will check it if I need implement the entity-sync. > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216813#comment-13216813 ] Jacques Le Roux commented on OFBIZ-4602: I let some links here for future possible work: https://fisheye6.atlassian.com/changelog/ofbiz?cs=141 https://fisheye6.atlassian.com/changelog/ofbiz?cs=1226065 https://fisheye6.atlassian.com/changelog/ofbiz?cs=1243026 > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216812#comment-13216812 ] Jacques Le Roux commented on OFBIZ-4602: OK, I did not get enough time to completly look at it yet. But I doubt using simply an xsi:nil attribute will solve the problem. Because nullFied (and "[null-field]") has been introduced because of issues with null in (at least) Freemarker... I believe the issue I crossed and reported above, has actually been solved by r1226065. Divesh, did you test if the same (r1226065) solved your issue? > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207559#comment-13207559 ] Jacques Le Roux commented on OFBIZ-4602: Thanks for repor Alexander, Unfortunately I don't expect to have a new look before this weekend. Reverting all from start seems the easier way. But I hope to rather follow the same way I did in r1243026 (which is only related to web services and not general) > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207278#comment-13207278 ] Alexander Reelsen commented on OFBIZ-4602: -- Hi some parts of this patch seem to have broken services in the job_sandbox. Suddenly the runtime_data entity with its XML based runtimeInfo field is filled with tons of entity values called foo="[null-field]" which are not serialized back into null, but rather is written as "[null-field]" into the database. Not too cool to cleanup... --Alexander > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206083#comment-13206083 ] Jacques Le Roux commented on OFBIZ-4602: At [r1243026|http://svn.apache.org/viewvc?view=revision&revision=1243026] I introduced the use of the xsi:nil attribute. More to come, but unfortunately not this week I think... > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[
https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200820#comment-13200820
]
Jacques Le Roux commented on OFBIZ-4602:
Paul,
Thanks to mention the nillable possiblity. Actually, for 2 weeks, I'm
considering to use it also in another case but have still to test the changes I
did in ModelService.getTypes(). This other case is not directly related. It's
when you use an exported service (SOAP) which may return null elements (in my
case a list of maps where some elements may be null). When you try to
unmarshall the SOAP response from CXF side you get an error like
{code}
Unmarshalling Error: unexpected element
(uri:"http://ofbiz.apache.org/service/";, local:"null")
{code}
As soon as I will have fixed this, I hope to have a better experience of
setting nillable attributes and I will consider to use it also in the case at
hand.
Divesh,
So it's a WIP and I don't want to revert anything for now. If you have an issue
with your production system and have not yet reverted the 2 changes above then
you may consider to do it in the meantime. Of course, I expect to fix that soon
(this week) ... Sorry for the inconvenient...
> Null values are not synchronized in http mode
> -
>
> Key: OFBIZ-4602
> URL: https://issues.apache.org/jira/browse/OFBIZ-4602
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release
> 10.04, SVN trunk
> Environment: Using entity synchronization over HTTP (not RMI)
>Reporter: Patrick Antivackis
>Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch
> 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is
> Xml serializing the values. GenericValue xml serialization is managed in
> GenericEntity.makeXmlElement, unfortunately this method just don't serialized
> null valued fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200818#comment-13200818 ] Jacques Le Roux commented on OFBIZ-4602: Hi Divesh, Sure, I'm looking at it... > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[
https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200574#comment-13200574
]
Divesh Dutta commented on OFBIZ-4602:
-
Hello Jacques,
I was testing credit card transactions and found that in some specific cases,
paymentgateway responses are not getting saved. This is due to commits: trunk
r1226055
R11.04 r1226056
To explain issue in more detail. When we place an Order, and then edit order,
and add additional adjustment in Order (say additional shipping and handling.)
Now order is authorized with original amount . And we set flag
ProductStore.shipIfCaptureFails to "Y". Now when we fulfill Order, original
amount is captured but additional amount is not yet captured. So
ProductStore.shipIfCaptureFails works in PaymentGatewayServices and return
error as total amount is not captured yet.
Now when this error is returned, Original amount is captured by Credit Card but
it is not logged in OFBiz.
Reason behind above bug:
In savePgr method of PaymentGatewayServices,
{code}
dispatcher.addRollbackService("savePaymentGatewayResponse", context, true);
{code}
is written. So this gets triggered when captureOrderPayments return error due
to flag ProductStore.shipIfCaptureFails. But above code does not work
successfully. Because it schedules a job. And RuntimeData is prepared for this
job and "runTimeInfo" is created where xml value of PaymentGatewayResponse is
prepared and saved. But when this job gets executed, it fails because it tries
to save "null-field" String for fields which are actually null.
Now because of this we are facing trouble in our current Production systems as
we are using 11.04 . It will be great if you look into this and fix this.
> Null values are not synchronized in http mode
> -
>
> Key: OFBIZ-4602
> URL: https://issues.apache.org/jira/browse/OFBIZ-4602
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release
> 10.04, SVN trunk
> Environment: Using entity synchronization over HTTP (not RMI)
>Reporter: Patrick Antivackis
>Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch
> 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is
> Xml serializing the values. GenericValue xml serialization is managed in
> GenericEntity.makeXmlElement, unfortunately this method just don't serialized
> null valued fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
Thanks Paul, But once again, please put directly your comments in the Jiras issues. It's much easier to follow the convo later than to have this, either in OFBiz dev ML, or as it seems you did in the nabble forum, which is actually nothing else than an "easier to use" duplicate of the OFBiz dev ML (I put quote because most of us actually prefer to use an email client which has much features, like folders filters, etc. I put myself your comment in the Jira for this time (did already for another one) and will continue the convo there. HTH Jacques From: "Paul Foxworthy" Hi all, There is a canonical way from the XML standards to express that an XML element is null. Rather than reserving a special value for the data within the element, there's a special *attribute* xsi:nil. Schemas can define a corresponding nillable attribute to say it is possible for an element to use the xsi:nil attribute. Given the problems we've been having with this Jira issue, would using xsi:nil be a good idea? The only disadvantage I can see is that this solution only works when we are serializing and deserializing to and from XML. We would need to solve the problem all over again for other serialization formats. See http://www.w3.org/TR/xmlschema-0/#Nils and http://docstore.mik.ua/orelly/xml/schema/ch11_03.htm . Cheers Paul Foxworthy -- View this message in context: http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-4602-Null-values-are-not-synchronized-in-http-mode-tp4145573p4356519.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[
https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200531#comment-13200531
]
Jacques Le Roux commented on OFBIZ-4602:
Paul Foxworthy on dev ML
{quote}
There is a canonical way from the XML standards to express that an XML
element is null. Rather than reserving a special value for the data within
the element, there's a special *attribute* xsi:nil. Schemas can define a
corresponding nillable attribute to say it is possible for an element to use
the xsi:nil attribute.
Given the problems we've been having with this Jira issue, would using
xsi:nil be a good idea? The only disadvantage I can see is that this
solution only works when we are serializing and deserializing to and from
XML. We would need to solve the problem all over again for other
serialization formats.
See http://www.w3.org/TR/xmlschema-0/#Nils and
http://docstore.mik.ua/orelly/xml/schema/ch11_03.htm .
{quote}
> Null values are not synchronized in http mode
> -
>
> Key: OFBIZ-4602
> URL: https://issues.apache.org/jira/browse/OFBIZ-4602
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release
> 10.04, SVN trunk
> Environment: Using entity synchronization over HTTP (not RMI)
>Reporter: Patrick Antivackis
>Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch
> 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is
> Xml serializing the values. GenericValue xml serialization is managed in
> GenericEntity.makeXmlElement, unfortunately this method just don't serialized
> null valued fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
Hi all, There is a canonical way from the XML standards to express that an XML element is null. Rather than reserving a special value for the data within the element, there's a special *attribute* xsi:nil. Schemas can define a corresponding nillable attribute to say it is possible for an element to use the xsi:nil attribute. Given the problems we've been having with this Jira issue, would using xsi:nil be a good idea? The only disadvantage I can see is that this solution only works when we are serializing and deserializing to and from XML. We would need to solve the problem all over again for other serialization formats. See http://www.w3.org/TR/xmlschema-0/#Nils and http://docstore.mik.ua/orelly/xml/schema/ch11_03.htm . Cheers Paul Foxworthy -- View this message in context: http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-4602-Null-values-are-not-synchronized-in-http-mode-tp4145573p4356519.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199868#comment-13199868 ] Jacques Le Roux commented on OFBIZ-4602: I finally did not create an issue for JobManager.reloadCrashedJobs() where I wanted to continue in the loop when a job has maxRetry set to 0. I believe this case appears (mostly?) when you have multiples instances running on the same DB. So I think it's better to handle this case using unique.instanceId in general.properties. The reason I made this choice is because I'm afraid that else we could prevent to reload running (ie crashed) jobs and hence miss them completly. Though I still wonder why I got those issues locally with demo instances running on their own DBs... > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190924#comment-13190924 ] Jacques Le Roux commented on OFBIZ-4602: Note that stopped in a non normal way, is not quite clear to me. I observed issues in at least 2 cases: many machines on the same jobs thread-pool, sole machine on Windows where you stop either by ctrl+C or directly by UI (X button). > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177989#comment-13177989 ] Jacques Le Roux commented on OFBIZ-4602: After some other issues, I completed in trunk r1226065 R11.04 r1226067 R10.04 r1226068 R09.04 r1226066 R4.0 r12260670 I better understand Patrick's answer to the issue now... > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177976#comment-13177976 ] Jacques Le Roux commented on OFBIZ-4602: Last sentence above is for you Patrick, as I guess anybody else ever used such thing so far... Thanks for the try ;), and thanks to Adrian for support :) > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177667#comment-13177667 ] Jacques Le Roux commented on OFBIZ-4602: Ankit just told me that, as I supposed, he crossed many more issues with this patch... So yes, it's not a solution at all... > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177214#comment-13177214 ] Jacques Le Roux commented on OFBIZ-4602: Also Patrick, Could you confirm that the fix you proposed solved the issue you crossed? Did you do any changes on entity sync clients side? > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177212#comment-13177212 ] Jacques Le Roux commented on OFBIZ-4602: Hi Adrian, Yes I think you are quite right, indeed GenericEntity.NULL_FIELD.toString() sounds like the best answer. I will try to see if it does not disrupt the same than OFBIZ-4637 and will have a look also at the entity sync clients side. Of course your help, Patrick, would be greatly appreciated... > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, SVN trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux > Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch > 10.04, Release Branch 11.04, SVN trunk > > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4602) Null values are not synchronized in http mode
[
https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177159#comment-13177159
]
Adrian Crum commented on OFBIZ-4602:
As I mentioned on the dev mailing list, this patch and this "solution" does not
make sense. It would be best to understand the problem thoroughly so that a
proper solution can be designed.
If I understand correctly, the problem that needs to be solved is this: OFBiz
does not serialize field values that are null. That causes a problem with
entity sync, because a field's value might have changed from non-null to null.
Since null field values are not serialized, the change is not propagated to the
entity sync clients.
So, we need a way to serialize null field values. The patch does this by
serializing a null value as the String "null". But the patch only does that for
field data types that are not String. Why are String fields excluded?
>From my perspective, null field values should be tokenized and the token
>should be serialized - in ALL fields, not just non-String fields. A good
>candidate for the token would be GenericEntity.NULL_FIELD.
So, the change to GenericEntity.java line 1079 could look something like this:
{code}
} else {
element.setAttribute(name, GenericEntity.NULL_FIELD.toString());
}
{code}
Now null field values are serialized in a predictable manner. But that change
could adversely impact other modes of entity serialization. Also, entity sync
clients will need to be updated to unmarshall the null value tokens.
> Null values are not synchronized in http mode
> -
>
> Key: OFBIZ-4602
> URL: https://issues.apache.org/jira/browse/OFBIZ-4602
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release
> 10.04, SVN trunk
> Environment: Using entity synchronization over HTTP (not RMI)
>Reporter: Patrick Antivackis
>Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch
> 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is
> Xml serializing the values. GenericValue xml serialization is managed in
> GenericEntity.makeXmlElement, unfortunately this method just don't serialized
> null valued fields.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
