[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504697#comment-14504697 ] Jacopo Cappellato commented on OFBIZ-6268: -- I am not aware of any code dependencies (there are a few in the loader configurations in start.properties) but that is a config file. Just out of curiosity, did you measure how much this change will improve performance at startup? (in terms of milliseconds) Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504708#comment-14504708 ] Jacopo Cappellato commented on OFBIZ-6268: -- The fact that this patch didn't change the class loader tree is a good thing! Thanks. Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[
https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504682#comment-14504682
]
Jacopo Cappellato commented on OFBIZ-6268:
--
Thank you Adrian.
What I don't like about this new approach is that it adds to the
framework/start module a dependency on the inner layout of the base
component:
{code}
classPath.addComponent(ofbizHomeTmp.concat(framework/base/config));
classPath.addComponent(ofbizHomeTmp.concat(framework/base/dtd));
classPath.addFilesFromPath(new
File(ofbizHomeTmp.concat(framework/base/lib)));
classPath.addFilesFromPath(new
File(ofbizHomeTmp.concat(framework/base/lib/commons)));
classPath.addComponent(ofbizHomeTmp.concat(framework/base/build/lib/ofbiz-base.jar));
{code}
while with the current code the dependency is just on the layout of the OFBiz
folder:
{code}
collectClasspathEntries(new File(home, framework), classPath,
libraryPath);
collectClasspathEntries(new File(home, applications), classPath,
libraryPath);
collectClasspathEntries(new File(home, specialpurpose), classPath,
libraryPath);
collectClasspathEntries(new File(home, hot-deploy), classPath,
libraryPath);
{code}
Moreover, does the new code introduce any changes to the ClassLoader tree?
(i.e. a new ClassLoader in the parent-child path)
I am asking because it is difficult for me to figure out by reviewing the patch.
If it adds new levels, even if this is not a big deal, then we should decide if
it is worth to improve startup performance and penalize runtime performance
(both by tiny fractions).
Improve Start.java Component Loading
Key: OFBIZ-6268
URL: https://issues.apache.org/jira/browse/OFBIZ-6268
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Upcoming Branch
Reporter: Adrian Crum
Priority: Minor
Attachments: OFBIZ-6268.patch
The current code for loading components parses configuration files twice.
This issue is intended for review of code improvements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504710#comment-14504710 ] Adrian Crum commented on OFBIZ-6268: Let's back up for a second. I understand the changes you made and why you made them. The problem is with your implementation - you caused the same files to be parsed twice. I am merely removing the double parsing, your other changes (and your intent) are intact. It would help if you applied the patch and actually looked at the code. Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504688#comment-14504688 ] Adrian Crum commented on OFBIZ-6268: The start component has many dependencies on base - there is no way to avoid that. Keep in mind that start used to be IN base. No changes have been made to the class loader tree. Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504702#comment-14504702 ] Jacopo Cappellato commented on OFBIZ-6268: -- Moreover, the code that you have removed was honoring the classpath entries defined in the base component (ofbiz-component.xml) rather than just relying in the folder layout of it. Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[
https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504792#comment-14504792
]
Jacopo Cappellato commented on OFBIZ-6268:
--
This is indeed a good point and a good idea for an improvement.
The current code that does this:
{code}
collectClasspathEntries(new File(home, framework), classPath,
libraryPath);
collectClasspathEntries(new File(home, applications), classPath,
libraryPath);
collectClasspathEntries(new File(home, specialpurpose), classPath,
libraryPath);
collectClasspathEntries(new File(home, hot-deploy), classPath,
libraryPath);
{code}
should instead look at the content of the component-loader file you mention; I
didn't think about it when I have implemented the code.
Improve Start.java Component Loading
Key: OFBIZ-6268
URL: https://issues.apache.org/jira/browse/OFBIZ-6268
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Upcoming Branch
Reporter: Adrian Crum
Priority: Minor
Attachments: OFBIZ-6268.patch
The current code for loading components parses configuration files twice.
This issue is intended for review of code improvements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[
https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504780#comment-14504780
]
Adrian Crum commented on OFBIZ-6268:
Btw, in the current trunk, if I disable the specialpurpose folder
{code}
component-loader xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/component-loader.xsd;
load-components parent-directory=framework/
load-components parent-directory=themes/
load-components parent-directory=applications/
!--
load-components parent-directory=specialpurpose/
--
load-components parent-directory=hot-deploy/
/component-loader
{code}
the specialpurpose component class paths are loaded anyway.
Improve Start.java Component Loading
Key: OFBIZ-6268
URL: https://issues.apache.org/jira/browse/OFBIZ-6268
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Upcoming Branch
Reporter: Adrian Crum
Priority: Minor
Attachments: OFBIZ-6268.patch
The current code for loading components parses configuration files twice.
This issue is intended for review of code improvements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
